Remove some out of date comments.

[wxWidgets.git] / src / msw / settings.cpp

diff --git a/src/msw/settings.cpp b/src/msw/settings.cpp
index 602d3f8e6209762ff8574b0f0971fd393ca8686b..4fbc2299f64f2582b02f437e05bee9374dddaef3 100644 (file)
--- a/src/msw/settings.cpp
+++ b/src/msw/settings.cpp
@@ -1,5 +1,5 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        msw/settings.cpp
+// Name:        src/msw/settings.cpp

 // Purpose:     wxSystemSettingsNative implementation for MSW
 // Author:      Julian Smart
 // Modified by:
 // Purpose:     wxSystemSettingsNative implementation for MSW
 // Author:      Julian Smart
 // Modified by:


@@ -24,25 +24,24 @@
     #pragma hdrstop
 #endif
 
     #pragma hdrstop
 #endif
 

+#include "wx/settings.h"
+

 #ifndef WX_PRECOMP
     #include "wx/utils.h"
     #include "wx/gdicmn.h"
 #ifndef WX_PRECOMP
     #include "wx/utils.h"
     #include "wx/gdicmn.h"

+    #include "wx/module.h"

 #endif
 
 #endif
 

-#include "wx/settings.h"
-

 #include "wx/msw/private.h"
 #include "wx/msw/private.h"

+#include "wx/msw/missing.h" // for SM_CXCURSOR, SM_CYCURSOR, SM_TABLETPC
+#include "wx/msw/private/metrics.h"

 
 #ifndef SPI_GETFLATMENU
 #define SPI_GETFLATMENU                     0x1022
 #endif
 
 
 #ifndef SPI_GETFLATMENU
 #define SPI_GETFLATMENU                     0x1022
 #endif
 

-#include "wx/module.h"

 #include "wx/fontutil.h"
 #include "wx/fontutil.h"

-
-#ifdef __WXWINCE__ // for SM_CXCURSOR and SM_CYCURSOR
-#include "wx/msw/wince/missing.h"
-#endif // __WXWINCE__
+#include "wx/fontenum.h"

 
 // ----------------------------------------------------------------------------
 // private classes
 
 // ----------------------------------------------------------------------------
 // private classes


@@ -92,8 +91,7 @@ bool wxSystemSettingsModule::OnInit()
 
 void wxSystemSettingsModule::OnExit()
 {
 
 void wxSystemSettingsModule::OnExit()
 {

-    delete gs_fontDefault;
-    gs_fontDefault = NULL;
+    wxDELETE(gs_fontDefault);

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -130,7 +128,17 @@ wxColour wxSystemSettingsNative::GetColour(wxSystemColour index)
         0,          // MENUBAR (unused)
     };
 
         0,          // MENUBAR (unused)
     };
 

-    if ( index == wxSYS_COLOUR_LISTBOX )
+    if ( index == wxSYS_COLOUR_LISTBOXTEXT)
+    {
+        // there is no standard colour with this index, map to another one
+        index = wxSYS_COLOUR_WINDOWTEXT;
+    }
+    else if ( index == wxSYS_COLOUR_LISTBOXHIGHLIGHTTEXT)
+    {
+        // there is no standard colour with this index, map to another one
+        index = wxSYS_COLOUR_HIGHLIGHTTEXT;
+    }
+    else if ( index == wxSYS_COLOUR_LISTBOX )

     {
         // there is no standard colour with this index, map to another one
         index = wxSYS_COLOUR_WINDOW;
     {
         // there is no standard colour with this index, map to another one
         index = wxSYS_COLOUR_WINDOW;


@@ -172,7 +180,7 @@ wxColour wxSystemSettingsNative::GetColour(wxSystemColour index)
                         index = wxSYS_COLOUR_MENU ;
                 }
             }
                         index = wxSYS_COLOUR_MENU ;
                 }
             }

-       }
+        }

 
         if ( useDefault )
         {
 
         if ( useDefault )
         {


@@ -189,7 +197,7 @@ wxColour wxSystemSettingsNative::GetColour(wxSystemColour index)
                 unsigned int n = index - wxSYS_COLOUR_BTNHIGHLIGHT;
 
                 wxASSERT_MSG( n < WXSIZEOF(s_defaultSysColors),
                 unsigned int n = index - wxSYS_COLOUR_BTNHIGHLIGHT;
 
                 wxASSERT_MSG( n < WXSIZEOF(s_defaultSysColors),

-                              _T("forgot tp update the default colours array") );
+                              wxT("forgot tp update the default colours array") );

 
                 colSys = s_defaultSysColors[n];
                 hasCol = true;
 
                 colSys = s_defaultSysColors[n];
                 hasCol = true;


@@ -206,7 +214,9 @@ wxColour wxSystemSettingsNative::GetColour(wxSystemColour index)
 #endif
     }
 
 #endif
     }
 

-    return wxRGBToColour(colSys);
+    wxColour ret = wxRGBToColour(colSys);
+    wxASSERT(ret.IsOk());
+    return ret;

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -225,12 +235,6 @@ wxFont wxCreateFontFromStockObject(int index)
         {
             wxNativeFontInfo info;
             info.lf = lf;
         {
             wxNativeFontInfo info;
             info.lf = lf;

-            // We want Windows 2000 or later to have new fonts even MS Shell Dlg
-            // is returned as default GUI font for compatibility
-            int verMaj;
-            if(index == DEFAULT_GUI_FONT && wxGetOsVersion(&verMaj) == wxWINDOWS_NT && verMaj >= 5)
-                wxStrcpy(info.lf.lfFaceName, wxT("MS Shell Dlg 2"));
-

             // Under MicroWindows we pass the HFONT as well
             // because it's hard to convert HFONT -> LOGFONT -> HFONT
             // It's OK to delete stock objects, the delete will be ignored.
             // Under MicroWindows we pass the HFONT as well
             // because it's hard to convert HFONT -> LOGFONT -> HFONT
             // It's OK to delete stock objects, the delete will be ignored.


@@ -242,12 +246,12 @@ wxFont wxCreateFontFromStockObject(int index)
         }
         else
         {
         }
         else
         {

-            wxFAIL_MSG( _T("failed to get LOGFONT") );
+            wxFAIL_MSG( wxT("failed to get LOGFONT") );

         }
     }
     else // GetStockObject() failed
     {
         }
     }
     else // GetStockObject() failed
     {

-        wxFAIL_MSG( _T("stock font not found") );
+        wxFAIL_MSG( wxT("stock font not found") );

     }
 
     return font;
     }
 
     return font;


@@ -264,24 +268,39 @@ wxFont wxSystemSettingsNative::GetFont(wxSystemFont index)
         gs_fontDefault = new wxFont(wxCreateFontFromStockObject(SYSTEM_FONT));
     }
 
         gs_fontDefault = new wxFont(wxCreateFontFromStockObject(SYSTEM_FONT));
     }
 

+    wxASSERT(gs_fontDefault->IsOk() &&
+             wxFontEnumerator::IsValidFacename(gs_fontDefault->GetFaceName()));

     return *gs_fontDefault;
 #else // !__WXWINCE__
     // wxWindow ctor calls GetFont(wxSYS_DEFAULT_GUI_FONT) so we're
     // called fairly often -- this is why we cache this particular font
     return *gs_fontDefault;
 #else // !__WXWINCE__
     // wxWindow ctor calls GetFont(wxSYS_DEFAULT_GUI_FONT) so we're
     // called fairly often -- this is why we cache this particular font

-    const bool isDefaultRequested = index == wxSYS_DEFAULT_GUI_FONT;
-    if ( isDefaultRequested )
+    if ( index == wxSYS_DEFAULT_GUI_FONT )

     {
     {

-        if ( gs_fontDefault )
-            return *gs_fontDefault;
+        if ( !gs_fontDefault )
+        {
+            // http://blogs.msdn.com/oldnewthing/archive/2005/07/07/436435.aspx
+            // explains why neither SYSTEM_FONT nor DEFAULT_GUI_FONT should be
+            // used here
+            //
+            // the message box font seems to be the one which should be used
+            // for most (simple) controls, e.g. buttons and such but other
+            // controls may prefer to use lfStatusFont or lfCaptionFont if it
+            // is more appropriate for them
+            wxNativeFontInfo info;
+            info.lf = wxMSWImpl::GetNonClientMetrics().lfMessageFont;
+            gs_fontDefault = new wxFont(info);
+        }
+
+        return *gs_fontDefault;

     }
 
     wxFont font = wxCreateFontFromStockObject(index);
 
     }
 
     wxFont font = wxCreateFontFromStockObject(index);
 

-    if ( isDefaultRequested )
-    {
-        // if we got here it means we hadn't cached it yet - do now
-        gs_fontDefault = new wxFont(font);
-    }
+    wxASSERT(font.IsOk());
+
+#if wxUSE_FONTENUM
+    wxASSERT(wxFontEnumerator::IsValidFacename(font.GetFaceName()));
+#endif // wxUSE_FONTENUM

 
     return font;
 #endif // __WXWINCE__/!__WXWINCE__
 
     return font;
 #endif // __WXWINCE__/!__WXWINCE__


@@ -309,8 +328,12 @@ static const int gs_metricsMap[] =
 
     SM_CXBORDER,
     SM_CYBORDER,
 
     SM_CXBORDER,
     SM_CYBORDER,

+#ifdef SM_CXCURSOR

     SM_CXCURSOR,
     SM_CYCURSOR,
     SM_CXCURSOR,
     SM_CYCURSOR,

+#else
+    -1, -1,
+#endif

     SM_CXDOUBLECLK,
     SM_CYDOUBLECLK,
 #if defined(__WIN32__) && defined(SM_CXDRAG)
     SM_CXDOUBLECLK,
     SM_CYDOUBLECLK,
 #if defined(__WIN32__) && defined(SM_CXDRAG)


@@ -350,7 +373,7 @@ static const int gs_metricsMap[] =
     -1, -1, -1, -1,
 #endif
     SM_CYHSCROLL,
     -1, -1, -1, -1,
 #endif
     SM_CYHSCROLL,

-    SM_CXVSCROLL,
+    SM_CXHSCROLL,

     SM_CXVSCROLL,
     SM_CYVSCROLL,
 #ifdef SM_CYVTHUMB
     SM_CXVSCROLL,
     SM_CYVSCROLL,
 #ifdef SM_CYVTHUMB


@@ -375,11 +398,14 @@ static const int gs_metricsMap[] =
 #else
     -1,
 #endif
 #else
     -1,
 #endif

+    // SM_SWAPBUTTON is not available under CE and it doesn't make sense to ask
+    // for it there

 #ifdef SM_SWAPBUTTON
     SM_SWAPBUTTON,
 #else
 #ifdef SM_SWAPBUTTON
     SM_SWAPBUTTON,
 #else

-    -1
+    -1,

 #endif
 #endif

+    -1   // wxSYS_DCLICK_MSEC - not available as system metric

 };
 
 // Get a system metric, e.g. scrollbar size
 };
 
 // Get a system metric, e.g. scrollbar size


@@ -390,7 +416,13 @@ int wxSystemSettingsNative::GetMetric(wxSystemMetric index, wxWindow* WXUNUSED(w
     return 0;
 #else // !__WXMICROWIN__
     wxCHECK_MSG( index > 0 && (size_t)index < WXSIZEOF(gs_metricsMap), 0,
     return 0;
 #else // !__WXMICROWIN__
     wxCHECK_MSG( index > 0 && (size_t)index < WXSIZEOF(gs_metricsMap), 0,

-                 _T("invalid metric") );
+                 wxT("invalid metric") );
+
+    if ( index == wxSYS_DCLICK_MSEC )
+    {
+        // This one is not a Win32 system metric
+        return ::GetDoubleClickTime();
+    }

 
     int indexMSW = gs_metricsMap[index];
     if ( indexMSW == -1 )
 
     int indexMSW = gs_metricsMap[index];
     if ( indexMSW == -1 )


@@ -418,8 +450,11 @@ bool wxSystemSettingsNative::HasFeature(wxSystemFeature index)
         case wxSYS_CAN_DRAW_FRAME_DECORATIONS:
             return true;
 
         case wxSYS_CAN_DRAW_FRAME_DECORATIONS:
             return true;
 

+        case wxSYS_TABLET_PRESENT:
+            return ::GetSystemMetrics(SM_TABLETPC) != 0;
+

         default:
         default:

-            wxFAIL_MSG( _T("unknown system feature") );
+            wxFAIL_MSG( wxT("unknown system feature") );

 
             return false;
     }
 
             return false;
     }


@@ -442,12 +477,12 @@ extern wxFont wxGetCCDefaultFont()
     int verMaj, verMin;
     switch ( wxGetOsVersion(&verMaj, &verMin) )
     {
     int verMaj, verMin;
     switch ( wxGetOsVersion(&verMaj, &verMin) )
     {

-        case wxWIN95:
+        case wxOS_WINDOWS_9X:

             // 4.10 is Win98
             useIconFont = verMaj == 4 && verMin >= 10;
             break;
 
             // 4.10 is Win98
             useIconFont = verMaj == 4 && verMin >= 10;
             break;
 

-        case wxWINDOWS_NT:
+        case wxOS_WINDOWS_NT:

             // 5.0 is Win2k
             useIconFont = verMaj >= 5;
             break;
             // 5.0 is Win2k
             useIconFont = verMaj >= 5;
             break;


@@ -471,7 +506,7 @@ extern wxFont wxGetCCDefaultFont()
         }
         else
         {
         }
         else
         {

-            wxLogLastError(_T("SystemParametersInfo(SPI_GETICONTITLELOGFONT"));
+            wxLogLastError(wxT("SystemParametersInfo(SPI_GETICONTITLELOGFONT"));

         }
     }
 #endif // __WXWINCE__
         }
     }
 #endif // __WXWINCE__