use WX_ASSERT_STR/SIZET_EQUAL instead of CPPUNIT_ASSERT_EQUAL with casts

[wxWidgets.git] / src / unix / appunix.cpp

diff --git a/src/unix/appunix.cpp b/src/unix/appunix.cpp
index a40991715ab1ab477d938e4e16fd39ac42a34c54..0bca1979a9a7003ee0cde098c62d1bae659f55cf 100644 (file)
--- a/src/unix/appunix.cpp
+++ b/src/unix/appunix.cpp
@@ -15,12 +15,11 @@
 #include <signal.h>
 #include <unistd.h>
 
 #include <signal.h>
 #include <unistd.h>
 

-bool wxAppConsoleUnix::Initialize(int& argc, wxChar** argv)
+// use unusual names for arg[cv] to avoid clashes with wxApp members with the
+// same names
+bool wxAppConsole::Initialize(int& argc_, wxChar** argv_)

 {
 {

-    if ( !wxAppConsole::Initialize(argc,argv) )
-        return false;
-
-    if ( !m_mainLoop->IsOk() )
+    if ( !wxAppConsoleBase::Initialize(argc_, argv_) )

         return false;
 
     sigemptyset(&m_signalsCaught);
         return false;
 
     sigemptyset(&m_signalsCaught);


@@ -28,9 +27,9 @@ bool wxAppConsoleUnix::Initialize(int& argc, wxChar** argv)
     return true;
 }
 
     return true;
 }
 

-void wxAppConsoleUnix::HandleSignal(int signal)
+void wxAppConsole::HandleSignal(int signal)

 {
 {

-    wxAppConsoleUnix * const app = wxTheApp;
+    wxAppConsole * const app = wxTheApp;

     if ( !app )
         return;
 
     if ( !app )
         return;
 


@@ -38,7 +37,7 @@ void wxAppConsoleUnix::HandleSignal(int signal)
     app->WakeUpIdle();
 }
 
     app->WakeUpIdle();
 }
 

-void wxAppConsoleUnix::CheckSignal()
+void wxAppConsole::CheckSignal()

 {
     for ( SignalHandlerHash::iterator it = m_signalHandlerHash.begin();
           it != m_signalHandlerHash.end();
 {
     for ( SignalHandlerHash::iterator it = m_signalHandlerHash.begin();
           it != m_signalHandlerHash.end();


@@ -53,13 +52,23 @@ void wxAppConsoleUnix::CheckSignal()
     }
 }
 
     }
 }
 

-bool wxAppConsoleUnix::SetSignalHandler(int signal, SignalHandler handler)
+// the type of the signal handlers we use is "void(*)(int)" while the real
+// signal handlers are extern "C" and so have incompatible type and at least
+// Sun CC warns about it, so use explicit casts to suppress these warnings as
+// they should be harmless
+extern "C"
+{
+    typedef void (*SignalHandler_t)(int);
+}
+
+bool wxAppConsole::SetSignalHandler(int signal, SignalHandler handler)

 {
 {

-    const bool install = handler != SIG_DFL && handler != SIG_IGN;
+    const bool install = (SignalHandler_t)handler != SIG_DFL &&
+                         (SignalHandler_t)handler != SIG_IGN;

 
     struct sigaction sa;
     memset(&sa, 0, sizeof(sa));
 
     struct sigaction sa;
     memset(&sa, 0, sizeof(sa));

-    sa.sa_handler = &wxAppConsoleUnix::HandleSignal;
+    sa.sa_handler = (SignalHandler_t)&wxAppConsole::HandleSignal;

     sa.sa_flags = SA_RESTART;
     int res = sigaction(signal, &sa, 0);
     if ( res != 0 )
     sa.sa_flags = SA_RESTART;
     int res = sigaction(signal, &sa, 0);
     if ( res != 0 )


@@ -75,3 +84,4 @@ bool wxAppConsoleUnix::SetSignalHandler(int signal, SignalHandler handler)
 
     return true;
 }
 
     return true;
 }

+