wxRegion fixes (off by one)

[wxWidgets.git] / src / msw / window.cpp

diff --git a/src/msw/window.cpp b/src/msw/window.cpp
index 5630b738c63db6c8c1940fe0413a149938fd9ff2..dc8a9563588b2c9bfc6f6f28a06343acb8bf6fd9 100644 (file)
--- a/src/msw/window.cpp
+++ b/src/msw/window.cpp
@@ -2562,7 +2562,10 @@ long wxWindowMSW::MSWWindowProc(WXUINT message, WXWPARAM wParam, WXLPARAM lParam
             break;
 #endif // __WIN32__
 
-#ifdef __WXUNIVERSAL__
+            // unfortunately this doesn't really work as then window which
+            // doesn't accept focus doesn't get any mouse events neither which
+            // means it can't get any input at all
+#if 0 //def __WXUNIVERSAL__
         case WM_NCHITTEST:
             // we shouldn't allow the windows which don't want to get focus to
             // get it
@@ -2692,29 +2695,32 @@ bool wxWindowMSW::MSWGetCreateWindowCoords(const wxPoint& pos,
         nonDefault = TRUE;
     }
 
-    if ( size.x == -1 || size.y == -1 )
+    /*
+      NB: there used to be some code here which set the initial size of the
+          window to the client size of the parent if no explicit size was
+          specified. This was wrong because wxWindows programs often assume
+          that they get a WM_SIZE (EVT_SIZE) upon creation, however this broke
+          it. To see why, you should understand that Windows sends WM_SIZE from
+          inside ::CreateWindow() anyhow. However, ::CreateWindow() is called
+          from some base class ctor and so this WM_SIZE is not processed in the
+          real class' OnSize() (because it's not fully constructed yet and the
+          event goes to some base class OnSize() instead). So the WM_SIZE we
+          rely on is the one sent when the parent frame resizes its children
+          but here is the problem: if the child already has just the right
+          size, nothing will happen as both wxWindows and Windows check for
+          this and ignore any attempts to change the window size to the size it
+          already has - so no WM_SIZE would be sent.
+     */
+    if ( size.x == -1 )
     {
-        // Find parent's size, if it exists, to set up a possible default panel
-        // size the size of the parent window
-        wxWindow *parent = GetParent();
-        if ( parent )
-        {
-            RECT rectParent;
-            ::GetClientRect(GetHwndOf(parent), &rectParent);
-
-            w = size.x == -1 ? rectParent.right - rectParent.left : size.x;
-            h = size.y == -1 ? rectParent.bottom - rectParent.top : size.y;
-        }
-        else
-        {
-            w =
-            h = CW_USEDEFAULT;
-        }
+        // as abobe, h is not used at all in this case anyhow
+        w =
+        h = CW_USEDEFAULT;
     }
     else
     {
         w = size.x;
-        h = size.y;
+        h = size.y == -1 ? CW_USEDEFAULT : size.y;
 
         nonDefault = TRUE;
     }
@@ -2745,7 +2751,7 @@ bool wxWindowMSW::MSWCreate(const wxChar *wclass,
     }
     else // !popup
     {
-        if ( (isChild || (style & WS_POPUPWINDOW)) && parent )
+        if ( (isChild || HasFlag(wxFRAME_TOOL_WINDOW)) && parent )
         {
             // this is either a normal child window or a top level window with
             // wxFRAME_TOOL_WINDOW style (see below)
@@ -2758,8 +2764,7 @@ bool wxWindowMSW::MSWCreate(const wxChar *wclass,
             // style: we should use NULL parent HWND for it or it would be
             // always on top of its parent which is not what we usually want
             // (in fact, we only want it for frames with the special
-            // wxFRAME_TOOL_WINDOW style translated into WS_POPUPWINDOW we test
-            // against above)
+            // wxFRAME_TOOL_WINDOW as above)
             hParent = NULL;
         }