fix the broken code in strftime()

[wxWidgets.git] / src / common / variant.cpp

diff --git a/src/common/variant.cpp b/src/common/variant.cpp
index c38fef7a8d059ba141251c79548ef063079d4fda..870938c773cf025448efc7495f31f03a519dae87 100644 (file)
--- a/src/common/variant.cpp
+++ b/src/common/variant.cpp
@@ -1,5 +1,5 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        variant.cpp
+// Name:        src/common/variant.cpp

 // Purpose:     wxVariant class, container for any type
 // Author:      Julian Smart
 // Modified by:
 // Purpose:     wxVariant class, container for any type
 // Author:      Julian Smart
 // Modified by:


@@ -9,12 +9,6 @@
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
-#pragma implementation "variant.h"
-#pragma implementation "time.h"
-#pragma implementation "date.h"
-#endif
-

 // For compilers that support precompilation, includes "wx/wx.h".
 #include "wx/wxprec.h"
 
 // For compilers that support precompilation, includes "wx/wx.h".
 #include "wx/wxprec.h"
 


@@ -22,6 +16,18 @@
     #pragma hdrstop
 #endif
 
     #pragma hdrstop
 #endif
 

+#include "wx/variant.h"
+
+#if wxUSE_VARIANT
+
+#ifndef WX_PRECOMP
+    #include "wx/string.h"
+    #include "wx/math.h"
+    #if wxUSE_STREAMS
+        #include "wx/stream.h"
+    #endif
+#endif
+

 #if wxUSE_STD_IOSTREAM
     #if wxUSE_IOSTREAMH
         #include <fstream.h>
 #if wxUSE_STD_IOSTREAM
     #if wxUSE_IOSTREAMH
         #include <fstream.h>


@@ -30,290 +36,174 @@
     #endif
 #endif
 
     #endif
 #endif
 

+#if defined(__MWERKS__) && __MSL__ >= 0x6000
+namespace std {}
+using namespace std ;
+#endif
+

 #if wxUSE_STREAMS
 #if wxUSE_STREAMS

-#include "wx/stream.h"
-#include "wx/txtstrm.h"
+    #include "wx/txtstrm.h"

 #endif
 
 #include "wx/string.h"
 #include "wx/tokenzr.h"
 
 #endif
 
 #include "wx/string.h"
 #include "wx/tokenzr.h"
 

-#include "wx/variant.h"
-
-#if wxUSE_TIMEDATE
-IMPLEMENT_DYNAMIC_CLASS(wxDate, wxObject)
-IMPLEMENT_DYNAMIC_CLASS(wxTime, wxObject)
-
-wxTime::tFormat    wxTime::ms_Format    = wxTime::wx12h;
-wxTime::tPrecision wxTime::ms_Precision  = wxTime::wxStdMinSec;
-wxChar             wxTime::ms_bufTime[128];
-#endif
-

 IMPLEMENT_ABSTRACT_CLASS(wxVariantData, wxObject)
 
 IMPLEMENT_ABSTRACT_CLASS(wxVariantData, wxObject)
 

-wxVariant WXDLLEXPORT wxNullVariant;
+wxVariant WXDLLIMPEXP_BASE wxNullVariant;
+

 
 /*
 
 /*

- * wxVariantDataList
+ * wxVariant

  */
 
  */
 

-class WXDLLEXPORT wxVariantDataList: public wxVariantData
-{
-DECLARE_DYNAMIC_CLASS(wxVariantDataList)
-public:
-    wxVariantDataList() {}
-    wxVariantDataList(const wxList& list);
-    ~wxVariantDataList();
-
-    wxList& GetValue() const { return (wxList&) m_value; }
-    void SetValue(const wxList& value) ;
-
-    virtual void Copy(wxVariantData& data);
-    virtual bool Eq(wxVariantData& data) const;
-#if wxUSE_STD_IOSTREAM
-    virtual bool Write(wxSTD ostream& str) const;
-#endif
-    virtual bool Write(wxString& str) const;
-#if wxUSE_STD_IOSTREAM
-    virtual bool Read(wxSTD istream& str);
-#endif
-    virtual bool Read(wxString& str);
-    virtual wxString GetType() const { return wxT("list"); };
-
-    void Clear();
-
-protected:
-    wxList  m_value;
-};
-
-IMPLEMENT_DYNAMIC_CLASS(wxVariantDataList, wxVariantData)
+IMPLEMENT_DYNAMIC_CLASS(wxVariant, wxObject)

 
 

-wxVariantDataList::wxVariantDataList(const wxList& list)
+wxVariant::wxVariant()

 {
 {

-    SetValue(list);
+    m_data = (wxVariantData*) NULL;

 }
 
 }
 

-wxVariantDataList::~wxVariantDataList()
+bool wxVariant::IsNull() const

 {
 {

-    Clear();
+     return (m_data == (wxVariantData*) NULL);

 }
 
 }
 

-void wxVariantDataList::SetValue(const wxList& value)
+void wxVariant::MakeNull()

 {
 {

-    Clear();
-    wxNode* node = value.GetFirst();
-    while (node)
-    {
-        wxVariant* var = (wxVariant*) node->GetData();
-        m_value.Append(new wxVariant(*var));
-        node = node->GetNext();
-    }
+    UnRef();

 }
 
 }
 

-void wxVariantDataList::Clear()
+void wxVariant::Clear()

 {
 {

-    wxNode* node = m_value.GetFirst();
-    while (node)
-    {
-        wxVariant* var = (wxVariant*) node->GetData();
-        delete var;
-        node = node->GetNext();
-    }
-    m_value.Clear();
+    m_name = wxEmptyString;

 }
 
 }
 

-void wxVariantDataList::Copy(wxVariantData& data)
+wxVariant::wxVariant(const wxVariant& variant)
+    : wxObject()

 {
 {

-    wxASSERT_MSG( (data.GetType() == wxT("list")), wxT("wxVariantDataList::Copy: Can't copy to this type of data") );
+    m_data = (wxVariantData*) NULL;

 
 

-    wxVariantDataList& listData = (wxVariantDataList&) data;
+    if (!variant.IsNull())
+        Ref(variant);

 
 

-    listData.Clear();
-    wxNode* node = m_value.GetFirst();
-    while (node)
-    {
-        wxVariant* var = (wxVariant*) node->GetData();
-        listData.m_value.Append(new wxVariant(*var));
-        node = node->GetNext();
-    }
+    m_name = variant.m_name;

 }
 
 }
 

-bool wxVariantDataList::Eq(wxVariantData& data) const
+wxVariant::wxVariant(wxVariantData* data, const wxString& name) // User-defined data

 {
 {

-    wxASSERT_MSG( (data.GetType() == wxT("list")), wxT("wxVariantDataList::Eq: argument mismatch") );
-
-    wxVariantDataList& listData = (wxVariantDataList&) data;
-    wxNode* node1 = m_value.GetFirst();
-    wxNode* node2 = listData.GetValue().GetFirst();
-    while (node1 && node2)
-    {
-        wxVariant* var1 = (wxVariant*) node1->GetData();
-        wxVariant* var2 = (wxVariant*) node2->GetData();
-        if ((*var1) != (*var2))
-            return false;
-        node1 = node1->GetNext();
-        node2 = node2->GetNext();
-    }
-    if (node1 || node2) return false;
-    return true;
+    m_data = data;
+    m_name = name;

 }
 
 }
 

-#if wxUSE_STD_IOSTREAM
-bool wxVariantDataList::Write(wxSTD ostream& str) const
+wxVariant::~wxVariant()

 {
 {

-    wxString s;
-    Write(s);
-    str << (const char*) s.mb_str();
-    return true;
+    UnRef();

 }
 }

-#endif

 
 

-bool wxVariantDataList::Write(wxString& str) const
+// Assignment
+void wxVariant::operator= (const wxVariant& variant)

 {
 {

-    str = wxT("");
-    wxNode* node = m_value.GetFirst();
-    while (node)
-    {
-        wxVariant* var = (wxVariant*) node->GetData();
-        if (node != m_value.GetFirst())
-          str += wxT(" ");
-        wxString str1;
-        str += var->MakeString();
-        node = node->GetNext();
-    }
-
-    return true;
+    Ref(variant);
+    m_name = variant.m_name;

 }
 
 }
 

-#if wxUSE_STD_IOSTREAM
-bool wxVariantDataList::Read(wxSTD istream& WXUNUSED(str))
+// myVariant = new wxStringVariantData("hello")
+void wxVariant::operator= (wxVariantData* variantData)

 {
 {

-    wxFAIL_MSG(wxT("Unimplemented"));
-    // TODO
-    return false;
+    UnRef();
+    m_data = variantData;

 }
 }

-#endif

 
 

-bool wxVariantDataList::Read(wxString& WXUNUSED(str))
+bool wxVariant::operator== (const wxVariant& variant) const

 {
 {

-    wxFAIL_MSG(wxT("Unimplemented"));
-    // TODO
-    return false;
-}
+    if (IsNull() || variant.IsNull())
+        return (IsNull() == variant.IsNull());

 
 

-/*
- * wxVariantDataStringList
- */
+    return (GetData()->Eq(* variant.GetData()));
+}

 
 

-class WXDLLEXPORT wxVariantDataStringList: public wxVariantData
+bool wxVariant::operator!= (const wxVariant& variant) const

 {
 {

-DECLARE_DYNAMIC_CLASS(wxVariantDataStringList)
-public:
-    wxVariantDataStringList() {}
-    wxVariantDataStringList(const wxStringList& list) { m_value = list; }
-
-    wxStringList& GetValue() const { return (wxStringList&) m_value; }
-    void SetValue(const wxStringList& value);
-
-    virtual void Copy(wxVariantData& data);
-    virtual bool Eq(wxVariantData& data) const;
-#if wxUSE_STD_IOSTREAM
-    virtual bool Write(wxSTD ostream& str) const;
-#endif
-    virtual bool Write(wxString& str) const;
-#if wxUSE_STD_IOSTREAM
-    virtual bool Read(wxSTD istream& str);
-#endif
-    virtual bool Read(wxString& str);
-    virtual wxString GetType() const { return wxT("stringlist"); };
-
-protected:
-    wxStringList  m_value;
-};
+    return (!(*this == variant));
+}

 
 

-IMPLEMENT_DYNAMIC_CLASS(wxVariantDataStringList, wxVariantData)

 
 

-void wxVariantDataStringList::SetValue(const wxStringList& value)
+wxString wxVariant::MakeString() const

 {
 {

-    m_value = value;
+    if (!IsNull())
+    {
+        wxString str;
+        if (GetData()->Write(str))
+            return str;
+    }
+    return wxEmptyString;

 }
 
 }
 

-void wxVariantDataStringList::Copy(wxVariantData& data)
+void wxVariant::SetData(wxVariantData* data)

 {
 {

-    wxASSERT_MSG( (data.GetType() == wxT("stringlist")), wxT("wxVariantDataStringList::Copy: Can't copy to this type of data") );
-
-    wxVariantDataStringList& listData = (wxVariantDataStringList&) data;
-
-    listData.m_value = m_value ;
+    UnRef();
+    m_data = data;

 }
 
 }
 

-bool wxVariantDataStringList::Eq(wxVariantData& data) const
+void wxVariant::Ref(const wxVariant& clone)

 {
 {

-    wxASSERT_MSG( (data.GetType() == wxT("stringlist")), wxT("wxVariantDataStringList::Eq: argument mismatch") );
+    // nothing to be done
+    if (m_data == clone.m_data)
+        return;

 
 

-    wxVariantDataStringList& listData = (wxVariantDataStringList&) data;
-    wxStringList::Node  *node1 = m_value.GetFirst();
-    wxStringList::Node  *node2 = listData.GetValue().GetFirst();
-    while (node1 && node2)
+    // delete reference to old data
+    UnRef();
+
+    // reference new data
+    if ( clone.m_data )

     {
     {

-        wxString str1 ( node1->GetData() );
-        wxString str2 ( node2->GetData() );
-        if (str1 != str2)
-            return false;
-        node1 = node1->GetNext();
-        node2 = node2->GetNext();
+        m_data = clone.m_data;
+        m_data->m_count++;

     }
     }

-    if (node1 || node2) return false;
-    return true;

 }
 
 }
 

-#if wxUSE_STD_IOSTREAM
-bool wxVariantDataStringList::Write(wxSTD ostream& str) const
-{
-    wxString s;
-    Write(s);
-    str << (const char*) s.mb_str();
-    return true;
-}
-#endif

 
 

-bool wxVariantDataStringList::Write(wxString& str) const
+void wxVariant::UnRef()

 {
 {

-    str.Empty();
-    wxStringList::Node  *node = m_value.GetFirst();
-    while (node)
+    if ( m_data )

     {
     {

-        wxChar* s = node->GetData();
-        if (node != m_value.GetFirst())
-          str += wxT(" ");
-        str += s;
-        node = node->GetNext();
+        wxASSERT_MSG( m_data->m_count > 0, _T("invalid ref data count") );
+
+        m_data->DecRef();
+        m_data = NULL;

     }
     }

+}

 
 

-    return true;
+
+// Returns a string representing the type of the variant,
+// e.g. "string", "bool", "list", "double", "long"
+wxString wxVariant::GetType() const
+{
+    if (IsNull())
+        return wxString(wxT("null"));
+    else
+        return GetData()->GetType();

 }
 
 }
 

-#if wxUSE_STD_IOSTREAM
-bool wxVariantDataStringList::Read(wxSTD istream& WXUNUSED(str))
+
+bool wxVariant::IsType(const wxString& type) const

 {
 {

-    wxFAIL_MSG(wxT("Unimplemented"));
-    // TODO
-    return false;
+    return (GetType() == type);

 }
 }

-#endif

 
 

-bool wxVariantDataStringList::Read(wxString& WXUNUSED(str))
+bool wxVariant::IsValueKindOf(const wxClassInfo* type) const

 {
 {

-    wxFAIL_MSG(wxT("Unimplemented"));
-    // TODO
-    return false;
+    wxClassInfo* info=GetData()->GetValueClassInfo();
+    return info ? info->IsKindOf(type) : false ;

 }
 
 }
 

-/*
- * wxVariantDataLong
- */

 
 

-class WXDLLEXPORT wxVariantDataLong: public wxVariantData
+// -----------------------------------------------------------------
+// wxVariantDataLong
+// -----------------------------------------------------------------
+
+class WXDLLIMPEXP_BASE wxVariantDataLong: public wxVariantData

 {
 DECLARE_DYNAMIC_CLASS(wxVariantDataLong)
 public:
 {
 DECLARE_DYNAMIC_CLASS(wxVariantDataLong)
 public:


@@ -323,7 +213,6 @@ public:
     inline long GetValue() const { return m_value; }
     inline void SetValue(long value) { m_value = value; }
 
     inline long GetValue() const { return m_value; }
     inline void SetValue(long value) { m_value = value; }
 

-    virtual void Copy(wxVariantData& data);

     virtual bool Eq(wxVariantData& data) const;
 
     virtual bool Read(wxString& str);
     virtual bool Eq(wxVariantData& data) const;
 
     virtual bool Read(wxString& str);


@@ -345,15 +234,6 @@ protected:
 
 IMPLEMENT_DYNAMIC_CLASS(wxVariantDataLong, wxVariantData)
 
 
 IMPLEMENT_DYNAMIC_CLASS(wxVariantDataLong, wxVariantData)
 

-void wxVariantDataLong::Copy(wxVariantData& data)
-{
-    wxASSERT_MSG( (data.GetType() == wxT("long")), wxT("wxVariantDataLong::Copy: Can't copy to this type of data") );
-
-    wxVariantDataLong& otherData = (wxVariantDataLong&) data;
-
-    otherData.m_value = m_value;
-}
-

 bool wxVariantDataLong::Eq(wxVariantData& data) const
 {
     wxASSERT_MSG( (data.GetType() == wxT("long")), wxT("wxVariantDataLong::Eq: argument mismatch") );
 bool wxVariantDataLong::Eq(wxVariantData& data) const
 {
     wxASSERT_MSG( (data.GetType() == wxT("long")), wxT("wxVariantDataLong::Eq: argument mismatch") );


@@ -410,23 +290,82 @@ bool wxVariantDataLong::Read(wxString& str)
     return true;
 }
 
     return true;
 }
 

-/*
- * wxVariantDataReal
- */
+// wxVariant

 
 

-class WXDLLEXPORT wxVariantDataReal: public wxVariantData
+wxVariant::wxVariant(long val, const wxString& name)

 {
 {

-DECLARE_DYNAMIC_CLASS(wxVariantDataReal)
-public:
-    wxVariantDataReal() { m_value = 0.0; }
-    wxVariantDataReal(double value) { m_value = value; }
+    m_data = new wxVariantDataLong(val);
+    m_name = name;
+}

 
 

-    inline double GetValue() const { return m_value; }
-    inline void SetValue(double value) { m_value = value; }
+wxVariant::wxVariant(int val, const wxString& name)
+{
+    m_data = new wxVariantDataLong((long)val);
+    m_name = name;
+}

 
 

-    virtual void Copy(wxVariantData& data);
-    virtual bool Eq(wxVariantData& data) const;
-    virtual bool Read(wxString& str);
+wxVariant::wxVariant(short val, const wxString& name)
+{
+    m_data = new wxVariantDataLong((long)val);
+    m_name = name;
+}
+
+bool wxVariant::operator== (long value) const
+{
+    long thisValue;
+    if (!Convert(&thisValue))
+        return false;
+    else
+        return (value == thisValue);
+}
+
+bool wxVariant::operator!= (long value) const
+{
+    return (!((*this) == value));
+}
+
+void wxVariant::operator= (long value)
+{
+    if (GetType() == wxT("long") &&
+        m_data->GetRefCount() == 1)
+    {
+        ((wxVariantDataLong*)GetData())->SetValue(value);
+    }
+    else
+    {
+        UnRef();
+        m_data = new wxVariantDataLong(value);
+    }
+}
+
+long wxVariant::GetLong() const
+{
+    long value;
+    if (Convert(& value))
+        return value;
+    else
+    {
+        wxFAIL_MSG(wxT("Could not convert to a long"));
+        return 0;
+    }
+}
+
+// -----------------------------------------------------------------
+// wxVariantDoubleData
+// -----------------------------------------------------------------
+
+class WXDLLIMPEXP_BASE wxVariantDoubleData: public wxVariantData
+{
+DECLARE_DYNAMIC_CLASS(wxVariantDoubleData)
+public:
+    wxVariantDoubleData() { m_value = 0.0; }
+    wxVariantDoubleData(double value) { m_value = value; }
+
+    inline double GetValue() const { return m_value; }
+    inline void SetValue(double value) { m_value = value; }
+
+    virtual bool Eq(wxVariantData& data) const;
+    virtual bool Read(wxString& str);

 #if wxUSE_STD_IOSTREAM
     virtual bool Write(wxSTD ostream& str) const;
 #endif
 #if wxUSE_STD_IOSTREAM
     virtual bool Write(wxSTD ostream& str) const;
 #endif


@@ -444,28 +383,19 @@ protected:
     double m_value;
 };
 
     double m_value;
 };
 

-IMPLEMENT_DYNAMIC_CLASS(wxVariantDataReal, wxVariantData)
+IMPLEMENT_DYNAMIC_CLASS(wxVariantDoubleData, wxVariantData)

 
 

-void wxVariantDataReal::Copy(wxVariantData& data)
+bool wxVariantDoubleData::Eq(wxVariantData& data) const

 {
 {

-    wxASSERT_MSG( (data.GetType() == wxT("double")), wxT("wxVariantDataReal::Copy: Can't copy to this type of data") );
+    wxASSERT_MSG( (data.GetType() == wxT("double")), wxT("wxVariantDoubleData::Eq: argument mismatch") );

 
 

-    wxVariantDataReal& otherData = (wxVariantDataReal&) data;
+    wxVariantDoubleData& otherData = (wxVariantDoubleData&) data;

 
 

-    otherData.m_value = m_value;
-}
-
-bool wxVariantDataReal::Eq(wxVariantData& data) const
-{
-    wxASSERT_MSG( (data.GetType() == wxT("double")), wxT("wxVariantDataReal::Eq: argument mismatch") );
-
-    wxVariantDataReal& otherData = (wxVariantDataReal&) data;
-
-    return (otherData.m_value == m_value);
+    return wxIsSameDouble(otherData.m_value, m_value);

 }
 
 #if wxUSE_STD_IOSTREAM
 }
 
 #if wxUSE_STD_IOSTREAM

-bool wxVariantDataReal::Write(wxSTD ostream& str) const
+bool wxVariantDoubleData::Write(wxSTD ostream& str) const

 {
     wxString s;
     Write(s);
 {
     wxString s;
     Write(s);


@@ -474,14 +404,14 @@ bool wxVariantDataReal::Write(wxSTD ostream& str) const
 }
 #endif
 
 }
 #endif
 

-bool wxVariantDataReal::Write(wxString& str) const
+bool wxVariantDoubleData::Write(wxString& str) const

 {
 {

-    str.Printf(wxT("%.4f"), m_value);
+    str.Printf(wxT("%.14g"), m_value);

     return true;
 }
 
 #if wxUSE_STD_IOSTREAM
     return true;
 }
 
 #if wxUSE_STD_IOSTREAM

-bool wxVariantDataReal::Read(wxSTD istream& str)
+bool wxVariantDoubleData::Read(wxSTD istream& str)

 {
     str >> m_value;
     return true;
 {
     str >> m_value;
     return true;


@@ -489,14 +419,14 @@ bool wxVariantDataReal::Read(wxSTD istream& str)
 #endif
 
 #if wxUSE_STREAMS
 #endif
 
 #if wxUSE_STREAMS

-bool wxVariantDataReal::Write(wxOutputStream& str) const
+bool wxVariantDoubleData::Write(wxOutputStream& str) const

 {
     wxTextOutputStream s(str);
     s.WriteDouble((double)m_value);
     return true;
 }
 
 {
     wxTextOutputStream s(str);
     s.WriteDouble((double)m_value);
     return true;
 }
 

-bool wxVariantDataReal::Read(wxInputStream& str)
+bool wxVariantDoubleData::Read(wxInputStream& str)

 {
     wxTextInputStream s(str);
     m_value = (float)s.ReadDouble();
 {
     wxTextInputStream s(str);
     m_value = (float)s.ReadDouble();


@@ -504,18 +434,67 @@ bool wxVariantDataReal::Read(wxInputStream& str)
 }
 #endif // wxUSE_STREAMS
 
 }
 #endif // wxUSE_STREAMS
 

-bool wxVariantDataReal::Read(wxString& str)
+bool wxVariantDoubleData::Read(wxString& str)

 {
     m_value = wxAtof((const wxChar*) str);
     return true;
 }
 
 {
     m_value = wxAtof((const wxChar*) str);
     return true;
 }
 

+//  wxVariant double code
+
+wxVariant::wxVariant(double val, const wxString& name)
+{
+    m_data = new wxVariantDoubleData(val);
+    m_name = name;
+}
+
+bool wxVariant::operator== (double value) const
+{
+    double thisValue;
+    if (!Convert(&thisValue))
+        return false;
+
+    return wxIsSameDouble(value, thisValue);
+}
+
+bool wxVariant::operator!= (double value) const
+{
+    return (!((*this) == value));
+}
+
+void wxVariant::operator= (double value)
+{
+    if (GetType() == wxT("double") &&
+        m_data->GetRefCount() == 1)
+    {
+        ((wxVariantDoubleData*)GetData())->SetValue(value);
+    }
+    else
+    {
+        UnRef();
+        m_data = new wxVariantDoubleData(value);
+    }
+}
+
+double wxVariant::GetDouble() const
+{
+    double value;
+    if (Convert(& value))
+        return value;
+    else
+    {
+        wxFAIL_MSG(wxT("Could not convert to a double number"));
+        return 0.0;
+    }
+}
+
+// -----------------------------------------------------------------
+// wxVariantBoolData
+// -----------------------------------------------------------------
+

 #ifdef HAVE_BOOL
 #ifdef HAVE_BOOL

-/*
- * wxVariantDataBool
- */

 
 

-class WXDLLEXPORT wxVariantDataBool: public wxVariantData
+class WXDLLIMPEXP_BASE wxVariantDataBool: public wxVariantData

 {
 DECLARE_DYNAMIC_CLASS(wxVariantDataBool)
 public:
 {
 DECLARE_DYNAMIC_CLASS(wxVariantDataBool)
 public:


@@ -525,7 +504,6 @@ public:
     inline bool GetValue() const { return m_value; }
     inline void SetValue(bool value) { m_value = value; }
 
     inline bool GetValue() const { return m_value; }
     inline void SetValue(bool value) { m_value = value; }
 

-    virtual void Copy(wxVariantData& data);

     virtual bool Eq(wxVariantData& data) const;
 #if wxUSE_STD_IOSTREAM
     virtual bool Write(wxSTD ostream& str) const;
     virtual bool Eq(wxVariantData& data) const;
 #if wxUSE_STD_IOSTREAM
     virtual bool Write(wxSTD ostream& str) const;


@@ -547,15 +525,6 @@ protected:
 
 IMPLEMENT_DYNAMIC_CLASS(wxVariantDataBool, wxVariantData)
 
 
 IMPLEMENT_DYNAMIC_CLASS(wxVariantDataBool, wxVariantData)
 

-void wxVariantDataBool::Copy(wxVariantData& data)
-{
-    wxASSERT_MSG( (data.GetType() == wxT("bool")), wxT("wxVariantDataBool::Copy: Can't copy to this type of data") );
-
-    wxVariantDataBool& otherData = (wxVariantDataBool&) data;
-
-    otherData.m_value = m_value;
-}
-

 bool wxVariantDataBool::Eq(wxVariantData& data) const
 {
     wxASSERT_MSG( (data.GetType() == wxT("bool")), wxT("wxVariantDataBool::Eq: argument mismatch") );
 bool wxVariantDataBool::Eq(wxVariantData& data) const
 {
     wxASSERT_MSG( (data.GetType() == wxT("bool")), wxT("wxVariantDataBool::Eq: argument mismatch") );


@@ -613,23 +582,71 @@ bool wxVariantDataBool::Read(wxString& str)
     m_value = (wxAtol((const wxChar*) str) != 0);
     return true;
 }
     m_value = (wxAtol((const wxChar*) str) != 0);
     return true;
 }

+
+// wxVariant ****
+
+wxVariant::wxVariant(bool val, const wxString& name)
+{
+    m_data = new wxVariantDataBool(val);
+    m_name = name;
+}
+
+bool wxVariant::operator== (bool value) const
+{
+    bool thisValue;
+    if (!Convert(&thisValue))
+        return false;
+    else
+        return (value == thisValue);
+}
+
+bool wxVariant::operator!= (bool value) const
+{
+    return (!((*this) == value));
+}
+
+void wxVariant::operator= (bool value)
+{
+    if (GetType() == wxT("bool") &&
+        m_data->GetRefCount() == 1)
+    {
+        ((wxVariantDataBool*)GetData())->SetValue(value);
+    }
+    else
+    {
+        UnRef();
+        m_data = new wxVariantDataBool(value);
+    }
+}
+
+bool wxVariant::GetBool() const
+{
+    bool value;
+    if (Convert(& value))
+        return value;
+    else
+    {
+        wxFAIL_MSG(wxT("Could not convert to a bool"));
+        return 0;
+    }
+}
+

 #endif // HAVE_BOOL
 
 #endif // HAVE_BOOL
 

-/*
- * wxVariantDataChar
- */
+// -----------------------------------------------------------------
+// wxVariantDataChar
+// -----------------------------------------------------------------

 
 

-class WXDLLEXPORT wxVariantDataChar: public wxVariantData
+class WXDLLIMPEXP_BASE wxVariantDataChar: public wxVariantData

 {
 DECLARE_DYNAMIC_CLASS(wxVariantDataChar)
 public:
     wxVariantDataChar() { m_value = 0; }
 {
 DECLARE_DYNAMIC_CLASS(wxVariantDataChar)
 public:
     wxVariantDataChar() { m_value = 0; }

-    wxVariantDataChar(char value) { m_value = value; }
+    wxVariantDataChar(wxChar value) { m_value = value; }

 
 

-    inline char GetValue() const { return m_value; }
-    inline void SetValue(char value) { m_value = value; }
+    inline wxChar GetValue() const { return m_value; }
+    inline void SetValue(wxChar value) { m_value = value; }

 
 

-    virtual void Copy(wxVariantData& data);

     virtual bool Eq(wxVariantData& data) const;
 #if wxUSE_STD_IOSTREAM
     virtual bool Read(wxSTD istream& str);
     virtual bool Eq(wxVariantData& data) const;
 #if wxUSE_STD_IOSTREAM
     virtual bool Read(wxSTD istream& str);


@@ -644,20 +661,11 @@ public:
     virtual wxString GetType() const { return wxT("char"); };
 
 protected:
     virtual wxString GetType() const { return wxT("char"); };
 
 protected:

-    char m_value;
+    wxChar m_value;

 };
 
 IMPLEMENT_DYNAMIC_CLASS(wxVariantDataChar, wxVariantData)
 
 };
 
 IMPLEMENT_DYNAMIC_CLASS(wxVariantDataChar, wxVariantData)
 

-void wxVariantDataChar::Copy(wxVariantData& data)
-{
-    wxASSERT_MSG( (data.GetType() == wxT("char")), wxT("wxVariantDataChar::Copy: Can't copy to this type of data") );
-
-    wxVariantDataChar& otherData = (wxVariantDataChar&) data;
-
-    otherData.m_value = m_value;
-}
-

 bool wxVariantDataChar::Eq(wxVariantData& data) const
 {
     wxASSERT_MSG( (data.GetType() == wxT("char")), wxT("wxVariantDataChar::Eq: argument mismatch") );
 bool wxVariantDataChar::Eq(wxVariantData& data) const
 {
     wxASSERT_MSG( (data.GetType() == wxT("char")), wxT("wxVariantDataChar::Eq: argument mismatch") );


@@ -687,7 +695,7 @@ bool wxVariantDataChar::Write(wxString& str) const
 bool wxVariantDataChar::Read(wxSTD istream& WXUNUSED(str))
 {
     wxFAIL_MSG(wxT("Unimplemented"));
 bool wxVariantDataChar::Read(wxSTD istream& WXUNUSED(str))
 {
     wxFAIL_MSG(wxT("Unimplemented"));

-//    str >> m_value;
+

     return false;
 }
 #endif
     return false;
 }
 #endif


@@ -697,7 +705,8 @@ bool wxVariantDataChar::Write(wxOutputStream& str) const
 {
     wxTextOutputStream s(str);
 
 {
     wxTextOutputStream s(str);
 

-    s.Write8(m_value);
+    s << m_value;
+

     return true;
 }
 
     return true;
 }
 


@@ -705,33 +714,71 @@ bool wxVariantDataChar::Read(wxInputStream& str)
 {
     wxTextInputStream s(str);
 
 {
     wxTextInputStream s(str);
 

-    m_value = s.Read8();
+    s >> m_value;
+

     return true;
 }
 #endif // wxUSE_STREAMS
 
 bool wxVariantDataChar::Read(wxString& str)
 {
     return true;
 }
 #endif // wxUSE_STREAMS
 
 bool wxVariantDataChar::Read(wxString& str)
 {

-    m_value = str[(size_t)0];
+    m_value = str[size_t(0)];

     return true;
 }
 
     return true;
 }
 

-/*
- * wxVariantDataString
- */
+wxVariant::wxVariant(wxChar val, const wxString& name)
+{
+    m_data = new wxVariantDataChar(val);
+    m_name = name;
+}

 
 

-#if defined(__BORLANDC__) && defined(__WIN16__)
-// Change name because of truncation
-#define wxVariantDataString wxVariantStringData
-#endif
+bool wxVariant::operator== (wxChar value) const
+{
+    wxChar thisValue;
+    if (!Convert(&thisValue))
+        return false;
+    else
+        return (value == thisValue);
+}

 
 

-class WXDLLEXPORT wxVariantDataString: public wxVariantData
+bool wxVariant::operator!= (wxChar value) const
+{
+    return (!((*this) == value));
+}
+
+void wxVariant::operator= (wxChar value)
+{
+    if (GetType() == wxT("char") &&
+        m_data->GetRefCount() == 1)
+    {
+        ((wxVariantDataChar*)GetData())->SetValue(value);
+    }
+    else
+    {
+        UnRef();
+        m_data = new wxVariantDataChar(value);
+    }
+}
+
+wxChar wxVariant::GetChar() const
+{
+    wxChar value;
+    if (Convert(& value))
+        return value;
+    else
+    {
+        wxFAIL_MSG(wxT("Could not convert to a char"));
+        return 0;
+    }
+}
+
+// ----------------------------------------------------------------------------
+// wxVariantDataString
+// ----------------------------------------------------------------------------
+
+class WXDLLIMPEXP_BASE wxVariantDataString: public wxVariantData

 {
 {

-#if defined(__BORLANDC__) && defined(__WIN16__)
-DECLARE_DYNAMIC_CLASS(wxVariantStringData)
-#else

 DECLARE_DYNAMIC_CLASS(wxVariantDataString)
 DECLARE_DYNAMIC_CLASS(wxVariantDataString)

-#endif

 public:
     wxVariantDataString() { }
     wxVariantDataString(const wxString& value) { m_value = value; }
 public:
     wxVariantDataString() { }
     wxVariantDataString(const wxString& value) { m_value = value; }


@@ -739,7 +786,6 @@ public:
     inline wxString GetValue() const { return m_value; }
     inline void SetValue(const wxString& value) { m_value = value; }
 
     inline wxString GetValue() const { return m_value; }
     inline void SetValue(const wxString& value) { m_value = value; }
 

-    virtual void Copy(wxVariantData& data);

     virtual bool Eq(wxVariantData& data) const;
 #if wxUSE_STD_IOSTREAM
     virtual bool Write(wxSTD ostream& str) const;
     virtual bool Eq(wxVariantData& data) const;
 #if wxUSE_STD_IOSTREAM
     virtual bool Write(wxSTD ostream& str) const;


@@ -747,7 +793,7 @@ public:
     virtual bool Read(wxString& str);
     virtual bool Write(wxString& str) const;
 #if wxUSE_STD_IOSTREAM
     virtual bool Read(wxString& str);
     virtual bool Write(wxString& str) const;
 #if wxUSE_STD_IOSTREAM

-    virtual bool Read(wxSTD istream& str);
+    virtual bool Read(wxSTD istream& WXUNUSED(str)) { return false; };

 #endif
 #if wxUSE_STREAMS
     virtual bool Read(wxInputStream& str);
 #endif
 #if wxUSE_STREAMS
     virtual bool Read(wxInputStream& str);


@@ -759,15 +805,6 @@ protected:
     wxString m_value;
 };
 
     wxString m_value;
 };
 

-void wxVariantDataString::Copy(wxVariantData& data)
-{
-    wxASSERT_MSG( (data.GetType() == wxT("string")), wxT("wxVariantDataString::Copy: Can't copy to this type of data") );
-
-    wxVariantDataString& otherData = (wxVariantDataString&) data;
-
-    otherData.m_value = m_value;
-}
-

 bool wxVariantDataString::Eq(wxVariantData& data) const
 {
     wxASSERT_MSG( (data.GetType() == wxT("string")), wxT("wxVariantDataString::Eq: argument mismatch") );
 bool wxVariantDataString::Eq(wxVariantData& data) const
 {
     wxASSERT_MSG( (data.GetType() == wxT("string")), wxT("wxVariantDataString::Eq: argument mismatch") );


@@ -791,14 +828,6 @@ bool wxVariantDataString::Write(wxString& str) const
     return true;
 }
 
     return true;
 }
 

-#if wxUSE_STD_IOSTREAM
-bool wxVariantDataString::Read(wxSTD istream& str)
-{
-    str >> m_value;
-    return true;
-}
-#endif
-

 #if wxUSE_STREAMS
 bool wxVariantDataString::Write(wxOutputStream& str) const
 {
 #if wxUSE_STREAMS
 bool wxVariantDataString::Write(wxOutputStream& str) const
 {


@@ -812,7 +841,7 @@ bool wxVariantDataString::Read(wxInputStream& str)
 {
     wxTextInputStream s(str);
 
 {
     wxTextInputStream s(str);
 

-    m_value = s.ReadString();
+    m_value = s.ReadLine();

     return true;
 }
 #endif // wxUSE_STREAMS
     return true;
 }
 #endif // wxUSE_STREAMS


@@ -823,112 +852,89 @@ bool wxVariantDataString::Read(wxString& str)
     return true;
 }
 
     return true;
 }
 

-#if defined(__BORLANDC__) && defined(__WIN16__)
-IMPLEMENT_DYNAMIC_CLASS(wxVariantStringData, wxVariantData)
-#else

 IMPLEMENT_DYNAMIC_CLASS(wxVariantDataString, wxVariantData)
 IMPLEMENT_DYNAMIC_CLASS(wxVariantDataString, wxVariantData)

-#endif

 
 

-/*
- * wxVariantDataTime
- */
+// wxVariant ****

 
 

-// For some reason, Watcom C++ can't link variant.cpp with time/date classes compiled
-#if wxUSE_TIMEDATE && !defined(__WATCOMC__)
-
-class wxVariantDataTime: public wxVariantData
+wxVariant::wxVariant(const wxString& val, const wxString& name)

 {
 {

- DECLARE_DYNAMIC_CLASS(wxVariantDataTime)
-public:
-    wxVariantDataTime() { }
-    wxVariantDataTime(const wxTime& value) { m_value = value; }
-
-    inline wxTime GetValue() const { return m_value; }
-    inline void SetValue(const wxTime& value) { m_value = value; }
-
-    virtual void Copy(wxVariantData& data);
-    virtual bool Eq(wxVariantData& data) const;
-#if wxUSE_STD_IOSTREAM
-    virtual bool Write(wxSTD ostream& str) const;
-#endif
-    virtual bool Write(wxString& str) const;
-#if wxUSE_STD_IOSTREAM
-    virtual bool Read(wxSTD istream& str);
-#endif
-    virtual bool Read(wxString& str);
-    virtual wxString GetType() const { return wxT("time"); };
-    virtual wxVariantData* Clone() { return new wxVariantDataTime; }
-
-protected:
-    wxTime m_value;
-};
-
-IMPLEMENT_DYNAMIC_CLASS(wxVariantDataTime, wxVariantData)
+    m_data = new wxVariantDataString(val);
+    m_name = name;
+}

 
 

-void wxVariantDataTime::Copy(wxVariantData& data)
+wxVariant::wxVariant(const wxChar* val, const wxString& name)

 {
 {

-    wxASSERT_MSG( (data.GetType() == wxT("time")), wxT("wxVariantDataTime::Copy: Can't copy to this type of data") );
-
-    wxVariantDataTime& otherData = (wxVariantDataTime&) data;
-
-    otherData.m_value = m_value;
+    m_data = new wxVariantDataString(wxString(val));
+    m_name = name;

 }
 
 }
 

-bool wxVariantDataTime::Eq(wxVariantData& data) const
+bool wxVariant::operator== (const wxString& value) const

 {
 {

-    wxASSERT_MSG( (data.GetType() == wxT("time")), wxT("wxVariantDataTime::Eq: argument mismatch") );
+    wxString thisValue;
+    if (!Convert(&thisValue))
+        return false;

 
 

-    wxVariantDataTime& otherData = (wxVariantDataTime&) data;
+    return value == thisValue;
+}

 
 

-    return (otherData.m_value == m_value);
+bool wxVariant::operator!= (const wxString& value) const
+{
+    return (!((*this) == value));

 }
 
 }
 

-#if wxUSE_STD_IOSTREAM
-bool wxVariantDataTime::Write(wxSTD ostream& str) const
+void wxVariant::operator= (const wxString& value)

 {
 {

-    wxString s;
-    Write(s);
-    str << (const char*) s.mb_str();
-    return true;
+    if (GetType() == wxT("string") &&
+        m_data->GetRefCount() == 1)
+    {
+        ((wxVariantDataString*)GetData())->SetValue(value);
+    }
+    else
+    {
+        UnRef();
+        m_data = new wxVariantDataString(value);
+    }

 }
 }

-#endif

 
 

-bool wxVariantDataTime::Write(wxString& str) const
+void wxVariant::operator= (const wxChar* value)

 {
 {

-    wxChar*s = m_value.FormatTime();
-    str = s;
-    return true;
+    if (GetType() == wxT("string") &&
+        m_data->GetRefCount() == 1)
+    {
+        ((wxVariantDataString*)GetData())->SetValue(wxString(value));
+    }
+    else
+    {
+        UnRef();
+        m_data = new wxVariantDataString(wxString(value));
+    }

 }
 
 }
 

-#if wxUSE_STD_IOSTREAM
-bool wxVariantDataTime::Read(wxSTD istream& WXUNUSED(str))
+wxString wxVariant::GetString() const

 {
 {

-    // Not implemented
-    return false;
-}
-#endif
+    wxString value;
+    if (!Convert(& value))
+    {
+        wxFAIL_MSG(wxT("Could not convert to a string"));
+    }

 
 

-bool wxVariantDataTime::Read(wxString& WXUNUSED(str))
-{
-    // Not implemented
-    return false;
+    return value;

 }
 
 }
 

-/*
- * wxVariantDataDate
- */
+// ----------------------------------------------------------------------------
+// wxVariantDataWxObjectPtr
+// ----------------------------------------------------------------------------

 
 

-class wxVariantDataDate: public wxVariantData
+class wxVariantDataWxObjectPtr: public wxVariantData

 {
 {

- DECLARE_DYNAMIC_CLASS(wxVariantDataDate)
+DECLARE_DYNAMIC_CLASS(wxVariantDataWxObjectPtr)

 public:
 public:

-    wxVariantDataDate() { }
-    wxVariantDataDate(const wxDate& value) { m_value = value; }
+    wxVariantDataWxObjectPtr() { }
+    wxVariantDataWxObjectPtr(wxObject* value) { m_value = value; }

 
 

-    inline wxDate GetValue() const { return m_value; }
-    inline void SetValue(const wxDate& value) { m_value = value; }
+    inline wxObject* GetValue() const { return m_value; }
+    inline void SetValue(wxObject* value) { m_value = value; }

 
 

-    virtual void Copy(wxVariantData& data);

     virtual bool Eq(wxVariantData& data) const;
 #if wxUSE_STD_IOSTREAM
     virtual bool Write(wxSTD ostream& str) const;
     virtual bool Eq(wxVariantData& data) const;
 #if wxUSE_STD_IOSTREAM
     virtual bool Write(wxSTD ostream& str) const;


@@ -938,35 +944,47 @@ public:
     virtual bool Read(wxSTD istream& str);
 #endif
     virtual bool Read(wxString& str);
     virtual bool Read(wxSTD istream& str);
 #endif
     virtual bool Read(wxString& str);

-    virtual wxString GetType() const { return wxT("date"); };
-    virtual wxVariantData* Clone() { return new wxVariantDataDate; }
+    virtual wxString GetType() const ;
+    virtual wxVariantData* Clone() { return new wxVariantDataWxObjectPtr; }

 
 

+    virtual wxClassInfo* GetValueClassInfo() ;

 protected:
 protected:

-    wxDate m_value;
+    wxObject* m_value;
+
+    DECLARE_NO_COPY_CLASS(wxVariantDataWxObjectPtr)

 };
 
 };
 

-IMPLEMENT_DYNAMIC_CLASS(wxVariantDataDate, wxVariantData)
+IMPLEMENT_DYNAMIC_CLASS(wxVariantDataWxObjectPtr, wxVariantData)

 
 

-void wxVariantDataDate::Copy(wxVariantData& data)
+bool wxVariantDataWxObjectPtr::Eq(wxVariantData& data) const

 {
 {

-    wxASSERT_MSG( (data.GetType() == wxT("date")), wxT("wxVariantDataDate::Copy: Can't copy to this type of data") );
+    wxASSERT_MSG(   wxIsKindOf((&data), wxVariantDataWxObjectPtr), wxT("wxVariantDataWxObjectPtr::Eq: argument mismatch") );
+
+    wxVariantDataWxObjectPtr& otherData = (wxVariantDataWxObjectPtr&) data;

 
 

-    wxVariantDataDate& otherData = (wxVariantDataDate&) data;
+    return (otherData.m_value == m_value);
+}

 
 

-    otherData.m_value = m_value;
+wxString wxVariantDataWxObjectPtr::GetType() const
+{
+    wxString returnVal(wxT("wxObject"));
+    if (m_value) {
+        returnVal = m_value->GetClassInfo()->GetClassName();
+    }
+    return returnVal;

 }
 
 }
 

-bool wxVariantDataDate::Eq(wxVariantData& data) const
+wxClassInfo* wxVariantDataWxObjectPtr::GetValueClassInfo()

 {
 {

-    wxASSERT_MSG( (data.GetType() == wxT("date")), wxT("wxVariantDataDate::Eq: argument mismatch") );
+    wxClassInfo* returnVal=NULL;

 
 

-    wxVariantDataDate& otherData = (wxVariantDataDate&) data;
+    if (m_value) returnVal = m_value->GetClassInfo();

 
 

-    return (otherData.m_value == m_value);
+    return returnVal;

 }
 
 #if wxUSE_STD_IOSTREAM
 }
 
 #if wxUSE_STD_IOSTREAM

-bool wxVariantDataDate::Write(wxSTD ostream& str) const
+bool wxVariantDataWxObjectPtr::Write(wxSTD ostream& str) const

 {
     wxString s;
     Write(s);
 {
     wxString s;
     Write(s);


@@ -975,31 +993,59 @@ bool wxVariantDataDate::Write(wxSTD ostream& str) const
 }
 #endif
 
 }
 #endif
 

-bool wxVariantDataDate::Write(wxString& str) const
+bool wxVariantDataWxObjectPtr::Write(wxString& str) const

 {
 {

-    str = m_value.FormatDate();
+    str.Printf(wxT("%s(%p)"), GetType().c_str(), wx_static_cast(void*, m_value));

     return true;
 }
 
 #if wxUSE_STD_IOSTREAM
     return true;
 }
 
 #if wxUSE_STD_IOSTREAM

-bool wxVariantDataDate::Read(wxSTD istream& WXUNUSED(str))
+bool wxVariantDataWxObjectPtr::Read(wxSTD istream& WXUNUSED(str))

 {
     // Not implemented
     return false;
 }
 #endif
 
 {
     // Not implemented
     return false;
 }
 #endif
 

-bool wxVariantDataDate::Read(wxString& WXUNUSED(str))
+bool wxVariantDataWxObjectPtr::Read(wxString& WXUNUSED(str))

 {
     // Not implemented
     return false;
 }
 {
     // Not implemented
     return false;
 }

-#endif
-  // wxUSE_TIMEDATE

 
 

-/*
- * wxVariantDataVoidPtr
- */
+// wxVariant
+
+wxVariant::wxVariant( wxObject* val, const wxString& name)
+{
+    m_data = new wxVariantDataWxObjectPtr(val);
+    m_name = name;
+}
+
+bool wxVariant::operator== (wxObject* value) const
+{
+    return (value == ((wxVariantDataWxObjectPtr*)GetData())->GetValue());
+}
+
+bool wxVariant::operator!= (wxObject* value) const
+{
+    return (!((*this) == (wxObject*) value));
+}
+
+void wxVariant::operator= (wxObject* value)
+{
+    UnRef();
+    m_data = new wxVariantDataWxObjectPtr(value);
+}
+
+wxObject* wxVariant::GetWxObjectPtr() const
+{
+    wxASSERT(wxIsKindOf(GetData(), wxVariantDataWxObjectPtr));
+    return (wxObject*) ((wxVariantDataWxObjectPtr*) m_data)->GetValue();
+}
+
+// ----------------------------------------------------------------------------
+// wxVariantDataVoidPtr
+// ----------------------------------------------------------------------------

 
 class wxVariantDataVoidPtr: public wxVariantData
 {
 
 class wxVariantDataVoidPtr: public wxVariantData
 {


@@ -1011,7 +1057,6 @@ public:
     inline void* GetValue() const { return m_value; }
     inline void SetValue(void* value) { m_value = value; }
 
     inline void* GetValue() const { return m_value; }
     inline void SetValue(void* value) { m_value = value; }
 

-    virtual void Copy(wxVariantData& data);

     virtual bool Eq(wxVariantData& data) const;
 #if wxUSE_STD_IOSTREAM
     virtual bool Write(wxSTD ostream& str) const;
     virtual bool Eq(wxVariantData& data) const;
 #if wxUSE_STD_IOSTREAM
     virtual bool Write(wxSTD ostream& str) const;


@@ -1032,15 +1077,6 @@ protected:
 
 IMPLEMENT_DYNAMIC_CLASS(wxVariantDataVoidPtr, wxVariantData)
 
 
 IMPLEMENT_DYNAMIC_CLASS(wxVariantDataVoidPtr, wxVariantData)
 

-void wxVariantDataVoidPtr::Copy(wxVariantData& data)
-{
-    wxASSERT_MSG( (data.GetType() == wxT("void*")), wxT("wxVariantDataVoidPtr::Copy: Can't copy to this type of data") );
-
-    wxVariantDataVoidPtr& otherData = (wxVariantDataVoidPtr&) data;
-
-    otherData.m_value = m_value;
-}
-

 bool wxVariantDataVoidPtr::Eq(wxVariantData& data) const
 {
     wxASSERT_MSG( (data.GetType() == wxT("void*")), wxT("wxVariantDataVoidPtr::Eq: argument mismatch") );
 bool wxVariantDataVoidPtr::Eq(wxVariantData& data) const
 {
     wxASSERT_MSG( (data.GetType() == wxT("void*")), wxT("wxVariantDataVoidPtr::Eq: argument mismatch") );


@@ -1062,7 +1098,7 @@ bool wxVariantDataVoidPtr::Write(wxSTD ostream& str) const
 
 bool wxVariantDataVoidPtr::Write(wxString& str) const
 {
 
 bool wxVariantDataVoidPtr::Write(wxString& str) const
 {

-    str.Printf(wxT("%ld"), (long) m_value);
+    str.Printf(wxT("%p"), m_value);

     return true;
 }
 
     return true;
 }
 


@@ -1080,9 +1116,50 @@ bool wxVariantDataVoidPtr::Read(wxString& WXUNUSED(str))
     return false;
 }
 
     return false;
 }
 

-/*
- * wxVariantDataDateTime
- */
+// wxVariant
+
+wxVariant::wxVariant( void* val, const wxString& name)
+{
+    m_data = new wxVariantDataVoidPtr(val);
+    m_name = name;
+}
+
+bool wxVariant::operator== (void* value) const
+{
+    return (value == ((wxVariantDataVoidPtr*)GetData())->GetValue());
+}
+
+bool wxVariant::operator!= (void* value) const
+{
+    return (!((*this) == (void*) value));
+}
+
+void wxVariant::operator= (void* value)
+{
+    if (GetType() == wxT("void*") &&
+        m_data->GetRefCount() == 1)
+    {
+        ((wxVariantDataVoidPtr*)GetData())->SetValue(value);
+    }
+    else
+    {
+        UnRef();
+        m_data = new wxVariantDataVoidPtr(value);
+    }
+}
+
+void* wxVariant::GetVoidPtr() const
+{
+    wxASSERT( (GetType() == wxT("void*")) );
+
+    return (void*) ((wxVariantDataVoidPtr*) m_data)->GetValue();
+}
+
+// ----------------------------------------------------------------------------
+// wxVariantDataDateTime
+// ----------------------------------------------------------------------------
+
+#if wxUSE_DATETIME

 
 class wxVariantDataDateTime: public wxVariantData
 {
 
 class wxVariantDataDateTime: public wxVariantData
 {


@@ -1098,13 +1175,12 @@ public:
         { m_value = wxDateTime(valptr->day, (wxDateTime::Month) (valptr->month - 1),valptr->year); }
     wxVariantDataDateTime(const TIMESTAMP_STRUCT* valptr)
         { m_value = wxDateTime(valptr->day, (wxDateTime::Month) (valptr->month - 1), valptr->year,
         { m_value = wxDateTime(valptr->day, (wxDateTime::Month) (valptr->month - 1),valptr->year); }
     wxVariantDataDateTime(const TIMESTAMP_STRUCT* valptr)
         { m_value = wxDateTime(valptr->day, (wxDateTime::Month) (valptr->month - 1), valptr->year,

-                        valptr->hour, valptr->minute, valptr->second, valptr->fraction ); }
+                        valptr->hour, valptr->minute, valptr->second, (wxDateTime::wxDateTime_t)valptr->fraction ); }

 #endif //ODBC
 
     inline wxDateTime GetValue() const { return m_value; }
     inline void SetValue(const wxDateTime& value) { m_value = value; }
 
 #endif //ODBC
 
     inline wxDateTime GetValue() const { return m_value; }
     inline void SetValue(const wxDateTime& value) { m_value = value; }
 

-    virtual void Copy(wxVariantData& data);

     virtual bool Eq(wxVariantData& data) const;
 #if wxUSE_STD_IOSTREAM
     virtual bool Write(wxSTD ostream& str) const;
     virtual bool Eq(wxVariantData& data) const;
 #if wxUSE_STD_IOSTREAM
     virtual bool Write(wxSTD ostream& str) const;


@@ -1124,16 +1200,6 @@ protected:
 
 IMPLEMENT_DYNAMIC_CLASS(wxVariantDataDateTime, wxVariantData)
 
 
 IMPLEMENT_DYNAMIC_CLASS(wxVariantDataDateTime, wxVariantData)
 

-void wxVariantDataDateTime::Copy(wxVariantData& data)
-{
-    wxASSERT_MSG( (data.GetType() == wxT("datetime")), wxT("wxVariantDataDateTime::Copy: Can't copy to this type of data") );
-
-    wxVariantDataDateTime& otherData = (wxVariantDataDateTime&) data;
-
-    otherData.m_value = m_value;
-}
-
-

 bool wxVariantDataDateTime::Eq(wxVariantData& data) const
 {
     wxASSERT_MSG( (data.GetType() == wxT("datetime")), wxT("wxVariantDataDateTime::Eq: argument mismatch") );
 bool wxVariantDataDateTime::Eq(wxVariantData& data) const
 {
     wxASSERT_MSG( (data.GetType() == wxT("datetime")), wxT("wxVariantDataDateTime::Eq: argument mismatch") );


@@ -1147,8 +1213,10 @@ bool wxVariantDataDateTime::Eq(wxVariantData& data) const
 #if wxUSE_STD_IOSTREAM
 bool wxVariantDataDateTime::Write(wxSTD ostream& str) const
 {
 #if wxUSE_STD_IOSTREAM
 bool wxVariantDataDateTime::Write(wxSTD ostream& str) const
 {

-    // Not implemented
-    return false;
+    wxString value;
+    Write( value );
+    str << value.c_str();
+    return true;

 }
 #endif
 
 }
 #endif
 


@@ -1176,6 +1244,96 @@ bool wxVariantDataDateTime::Read(wxString& str)
     return true;
 }
 
     return true;
 }
 

+// wxVariant
+
+wxVariant::wxVariant(const wxDateTime& val, const wxString& name) // Date
+{
+    m_data = new wxVariantDataDateTime(val);
+    m_name = name;
+}
+
+#if wxUSE_ODBC
+wxVariant::wxVariant(const TIME_STRUCT* valptr, const wxString& name) // Date
+{
+    m_data = new wxVariantDataDateTime(valptr);
+    m_name = name;
+}
+
+wxVariant::wxVariant(const TIMESTAMP_STRUCT* valptr, const wxString& name) // Date
+{
+    m_data = new wxVariantDataDateTime(valptr);
+    m_name = name;
+}
+
+wxVariant::wxVariant(const DATE_STRUCT* valptr, const wxString& name) // Date
+{
+    m_data = new wxVariantDataDateTime(valptr);
+    m_name = name;
+}
+#endif // wxUSE_ODBC
+
+bool wxVariant::operator== (const wxDateTime& value) const
+{
+    wxDateTime thisValue;
+    if (!Convert(&thisValue))
+        return false;
+
+    return value.IsEqualTo(thisValue);
+}
+
+bool wxVariant::operator!= (const wxDateTime& value) const
+{
+    return (!((*this) == value));
+}
+
+void wxVariant::operator= (const wxDateTime& value)
+{
+    if (GetType() == wxT("datetime") &&
+        m_data->GetRefCount() == 1)
+    {
+        ((wxVariantDataDateTime*)GetData())->SetValue(value);
+    }
+    else
+    {
+        UnRef();
+        m_data = new wxVariantDataDateTime(value);
+    }
+}
+
+#if wxUSE_ODBC
+void wxVariant::operator= (const DATE_STRUCT* value)
+{
+    UnRef();
+    m_data = new wxVariantDataDateTime(value);
+}
+
+void wxVariant::operator= (const TIME_STRUCT* value)
+{
+    UnRef();
+    m_data = new wxVariantDataDateTime(value);
+}
+
+void wxVariant::operator= (const TIMESTAMP_STRUCT* value)
+{
+    UnRef();
+    m_data = new wxVariantDataDateTime(value);
+}
+
+#endif // wxUSE_ODBC
+
+wxDateTime wxVariant::GetDateTime() const
+{
+    wxDateTime value;
+    if (!Convert(& value))
+    {
+        wxFAIL_MSG(wxT("Could not convert to a datetime"));
+    }
+
+    return value;
+}
+
+#endif // wxUSE_DATETIME
+

 // ----------------------------------------------------------------------------
 // wxVariantDataArrayString
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
 // wxVariantDataArrayString
 // ----------------------------------------------------------------------------


@@ -1189,7 +1347,6 @@ public:
     wxArrayString GetValue() const { return m_value; }
     void SetValue(const wxArrayString& value) { m_value = value; }
 
     wxArrayString GetValue() const { return m_value; }
     void SetValue(const wxArrayString& value) { m_value = value; }
 

-    virtual void Copy(wxVariantData& data);

     virtual bool Eq(wxVariantData& data) const;
 #if wxUSE_STD_IOSTREAM
     virtual bool Write(wxSTD ostream& str) const;
     virtual bool Eq(wxVariantData& data) const;
 #if wxUSE_STD_IOSTREAM
     virtual bool Write(wxSTD ostream& str) const;


@@ -1210,16 +1367,6 @@ protected:
 
 IMPLEMENT_DYNAMIC_CLASS(wxVariantDataArrayString, wxVariantData)
 
 
 IMPLEMENT_DYNAMIC_CLASS(wxVariantDataArrayString, wxVariantData)
 

-void wxVariantDataArrayString::Copy(wxVariantData& data)
-{
-    wxASSERT_MSG( data.GetType() == GetType(), wxT("wxVariantDataArrayString::Copy: Can't copy to this type of data") );
-
-    wxVariantDataArrayString& otherData = (wxVariantDataArrayString&) data;
-
-    otherData.m_value = m_value;
-}
-
-

 bool wxVariantDataArrayString::Eq(wxVariantData& data) const
 {
     wxASSERT_MSG( data.GetType() == GetType(), wxT("wxVariantDataArrayString::Eq: argument mismatch") );
 bool wxVariantDataArrayString::Eq(wxVariantData& data) const
 {
     wxASSERT_MSG( data.GetType() == GetType(), wxT("wxVariantDataArrayString::Eq: argument mismatch") );


@@ -1229,16 +1376,14 @@ bool wxVariantDataArrayString::Eq(wxVariantData& data) const
     return otherData.m_value == m_value;
 }
 
     return otherData.m_value == m_value;
 }
 

-

 #if wxUSE_STD_IOSTREAM
 #if wxUSE_STD_IOSTREAM

-bool wxVariantDataArrayString::Write(wxSTD ostream& str) const
+bool wxVariantDataArrayString::Write(wxSTD ostream& WXUNUSED(str)) const

 {
     // Not implemented
     return false;
 }
 #endif
 
 {
     // Not implemented
     return false;
 }
 #endif
 

-

 bool wxVariantDataArrayString::Write(wxString& str) const
 {
     size_t count = m_value.GetCount();
 bool wxVariantDataArrayString::Write(wxString& str) const
 {
     size_t count = m_value.GetCount();


@@ -1274,772 +1419,212 @@ bool wxVariantDataArrayString::Read(wxString& str)
     return true;
 }
 
     return true;
 }
 

+// wxVariant

 
 

-
-/*
- * wxVariant
- */
-
-IMPLEMENT_DYNAMIC_CLASS(wxVariant, wxObject)
-
-// Construction & destruction
-wxVariant::wxVariant()
-{
-    m_data = (wxVariantData*) NULL;
-}
-
-wxVariant::wxVariant(double val, const wxString& name)
+wxVariant::wxVariant(const wxArrayString& val, const wxString& name) // Strings

 {
 {

-    m_data = new wxVariantDataReal(val);
+    m_data = new wxVariantDataArrayString(val);

     m_name = name;
 }
 
     m_name = name;
 }
 

-wxVariant::wxVariant(long val, const wxString& name)
+bool wxVariant::operator==(const wxArrayString& WXUNUSED(value)) const

 {
 {

-    m_data = new wxVariantDataLong(val);
-    m_name = name;
+    wxFAIL_MSG( _T("TODO") );
+
+    return false;

 }
 
 }
 

-#ifdef HAVE_BOOL
-wxVariant::wxVariant(bool val, const wxString& name)
+bool wxVariant::operator!=(const wxArrayString& value) const

 {
 {

-    m_data = new wxVariantDataBool(val);
-    m_name = name;
+    return !(*this == value);

 }
 }

-#endif

 
 

-wxVariant::wxVariant(char val, const wxString& name)
+void wxVariant::operator=(const wxArrayString& value)

 {
 {

-    m_data = new wxVariantDataChar(val);
-    m_name = name;
+    if (GetType() == wxT("arrstring") &&
+        m_data->GetRefCount() == 1)
+    {
+        ((wxVariantDataArrayString *)GetData())->SetValue(value);
+    }
+    else
+    {
+        UnRef();
+        m_data = new wxVariantDataArrayString(value);
+    }

 }
 
 }
 

-wxVariant::wxVariant(const wxString& val, const wxString& name)
+wxArrayString wxVariant::GetArrayString() const

 {
 {

-    m_data = new wxVariantDataString(val);
-    m_name = name;
-}
+    if ( GetType() == wxT("arrstring") )
+        return ((wxVariantDataArrayString *)GetData())->GetValue();

 
 

-wxVariant::wxVariant(const wxChar* val, const wxString& name)
-{
-    m_data = new wxVariantDataString(wxString(val));
-    m_name = name;
+    return wxArrayString();

 }
 
 }
 

-wxVariant::wxVariant(const wxStringList& val, const wxString& name)
-{
-    m_data = new wxVariantDataStringList(val);
-    m_name = name;
-}
+// ----------------------------------------------------------------------------
+// wxVariantDataList
+// ----------------------------------------------------------------------------

 
 

-wxVariant::wxVariant(const wxList& val, const wxString& name) // List of variants
+class WXDLLIMPEXP_BASE wxVariantDataList: public wxVariantData

 {
 {

-    m_data = new wxVariantDataList(val);
-    m_name = name;
-}
+DECLARE_DYNAMIC_CLASS(wxVariantDataList)
+public:
+    wxVariantDataList() {}
+    wxVariantDataList(const wxList& list);
+    virtual ~wxVariantDataList();

 
 

-// For some reason, Watcom C++ can't link variant.cpp with time/date classes compiled
-#if wxUSE_TIMEDATE && !defined(__WATCOMC__)
-wxVariant::wxVariant(const wxTime& val, const wxString& name) // Time
-{
-    m_data = new wxVariantDataTime(val);
-    m_name = name;
-}
+    wxList& GetValue() { return m_value; }
+    void SetValue(const wxList& value) ;

 
 

-wxVariant::wxVariant(const wxDate& val, const wxString& name) // Date
-{
-    m_data = new wxVariantDataDate(val);
-    m_name = name;
-}
+    virtual bool Eq(wxVariantData& data) const;
+#if wxUSE_STD_IOSTREAM
+    virtual bool Write(wxSTD ostream& str) const;

 #endif
 #endif

+    virtual bool Write(wxString& str) const;
+#if wxUSE_STD_IOSTREAM
+    virtual bool Read(wxSTD istream& str);
+#endif
+    virtual bool Read(wxString& str);
+    virtual wxString GetType() const { return wxT("list"); };

 
 

-wxVariant::wxVariant(void* val, const wxString& name) // Void ptr
-{
-    m_data = new wxVariantDataVoidPtr(val);
-    m_name = name;
-}
-
-wxVariant::wxVariant(const wxDateTime& val, const wxString& name) // Date
-{
-    m_data = new wxVariantDataDateTime(val);
-    m_name = name;
-}
-
-#if wxUSE_ODBC
-wxVariant::wxVariant(const TIME_STRUCT* valptr, const wxString& name) // Date
-{
-    m_data = new wxVariantDataDateTime(valptr);
-    m_name = name;
-}
-
-wxVariant::wxVariant(const TIMESTAMP_STRUCT* valptr, const wxString& name) // Date
-{
-    m_data = new wxVariantDataDateTime(valptr);
-    m_name = name;
-}
-
-wxVariant::wxVariant(const DATE_STRUCT* valptr, const wxString& name) // Date
-{
-    m_data = new wxVariantDataDateTime(valptr);
-    m_name = name;
-}
-#endif // wxUSE_ODBC
-
-wxVariant::wxVariant(const wxArrayString& val, const wxString& name) // Strings
-{
-    m_data = new wxVariantDataArrayString(val);
-    m_name = name;
-}
+    void Clear();

 
 

-wxVariant::wxVariant(const wxVariant& variant)
-    : wxObject()
-{
-    if (!variant.IsNull())
-    {
-        m_data = (wxVariantData*) variant.GetData()->GetClassInfo()->CreateObject();
-        variant.m_data->Copy(*m_data);
-    }
-    else
-        m_data = (wxVariantData*) NULL;
-    m_name = variant.m_name;
-}
+protected:
+    wxList  m_value;
+};

 
 

-wxVariant::wxVariant(wxVariantData* data, const wxString& name) // User-defined data
-{
-    m_data = data;
-    m_name = name;
-}
+IMPLEMENT_DYNAMIC_CLASS(wxVariantDataList, wxVariantData)

 
 

-wxVariant::~wxVariant()
+wxVariantDataList::wxVariantDataList(const wxList& list)

 {
 {

-    delete m_data;
+    SetValue(list);

 }
 
 }
 

-
-// Make NULL (i.e. delete the data)
-void wxVariant::MakeNull()
+wxVariantDataList::~wxVariantDataList()

 {
 {

-    delete m_data;
-    m_data = NULL;
+    Clear();

 }
 
 }
 

-// Generic operators
-// Assignment
-void wxVariant::operator= (const wxVariant& variant)
+void wxVariantDataList::SetValue(const wxList& value)

 {
 {

-    if (variant.IsNull())
-    {
-        MakeNull();
-        return;
-    }
-
-    if (IsNull() || (GetType() != variant.GetType()))
+    Clear();
+    wxList::compatibility_iterator node = value.GetFirst();
+    while (node)

     {
     {

-        if (m_data)
-            delete m_data;
-        m_data = (wxVariantData*) variant.GetData()->GetClassInfo()->CreateObject();
+        wxVariant* var = (wxVariant*) node->GetData();
+        m_value.Append(new wxVariant(*var));
+        node = node->GetNext();

     }
     }

-
-    variant.GetData()->Copy(* GetData());
-
-    m_name = variant.m_name;
-}
-
-// Assignment using data, e.g.
-// myVariant = new wxStringVariantData("hello")
-void wxVariant::operator= (wxVariantData* variantData)
-{
-    MakeNull();
-    m_data = variantData;
-}
-
-bool wxVariant::operator== (const wxVariant& variant) const
-{
-    if (IsNull() || variant.IsNull())
-        return (IsNull() == variant.IsNull());
-
-    return (GetData()->Eq(* variant.GetData()));
-}
-
-bool wxVariant::operator!= (const wxVariant& variant) const
-{
-    return (!(*this == variant));
-}
-
-
-// Specific operators
-bool wxVariant::operator== (double value) const
-{
-    double thisValue;
-    if (!Convert(&thisValue))
-        return false;
-    else
-        return (value == thisValue);
-}
-
-bool wxVariant::operator!= (double value) const
-{
-    return (!((*this) == value));

 }
 
 }
 

-void wxVariant::operator= (double value)
+void wxVariantDataList::Clear()

 {
 {

-    if (GetType() == wxT("double"))
-    {
-        ((wxVariantDataReal*)GetData())->SetValue(value);
-    }
-    else
+    wxList::compatibility_iterator node = m_value.GetFirst();
+    while (node)

     {
     {

-        if (m_data)
-            delete m_data;
-        m_data = new wxVariantDataReal(value);
+        wxVariant* var = (wxVariant*) node->GetData();
+        delete var;
+        node = node->GetNext();

     }
     }

+    m_value.Clear();

 }
 
 }
 

-bool wxVariant::operator== (long value) const
-{
-    long thisValue;
-    if (!Convert(&thisValue))
-        return false;
-    else
-        return (value == thisValue);
-}
-
-bool wxVariant::operator!= (long value) const
+bool wxVariantDataList::Eq(wxVariantData& data) const

 {
 {

-    return (!((*this) == value));
-}
+    wxASSERT_MSG( (data.GetType() == wxT("list")), wxT("wxVariantDataList::Eq: argument mismatch") );

 
 

-void wxVariant::operator= (long value)
-{
-    if (GetType() == wxT("long"))
-    {
-        ((wxVariantDataLong*)GetData())->SetValue(value);
-    }
-    else
+    wxVariantDataList& listData = (wxVariantDataList&) data;
+    wxList::compatibility_iterator node1 = m_value.GetFirst();
+    wxList::compatibility_iterator node2 = listData.GetValue().GetFirst();
+    while (node1 && node2)

     {
     {

-        if (m_data)
-            delete m_data;
-        m_data = new wxVariantDataLong(value);
+        wxVariant* var1 = (wxVariant*) node1->GetData();
+        wxVariant* var2 = (wxVariant*) node2->GetData();
+        if ((*var1) != (*var2))
+            return false;
+        node1 = node1->GetNext();
+        node2 = node2->GetNext();

     }
     }

+    if (node1 || node2) return false;
+    return true;

 }
 
 }
 

-bool wxVariant::operator== (char value) const
-{
-    char thisValue;
-    if (!Convert(&thisValue))
-        return false;
-    else
-        return (value == thisValue);
-}
-
-bool wxVariant::operator!= (char value) const
+#if wxUSE_STD_IOSTREAM
+bool wxVariantDataList::Write(wxSTD ostream& str) const

 {
 {

-    return (!((*this) == value));
+    wxString s;
+    Write(s);
+    str << (const char*) s.mb_str();
+    return true;

 }
 }

+#endif

 
 

-void wxVariant::operator= (char value)
+bool wxVariantDataList::Write(wxString& str) const

 {
 {

-    if (GetType() == wxT("char"))
-    {
-        ((wxVariantDataChar*)GetData())->SetValue(value);
-    }
-    else
+    str = wxEmptyString;
+    wxList::compatibility_iterator node = m_value.GetFirst();
+    while (node)

     {
     {

-        if (m_data)
-            delete m_data;
-        m_data = new wxVariantDataChar(value);
+        wxVariant* var = (wxVariant*) node->GetData();
+        if (node != m_value.GetFirst())
+          str += wxT(" ");
+        wxString str1;
+        str += var->MakeString();
+        node = node->GetNext();

     }
     }

-}
-
-#ifdef HAVE_BOOL
-bool wxVariant::operator== (bool value) const
-{
-    bool thisValue;
-    if (!Convert(&thisValue))
-        return false;
-    else
-        return (value == thisValue);
-}

 
 

-bool wxVariant::operator!= (bool value) const
-{
-    return (!((*this) == value));
+    return true;

 }
 
 }
 

-void wxVariant::operator= (bool value)
+#if wxUSE_STD_IOSTREAM
+bool wxVariantDataList::Read(wxSTD istream& WXUNUSED(str))

 {
 {

-    if (GetType() == wxT("bool"))
-    {
-        ((wxVariantDataBool*)GetData())->SetValue(value);
-    }
-    else
-    {
-        if (m_data)
-            delete m_data;
-        m_data = new wxVariantDataBool(value);
-    }
+    wxFAIL_MSG(wxT("Unimplemented"));
+    // TODO
+    return false;

 }
 }

-#endif // HAVE_BOOL
+#endif

 
 

-bool wxVariant::operator== (const wxString& value) const
+bool wxVariantDataList::Read(wxString& WXUNUSED(str))

 {
 {

-    wxString thisValue;
-    if (!Convert(&thisValue))
-        return false;
-
-    return value == thisValue;
-}
-
-bool wxVariant::operator!= (const wxString& value) const
-{
-    return (!((*this) == value));
-}
-
-void wxVariant::operator= (const wxString& value)
-{
-    if (GetType() == wxT("string"))
-    {
-        ((wxVariantDataString*)GetData())->SetValue(value);
-    }
-    else
-    {
-        if (m_data)
-            delete m_data;
-        m_data = new wxVariantDataString(value);
-    }
-}
-
-void wxVariant::operator= (const wxChar* value)
-{
-    if (GetType() == wxT("string"))
-    {
-        ((wxVariantDataString*)GetData())->SetValue(wxString(value));
-    }
-    else
-    {
-        if (m_data)
-            delete m_data;
-        m_data = new wxVariantDataString(wxString(value));
-    }
-}
-
-bool wxVariant::operator== (const wxStringList& value) const
-{
-    wxASSERT_MSG( (GetType() == wxT("stringlist")), wxT("Invalid type for == operator") );
-
-    wxVariantDataStringList other(value);
-    return (m_data->Eq(other));
-}
-
-bool wxVariant::operator!= (const wxStringList& value) const
-{
-    return (!((*this) == value));
-}
-
-void wxVariant::operator= (const wxStringList& value)
-{
-    if (GetType() == wxT("stringlist"))
-    {
-        ((wxVariantDataStringList*)GetData())->SetValue(value);
-    }
-    else
-    {
-        if (m_data)
-            delete m_data;
-        m_data = new wxVariantDataStringList(value);
-    }
-}
-
-bool wxVariant::operator== (const wxList& value) const
-{
-    wxASSERT_MSG( (GetType() == wxT("list")), wxT("Invalid type for == operator") );
-
-    wxVariantDataList other(value);
-    return (m_data->Eq(other));
-}
-
-bool wxVariant::operator!= (const wxList& value) const
-{
-    return (!((*this) == value));
-}
-
-void wxVariant::operator= (const wxList& value)
-{
-    if (GetType() == wxT("list"))
-    {
-        ((wxVariantDataList*)GetData())->SetValue(value);
-    }
-    else
-    {
-        if (m_data)
-            delete m_data;
-        m_data = new wxVariantDataList(value);
-    }
-}
-
-// For some reason, Watcom C++ can't link variant.cpp with time/date classes compiled
-#if wxUSE_TIMEDATE && !defined(__WATCOMC__)
-bool wxVariant::operator== (const wxTime& value) const
-{
-    wxTime thisValue;
-    if (!Convert(&thisValue))
-        return false;
-
-    return value == thisValue;
-}
-
-bool wxVariant::operator!= (const wxTime& value) const
-{
-    return (!((*this) == value));
-}
-
-void wxVariant::operator= (const wxTime& value)
-{
-    if (GetType() == wxT("time"))
-    {
-        ((wxVariantDataTime*)GetData())->SetValue(value);
-    }
-    else
-    {
-        if (m_data)
-            delete m_data;
-        m_data = new wxVariantDataTime(value);
-    }
-}
-
-bool wxVariant::operator== (const wxDate& value) const
-{
-    wxDate thisValue;
-    if (!Convert(&thisValue))
-        return false;
-
-    return (value == thisValue);
-}
-
-bool wxVariant::operator!= (const wxDate& value) const
-{
-    return (!((*this) == value));
-}
-
-void wxVariant::operator= (const wxDate& value)
-{
-    if (GetType() == wxT("date"))
-    {
-        ((wxVariantDataTime*)GetData())->SetValue(value);
-    }
-    else
-    {
-        if (m_data)
-            delete m_data;
-        m_data = new wxVariantDataDate(value);
-    }
-}
-#endif
-
-bool wxVariant::operator== (void* value) const
-{
-    return (value == ((wxVariantDataVoidPtr*)GetData())->GetValue());
-}
-
-bool wxVariant::operator!= (void* value) const
-{
-    return (!((*this) == (void*) value));
-}
-
-void wxVariant::operator= (void* value)
-{
-    if (GetType() == wxT("void*"))
-    {
-        ((wxVariantDataVoidPtr*)GetData())->SetValue(value);
-    }
-    else
-    {
-        if (m_data)
-            delete m_data;
-        m_data = new wxVariantDataVoidPtr(value);
-    }
-}
-
-bool wxVariant::operator== (const wxDateTime& value) const
-{
-    wxDateTime thisValue;
-    if (!Convert(&thisValue))
-        return false;
-
-    return value.IsEqualTo(thisValue);
-}
-
-bool wxVariant::operator!= (const wxDateTime& value) const
-{
-    return (!((*this) == value));
-}
-
-void wxVariant::operator= (const wxDateTime& value)
-{
-    if (GetType() == wxT("datetime"))
-    {
-        ((wxVariantDataDateTime*)GetData())->SetValue(value);
-    }
-    else
-    {
-        if (m_data)
-            delete m_data;
-        m_data = new wxVariantDataDateTime(value);
-    }
-}
-
-#if wxUSE_ODBC
-void wxVariant::operator= (const DATE_STRUCT* value)
-{
-    if (m_data)
-        delete m_data;
-    m_data = new wxVariantDataDateTime(value);
-}
-
-
-void wxVariant::operator= (const TIME_STRUCT* value)
-{
-    if (m_data)
-        delete m_data;
-    m_data = new wxVariantDataDateTime(value);
-}
-
-
-void wxVariant::operator= (const TIMESTAMP_STRUCT* value)
-{
-    if (m_data)
-        delete m_data;
-    m_data = new wxVariantDataDateTime(value);
-}
-
-#endif // wxUSE_ODBC
-
-bool wxVariant::operator==(const wxArrayString& WXUNUSED(value)) const
-{
-    wxFAIL_MSG( _T("TODO") );
-
-    return false;
-}
-
-bool wxVariant::operator!=(const wxArrayString& value) const
-{
-    return !(*this == value);
-}
-
-void wxVariant::operator=(const wxArrayString& value)
-{
-    if (GetType() == wxT("arrstring"))
-    {
-        ((wxVariantDataArrayString *)GetData())->SetValue(value);
-    }
-    else
-    {
-        delete m_data;
-        m_data = new wxVariantDataArrayString(value);
-    }
-}
-
-wxArrayString wxVariant::GetArrayString() const
-{
-    if ( GetType() == wxT("arrstring") )
-        return ((wxVariantDataArrayString *)GetData())->GetValue();
-
-    return wxArrayString();
-}
-
-
-// Treat a list variant as an array
-wxVariant wxVariant::operator[] (size_t idx) const
-{
-    wxASSERT_MSG( (GetType() == wxT("list") || GetType() == wxT("stringlist")), wxT("Invalid type for array operator") );
-
-    if (GetType() == wxT("list"))
-    {
-        wxVariantDataList* data = (wxVariantDataList*) m_data;
-        wxASSERT_MSG( (idx < (size_t) data->GetValue().GetCount()), wxT("Invalid index for array") );
-        return * (wxVariant*) (data->GetValue().Item(idx)->GetData());
-    }
-    else if (GetType() == wxT("stringlist"))
-    {
-        wxVariantDataStringList* data = (wxVariantDataStringList*) m_data;
-        wxASSERT_MSG( (idx < (size_t) data->GetValue().GetCount()), wxT("Invalid index for array") );
-
-        wxVariant variant( wxString( (wxChar*) (data->GetValue().Item(idx)->GetData()) ));
-        return variant;
-    }
-    return wxNullVariant;
-}
-
-wxVariant& wxVariant::operator[] (size_t idx)
-{
-    // We can't return a reference to a variant for a string list, since the string
-    // is actually stored as a char*, not a variant.
-
-    wxASSERT_MSG( (GetType() == wxT("list")), wxT("Invalid type for array operator") );
-
-    wxVariantDataList* data = (wxVariantDataList*) m_data;
-    wxASSERT_MSG( (idx < (size_t) data->GetValue().GetCount()), wxT("Invalid index for array") );
-
-    return * (wxVariant*) (data->GetValue().Item(idx)->GetData());
-}
-
-// Return the number of elements in a list
-int wxVariant::GetCount() const
-{
-    wxASSERT_MSG( (GetType() == wxT("list") || GetType() == wxT("stringlist")), wxT("Invalid type for GetCount()") );
-
-    if (GetType() == wxT("list"))
-    {
-        wxVariantDataList* data = (wxVariantDataList*) m_data;
-        return data->GetValue().GetCount();
-    }
-    else if (GetType() == wxT("stringlist"))
-    {
-        wxVariantDataStringList* data = (wxVariantDataStringList*) m_data;
-        return data->GetValue().GetCount();
-    }
-    return 0;
-}
-
-wxString wxVariant::MakeString() const
-{
-    if (!IsNull())
-    {
-        wxString str;
-        if (GetData()->Write(str))
-            return str;
-    }
-    return wxString(wxT(""));
-}
-
-// Accessors
-
-void wxVariant::SetData(wxVariantData* data)
-{
-    if (m_data) delete m_data;
-    m_data = data;
-}
-
-
-// Returns a string representing the type of the variant,
-// e.g. "string", "bool", "stringlist", "list", "double", "long"
-wxString wxVariant::GetType() const
-{
-    if (IsNull())
-        return wxString(wxT("null"));
-    else
-        return m_data->GetType();
-}
-
-
-bool wxVariant::IsType(const wxString& type) const
-{
-    return (GetType() == type);
-}
-
-
-// Value accessors
-double wxVariant::GetReal() const
-{
-    double value;
-    if (Convert(& value))
-        return value;
-    else
-    {
-        wxFAIL_MSG(wxT("Could not convert to a real number"));
-        return 0.0;
-    }
-}
-
-long wxVariant::GetInteger() const
-{
-    long value;
-    if (Convert(& value))
-        return value;
-    else
-    {
-        wxFAIL_MSG(wxT("Could not convert to an integer"));
-        return 0;
-    }
-}
-
-char wxVariant::GetChar() const
-{
-    char value;
-    if (Convert(& value))
-        return value;
-    else
-    {
-        wxFAIL_MSG(wxT("Could not convert to a char"));
-        return 0;
-    }
-}
-
-bool wxVariant::GetBool() const
-{
-    bool value;
-    if (Convert(& value))
-        return value;
-    else
-    {
-        wxFAIL_MSG(wxT("Could not convert to a bool"));
-        return 0;
-    }
-}
-
-wxString wxVariant::GetString() const
-{
-    wxString value;
-    if (!Convert(& value))
-    {
-        wxFAIL_MSG(wxT("Could not convert to a string"));
-    }
-
-    return value;
+    wxFAIL_MSG(wxT("Unimplemented"));
+    // TODO
+    return false;

 }
 
 }
 

-// For some reason, Watcom C++ can't link variant.cpp with time/date classes compiled
-#if wxUSE_TIMEDATE && !defined(__WATCOMC__)
-wxTime wxVariant::GetTime() const
-{
-    wxTime value;
-    if (!Convert(& value))
-    {
-        wxFAIL_MSG(wxT("Could not convert to a time"));
-    }
+// wxVariant

 
 

-    return value;
+wxVariant::wxVariant(const wxList& val, const wxString& name) // List of variants
+{
+    m_data = new wxVariantDataList(val);
+    m_name = name;

 }
 
 }
 

-wxDate wxVariant::GetDate() const
+bool wxVariant::operator== (const wxList& value) const

 {
 {

-    wxDate value;
-    if (!Convert(& value))
-    {
-        wxFAIL_MSG(wxT("Could not convert to a date"));
-    }
+    wxASSERT_MSG( (GetType() == wxT("list")), wxT("Invalid type for == operator") );

 
 

-    return value;
+    wxVariantDataList other(value);
+    return (GetData()->Eq(other));

 }
 }

-#endif // wxUSE_TIMEDATE

 
 

-void* wxVariant::GetVoidPtr() const
+bool wxVariant::operator!= (const wxList& value) const

 {
 {

-    wxASSERT( (GetType() == wxT("void*")) );
-
-    return (void*) ((wxVariantDataVoidPtr*) m_data)->GetValue();
+    return (!((*this) == value));

 }
 
 }
 

-wxDateTime wxVariant::GetDateTime() const
+void wxVariant::operator= (const wxList& value)

 {
 {

-    wxDateTime value;
-    if (!Convert(& value))
+    if (GetType() == wxT("list") &&
+        m_data->GetRefCount() == 1)

     {
     {

-        wxFAIL_MSG(wxT("Could not convert to a datetime"));
+        ((wxVariantDataList*)GetData())->SetValue(value);
+    }
+    else
+    {
+        UnRef();
+        m_data = new wxVariantDataList(value);

     }
     }

-
-    return value;

 }
 
 wxList& wxVariant::GetList() const
 }
 
 wxList& wxVariant::GetList() const


@@ -2049,18 +1634,11 @@ wxList& wxVariant::GetList() const
     return (wxList&) ((wxVariantDataList*) m_data)->GetValue();
 }
 
     return (wxList&) ((wxVariantDataList*) m_data)->GetValue();
 }
 

-wxStringList& wxVariant::GetStringList() const
-{
-    wxASSERT( (GetType() == wxT("stringlist")) );
-
-    return (wxStringList&) ((wxVariantDataStringList*) m_data)->GetValue();
-}
-

 // Make empty list
 void wxVariant::NullList()
 {
     SetData(new wxVariantDataList());
 // Make empty list
 void wxVariant::NullList()
 {
     SetData(new wxVariantDataList());

-};
+}

 
 // Append to list
 void wxVariant::Append(const wxVariant& value)
 
 // Append to list
 void wxVariant::Append(const wxVariant& value)


@@ -2083,7 +1661,7 @@ bool wxVariant::Member(const wxVariant& value) const
 {
     wxList& list = GetList();
 
 {
     wxList& list = GetList();
 

-    wxNode* node = list.GetFirst();
+    wxList::compatibility_iterator node = list.GetFirst();

     while (node)
     {
         wxVariant* other = (wxVariant*) node->GetData();
     while (node)
     {
         wxVariant* other = (wxVariant*) node->GetData();


@@ -2095,15 +1673,15 @@ bool wxVariant::Member(const wxVariant& value) const
 }
 
 // Deletes the nth element of the list
 }
 
 // Deletes the nth element of the list

-bool wxVariant::Delete(int item)
+bool wxVariant::Delete(size_t item)

 {
     wxList& list = GetList();
 
 {
     wxList& list = GetList();
 

-    wxASSERT_MSG( (item < (int) list.GetCount()), wxT("Invalid index to Delete") );
-    wxNode* node = list.Item(item);
+    wxASSERT_MSG( (item < list.GetCount()), wxT("Invalid index to Delete") );
+    wxList::compatibility_iterator node = list.Item(item);

     wxVariant* variant = (wxVariant*) node->GetData();
     delete variant;
     wxVariant* variant = (wxVariant*) node->GetData();
     delete variant;

-    delete node;
+    list.Erase(node);

     return true;
 }
 
     return true;
 }
 


@@ -2116,21 +1694,239 @@ void wxVariant::ClearList()
     }
     else
     {
     }
     else
     {

-        if (GetType() != wxT("list"))
-        {
-            delete m_data;
-            m_data = NULL;
-        }
+        if (!GetType().IsSameAs(wxT("list")))
+            UnRef();
+

         m_data = new wxVariantDataList;
     }
 }
 
         m_data = new wxVariantDataList;
     }
 }
 

+#if WXWIN_COMPATIBILITY_2_4
+
+// ----------------------------------------------------------------------------
+// wxVariantDataStringList
+// ----------------------------------------------------------------------------
+
+class WXDLLIMPEXP_BASE wxVariantDataStringList: public wxVariantData
+{
+DECLARE_DYNAMIC_CLASS(wxVariantDataStringList)
+public:
+    wxVariantDataStringList() {}
+    wxVariantDataStringList(const wxStringList& list) { m_value = list; }
+
+    wxStringList& GetValue() const { return (wxStringList&) m_value; }
+    void SetValue(const wxStringList& value);
+
+    virtual bool Eq(wxVariantData& data) const;
+#if wxUSE_STD_IOSTREAM
+    virtual bool Write(wxSTD ostream& str) const;
+#endif
+    virtual bool Write(wxString& str) const;
+#if wxUSE_STD_IOSTREAM
+    virtual bool Read(wxSTD istream& str);
+#endif
+    virtual bool Read(wxString& str);
+    virtual wxString GetType() const { return wxT("stringlist"); };
+
+protected:
+    wxStringList  m_value;
+};
+
+IMPLEMENT_DYNAMIC_CLASS(wxVariantDataStringList, wxVariantData)
+
+void wxVariantDataStringList::SetValue(const wxStringList& value)
+{
+    m_value = value;
+}
+
+bool wxVariantDataStringList::Eq(wxVariantData& data) const
+{
+    wxASSERT_MSG( (data.GetType() == wxT("stringlist")), wxT("wxVariantDataStringList::Eq: argument mismatch") );
+
+    wxVariantDataStringList& listData = (wxVariantDataStringList&) data;
+    wxStringList::compatibility_iterator node1 = m_value.GetFirst();
+    wxStringList::compatibility_iterator node2 = listData.GetValue().GetFirst();
+    while (node1 && node2)
+    {
+        wxString str1 ( node1->GetData() );
+        wxString str2 ( node2->GetData() );
+        if (str1 != str2)
+            return false;
+        node1 = node1->GetNext();
+        node2 = node2->GetNext();
+    }
+    if (node1 || node2) return false;
+    return true;
+}
+
+#if wxUSE_STD_IOSTREAM
+bool wxVariantDataStringList::Write(wxSTD ostream& str) const
+{
+    wxString s;
+    Write(s);
+    str << (const char*) s.mb_str();
+    return true;
+}
+#endif
+
+bool wxVariantDataStringList::Write(wxString& str) const
+{
+    str.Empty();
+    wxStringList::compatibility_iterator node = m_value.GetFirst();
+    while (node)
+    {
+        const wxChar* s = node->GetData();
+        if (node != m_value.GetFirst())
+          str += wxT(" ");
+        str += s;
+        node = node->GetNext();
+    }
+
+    return true;
+}
+
+#if wxUSE_STD_IOSTREAM
+bool wxVariantDataStringList::Read(wxSTD istream& WXUNUSED(str))
+{
+    wxFAIL_MSG(wxT("Unimplemented"));
+    // TODO
+    return false;
+}
+#endif
+
+bool wxVariantDataStringList::Read(wxString& WXUNUSED(str))
+{
+    wxFAIL_MSG(wxT("Unimplemented"));
+    // TODO
+    return false;
+}
+
+#endif //2.4 compat
+
+#if WXWIN_COMPATIBILITY_2_4
+
+wxVariant::wxVariant(const wxStringList& val, const wxString& name)
+{
+    m_data = new wxVariantDataStringList(val);
+    m_name = name;
+}
+
+bool wxVariant::operator== (const wxStringList& value) const
+{
+    wxASSERT_MSG( (GetType() == wxT("stringlist")), wxT("Invalid type for == operator") );
+
+    wxVariantDataStringList other(value);
+    return (GetData()->Eq(other));
+}
+
+bool wxVariant::operator!= (const wxStringList& value) const
+{
+    wxASSERT_MSG( (GetType() == wxT("stringlist")), wxT("Invalid type for == operator") );
+
+    wxVariantDataStringList other(value);
+    return !(GetData()->Eq(other));
+}
+
+void wxVariant::operator= (const wxStringList& value)
+{
+    if (GetType() == wxT("stringlist") &&
+        m_data->GetRefCount() == 1)
+    {
+        ((wxVariantDataStringList*)GetData())->SetValue(value);
+    }
+    else
+    {
+        UnRef();
+        m_data = new wxVariantDataStringList(value);
+    }
+}
+
+// wxVariant
+
+wxStringList& wxVariant::GetStringList() const
+{
+    wxASSERT( (GetType() == wxT("stringlist")) );
+
+    return (wxStringList&) ((wxVariantDataStringList*) m_data)->GetValue();
+}
+
+#endif
+
+// Treat a list variant as an array
+wxVariant wxVariant::operator[] (size_t idx) const
+{
+#if WXWIN_COMPATIBILITY_2_4
+    wxASSERT_MSG( (GetType() == wxT("list") || GetType() == wxT("stringlist")), wxT("Invalid type for array operator") );
+#else
+    wxASSERT_MSG( GetType() == wxT("list"), wxT("Invalid type for array operator") );
+#endif
+
+    if (GetType() == wxT("list"))
+    {
+        wxVariantDataList* data = (wxVariantDataList*) m_data;
+        wxASSERT_MSG( (idx < data->GetValue().GetCount()), wxT("Invalid index for array") );
+        return * (wxVariant*) (data->GetValue().Item(idx)->GetData());
+    }
+#if WXWIN_COMPATIBILITY_2_4
+    else if (GetType() == wxT("stringlist"))
+    {
+        wxVariantDataStringList* data = (wxVariantDataStringList*) m_data;
+        wxASSERT_MSG( (idx < data->GetValue().GetCount()), wxT("Invalid index for array") );
+
+        wxString str( (const wxChar*) (data->GetValue().Item(idx)->GetData()) );
+        wxVariant variant( str );
+        return variant;
+    }
+#endif
+    return wxNullVariant;
+}
+
+wxVariant& wxVariant::operator[] (size_t idx)
+{
+    // We can't return a reference to a variant for a string list, since the string
+    // is actually stored as a char*, not a variant.
+
+    wxASSERT_MSG( (GetType() == wxT("list")), wxT("Invalid type for array operator") );
+
+    wxVariantDataList* data = (wxVariantDataList*) m_data;
+    wxASSERT_MSG( (idx < data->GetValue().GetCount()), wxT("Invalid index for array") );
+
+    return * (wxVariant*) (data->GetValue().Item(idx)->GetData());
+}
+
+// Return the number of elements in a list
+size_t wxVariant::GetCount() const
+{
+#if WXWIN_COMPATIBILITY_2_4
+    wxASSERT_MSG( (GetType() == wxT("list") || GetType() == wxT("stringlist")), wxT("Invalid type for GetCount()") );
+#else
+    wxASSERT_MSG( GetType() == wxT("list"), wxT("Invalid type for GetCount()") );
+#endif
+
+    if (GetType() == wxT("list"))
+    {
+        wxVariantDataList* data = (wxVariantDataList*) m_data;
+        return data->GetValue().GetCount();
+    }
+#if WXWIN_COMPATIBILITY_2_4
+    else if (GetType() == wxT("stringlist"))
+    {
+        wxVariantDataStringList* data = (wxVariantDataStringList*) m_data;
+        return data->GetValue().GetCount();
+    }
+#endif
+    return 0;
+}
+
+// ----------------------------------------------------------------------------

 // Type conversion
 // Type conversion

+// ----------------------------------------------------------------------------
+

 bool wxVariant::Convert(long* value) const
 {
     wxString type(GetType());
     if (type == wxT("double"))
 bool wxVariant::Convert(long* value) const
 {
     wxString type(GetType());
     if (type == wxT("double"))

-        *value = (long) (((wxVariantDataReal*)GetData())->GetValue());
+        *value = (long) (((wxVariantDoubleData*)GetData())->GetValue());

     else if (type == wxT("long"))
         *value = ((wxVariantDataLong*)GetData())->GetValue();
 #ifdef HAVE_BOOL
     else if (type == wxT("long"))
         *value = ((wxVariantDataLong*)GetData())->GetValue();
 #ifdef HAVE_BOOL


@@ -2149,7 +1945,7 @@ bool wxVariant::Convert(bool* value) const
 {
     wxString type(GetType());
     if (type == wxT("double"))
 {
     wxString type(GetType());
     if (type == wxT("double"))

-        *value = ((int) (((wxVariantDataReal*)GetData())->GetValue()) != 0);
+        *value = ((int) (((wxVariantDoubleData*)GetData())->GetValue()) != 0);

     else if (type == wxT("long"))
         *value = (((wxVariantDataLong*)GetData())->GetValue() != 0);
 #ifdef HAVE_BOOL
     else if (type == wxT("long"))
         *value = (((wxVariantDataLong*)GetData())->GetValue() != 0);
 #ifdef HAVE_BOOL


@@ -2160,9 +1956,9 @@ bool wxVariant::Convert(bool* value) const
     {
         wxString val(((wxVariantDataString*)GetData())->GetValue());
         val.MakeLower();
     {
         wxString val(((wxVariantDataString*)GetData())->GetValue());
         val.MakeLower();

-        if (val == wxT("true") || val == wxT("yes"))
+        if (val == wxT("true") || val == wxT("yes") || val == wxT('1') )

             *value = true;
             *value = true;

-        else if (val == wxT("false") || val == wxT("no"))
+        else if (val == wxT("false") || val == wxT("no") || val == wxT('0') )

             *value = false;
         else
             return false;
             *value = false;
         else
             return false;


@@ -2177,7 +1973,7 @@ bool wxVariant::Convert(double* value) const
 {
     wxString type(GetType());
     if (type == wxT("double"))
 {
     wxString type(GetType());
     if (type == wxT("double"))

-        *value = ((wxVariantDataReal*)GetData())->GetValue();
+        *value = ((wxVariantDoubleData*)GetData())->GetValue();

     else if (type == wxT("long"))
         *value = (double) (((wxVariantDataLong*)GetData())->GetValue());
 #ifdef HAVE_BOOL
     else if (type == wxT("long"))
         *value = (double) (((wxVariantDataLong*)GetData())->GetValue());
 #ifdef HAVE_BOOL


@@ -2192,7 +1988,7 @@ bool wxVariant::Convert(double* value) const
     return true;
 }
 
     return true;
 }
 

-bool wxVariant::Convert(char* value) const
+bool wxVariant::Convert(wxChar* value) const

 {
     wxString type(GetType());
     if (type == wxT("char"))
 {
     wxString type(GetType());
     if (type == wxT("char"))


@@ -2215,33 +2011,7 @@ bool wxVariant::Convert(wxString* value) const
     return true;
 }
 
     return true;
 }
 

-// For some reason, Watcom C++ can't link variant.cpp with time/date classes compiled
-#if wxUSE_TIMEDATE && !defined(__WATCOMC__)
-bool wxVariant::Convert(wxTime* value) const
-{
-    wxString type(GetType());
-    if (type == wxT("time"))
-        *value = ((wxVariantDataTime*)GetData())->GetValue();
-    else if (type == wxT("date"))
-        *value = wxTime(((wxVariantDataDate*)GetData())->GetValue());
-    else
-        return false;
-
-    return true;
-}
-
-bool wxVariant::Convert(wxDate* value) const
-{
-    wxString type(GetType());
-    if (type == wxT("date"))
-        *value = ((wxVariantDataDate*)GetData())->GetValue();
-    else
-        return false;
-
-    return true;
-}
-#endif // wxUSE_TIMEDATE
-
+#if wxUSE_DATETIME

 bool wxVariant::Convert(wxDateTime* value) const
 {
     wxString type(GetType());
 bool wxVariant::Convert(wxDateTime* value) const
 {
     wxString type(GetType());


@@ -2249,8 +2019,12 @@ bool wxVariant::Convert(wxDateTime* value) const
     {
         *value = ((wxVariantDataDateTime*)GetData())->GetValue();
         return true;
     {
         *value = ((wxVariantDataDateTime*)GetData())->GetValue();
         return true;

-    } 
+    }

     // Fallback to string conversion
     wxString val;
     // Fallback to string conversion
     wxString val;

-    return Convert(&val) && (value->ParseDate(val));
+    return Convert(&val) &&
+                (value->ParseDateTime(val) || value->ParseDate(val) || value->ParseTime(val));

 }
 }

+#endif // wxUSE_DATETIME
+
+#endif // wxUSE_VARIANT