Make radiobutton tab behaviour the same on MSW

[wxWidgets.git] / src / common / image.cpp

diff --git a/src/common/image.cpp b/src/common/image.cpp
index f98926b073568fbd5822d91e08d1f84c25337436..d5ea5590e77f3ad5bd0dc03f10d613b229ba493c 100644 (file)
--- a/src/common/image.cpp
+++ b/src/common/image.cpp
@@ -7,7 +7,7 @@
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
+#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)

 #pragma implementation "image.h"
 #endif
 
 #pragma implementation "image.h"
 #endif
 


@@ -31,6 +31,8 @@
 #include "wx/wfstream.h"
 #include "wx/intl.h"
 #include "wx/module.h"
 #include "wx/wfstream.h"
 #include "wx/intl.h"
 #include "wx/module.h"

+#include "wx/hash.h"
+#include "wx/utils.h"

 
 // For memcpy
 #include <string.h>
 
 // For memcpy
 #include <string.h>


@@ -49,39 +51,53 @@ class wxImageRefData: public wxObjectRefData
 {
 public:
     wxImageRefData();
 {
 public:
     wxImageRefData();

-    ~wxImageRefData();
+    virtual ~wxImageRefData();

 
     int             m_width;
     int             m_height;
     unsigned char  *m_data;
 
     int             m_width;
     int             m_height;
     unsigned char  *m_data;

+

     bool            m_hasMask;
     unsigned char   m_maskRed,m_maskGreen,m_maskBlue;
     bool            m_hasMask;
     unsigned char   m_maskRed,m_maskGreen,m_maskBlue;

+
+    // alpha channel data, may be NULL for the formats without alpha support
+    unsigned char  *m_alpha;
+

     bool            m_ok;
     bool            m_static;
     bool            m_ok;
     bool            m_static;

+

 #if wxUSE_PALETTE
     wxPalette       m_palette;
 #endif // wxUSE_PALETTE
 #if wxUSE_PALETTE
     wxPalette       m_palette;
 #endif // wxUSE_PALETTE

+

     wxArrayString   m_optionNames;
     wxArrayString   m_optionValues;
     wxArrayString   m_optionNames;
     wxArrayString   m_optionValues;

+
+    DECLARE_NO_COPY_CLASS(wxImageRefData)

 };
 
 wxImageRefData::wxImageRefData()
 {
     m_width = 0;
     m_height = 0;
 };
 
 wxImageRefData::wxImageRefData()
 {
     m_width = 0;
     m_height = 0;

-    m_data = (unsigned char*) NULL;
-    m_ok = FALSE;
+    m_data =
+    m_alpha = (unsigned char *) NULL;
+

     m_maskRed = 0;
     m_maskGreen = 0;
     m_maskBlue = 0;
     m_maskRed = 0;
     m_maskGreen = 0;
     m_maskBlue = 0;

-    m_hasMask = FALSE;
-    m_static = FALSE;
+    m_hasMask = false;
+
+    m_ok = false;
+    m_static = false;

 }
 
 wxImageRefData::~wxImageRefData()
 {
 }
 
 wxImageRefData::~wxImageRefData()
 {

-    if (m_data && !m_static)
+    if ( !m_static )

         free( m_data );
         free( m_data );

+
+    free(m_alpha);

 }
 
 wxList wxImage::sm_handlers;
 }
 
 wxList wxImage::sm_handlers;


@@ -98,9 +114,9 @@ wxImage::wxImage()
 {
 }
 
 {
 }
 

-wxImage::wxImage( int width, int height )
+wxImage::wxImage( int width, int height, bool clear )

 {
 {

-    Create( width, height );
+    Create( width, height, clear );

 }
 
 wxImage::wxImage( int width, int height, unsigned char* data, bool static_data )
 }
 
 wxImage::wxImage( int width, int height, unsigned char* data, bool static_data )


@@ -131,6 +147,7 @@ wxImage::wxImage( wxInputStream& stream, const wxString& mimetype, int index )
 #endif // wxUSE_STREAMS
 
 wxImage::wxImage( const wxImage& image )
 #endif // wxUSE_STREAMS
 
 wxImage::wxImage( const wxImage& image )

+    : wxObject()

 {
     Ref(image);
 }
 {
     Ref(image);
 }


@@ -140,45 +157,44 @@ wxImage::wxImage( const wxImage* image )
     if (image) Ref(*image);
 }
 
     if (image) Ref(*image);
 }
 

-void wxImage::Create( int width, int height )
+bool wxImage::Create( int width, int height, bool clear )

 {
     UnRef();
 
     m_refData = new wxImageRefData();
 
     M_IMGDATA->m_data = (unsigned char *) malloc( width*height*3 );
 {
     UnRef();
 
     m_refData = new wxImageRefData();
 
     M_IMGDATA->m_data = (unsigned char *) malloc( width*height*3 );

-    if (M_IMGDATA->m_data)
-    {
-        for (int l = 0; l < width*height*3; l++) M_IMGDATA->m_data[l] = 0;
-
-        M_IMGDATA->m_width = width;
-        M_IMGDATA->m_height = height;
-        M_IMGDATA->m_ok = TRUE;
-    }
-    else
+    if (!M_IMGDATA->m_data)

     {
         UnRef();
     {
         UnRef();

+        return false;

     }
     }

+
+    if (clear)
+        memset(M_IMGDATA->m_data, 0, width*height*3);
+
+    M_IMGDATA->m_width = width;
+    M_IMGDATA->m_height = height;
+    M_IMGDATA->m_ok = true;
+
+    return true;

 }
 
 }
 

-void wxImage::Create( int width, int height, unsigned char* data, bool static_data )
+bool wxImage::Create( int width, int height, unsigned char* data, bool static_data )

 {
     UnRef();
 
 {
     UnRef();
 

+    wxCHECK_MSG( data, false, _T("NULL data in wxImage::Create") );
+

     m_refData = new wxImageRefData();
 
     M_IMGDATA->m_data = data;
     m_refData = new wxImageRefData();
 
     M_IMGDATA->m_data = data;

-    if (M_IMGDATA->m_data)
-    {
-        M_IMGDATA->m_width = width;
-        M_IMGDATA->m_height = height;
-        M_IMGDATA->m_ok = TRUE;
-        M_IMGDATA->m_static = static_data;
-    }
-    else
-    {
-        UnRef();
-    }
+    M_IMGDATA->m_width = width;
+    M_IMGDATA->m_height = height;
+    M_IMGDATA->m_ok = true;
+    M_IMGDATA->m_static = static_data;
+
+    return true;

 }
 
 void wxImage::Destroy()
 }
 
 void wxImage::Destroy()


@@ -192,88 +208,183 @@ wxImage wxImage::Copy() const
 
     wxCHECK_MSG( Ok(), image, wxT("invalid image") );
 
 
     wxCHECK_MSG( Ok(), image, wxT("invalid image") );
 

-    image.Create( M_IMGDATA->m_width, M_IMGDATA->m_height );
+    image.Create( M_IMGDATA->m_width, M_IMGDATA->m_height, false );

 
 

-    char unsigned *data = image.GetData();
+    unsigned char *data = image.GetData();

 
     wxCHECK_MSG( data, image, wxT("unable to create image") );
 
 
     wxCHECK_MSG( data, image, wxT("unable to create image") );
 

-    if (M_IMGDATA->m_hasMask)
-        image.SetMaskColour( M_IMGDATA->m_maskRed, M_IMGDATA->m_maskGreen, M_IMGDATA->m_maskBlue );
+    image.SetMaskColour( M_IMGDATA->m_maskRed, M_IMGDATA->m_maskGreen, M_IMGDATA->m_maskBlue );
+    image.SetMask( M_IMGDATA->m_hasMask );

 
     memcpy( data, GetData(), M_IMGDATA->m_width*M_IMGDATA->m_height*3 );
 
 
     memcpy( data, GetData(), M_IMGDATA->m_width*M_IMGDATA->m_height*3 );
 

+    // also copy the image options
+    wxImageRefData *imgData = (wxImageRefData *)image.m_refData;
+    imgData->m_optionNames = M_IMGDATA->m_optionNames;
+    imgData->m_optionValues = M_IMGDATA->m_optionValues;
+

     return image;
 }
 
     return image;
 }
 

-wxImage wxImage::Scale( int width, int height ) const
+wxImage wxImage::ShrinkBy( int xFactor , int yFactor ) const

 {
 {

+    if( xFactor == 1 && yFactor == 1 )
+        return Copy() ;
+

     wxImage image;
 
     wxCHECK_MSG( Ok(), image, wxT("invalid image") );
 
     // can't scale to/from 0 size
     wxImage image;
 
     wxCHECK_MSG( Ok(), image, wxT("invalid image") );
 
     // can't scale to/from 0 size

-    wxCHECK_MSG( (width > 0) && (height > 0), image,
+    wxCHECK_MSG( (xFactor > 0) && (yFactor > 0), image,

                  wxT("invalid new image size") );
 
     long old_height = M_IMGDATA->m_height,
          old_width  = M_IMGDATA->m_width;
                  wxT("invalid new image size") );
 
     long old_height = M_IMGDATA->m_height,
          old_width  = M_IMGDATA->m_width;

+

     wxCHECK_MSG( (old_height > 0) && (old_width > 0), image,
                  wxT("invalid old image size") );
 
     wxCHECK_MSG( (old_height > 0) && (old_width > 0), image,
                  wxT("invalid old image size") );
 

-    image.Create( width, height );
+    long width = old_width / xFactor ;
+    long height = old_height / yFactor ;
+
+    image.Create( width, height, false );

 
     char unsigned *data = image.GetData();
 
     wxCHECK_MSG( data, image, wxT("unable to create image") );
 
 
     char unsigned *data = image.GetData();
 
     wxCHECK_MSG( data, image, wxT("unable to create image") );
 

+    bool hasMask = false ;
+    unsigned char maskRed = 0;
+    unsigned char maskGreen = 0;
+    unsigned char maskBlue =0 ;

     if (M_IMGDATA->m_hasMask)
     {
     if (M_IMGDATA->m_hasMask)
     {

+        hasMask = true ;
+        maskRed = M_IMGDATA->m_maskRed;
+        maskGreen = M_IMGDATA->m_maskGreen;
+        maskBlue =M_IMGDATA->m_maskBlue ;
+

         image.SetMaskColour( M_IMGDATA->m_maskRed,
                              M_IMGDATA->m_maskGreen,
                              M_IMGDATA->m_maskBlue );
     }
         image.SetMaskColour( M_IMGDATA->m_maskRed,
                              M_IMGDATA->m_maskGreen,
                              M_IMGDATA->m_maskBlue );
     }

-

     char unsigned *source_data = M_IMGDATA->m_data;
     char unsigned *target_data = data;
 
     char unsigned *source_data = M_IMGDATA->m_data;
     char unsigned *target_data = data;
 

-#if 0
-    // This is nonsense, RR.
-
-    // We do (x, y) -> (x, y)*oldSize/newSize but the valid values of x and y
-    // are from 0 to size-1, hence all decrement the sizes
-    long old_old_width = old_width;
-    old_height--;
-    old_width--;
-    height--;
-    width--;
-    for ( long j = 0; j <= height; j++ )
+    for (long y = 0; y < height; y++)

     {
     {

-        // don't crash for images with height == 1
-        long y_offset = height ? (j * old_height / height)* old_old_width : 0;
-
-        for ( long i = 0; i <= width; i++ )
+        for (long x = 0; x < width; x++)

         {
         {

-            long x_offset = width ? (i * old_width) / width : 0;
-
-            memcpy( target_data, source_data + 3*(y_offset + x_offset), 3 );
-            target_data += 3;
+            unsigned long avgRed = 0 ;
+            unsigned long avgGreen = 0;
+            unsigned long avgBlue = 0;
+            unsigned long counter = 0 ;
+            // determine average
+            for ( int y1 = 0 ; y1 < yFactor ; ++y1 )
+            {
+                long y_offset = (y * yFactor + y1) * old_width;
+                for ( int x1 = 0 ; x1 < xFactor ; ++x1 )
+                {
+                    unsigned char *pixel = source_data + 3 * ( y_offset + x * xFactor + x1 ) ;
+                    unsigned char red = pixel[0] ;
+                    unsigned char green = pixel[1] ;
+                    unsigned char blue = pixel[2] ;
+                    if ( !hasMask || red != maskRed || green != maskGreen || blue != maskBlue )
+                    {
+                        avgRed += red ;
+                        avgGreen += green ;
+                        avgBlue += blue ;
+                        counter++ ;
+                    }
+                }
+            }
+            if ( counter == 0 )
+            {
+                *(target_data++) = M_IMGDATA->m_maskRed ;
+                *(target_data++) = M_IMGDATA->m_maskGreen ;
+                *(target_data++) = M_IMGDATA->m_maskBlue ;
+            }
+            else
+            {
+                *(target_data++) = (unsigned char)(avgRed / counter);
+                *(target_data++) = (unsigned char)(avgGreen / counter);
+                *(target_data++) = (unsigned char)(avgBlue / counter);
+            }

         }
     }
         }
     }

-#else
-    for (long j = 0; j < height; j++)
+
+    // In case this is a cursor, make sure the hotspot is scalled accordingly:
+    if ( HasOption(wxIMAGE_OPTION_CUR_HOTSPOT_X) )
+        image.SetOption(wxIMAGE_OPTION_CUR_HOTSPOT_X,
+                (GetOptionInt(wxIMAGE_OPTION_CUR_HOTSPOT_X))/xFactor);
+    if ( HasOption(wxIMAGE_OPTION_CUR_HOTSPOT_Y) )
+        image.SetOption(wxIMAGE_OPTION_CUR_HOTSPOT_Y,
+                (GetOptionInt(wxIMAGE_OPTION_CUR_HOTSPOT_Y))/yFactor);
+
+    return image;
+}
+
+wxImage wxImage::Scale( int width, int height ) const
+{
+    wxImage image;
+
+    wxCHECK_MSG( Ok(), image, wxT("invalid image") );
+
+    // can't scale to/from 0 size
+    wxCHECK_MSG( (width > 0) && (height > 0), image,
+                 wxT("invalid new image size") );
+
+    long old_height = M_IMGDATA->m_height,
+         old_width  = M_IMGDATA->m_width;
+    wxCHECK_MSG( (old_height > 0) && (old_width > 0), image,
+                 wxT("invalid old image size") );
+
+    if ( old_width % width == 0 && old_width >= width &&
+        old_height % height == 0 && old_height >= height )

     {
     {

-        long y_offset = (j * old_height / height) * old_width;
+        return ShrinkBy( old_width / width , old_height / height ) ;
+    }
+    image.Create( width, height, false );

 
 

-        for (long i = 0; i < width; i++)
+    unsigned char *data = image.GetData();
+
+    wxCHECK_MSG( data, image, wxT("unable to create image") );
+
+    if (M_IMGDATA->m_hasMask)
+    {
+        image.SetMaskColour( M_IMGDATA->m_maskRed,
+                             M_IMGDATA->m_maskGreen,
+                             M_IMGDATA->m_maskBlue );
+    }
+
+    unsigned char *source_data = M_IMGDATA->m_data;
+    unsigned char *target_data = data;
+
+    long x_delta = (old_width<<16) / width;
+    long y_delta = (old_height<<16) / height;
+
+    unsigned char* dest_pixel = target_data;
+
+    long y = 0;
+    for ( long j = 0; j < height; j++ )
+        {
+        unsigned char* src_line = &source_data[(y>>16)*old_width*3];
+
+        long x = 0;
+        for ( long i = 0; i < width; i++ )

         {
         {

-            memcpy( target_data,
-                source_data + 3*(y_offset + ((i * old_width )/ width)),
-                3 );
-            target_data += 3;
+             unsigned char* src_pixel = &src_line[(x>>16)*3];
+             dest_pixel[0] = src_pixel[0];
+             dest_pixel[1] = src_pixel[1];
+             dest_pixel[2] = src_pixel[2];
+             dest_pixel += 3;
+             x += x_delta;

         }
         }

+
+        y += y_delta;

     }
     }

-#endif

 
     // In case this is a cursor, make sure the hotspot is scalled accordingly:
     if ( HasOption(wxIMAGE_OPTION_CUR_HOTSPOT_X) )
 
     // In case this is a cursor, make sure the hotspot is scalled accordingly:
     if ( HasOption(wxIMAGE_OPTION_CUR_HOTSPOT_X) )


@@ -292,9 +403,9 @@ wxImage wxImage::Rotate90( bool clockwise ) const
 
     wxCHECK_MSG( Ok(), image, wxT("invalid image") );
 
 
     wxCHECK_MSG( Ok(), image, wxT("invalid image") );
 

-    image.Create( M_IMGDATA->m_height, M_IMGDATA->m_width );
+    image.Create( M_IMGDATA->m_height, M_IMGDATA->m_width, false );

 
 

-    char unsigned *data = image.GetData();
+    unsigned char *data = image.GetData();

 
     wxCHECK_MSG( data, image, wxT("unable to create image") );
 
 
     wxCHECK_MSG( data, image, wxT("unable to create image") );
 


@@ -304,8 +415,8 @@ wxImage wxImage::Rotate90( bool clockwise ) const
     long height = M_IMGDATA->m_height;
     long width  = M_IMGDATA->m_width;
 
     long height = M_IMGDATA->m_height;
     long width  = M_IMGDATA->m_width;
 

-    char unsigned *source_data = M_IMGDATA->m_data;
-    char unsigned *target_data;
+    unsigned char *source_data = M_IMGDATA->m_data;
+    unsigned char *target_data;

 
     for (long j = 0; j < height; j++)
     {
 
     for (long j = 0; j < height; j++)
     {


@@ -329,9 +440,9 @@ wxImage wxImage::Mirror( bool horizontally ) const
 
     wxCHECK_MSG( Ok(), image, wxT("invalid image") );
 
 
     wxCHECK_MSG( Ok(), image, wxT("invalid image") );
 

-    image.Create( M_IMGDATA->m_width, M_IMGDATA->m_height );
+    image.Create( M_IMGDATA->m_width, M_IMGDATA->m_height, false );

 
 

-    char unsigned *data = image.GetData();
+    unsigned char *data = image.GetData();

 
     wxCHECK_MSG( data, image, wxT("unable to create image") );
 
 
     wxCHECK_MSG( data, image, wxT("unable to create image") );
 


@@ -341,8 +452,8 @@ wxImage wxImage::Mirror( bool horizontally ) const
     long height = M_IMGDATA->m_height;
     long width  = M_IMGDATA->m_width;
 
     long height = M_IMGDATA->m_height;
     long width  = M_IMGDATA->m_width;
 

-    char unsigned *source_data = M_IMGDATA->m_data;
-    char unsigned *target_data;
+    unsigned char *source_data = M_IMGDATA->m_data;
+    unsigned char *target_data;

 
     if (horizontally)
     {
 
     if (horizontally)
     {


@@ -383,9 +494,9 @@ wxImage wxImage::GetSubImage( const wxRect &rect ) const
     int subwidth=rect.GetWidth();
     const int subheight=rect.GetHeight();
 
     int subwidth=rect.GetWidth();
     const int subheight=rect.GetHeight();
 

-    image.Create( subwidth, subheight );
+    image.Create( subwidth, subheight, false );

 
 

-    char unsigned *subdata = image.GetData(), *data=GetData();
+    unsigned char *subdata = image.GetData(), *data=GetData();

 
     wxCHECK_MSG( subdata, image, wxT("unable to create image") );
 
 
     wxCHECK_MSG( subdata, image, wxT("unable to create image") );
 


@@ -493,7 +604,7 @@ void wxImage::Replace( unsigned char r1, unsigned char g1, unsigned char b1,
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 

-    char unsigned *data = GetData();
+    unsigned char *data = GetData();

 
     const int w = GetWidth();
     const int h = GetHeight();
 
     const int w = GetWidth();
     const int h = GetHeight();


@@ -517,9 +628,9 @@ wxImage wxImage::ConvertToMono( unsigned char r, unsigned char g, unsigned char
 
     wxCHECK_MSG( Ok(), image, wxT("invalid image") );
 
 
     wxCHECK_MSG( Ok(), image, wxT("invalid image") );
 

-    image.Create( M_IMGDATA->m_width, M_IMGDATA->m_height );
+    image.Create( M_IMGDATA->m_width, M_IMGDATA->m_height, false );

 
 

-    char unsigned *data = image.GetData();
+    unsigned char *data = image.GetData();

 
     wxCHECK_MSG( data, image, wxT("unable to create image") );
 
 
     wxCHECK_MSG( data, image, wxT("unable to create image") );
 


@@ -534,8 +645,8 @@ wxImage wxImage::ConvertToMono( unsigned char r, unsigned char g, unsigned char
 
     long size = M_IMGDATA->m_height * M_IMGDATA->m_width;
 
 
     long size = M_IMGDATA->m_height * M_IMGDATA->m_width;
 

-    char unsigned *srcd = M_IMGDATA->m_data;
-    char unsigned *tard = image.GetData();
+    unsigned char *srcd = M_IMGDATA->m_data;
+    unsigned char *tard = image.GetData();

 
     for ( long i = 0; i < size; i++, srcd += 3, tard += 3 )
     {
 
     for ( long i = 0; i < size; i++, srcd += 3, tard += 3 )
     {


@@ -614,14 +725,14 @@ bool wxImage::Ok() const
     return data && data->m_ok && data->m_width && data->m_height;
 }
 
     return data && data->m_ok && data->m_width && data->m_height;
 }
 

-char unsigned *wxImage::GetData() const
+unsigned char *wxImage::GetData() const

 {
 {

-    wxCHECK_MSG( Ok(), (char unsigned *)NULL, wxT("invalid image") );
+    wxCHECK_MSG( Ok(), (unsigned char *)NULL, wxT("invalid image") );

 
     return M_IMGDATA->m_data;
 }
 
 
     return M_IMGDATA->m_data;
 }
 

-void wxImage::SetData( char unsigned *data )
+void wxImage::SetData( unsigned char *data )

 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 


@@ -630,7 +741,7 @@ void wxImage::SetData( char unsigned *data )
     newRefData->m_width = M_IMGDATA->m_width;
     newRefData->m_height = M_IMGDATA->m_height;
     newRefData->m_data = data;
     newRefData->m_width = M_IMGDATA->m_width;
     newRefData->m_height = M_IMGDATA->m_height;
     newRefData->m_data = data;

-    newRefData->m_ok = TRUE;
+    newRefData->m_ok = true;

     newRefData->m_maskRed = M_IMGDATA->m_maskRed;
     newRefData->m_maskGreen = M_IMGDATA->m_maskGreen;
     newRefData->m_maskBlue = M_IMGDATA->m_maskBlue;
     newRefData->m_maskRed = M_IMGDATA->m_maskRed;
     newRefData->m_maskGreen = M_IMGDATA->m_maskGreen;
     newRefData->m_maskBlue = M_IMGDATA->m_maskBlue;


@@ -641,7 +752,7 @@ void wxImage::SetData( char unsigned *data )
     m_refData = newRefData;
 }
 
     m_refData = newRefData;
 }
 

-void wxImage::SetData( char unsigned *data, int new_width, int new_height )
+void wxImage::SetData( unsigned char *data, int new_width, int new_height )

 {
     wxImageRefData *newRefData = new wxImageRefData();
 
 {
     wxImageRefData *newRefData = new wxImageRefData();
 


@@ -650,7 +761,7 @@ void wxImage::SetData( char unsigned *data, int new_width, int new_height )
         newRefData->m_width = new_width;
         newRefData->m_height = new_height;
         newRefData->m_data = data;
         newRefData->m_width = new_width;
         newRefData->m_height = new_height;
         newRefData->m_data = data;

-        newRefData->m_ok = TRUE;
+        newRefData->m_ok = true;

         newRefData->m_maskRed = M_IMGDATA->m_maskRed;
         newRefData->m_maskGreen = M_IMGDATA->m_maskGreen;
         newRefData->m_maskBlue = M_IMGDATA->m_maskBlue;
         newRefData->m_maskRed = M_IMGDATA->m_maskRed;
         newRefData->m_maskGreen = M_IMGDATA->m_maskGreen;
         newRefData->m_maskBlue = M_IMGDATA->m_maskBlue;


@@ -661,7 +772,7 @@ void wxImage::SetData( char unsigned *data, int new_width, int new_height )
         newRefData->m_width = new_width;
         newRefData->m_height = new_height;
         newRefData->m_data = data;
         newRefData->m_width = new_width;
         newRefData->m_height = new_height;
         newRefData->m_data = data;

-        newRefData->m_ok = TRUE;
+        newRefData->m_ok = true;

     }
 
     UnRef();
     }
 
     UnRef();


@@ -669,6 +780,58 @@ void wxImage::SetData( char unsigned *data, int new_width, int new_height )
     m_refData = newRefData;
 }
 
     m_refData = newRefData;
 }
 

+// ----------------------------------------------------------------------------
+// alpha channel support
+// ----------------------------------------------------------------------------
+
+void wxImage::SetAlpha(int x, int y, unsigned char alpha)
+{
+    wxCHECK_RET( Ok() && HasAlpha(), wxT("invalid image or no alpha channel") );
+
+    int w = M_IMGDATA->m_width,
+        h = M_IMGDATA->m_height;
+
+    wxCHECK_RET( x >=0 && y >= 0 && x < w && y < h, wxT("invalid image index") );
+
+    M_IMGDATA->m_alpha[y*w + x] = alpha;
+}
+
+unsigned char wxImage::GetAlpha(int x, int y) const
+{
+    wxCHECK_MSG( Ok() && HasAlpha(), 0, wxT("invalid image or no alpha channel") );
+
+    int w = M_IMGDATA->m_width,
+        h = M_IMGDATA->m_height;
+
+    wxCHECK_MSG( x >=0 && y >= 0 && x < w && y < h, 0, wxT("invalid image index") );
+
+    return M_IMGDATA->m_alpha[y*w + x];
+}
+
+void wxImage::SetAlpha( unsigned char *alpha )
+{
+    wxCHECK_RET( Ok(), wxT("invalid image") );
+
+    if ( !alpha )
+    {
+        alpha = (unsigned char *)malloc(M_IMGDATA->m_width*M_IMGDATA->m_height);
+    }
+
+    free(M_IMGDATA->m_alpha);
+    M_IMGDATA->m_alpha = alpha;
+}
+
+unsigned char *wxImage::GetAlpha() const
+{
+    wxCHECK_MSG( Ok(), (unsigned char *)NULL, wxT("invalid image") );
+
+    return M_IMGDATA->m_alpha;
+}
+
+// ----------------------------------------------------------------------------
+// mask support
+// ----------------------------------------------------------------------------
+

 void wxImage::SetMaskColour( unsigned char r, unsigned char g, unsigned char b )
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 void wxImage::SetMaskColour( unsigned char r, unsigned char g, unsigned char b )
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );


@@ -676,7 +839,7 @@ void wxImage::SetMaskColour( unsigned char r, unsigned char g, unsigned char b )
     M_IMGDATA->m_maskRed = r;
     M_IMGDATA->m_maskGreen = g;
     M_IMGDATA->m_maskBlue = b;
     M_IMGDATA->m_maskRed = r;
     M_IMGDATA->m_maskGreen = g;
     M_IMGDATA->m_maskBlue = b;

-    M_IMGDATA->m_hasMask = TRUE;
+    M_IMGDATA->m_hasMask = true;

 }
 
 unsigned char wxImage::GetMaskRed() const
 }
 
 unsigned char wxImage::GetMaskRed() const


@@ -709,7 +872,7 @@ void wxImage::SetMask( bool mask )
 
 bool wxImage::HasMask() const
 {
 
 bool wxImage::HasMask() const
 {

-    wxCHECK_MSG( Ok(), FALSE, wxT("invalid image") );
+    wxCHECK_MSG( Ok(), false, wxT("invalid image") );

 
     return M_IMGDATA->m_hasMask;
 }
 
     return M_IMGDATA->m_hasMask;
 }


@@ -728,73 +891,26 @@ int wxImage::GetHeight() const
     return M_IMGDATA->m_height;
 }
 
     return M_IMGDATA->m_height;
 }
 

-
-bool wxImage::FindFirstUnusedColour(
-            unsigned char *r, unsigned char *g, unsigned char *b,
-            unsigned char startR, unsigned char startG, unsigned char startB) const
-{
-    wxImageHistogram histogram;
-    unsigned long key;
-   
-    ComputeHistogram(histogram);
-    
-    unsigned char r2 = startR;
-    unsigned char g2 = startG;
-    unsigned char b2 = startB;
-    
-    key = (r2 << 16) | (g2 << 8) | b2;
-
-    while ( histogram.find(key) != histogram.end() )
-    {
-        // color already used
-        r2++;
-        if ( r2 >= 255 )
-        {
-            r2 = 0;
-            g2++;
-            if ( g2 >= 255 )
-            {
-                g2 = 0;
-                b2++;
-                if ( b2 >= 255 )
-                {
-                    wxLogError( _("GetUnusedColour:: No Unused Color in image ") );            
-                    return FALSE;                              
-                }
-            }
-        }
-        
-        key = (r2 << 16) | (g2 << 8) | b2;
-    }
-    
-    if (r) *r = r2;
-    if (g) *g = g2;
-    if (b) *b = b2;
-    
-    return TRUE;
-}
-
-
-bool wxImage::SetMaskFromImage(const wxImage& mask, 
+bool wxImage::SetMaskFromImage(const wxImage& mask,

                                unsigned char mr, unsigned char mg, unsigned char mb)
 {
     // check that the images are the same size
     if ( (M_IMGDATA->m_height != mask.GetHeight() ) || (M_IMGDATA->m_width != mask.GetWidth () ) )
     {
                                unsigned char mr, unsigned char mg, unsigned char mb)
 {
     // check that the images are the same size
     if ( (M_IMGDATA->m_height != mask.GetHeight() ) || (M_IMGDATA->m_width != mask.GetWidth () ) )
     {

-        wxLogError( _("Image and Mask have different sizes") );            
-        return FALSE;
+        wxLogError( _("Image and mask have different sizes.") );
+        return false;

     }
     }

-    
+

     // find unused colour
     unsigned char r,g,b ;
     if (!FindFirstUnusedColour(&r, &g, &b))
     {
     // find unused colour
     unsigned char r,g,b ;
     if (!FindFirstUnusedColour(&r, &g, &b))
     {

-        wxLogError( _("No Unused Color in image being masked") );            
-        return FALSE ;
+        wxLogError( _("No unused colour in image being masked.") );
+        return false ;

     }
     }

-        
-    char unsigned *imgdata = GetData();
-    char unsigned *maskdata = mask.GetData();
+
+    unsigned char *imgdata = GetData();
+    unsigned char *maskdata = mask.GetData();

 
     const int w = GetWidth();
     const int h = GetHeight();
 
     const int w = GetWidth();
     const int h = GetHeight();


@@ -815,253 +931,51 @@ bool wxImage::SetMaskFromImage(const wxImage& mask,
     }
 
     SetMaskColour(r, g, b);
     }
 
     SetMaskColour(r, g, b);

-    SetMask(TRUE);
-    
-    return TRUE;
-}
+    SetMask(true);

 
 

-
-// DoFloodFill
-// Fills with the colour extracted from fillBrush, starting at x,y until either
-// a color different from the start pixel is reached (wxFLOOD_SURFACE)
-// or fill color is reached (wxFLOOD_BORDER)
-
-bool wxImage::MatchPixel(int x, int y, int w, int h, const wxColour & c)
-{
-    if ((x<0)||(x>=w)||(y<0)||(y>=h)) return false;
-
-    unsigned char r = GetRed(x,y);
-    unsigned char g = GetGreen(x,y);
-    unsigned char b = GetBlue(x,y);
-    return c.Red() == r && c.Green() == g && c.Blue() == b ;
+    return true;

 }
 
 }
 

-bool wxImage::MatchBoundaryPixel(int x, int y, int w, int h, const wxColour & fill, const wxColour & bound)
+bool wxImage::ConvertAlphaToMask(unsigned char threshold)

 {
 {

-    if ((x<0)||(x>=w)||(y<0)||(y>=h)) return TRUE;
+    if (!HasAlpha())
+        return true;

 
 

-    unsigned char r = GetRed(x,y);
-    unsigned char g = GetGreen(x,y);
-    unsigned char b = GetBlue(x,y);
-    if ( fill.Red() == r && fill.Green() == g && fill.Blue() == b ) return TRUE;
-    if ( bound.Red() == r && bound.Green() == g && bound.Blue() == b ) return TRUE;
-    return FALSE ;
-}
-
-
-void wxImage::DoFloodFill (wxCoord x, wxCoord y, const wxBrush & fillBrush,
-        const wxColour& testColour, int style /*=wxFLOOD_SURFACE */,
-        int LogicalFunction /*= wxCOPY, currently unused */)
-{
-    /* A diamond flood-fill using a circular queue system.
-    Each pixel surrounding the current pixel is added to
-    the queue if it meets the criteria, then is retrieved in
-    its turn.  Code originally based on http://www.drawit.co.nz/Developers.htm */
-
-    int width = GetWidth();
-    int height = GetHeight();
-
-    //Draw using a pen made from the current brush colour
-    //Potentially allows us to use patterned flood fills in future code
-    wxColour fillColour = fillBrush.GetColour();
-    unsigned char r = fillColour.Red();
-    unsigned char g = fillColour.Green();
-    unsigned char b = fillColour.Blue();
-
-    //initial test :
-    if (style == wxFLOOD_SURFACE)
+    unsigned char mr, mg, mb;
+    if (!FindFirstUnusedColour(&mr, &mg, &mb))

     {
     {

-       //if wxFLOOD_SURFACE, if fill colour is same as required, we don't do anything
-       if (     GetRed(x,y)   != r
-             || GetGreen(x,y) != g
-             || GetBlue (x,y) != b   )
-        {
-        //prepare memory for queue
-        //queue save, start, read
-        size_t *qs, *qst, *qr;
-
-        //queue size (physical)
-        long qSz= height * width * 2;
-        qst = new size_t [qSz];
-
-        //temporary x and y locations
-        int xt, yt;
+        wxLogError( _("No unused colour in image being masked.") );
+        return false;
+    }

 
 

-        for (int i=0; i < qSz; i++)
-            qst[i] = 0;
+    SetMask(true);
+    SetMaskColour(mr, mg, mb);

 
 

-        // start queue
-        qs=qr=qst;
-        *qs=xt=x;
-        qs++;
-        *qs=yt=y;
-        qs++;
+    unsigned char *imgdata = GetData();
+    unsigned char *alphadata = GetAlpha();

 
 

-        SetRGB(xt,yt,r,g,b);
+    int w = GetWidth();
+    int h = GetHeight();

 
 

-        //Main queue loop
-        while(qr!=qs)
+    for (int y = 0; y < h; y++)
+    {
+        for (int x = 0; x < w; x++, imgdata += 3, alphadata++)

         {
         {

-            //Add new members to queue
-            //Above current pixel
-            if(MatchPixel(xt,yt-1,width,height,testColour))
-            {
-                *qs=xt;
-                qs++;
-                *qs=yt-1;
-                qs++;
-                SetRGB(xt,yt-1,r,g,b);
-
-                //Loop back to beginning of queue
-                if(qs>=(qst+qSz)) qs=qst;
-            }
-
-            //Below current pixel
-            if(MatchPixel(xt,yt+1,width,height,testColour))
-            {
-                *qs=xt;
-                qs++;
-                *qs=yt+1;
-                qs++;
-                SetRGB(xt,yt+1,r,g,b);
-                if(qs>=(qst+qSz)) qs=qst;
-            }
-
-            //Left of current pixel
-            if(MatchPixel(xt-1,yt,width,height,testColour))
-            {
-                *qs=xt-1;
-                qs++;
-                *qs=yt;
-                qs++;
-                SetRGB(xt-1,yt,r,g,b);
-                if(qs>=(qst+qSz)) qs=qst;
-            }
-
-            //Right of current pixel
-            if(MatchPixel(xt+1,yt,width,height,testColour))
+            if (*alphadata < threshold)

             {
             {

-                *qs=xt+1;
-                qs++;
-                *qs=yt;
-                qs++;
-                SetRGB(xt+1,yt,r,g,b);
-                if(qs>=(qst+qSz)) qs=qst;
+                imgdata[0] = mr;
+                imgdata[1] = mg;
+                imgdata[2] = mb;

             }
             }

-
-            //Retrieve current queue member
-            qr+=2;
-
-            //Loop back to the beginning
-            if(qr>=(qst+qSz)) qr=qst;
-            xt=*qr;
-            yt=*(qr+1);
-
-        //Go Back to beginning of loop
-        }
-
-        delete [] qst ;

         }
     }
         }
     }

-    else
-    {
-    //style is wxFLOOD_BORDER
-    // fill up to testColor border - if already testColour don't do anything
-    if (  GetRed(x,y)   != testColour.Red()
-       || GetGreen(x,y) != testColour.Green()
-       || GetBlue(x,y)  != testColour.Blue()   )
-        {
-        //prepare memory for queue
-        //queue save, start, read
-        size_t *qs, *qst, *qr;
-
-        //queue size (physical)
-        long qSz= height * width * 2;
-        qst = new size_t [qSz];
-
-        //temporary x and y locations
-        int xt, yt;
-
-        for (int i=0; i < qSz; i++)
-            qst[i] = 0;
-
-        // start queue
-        qs=qr=qst;
-        *qs=xt=x;
-        qs++;
-        *qs=yt=y;
-        qs++;
-
-        SetRGB(xt,yt,r,g,b);
-
-        //Main queue loop
-        while(qr!=qs)
-        {
-            //Add new members to queue
-            //Above current pixel
-            if(!MatchBoundaryPixel(xt,yt-1,width,height,fillColour,testColour))
-            {
-                *qs=xt;
-                qs++;
-                *qs=yt-1;
-                qs++;
-                SetRGB(xt,yt-1,r,g,b);
-
-                //Loop back to beginning of queue
-                if(qs>=(qst+qSz)) qs=qst;
-            }
-
-            //Below current pixel
-            if(!MatchBoundaryPixel(xt,yt+1,width,height,fillColour,testColour))
-            {
-                *qs=xt;
-                qs++;
-                *qs=yt+1;
-                qs++;
-                SetRGB(xt,yt+1,r,g,b);
-                if(qs>=(qst+qSz)) qs=qst;
-            }
-
-            //Left of current pixel
-            if(!MatchBoundaryPixel(xt-1,yt,width,height,fillColour,testColour))
-            {
-                *qs=xt-1;
-                qs++;
-                *qs=yt;
-                qs++;
-                SetRGB(xt-1,yt,r,g,b);
-                if(qs>=(qst+qSz)) qs=qst;
-            }
-
-            //Right of current pixel
-            if(!MatchBoundaryPixel(xt+1,yt,width,height,fillColour,testColour))
-            {
-                *qs=xt+1;
-                qs++;
-                *qs=yt;
-                qs++;
-                SetRGB(xt+1,yt,r,g,b);
-                if(qs>=(qst+qSz)) qs=qst;
-            }
-
-            //Retrieve current queue member
-            qr+=2;

 
 

-            //Loop back to the beginning
-            if(qr>=(qst+qSz)) qr=qst;
-            xt=*qr;
-            yt=*(qr+1);
+    free(M_IMGDATA->m_alpha);
+    M_IMGDATA->m_alpha = NULL;

 
 

-        //Go Back to beginning of loop
-        }
-
-        delete [] qst ;
-        }
-    }
-    //all done,
+    return true;

 }
 
 }
 

-

 #if wxUSE_PALETTE
 
 // Palette functions
 #if wxUSE_PALETTE
 
 // Palette functions


@@ -1069,7 +983,7 @@ void wxImage::DoFloodFill (wxCoord x, wxCoord y, const wxBrush & fillBrush,
 bool wxImage::HasPalette() const
 {
     if (!Ok())
 bool wxImage::HasPalette() const
 {
     if (!Ok())

-        return FALSE;
+        return false;

 
     return M_IMGDATA->m_palette.Ok();
 }
 
     return M_IMGDATA->m_palette.Ok();
 }


@@ -1095,7 +1009,7 @@ void wxImage::SetOption(const wxString& name, const wxString& value)
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 
 {
     wxCHECK_RET( Ok(), wxT("invalid image") );
 

-    int idx = M_IMGDATA->m_optionNames.Index(name, FALSE);
+    int idx = M_IMGDATA->m_optionNames.Index(name, false);

     if (idx == wxNOT_FOUND)
     {
         M_IMGDATA->m_optionNames.Add(name);
     if (idx == wxNOT_FOUND)
     {
         M_IMGDATA->m_optionNames.Add(name);


@@ -1119,7 +1033,7 @@ wxString wxImage::GetOption(const wxString& name) const
 {
     wxCHECK_MSG( Ok(), wxEmptyString, wxT("invalid image") );
 
 {
     wxCHECK_MSG( Ok(), wxEmptyString, wxT("invalid image") );
 

-    int idx = M_IMGDATA->m_optionNames.Index(name, FALSE);
+    int idx = M_IMGDATA->m_optionNames.Index(name, false);

     if (idx == wxNOT_FOUND)
         return wxEmptyString;
     else
     if (idx == wxNOT_FOUND)
         return wxEmptyString;
     else


@@ -1135,9 +1049,9 @@ int wxImage::GetOptionInt(const wxString& name) const
 
 bool wxImage::HasOption(const wxString& name) const
 {
 
 bool wxImage::HasOption(const wxString& name) const
 {

-    wxCHECK_MSG( Ok(), FALSE, wxT("invalid image") );
+    wxCHECK_MSG( Ok(), false, wxT("invalid image") );

 
 

-    return (M_IMGDATA->m_optionNames.Index(name, FALSE) != wxNOT_FOUND);
+    return (M_IMGDATA->m_optionNames.Index(name, false) != wxNOT_FOUND);

 }
 
 bool wxImage::LoadFile( const wxString& filename, long type, int index )
 }
 
 bool wxImage::LoadFile( const wxString& filename, long type, int index )


@@ -1153,10 +1067,10 @@ bool wxImage::LoadFile( const wxString& filename, long type, int index )
     {
         wxLogError( _("Can't load image from file '%s': file does not exist."), filename.c_str() );
 
     {
         wxLogError( _("Can't load image from file '%s': file does not exist."), filename.c_str() );
 

-        return FALSE;
+        return false;

     }
 #else // !wxUSE_STREAMS
     }
 #else // !wxUSE_STREAMS

-    return FALSE;
+    return false;

 #endif // wxUSE_STREAMS
 }
 
 #endif // wxUSE_STREAMS
 }
 


@@ -1173,10 +1087,10 @@ bool wxImage::LoadFile( const wxString& filename, const wxString& mimetype, int
     {
         wxLogError( _("Can't load image from file '%s': file does not exist."), filename.c_str() );
 
     {
         wxLogError( _("Can't load image from file '%s': file does not exist."), filename.c_str() );
 

-        return FALSE;
+        return false;

     }
 #else // !wxUSE_STREAMS
     }
 #else // !wxUSE_STREAMS

-    return FALSE;
+    return false;

 #endif // wxUSE_STREAMS
 }
 
 #endif // wxUSE_STREAMS
 }
 


@@ -1185,17 +1099,17 @@ bool wxImage::LoadFile( const wxString& filename, const wxString& mimetype, int
 bool wxImage::SaveFile( const wxString& filename ) const
 {
     wxString ext = filename.AfterLast('.').Lower();
 bool wxImage::SaveFile( const wxString& filename ) const
 {
     wxString ext = filename.AfterLast('.').Lower();

-    
+

     wxImageHandler * pHandler = FindHandler(ext, -1);
     if (pHandler)
     {
         SaveFile(filename, pHandler->GetType());
     wxImageHandler * pHandler = FindHandler(ext, -1);
     if (pHandler)
     {
         SaveFile(filename, pHandler->GetType());

-        return TRUE;
+        return true;

     }
 
     wxLogError(_("Can't save image to file '%s': unknown extension."), filename.c_str());
 
     }
 
     wxLogError(_("Can't save image to file '%s': unknown extension."), filename.c_str());
 

-    return FALSE;
+    return false;

 }
 
 bool wxImage::SaveFile( const wxString& filename, int type ) const
 }
 
 bool wxImage::SaveFile( const wxString& filename, int type ) const


@@ -1205,14 +1119,14 @@ bool wxImage::SaveFile( const wxString& filename, int type ) const
 
     wxFileOutputStream stream(filename);
 
 
     wxFileOutputStream stream(filename);
 

-    if ( stream.LastError() == wxStream_NOERROR )
+    if ( stream.IsOk() )

     {
         wxBufferedOutputStream bstream( stream );
         return SaveFile(bstream, type);
     }
 #endif // wxUSE_STREAMS
 
     {
         wxBufferedOutputStream bstream( stream );
         return SaveFile(bstream, type);
     }
 #endif // wxUSE_STREAMS
 

-    return FALSE;
+    return false;

 }
 
 bool wxImage::SaveFile( const wxString& filename, const wxString& mimetype ) const
 }
 
 bool wxImage::SaveFile( const wxString& filename, const wxString& mimetype ) const


@@ -1222,14 +1136,14 @@ bool wxImage::SaveFile( const wxString& filename, const wxString& mimetype ) con
 
     wxFileOutputStream stream(filename);
 
 
     wxFileOutputStream stream(filename);
 

-    if ( stream.LastError() == wxStream_NOERROR )
+    if ( stream.IsOk() )

     {
         wxBufferedOutputStream bstream( stream );
         return SaveFile(bstream, mimetype);
     }
 #endif // wxUSE_STREAMS
 
     {
         wxBufferedOutputStream bstream( stream );
         return SaveFile(bstream, mimetype);
     }
 #endif // wxUSE_STREAMS
 

-    return FALSE;
+    return false;

 }
 
 bool wxImage::CanRead( const wxString &name )
 }
 
 bool wxImage::CanRead( const wxString &name )


@@ -1238,7 +1152,7 @@ bool wxImage::CanRead( const wxString &name )
   wxFileInputStream stream(name);
   return CanRead(stream);
 #else
   wxFileInputStream stream(name);
   return CanRead(stream);
 #else

-  return FALSE;
+  return false;

 #endif
 }
 
 #endif
 }
 


@@ -1246,26 +1160,27 @@ int wxImage::GetImageCount( const wxString &name, long type )
 {
 #if wxUSE_STREAMS
   wxFileInputStream stream(name);
 {
 #if wxUSE_STREAMS
   wxFileInputStream stream(name);

-  return GetImageCount(stream, type);
-#else
-  return 0;
+  if (stream.Ok())
+      return GetImageCount(stream, type);

 #endif
 #endif

+
+  return 0;

 }
 
 #if wxUSE_STREAMS
 
 bool wxImage::CanRead( wxInputStream &stream )
 {
 }
 
 #if wxUSE_STREAMS
 
 bool wxImage::CanRead( wxInputStream &stream )
 {

-    wxList &list=GetHandlers();
+    const wxList& list = GetHandlers();

 
 

-    for ( wxList::Node *node = list.GetFirst(); node; node = node->GetNext() )
+    for ( wxList::compatibility_iterator node = list.GetFirst(); node; node = node->GetNext() )

     {
         wxImageHandler *handler=(wxImageHandler*)node->GetData();
         if (handler->CanRead( stream ))
     {
         wxImageHandler *handler=(wxImageHandler*)node->GetData();
         if (handler->CanRead( stream ))

-            return TRUE;
+            return true;

     }
 
     }
 

-    return FALSE;
+    return false;

 }
 
 int wxImage::GetImageCount( wxInputStream &stream, long type )
 }
 
 int wxImage::GetImageCount( wxInputStream &stream, long type )


@@ -1276,7 +1191,7 @@ int wxImage::GetImageCount( wxInputStream &stream, long type )
     {
         wxList &list=GetHandlers();
 
     {
         wxList &list=GetHandlers();
 

-        for (wxList::Node *node = list.GetFirst(); node; node = node->GetNext())
+        for (wxList::compatibility_iterator node = list.GetFirst(); node; node = node->GetNext())

         {
              handler=(wxImageHandler*)node->GetData();
              if ( handler->CanRead(stream) )
         {
              handler=(wxImageHandler*)node->GetData();
              if ( handler->CanRead(stream) )


@@ -1293,7 +1208,7 @@ int wxImage::GetImageCount( wxInputStream &stream, long type )
     if ( !handler )
     {
         wxLogWarning(_("No image handler for type %d defined."), type);
     if ( !handler )
     {
         wxLogWarning(_("No image handler for type %d defined."), type);

-        return FALSE;
+        return false;

     }
 
     if ( handler->CanRead(stream) )
     }
 
     if ( handler->CanRead(stream) )


@@ -1319,28 +1234,28 @@ bool wxImage::LoadFile( wxInputStream& stream, long type, int index )
     {
         wxList &list=GetHandlers();
 
     {
         wxList &list=GetHandlers();
 

-        for ( wxList::Node *node = list.GetFirst(); node; node = node->GetNext() )
+        for ( wxList::compatibility_iterator node = list.GetFirst(); node; node = node->GetNext() )

         {
              handler=(wxImageHandler*)node->GetData();
              if ( handler->CanRead(stream) )
         {
              handler=(wxImageHandler*)node->GetData();
              if ( handler->CanRead(stream) )

-                 return handler->LoadFile(this, stream, TRUE/*verbose*/, index);
+                 return handler->LoadFile(this, stream, true/*verbose*/, index);

 
         }
 
         wxLogWarning( _("No handler found for image type.") );
 
         }
 
         wxLogWarning( _("No handler found for image type.") );

-        return FALSE;
+        return false;

     }
 
     handler = FindHandler(type);
 
     }
 
     handler = FindHandler(type);
 

-    if (handler == NULL)
+    if (handler == 0)

     {
         wxLogWarning( _("No image handler for type %d defined."), type );
 
     {
         wxLogWarning( _("No image handler for type %d defined."), type );
 

-        return FALSE;
+        return false;

     }
 
     }
 

-    return handler->LoadFile(this, stream, TRUE/*verbose*/, index);
+    return handler->LoadFile(this, stream, true/*verbose*/, index);

 }
 
 bool wxImage::LoadFile( wxInputStream& stream, const wxString& mimetype, int index )
 }
 
 bool wxImage::LoadFile( wxInputStream& stream, const wxString& mimetype, int index )


@@ -1351,27 +1266,27 @@ bool wxImage::LoadFile( wxInputStream& stream, const wxString& mimetype, int ind
 
     wxImageHandler *handler = FindHandlerMime(mimetype);
 
 
     wxImageHandler *handler = FindHandlerMime(mimetype);
 

-    if (handler == NULL)
+    if (handler == 0)

     {
         wxLogWarning( _("No image handler for type %s defined."), mimetype.GetData() );
 
     {
         wxLogWarning( _("No image handler for type %s defined."), mimetype.GetData() );
 

-        return FALSE;
+        return false;

     }
 
     }
 

-    return handler->LoadFile( this, stream, TRUE/*verbose*/, index );
+    return handler->LoadFile( this, stream, true/*verbose*/, index );

 }
 
 bool wxImage::SaveFile( wxOutputStream& stream, int type ) const
 {
 }
 
 bool wxImage::SaveFile( wxOutputStream& stream, int type ) const
 {

-    wxCHECK_MSG( Ok(), FALSE, wxT("invalid image") );
+    wxCHECK_MSG( Ok(), false, wxT("invalid image") );

 
     wxImageHandler *handler = FindHandler(type);
 
 
     wxImageHandler *handler = FindHandler(type);
 

-    if (handler == NULL)
+    if (handler == 0)

     {
         wxLogWarning( _("No image handler for type %d defined."), type );
 
     {
         wxLogWarning( _("No image handler for type %d defined."), type );
 

-        return FALSE;
+        return false;

     }
 
     return handler->SaveFile( (wxImage*)this, stream );
     }
 
     return handler->SaveFile( (wxImage*)this, stream );


@@ -1379,15 +1294,15 @@ bool wxImage::SaveFile( wxOutputStream& stream, int type ) const
 
 bool wxImage::SaveFile( wxOutputStream& stream, const wxString& mimetype ) const
 {
 
 bool wxImage::SaveFile( wxOutputStream& stream, const wxString& mimetype ) const
 {

-    wxCHECK_MSG( Ok(), FALSE, wxT("invalid image") );
+    wxCHECK_MSG( Ok(), false, wxT("invalid image") );

 
     wxImageHandler *handler = FindHandlerMime(mimetype);
 
 
     wxImageHandler *handler = FindHandlerMime(mimetype);
 

-    if (handler == NULL)
+    if (handler == 0)

     {
         wxLogWarning( _("No image handler for type %s defined."), mimetype.GetData() );
 
     {
         wxLogWarning( _("No image handler for type %s defined."), mimetype.GetData() );
 

-        return FALSE;
+        return false;

     }
 
     return handler->SaveFile( (wxImage*)this, stream );
     }
 
     return handler->SaveFile( (wxImage*)this, stream );


@@ -1396,18 +1311,39 @@ bool wxImage::SaveFile( wxOutputStream& stream, const wxString& mimetype ) const
 
 void wxImage::AddHandler( wxImageHandler *handler )
 {
 
 void wxImage::AddHandler( wxImageHandler *handler )
 {

-    // make sure that the memory will be freed at the program end
-    sm_handlers.DeleteContents(TRUE);
-
-    sm_handlers.Append( handler );
+    // Check for an existing handler of the type being added.
+    if (FindHandler( handler->GetType() ) == 0)
+    {
+        sm_handlers.Append( handler );
+    }
+    else
+    {
+        // This is not documented behaviour, merely the simplest 'fix'
+        // for preventing duplicate additions.  If someone ever has
+        // a good reason to add and remove duplicate handlers (and they
+        // may) we should probably refcount the duplicates.
+        //   also an issue in InsertHandler below.
+
+        wxLogDebug( _T("Adding duplicate image handler for '%s'"),
+                    handler->GetName().c_str() );
+        delete handler;
+    }

 }
 
 void wxImage::InsertHandler( wxImageHandler *handler )
 {
 }
 
 void wxImage::InsertHandler( wxImageHandler *handler )
 {

-    // make sure that the memory will be freed at the program end
-    sm_handlers.DeleteContents(TRUE);
-
-    sm_handlers.Insert( handler );
+    // Check for an existing handler of the type being added.
+    if (FindHandler( handler->GetType() ) == 0)
+    {
+        sm_handlers.Insert( handler );
+    }
+    else
+    {
+        // see AddHandler for additional comments.
+        wxLogDebug( _T("Inserting duplicate image handler for '%s'"),
+                    handler->GetName().c_str() );
+        delete handler;
+    }

 }
 
 bool wxImage::RemoveHandler( const wxString& name )
 }
 
 bool wxImage::RemoveHandler( const wxString& name )


@@ -1416,61 +1352,62 @@ bool wxImage::RemoveHandler( const wxString& name )
     if (handler)
     {
         sm_handlers.DeleteObject(handler);
     if (handler)
     {
         sm_handlers.DeleteObject(handler);

-        return TRUE;
+        delete handler;
+        return true;

     }
     else
     }
     else

-        return FALSE;
+        return false;

 }
 
 wxImageHandler *wxImage::FindHandler( const wxString& name )
 {
 }
 
 wxImageHandler *wxImage::FindHandler( const wxString& name )
 {

-    wxNode *node = sm_handlers.First();
+    wxList::compatibility_iterator node = sm_handlers.GetFirst();

     while (node)
     {
     while (node)
     {

-        wxImageHandler *handler = (wxImageHandler*)node->Data();
+        wxImageHandler *handler = (wxImageHandler*)node->GetData();

         if (handler->GetName().Cmp(name) == 0) return handler;
 
         if (handler->GetName().Cmp(name) == 0) return handler;
 

-        node = node->Next();
+        node = node->GetNext();

     }
     }

-    return (wxImageHandler *)NULL;
+    return 0;

 }
 
 wxImageHandler *wxImage::FindHandler( const wxString& extension, long bitmapType )
 {
 }
 
 wxImageHandler *wxImage::FindHandler( const wxString& extension, long bitmapType )
 {

-    wxNode *node = sm_handlers.First();
+    wxList::compatibility_iterator node = sm_handlers.GetFirst();

     while (node)
     {
     while (node)
     {

-        wxImageHandler *handler = (wxImageHandler*)node->Data();
+        wxImageHandler *handler = (wxImageHandler*)node->GetData();

         if ( (handler->GetExtension().Cmp(extension) == 0) &&
             (bitmapType == -1 || handler->GetType() == bitmapType) )
             return handler;
         if ( (handler->GetExtension().Cmp(extension) == 0) &&
             (bitmapType == -1 || handler->GetType() == bitmapType) )
             return handler;

-        node = node->Next();
+        node = node->GetNext();

     }
     }

-    return (wxImageHandler*)NULL;
+    return 0;

 }
 
 wxImageHandler *wxImage::FindHandler( long bitmapType )
 {
 }
 
 wxImageHandler *wxImage::FindHandler( long bitmapType )
 {

-    wxNode *node = sm_handlers.First();
+    wxList::compatibility_iterator node = sm_handlers.GetFirst();

     while (node)
     {
     while (node)
     {

-        wxImageHandler *handler = (wxImageHandler *)node->Data();
+        wxImageHandler *handler = (wxImageHandler *)node->GetData();

         if (handler->GetType() == bitmapType) return handler;
         if (handler->GetType() == bitmapType) return handler;

-        node = node->Next();
+        node = node->GetNext();

     }
     }

-    return NULL;
+    return 0;

 }
 
 wxImageHandler *wxImage::FindHandlerMime( const wxString& mimetype )
 {
 }
 
 wxImageHandler *wxImage::FindHandlerMime( const wxString& mimetype )
 {

-    wxNode *node = sm_handlers.First();
+    wxList::compatibility_iterator node = sm_handlers.GetFirst();

     while (node)
     {
     while (node)
     {

-        wxImageHandler *handler = (wxImageHandler *)node->Data();
-        if (handler->GetMimeType().IsSameAs(mimetype, FALSE)) return handler;
-        node = node->Next();
+        wxImageHandler *handler = (wxImageHandler *)node->GetData();
+        if (handler->GetMimeType().IsSameAs(mimetype, false)) return handler;
+        node = node->GetNext();

     }
     }

-    return NULL;
+    return 0;

 }
 
 void wxImage::InitStandardHandlers()
 }
 
 void wxImage::InitStandardHandlers()


@@ -1478,23 +1415,37 @@ void wxImage::InitStandardHandlers()
 #if wxUSE_STREAMS
     AddHandler(new wxBMPHandler);
 #endif // wxUSE_STREAMS
 #if wxUSE_STREAMS
     AddHandler(new wxBMPHandler);
 #endif // wxUSE_STREAMS

-
-#if wxUSE_XPM && !defined(__WXGTK__) && !defined(__WXMOTIF__)
-    AddHandler(new wxXPMHandler);
-#endif

 }
 
 void wxImage::CleanUpHandlers()
 {
 }
 
 void wxImage::CleanUpHandlers()
 {

-    wxNode *node = sm_handlers.First();
+    wxList::compatibility_iterator node = sm_handlers.GetFirst();

     while (node)
     {
     while (node)
     {

-        wxImageHandler *handler = (wxImageHandler *)node->Data();
-        wxNode *next = node->Next();
+        wxImageHandler *handler = (wxImageHandler *)node->GetData();
+        wxList::compatibility_iterator next = node->GetNext();

         delete handler;
         delete handler;

-        delete node;

         node = next;
     }
         node = next;
     }

+
+    sm_handlers.Clear();
+}
+
+wxString wxImage::GetImageExtWildcard()
+{
+    wxString fmts;
+
+    wxList& Handlers = wxImage::GetHandlers();
+    wxList::compatibility_iterator Node = Handlers.GetFirst();
+    while ( Node )
+    {
+        wxImageHandler* Handler = (wxImageHandler*)Node->GetData();
+        fmts += wxT("*.") + Handler->GetExtension();
+        Node = Node->GetNext();
+        if ( Node ) fmts += wxT(";");
+    }
+
+    return wxT("(") + fmts + wxT(")|") + fmts;

 }
 
 //-----------------------------------------------------------------------------
 }
 
 //-----------------------------------------------------------------------------


@@ -1506,12 +1457,12 @@ IMPLEMENT_ABSTRACT_CLASS(wxImageHandler,wxObject)
 #if wxUSE_STREAMS
 bool wxImageHandler::LoadFile( wxImage *WXUNUSED(image), wxInputStream& WXUNUSED(stream), bool WXUNUSED(verbose), int WXUNUSED(index) )
 {
 #if wxUSE_STREAMS
 bool wxImageHandler::LoadFile( wxImage *WXUNUSED(image), wxInputStream& WXUNUSED(stream), bool WXUNUSED(verbose), int WXUNUSED(index) )
 {

-    return FALSE;
+    return false;

 }
 
 bool wxImageHandler::SaveFile( wxImage *WXUNUSED(image), wxOutputStream& WXUNUSED(stream), bool WXUNUSED(verbose) )
 {
 }
 
 bool wxImageHandler::SaveFile( wxImage *WXUNUSED(image), wxOutputStream& WXUNUSED(stream), bool WXUNUSED(verbose) )
 {

-    return FALSE;
+    return false;

 }
 
 int wxImageHandler::GetImageCount( wxInputStream& WXUNUSED(stream) )
 }
 
 int wxImageHandler::GetImageCount( wxInputStream& WXUNUSED(stream) )


@@ -1527,48 +1478,99 @@ bool wxImageHandler::CanRead( const wxString& name )
         return CanRead(stream);
     }
 
         return CanRead(stream);
     }
 

-    else {
-        wxLogError( _("Can't check image format of file '%s': file does not exist."), name.c_str() );
+    wxLogError( _("Can't check image format of file '%s': file does not exist."), name.c_str() );

 
 

-        return FALSE;
+    return false;
+}
+
+bool wxImageHandler::CallDoCanRead(wxInputStream& stream)
+{
+    off_t posOld = stream.TellI();
+    if ( posOld == wxInvalidOffset )
+    {
+        // can't test unseekable stream
+        return false;
+    }
+
+    bool ok = DoCanRead(stream);
+
+    // restore the old position to be able to test other formats and so on
+    if ( stream.SeekI(posOld) == wxInvalidOffset )
+    {
+        wxLogDebug(_T("Failed to rewind the stream in wxImageHandler!"));
+
+        // reading would fail anyhow as we're not at the right position
+        return false;

     }
     }

-//    return FALSE;
+
+    return ok;

 }
 
 #endif // wxUSE_STREAMS
 
 }
 
 #endif // wxUSE_STREAMS
 

+// ----------------------------------------------------------------------------
+// image histogram stuff
+// ----------------------------------------------------------------------------

 
 

+bool
+wxImageHistogram::FindFirstUnusedColour(unsigned char *r,
+                                        unsigned char *g,
+                                        unsigned char *b,
+                                        unsigned char r2,
+                                        unsigned char b2,
+                                        unsigned char g2) const
+{
+    unsigned long key = MakeKey(r2, g2, b2);

 
 

-//-----------------------------------------------------------------------------
-// Deprecated wxBitmap convertion routines
-//-----------------------------------------------------------------------------
+    while ( find(key) != end() )
+    {
+        // color already used
+        r2++;
+        if ( r2 >= 255 )
+        {
+            r2 = 0;
+            g2++;
+            if ( g2 >= 255 )
+            {
+                g2 = 0;
+                b2++;
+                if ( b2 >= 255 )
+                {
+                    wxLogError(_("No unused colour in image.") );
+                    return false;
+                }
+            }
+        }

 
 

-#if WXWIN_COMPATIBILITY_2_2 && wxUSE_GUI
+        key = MakeKey(r2, g2, b2);
+    }

 
 

-#ifdef __WXGTK__
-wxBitmap wxImage::ConvertToMonoBitmap( unsigned char red, unsigned char green, unsigned char blue ) const
-{
-    wxImage mono = this->ConvertToMono( red, green, blue );
-    wxBitmap bitmap( mono, 1 );
-    return bitmap;
-}
-#endif
+    if ( r )
+        *r = r2;
+    if ( g )
+        *g = g2;
+    if ( b )
+        *b = b2;

 
 

-wxBitmap wxImage::ConvertToBitmap() const
-{
-    wxBitmap bitmap( *this );
-    return bitmap;
+    return true;

 }
 
 }
 

-wxImage::wxImage( const wxBitmap &bitmap )
+bool
+wxImage::FindFirstUnusedColour(unsigned char *r,
+                               unsigned char *g,
+                               unsigned char *b,
+                               unsigned char r2,
+                               unsigned char b2,
+                               unsigned char g2) const

 {
 {

-    *this = bitmap.ConvertToImage();
-}
+    wxImageHistogram histogram;

 
 

-#endif // WXWIN_COMPATIBILITY_2_2 && wxUSE_GUI
+    ComputeHistogram(histogram);
+
+    return histogram.FindFirstUnusedColour(r, g, b, r2, g2, b2);
+}

 
 
 
 

-//-----------------------------------------------------------------------------

 
 // GRG, Dic/99
 // Counts and returns the number of different colours. Optionally stops
 
 // GRG, Dic/99
 // Counts and returns the number of different colours. Optionally stops


@@ -1594,7 +1596,7 @@ unsigned long wxImage::CountColours( unsigned long stopafter ) const
         r = *(p++);
         g = *(p++);
         b = *(p++);
         r = *(p++);
         g = *(p++);
         b = *(p++);

-        key = (r << 16) | (g << 8) | b;
+        key = wxImageHistogram::MakeKey(r, g, b);

 
         if (h.Get(key) == NULL)
         {
 
         if (h.Get(key) == NULL)
         {


@@ -1609,24 +1611,22 @@ unsigned long wxImage::CountColours( unsigned long stopafter ) const
 
 unsigned long wxImage::ComputeHistogram( wxImageHistogram &h ) const
 {
 
 unsigned long wxImage::ComputeHistogram( wxImageHistogram &h ) const
 {

-    unsigned char r, g, b;
-    unsigned char *p;
-    unsigned long size, nentries, key;
+    unsigned char *p = GetData();
+    unsigned long nentries = 0;

 
     h.clear();
 
 
     h.clear();
 

-    p = GetData();
-    size = GetWidth() * GetHeight();
-    nentries = 0;
+    const unsigned long size = GetWidth() * GetHeight();

 
 

-    for (unsigned long j = 0; j < size; j++)
+    unsigned char r, g, b;
+    for ( unsigned long n = 0; n < size; n++ )

     {
     {

-        r = *(p++);
-        g = *(p++);
-        b = *(p++);
-        key = (r << 16) | (g << 8) | b;
+        r = *p++;
+        g = *p++;
+        b = *p++;
+
+        wxImageHistogramEntry& entry = h[wxImageHistogram::MakeKey(r, g, b)];

 
 

-        wxImageHistogramEntry& entry = h[key];

         if ( entry.value++ == 0 )
             entry.index = nentries++;
     }
         if ( entry.value++ == 0 )
             entry.index = nentries++;
     }


@@ -1702,7 +1702,7 @@ wxImage wxImage::Rotate(double angle, const wxPoint & centre_of_rotation, bool i
     int x2 = (int) ceil (wxMax (wxMax(p1.x, p2.x), wxMax(p3.x, p4.x)));
     int y2 = (int) ceil (wxMax (wxMax(p1.y, p2.y), wxMax(p3.y, p4.y)));
 
     int x2 = (int) ceil (wxMax (wxMax(p1.x, p2.x), wxMax(p3.x, p4.x)));
     int y2 = (int) ceil (wxMax (wxMax(p1.y, p2.y), wxMax(p3.y, p4.y)));
 

-    wxImage rotated (x2 - x1 + 1, y2 - y1 + 1);
+    wxImage rotated (x2 - x1 + 1, y2 - y1 + 1, false);

 
     if (offset_after_rotation != NULL)
     {
 
     if (offset_after_rotation != NULL)
     {


@@ -1844,8 +1844,8 @@ wxImage wxImage::Rotate(double angle, const wxPoint & centre_of_rotation, bool i
                                w3 * *(v3++) + w4 * *(v4++)) /
                               (w1 + w2 + w3 + w4) );
                         *(dst++) = (unsigned char)
                                w3 * *(v3++) + w4 * *(v4++)) /
                               (w1 + w2 + w3 + w4) );
                         *(dst++) = (unsigned char)

-                            ( (w1 * *(v1++) + w2 * *(v2++) +
-                               w3 * *(v3++) + w4 * *(v4++)) /
+                            ( (w1 * *v1 + w2 * *v2 +
+                               w3 * *v3 + w4 * *v4) /

                               (w1 + w2 + w3 + w4) );
                     }
                 }
                               (w1 + w2 + w3 + w4) );
                     }
                 }


@@ -1875,7 +1875,7 @@ wxImage wxImage::Rotate(double angle, const wxPoint & centre_of_rotation, bool i
                     unsigned char *p = data[ys] + (3 * xs);
                     *(dst++) = *(p++);
                     *(dst++) = *(p++);
                     unsigned char *p = data[ys] + (3 * xs);
                     *(dst++) = *(p++);
                     *(dst++) = *(p++);

-                    *(dst++) = *(p++);
+                    *(dst++) = *p;

                 }
                 else
                 {
                 }
                 else
                 {


@@ -1905,7 +1905,7 @@ class wxImageModule: public wxModule
 DECLARE_DYNAMIC_CLASS(wxImageModule)
 public:
     wxImageModule() {}
 DECLARE_DYNAMIC_CLASS(wxImageModule)
 public:
     wxImageModule() {}

-    bool OnInit() { wxImage::InitStandardHandlers(); return TRUE; };
+    bool OnInit() { wxImage::InitStandardHandlers(); return true; };

     void OnExit() { wxImage::CleanUpHandlers(); };
 };
 
     void OnExit() { wxImage::CleanUpHandlers(); };
 };