fixed bug in parsing formats in which fields don't have any non-numeric delimiters

[wxWidgets.git] / src / common / imagpcx.cpp

diff --git a/src/common/imagpcx.cpp b/src/common/imagpcx.cpp
index 17a9b54bd54037a0a8d35c0e81522a9ef4e6b352..64a4d246b0efa5058f7aec2cfe7ed9524243ad88 100644 (file)
--- a/src/common/imagpcx.cpp
+++ b/src/common/imagpcx.cpp
@@ -311,7 +311,7 @@ int SavePCX(wxImage *image, wxOutputStream& stream)
     unsigned int bytesperline;      // bytes per line (each plane)
     int nplanes = 3;                // number of planes
     int format = wxPCX_24BIT;       // image format (8 bit, 24 bit)
     unsigned int bytesperline;      // bytes per line (each plane)
     int nplanes = 3;                // number of planes
     int format = wxPCX_24BIT;       // image format (8 bit, 24 bit)

-    wxHashTable h(wxKEY_INTEGER);   // image histogram
+    wxImageHistogram histogram;     // image histogram

     unsigned long key;              // key in the hashtable
     unsigned int i;
 
     unsigned long key;              // key in the hashtable
     unsigned int i;
 


@@ -319,7 +319,7 @@ int SavePCX(wxImage *image, wxOutputStream& stream)
 
     if (image->CountColours(256) <= 256)
     {
 
     if (image->CountColours(256) <= 256)
     {

-        image->ComputeHistogram(h);
+        image->ComputeHistogram(histogram);

         format = wxPCX_8BIT;
         nplanes = 1;
     }
         format = wxPCX_8BIT;
         nplanes = 1;
     }


@@ -371,7 +371,6 @@ int SavePCX(wxImage *image, wxOutputStream& stream)
             case wxPCX_8BIT:
             {
                 unsigned char r, g, b;
             case wxPCX_8BIT:
             {
                 unsigned char r, g, b;

-                wxHNode *hnode;

 
                 for (i = 0; i < width; i++)
                 {
 
                 for (i = 0; i < width; i++)
                 {


@@ -380,8 +379,7 @@ int SavePCX(wxImage *image, wxOutputStream& stream)
                     b = *(src++);
                     key = (r << 16) | (g << 8) | b;
 
                     b = *(src++);
                     key = (r << 16) | (g << 8) | b;
 

-                    hnode = (wxHNode *) h.Get(key);
-                    p[i] = (unsigned char)hnode->index;
+                    p[i] = (unsigned char)histogram[key].index;

                 }
                 break;
             }
                 }
                 break;
             }


@@ -402,26 +400,22 @@ int SavePCX(wxImage *image, wxOutputStream& stream)
 
     free(p);
 
 
     free(p);
 

-    // For 8 bit images, build the palette and write it to the stream
-
+    // For 8 bit images, build the palette and write it to the stream:

     if (format == wxPCX_8BIT)
     {
     if (format == wxPCX_8BIT)
     {

-        wxNode *node;
-        wxHNode *hnode;
-

         // zero unused colours
         memset(pal, 0, sizeof(pal));
 
         // zero unused colours
         memset(pal, 0, sizeof(pal));
 

-        h.BeginFind();
-        while ((node = h.Next()) != NULL)
+        unsigned long index;
+        
+        for (wxImageHistogram::iterator entry = histogram.begin();
+             entry != histogram.end(); entry++ )

         {
         {

-            key = node->GetKeyInteger();
-            hnode = (wxHNode *) node->GetData();
-
-            pal[3 * hnode->index]     = (unsigned char)(key >> 16);
-            pal[3 * hnode->index + 1] = (unsigned char)(key >> 8);
-            pal[3 * hnode->index + 2] = (unsigned char)(key);
-            delete hnode;
+            key = entry->first;
+            index = entry->second.index;
+            pal[3 * index]     = (unsigned char)(key >> 16);
+            pal[3 * index + 1] = (unsigned char)(key >> 8);
+            pal[3 * index + 2] = (unsigned char)(key);

         }
 
         stream.PutC(12);
         }
 
         stream.PutC(12);


@@ -492,13 +486,12 @@ bool wxPCXHandler::SaveFile( wxImage *image, wxOutputStream& stream, bool verbos
 
 bool wxPCXHandler::DoCanRead( wxInputStream& stream )
 {
 
 bool wxPCXHandler::DoCanRead( wxInputStream& stream )
 {

-    unsigned char c;
-
-    c = stream.GetC();
-    stream.SeekI(-1, wxFromCurrent);
+    unsigned char c = stream.GetC();
+    if ( !stream )
+        return FALSE;

 
     // not very safe, but this is all we can get from PCX header :-(
 
     // not very safe, but this is all we can get from PCX header :-(

-    return (c == 10);
+    return c == 10;

 }
 
 #endif // wxUSE_STREAMS && wxUSE_PCX
 }
 
 #endif // wxUSE_STREAMS && wxUSE_PCX