Only send keypress events to focus widget, not its parents

[wxWidgets.git] / src / gtk / settings.cpp

diff --git a/src/gtk/settings.cpp b/src/gtk/settings.cpp
index cf6f7960e509c02aa129cfff8b60d4c264eb858a..45fd8ac9d798698b44591f14b9f663a0f4be2bef 100644 (file)
--- a/src/gtk/settings.cpp
+++ b/src/gtk/settings.cpp
@@ -126,28 +126,26 @@ static bool GetColourFromGTKWidget(GdkColor& gdkColor,
         }
     }
 
         }
     }
 

-    gtk_widget_destroy( widget );
+    gtk_object_sink((GtkObject*)widget);

 
     return ok;
 }
 
 static void GetTooltipColors()
 {
 
     return ok;
 }
 
 static void GetTooltipColors()
 {

-    GtkTooltips* tooltips = gtk_tooltips_new();
-    gtk_tooltips_force_window(tooltips);
-    gtk_widget_ensure_style(tooltips->tip_window);
-    GdkColor c = tooltips->tip_window->style->bg[GTK_STATE_NORMAL];
+    GtkWidget* widget = gtk_window_new(GTK_WINDOW_POPUP);
+    const char* name = "gtk-tooltip";
+    if (gtk_check_version(2, 11, 0))
+        name = "gtk-tooltips";
+    gtk_widget_set_name(widget, name);
+    gtk_widget_ensure_style(widget);
+
+    GdkColor c = widget->style->bg[GTK_STATE_NORMAL];

     gs_objects.m_colTooltip = wxColor(c);
     gs_objects.m_colTooltip = wxColor(c);

-    c = tooltips->tip_window->style->fg[GTK_STATE_NORMAL];
+    c = widget->style->fg[GTK_STATE_NORMAL];

     gs_objects.m_colTooltipText = wxColor(c);
     gs_objects.m_colTooltipText = wxColor(c);

-#if GTK_CHECK_VERSION(2, 9, 0)
-    if (gtk_check_version(2, 9, 0) == NULL)
-        g_object_ref_sink(tooltips);
-    else
-#endif
-    {
-        gtk_object_sink((GtkObject*)tooltips);
-    }
+
+    gtk_widget_destroy(widget);

 }
 
 wxColour wxSystemSettingsNative::GetColour( wxSystemColour index )
 }
 
 wxColour wxSystemSettingsNative::GetColour( wxSystemColour index )


@@ -355,7 +353,7 @@ wxFont wxSystemSettingsNative::GetFont( wxSystemFont index )
                         gs_objects.m_fontSystem = wxFont(wxString::FromAscii(font_name));
                     g_free (font_name);
                 }
                         gs_objects.m_fontSystem = wxFont(wxString::FromAscii(font_name));
                     g_free (font_name);
                 }

-                gtk_widget_destroy( widget );
+                gtk_object_sink((GtkObject*)widget);

             }
             font = gs_objects.m_fontSystem;
             break;
             }
             font = gs_objects.m_fontSystem;
             break;


@@ -366,36 +364,66 @@ wxFont wxSystemSettingsNative::GetFont( wxSystemFont index )
     return font;
 }
 
     return font;
 }
 

-static bool wxXGetWindowProperty(GdkWindow* window, Atom& type, int& format, gulong& nitems, guchar*& data)
+static bool GetFrameExtents(GdkWindow* window, int* left, int* right, int* top, int* bottom)

 {
     bool success = false;
 {
     bool success = false;

+    Atom property = 0;

 #if GTK_CHECK_VERSION(2, 2, 0)
     if (gtk_check_version(2, 2, 0) == NULL)
     {
 #if GTK_CHECK_VERSION(2, 2, 0)
     if (gtk_check_version(2, 2, 0) == NULL)
     {

-        gulong bytes_after;
-        success = XGetWindowProperty(
-            GDK_DISPLAY_XDISPLAY(gdk_drawable_get_display(window)),
-            GDK_WINDOW_XWINDOW(window),
-            gdk_x11_get_xatom_by_name_for_display(
+        if (gdk_x11_screen_supports_net_wm_hint(
+                gdk_drawable_get_screen(window),
+                gdk_atom_intern("_NET_FRAME_EXTENTS", false)))
+        {
+            success = true;
+            property = gdk_x11_get_xatom_by_name_for_display(

                 gdk_drawable_get_display(window),
                 gdk_drawable_get_display(window),

-                "_NET_FRAME_EXTENTS"),
-            0, // left, right, top, bottom, CARDINAL[4]/32
-            G_MAXLONG, // size of long
-            false, // do not delete property
-            XA_CARDINAL, // 32 bit
-            &type, &format, &nitems, &bytes_after, &data
-            ) == Success;
+                "_NET_FRAME_EXTENTS");
+        }

     }
     }

+    else

 #endif
 #endif

+    {
+        if (gdk_net_wm_supports(gdk_atom_intern("_NET_FRAME_EXTENTS", false)))
+        {
+            success = true;
+            property = gdk_x11_get_xatom_by_name("_NET_FRAME_EXTENTS");
+        }
+    }
+    if (success)
+    {
+        Atom type;
+        int format;
+        gulong nitems, bytes_after;
+        long* data = NULL;
+        success = XGetWindowProperty(
+            gdk_x11_drawable_get_xdisplay(window),
+            gdk_x11_drawable_get_xid(window),
+            property,
+            0, 4,
+            false,
+            XA_CARDINAL,
+            &type, &format, &nitems, &bytes_after, (guchar**)&data
+            ) == Success;
+        if (success)
+        {
+            success = data && nitems == 4;
+            if (success)
+            {
+                if (left)   *left   = int(data[0]);
+                if (right)  *right  = int(data[1]);
+                if (top)    *top    = int(data[2]);
+                if (bottom) *bottom = int(data[3]);
+            }
+            if (data)
+                XFree(data);
+        }
+    }

     return success;
 }
 
 int wxSystemSettingsNative::GetMetric( wxSystemMetric index, wxWindow* win )
 {
     return success;
 }
 
 int wxSystemSettingsNative::GetMetric( wxSystemMetric index, wxWindow* win )
 {

-    guchar *data = NULL;
-    Atom type;
-    int format;
-    gulong nitems;

     GdkWindow *window = NULL;
     if(win && GTK_WIDGET_REALIZED(win->GetHandle()))
         window = win->GetHandle()->window;
     GdkWindow *window = NULL;
     if(win && GTK_WIDGET_REALIZED(win->GetHandle()))
         window = win->GetHandle()->window;


@@ -417,49 +445,21 @@ int wxSystemSettingsNative::GetMetric( wxSystemMetric index, wxWindow* win )
                     return -1; // not a tlw, not sure how to approach
                 else
                 {
                     return -1; // not a tlw, not sure how to approach
                 else
                 {

-                    // Check if wm supports frame extents - we can't know
-                    // the border widths if it does not.
-#if GTK_CHECK_VERSION(2,2,0)
-                    if (!gtk_check_version(2,2,0))
-                    {
-                        if (!gdk_x11_screen_supports_net_wm_hint(
-                                gdk_drawable_get_screen(window),
-                                gdk_atom_intern("_NET_FRAME_EXTENTS", false) ) )
-                            return -1;
-                    }
-                    else
-#endif
-                    {
-                        if (!gdk_net_wm_supports(gdk_atom_intern("_NET_FRAME_EXTENTS", false)))
-                            return -1;
-                    }
-

                     // Get the frame extents from the windowmanager.
                     // In most cases the top extent is the titlebar, so we use the bottom extent
                     // for the heights.
                     // Get the frame extents from the windowmanager.
                     // In most cases the top extent is the titlebar, so we use the bottom extent
                     // for the heights.

-                    if (wxXGetWindowProperty(window, type, format, nitems, data))
+                    int right, bottom;
+                    if (GetFrameExtents(window, NULL, &right, NULL, &bottom))

                     {
                     {

-                        int border_return = -1;
-
-                        if ((type == XA_CARDINAL) && (format == 32) && (nitems >= 4) && (data))
+                        switch (index)

                         {
                         {

-                            switch(index)
-                            {
-                                case wxSYS_BORDER_X:
-                                case wxSYS_EDGE_X:
-                                case wxSYS_FRAMESIZE_X:
-                                    border_return = int(data[1]); // width of right extent
-                                    break;
-                                default:
-                                    border_return = int(data[3]); // height of bottom extent
-                                    break;
-                            }
+                            case wxSYS_BORDER_X:
+                            case wxSYS_EDGE_X:
+                            case wxSYS_FRAMESIZE_X:
+                                return right; // width of right extent
+                            default:
+                                return bottom; // height of bottom extent

                         }
                         }

-
-                        if (data)
-                            XFree(data);
-
-                        return border_return;

                     }
                 }
             }
                     }
                 }
             }


@@ -494,6 +494,12 @@ int wxSystemSettingsNative::GetMetric( wxSystemMetric index, wxWindow* win )
 
             return dclick_distance * 2;
 
 
             return dclick_distance * 2;
 

+        case wxSYS_DCLICK_MSEC:
+            gint dclick;
+            g_object_get(gtk_settings_get_default(),
+                            "gtk-double-click-time", &dclick, NULL);
+            return dclick;
+

         case wxSYS_DRAG_X:
         case wxSYS_DRAG_Y:
             gint drag_threshold;
         case wxSYS_DRAG_X:
         case wxSYS_DRAG_Y:
             gint drag_threshold;


@@ -516,7 +522,7 @@ int wxSystemSettingsNative::GetMetric( wxSystemMetric index, wxWindow* win )
             // since that is what the API wants. But the values
             // are much bigger under GNOME than under Windows and
             // just seem to much in many cases to be useful.
             // since that is what the API wants. But the values
             // are much bigger under GNOME than under Windows and
             // just seem to much in many cases to be useful.

-            // drag_threshold *= 2;   
+            // drag_threshold *= 2;

 
             return drag_threshold;
 
 
             return drag_threshold;
 


@@ -548,22 +554,6 @@ int wxSystemSettingsNative::GetMetric( wxSystemMetric index, wxWindow* win )
                 // No realized window specified, and no implementation for that case yet.
                 return -1;
 
                 // No realized window specified, and no implementation for that case yet.
                 return -1;
 

-            // Check if wm supports frame extents - we can't know the caption height if it does not.
-#if GTK_CHECK_VERSION(2,2,0)
-            if (!gtk_check_version(2,2,0))
-            {
-                if (!gdk_x11_screen_supports_net_wm_hint(
-                        gdk_drawable_get_screen(window),
-                        gdk_atom_intern("_NET_FRAME_EXTENTS", false) ) )
-                    return -1;
-            }
-            else
-#endif
-            {
-                if (!gdk_net_wm_supports(gdk_atom_intern("_NET_FRAME_EXTENTS", false)))
-                    return -1;
-            }
-

             wxASSERT_MSG( wxDynamicCast(win, wxTopLevelWindow),
                           wxT("Asking for caption height of a non toplevel window") );
 
             wxASSERT_MSG( wxDynamicCast(win, wxTopLevelWindow),
                           wxT("Asking for caption height of a non toplevel window") );
 


@@ -572,19 +562,12 @@ int wxSystemSettingsNative::GetMetric( wxSystemMetric index, wxWindow* win )
             // we could check which is the thickest wm border to decide on which side the
             // titlebar is, but this might lead to interesting behaviours in used code.
             // Reconsider when we have a way to report to the user on which side it is.
             // we could check which is the thickest wm border to decide on which side the
             // titlebar is, but this might lead to interesting behaviours in used code.
             // Reconsider when we have a way to report to the user on which side it is.

-            if (wxXGetWindowProperty(window, type, format, nitems, data))

             {
             {

-                int caption_height = -1;
-
-                if ((type == XA_CARDINAL) && (format == 32) && (nitems >= 3) && (data))
+                int top;
+                if (GetFrameExtents(window, NULL, NULL, &top, NULL))

                 {
                 {

-                    caption_height = int(data[2]); // top frame extent
+                    return top; // top frame extent

                 }
                 }

-
-                if (data)
-                    XFree(data);
-
-                return caption_height;

             }
 
             // Try a default approach without a window pointer, if possible
             }
 
             // Try a default approach without a window pointer, if possible