#include "wx/imaglist.h"
#include "wx/headerctrl.h"
#include "wx/dnd.h"
+#include "wx/stopwatch.h"
//-----------------------------------------------------------------------------
// classes
void wxDataViewColumn::Init(int width, wxAlignment align, int flags)
{
- m_width = width == wxCOL_WIDTH_DEFAULT ? wxDVC_DEFAULT_WIDTH : width;
+ m_width = width;
m_minWidth = 0;
m_align = align;
m_flags = flags;
m_sort = false;
m_sortAscending = true;
}
-
+
+int wxDataViewColumn::GetWidth() const
+{
+ switch ( m_width )
+ {
+ case wxCOL_WIDTH_DEFAULT:
+ return wxDVC_DEFAULT_WIDTH;
+
+ case wxCOL_WIDTH_AUTOSIZE:
+ wxCHECK_MSG( m_owner, wxDVC_DEFAULT_WIDTH, "no owner control" );
+ return m_owner->GetBestColumnWidth(m_owner->GetColumnIndex(this));
+
+ default:
+ return m_width;
+ }
+}
+
void wxDataViewColumn::UpdateDisplay()
{
if (m_owner)
bool ItemAdded( const wxDataViewItem &parent, const wxDataViewItem &item );
bool ItemDeleted( const wxDataViewItem &parent, const wxDataViewItem &item );
bool ItemChanged( const wxDataViewItem &item );
- bool ValueChanged( const wxDataViewItem &item, unsigned int col );
+ bool ValueChanged( const wxDataViewItem &item, unsigned int model_column );
bool Cleared();
void Resort()
{
void ScrollWindow( int dx, int dy, const wxRect *rect = NULL );
void ScrollTo( int rows, int column );
+ unsigned GetCurrentRow() const { return m_currentRow; }
bool HasCurrentRow() { return m_currentRow != (unsigned int)-1; }
void ChangeCurrentRow( unsigned int row );
wxSize wxDataViewTextRenderer::GetSize() const
{
- const wxDataViewCtrl *view = GetView();
if (!m_text.empty())
- return view->wxWindowBase::GetTextExtent( m_text );
- return wxSize(wxDVC_DEFAULT_RENDERER_SIZE,wxDVC_DEFAULT_RENDERER_SIZE);
+ return GetTextExtent(m_text);
+ else
+ return wxSize(wxDVC_DEFAULT_RENDERER_SIZE,wxDVC_DEFAULT_RENDERER_SIZE);
}
// ---------------------------------------------------------
int flags = 0;
if (m_toggle)
flags |= wxCONTROL_CHECKED;
- if (GetMode() != wxDATAVIEW_CELL_ACTIVATABLE)
+ if (GetMode() != wxDATAVIEW_CELL_ACTIVATABLE ||
+ GetEnabled() == false)
flags |= wxCONTROL_DISABLED;
// check boxes we draw must always have the same, standard size (if it's
const wxDataViewItem & item,
unsigned int col)
{
- model->ChangeValue(!valueOld.GetBool(), item, col);
+ if (model->IsEnabled(item, col))
+ {
+ model->ChangeValue(!valueOld.GetBool(), item, col);
+ }
}
wxSize wxDataViewToggleRenderer::GetSize() const
wxSize wxDataViewDateRenderer::GetSize() const
{
- const wxDataViewCtrl* view = GetView();
- wxString tmp = m_date.FormatDate();
- wxCoord x,y,d;
- view->GetTextExtent( tmp, &x, &y, &d );
- return wxSize(x,y+d);
+ return GetTextExtent(m_date.FormatDate());
}
void wxDataViewDateRenderer::WXOnActivate(wxDataViewModel *model,
wxSize wxDataViewIconTextRenderer::GetSize() const
{
- const wxDataViewCtrl *view = GetView();
if (!m_value.GetText().empty())
{
- int x,y;
- view->GetTextExtent( m_value.GetText(), &x, &y );
+ wxSize size = GetTextExtent(m_value.GetText());
if (m_value.GetIcon().IsOk())
- x += m_value.GetIcon().GetWidth() + 4;
- return wxSize( x, y );
+ size.x += m_value.GetIcon().GetWidth() + 4;
+ return size;
}
return wxSize(80,20);
}
//-----------------------------------------------------------------------------
// The tree building helper, declared firstly
-static void BuildTreeHelper( wxDataViewModel * model, wxDataViewItem & item,
+static void BuildTreeHelper( const wxDataViewModel * model, const wxDataViewItem & item,
wxDataViewTreeNode * node);
int LINKAGEMODE wxDataViewSelectionCmp( unsigned int row1, unsigned int row2 )
if (column == expander)
width -= indent;
- wxVariant value;
wxDataViewItem item = GetItemByRow( row );
- model->GetValue( value, item, column->GetModelColumn());
- cell->SetValue( value );
-
- wxDataViewItemAttr attr;
- model->GetAttr(item, column->GetModelColumn(), attr);
- cell->SetAttr(attr);
+ cell->PrepareForItem(model, item, column->GetModelColumn());
wxRect item_rect(x, 0, width, height);
item_rect.Deflate(PADDING_RIGHTLEFT, 0);
for (unsigned int item = item_start; item < item_last; item++)
{
// get the cell value and set it into the renderer
- wxVariant value;
wxDataViewTreeNode *node = NULL;
wxDataViewItem dataitem;
dataitem = wxDataViewItem( wxUIntToPtr(item+1) );
}
- model->GetValue( value, dataitem, col->GetModelColumn());
- cell->SetValue( value );
-
- wxDataViewItemAttr attr;
- model->GetAttr(dataitem, col->GetModelColumn(), attr);
- cell->SetAttr(attr);
+ cell->PrepareForItem(model, dataitem, col->GetModelColumn());
// update cell_rect
cell_rect.y = GetLineStart( item );
;
}
- wxDataViewTreeNodes nodes = node->GetNodes();
- wxDataViewTreeLeaves leaves = node->GetChildren();
+ const wxDataViewTreeNodes& nodes = node->GetNodes();
+ const wxDataViewTreeLeaves& leaves = node->GetChildren();
int len_nodes = nodes.GetCount();
int len = leaves.GetCount();
bool wxDataViewMainWindow::ItemAdded(const wxDataViewItem & parent, const wxDataViewItem & item)
{
+ GetOwner()->InvalidateColBestWidths();
+
if (IsVirtualList())
{
wxDataViewVirtualListModel *list_model =
bool wxDataViewMainWindow::ItemDeleted(const wxDataViewItem& parent,
const wxDataViewItem& item)
{
+ GetOwner()->InvalidateColBestWidths();
+
if (IsVirtualList())
{
wxDataViewVirtualListModel *list_model =
bool wxDataViewMainWindow::ItemChanged(const wxDataViewItem & item)
{
+ GetOwner()->InvalidateColBestWidths();
+
SortPrepare();
g_model->Resort();
return true;
}
-bool wxDataViewMainWindow::ValueChanged( const wxDataViewItem & item, unsigned int col )
+bool wxDataViewMainWindow::ValueChanged( const wxDataViewItem & item, unsigned int model_column )
{
+ int view_column = -1;
+ unsigned int n_col = m_owner->GetColumnCount();
+ for (unsigned i = 0; i < n_col; i++)
+ {
+ wxDataViewColumn *column = m_owner->GetColumn( i );
+ if (column->GetModelColumn() == model_column)
+ {
+ view_column = (int) i;
+ break;
+ }
+ }
+ if (view_column == -1)
+ return false;
+
+ GetOwner()->InvalidateColBestWidth(view_column);
+
// NOTE: to be valid, we cannot use e.g. INT_MAX - 1
/*#define MAX_VIRTUAL_WIDTH 100000
le.SetEventObject(parent);
le.SetModel(GetOwner()->GetModel());
le.SetItem(item);
- le.SetColumn(col);
- le.SetDataViewColumn(GetOwner()->GetColumn(col));
+ le.SetColumn(view_column);
+ le.SetDataViewColumn(GetOwner()->GetColumn(view_column));
parent->GetEventHandler()->ProcessEvent(le);
return true;
bool wxDataViewMainWindow::Cleared()
{
+ GetOwner()->InvalidateColBestWidths();
+
DestroyTree();
+ m_selection.Clear();
SortPrepare();
BuildTree( GetOwner()->GetModel() );
void wxDataViewMainWindow::ScrollWindow( int dx, int dy, const wxRect *rect )
{
+ m_underMouse = NULL;
+
wxWindow::ScrollWindow( dx, dy, rect );
if (GetOwner()->m_headerArea)
void wxDataViewMainWindow::ScrollTo( int rows, int column )
{
+ m_underMouse = NULL;
+
int x, y;
m_owner->GetScrollPixelsPerUnit( &x, &y );
int sy = GetLineStart( rows )/y;
!model->HasContainerColumns(item))
continue; // skip it!
- wxVariant value;
- model->GetValue( value, item, column->GetModelColumn() );
-
wxDataViewRenderer *renderer =
const_cast<wxDataViewRenderer*>(column->GetRenderer());
- renderer->SetValue( value );
+ renderer->PrepareForItem(model, item, column->GetModelColumn());
+
height = wxMax( height, renderer->GetSize().y );
}
!model->HasContainerColumns(item))
continue; // skip it!
- wxVariant value;
- model->GetValue( value, item, column->GetModelColumn() );
-
wxDataViewRenderer *renderer =
const_cast<wxDataViewRenderer*>(column->GetRenderer());
- renderer->SetValue( value );
+ renderer->PrepareForItem(model, item, column->GetModelColumn());
+
height = wxMax( height, renderer->GetSize().y );
}
!model->HasContainerColumns(item))
continue; // skip it!
- wxVariant value;
- model->GetValue( value, item, column->GetModelColumn() );
-
wxDataViewRenderer *renderer =
const_cast<wxDataViewRenderer*>(column->GetRenderer());
- renderer->SetValue( value );
+ renderer->PrepareForItem(model, item, column->GetModelColumn());
+
height = wxMax( height, renderer->GetSize().y );
}
wxDataViewTreeNode * wxDataViewMainWindow::FindNode( const wxDataViewItem & item )
{
- wxDataViewModel * model = GetOwner()->GetModel();
+ const wxDataViewModel * model = GetOwner()->GetModel();
if( model == NULL )
return NULL;
if (!item.IsOk())
return m_root;
- // Compose the a parent-chain of the finding item
- ItemList list;
- list.DeleteContents( true );
+ // Compose the parent-chain for the item we are looking for
+ wxVector<wxDataViewItem> parentChain;
wxDataViewItem it( item );
while( it.IsOk() )
{
- wxDataViewItem * pItem = new wxDataViewItem( it );
- list.Insert( pItem );
- it = model->GetParent( it );
+ parentChain.push_back(it);
+ it = model->GetParent(it);
}
// Find the item along the parent-chain.
// This algorithm is designed to speed up the node-finding method
- wxDataViewTreeNode * node = m_root;
- for( ItemList::const_iterator iter = list.begin(); iter !=list.end(); iter++ )
+ wxDataViewTreeNode* node = m_root;
+ for( unsigned iter = parentChain.size()-1; iter>=0; --iter )
{
if( node->HasChildren() )
{
::BuildTreeHelper(model, node->GetItem(), node);
}
- wxDataViewTreeNodes nodes = node->GetNodes();
- unsigned int i;
+ const wxDataViewTreeNodes& nodes = node->GetNodes();
bool found = false;
- for (i = 0; i < nodes.GetCount(); i ++)
+ for (unsigned i = 0; i < nodes.GetCount(); ++i)
{
- if (nodes[i]->GetItem() == (**iter))
+ wxDataViewTreeNode* currentNode = nodes[i];
+ if (currentNode->GetItem() == parentChain[iter])
{
- if (nodes[i]->GetItem() == item)
- return nodes[i];
+ if (currentNode->GetItem() == item)
+ return currentNode;
- node = nodes[i];
+ node = currentNode;
found = true;
break;
}
class ItemToRowJob : public DoJob
{
public:
- ItemToRowJob(const wxDataViewItem& item_, ItemList::const_iterator iter)
+ ItemToRowJob(const wxDataViewItem& item_, wxVector<wxDataViewItem>::reverse_iterator iter)
: m_iter(iter),
item(item_)
{
return DoJob::OK;
}
- if( node->GetItem() == **m_iter )
+ if( node->GetItem() == *m_iter )
{
m_iter++;
return DoJob::CONT;
{ return ret -1; }
private:
- ItemList::const_iterator m_iter;
+ wxVector<wxDataViewItem>::reverse_iterator m_iter;
wxDataViewItem item;
int ret;
if( !item.IsOk() )
return -1;
- // Compose the a parent-chain of the finding item
- ItemList list;
- wxDataViewItem * pItem;
- list.DeleteContents( true );
+ // Compose the parent-chain of the item we are looking for
+ wxVector<wxDataViewItem> parentChain;
wxDataViewItem it( item );
while( it.IsOk() )
{
- pItem = new wxDataViewItem( it );
- list.Insert( pItem );
- it = model->GetParent( it );
+ parentChain.push_back(it);
+ it = model->GetParent(it);
}
- pItem = new wxDataViewItem( );
- list.Insert( pItem );
- ItemToRowJob job( item, list.begin() );
- Walker(m_root , job );
+ // add an 'invalid' item to represent our 'invisible' root node
+ parentChain.push_back(wxDataViewItem());
+
+ // the parent chain was created by adding the deepest parent first.
+ // so if we want to start at the root node, we have to iterate backwards through the vector
+ ItemToRowJob job( item, parentChain.rbegin() );
+ Walker( m_root, job );
return job.GetResult();
}
}
-static void BuildTreeHelper( wxDataViewModel * model, wxDataViewItem & item,
+static void BuildTreeHelper( const wxDataViewModel * model, const wxDataViewItem & item,
wxDataViewTreeNode * node)
{
if( !model->IsContainer( item ) )
return;
}
+ // set the focus to ourself if any of the mouse buttons are pressed
+ if(event.ButtonDown() && !HasFocus())
+ SetFocus();
+
int x = event.GetX();
int y = event.GetY();
m_owner->CalcUnscrolledPosition( x, y, &x, &y );
xpos += c->GetWidth();
}
if (!col)
+ {
+ event.Skip();
return;
+ }
wxDataViewRenderer *cell = col->GetRenderer();
unsigned int current = GetLineAt( y );
if ((current >= GetRowCount()) || (x > GetEndOfLastCol()))
{
// Unselect all if below the last row ?
+ event.Skip();
return;
}
wxWindow *parent = GetParent();
wxDataViewEvent le(wxEVT_COMMAND_DATAVIEW_ITEM_ACTIVATED, parent->GetId());
le.SetItem( item );
+ le.SetColumn( col->GetModelColumn() );
+ le.SetDataViewColumn( col );
le.SetEventObject(parent);
le.SetModel(GetOwner()->GetModel());
wxWindow *parent = GetParent();
wxDataViewEvent le(wxEVT_COMMAND_DATAVIEW_ITEM_CONTEXT_MENU, parent->GetId());
le.SetItem( item );
+ le.SetColumn( col->GetModelColumn() );
+ le.SetDataViewColumn( col );
le.SetEventObject(parent);
le.SetModel(GetOwner()->GetModel());
le.SetValue(value);
}
else if ((event.LeftDown() || simulateClick) && !hoverOverExpander)
{
- SetFocus();
-
m_lineBeforeLastClicked = m_lineLastClicked;
m_lineLastClicked = current;
if ( wxDataViewCustomRenderer *custom = cell->WXGetAsCustom() )
{
// notify cell about click
- wxVariant value;
- model->GetValue( value, item, col->GetModelColumn() );
- custom->SetValue( value );
+ custom->PrepareForItem(model, item, col->GetModelColumn());
+
wxRect cell_rect( xpos, GetLineStart( current ),
col->GetWidth(), GetLineHeight( current ) );
else if ( align & wxALIGN_BOTTOM )
rectItem.y += cell_rect.height - size.y;
// else: wxALIGN_TOP is the default
- }
+ }
}
wxPoint pos( event.GetPosition() );
GetModel()->RemoveNotifier( m_notifier );
m_cols.Clear();
+ m_colsBestWidths.clear();
}
void wxDataViewCtrl::Init()
m_headerArea = NULL;
}
-bool wxDataViewCtrl::Create(wxWindow *parent, wxWindowID id,
- const wxPoint& pos, const wxSize& size,
- long style, const wxValidator& validator )
+bool wxDataViewCtrl::Create(wxWindow *parent,
+ wxWindowID id,
+ const wxPoint& pos,
+ const wxSize& size,
+ long style,
+ const wxValidator& validator,
+ const wxString& name)
{
// if ( (style & wxBORDER_MASK) == 0)
// style |= wxBORDER_SUNKEN;
Init();
if (!wxControl::Create( parent, id, pos, size,
- style | wxScrolledWindowStyle, validator))
+ style | wxScrolledWindowStyle, validator, name))
return false;
SetInitialSize(size);
return false;
m_cols.Append( col );
+ m_colsBestWidths.push_back(0);
OnColumnsCountChanged();
return true;
}
return false;
m_cols.Insert( col );
+ m_colsBestWidths.insert(m_colsBestWidths.begin(), 0);
OnColumnsCountChanged();
return true;
}
return false;
m_cols.Insert( pos, col );
+ m_colsBestWidths.insert(m_colsBestWidths.begin() + pos, 0);
OnColumnsCountChanged();
return true;
}
return wxNOT_FOUND;
}
+unsigned int wxDataViewCtrl::GetBestColumnWidth(int idx) const
+{
+ if ( m_colsBestWidths[idx] != 0 )
+ return m_colsBestWidths[idx];
+
+ const int count = m_clientArea->GetRowCount();
+ wxDataViewColumn *column = GetColumn(idx);
+ wxDataViewRenderer *renderer =
+ const_cast<wxDataViewRenderer*>(column->GetRenderer());
+
+ class MaxWidthCalculator
+ {
+ public:
+ MaxWidthCalculator(wxDataViewMainWindow *clientArea,
+ wxDataViewRenderer *renderer,
+ const wxDataViewModel *model,
+ unsigned column)
+ : m_width(0),
+ m_clientArea(clientArea),
+ m_renderer(renderer),
+ m_model(model),
+ m_column(column)
+ {
+ }
+
+ void UpdateWithWidth(int width)
+ {
+ m_width = wxMax(m_width, width);
+ }
+
+ void UpdateWithRow(int row)
+ {
+ wxDataViewItem item = m_clientArea->GetItemByRow(row);
+ m_renderer->PrepareForItem(m_model, item, m_column);
+ m_width = wxMax(m_width, m_renderer->GetSize().x);
+ }
+
+ int GetMaxWidth() const { return m_width; }
+
+ private:
+ int m_width;
+ wxDataViewMainWindow *m_clientArea;
+ wxDataViewRenderer *m_renderer;
+ const wxDataViewModel *m_model;
+ unsigned m_column;
+ };
+
+ MaxWidthCalculator calculator(m_clientArea, renderer,
+ GetModel(), column->GetModelColumn());
+
+ if ( m_headerArea )
+ {
+ int header_width = m_headerArea->GetTextExtent(column->GetTitle()).x;
+ // Labels on native MSW header are indented on both sides
+ header_width +=
+ wxRendererNative::Get().GetHeaderButtonMargin(m_headerArea);
+ calculator.UpdateWithWidth(header_width);
+ }
+
+ // The code below deserves some explanation. For very large controls, we
+ // simply can't afford to calculate sizes for all items, it takes too
+ // long. So the best we can do is to check the first and the last N/2
+ // items in the control for some sufficiently large N and calculate best
+ // sizes from that. That can result in the calculated best width being too
+ // small for some outliers, but it's better to get slightly imperfect
+ // result than to wait several seconds after every update. To avoid highly
+ // visible miscalculations, we also include all currently visible items
+ // no matter what. Finally, the value of N is determined dynamically by
+ // measuring how much time we spent on the determining item widths so far.
+
+#if wxUSE_STOPWATCH
+ int top_part_end = count;
+ static const long CALC_TIMEOUT = 20/*ms*/;
+ // don't call wxStopWatch::Time() too often
+ static const unsigned CALC_CHECK_FREQ = 100;
+ wxStopWatch timer;
+#else
+ // use some hard-coded limit, that's the best we can do without timer
+ int top_part_end = wxMin(500, count);
+#endif // wxUSE_STOPWATCH/!wxUSE_STOPWATCH
+
+ int row = 0;
+
+ for ( row = 0; row < top_part_end; row++ )
+ {
+#if wxUSE_STOPWATCH
+ if ( row % CALC_CHECK_FREQ == CALC_CHECK_FREQ-1 &&
+ timer.Time() > CALC_TIMEOUT )
+ break;
+#endif // wxUSE_STOPWATCH
+ calculator.UpdateWithRow(row);
+ }
+
+ // row is the first unmeasured item now; that's out value of N/2
+
+ if ( row < count )
+ {
+ top_part_end = row;
+
+ // add bottom N/2 items now:
+ const int bottom_part_start = wxMax(row, count - row);
+ for ( row = bottom_part_start; row < count; row++ )
+ {
+ calculator.UpdateWithRow(row);
+ }
+
+ // finally, include currently visible items in the calculation:
+ const wxPoint origin = CalcUnscrolledPosition(wxPoint(0, 0));
+ int first_visible = m_clientArea->GetLineAt(origin.y);
+ int last_visible = m_clientArea->GetLineAt(origin.y + GetClientSize().y);
+
+ first_visible = wxMax(first_visible, top_part_end);
+ last_visible = wxMin(bottom_part_start, last_visible);
+
+ for ( row = first_visible; row < last_visible; row++ )
+ {
+ calculator.UpdateWithRow(row);
+ }
+
+ wxLogTrace("dataview",
+ "determined best size from %d top, %d bottom plus %d more visible items out of %d total",
+ top_part_end,
+ count - bottom_part_start,
+ wxMax(0, last_visible - first_visible),
+ count);
+ }
+
+ int max_width = calculator.GetMaxWidth();
+ if ( max_width > 0 )
+ max_width += 2 * PADDING_RIGHTLEFT;
+
+ const_cast<wxDataViewCtrl*>(this)->m_colsBestWidths[idx] = max_width;
+ return max_width;
+
+ #undef MEASURE_ITEM
+}
+
void wxDataViewCtrl::ColumnMoved(wxDataViewColumn * WXUNUSED(col),
unsigned int WXUNUSED(new_pos))
{
if (!ret)
return false;
+ m_colsBestWidths.erase(m_colsBestWidths.begin() + GetColumnIndex(column));
m_cols.Erase(ret);
OnColumnsCountChanged();
bool wxDataViewCtrl::ClearColumns()
{
m_cols.Clear();
+ m_colsBestWidths.clear();
OnColumnsCountChanged();
return true;
}
+void wxDataViewCtrl::InvalidateColBestWidth(int idx)
+{
+ m_colsBestWidths[idx] = 0;
+
+ if ( m_headerArea )
+ m_headerArea->UpdateColumn(idx);
+}
+
+void wxDataViewCtrl::InvalidateColBestWidths()
+{
+ m_colsBestWidths.clear();
+ m_colsBestWidths.resize(m_cols.size());
+
+ if ( m_headerArea )
+ {
+ // this updates visual appearance of columns 0 and up, not just 0
+ m_headerArea->UpdateColumn(0);
+ }
+}
+
int wxDataViewCtrl::GetColumnPosition( const wxDataViewColumn *column ) const
{
#if 1
if (column==col)
return i;
}
-
+
return wxNOT_FOUND;
#else
// This returns the position in pixels which is not what we want.
: GetColumn(m_sortingColumnIdx);
}
+wxDataViewItem wxDataViewCtrl::DoGetCurrentItem() const
+{
+ return GetItemByRow(m_clientArea->GetCurrentRow());
+}
+
+void wxDataViewCtrl::DoSetCurrentItem(const wxDataViewItem& item)
+{
+ const int row = m_clientArea->GetRowByItem(item);
+
+ const unsigned oldCurrent = m_clientArea->GetCurrentRow();
+ if ( static_cast<unsigned>(row) != oldCurrent )
+ {
+ m_clientArea->ChangeCurrentRow(row);
+ m_clientArea->RefreshRow(oldCurrent);
+ m_clientArea->RefreshRow(row);
+ }
+}
+
// Selection code with wxDataViewItem as parameters
wxDataViewItem wxDataViewCtrl::GetSelection() const
{
// Unselect all rows before select another in the single select mode
if (m_clientArea->IsSingleSel())
m_clientArea->SelectAllRows(false);
-
+
m_clientArea->SelectRow(row, true);
-
+
// Also set focus to the selected item
m_clientArea->ChangeCurrentRow( row );
}
void wxDataViewCtrl::Expand( const wxDataViewItem & item )
{
+ ExpandAncestors( item );
+
int row = m_clientArea->GetRowByItem( item );
if (row != -1)
m_clientArea->Expand(row);
wxRect itemRect = GetItemRect(item, col);
wxDataViewRenderer* renderer = col->GetRenderer();
- renderer->StartEditing(item, itemRect);
+ if (renderer->GetMode() == wxDATAVIEW_CELL_EDITABLE)
+ renderer->StartEditing(item, itemRect);
}
#endif // !wxUSE_GENERICDATAVIEWCTRL
projects / wxWidgets.git / blobdiff