static void
gtk_value_changed(GtkRange* range, wxScrollBar* win)
{
- wxEventType eventType = win->GetScrollEventType(range);
+ wxEventType eventType = win->GTKGetScrollEventType(range);
if (eventType != wxEVT_NULL)
{
const int orient = win->HasFlag(wxSB_VERTICAL) ? wxVERTICAL : wxHORIZONTAL;
const int value = win->GetThumbPosition();
- wxScrollEvent event(eventType, win->GetId(), value, orient);
- event.SetEventObject(win);
- win->GetEventHandler()->ProcessEvent(event);
+ const int id = win->GetId();
+
+ // first send the specific event for the user action
+ wxScrollEvent evtSpec(eventType, id, value, orient);
+ evtSpec.SetEventObject(win);
+ win->HandleWindowEvent(evtSpec);
+
if (!win->m_isScrolling)
{
- wxScrollEvent event(wxEVT_SCROLL_CHANGED, win->GetId(), value, orient);
- event.SetEventObject(win);
- win->GetEventHandler()->ProcessEvent(event);
+ // and if it's over also send a general "changed" event
+ wxScrollEvent evtChanged(wxEVT_SCROLL_CHANGED, id, value, orient);
+ evtChanged.SetEventObject(win);
+ win->HandleWindowEvent(evtChanged);
}
}
}
static gboolean
gtk_button_press_event(GtkRange*, GdkEventButton*, wxScrollBar* win)
{
- if (g_isIdle) wxapp_install_idle_handler();
-
win->m_mouseButtonDown = true;
return false;
}
}
+//-----------------------------------------------------------------------------
+// "event_after" from scrollbar
+//-----------------------------------------------------------------------------
+
+extern "C" {
+static void
+gtk_event_after(GtkRange* range, GdkEvent* event, wxScrollBar* win)
+{
+ if (event->type == GDK_BUTTON_RELEASE)
+ {
+ g_signal_handlers_block_by_func(range, (void*)gtk_event_after, win);
+
+ const int value = win->GetThumbPosition();
+ const int orient = win->HasFlag(wxSB_VERTICAL) ? wxVERTICAL : wxHORIZONTAL;
+ const int id = win->GetId();
+
+ wxScrollEvent evtRel(wxEVT_SCROLL_THUMBRELEASE, id, value, orient);
+ evtRel.SetEventObject(win);
+ win->HandleWindowEvent(evtRel);
+
+ wxScrollEvent evtChanged(wxEVT_SCROLL_CHANGED, id, value, orient);
+ evtChanged.SetEventObject(win);
+ win->HandleWindowEvent(evtChanged);
+ }
+}
+}
+
//-----------------------------------------------------------------------------
// "button_release_event" from scrollbar
//-----------------------------------------------------------------------------
extern "C" {
static gboolean
-gtk_button_release_event(GtkRange*, GdkEventButton*, wxScrollBar* win)
+gtk_button_release_event(GtkRange* range, GdkEventButton*, wxScrollBar* win)
{
- if (g_isIdle)
- wxapp_install_idle_handler();
-
win->m_mouseButtonDown = false;
// If thumb tracking
if (win->m_isScrolling)
{
win->m_isScrolling = false;
- const int value = win->GetThumbPosition();
- const int orient = win->HasFlag(wxSB_VERTICAL) ? wxVERTICAL : wxHORIZONTAL;
-
- wxScrollEvent event(wxEVT_SCROLL_THUMBRELEASE, win->GetId(), value, orient);
- event.SetEventObject(win);
- win->GetEventHandler()->ProcessEvent(event);
-
- wxScrollEvent event2(wxEVT_SCROLL_CHANGED, win->GetId(), value, orient);
- event2.SetEventObject(win);
- win->GetEventHandler()->ProcessEvent(event2);
+ // Hook up handler to send thumb release event after this emission is finished.
+ // To allow setting scroll position from event handler, sending event must
+ // be deferred until after the GtkRange handler for this signal has run
+ g_signal_handlers_unblock_by_func(range, (void*)gtk_event_after, win);
}
return false;
const wxPoint& pos, const wxSize& size,
long style, const wxValidator& validator, const wxString& name )
{
- m_needParent = true;
- m_acceptsFocus = true;
-
if (!PreCreation( parent, pos, size ) ||
!CreateBase( parent, id, pos, size, style, validator, name ))
{
const bool isVertical = (style & wxSB_VERTICAL) != 0;
if (isVertical)
- m_widget = gtk_vscrollbar_new( (GtkAdjustment *) NULL );
+ m_widget = gtk_vscrollbar_new( NULL );
else
- m_widget = gtk_hscrollbar_new( (GtkAdjustment *) NULL );
+ m_widget = gtk_hscrollbar_new( NULL );
+ g_object_ref(m_widget);
- m_scrollBar[int(isVertical)] = (GtkRange*)m_widget;
+ m_scrollBar[0] = (GtkRange*)m_widget;
- g_signal_connect(m_widget, "value_changed",
+ g_signal_connect_after(m_widget, "value_changed",
G_CALLBACK(gtk_value_changed), this);
g_signal_connect(m_widget, "button_press_event",
G_CALLBACK(gtk_button_press_event), this);
g_signal_connect(m_widget, "button_release_event",
G_CALLBACK(gtk_button_release_event), this);
+ gulong handler_id;
+ handler_id = g_signal_connect(
+ m_widget, "event_after", G_CALLBACK(gtk_event_after), this);
+ g_signal_handler_block(m_widget, handler_id);
+
m_parent->DoAddChild( this );
PostCreation(size);
{
if (GetThumbPosition() != viewStart)
{
- BlockScrollEvent();
+ g_signal_handlers_block_by_func(m_widget,
+ (gpointer)gtk_value_changed, this);
+
gtk_range_set_value((GtkRange*)m_widget, viewStart);
- UnblockScrollEvent();
- GtkAdjustment* adj = ((GtkRange*)m_widget)->adjustment;
- const int i = HasFlag(wxSB_VERTICAL);
- m_scrollPos[i] = adj->value;
+ m_scrollPos[0] = gtk_range_get_value((GtkRange*)m_widget);
+
+ g_signal_handlers_unblock_by_func(m_widget,
+ (gpointer)gtk_value_changed, this);
}
}
void wxScrollBar::SetScrollbar(int position, int thumbSize, int range, int pageSize, bool)
{
+ if (range == 0)
+ {
+ // GtkRange requires upper > lower
+ range =
+ thumbSize = 1;
+ }
GtkAdjustment* adj = ((GtkRange*)m_widget)->adjustment;
- adj->value = position;
adj->step_increment = 1;
adj->page_increment = pageSize;
adj->page_size = thumbSize;
- BlockScrollEvent();
+ adj->value = position;
+ g_signal_handlers_block_by_func(m_widget, (void*)gtk_value_changed, this);
gtk_range_set_range((GtkRange*)m_widget, 0, range);
- UnblockScrollEvent();
- const int i = HasFlag(wxSB_VERTICAL);
- m_scrollPos[i] = adj->value;
+ m_scrollPos[0] = adj->value;
+ g_signal_handlers_unblock_by_func(m_widget, (void*)gtk_value_changed, this);
}
void wxScrollBar::SetPageSize( int pageLength )
SetScrollbar(GetThumbPosition(), GetThumbSize(), range, GetPageSize());
}
-bool wxScrollBar::IsOwnGtkWindow( GdkWindow *window )
+GdkWindow *wxScrollBar::GTKGetWindow(wxArrayGdkWindows& WXUNUSED(windows)) const
{
- GtkRange *range = GTK_RANGE(m_widget);
- return ( (window == GTK_WIDGET(range)->window) );
+ return m_widget->window;
}
// static