Applied patch from Ian Brown to make menus look better in wxMotif (#586347)

[wxWidgets.git] / src / motif / dialog.cpp

diff --git a/src/motif/dialog.cpp b/src/motif/dialog.cpp
index 41d930d7f16c8b5842d5373201c8a6f7b3435180..19a321cc023f3e6d532be0ed384c88f3a3ce7a10 100644 (file)
--- a/src/motif/dialog.cpp
+++ b/src/motif/dialog.cpp
@@ -6,19 +6,29 @@
 // Created:     17/09/98
 // RCS-ID:      $Id$
 // Copyright:   (c) Julian Smart
 // Created:     17/09/98
 // RCS-ID:      $Id$
 // Copyright:   (c) Julian Smart

-// Licence:    wxWindows licence
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 #ifdef __GNUG__
 #pragma implementation "dialog.h"
 #endif
 
 /////////////////////////////////////////////////////////////////////////////
 
 #ifdef __GNUG__
 #pragma implementation "dialog.h"
 #endif
 

+#ifdef __VMS
+#define XtDisplay XTDISPLAY
+#define XtWindow XTWINDOW
+#define XtParent XTPARENT
+#define XtScreen XTSCREEN
+#endif
+

 #include "wx/dialog.h"
 #include "wx/utils.h"
 #include "wx/frame.h"
 #include "wx/app.h"
 #include "wx/settings.h"
 
 #include "wx/dialog.h"
 #include "wx/utils.h"
 #include "wx/frame.h"
 #include "wx/app.h"
 #include "wx/settings.h"
 

+#ifdef __VMS__
+#pragma message disable nosimpint
+#endif

 #include <Xm/Xm.h>
 
 #include <X11/Shell.h>
 #include <Xm/Xm.h>
 
 #include <X11/Shell.h>


@@ -38,6 +48,9 @@
 #if   XmVersion > 1000
 #include <Xm/Protocols.h>
 #endif
 #if   XmVersion > 1000
 #include <Xm/Protocols.h>
 #endif

+#ifdef __VMS__
+#pragma message enable nosimpint
+#endif

 
 #include "wx/motif/private.h"
 
 
 #include "wx/motif/private.h"
 


@@ -62,24 +75,23 @@ extern wxList wxPendingDelete;
 
 #define wxUSE_INVISIBLE_RESIZE 1
 
 
 #define wxUSE_INVISIBLE_RESIZE 1
 

-#if !USE_SHARED_LIBRARY

 IMPLEMENT_DYNAMIC_CLASS(wxDialog, wxPanel)
 
 BEGIN_EVENT_TABLE(wxDialog, wxPanel)
 IMPLEMENT_DYNAMIC_CLASS(wxDialog, wxPanel)
 
 BEGIN_EVENT_TABLE(wxDialog, wxPanel)

-EVT_BUTTON(wxID_OK, wxDialog::OnOK)
-EVT_BUTTON(wxID_APPLY, wxDialog::OnApply)
-EVT_BUTTON(wxID_CANCEL, wxDialog::OnCancel)
-EVT_CHAR_HOOK(wxDialog::OnCharHook)
-EVT_SYS_COLOUR_CHANGED(wxDialog::OnSysColourChanged)
-EVT_CLOSE(wxDialog::OnCloseWindow)
+  EVT_SIZE(wxDialog::OnSize)
+  EVT_BUTTON(wxID_OK, wxDialog::OnOK)
+  EVT_BUTTON(wxID_APPLY, wxDialog::OnApply)
+  EVT_BUTTON(wxID_CANCEL, wxDialog::OnCancel)
+  EVT_CHAR_HOOK(wxDialog::OnCharHook)
+  EVT_SYS_COLOUR_CHANGED(wxDialog::OnSysColourChanged)
+  EVT_CLOSE(wxDialog::OnCloseWindow)

 END_EVENT_TABLE()
 
 END_EVENT_TABLE()
 

-#endif

 
 wxDialog::wxDialog()
 {
     m_modalShowing = FALSE;
 
 wxDialog::wxDialog()
 {
     m_modalShowing = FALSE;

-    m_backgroundColour = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_3DFACE);
+    m_backgroundColour = wxSystemSettings::GetColour(wxSYS_COLOUR_3DFACE);

 }
 
 bool wxDialog::Create(wxWindow *parent, wxWindowID id,
 }
 
 bool wxDialog::Create(wxWindow *parent, wxWindowID id,


@@ -92,43 +104,43 @@ bool wxDialog::Create(wxWindow *parent, wxWindowID id,
     m_windowStyle = style;
     m_modalShowing = FALSE;
     m_dialogTitle = title;
     m_windowStyle = style;
     m_modalShowing = FALSE;
     m_dialogTitle = title;

-    
-    m_backgroundColour = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_3DFACE);
+
+    m_backgroundColour = wxSystemSettings::GetColour(wxSYS_COLOUR_3DFACE);

     m_foregroundColour = *wxBLACK;
     m_foregroundColour = *wxBLACK;

-    
+

     SetName(name);
     SetName(name);

-    
+

     if (!parent)
         wxTopLevelWindows.Append(this);
     if (!parent)
         wxTopLevelWindows.Append(this);

-    
+

     if (parent) parent->AddChild(this);
     if (parent) parent->AddChild(this);

-    
+

     if ( id == -1 )
         m_windowId = (int)NewControlId();
     else
         m_windowId = id;
     if ( id == -1 )
         m_windowId = (int)NewControlId();
     else
         m_windowId = id;

-    
+

     Widget parentWidget = (Widget) 0;
     if (parent)
         parentWidget = (Widget) parent->GetTopWidget();
     if (!parent)
         parentWidget = (Widget) wxTheApp->GetTopLevelWidget();
     Widget parentWidget = (Widget) 0;
     if (parent)
         parentWidget = (Widget) parent->GetTopWidget();
     if (!parent)
         parentWidget = (Widget) wxTheApp->GetTopLevelWidget();

-    
+

     wxASSERT_MSG( (parentWidget != (Widget) 0), "Could not find a suitable parent shell for dialog." );
     wxASSERT_MSG( (parentWidget != (Widget) 0), "Could not find a suitable parent shell for dialog." );

-    
+

     Arg args[2];
     XtSetArg (args[0], XmNdefaultPosition, False);
     XtSetArg (args[1], XmNautoUnmanage, False);
     Widget dialogShell = XmCreateBulletinBoardDialog(parentWidget, (char*) (const char*) name, args, 2);
     m_mainWidget = (WXWidget) dialogShell;
     Arg args[2];
     XtSetArg (args[0], XmNdefaultPosition, False);
     XtSetArg (args[1], XmNautoUnmanage, False);
     Widget dialogShell = XmCreateBulletinBoardDialog(parentWidget, (char*) (const char*) name, args, 2);
     m_mainWidget = (WXWidget) dialogShell;

-    
+

     // We don't want margins, since there is enough elsewhere.
     XtVaSetValues(dialogShell,
         XmNmarginHeight,   0,
         XmNmarginWidth,    0,
         XmNresizePolicy, XmRESIZE_NONE,
         NULL) ;
     // We don't want margins, since there is enough elsewhere.
     XtVaSetValues(dialogShell,
         XmNmarginHeight,   0,
         XmNmarginWidth,    0,
         XmNresizePolicy, XmRESIZE_NONE,
         NULL) ;

-    
+

     Widget shell = XtParent(dialogShell) ;
     if (!title.IsNull())
     {
     Widget shell = XtParent(dialogShell) ;
     if (!title.IsNull())
     {


@@ -138,21 +150,21 @@ bool wxDialog::Create(wxWindow *parent, wxWindowID id,
             NULL);
         XmStringFree(str);
     }
             NULL);
         XmStringFree(str);
     }

-    
-    m_windowFont = wxSystemSettings::GetSystemFont(wxSYS_DEFAULT_GUI_FONT);
+
+    m_font = wxSystemSettings::GetFont(wxSYS_DEFAULT_GUI_FONT);

     ChangeFont(FALSE);
     ChangeFont(FALSE);

-    
+

     wxAddWindowToTable(dialogShell, this);
     wxAddWindowToTable(dialogShell, this);

-    
+

     // Intercept CLOSE messages from the window manager
     Atom WM_DELETE_WINDOW = XmInternAtom(XtDisplay(shell), "WM_DELETE_WINDOW", False);
     // Intercept CLOSE messages from the window manager
     Atom WM_DELETE_WINDOW = XmInternAtom(XtDisplay(shell), "WM_DELETE_WINDOW", False);

-    
+

     /* Remove and add WM_DELETE_WINDOW so ours is only handler */
     /* Why do we have to do this for wxDialog, but not wxFrame? */
     XmRemoveWMProtocols(shell, &WM_DELETE_WINDOW, 1);
     XmAddWMProtocols(shell, &WM_DELETE_WINDOW, 1);
     XmActivateWMProtocol(shell, WM_DELETE_WINDOW);
     /* Remove and add WM_DELETE_WINDOW so ours is only handler */
     /* Why do we have to do this for wxDialog, but not wxFrame? */
     XmRemoveWMProtocols(shell, &WM_DELETE_WINDOW, 1);
     XmAddWMProtocols(shell, &WM_DELETE_WINDOW, 1);
     XmActivateWMProtocol(shell, WM_DELETE_WINDOW);

-    
+

     // Modified Steve Hammes for Motif 2.0
 #if (XmREVISION > 1 || XmVERSION > 1)
     XmAddWMProtocolCallback(shell, WM_DELETE_WINDOW, (XtCallbackProc) wxCloseDialogCallback, (XtPointer)this);
     // Modified Steve Hammes for Motif 2.0
 #if (XmREVISION > 1 || XmVERSION > 1)
     XmAddWMProtocolCallback(shell, WM_DELETE_WINDOW, (XtCallbackProc) wxCloseDialogCallback, (XtPointer)this);


@@ -161,14 +173,14 @@ bool wxDialog::Create(wxWindow *parent, wxWindowID id,
 #else
     XmAddWMProtocolCallback(shell, WM_DELETE_WINDOW, (void (*)())wxCloseDialogCallback, (caddr_t)this);
 #endif
 #else
     XmAddWMProtocolCallback(shell, WM_DELETE_WINDOW, (void (*)())wxCloseDialogCallback, (caddr_t)this);
 #endif

-    
+

     XtTranslations ptr ;
     XtOverrideTranslations(dialogShell,
         ptr = XtParseTranslationTable("<Configure>: resize()"));
     XtFree((char *)ptr);
     XtTranslations ptr ;
     XtOverrideTranslations(dialogShell,
         ptr = XtParseTranslationTable("<Configure>: resize()"));
     XtFree((char *)ptr);

-    
+

     // Can't remember what this was about... but I think it's necessary.
     // Can't remember what this was about... but I think it's necessary.

-    
+

     if (wxUSE_INVISIBLE_RESIZE)
     {
         if (pos.x > -1)
     if (wxUSE_INVISIBLE_RESIZE)
     {
         if (pos.x > -1)


@@ -177,13 +189,13 @@ bool wxDialog::Create(wxWindow *parent, wxWindowID id,
         if (pos.y > -1)
             XtVaSetValues(dialogShell, XmNy, pos.y,
             NULL);
         if (pos.y > -1)
             XtVaSetValues(dialogShell, XmNy, pos.y,
             NULL);

-        
+

         if (size.x > -1)
             XtVaSetValues(dialogShell, XmNwidth, size.x, NULL);
         if (size.y > -1)
             XtVaSetValues(dialogShell, XmNheight, size.y, NULL);
     }
         if (size.x > -1)
             XtVaSetValues(dialogShell, XmNwidth, size.x, NULL);
         if (size.y > -1)
             XtVaSetValues(dialogShell, XmNheight, size.y, NULL);
     }

-    
+

     // This patch come from Torsten Liermann lier@lier1.muc.de
     if (XmIsMotifWMRunning(shell))
     {
     // This patch come from Torsten Liermann lier@lier1.muc.de
     if (XmIsMotifWMRunning(shell))
     {


@@ -202,7 +214,7 @@ bool wxDialog::Create(wxWindow *parent, wxWindowID id,
             decor |= MWM_DECOR_MINIMIZE;
         if (m_windowStyle & wxMAXIMIZE_BOX)
             decor |= MWM_DECOR_MAXIMIZE;
             decor |= MWM_DECOR_MINIMIZE;
         if (m_windowStyle & wxMAXIMIZE_BOX)
             decor |= MWM_DECOR_MAXIMIZE;

-        
+

         XtVaSetValues(shell,XmNmwmDecorations,decor,NULL) ;
     }
     // This allows non-Motif window managers to support at least the
         XtVaSetValues(shell,XmNmwmDecorations,decor,NULL) ;
     }
     // This allows non-Motif window managers to support at least the


@@ -212,18 +224,18 @@ bool wxDialog::Create(wxWindow *parent, wxWindowID id,
         if ((m_windowStyle & wxCAPTION) != wxCAPTION)
             XtVaSetValues((Widget) shell,XmNoverrideRedirect,TRUE,NULL);
     }
         if ((m_windowStyle & wxCAPTION) != wxCAPTION)
             XtVaSetValues((Widget) shell,XmNoverrideRedirect,TRUE,NULL);
     }

-    
+

     XtRealizeWidget(dialogShell);
     XtRealizeWidget(dialogShell);

-    
+

     XtAddCallback(dialogShell,XmNunmapCallback,
         (XtCallbackProc)wxUnmapBulletinBoard,this) ;
     XtAddCallback(dialogShell,XmNunmapCallback,
         (XtCallbackProc)wxUnmapBulletinBoard,this) ;

-    
+

     // Positioning of the dialog doesn't work properly unless the dialog
     // is managed, so we manage without mapping to the screen.
     // To show, we map the shell (actually it's parent).
     if (!wxUSE_INVISIBLE_RESIZE)
         XtVaSetValues(shell, XmNmappedWhenManaged, FALSE, NULL);
     // Positioning of the dialog doesn't work properly unless the dialog
     // is managed, so we manage without mapping to the screen.
     // To show, we map the shell (actually it's parent).
     if (!wxUSE_INVISIBLE_RESIZE)
         XtVaSetValues(shell, XmNmappedWhenManaged, FALSE, NULL);

-    
+

     if (!wxUSE_INVISIBLE_RESIZE)
     {
         XtManageChild(dialogShell);
     if (!wxUSE_INVISIBLE_RESIZE)
     {
         XtManageChild(dialogShell);


@@ -231,15 +243,15 @@ bool wxDialog::Create(wxWindow *parent, wxWindowID id,
     }
     XtAddEventHandler(dialogShell,ExposureMask,FALSE,
         wxUniversalRepaintProc, (XtPointer) this);
     }
     XtAddEventHandler(dialogShell,ExposureMask,FALSE,
         wxUniversalRepaintProc, (XtPointer) this);

-    
+

     XtAddEventHandler(dialogShell,
         ButtonPressMask | ButtonReleaseMask | PointerMotionMask | KeyPressMask,
         FALSE,
         wxDialogBoxEventHandler,
         (XtPointer)this);
     XtAddEventHandler(dialogShell,
         ButtonPressMask | ButtonReleaseMask | PointerMotionMask | KeyPressMask,
         FALSE,
         wxDialogBoxEventHandler,
         (XtPointer)this);

-    
+

     ChangeBackgroundColour();
     ChangeBackgroundColour();

-    
+

     return TRUE;
 }
 
     return TRUE;
 }
 


@@ -250,7 +262,7 @@ void wxDialog::SetModal(bool flag)
     else
         if ( m_windowStyle & wxDIALOG_MODAL )
             m_windowStyle -= wxDIALOG_MODAL ;
     else
         if ( m_windowStyle & wxDIALOG_MODAL )
             m_windowStyle -= wxDIALOG_MODAL ;

-        
+

         wxModelessWindows.DeleteObject(this);
         if (!flag)
             wxModelessWindows.Append(this);
         wxModelessWindows.DeleteObject(this);
         if (!flag)
             wxModelessWindows.Append(this);


@@ -258,32 +270,34 @@ void wxDialog::SetModal(bool flag)
 
 wxDialog::~wxDialog()
 {
 
 wxDialog::~wxDialog()
 {

+    m_isBeingDeleted = TRUE;
+    

     if (m_mainWidget)
       XtRemoveEventHandler((Widget) m_mainWidget, ExposureMask, FALSE,
           wxUniversalRepaintProc, (XtPointer) this);
     if (m_mainWidget)
       XtRemoveEventHandler((Widget) m_mainWidget, ExposureMask, FALSE,
           wxUniversalRepaintProc, (XtPointer) this);

-    
+

     m_modalShowing = FALSE;
     if (!wxUSE_INVISIBLE_RESIZE && m_mainWidget)
     {
         XtUnmapWidget((Widget) m_mainWidget);
     }
     m_modalShowing = FALSE;
     if (!wxUSE_INVISIBLE_RESIZE && m_mainWidget)
     {
         XtUnmapWidget((Widget) m_mainWidget);
     }

-    
+

     wxTopLevelWindows.DeleteObject(this);
     wxTopLevelWindows.DeleteObject(this);

-    
+

     if ( (GetWindowStyleFlag() & wxDIALOG_MODAL) != wxDIALOG_MODAL )
         wxModelessWindows.DeleteObject(this);
     if ( (GetWindowStyleFlag() & wxDIALOG_MODAL) != wxDIALOG_MODAL )
         wxModelessWindows.DeleteObject(this);

-    
+

     // If this is the last top-level window, exit.
     if (wxTheApp && (wxTopLevelWindows.Number() == 0))
     {
         wxTheApp->SetTopWindow(NULL);
     // If this is the last top-level window, exit.
     if (wxTheApp && (wxTopLevelWindows.Number() == 0))
     {
         wxTheApp->SetTopWindow(NULL);

-        
+

         if (wxTheApp->GetExitOnFrameDelete())
         {
             wxTheApp->ExitMainLoop();
         }
     }
         if (wxTheApp->GetExitOnFrameDelete())
         {
             wxTheApp->ExitMainLoop();
         }
     }

-    
+

     // This event-flushing code used to be in wxWindow::PostDestroyChildren (wx_dialog.cpp)
     // but I think this should work, if we destroy the children first.
     // Note that this might need to be done for wxFrame also.
     // This event-flushing code used to be in wxWindow::PostDestroyChildren (wx_dialog.cpp)
     // but I think this should work, if we destroy the children first.
     // Note that this might need to be done for wxFrame also.


@@ -310,7 +324,7 @@ void wxDialog::OnCharHook(wxKeyEvent& event)
         wxCommandEvent cancelEvent(wxEVT_COMMAND_BUTTON_CLICKED, wxID_CANCEL);
         cancelEvent.SetEventObject( this );
         GetEventHandler()->ProcessEvent(cancelEvent);
         wxCommandEvent cancelEvent(wxEVT_COMMAND_BUTTON_CLICKED, wxID_CANCEL);
         cancelEvent.SetEventObject( this );
         GetEventHandler()->ProcessEvent(cancelEvent);

-        
+

         return;
     }
     // We didn't process this event.
         return;
     }
     // We didn't process this event.


@@ -324,6 +338,45 @@ void wxDialog::Iconize(bool WXUNUSED(iconize))
     //  XtVaSetValues((Widget) m_mainWidget, XmNiconic, iconize, NULL);
 }
 
     //  XtVaSetValues((Widget) m_mainWidget, XmNiconic, iconize, NULL);
 }
 

+// Default resizing behaviour - if only ONE subwindow,
+// resize to client rectangle size
+void wxDialog::OnSize(wxSizeEvent& WXUNUSED(event))
+{
+    // if we're using constraints - do use them
+#if wxUSE_CONSTRAINTS
+    if ( GetAutoLayout() ) {
+        Layout();
+        return;
+    }
+#endif
+
+    // do we have _exactly_ one child?
+    wxWindow *child = NULL;
+    for ( wxNode *node = GetChildren().First(); node; node = node->Next() )
+    {
+        wxWindow *win = (wxWindow *)node->Data();
+        if ( !win->IsKindOf(CLASSINFO(wxFrame))  &&
+            !win->IsKindOf(CLASSINFO(wxDialog))  )
+        {
+            if ( child )
+                return;     // it's our second subwindow - nothing to do
+            child = win;
+        }
+    }
+
+    if ( child ) {
+        // we have exactly one child - set it's size to fill the whole frame
+        int clientW, clientH;
+        GetClientSize(&clientW, &clientH);
+
+        int x = 0;
+        int y = 0;
+
+        child->SetSize(x, y, clientW, clientH);
+    }
+}
+
+

 bool wxDialog::IsIconized() const
 {
 /*
 bool wxDialog::IsIconized() const
 {
 /*


@@ -353,7 +406,7 @@ void wxDialog::SetTitle(const wxString& title)
     if (!title.IsNull())
     {
         XmString str = XmStringCreateSimple((char*) (const char*) title);
     if (!title.IsNull())
     {
         XmString str = XmStringCreateSimple((char*) (const char*) title);

-        XtVaSetValues((Widget) m_mainWidget, 
+        XtVaSetValues((Widget) m_mainWidget,

             XmNtitle, (char*) (const char*) title,
             XmNdialogTitle, str, // Roberto Cocchi
             XmNiconName, (char*) (const char*) title,
             XmNtitle, (char*) (const char*) title,
             XmNdialogTitle, str, // Roberto Cocchi
             XmNiconName, (char*) (const char*) title,


@@ -367,35 +420,6 @@ wxString wxDialog::GetTitle() const
     return m_dialogTitle;
 }
 
     return m_dialogTitle;
 }
 

-void wxDialog::Centre(int direction)
-{
-    int x_offset,y_offset ;
-    int display_width, display_height;
-    int  width, height, x, y;
-    wxWindow *parent = GetParent();
-    if ((direction & wxCENTER_FRAME) && parent)
-    {
-        parent->GetPosition(&x_offset,&y_offset) ;
-        parent->GetSize(&display_width,&display_height) ;
-    }
-    else
-    {
-        wxDisplaySize(&display_width, &display_height);
-        x_offset = 0 ;
-        y_offset = 0 ;
-    }
-    
-    GetSize(&width, &height);
-    GetPosition(&x, &y);
-    
-    if (direction & wxHORIZONTAL)
-        x = (int)((display_width - width)/2);
-    if (direction & wxVERTICAL)
-        y = (int)((display_height - height)/2);
-    
-    SetSize(x+x_offset, y+y_offset, width, height);
-}
-

 void wxDialog::Raise()
 {
     Window parent_window = XtWindow((Widget) m_mainWidget),
 void wxDialog::Raise()
 {
     Window parent_window = XtWindow((Widget) m_mainWidget),


@@ -433,16 +457,16 @@ void wxDialog::Lower()
 bool wxDialog::Show(bool show)
 {
     m_isShown = show;
 bool wxDialog::Show(bool show)
 {
     m_isShown = show;

-    
+

     if (show)
     {
         if (!wxUSE_INVISIBLE_RESIZE)
             XtMapWidget(XtParent((Widget) m_mainWidget));
         else
     if (show)
     {
         if (!wxUSE_INVISIBLE_RESIZE)
             XtMapWidget(XtParent((Widget) m_mainWidget));
         else

-            XtManageChild((Widget) m_mainWidget) ; 
-        
+            XtManageChild((Widget) m_mainWidget) ;
+

         XRaiseWindow(XtDisplay((Widget) m_mainWidget), XtWindow((Widget) m_mainWidget));
         XRaiseWindow(XtDisplay((Widget) m_mainWidget), XtWindow((Widget) m_mainWidget));

-        
+

     }
     else
     {
     }
     else
     {


@@ -450,11 +474,11 @@ bool wxDialog::Show(bool show)
             XtUnmapWidget(XtParent((Widget) m_mainWidget));
         else
             XtUnmanageChild((Widget) m_mainWidget) ;
             XtUnmapWidget(XtParent((Widget) m_mainWidget));
         else
             XtUnmanageChild((Widget) m_mainWidget) ;

-        
+

         XFlush(XtDisplay((Widget) wxTheApp->GetTopLevelWidget()));
         XSync(XtDisplay((Widget) wxTheApp->GetTopLevelWidget()), FALSE);
     }
         XFlush(XtDisplay((Widget) wxTheApp->GetTopLevelWidget()));
         XSync(XtDisplay((Widget) wxTheApp->GetTopLevelWidget()), FALSE);
     }

-    
+

     return TRUE;
 }
 
     return TRUE;
 }
 


@@ -462,43 +486,57 @@ bool wxDialog::Show(bool show)
 int wxDialog::ShowModal()
 {
     m_windowStyle |= wxDIALOG_MODAL;
 int wxDialog::ShowModal()
 {
     m_windowStyle |= wxDIALOG_MODAL;

-    
+

     Show(TRUE);
     Show(TRUE);

-    
+

     if (m_modalShowing)
         return 0;
     if (m_modalShowing)
         return 0;

-    
+

     wxModalShowingStack.Insert((wxObject *)TRUE);
     wxModalShowingStack.Insert((wxObject *)TRUE);

-    
+

     m_modalShowing = TRUE;
     XtAddGrab((Widget) m_mainWidget, TRUE, FALSE);
     m_modalShowing = TRUE;
     XtAddGrab((Widget) m_mainWidget, TRUE, FALSE);

-    
+

     XEvent event;
     XEvent event;

-    
+

     // Loop until we signal that the dialog should be closed
     while ((wxModalShowingStack.Number() > 0) && ((int)(wxModalShowingStack.First()->Data()) != 0))
     {
         //        XtAppProcessEvent((XtAppContext) wxTheApp->GetAppContext(), XtIMAll);
     // Loop until we signal that the dialog should be closed
     while ((wxModalShowingStack.Number() > 0) && ((int)(wxModalShowingStack.First()->Data()) != 0))
     {
         //        XtAppProcessEvent((XtAppContext) wxTheApp->GetAppContext(), XtIMAll);

-        
+

         XtAppNextEvent((XtAppContext) wxTheApp->GetAppContext(), &event);
         wxTheApp->ProcessXEvent((WXEvent*) &event);
         XtAppNextEvent((XtAppContext) wxTheApp->GetAppContext(), &event);
         wxTheApp->ProcessXEvent((WXEvent*) &event);

+
+        if (XtAppPending( (XtAppContext) wxTheApp->GetAppContext() ) == 0)
+        {
+            if (!wxTheApp->ProcessIdle())
+            {
+#if wxUSE_THREADS
+                // leave the main loop to give other threads a chance to
+                // perform their GUI work
+                wxMutexGuiLeave();
+                wxUsleep(20);
+                wxMutexGuiEnter();
+#endif
+            }
+        }

     }
     }

-    
+

     // Remove modal dialog flag from stack
     wxNode *node = wxModalShowingStack.First();
     if (node)
         delete node;
     // Remove modal dialog flag from stack
     wxNode *node = wxModalShowingStack.First();
     if (node)
         delete node;

-    
+

     // Now process all events in case they get sent to a destroyed dialog
     XSync(XtDisplay((Widget) wxTheApp->GetTopLevelWidget()), FALSE);
     while (XtAppPending((XtAppContext) wxTheApp->GetAppContext()))
     {
         XFlush(XtDisplay((Widget) wxTheApp->GetTopLevelWidget()));
         XtAppNextEvent((XtAppContext) wxTheApp->GetAppContext(), &event);
     // Now process all events in case they get sent to a destroyed dialog
     XSync(XtDisplay((Widget) wxTheApp->GetTopLevelWidget()), FALSE);
     while (XtAppPending((XtAppContext) wxTheApp->GetAppContext()))
     {
         XFlush(XtDisplay((Widget) wxTheApp->GetTopLevelWidget()));
         XtAppNextEvent((XtAppContext) wxTheApp->GetAppContext(), &event);

-        
+

         wxTheApp->ProcessXEvent((WXEvent*) &event);
     }
         wxTheApp->ProcessXEvent((WXEvent*) &event);
     }

-    
+

     // TODO: is it safe to call this, if the dialog may have been deleted
     // by now? Probably only if we're using delayed deletion of dialogs.
     return GetReturnCode();
     // TODO: is it safe to call this, if the dialog may have been deleted
     // by now? Probably only if we're using delayed deletion of dialogs.
     return GetReturnCode();


@@ -508,16 +546,16 @@ void wxDialog::EndModal(int retCode)
 {
     if (!m_modalShowing)
         return;
 {
     if (!m_modalShowing)
         return;

-    
+

     SetReturnCode(retCode);
     SetReturnCode(retCode);

-    
+

     // Strangely, we don't seem to need this now.
     //    XtRemoveGrab((Widget) m_mainWidget);
     // Strangely, we don't seem to need this now.
     //    XtRemoveGrab((Widget) m_mainWidget);

-    
+

     Show(FALSE);
     Show(FALSE);

-    
+

     m_modalShowing = FALSE;
     m_modalShowing = FALSE;

-    
+

     wxNode *node = wxModalShowingStack.First();
     if (node)
         node->SetData((wxObject *)FALSE);
     wxNode *node = wxModalShowingStack.First();
     if (node)
         node->SetData((wxObject *)FALSE);


@@ -556,7 +594,7 @@ void wxDialog::OnCancel(wxCommandEvent& WXUNUSED(event))
     }
 }
 
     }
 }
 

-void wxDialog::OnCloseWindow(wxCloseEvent& event)
+void wxDialog::OnCloseWindow(wxCloseEvent& WXUNUSED(event))

 {
     // We'll send a Cancel message by default,
     // which may close the dialog.
 {
     // We'll send a Cancel message by default,
     // which may close the dialog.


@@ -573,12 +611,12 @@ void wxDialog::OnCloseWindow(wxCloseEvent& event)
     // The default OnCancel (above) simply ends a modal dialog, and hides a modeless dialog.
 
     static wxList closing;
     // The default OnCancel (above) simply ends a modal dialog, and hides a modeless dialog.
 
     static wxList closing;

-    
+

     if ( closing.Member(this) )
         return;
     if ( closing.Member(this) )
         return;

-    
+

     closing.Append(this);
     closing.Append(this);

-    
+

     wxCommandEvent cancelEvent(wxEVT_COMMAND_BUTTON_CLICKED, wxID_CANCEL);
     cancelEvent.SetEventObject( this );
     GetEventHandler()->ProcessEvent(cancelEvent); // This may close the dialog
     wxCommandEvent cancelEvent(wxEVT_COMMAND_BUTTON_CLICKED, wxID_CANCEL);
     cancelEvent.SetEventObject( this );
     GetEventHandler()->ProcessEvent(cancelEvent); // This may close the dialog


@@ -586,6 +624,11 @@ void wxDialog::OnCloseWindow(wxCloseEvent& event)
     closing.DeleteObject(this);
 }
 
     closing.DeleteObject(this);
 }
 

+void wxDialog::OnPaint(wxPaintEvent &WXUNUSED(event))
+{
+  // added for compatiblity only
+}
+

 // Destroy the window (delayed, if a managed window)
 bool wxDialog::Destroy()
 {
 // Destroy the window (delayed, if a managed window)
 bool wxDialog::Destroy()
 {


@@ -596,33 +639,28 @@ bool wxDialog::Destroy()
 
 void wxDialog::OnSysColourChanged(wxSysColourChangedEvent& WXUNUSED(event))
 {
 
 void wxDialog::OnSysColourChanged(wxSysColourChangedEvent& WXUNUSED(event))
 {

-    SetBackgroundColour(wxSystemSettings::GetSystemColour(wxSYS_COLOUR_3DFACE));
+    SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_3DFACE));

     Refresh();
 }
 
     Refresh();
 }
 

-void wxDialog::Fit()
-{
-    wxWindow::Fit();
-}
-

 // Handle a close event from the window manager
 // Handle a close event from the window manager

-static void wxCloseDialogCallback( Widget WXUNUSED(widget), XtPointer client_data, 
+static void wxCloseDialogCallback( Widget WXUNUSED(widget), XtPointer client_data,

                                   XmAnyCallbackStruct *WXUNUSED(cbs))
 {
     wxDialog *dialog = (wxDialog *)client_data;
     wxCloseEvent closeEvent(wxEVT_CLOSE_WINDOW, dialog->GetId());
     closeEvent.SetEventObject(dialog);
                                   XmAnyCallbackStruct *WXUNUSED(cbs))
 {
     wxDialog *dialog = (wxDialog *)client_data;
     wxCloseEvent closeEvent(wxEVT_CLOSE_WINDOW, dialog->GetId());
     closeEvent.SetEventObject(dialog);

-    
+

     // May delete the dialog (with delayed deletion)
     dialog->GetEventHandler()->ProcessEvent(closeEvent);
 }
 
     // May delete the dialog (with delayed deletion)
     dialog->GetEventHandler()->ProcessEvent(closeEvent);
 }
 

-void wxDialogBoxEventHandler (Widget    wid,
-                                     XtPointer WXUNUSED(client_data),
-                                     XEvent*   event,
-                                     Boolean *continueToDispatch)
+void wxDialogBoxEventHandler(Widget    wid,
+                             XtPointer WXUNUSED(client_data),
+                             XEvent*   event,
+                             Boolean*  continueToDispatch)

 {
 {

-    wxDialog *dialog = (wxDialog *)wxWidgetHashTable->Get((long)wid);
+    wxDialog *dialog = (wxDialog *)wxGetWindowFromTable(wid);

     if (dialog)
     {
         wxMouseEvent wxevent(wxEVT_NULL);
     if (dialog)
     {
         wxMouseEvent wxevent(wxEVT_NULL);


@@ -660,7 +698,7 @@ void wxDialogBoxEventHandler (Widget    wid,
                     {
                         keyEvent.SetEventType(wxEVT_CHAR);
                         dialog->GetEventHandler()->ProcessEvent(keyEvent);
                     {
                         keyEvent.SetEventType(wxEVT_CHAR);
                         dialog->GetEventHandler()->ProcessEvent(keyEvent);

-                   }
+                    }

                 }
             }
         }
                 }
             }
         }