removed stray return from SetFont()

[wxWidgets.git] / src / os2 / thread.cpp

diff --git a/src/os2/thread.cpp b/src/os2/thread.cpp
index 5c73b1a6ce9a898ebf685a9e679c77973c6f436b..bcdd9e1934bdddd3064ddf3b10972e435182f802 100644 (file)
--- a/src/os2/thread.cpp
+++ b/src/os2/thread.cpp
@@ -6,14 +6,9 @@
 // Created:     04/22/98
 // RCS-ID:      $Id$
 // Copyright:   (c) Stefan Neis (2003)
 // Created:     04/22/98
 // RCS-ID:      $Id$
 // Copyright:   (c) Stefan Neis (2003)

-//                         

 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
-    #pragma implementation "thread.h"
-#endif
-

 // ----------------------------------------------------------------------------
 // headers
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
 // headers
 // ----------------------------------------------------------------------------


@@ -23,14 +18,19 @@
 
 #if wxUSE_THREADS
 
 
 #if wxUSE_THREADS
 

-#include <stdio.h>
+#include "wx/thread.h"

 
 

-#include "wx/app.h"
-#include "wx/module.h"
-#include "wx/intl.h"
+#ifndef WX_PRECOMP
+    #include "wx/intl.h"
+    #include "wx/log.h"
+    #include "wx/app.h"
+    #include "wx/module.h"
+#endif //WX_PRECOMP
+
+#include "wx/apptrait.h"

 #include "wx/utils.h"
 #include "wx/utils.h"

-#include "wx/log.h"
-#include "wx/thread.h"
+
+#include <stdio.h>

 
 #define INCL_DOSSEMAPHORES
 #define INCL_DOSPROCESS
 
 #define INCL_DOSSEMAPHORES
 #define INCL_DOSPROCESS


@@ -61,10 +61,10 @@ static ULONG                        s_ulIdMainThread = 1;
 wxMutex*                            p_wxMainMutex;
 
 // OS2 substitute for Tls pointer the current parent thread object
 wxMutex*                            p_wxMainMutex;
 
 // OS2 substitute for Tls pointer the current parent thread object

-wxThread*                           m_pThread;    // pointer to the wxWindows thread object
+wxThread*                           m_pThread;    // pointer to the wxWidgets thread object

 
 

-// if it's FALSE, some secondary thread is holding the GUI lock
-static bool gs_bGuiOwnedByMainThread = TRUE;
+// if it's false, some secondary thread is holding the GUI lock
+static bool gs_bGuiOwnedByMainThread = true;

 
 // critical section which controls access to all GUI functions: any secondary
 // thread (i.e. except the main one) must enter this crit section before doing
 
 // critical section which controls access to all GUI functions: any secondary
 // thread (i.e. except the main one) must enter this crit section before doing


@@ -78,7 +78,7 @@ static wxCriticalSection *gs_pCritsectWaitingForGui = NULL;
 static size_t gs_nWaitingForGui = 0;
 
 // are we waiting for a thread termination?
 static size_t gs_nWaitingForGui = 0;
 
 // are we waiting for a thread termination?

-static bool gs_bWaitingForThread = FALSE;
+static bool gs_bWaitingForThread = false;

 
 // ============================================================================
 // OS/2 implementation of thread and related classes
 
 // ============================================================================
 // OS/2 implementation of thread and related classes


@@ -108,13 +108,9 @@ private:
 // (Calls to DosRequestMutexSem and DosReleaseMutexSem can be nested, but
 //  the request count for a semaphore cannot exceed 65535. If an attempt is
 //  made to exceed this number, ERROR_TOO_MANY_SEM_REQUESTS is returned.)
 // (Calls to DosRequestMutexSem and DosReleaseMutexSem can be nested, but
 //  the request count for a semaphore cannot exceed 65535. If an attempt is
 //  made to exceed this number, ERROR_TOO_MANY_SEM_REQUESTS is returned.)

-wxMutexInternal::wxMutexInternal(
-  wxMutexType                       WXUNUSED(eMutexType)
-)
+wxMutexInternal::wxMutexInternal(wxMutexType WXUNUSED(eMutexType))

 {
 {

-    APIRET                          ulrc;
-
-    ulrc = ::DosCreateMutexSem(NULL, &m_vMutex, 0L, FALSE);
+    APIRET ulrc = ::DosCreateMutexSem(NULL, &m_vMutex, 0L, FALSE);

     if (ulrc != 0)
     {
         wxLogSysError(_("Can not create mutex."));
     if (ulrc != 0)
     {
         wxLogSysError(_("Can not create mutex."));


@@ -382,17 +378,15 @@ public:
 private:
     // Threads in OS/2 have only an ID, so m_hThread is both it's handle and ID
     // PM also has no real Tls mechanism to index pointers by so we'll just
 private:
     // Threads in OS/2 have only an ID, so m_hThread is both it's handle and ID
     // PM also has no real Tls mechanism to index pointers by so we'll just

-    // keep track of the wxWindows parent object here.
+    // keep track of the wxWidgets parent object here.

     TID                             m_hThread;    // handle and ID of the thread
     wxThreadState                   m_eState;     // state, see wxThreadState enum
     unsigned int                    m_nPriority;  // thread priority in "wx" units
 };
 
     TID                             m_hThread;    // handle and ID of the thread
     wxThreadState                   m_eState;     // state, see wxThreadState enum
     unsigned int                    m_nPriority;  // thread priority in "wx" units
 };
 

-void wxThreadInternal::OS2ThreadStart(
-  void * pParam
-)
+void wxThreadInternal::OS2ThreadStart( void * pParam )

 {
 {

-    DWORD                           dwRet;
+    DWORD dwRet;

     bool bWasCancelled;
 
     wxThread *pThread = (wxThread *)pParam;
     bool bWasCancelled;
 
     wxThread *pThread = (wxThread *)pParam;


@@ -405,22 +399,25 @@ void wxThreadInternal::OS2ThreadStart(
     if ( pThread->m_internal->GetState() == STATE_EXITED )
     {
         dwRet = (DWORD)-1;
     if ( pThread->m_internal->GetState() == STATE_EXITED )
     {
         dwRet = (DWORD)-1;

-        bWasCancelled = TRUE;
+        bWasCancelled = true;

     }
     else // do run thread
     {
     }
     else // do run thread
     {

-        HAB     vHab;
-        vHab = ::WinInitialize(0);
+        wxAppTraits *traits = wxTheApp ? wxTheApp->GetTraits() : NULL;
+        unsigned long ulHab;
+        if (traits)
+            traits->InitializeGui(ulHab);

         dwRet = (DWORD)pThread->Entry();
         dwRet = (DWORD)pThread->Entry();

-        ::WinTerminate(vHab);
+        if (traits)
+            traits->TerminateGui(ulHab);

 
 

-       // enter m_critsect before changing the thread state
-       pThread->m_critsect.Enter();
+        // enter m_critsect before changing the thread state
+        pThread->m_critsect.Enter();

 
 

-       bWasCancelled = pThread->m_internal->GetState() == STATE_CANCELED;
+        bWasCancelled = pThread->m_internal->GetState() == STATE_CANCELED;

 
 

-       pThread->m_internal->SetState(STATE_EXITED);
-       pThread->m_critsect.Leave();
+        pThread->m_internal->SetState(STATE_EXITED);
+        pThread->m_critsect.Leave();

     }
     pThread->OnExit();
 
     }
     pThread->OnExit();
 


@@ -439,7 +436,7 @@ void wxThreadInternal::SetPriority(
   unsigned int                      nPriority
 )
 {
   unsigned int                      nPriority
 )
 {

-    // translate wxWindows priority to the PM one
+    // translate wxWidgets priority to the PM one

     ULONG                           ulOS2_PriorityClass;
     ULONG                           ulOS2_SubPriority;
     ULONG                           ulrc;
     ULONG                           ulOS2_PriorityClass;
     ULONG                           ulOS2_SubPriority;
     ULONG                           ulrc;


@@ -470,23 +467,22 @@ void wxThreadInternal::SetPriority(
     }
 }
 
     }
 }
 

-bool wxThreadInternal::Create(
-  wxThread*                         pThread
-, unsigned int                      uStackSize
-)
+bool wxThreadInternal::Create( wxThread* pThread,
+                               unsigned int uStackSize)

 {
 {

-    int                          tid;
-    
+    int tid;
+

     if (!uStackSize)
     if (!uStackSize)

-      uStackSize = 131072;
+        uStackSize = 131072;
+

     pThread->m_critsect.Enter();
     tid = _beginthread(wxThreadInternal::OS2ThreadStart,
     pThread->m_critsect.Enter();
     tid = _beginthread(wxThreadInternal::OS2ThreadStart,

-                            NULL, uStackSize, pThread);
+                             NULL, uStackSize, pThread);

     if(tid == -1)
     {
         wxLogSysError(_("Can't create thread"));
 
     if(tid == -1)
     {
         wxLogSysError(_("Can't create thread"));
 

-        return FALSE;
+        return false;

     }
     m_hThread = tid;
     if (m_nPriority != WXTHREAD_DEFAULT_PRIORITY)
     }
     m_hThread = tid;
     if (m_nPriority != WXTHREAD_DEFAULT_PRIORITY)


@@ -494,30 +490,31 @@ bool wxThreadInternal::Create(
         SetPriority(m_nPriority);
     }
 
         SetPriority(m_nPriority);
     }
 

-    return(TRUE);
+    return true;

 }
 
 bool wxThreadInternal::Suspend()
 {
 }
 
 bool wxThreadInternal::Suspend()
 {

-    ULONG                           ulrc = ::DosSuspendThread(m_hThread);
+    ULONG ulrc = ::DosSuspendThread(m_hThread);

 
     if (ulrc != 0)
     {
         wxLogSysError(_("Can not suspend thread %lu"), m_hThread);
 
     if (ulrc != 0)
     {
         wxLogSysError(_("Can not suspend thread %lu"), m_hThread);

-        return FALSE;
+        return false;

     }
     m_eState = STATE_PAUSED;
     }
     m_eState = STATE_PAUSED;

-    return TRUE;
+
+    return true;

 }
 
 bool wxThreadInternal::Resume()
 {
 }
 
 bool wxThreadInternal::Resume()
 {

-    ULONG                           ulrc = ::DosResumeThread(m_hThread);
+    ULONG ulrc = ::DosResumeThread(m_hThread);

 
     if (ulrc != 0)
     {
         wxLogSysError(_("Can not resume thread %lu"), m_hThread);
 
     if (ulrc != 0)
     {
         wxLogSysError(_("Can not resume thread %lu"), m_hThread);

-        return FALSE;
+        return false;

     }
 
     // don't change the state from STATE_EXITED because it's special and means
     }
 
     // don't change the state from STATE_EXITED because it's special and means


@@ -528,7 +525,7 @@ bool wxThreadInternal::Resume()
         m_eState = STATE_RUNNING;
     }
 
         m_eState = STATE_RUNNING;
     }
 

-    return TRUE;
+    return true;

 }
 
 // static functions
 }
 
 // static functions


@@ -542,14 +539,15 @@ wxThread *wxThread::This()
 
 bool wxThread::IsMain()
 {
 
 bool wxThread::IsMain()
 {

-    PTIB                            ptib;
-    PPIB                            ppib;
+    PTIB ptib;
+    PPIB ppib;

 
     ::DosGetInfoBlocks(&ptib, &ppib);
 
     if (ptib->tib_ptib2->tib2_ultid == s_ulIdMainThread)
 
     ::DosGetInfoBlocks(&ptib, &ppib);
 
     if (ptib->tib_ptib2->tib2_ultid == s_ulIdMainThread)

-        return TRUE;
-    return FALSE;
+        return true;
+
+    return false;

 }
 
 #ifdef Yield
 }
 
 #ifdef Yield


@@ -658,9 +656,9 @@ wxThreadError wxThread::Resume()
 {
     if (m_internal->GetState() == STATE_NEW)
     {
 {
     if (m_internal->GetState() == STATE_NEW)
     {

-       m_internal->SetState(STATE_RUNNING);
+        m_internal->SetState(STATE_RUNNING);

         m_critsect.Leave();
         m_critsect.Leave();

-       return wxTHREAD_NO_ERROR;
+        return wxTHREAD_NO_ERROR;

     }
 
     wxCriticalSectionLocker         lock((wxCriticalSection &)m_critsect);
     }
 
     wxCriticalSectionLocker         lock((wxCriticalSection &)m_critsect);


@@ -690,9 +688,9 @@ wxThreadError wxThread::Delete(ExitCode *pRc)
 
     // we might need to resume the thread, but we might also not need to cancel
     // it if it doesn't run yet
 
     // we might need to resume the thread, but we might also not need to cancel
     // it if it doesn't run yet

-    bool shouldResume = FALSE,
-         shouldCancel = TRUE,
-         isRunning = FALSE;
+    bool shouldResume = false,
+         shouldCancel = true,
+         isRunning = false;

 
     // check if the thread already started to run
     {
 
     // check if the thread already started to run
     {


@@ -707,10 +705,10 @@ wxThreadError wxThread::Delete(ExitCode *pRc)
 
             Resume();   // it knows about STATE_EXITED special case
 
 
             Resume();   // it knows about STATE_EXITED special case
 

-            shouldCancel = FALSE;
-            isRunning = TRUE;
+            shouldCancel = false;
+            isRunning = true;

 
 

-            // shouldResume is correctly set to FALSE here
+            // shouldResume is correctly set to false here

         }
         else
         {
         }
         else
         {


@@ -722,15 +720,15 @@ wxThreadError wxThread::Delete(ExitCode *pRc)
     if ( shouldResume )
         Resume();
 
     if ( shouldResume )
         Resume();
 

-    TID                             hThread = m_internal->GetHandle();
+    TID hThread = m_internal->GetHandle();

 
     if ( isRunning || IsRunning())
     {
         if (IsMain())
         {
             // set flag for wxIsWaitingForThread()
 
     if ( isRunning || IsRunning())
     {
         if (IsMain())
         {
             // set flag for wxIsWaitingForThread()

-            gs_bWaitingForThread = TRUE;
-       }
+            gs_bWaitingForThread = true;
+        }

 
         // ask the thread to terminate
         if ( shouldCancel )
 
         // ask the thread to terminate
         if ( shouldCancel )


@@ -740,7 +738,7 @@ wxThreadError wxThread::Delete(ExitCode *pRc)
             m_internal->Cancel();
         }
 
             m_internal->Cancel();
         }
 

-#if wxUSE_GUI
+#if 0

         // we can't just wait for the thread to terminate because it might be
         // calling some GUI functions and so it will never terminate before we
         // process the Windows messages that result from these functions
         // we can't just wait for the thread to terminate because it might be
         // calling some GUI functions and so it will never terminate before we
         // process the Windows messages that result from these functions


@@ -758,41 +756,41 @@ wxThreadError wxThread::Delete(ExitCode *pRc)
             }
 
             result = ::DosWaitThread(&hThread, DCWW_NOWAIT);
             }
 
             result = ::DosWaitThread(&hThread, DCWW_NOWAIT);

-           // FIXME: We ought to have a message processing loop here!!
+            // FIXME: We ought to have a message processing loop here!!

 
             switch ( result )
 
             switch ( result )

-           {
-               case ERROR_INTERRUPT:
-               case ERROR_THREAD_NOT_TERMINATED:
-                   break;
-               case ERROR_INVALID_THREADID:
+            {
+                case ERROR_INTERRUPT:
+                case ERROR_THREAD_NOT_TERMINATED:
+                    break;
+                case ERROR_INVALID_THREADID:

                 case NO_ERROR:
                     // thread we're waiting for just terminated
                 case NO_ERROR:
                     // thread we're waiting for just terminated

-                   // or even does not exist any more.
-                   result = NO_ERROR;
-                   break;
+                    // or even does not exist any more.
+                    result = NO_ERROR;
+                    break;

                 default:
                     wxFAIL_MSG(wxT("unexpected result of DosWaitThread"));
             }
                 default:
                     wxFAIL_MSG(wxT("unexpected result of DosWaitThread"));
             }

-           if ( IsMain() )
-           {
-               // event processing - needed if we are the main thread
-               // to give other threads a chance to do remaining GUI
-               // processing and terminate cleanly.
-               wxTheApp->HandleSockets();
-               if (wxTheApp->Pending())
-                 if ( !wxTheApp->DoMessage() )
-                 {
-                     // WM_QUIT received: kill the thread
-                     Kill();
-
-                     return wxTHREAD_KILLED;
-                 }
-                 else
-                   wxUsleep(10);
-           }
-           else
-               wxUsleep(10);
+            if ( IsMain() )
+            {
+                // event processing - needed if we are the main thread
+                // to give other threads a chance to do remaining GUI
+                // processing and terminate cleanly.
+                wxTheApp->HandleSockets();
+                if (wxTheApp->Pending())
+                  if ( !wxTheApp->DoMessage() )
+                  {
+                      // WM_QUIT received: kill the thread
+                      Kill();
+
+                      return wxTHREAD_KILLED;
+                  }
+                  else
+                    wxUsleep(10);
+            }
+            else
+                wxUsleep(10);

         } while ( result != NO_ERROR );
 #else // !wxUSE_GUI
         // simply wait for the thread to terminate
         } while ( result != NO_ERROR );
 #else // !wxUSE_GUI
         // simply wait for the thread to terminate


@@ -807,7 +805,7 @@ wxThreadError wxThread::Delete(ExitCode *pRc)
 
         if ( IsMain() )
         {
 
         if ( IsMain() )
         {

-            gs_bWaitingForThread = FALSE;
+            gs_bWaitingForThread = false;

         }
     }
 
         }
     }
 


@@ -854,9 +852,7 @@ wxThreadError wxThread::Kill()
     return wxTHREAD_NO_ERROR;
 }
 
     return wxTHREAD_NO_ERROR;
 }
 

-void wxThread::Exit(
-  ExitCode                          pStatus
-)
+void wxThread::Exit(ExitCode WXUNUSED(pStatus))

 {
     delete this;
     _endthread();
 {
     delete this;
     _endthread();


@@ -938,13 +934,13 @@ bool wxThreadModule::OnInit()
     gs_pCritsectGui = new wxCriticalSection();
     gs_pCritsectGui->Enter();
 
     gs_pCritsectGui = new wxCriticalSection();
     gs_pCritsectGui->Enter();
 

-    PTIB                            ptib;
-    PPIB                            ppib;
+    PTIB ptib;
+    PPIB ppib;

 
     ::DosGetInfoBlocks(&ptib, &ppib);
 
     s_ulIdMainThread = ptib->tib_ptib2->tib2_ultid;
 
     ::DosGetInfoBlocks(&ptib, &ppib);
 
     s_ulIdMainThread = ptib->tib_ptib2->tib2_ultid;

-    return TRUE;
+    return true;

 }
 
 void wxThreadModule::OnExit()
 }
 
 void wxThreadModule::OnExit()


@@ -1007,7 +1003,7 @@ void WXDLLEXPORT wxMutexGuiLeave()
 
     if ( wxThread::IsMain() )
     {
 
     if ( wxThread::IsMain() )
     {

-        gs_bGuiOwnedByMainThread = FALSE;
+        gs_bGuiOwnedByMainThread = false;

     }
     else
     {
     }
     else
     {


@@ -1038,7 +1034,7 @@ void WXDLLEXPORT wxMutexGuiLeaveOrEnter()
         {
             gs_pCritsectGui->Enter();
 
         {
             gs_pCritsectGui->Enter();
 

-            gs_bGuiOwnedByMainThread = TRUE;
+            gs_bGuiOwnedByMainThread = true;

         }
         //else: already have it, nothing to do
     }
         }
         //else: already have it, nothing to do
     }