fix crashes due to missing npos handling in several wxString methods in STL build...

[wxWidgets.git] / src / msw / bmpbuttn.cpp

diff --git a/src/msw/bmpbuttn.cpp b/src/msw/bmpbuttn.cpp
index fd05a25f537711935ca0b12be3c6899cb0ce1d3b..b05541c6353ff74c29cc62cd93c02be8b753c7f1 100644 (file)
--- a/src/msw/bmpbuttn.cpp
+++ b/src/msw/bmpbuttn.cpp
@@ -23,10 +23,11 @@
 #ifndef WX_PRECOMP
     #include "wx/log.h"
     #include "wx/dcmemory.h"
 #ifndef WX_PRECOMP
     #include "wx/log.h"
     #include "wx/dcmemory.h"

+    #include "wx/image.h"

 #endif
 
 #include "wx/msw/private.h"
 #endif
 
 #include "wx/msw/private.h"

-#include "wx/image.h"
+#include "wx/msw/dc.h"          // for wxDCTemp

 
 #include "wx/msw/uxtheme.h"
 
 
 #include "wx/msw/uxtheme.h"
 


@@ -130,7 +131,7 @@ bool wxBitmapButton::Create(wxWindow *parent, wxWindowID id,
     const wxValidator& wxVALIDATOR_PARAM(validator),
     const wxString& name)
 {
     const wxValidator& wxVALIDATOR_PARAM(validator),
     const wxString& name)
 {

-    m_bmpNormal = bitmap;
+    SetBitmapLabel(bitmap);

     SetName(name);
 
 #if wxUSE_VALIDATORS
     SetName(name);
 
 #if wxUSE_VALIDATORS


@@ -175,7 +176,7 @@ bool wxBitmapButton::Create(wxWindow *parent, wxWindowID id,
                     msStyle,
                     0, 0, 0, 0,
                     GetWinHwnd(parent),
                     msStyle,
                     0, 0, 0, 0,
                     GetWinHwnd(parent),

-                    (HMENU)m_windowId,
+                    (HMENU)wxUIntToPtr(m_windowId.GetValue()),

                     wxGetInstance(),
                     NULL
                    );
                     wxGetInstance(),
                     NULL
                    );


@@ -184,7 +185,7 @@ bool wxBitmapButton::Create(wxWindow *parent, wxWindowID id,
     SubclassWin(m_hWnd);
 
     SetPosition(pos);
     SubclassWin(m_hWnd);
 
     SetPosition(pos);

-    SetBestSize(size);
+    SetInitialSize(size);

 
     return true;
 }
 
     return true;
 }


@@ -224,7 +225,19 @@ void wxBitmapButton::OnMouseEnterOrLeave(wxMouseEvent& event)
     event.Skip();
 }
 
     event.Skip();
 }
 

-void wxBitmapButton::OnSetBitmap()
+void wxBitmapButton::SetBitmapLabel(const wxBitmap& bitmap)
+{
+#if wxUSE_IMAGE
+    if ( !HasFlag(wxBU_AUTODRAW) && !m_disabledSetByUser && bitmap.IsOk() )
+    {
+        m_bmpDisabled = wxBitmap(bitmap.ConvertToImage().ConvertToGreyscale());
+    }
+#endif // wxUSE_IMAGE
+
+    wxBitmapButtonBase::SetBitmapLabel(bitmap);
+}
+
+void wxBitmapButton::SetBitmapFocus(const wxBitmap& focus)

 {
     // if the focus bitmap is specified but hover one isn't, use the focus
     // bitmap for hovering as well if this is consistent with the current
 {
     // if the focus bitmap is specified but hover one isn't, use the focus
     // bitmap for hovering as well if this is consistent with the current


@@ -233,15 +246,26 @@ void wxBitmapButton::OnSetBitmap()
     // rationale: this is compatible with the old wxGTK behaviour and also
     // makes it much easier to do "the right thing" for all platforms (some of
     // them, such as Windows XP, have "hot" buttons while others don't)
     // rationale: this is compatible with the old wxGTK behaviour and also
     // makes it much easier to do "the right thing" for all platforms (some of
     // them, such as Windows XP, have "hot" buttons while others don't)

-    if ( !m_bmpHover.Ok() &&
-            m_bmpFocus.Ok() &&
-                wxUxThemeEngine::GetIfActive() )
-    {
+    if ( focus.Ok() && !m_hoverSetByUser )

         m_bmpHover = m_bmpFocus;
         m_bmpHover = m_bmpFocus;

-    }

 
 

-    // this will redraw us
-    wxBitmapButtonBase::OnSetBitmap();
+    wxBitmapButtonBase::SetBitmapFocus(focus);
+}
+
+void wxBitmapButton::SetBitmapDisabled(const wxBitmap& disabled)
+{
+    if ( disabled.IsOk() )
+        m_disabledSetByUser = true;
+
+    wxBitmapButtonBase::SetBitmapDisabled(disabled);
+}
+
+void wxBitmapButton::SetBitmapHover(const wxBitmap& hover)
+{
+    if ( hover.IsOk() )
+        m_hoverSetByUser = true;
+
+    wxBitmapButtonBase::SetBitmapHover(hover);

 }
 
 #if wxUSE_UXTHEME
 }
 
 #if wxUSE_UXTHEME


@@ -408,8 +432,7 @@ bool wxBitmapButton::MSWOnDraw(WXDRAWITEMSTRUCT *item)
         }
 
         // draw the bitmap
         }
 
         // draw the bitmap

-        wxClientDC dst;
-        dst.SetHDC((WXHDC) hDC, false);
+        wxDCTemp dst((WXHDC)hDC);

         dst.DrawBitmap(*bitmap, x1, y1, true);
 
         return true;
         dst.DrawBitmap(*bitmap, x1, y1, true);
 
         return true;


@@ -583,11 +606,6 @@ wxBitmapButton::DrawButtonDisable( WXHDC dc,
     ::PatBlt( (HDC) dc, left, top, right, bottom, PATTERNPAINT);
 }
 
     ::PatBlt( (HDC) dc, left, top, right, bottom, PATTERNPAINT);
 }
 

-void wxBitmapButton::SetDefault()
-{
-    wxButton::SetDefault();
-}
-

 wxSize wxBitmapButton::DoGetBestSize() const
 {
     if ( m_bmpNormal.Ok() )
 wxSize wxBitmapButton::DoGetBestSize() const
 {
     if ( m_bmpNormal.Ok() )