Enable graphics context by default

[wxWidgets.git] / src / common / cmndata.cpp

diff --git a/src/common/cmndata.cpp b/src/common/cmndata.cpp
index 2edd26ca9af324e1e160a4d3e024bc9e17b0d40b..3c04d1d0b961b7e4b4eca4ecf0014578a3989e5c 100644 (file)
--- a/src/common/cmndata.cpp
+++ b/src/common/cmndata.cpp
@@ -38,6 +38,7 @@
     #include "wx/gdicmn.h"
 #endif
 
     #include "wx/gdicmn.h"
 #endif
 

+#include "wx/tokenzr.h"

 #include "wx/prntbase.h"
 #include "wx/printdlg.h"
 
 #include "wx/prntbase.h"
 #include "wx/printdlg.h"
 


@@ -135,43 +136,19 @@ wxString wxColourData::ToString() const
 
 bool wxColourData::FromString(const wxString& str)
 {
 
 bool wxColourData::FromString(const wxString& str)
 {

-    wxString token;
-    int n = -1; // index of the field, -1 corresponds to m_chooseFull
-    for ( wxString::const_iterator i = str.begin(); i != str.end(); ++i )
+    wxStringTokenizer tokenizer(str, wxCOL_DATA_SEP);
+    wxString token = tokenizer.GetNextToken();
+    m_chooseFull = token == '1';
+    bool success = m_chooseFull || token == '0';
+    for (int i = 0; success && i < NUM_CUSTOM; i++)

     {
     {

-        if ( *i == wxCOL_DATA_SEP )
-        {
-            if ( n == -1 )
-            {
-                if ( token == '0' )
-                    m_chooseFull = false;
-                else if ( token == '1' )
-                    m_chooseFull = true;
-                else // only '0' and '1' are used in ToString()
-                    return false;
-            }
-            else // custom colour
-            {
-                if ( n == WXSIZEOF(m_custColours) )
-                    return false;   // too many custom colours
-
-                // empty strings are used by ToString() for colours not used
-                if ( token.empty() )
-                    m_custColours[n] = wxNullColour;
-                else if ( !m_custColours[n].Set(token) )
-                    return false;   // invalid colour string
-            }
-
-            token.clear();
-            n++;
-        }
-        else // continuation of the current field
-        {
-            token += *i;
-        }
+        token = tokenizer.GetNextToken();
+        if (token.empty())
+            m_custColours[i] = wxNullColour;
+        else
+            success = m_custColours[i].Set(token);

     }
     }

-
-    return true;
+    return success;

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -365,7 +342,12 @@ wxPrintDialogData::wxPrintDialogData(const wxPrintData& printData)
     m_printMinPage = 1;
     m_printMaxPage = 9999;
     m_printNoCopies = 1;
     m_printMinPage = 1;
     m_printMaxPage = 9999;
     m_printNoCopies = 1;

+    // On Mac the Print dialog always defaults to "All Pages"
+#ifdef __WXMAC__
+    m_printAllPages = true;
+#else

     m_printAllPages = false;
     m_printAllPages = false;

+#endif

     m_printCollate = false;
     m_printToFile = false;
     m_printSelection = false;
     m_printCollate = false;
     m_printToFile = false;
     m_printSelection = false;