reset the tooltip text before changing it, this apparently prevents a spurious redraw...

[wxWidgets.git] / src / univ / winuniv.cpp

diff --git a/src/univ/winuniv.cpp b/src/univ/winuniv.cpp
index f4aeb43620bce7d755844fc36904fba567afc982..41b166cc4d8032e0d1537e58d532b9c6d39bf734 100644 (file)
--- a/src/univ/winuniv.cpp
+++ b/src/univ/winuniv.cpp
@@ -1,5 +1,5 @@
 ///////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////

-// Name:        univ/window.cpp
+// Name:        src/univ/window.cpp

 // Purpose:     implementation of extra wxWindow methods for wxUniv port
 // Author:      Vadim Zeitlin
 // Modified by:
 // Purpose:     implementation of extra wxWindow methods for wxUniv port
 // Author:      Vadim Zeitlin
 // Modified by:


@@ -17,10 +17,6 @@
 // headers
 // ---------------------------------------------------------------------------
 
 // headers
 // ---------------------------------------------------------------------------
 

-#ifdef __GNUG__
-    #pragma implementation "univwindow.h"
-#endif
-

 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 


@@ -28,18 +24,19 @@
     #pragma hdrstop
 #endif
 
     #pragma hdrstop
 #endif
 

+#include "wx/window.h"
+

 #ifndef WX_PRECOMP
     #include "wx/app.h"
 #ifndef WX_PRECOMP
     #include "wx/app.h"

-    #include "wx/window.h"

     #include "wx/dcclient.h"
     #include "wx/dcmemory.h"
     #include "wx/event.h"
     #include "wx/scrolbar.h"
     #include "wx/menu.h"
     #include "wx/frame.h"
     #include "wx/dcclient.h"
     #include "wx/dcmemory.h"
     #include "wx/event.h"
     #include "wx/scrolbar.h"
     #include "wx/menu.h"
     #include "wx/frame.h"

+    #include "wx/log.h"

 #endif // WX_PRECOMP
 
 #endif // WX_PRECOMP
 

-#include "wx/log.h"

 #include "wx/univ/colschem.h"
 #include "wx/univ/renderer.h"
 #include "wx/univ/theme.h"
 #include "wx/univ/colschem.h"
 #include "wx/univ/renderer.h"
 #include "wx/univ/theme.h"


@@ -63,6 +60,29 @@
 // implementation
 // ============================================================================
 
 // implementation
 // ============================================================================
 

+// ----------------------------------------------------------------------------
+// scrollbars class
+// ----------------------------------------------------------------------------
+
+// This is scrollbar class used to implement wxWindow's "built-in" scrollbars;
+// unlike the standard wxScrollBar class, this one is positioned outside of its
+// parent's client area
+class wxWindowScrollBar : public wxScrollBar
+{
+public:
+    wxWindowScrollBar(wxWindow *parent,
+                      wxWindowID id,
+                      const wxPoint& pos = wxDefaultPosition,
+                      const wxSize& size = wxDefaultSize,
+                      long style = wxSB_HORIZONTAL)
+        : wxScrollBar(parent, id, pos, size, style)
+    {
+    }
+
+    virtual bool CanBeOutsideClientArea() const { return true; }
+};
+
+

 // ----------------------------------------------------------------------------
 // event tables
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
 // event tables
 // ----------------------------------------------------------------------------


@@ -72,8 +92,12 @@
     IMPLEMENT_DYNAMIC_CLASS(wxWindow, wxWindowMSW)
 #elif defined(__WXGTK__)
     IMPLEMENT_DYNAMIC_CLASS(wxWindow, wxWindowGTK)
     IMPLEMENT_DYNAMIC_CLASS(wxWindow, wxWindowMSW)
 #elif defined(__WXGTK__)
     IMPLEMENT_DYNAMIC_CLASS(wxWindow, wxWindowGTK)

+#elif defined(__WXOSX_OR_COCOA__)
+    IMPLEMENT_DYNAMIC_CLASS(wxWindow, wxWindowMac)

 #elif defined(__WXMGL__)
     IMPLEMENT_DYNAMIC_CLASS(wxWindow, wxWindowMGL)
 #elif defined(__WXMGL__)
     IMPLEMENT_DYNAMIC_CLASS(wxWindow, wxWindowMGL)

+#elif defined(__WXDFB__)
+    IMPLEMENT_DYNAMIC_CLASS(wxWindow, wxWindowDFB)

 #elif defined(__WXX11__)
     IMPLEMENT_DYNAMIC_CLASS(wxWindow, wxWindowX11)
 #elif defined(__WXPM__)
 #elif defined(__WXX11__)
     IMPLEMENT_DYNAMIC_CLASS(wxWindow, wxWindowX11)
 #elif defined(__WXPM__)


@@ -103,15 +127,17 @@ END_EVENT_TABLE()
 
 void wxWindow::Init()
 {
 
 void wxWindow::Init()
 {

+#if wxUSE_SCROLLBAR

     m_scrollbarVert =
     m_scrollbarVert =

-    m_scrollbarHorz = (wxScrollBar *)NULL;
+    m_scrollbarHorz = NULL;
+#endif // wxUSE_SCROLLBAR

 
 

-    m_isCurrent = FALSE;
+    m_isCurrent = false;

 
     m_renderer = wxTheme::Get()->GetRenderer();
 
 
     m_renderer = wxTheme::Get()->GetRenderer();
 

-    m_oldSize.x = -1;
-    m_oldSize.y = -1;
+    m_oldSize.x = wxDefaultCoord;
+    m_oldSize.y = wxDefaultCoord;

 }
 
 bool wxWindow::Create(wxWindow *parent,
 }
 
 bool wxWindow::Create(wxWindow *parent,


@@ -121,33 +147,99 @@ bool wxWindow::Create(wxWindow *parent,
                       long style,
                       const wxString& name)
 {
                       long style,
                       const wxString& name)
 {

+    // Get default border
+    wxBorder border = GetBorder(style);
+    style &= ~wxBORDER_MASK;
+    style |= border;
+
+    long actualStyle = style;
+

     // we add wxCLIP_CHILDREN to get the same ("natural") behaviour under MSW
     // as under the other platforms
     // we add wxCLIP_CHILDREN to get the same ("natural") behaviour under MSW
     // as under the other platforms

-    if ( !wxWindowNative::Create(parent, id, pos, size,
-                                 style | wxCLIP_CHILDREN,
-                                 name) )
+    actualStyle |= wxCLIP_CHILDREN;
+
+    actualStyle &= ~wxVSCROLL;
+    actualStyle &= ~wxHSCROLL;
+
+#ifdef __WXMSW__
+    // without this, borders (non-client areas in general) are not repainted
+    // correctly when resizing; apparently, native NC areas are fully repainted
+    // even without this style by MSW, but wxUniv implements client area
+    // itself, so it doesn't work correctly for us
+    //
+    // FIXME: this is very expensive, we need to fix the (commented-out) code
+    //        in OnSize() instead
+    actualStyle |= wxFULL_REPAINT_ON_RESIZE;
+#endif
+
+    if ( !wxWindowNative::Create(parent, id, pos, size, actualStyle, name) )
+        return false;
+
+    // Set full style again, including those we didn't want present
+    // when calling the base window Create().
+    wxWindowBase::SetWindowStyleFlag(style);
+
+    // if we allow or should always have a vertical scrollbar, make it
+    if ( style & wxVSCROLL || style & wxALWAYS_SHOW_SB )

     {
     {

-        return FALSE;
+#if wxUSE_TWO_WINDOWS
+        SetInsertIntoMain( true );
+#endif
+#if wxUSE_SCROLLBAR
+        m_scrollbarVert = new wxWindowScrollBar(this, wxID_ANY,
+                                                wxDefaultPosition, wxDefaultSize,
+                                                wxSB_VERTICAL);
+#endif // wxUSE_SCROLLBAR
+#if wxUSE_TWO_WINDOWS
+        SetInsertIntoMain( false );
+#endif

     }
 
     }
 

-    // if we should always have the scrollbar, do show it
-    if ( GetWindowStyle() & wxALWAYS_SHOW_SB )
+    // if we should allow a horizontal scrollbar, make it
+    if ( style & wxHSCROLL )

     {
 #if wxUSE_TWO_WINDOWS
     {
 #if wxUSE_TWO_WINDOWS

-        SetInsertIntoMain( TRUE );
+        SetInsertIntoMain( true );

 #endif
 #endif

-        m_scrollbarVert = new wxScrollBar(this, -1,
-                                          wxDefaultPosition, wxDefaultSize,
-                                          wxSB_VERTICAL);
+#if wxUSE_SCROLLBAR
+        m_scrollbarHorz = new wxWindowScrollBar(this, wxID_ANY,
+                                                wxDefaultPosition, wxDefaultSize,
+                                                wxSB_HORIZONTAL);
+#endif // wxUSE_SCROLLBAR

 #if wxUSE_TWO_WINDOWS
 #if wxUSE_TWO_WINDOWS

-        SetInsertIntoMain( FALSE );
+        SetInsertIntoMain( false );

 #endif
 #endif

+    }

 
 

-        // and position it
+#if wxUSE_SCROLLBAR
+    if (m_scrollbarHorz || m_scrollbarVert)
+    {
+        // position it/them

         PositionScrollbars();
     }
         PositionScrollbars();
     }

+#endif // wxUSE_SCROLLBAR

 
 

-    return TRUE;
+    return true;
+}
+
+wxWindow::~wxWindow()
+{
+    SendDestroyEvent();
+
+#if wxUSE_SCROLLBAR
+    // clear pointers to scrollbar before deleting the children: they are
+    // children and so will be deleted by DestroyChildren() call below and if
+    // any code using the scrollbars would be called in the process or from
+    // ~wxWindowBase, the app would crash:
+    m_scrollbarVert = m_scrollbarHorz = NULL;
+#endif
+
+    // we have to destroy our children before we're destroyed because our
+    // children suppose that we're of type wxWindow, not just wxWindowNative,
+    // and so bad things may happen if they're deleted from the base class dtor
+    // as by then we're not a wxWindow any longer and wxUniv-specific virtual
+    // functions can't be called
+    DestroyChildren();

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -182,18 +274,14 @@ const wxBitmap& wxWindow::GetBackgroundBitmap(int *alignment,
 // ----------------------------------------------------------------------------
 
 // the event handlers executed when the window must be repainted
 // ----------------------------------------------------------------------------
 
 // the event handlers executed when the window must be repainted

-void wxWindow::OnNcPaint(wxPaintEvent& event)
+void wxWindow::OnNcPaint(wxNcPaintEvent& WXUNUSED(event))

 {
     if ( m_renderer )
     {
         // get the window rect
 {
     if ( m_renderer )
     {
         // get the window rect

-        wxRect rect;
-        wxSize size = GetSize();
-        rect.x =
-        rect.y = 0;
-        rect.width = size.x;
-        rect.height = size.y;
+        wxRect rect(GetSize());

 
 

+#if wxUSE_SCROLLBAR

         // if the scrollbars are outside the border, we must adjust the rect to
         // exclude them
         if ( !m_renderer->AreScrollbarsInsideBorder() )
         // if the scrollbars are outside the border, we must adjust the rect to
         // exclude them
         if ( !m_renderer->AreScrollbarsInsideBorder() )


@@ -206,6 +294,7 @@ void wxWindow::OnNcPaint(wxPaintEvent& event)
             if ( scrollbar )
                 rect.height -= scrollbar->GetSize().y;
         }
             if ( scrollbar )
                 rect.height -= scrollbar->GetSize().y;
         }

+#endif // wxUSE_SCROLLBAR

 
         // get the DC and draw the border on it
         wxWindowDC dc(this);
 
         // get the DC and draw the border on it
         wxWindowDC dc(this);


@@ -243,6 +332,7 @@ void wxWindow::OnErase(wxEraseEvent& event)
 
     DoDrawBackground(*event.GetDC());
 
 
     DoDrawBackground(*event.GetDC());
 

+#if wxUSE_SCROLLBAR

     // if we have both scrollbars, we also have a square in the corner between
     // them which we must paint
     if ( m_scrollbarVert && m_scrollbarHorz )
     // if we have both scrollbars, we also have a square in the corner between
     // them which we must paint
     if ( m_scrollbarVert && m_scrollbarHorz )


@@ -262,6 +352,7 @@ void wxWindow::OnErase(wxEraseEvent& event)
             m_renderer->DrawScrollCorner(*event.GetDC(), rectCorner);
         }
     }
             m_renderer->DrawScrollCorner(*event.GetDC(), rectCorner);
         }
     }

+#endif // wxUSE_SCROLLBAR

 }
 
 bool wxWindow::DoDrawBackground(wxDC& dc)
 }
 
 bool wxWindow::DoDrawBackground(wxDC& dc)


@@ -275,8 +366,13 @@ bool wxWindow::DoDrawBackground(wxDC& dc)
     rect.height = size.y;
 
     wxWindow * const parent = GetParent();
     rect.height = size.y;
 
     wxWindow * const parent = GetParent();

-    if ( HasTransparentBackground() && parent && parent->ProvidesBackground() )
+    if ( HasTransparentBackground() && !UseBgCol() && parent )

     {
     {

+        // DirectFB paints the parent first, then its child windows, so by
+        // the time this code is called, parent's background was already
+        // drawn and there's no point in (imperfectly!) duplicating the work
+        // here:
+#ifndef __WXDFB__

         wxASSERT( !IsTopLevel() );
 
         wxPoint pos = GetPosition();
         wxASSERT( !IsTopLevel() );
 
         wxPoint pos = GetPosition();


@@ -299,14 +395,15 @@ bool wxWindow::DoDrawBackground(wxDC& dc)
 
         // Restore DC logical origin
         dc.SetLogicalOrigin( org_x, org_y );
 
         // Restore DC logical origin
         dc.SetLogicalOrigin( org_x, org_y );

+#endif // !__WXDFB__

     }
     else
     {
     }
     else
     {

-        // Draw background ouselves
+        // Draw background ourselves

         EraseBackground( dc, rect );
     }
 
         EraseBackground( dc, rect );
     }
 

-    return TRUE;
+    return true;

 }
 
 void wxWindow::EraseBackground(wxDC& dc, const wxRect& rect)
 }
 
 void wxWindow::EraseBackground(wxDC& dc, const wxRect& rect)


@@ -340,41 +437,43 @@ void wxWindow::DoDrawBorder(wxDC& dc, const wxRect& rect)
     }
 }
 
     }
 }
 

-void wxWindow::DoDraw(wxControlRenderer *renderer)
+void wxWindow::DoDraw(wxControlRenderer * WXUNUSED(renderer))

 {
 }
 
 {
 }
 

-void wxWindow::Refresh(bool eraseBackground, const wxRect *rectClient)
+void wxWindow::Refresh(bool eraseBackground, const wxRect *rect)

 {
 {

-    wxRect rectWin;
-    wxPoint pt = GetClientAreaOrigin();
+    wxRect rectClient; // the same rectangle in client coordinates
+    wxPoint origin = GetClientAreaOrigin();

 
     wxSize size = GetClientSize();
 
 
     wxSize size = GetClientSize();
 

-    if ( rectClient )
+    if ( rect )

     {
     {

-        rectWin = *rectClient;
+        // the rectangle passed as argument is in client coordinates
+        rectClient = *rect;

 
         // don't refresh anything beyond the client area (scrollbars for
         // example)
 
         // don't refresh anything beyond the client area (scrollbars for
         // example)

-        if ( rectWin.GetRight() > size.x )
-            rectWin.SetRight(size.x);
-        if ( rectWin.GetBottom() > size.y )
-            rectWin.SetBottom(size.y);
+        if ( rectClient.GetRight() > size.x )
+            rectClient.SetRight(size.x);
+        if ( rectClient.GetBottom() > size.y )
+            rectClient.SetBottom(size.y);

 
 

-        rectWin.Offset(pt);

     }
     else // refresh the entire client area
     {
     }
     else // refresh the entire client area
     {

-        rectWin.x = pt.x;
-        rectWin.y = pt.y;
-        rectWin.width = size.x;
-        rectWin.height = size.y;
+        // x,y is already set to 0 by default
+        rectClient.SetSize(size);

     }
 
     }
 

+    // convert refresh rectangle to window coordinates:
+    wxRect rectWin(rectClient);
+    rectWin.Offset(origin);
+

     // debugging helper
 #ifdef WXDEBUG_REFRESH
     // debugging helper
 #ifdef WXDEBUG_REFRESH

-    static bool s_refreshDebug = FALSE;
+    static bool s_refreshDebug = false;

     if ( s_refreshDebug )
     {
         wxWindowDC dc(this);
     if ( s_refreshDebug )
     {
         wxWindowDC dc(this);


@@ -393,16 +492,30 @@ void wxWindow::Refresh(bool eraseBackground, const wxRect *rectClient)
     wxWindowNative::Refresh(eraseBackground, &rectWin);
 
     // Refresh all sub controls if any.
     wxWindowNative::Refresh(eraseBackground, &rectWin);
 
     // Refresh all sub controls if any.

-    wxWindowList::compatibility_iterator node = GetChildren().GetFirst();
-    while ( node )
+    wxWindowList& children = GetChildren();
+    for ( wxWindowList::iterator i = children.begin(); i != children.end(); ++i )

     {
     {

-        wxWindow *win = node->GetData();
-        // Only refresh sub controls when it is visible 
-        // and when it is in the update region.
-        if(!win->IsKindOf(CLASSINFO(wxTopLevelWindow)) && win->IsShown() && wxRegion(rectWin).Contains(win->GetRect()) != wxOutRegion)
-            win->Refresh(eraseBackground, &rectWin);
-            
-        node = node->GetNext();
+        wxWindow *child = *i;
+        // only refresh subcontrols if they are visible:
+        if ( child->IsTopLevel() || !child->IsShown() || child->IsFrozen() )
+            continue;
+
+        // ...and when the subcontrols are in the update region:
+        wxRect childrect(child->GetRect());
+        childrect.Intersect(rectClient);
+        if ( childrect.IsEmpty() )
+            continue;
+
+        // refresh the subcontrol now:
+        childrect.Offset(-child->GetPosition());
+        // NB: We must call wxWindowNative version because we need to refresh
+        //     the entire control, not just its client area, and this is why we
+        //     don't account for child client area origin here neither. Also
+        //     note that we don't pass eraseBackground to the child, but use
+        //     true instead: this is because we can't be sure that
+        //     eraseBackground=false is safe for children as well and not only
+        //     for the parent.
+        child->wxWindowNative::Refresh(eraseBackground, &childrect);

     }
 }
 
     }
 }
 


@@ -413,7 +526,7 @@ void wxWindow::Refresh(bool eraseBackground, const wxRect *rectClient)
 bool wxWindow::Enable(bool enable)
 {
     if ( !wxWindowNative::Enable(enable) )
 bool wxWindow::Enable(bool enable)
 {
     if ( !wxWindowNative::Enable(enable) )

-        return FALSE;
+        return false;

 
     // disabled window can't keep focus
     if ( FindFocus() == this && GetParent() != NULL )
 
     // disabled window can't keep focus
     if ( FindFocus() == this && GetParent() != NULL )


@@ -428,23 +541,22 @@ bool wxWindow::Enable(bool enable)
         Refresh();
     }
 
         Refresh();
     }
 

-    return TRUE;
+    return true;

 }
 
 bool wxWindow::IsFocused() const
 {
 }
 
 bool wxWindow::IsFocused() const
 {

-    wxWindow *self = wxConstCast(this, wxWindow);
-    return self->FindFocus() == self;
+    return FindFocus() == this;

 }
 
 bool wxWindow::IsPressed() const
 {
 }
 
 bool wxWindow::IsPressed() const
 {

-    return FALSE;
+    return false;

 }
 
 bool wxWindow::IsDefault() const
 {
 }
 
 bool wxWindow::IsDefault() const
 {

-    return FALSE;
+    return false;

 }
 
 bool wxWindow::IsCurrent() const
 }
 
 bool wxWindow::IsCurrent() const


@@ -455,14 +567,14 @@ bool wxWindow::IsCurrent() const
 bool wxWindow::SetCurrent(bool doit)
 {
     if ( doit == m_isCurrent )
 bool wxWindow::SetCurrent(bool doit)
 {
     if ( doit == m_isCurrent )

-        return FALSE;
+        return false;

 
     m_isCurrent = doit;
 
     if ( CanBeHighlighted() )
         Refresh();
 
 
     m_isCurrent = doit;
 
     if ( CanBeHighlighted() )
         Refresh();
 

-    return TRUE;
+    return true;

 }
 
 int wxWindow::GetStateFlags() const
 }
 
 int wxWindow::GetStateFlags() const


@@ -496,22 +608,24 @@ void wxWindow::OnSize(wxSizeEvent& event)
 {
     event.Skip();
 
 {
     event.Skip();
 

+#if wxUSE_SCROLLBAR

     if ( m_scrollbarVert || m_scrollbarHorz )
     {
         PositionScrollbars();
     }
     if ( m_scrollbarVert || m_scrollbarHorz )
     {
         PositionScrollbars();
     }

+#endif // wxUSE_SCROLLBAR

 
 #if 0   // ndef __WXMSW__
     // Refresh the area (strip) previously occupied by the border
 
 
 #if 0   // ndef __WXMSW__
     // Refresh the area (strip) previously occupied by the border
 

-    if (HasFlag( wxNO_FULL_REPAINT_ON_RESIZE ) && IsShown())
+    if ( !HasFlag(wxFULL_REPAINT_ON_RESIZE) && IsShown() )

     {
         // This code assumes that wxSizeEvent.GetSize() returns
         // the area of the entire window, not just the client
         // area.
         wxSize newSize = event.GetSize();
 
     {
         // This code assumes that wxSizeEvent.GetSize() returns
         // the area of the entire window, not just the client
         // area.
         wxSize newSize = event.GetSize();
 

-        if (m_oldSize.x == -1 && m_oldSize.y == -1)
+        if (m_oldSize.x == wxDefaultCoord && m_oldSize.y == wxDefaultCoord)

         {
             m_oldSize = newSize;
             return;
         {
             m_oldSize = newSize;
             return;


@@ -526,7 +640,7 @@ void wxWindow::OnSize(wxSizeEvent& event)
                 rect.width = m_oldSize.x;
                 rect.y = m_oldSize.y-2;
                 rect.height = 1;
                 rect.width = m_oldSize.x;
                 rect.y = m_oldSize.y-2;
                 rect.height = 1;

-                Refresh( TRUE, &rect );
+                Refresh( true, &rect );

             }
             else if (newSize.y < m_oldSize.y)
             {
             }
             else if (newSize.y < m_oldSize.y)
             {


@@ -535,7 +649,7 @@ void wxWindow::OnSize(wxSizeEvent& event)
                 rect.x = 0;
                 rect.height = 1;
                 rect.width = newSize.x;
                 rect.x = 0;
                 rect.height = 1;
                 rect.width = newSize.x;

-                wxWindowNative::Refresh( TRUE, &rect );
+                wxWindowNative::Refresh( true, &rect );

             }
 
             if (newSize.x > m_oldSize.x)
             }
 
             if (newSize.x > m_oldSize.x)


@@ -545,7 +659,7 @@ void wxWindow::OnSize(wxSizeEvent& event)
                 rect.height = m_oldSize.y;
                 rect.x = m_oldSize.x-2;
                 rect.width = 1;
                 rect.height = m_oldSize.y;
                 rect.x = m_oldSize.x-2;
                 rect.width = 1;

-                Refresh( TRUE, &rect );
+                Refresh( true, &rect );

             }
             else if (newSize.x < m_oldSize.x)
             {
             }
             else if (newSize.x < m_oldSize.x)
             {


@@ -554,11 +668,11 @@ void wxWindow::OnSize(wxSizeEvent& event)
                 rect.y = 0;
                 rect.width = 1;
                 rect.height = newSize.y;
                 rect.y = 0;
                 rect.width = 1;
                 rect.height = newSize.y;

-                wxWindowNative::Refresh( TRUE, &rect );
+                wxWindowNative::Refresh( true, &rect );

             }
         }
         else
             }
         }
         else

-        if (HasFlag( wxSUNKEN_BORDER ) || HasFlag( wxRAISED_BORDER ))
+        if (HasFlag( wxSUNKEN_BORDER ) || HasFlag( wxRAISED_BORDER ) || HasFlag( wxBORDER_THEME ))

         {
             if (newSize.y > m_oldSize.y)
             {
         {
             if (newSize.y > m_oldSize.y)
             {


@@ -567,7 +681,7 @@ void wxWindow::OnSize(wxSizeEvent& event)
                 rect.width = m_oldSize.x;
                 rect.y = m_oldSize.y-4;
                 rect.height = 2;
                 rect.width = m_oldSize.x;
                 rect.y = m_oldSize.y-4;
                 rect.height = 2;

-                Refresh( TRUE, &rect );
+                Refresh( true, &rect );

             }
             else if (newSize.y < m_oldSize.y)
             {
             }
             else if (newSize.y < m_oldSize.y)
             {


@@ -576,7 +690,7 @@ void wxWindow::OnSize(wxSizeEvent& event)
                 rect.x = 0;
                 rect.height = 2;
                 rect.width = newSize.x;
                 rect.x = 0;
                 rect.height = 2;
                 rect.width = newSize.x;

-                wxWindowNative::Refresh( TRUE, &rect );
+                wxWindowNative::Refresh( true, &rect );

             }
 
             if (newSize.x > m_oldSize.x)
             }
 
             if (newSize.x > m_oldSize.x)


@@ -586,7 +700,7 @@ void wxWindow::OnSize(wxSizeEvent& event)
                 rect.height = m_oldSize.y;
                 rect.x = m_oldSize.x-4;
                 rect.width = 2;
                 rect.height = m_oldSize.y;
                 rect.x = m_oldSize.x-4;
                 rect.width = 2;

-                Refresh( TRUE, &rect );
+                Refresh( true, &rect );

             }
             else if (newSize.x < m_oldSize.x)
             {
             }
             else if (newSize.x < m_oldSize.x)
             {


@@ -595,7 +709,7 @@ void wxWindow::OnSize(wxSizeEvent& event)
                 rect.y = 0;
                 rect.width = 2;
                 rect.height = newSize.y;
                 rect.y = 0;
                 rect.width = 2;
                 rect.height = newSize.y;

-                wxWindowNative::Refresh( TRUE, &rect );
+                wxWindowNative::Refresh( true, &rect );

             }
         }
 
             }
         }
 


@@ -656,21 +770,16 @@ void wxWindow::DoGetClientSize(int *width, int *height) const
     if ( m_renderer )
         rectBorder = m_renderer->GetBorderDimensions(GetBorder());
 
     if ( m_renderer )
         rectBorder = m_renderer->GetBorderDimensions(GetBorder());
 

-    bool inside = m_renderer->AreScrollbarsInsideBorder();
-

     if ( width )
     {
     if ( width )
     {

+#if wxUSE_SCROLLBAR

         // in any case, take account of the scrollbar
         if ( m_scrollbarVert )
             w -= m_scrollbarVert->GetSize().x;
         // in any case, take account of the scrollbar
         if ( m_scrollbarVert )
             w -= m_scrollbarVert->GetSize().x;

+#endif // wxUSE_SCROLLBAR

 
 

-        // if we don't have scrollbar or if it is outside the border (and not
-        // blended into it), take account of the right border as well
-        if ( !m_scrollbarVert || inside )
-            w -= rectBorder.width;
-
-        // and always account for the left border
-        *width = w - rectBorder.x;
+        // account for the left and right borders
+        *width = w - rectBorder.x - rectBorder.width;

 
         // we shouldn't return invalid width
         if ( *width < 0 )
 
         // we shouldn't return invalid width
         if ( *width < 0 )


@@ -679,13 +788,12 @@ void wxWindow::DoGetClientSize(int *width, int *height) const
 
     if ( height )
     {
 
     if ( height )
     {

+#if wxUSE_SCROLLBAR

         if ( m_scrollbarHorz )
             h -= m_scrollbarHorz->GetSize().y;
         if ( m_scrollbarHorz )
             h -= m_scrollbarHorz->GetSize().y;

+#endif // wxUSE_SCROLLBAR

 
 

-        if ( !m_scrollbarHorz || inside )
-            h -= rectBorder.height;
-
-        *height = h - rectBorder.y;
+        *height = h - rectBorder.y - rectBorder.height;

 
         // we shouldn't return invalid height
         if ( *height < 0 )
 
         // we shouldn't return invalid height
         if ( *height < 0 )


@@ -703,17 +811,18 @@ void wxWindow::DoSetClientSize(int width, int height)
     // and the scrollbars (as they may be offset into the border, use the
     // scrollbar position, not size - this supposes that PositionScrollbars()
     // had been called before)
     // and the scrollbars (as they may be offset into the border, use the
     // scrollbar position, not size - this supposes that PositionScrollbars()
     // had been called before)

-    bool inside = m_renderer->AreScrollbarsInsideBorder();

     wxSize size = GetSize();
     wxSize size = GetSize();

+#if wxUSE_SCROLLBAR

     if ( m_scrollbarVert )
         width += size.x - m_scrollbarVert->GetPosition().x;
     if ( m_scrollbarVert )
         width += size.x - m_scrollbarVert->GetPosition().x;

-    if ( !m_scrollbarVert || inside )
-        width += rectBorder.width;
+#endif // wxUSE_SCROLLBAR
+    width += rectBorder.width;

 
 

+#if wxUSE_SCROLLBAR

     if ( m_scrollbarHorz )
         height += size.y - m_scrollbarHorz->GetPosition().y;
     if ( m_scrollbarHorz )
         height += size.y - m_scrollbarHorz->GetPosition().y;

-    if ( !m_scrollbarHorz || inside )
-        height += rectBorder.height;
+#endif // wxUSE_SCROLLBAR
+    height += rectBorder.height;

 
     wxWindowNative::DoSetClientSize(width, height);
 }
 
     wxWindowNative::DoSetClientSize(width, height);
 }


@@ -721,6 +830,8 @@ void wxWindow::DoSetClientSize(int width, int height)
 wxHitTest wxWindow::DoHitTest(wxCoord x, wxCoord y) const
 {
     wxHitTest ht = wxWindowNative::DoHitTest(x, y);
 wxHitTest wxWindow::DoHitTest(wxCoord x, wxCoord y) const
 {
     wxHitTest ht = wxWindowNative::DoHitTest(x, y);

+
+#if wxUSE_SCROLLBAR

     if ( ht == wxHT_WINDOW_INSIDE )
     {
         if ( m_scrollbarVert && x >= m_scrollbarVert->GetPosition().x )
     if ( ht == wxHT_WINDOW_INSIDE )
     {
         if ( m_scrollbarVert && x >= m_scrollbarVert->GetPosition().x )


@@ -735,6 +846,7 @@ wxHitTest wxWindow::DoHitTest(wxCoord x, wxCoord y) const
                                                   : wxHT_WINDOW_HORZ_SCROLLBAR;
         }
     }
                                                   : wxHT_WINDOW_HORZ_SCROLLBAR;
         }
     }

+#endif // wxUSE_SCROLLBAR

 
     return ht;
 }
 
     return ht;
 }


@@ -747,15 +859,18 @@ wxHitTest wxWindow::DoHitTest(wxCoord x, wxCoord y) const
 
 void wxWindow::RefreshScrollbars()
 {
 
 void wxWindow::RefreshScrollbars()
 {

+#if wxUSE_SCROLLBAR

     if ( m_scrollbarHorz )
         m_scrollbarHorz->Refresh();
 
     if ( m_scrollbarVert )
         m_scrollbarVert->Refresh();
     if ( m_scrollbarHorz )
         m_scrollbarHorz->Refresh();
 
     if ( m_scrollbarVert )
         m_scrollbarVert->Refresh();

+#endif // wxUSE_SCROLLBAR

 }
 
 void wxWindow::PositionScrollbars()
 {
 }
 
 void wxWindow::PositionScrollbars()
 {

+#if wxUSE_SCROLLBAR

     // do not use GetClientSize/Rect as it relies on the scrollbars being
     // correctly positioned
 
     // do not use GetClientSize/Rect as it relies on the scrollbars being
     // correctly positioned
 


@@ -801,6 +916,7 @@ void wxWindow::PositionScrollbars()
     }
 
     RefreshScrollbars();
     }
 
     RefreshScrollbars();

+#endif // wxUSE_SCROLLBAR

 }
 
 void wxWindow::SetScrollbar(int orient,
 }
 
 void wxWindow::SetScrollbar(int orient,


@@ -809,10 +925,11 @@ void wxWindow::SetScrollbar(int orient,
                             int range,
                             bool refresh)
 {
                             int range,
                             bool refresh)
 {

+#if wxUSE_SCROLLBAR

     wxASSERT_MSG( pageSize <= range,
                     _T("page size can't be greater than range") );
 
     wxASSERT_MSG( pageSize <= range,
                     _T("page size can't be greater than range") );
 

-    bool hasClientSizeChanged = FALSE;
+    bool hasClientSizeChanged = false;

     wxScrollBar *scrollbar = GetScrollbar(orient);
     if ( range && (pageSize < range) )
     {
     wxScrollBar *scrollbar = GetScrollbar(orient);
     if ( range && (pageSize < range) )
     {


@@ -820,14 +937,14 @@ void wxWindow::SetScrollbar(int orient,
         {
             // create it
 #if wxUSE_TWO_WINDOWS
         {
             // create it
 #if wxUSE_TWO_WINDOWS

-            SetInsertIntoMain( TRUE );
+            SetInsertIntoMain( true );

 #endif
 #endif

-            scrollbar = new wxScrollBar(this, -1,
-                                        wxDefaultPosition, wxDefaultSize,
-                                        orient & wxVERTICAL ? wxSB_VERTICAL
-                                                            : wxSB_HORIZONTAL);
+            scrollbar = new wxWindowScrollBar(this, wxID_ANY,
+                                              wxDefaultPosition, wxDefaultSize,
+                                              orient & wxVERTICAL ? wxSB_VERTICAL
+                                                                  : wxSB_HORIZONTAL);

 #if wxUSE_TWO_WINDOWS
 #if wxUSE_TWO_WINDOWS

-            SetInsertIntoMain( FALSE );
+            SetInsertIntoMain( false );

 #endif
             if ( orient & wxVERTICAL )
                 m_scrollbarVert = scrollbar;
 #endif
             if ( orient & wxVERTICAL )
                 m_scrollbarVert = scrollbar;


@@ -835,7 +952,7 @@ void wxWindow::SetScrollbar(int orient,
                 m_scrollbarHorz = scrollbar;
 
             // the client area diminished as we created a scrollbar
                 m_scrollbarHorz = scrollbar;
 
             // the client area diminished as we created a scrollbar

-            hasClientSizeChanged = TRUE;
+            hasClientSizeChanged = true;

 
             PositionScrollbars();
         }
 
             PositionScrollbars();
         }


@@ -868,7 +985,7 @@ void wxWindow::SetScrollbar(int orient,
                     m_scrollbarHorz = NULL;
 
                 // the client area increased as we removed a scrollbar
                     m_scrollbarHorz = NULL;
 
                 // the client area increased as we removed a scrollbar

-                hasClientSizeChanged = TRUE;
+                hasClientSizeChanged = true;

 
                 // the size of the remaining scrollbar must be adjusted
                 if ( m_scrollbarHorz || m_scrollbarVert )
 
                 // the size of the remaining scrollbar must be adjusted
                 if ( m_scrollbarHorz || m_scrollbarVert )


@@ -889,14 +1006,22 @@ void wxWindow::SetScrollbar(int orient,
         (void)GetEventHandler()->ProcessEvent(event);
 #endif
     }
         (void)GetEventHandler()->ProcessEvent(event);
 #endif
     }

+#else
+    wxUnusedVar(orient);
+    wxUnusedVar(pos);
+    wxUnusedVar(pageSize);
+    wxUnusedVar(range);
+    wxUnusedVar(refresh);
+#endif // wxUSE_SCROLLBAR

 }
 
 }
 

-void wxWindow::SetScrollPos(int orient, int pos, bool refresh)
+void wxWindow::SetScrollPos(int orient, int pos, bool WXUNUSED(refresh))

 {
 {

+#if wxUSE_SCROLLBAR

     wxScrollBar *scrollbar = GetScrollbar(orient);
     wxScrollBar *scrollbar = GetScrollbar(orient);

-    wxCHECK_RET( scrollbar, _T("no scrollbar to set position for") );

 
 

-    scrollbar->SetThumbPosition(pos);
+    if (scrollbar)
+        scrollbar->SetThumbPosition(pos);

 
     // VZ: I think we can safely ignore this as we always refresh it
     //     automatically whenever the value chanegs
 
     // VZ: I think we can safely ignore this as we always refresh it
     //     automatically whenever the value chanegs


@@ -904,24 +1029,43 @@ void wxWindow::SetScrollPos(int orient, int pos, bool refresh)
     if ( refresh )
         Refresh();
 #endif
     if ( refresh )
         Refresh();
 #endif

+#else
+    wxUnusedVar(orient);
+    wxUnusedVar(pos);
+#endif // wxUSE_SCROLLBAR

 }
 
 int wxWindow::GetScrollPos(int orient) const
 {
 }
 
 int wxWindow::GetScrollPos(int orient) const
 {

+#if wxUSE_SCROLLBAR

     wxScrollBar *scrollbar = GetScrollbar(orient);
     return scrollbar ? scrollbar->GetThumbPosition() : 0;
     wxScrollBar *scrollbar = GetScrollbar(orient);
     return scrollbar ? scrollbar->GetThumbPosition() : 0;

+#else
+    wxUnusedVar(orient);
+    return 0;
+#endif // wxUSE_SCROLLBAR

 }
 
 int wxWindow::GetScrollThumb(int orient) const
 {
 }
 
 int wxWindow::GetScrollThumb(int orient) const
 {

+#if wxUSE_SCROLLBAR

     wxScrollBar *scrollbar = GetScrollbar(orient);
     return scrollbar ? scrollbar->GetThumbSize() : 0;
     wxScrollBar *scrollbar = GetScrollbar(orient);
     return scrollbar ? scrollbar->GetThumbSize() : 0;

+#else
+    wxUnusedVar(orient);
+    return 0;
+#endif // wxUSE_SCROLLBAR

 }
 
 int wxWindow::GetScrollRange(int orient) const
 {
 }
 
 int wxWindow::GetScrollRange(int orient) const
 {

+#if wxUSE_SCROLLBAR

     wxScrollBar *scrollbar = GetScrollbar(orient);
     return scrollbar ? scrollbar->GetRange() : 0;
     wxScrollBar *scrollbar = GetScrollbar(orient);
     return scrollbar ? scrollbar->GetRange() : 0;

+#else
+    wxUnusedVar(orient);
+    return 0;
+#endif // wxUSE_SCROLLBAR

 }
 
 void wxWindow::ScrollWindow(int dx, int dy, const wxRect *rect)
 }
 
 void wxWindow::ScrollWindow(int dx, int dy, const wxRect *rect)


@@ -942,13 +1086,13 @@ void wxWindow::ScrollWindow(int dx, int dy, const wxRect *rect)
     if ( dx )
     {
         r = ScrollNoRefresh(dx, 0, rect);
     if ( dx )
     {
         r = ScrollNoRefresh(dx, 0, rect);

-        Refresh(TRUE /* erase bkgnd */, &r);
+        Refresh(true /* erase bkgnd */, &r);

     }
 
     if ( dy )
     {
         r = ScrollNoRefresh(0, dy, rect);
     }
 
     if ( dy )
     {
         r = ScrollNoRefresh(0, dy, rect);

-        Refresh(TRUE /* erase bkgnd */, &r);
+        Refresh(true /* erase bkgnd */, &r);

     }
 
     // scroll children accordingly:
     }
 
     // scroll children accordingly:


@@ -958,8 +1102,10 @@ void wxWindow::ScrollWindow(int dx, int dy, const wxRect *rect)
          node; node = node->GetNext())
     {
         wxWindow *child = node->GetData();
          node; node = node->GetNext())
     {
         wxWindow *child = node->GetData();

+#if wxUSE_SCROLLBAR

         if ( child == m_scrollbarVert || child == m_scrollbarHorz )
             continue;
         if ( child == m_scrollbarVert || child == m_scrollbarHorz )
             continue;

+#endif // wxUSE_SCROLLBAR

 
         // VS: Scrolling children has non-trivial semantics. If rect=NULL then
         //     it is easy: we scroll all children. Otherwise it gets
 
         // VS: Scrolling children has non-trivial semantics. If rect=NULL then
         //     it is easy: we scroll all children. Otherwise it gets


@@ -969,24 +1115,30 @@ void wxWindow::ScrollWindow(int dx, int dy, const wxRect *rect)
         //          and scrolling direction
         //       2. if scrolling in both axes, scroll all children
 
         //          and scrolling direction
         //       2. if scrolling in both axes, scroll all children
 

+        bool shouldMove = false;
+

         if ( rect && (dx * dy == 0 /* moving in only one of x, y axis */) )
         {
             wxRect childRect = child->GetRect();
             if ( dx == 0 && (childRect.GetLeft() <= rect->GetRight() ||
                              childRect.GetRight() >= rect->GetLeft()) )
             {
         if ( rect && (dx * dy == 0 /* moving in only one of x, y axis */) )
         {
             wxRect childRect = child->GetRect();
             if ( dx == 0 && (childRect.GetLeft() <= rect->GetRight() ||
                              childRect.GetRight() >= rect->GetLeft()) )
             {

-                child->Move(child->GetPosition() + offset);
+                shouldMove = true;

             }
             else if ( dy == 0 && (childRect.GetTop() <= rect->GetBottom() ||
                                   childRect.GetBottom() >= rect->GetTop()) )
             {
             }
             else if ( dy == 0 && (childRect.GetTop() <= rect->GetBottom() ||
                                   childRect.GetBottom() >= rect->GetTop()) )
             {

-                child->Move(child->GetPosition() + offset);
+                shouldMove = true;

             }
             }

+            // else: child outside of scrolling shaft, don't move

         }
         }

-        else
+        else // scrolling in both axes or rect=NULL

         {
         {

-            child->Move(child->GetPosition() + offset);
+            shouldMove = true;

         }
         }

+
+        if ( shouldMove )
+            child->Move(child->GetPosition() + offset, wxSIZE_ALLOW_MINUS_ONE);

     }
 #endif // wxX11/!wxX11
 }
     }
 #endif // wxX11/!wxX11
 }


@@ -1071,12 +1223,12 @@ wxRect wxWindow::ScrollNoRefresh(int dx, int dy, const wxRect *rectTotal)
         wxMemoryDC dcMem;
         dcMem.SelectObject(bmp);
 
         wxMemoryDC dcMem;
         dcMem.SelectObject(bmp);
 

-        dcMem.Blit(wxPoint(0, 0), size, &dc, ptSource
+        dcMem.Blit(wxPoint(0,0), size, &dc, ptSource

 #if defined(__WXGTK__) && !defined(wxHAS_WORKING_GTK_DC_BLIT)
                 + GetClientAreaOrigin()
 #endif // broken wxGTK wxDC::Blit
                   );
 #if defined(__WXGTK__) && !defined(wxHAS_WORKING_GTK_DC_BLIT)
                 + GetClientAreaOrigin()
 #endif // broken wxGTK wxDC::Blit
                   );

-        dc.Blit(ptDest, size, &dcMem, wxPoint(0, 0));
+        dc.Blit(ptDest, size, &dcMem, wxPoint(0,0));

 
         wxLogTrace(_T("scroll"),
                    _T("Blit: (%d, %d) of size %dx%d -> (%d, %d)"),
 
         wxLogTrace(_T("scroll"),
                    _T("Blit: (%d, %d) of size %dx%d -> (%d, %d)"),


@@ -1160,7 +1312,7 @@ void wxWindow::OnKeyDown(wxKeyEvent& event)
 {
 #if wxUSE_MENUS
     int key = event.GetKeyCode();
 {
 #if wxUSE_MENUS
     int key = event.GetKeyCode();

-    if ( !event.ControlDown() && (key == WXK_MENU || key == WXK_F10) )
+    if ( !event.ControlDown() && (key == WXK_ALT || key == WXK_F10) )

     {
         ms_winLastAltPress = this;
 
     {
         ms_winLastAltPress = this;
 


@@ -1201,6 +1353,7 @@ void wxWindow::OnKeyDown(wxKeyEvent& event)
             }
 #endif // wxUSE_MENUS
 
             }
 #endif // wxUSE_MENUS
 

+#if wxUSE_BUTTON

             // if it wasn't in a menu, try to find a button
             if ( command != -1 )
             {
             // if it wasn't in a menu, try to find a button
             if ( command != -1 )
             {


@@ -1216,6 +1369,7 @@ void wxWindow::OnKeyDown(wxKeyEvent& event)
                     }
                 }
             }
                     }
                 }
             }

+#endif // wxUSE_BUTTON

 
             // don't propagate accels from the child frame to the parent one
             break;
 
             // don't propagate accels from the child frame to the parent one
             break;


@@ -1271,13 +1425,32 @@ void wxWindow::OnChar(wxKeyEvent& event)
         }
     }
 
         }
     }
 

+    // if Return was pressed, see if there's a default button to activate
+    if ( !event.HasModifiers() && event.GetKeyCode() == WXK_RETURN )
+    {
+        wxTopLevelWindow *
+            tlw = wxDynamicCast(wxGetTopLevelParent(this), wxTopLevelWindow);
+        if ( tlw )
+        {
+            wxButton *btn = wxDynamicCast(tlw->GetDefaultItem(), wxButton);
+            if ( btn )
+            {
+                wxCommandEvent evt(wxEVT_COMMAND_BUTTON_CLICKED, btn->GetId());
+                evt.SetEventObject(btn);
+                btn->Command(evt);
+                return;
+            }
+        }
+    }
+
+

     event.Skip();
 }
 
 void wxWindow::OnKeyUp(wxKeyEvent& event)
 {
     int key = event.GetKeyCode();
     event.Skip();
 }
 
 void wxWindow::OnKeyUp(wxKeyEvent& event)
 {
     int key = event.GetKeyCode();

-    if ( !event.HasModifiers() && (key == WXK_MENU || key == WXK_F10) )
+    if ( !event.HasModifiers() && (key == WXK_ALT || key == WXK_F10) )

     {
         // only process Alt release specially if there were no other key
         // presses since Alt had been pressed and if both events happened in
     {
         // only process Alt release specially if there were no other key
         // presses since Alt had been pressed and if both events happened in


@@ -1310,7 +1483,7 @@ void wxWindow::OnKeyUp(wxKeyEvent& event)
 
 #include "wx/msw/private.h"
 
 
 #include "wx/msw/private.h"
 

-long wxWindow::MSWWindowProc(WXUINT message, WXWPARAM wParam, WXLPARAM lParam)
+WXLRESULT wxWindow::MSWWindowProc(WXUINT message, WXWPARAM wParam, WXLPARAM lParam)

 {
     if ( message == WM_NCHITTEST )
     {
 {
     if ( message == WM_NCHITTEST )
     {


@@ -1327,4 +1500,3 @@ long wxWindow::MSWWindowProc(WXUINT message, WXWPARAM wParam, WXLPARAM lParam)
 }
 
 #endif // __WXMSW__
 }
 
 #endif // __WXMSW__

-