todos, cleanups, detabified

[wxWidgets.git] / wxPython / src / _taskbar.i

diff --git a/wxPython/src/_taskbar.i b/wxPython/src/_taskbar.i
index 3fbbbc660c69c83c7e95d63cf7ed7cecc8f0c66b..a43322bb81d204f34efd9eb2a26194d0df2be15c 100644 (file)
--- a/wxPython/src/_taskbar.i
+++ b/wxPython/src/_taskbar.i
@@ -23,15 +23,15 @@
 
 
 %{
-#ifdef __WXMAC__
-// implement dummy classes and such for wxMac
+#ifndef wxHAS_TASK_BAR_ICON
+// implement dummy classes for platforms that don't have it
 
 class wxTaskBarIcon : public wxEvtHandler
 {
 public:
     wxTaskBarIcon()  { wxPyRaiseNotImplemented(); }
 };
- 
+
 
 class wxTaskBarIconEvent : public wxEvent
 {
@@ -39,6 +39,11 @@ public:
     wxTaskBarIconEvent(wxEventType, wxTaskBarIcon *)
         { wxPyRaiseNotImplemented(); }
     virtual wxEvent* Clone() const { return NULL; }
+    bool IsOk() const { return false; }
+    bool IsIconInstalled() const { return false; }
+    bool SetIcon(const wxIcon& icon, const wxString& tooltip = wxPyEmptyString) { return false; }
+    bool RemoveIcon() { return false; }
+    bool PopupMenu(wxMenu *menu) { return false; }
 };
 
 enum {
@@ -50,11 +55,53 @@ enum {
     wxEVT_TASKBAR_LEFT_DCLICK = 0,
     wxEVT_TASKBAR_RIGHT_DCLICK = 0,
 };
+
+
+#else
+// // Otherwise make a class that can virtualize CreatePopupMenu
+// class wxPyTaskBarIcon : public wxTaskBarIcon
+// {
+//     DECLARE_ABSTRACT_CLASS(wxPyTaskBarIcon);
+// public:
+//     wxPyTaskBarIcon() : wxTaskBarIcon()
+//     {}
+
+//     wxMenu* CreatePopupMenu() {
+//         wxMenu *rval = NULL;
+//         bool found;
+//         bool blocked = wxPyBeginBlockThreads();
+//         if ((found = wxPyCBH_findCallback(m_myInst, "CreatePopupMenu"))) {
+//             PyObject* ro;
+//             wxMenu* ptr;
+//             ro = wxPyCBH_callCallbackObj(m_myInst, Py_BuildValue("()"));
+//             if (ro) {
+//                 if (wxPyConvertSwigPtr(ro, (void **)&ptr, wxT("wxMenu")))
+//                     rval = ptr;
+//                 Py_DECREF(ro);
+//             }
+//         }
+//         wxPyEndBlockThreads(blocked);
+//         if (! found)
+//             rval = wxTaskBarIcon::CreatePopupMenu();
+//         return rval;
+//     }
+
+//     PYPRIVATE;
+// };
+
+// IMPLEMENT_ABSTRACT_CLASS(wxPyTaskBarIcon, wxTaskBarIcon);
+
 #endif
 %}
 
 
-
+// NOTE: TaskbarIcon has not yet been changed to be able to virtualize the
+// CreatePopupMenu method because it is just before a release and I worry that
+// there will be a problem in this case with it holding a reference to itself
+// (since it depends on the dtor for cleanup.)  Better safe than sorry!
+//
+// Perhaps a better mechanism for wxPython would be to turn CreatePopupMenu
+// into an event...
 
 MustHaveApp(wxTaskBarIcon);
 
@@ -72,16 +119,14 @@ public:
         }
     }
 
-#ifndef __WXMAC__
     bool IsOk() const;
     %pythoncode { def __nonzero__(self): return self.IsOk() }
-    
+
     bool IsIconInstalled() const;
 
     bool SetIcon(const wxIcon& icon, const wxString& tooltip = wxPyEmptyString);
-    bool RemoveIcon(void);
+    bool RemoveIcon();
     bool PopupMenu(wxMenu *menu);
-#endif
 };
 
 
@@ -111,6 +156,6 @@ EVT_TASKBAR_RIGHT_DOWN = wx.PyEventBinder (   wxEVT_TASKBAR_RIGHT_DOWN )
 EVT_TASKBAR_RIGHT_UP = wx.PyEventBinder (     wxEVT_TASKBAR_RIGHT_UP )
 EVT_TASKBAR_LEFT_DCLICK = wx.PyEventBinder (  wxEVT_TASKBAR_LEFT_DCLICK )
 EVT_TASKBAR_RIGHT_DCLICK = wx.PyEventBinder ( wxEVT_TASKBAR_RIGHT_DCLICK )
-}   
+}
 
 //---------------------------------------------------------------------------