/////////////////////////////////////////////////////////////////////////////
-// Name: msw/stackwalk.cpp
+// Name: src/unix/stackwalk.cpp
// Purpose: wxStackWalker implementation for Unix/glibc
// Author: Vadim Zeitlin
// Modified by:
private:
FILE *m_fp;
- DECLARE_NO_COPY_CLASS(wxStdioPipe)
+ wxDECLARE_NO_COPY_CLASS(wxStdioPipe);
};
// ============================================================================
// format is: "module(funcname+offset) [address]" but the part in
// parentheses can be not present
wxString syminfo = wxString::FromAscii(m_syminfo);
- const size_t posOpen = syminfo.find(_T('('));
+ const size_t posOpen = syminfo.find(wxT('('));
if ( posOpen != wxString::npos )
{
- const size_t posPlus = syminfo.find(_T('+'), posOpen + 1);
+ const size_t posPlus = syminfo.find(wxT('+'), posOpen + 1);
if ( posPlus != wxString::npos )
{
- const size_t posClose = syminfo.find(_T(')'), posPlus + 1);
+ const size_t posClose = syminfo.find(wxT(')'), posPlus + 1);
if ( posClose != wxString::npos )
{
if ( m_name.empty() )
m_module.assign(syminfo, posOpen);
}
+#ifndef __WXOSX__
else // not in "module(funcname+offset)" format
{
m_module = syminfo;
}
+#endif // !__WXOSX__
}
if (!ms_symbols || !m_depth)
return;
- // we have 3 more "intermediate" frames which the calling code doesn't know
- // about, account for them
- skip += 3;
+ // we are another level down from Walk(), so adjust the number of stack
+ // frames to skip accordingly
+ skip += 1;
// call addr2line only once since this call may be very slow
// (it has to load in memory the entire EXE of this app which may be quite
// big, especially if it contains debug info and is compiled statically!)
- int towalk = InitFrames(frames, m_depth - skip, &ms_addresses[skip], &ms_symbols[skip]);
+ int numFrames = InitFrames(frames, m_depth - skip,
+ &ms_addresses[skip], &ms_symbols[skip]);
// now do user-defined operations on each frame
- for ( int n = 0; n < towalk - (int)skip; n++ )
+ for ( int n = 0; n < numFrames; n++ )
OnStackFrame(frames[n]);
}
m_depth = 0;
}
+namespace
+{
+
+// Helper function to read a line from the file and return it without the
+// trailing newline. Line number is only used for error reporting.
+bool ReadLine(FILE* fp, unsigned long num, wxString* line)
+{
+ if ( !fgets(g_buf, WXSIZEOF(g_buf), fp) )
+ {
+ wxLogDebug(wxS("cannot read address information for stack frame #%lu"),
+ num);
+ return false;
+ }
+
+ *line = wxString::FromAscii(g_buf);
+ line->RemoveLast();
+
+ return true;
+}
+
+} // anonymous namespace
+
int wxStackWalker::InitFrames(wxStackFrame *arr, size_t n, void **addresses, char **syminfo)
{
// we need to launch addr2line tool to get this information and we need to
}
}
- // build the (long) command line for executing addr2line in an optimized way
- // (e.g. use always chars, even in Unicode build: popen() always takes chars)
- int len = snprintf(g_buf, BUFSIZE, "addr2line -C -f -e \"%s\"", exepath.mb_str());
+ // build the command line for executing addr2line or atos under OS X using
+ // char* directly to avoid the conversions from Unicode
+#ifdef __WXOSX__
+ int len = snprintf(g_buf, BUFSIZE, "atos -p %d", (int)getpid());
+#else
+ int len = snprintf(g_buf, BUFSIZE, "addr2line -C -f -e \"%s\"", (const char*) exepath.mb_str());
+#endif
len = (len <= 0) ? strlen(g_buf) : len; // in case snprintf() is broken
for (size_t i=0; i<n; i++)
{
if ( !fp )
return 0;
- // parse addr2line output (should be exactly 2 lines for each address)
- // reusing the g_buf used for building the command line above
+ // parse the output reusing the same buffer to avoid any big memory
+ // allocations which could fail if our program is in a bad state
wxString name, filename;
- unsigned long line, curr=0;
- for (size_t i=0; i<n; i++)
+ unsigned long line = 0,
+ curr = 0;
+ for ( size_t i = 0; i < n; i++ )
{
- // 1st line has function name
- if ( fgets(g_buf, WXSIZEOF(g_buf), fp) )
- {
- name = wxString::FromAscii(g_buf);
- name.RemoveLast(); // trailing newline
-
- if ( name == _T("??") )
- name.clear();
- }
- else
- {
- wxLogDebug(_T("cannot read addr2line output for %d-th stack frame!"), i);
+#ifdef __WXOSX__
+ wxString buffer;
+ if ( !ReadLine(fp, i, &buffer) )
return false;
- }
- // 2nd one -- the file/line info
- if ( fgets(g_buf, WXSIZEOF(g_buf), fp) )
+ line = 0;
+ filename.clear();
+
+ // We can get back either the string in the following format:
+ //
+ // func(args) (in module) (file:line)
+ //
+ // or just the same address back if it couldn't be resolved.
+ const size_t posIn = buffer.find("(in ");
+ if ( posIn != wxString::npos )
{
- filename = wxString::FromAscii(g_buf);
- filename.RemoveLast();
+ name.assign(buffer, 0, posIn);
- const size_t posColon = filename.find(_T(':'));
- if ( posColon != wxString::npos )
- {
- // parse line number
- if ( !wxString(filename, posColon + 1, wxString::npos).
- ToULong(&line) )
- line = 0;
-
- // remove line number from 'filename'
- filename.erase(posColon);
- if ( filename == _T("??") )
- filename.clear();
- }
- else
+ size_t posAt = buffer.find(") (", posIn + 3);
+ if ( posAt != wxString::npos )
{
- wxLogDebug(_T("Unexpected addr2line format: \"%s\" - ")
- _T("the semicolon is missing"),
- filename.c_str());
+ posAt += 3; // Skip ") ("
+
+ // Discard the two last characters which are ")\n"
+ wxString location(buffer, posAt, buffer.length() - posAt - 2);
+
+ wxString linenum;
+ filename = location.BeforeFirst(':', &linenum);
+ if ( !linenum.empty() )
+ linenum.ToULong(&line);
}
}
+#else // !__WXOSX__
+ // 1st line has function name
+ if ( !ReadLine(fp, i, &name) )
+ return false;
- if (!name.empty() || !filename.empty())
+ name = wxString::FromAscii(g_buf);
+ name.RemoveLast(); // trailing newline
+
+ if ( name == wxT("??") )
+ name.clear();
+
+ // 2nd one -- the file/line info
+ if ( !ReadLine(fp, i, &filename) )
+ return false;
+
+ const size_t posColon = filename.find(wxT(':'));
+ if ( posColon != wxString::npos )
{
- // now we've got enough info to initialize curr-th stack frame:
- arr[curr++].Set(name, filename, syminfo[i], i, line, addresses[i]);
+ // parse line number (it's ok if it fails, this will just leave
+ // line at its current, invalid, 0 value)
+ wxString(filename, posColon + 1, wxString::npos).ToULong(&line);
+
+ // remove line number from 'filename'
+ filename.erase(posColon);
+ if ( filename == wxT("??") )
+ filename.clear();
}
+ else
+ {
+ wxLogDebug(wxT("Unexpected addr2line format: \"%s\" - ")
+ wxT("the semicolon is missing"),
+ filename.c_str());
+ }
+#endif // __WXOSX__/!__WXOSX__
+
+ // now we've got enough info to initialize curr-th stack frame
+ // (at worst, only addresses[i] and syminfo[i] have been initialized,
+ // but wxStackFrame::OnGetName may still be able to get function name):
+ arr[curr++].Set(name, filename, syminfo[i], i, line, addresses[i]);
}
return curr;
projects / wxWidgets.git / blobdiff