more fixes to keypress handling in wxGTK:

[wxWidgets.git] / src / generic / colrdlgg.cpp

diff --git a/src/generic/colrdlgg.cpp b/src/generic/colrdlgg.cpp
index 3b75c107b5c357a71bf787d028371964c2127391..849f205e680d76da2346990429bea33fffa20a66 100644 (file)
--- a/src/generic/colrdlgg.cpp
+++ b/src/generic/colrdlgg.cpp
@@ -5,11 +5,11 @@
 // Modified by:
 // Created:     04/01/98
 // RCS-ID:      $Id$
 // Modified by:
 // Created:     04/01/98
 // RCS-ID:      $Id$

-// Copyright:   (c) Julian Smart and Markus Holzem
-// Licence:     wxWindows license
+// Copyright:   (c) Julian Smart
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
+#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)

 #pragma implementation "colrdlgg.h"
 #endif
 
 #pragma implementation "colrdlgg.h"
 #endif
 


@@ -20,7 +20,7 @@
     #pragma hdrstop
 #endif
 
     #pragma hdrstop
 #endif
 

-#if wxUSE_COLOURDLG
+#if wxUSE_COLOURDLG && !defined(__WXGTK20__)

 
 #ifndef WX_PRECOMP
     #include "wx/utils.h"
 
 #ifndef WX_PRECOMP
     #include "wx/utils.h"


@@ -143,10 +143,9 @@ void wxGenericColourDialog::OnCloseWindow(wxCloseEvent& WXUNUSED(event))
 
 bool wxGenericColourDialog::Create(wxWindow *parent, wxColourData *data)
 {
 
 bool wxGenericColourDialog::Create(wxWindow *parent, wxColourData *data)
 {

-    if ( !wxDialog::Create(parent, -1, wxT("Colour"),
-                           wxPoint(0, 0), wxSize(900, 900),
-                           wxDEFAULT_DIALOG_STYLE | wxDIALOG_MODAL) )
-        return FALSE;
+    if ( !wxDialog::Create(parent, wxID_ANY, _("Choose colour"),
+                           wxPoint(0, 0), wxSize(900, 900)) )
+        return false;

 
     dialogParent = parent;
 
 
     dialogParent = parent;
 


@@ -157,7 +156,7 @@ bool wxGenericColourDialog::Create(wxWindow *parent, wxColourData *data)
     CalculateMeasurements();
     CreateWidgets();
 
     CalculateMeasurements();
     CreateWidgets();
 

-    return TRUE;
+    return true;

 }
 
 int wxGenericColourDialog::ShowModal()
 }
 
 int wxGenericColourDialog::ShowModal()


@@ -174,6 +173,13 @@ void wxGenericColourDialog::OnMouseEvent(wxMouseEvent& event)
     int x = (int)event.GetX();
     int y = (int)event.GetY();
 
     int x = (int)event.GetX();
     int y = (int)event.GetY();
 

+#ifdef __WXPM__
+    // Handle OS/2's reverse coordinate system and account for the dialog title
+    int                             nClientHeight;
+
+    GetClientSize(NULL, &nClientHeight);
+    y = (nClientHeight - y) + 20;
+#endif

     if ((x >= standardColoursRect.x && x <= (standardColoursRect.x + standardColoursRect.width)) &&
         (y >= standardColoursRect.y && y <= (standardColoursRect.y + standardColoursRect.height)))
     {
     if ((x >= standardColoursRect.x && x <= (standardColoursRect.x + standardColoursRect.width)) &&
         (y >= standardColoursRect.y && y <= (standardColoursRect.y + standardColoursRect.height)))
     {


@@ -199,7 +205,7 @@ void wxGenericColourDialog::OnMouseEvent(wxMouseEvent& event)
 
 void wxGenericColourDialog::OnPaint(wxPaintEvent& event)
 {
 
 void wxGenericColourDialog::OnPaint(wxPaintEvent& event)
 {

-#if !defined(__WXMOTIF__) && !defined(__WXMAC__) && !defined(__WXPM__)
+#if !defined(__WXMOTIF__) && !defined(__WXMAC__) && !defined(__WXPM__) && !defined(__WXCOCOA__)

   wxDialog::OnPaint(event);
 #endif
 
   wxDialog::OnPaint(event);
 #endif
 


@@ -208,7 +214,7 @@ void wxGenericColourDialog::OnPaint(wxPaintEvent& event)
   PaintBasicColours(dc);
   PaintCustomColours(dc);
   PaintCustomColour(dc);
   PaintBasicColours(dc);
   PaintCustomColours(dc);
   PaintCustomColour(dc);

-  PaintHighlight(dc, TRUE);
+  PaintHighlight(dc, true);

 }
 
 void wxGenericColourDialog::CalculateMeasurements()
 }
 
 void wxGenericColourDialog::CalculateMeasurements()


@@ -222,7 +228,11 @@ void wxGenericColourDialog::CalculateMeasurements()
   sectionSpacing = 15;
 
   standardColoursRect.x = 10;
   sectionSpacing = 15;
 
   standardColoursRect.x = 10;

+#ifdef __WXPM__
+  standardColoursRect.y = 15 + 20; /* OS/2 needs to account for dialog titlebar */
+#else

   standardColoursRect.y = 15;
   standardColoursRect.y = 15;

+#endif

   standardColoursRect.width = (8*smallRectangleSize.x) + (7*gridSpacing);
   standardColoursRect.height = (6*smallRectangleSize.y) + (5*gridSpacing);
 
   standardColoursRect.width = (8*smallRectangleSize.x) + (7*gridSpacing);
   standardColoursRect.height = (6*smallRectangleSize.y) + (5*gridSpacing);
 


@@ -255,11 +265,11 @@ void wxGenericColourDialog::CreateWidgets()
 #endif
 
     redSlider = new wxSlider(this, wxID_RED_SLIDER, singleCustomColour.Red(), 0, 255,
 #endif
 
     redSlider = new wxSlider(this, wxID_RED_SLIDER, singleCustomColour.Red(), 0, 255,

-        wxPoint(sliderX, 10), wxSize(-1, sliderHeight), wxVERTICAL|wxSL_LABELS);
+        wxPoint(sliderX, 10), wxSize(wxDefaultSize.x, sliderHeight), wxVERTICAL|wxSL_LABELS);

     greenSlider = new wxSlider(this, wxID_GREEN_SLIDER, singleCustomColour.Green(), 0, 255,
     greenSlider = new wxSlider(this, wxID_GREEN_SLIDER, singleCustomColour.Green(), 0, 255,

-        wxPoint(sliderX + sliderSpacing, 10), wxSize(-1, sliderHeight), wxVERTICAL|wxSL_LABELS);
+        wxPoint(sliderX + sliderSpacing, 10), wxSize(wxDefaultSize.x, sliderHeight), wxVERTICAL|wxSL_LABELS);

     blueSlider = new wxSlider(this, wxID_BLUE_SLIDER, singleCustomColour.Blue(), 0, 255,
     blueSlider = new wxSlider(this, wxID_BLUE_SLIDER, singleCustomColour.Blue(), 0, 255,

-        wxPoint(sliderX + 2*sliderSpacing, 10), wxSize(-1, sliderHeight), wxVERTICAL|wxSL_LABELS);
+        wxPoint(sliderX + 2*sliderSpacing, 10), wxSize(wxDefaultSize.x, sliderHeight), wxVERTICAL|wxSL_LABELS);

 
     wxBoxSizer *topsizer = new wxBoxSizer( wxVERTICAL );
 
 
     wxBoxSizer *topsizer = new wxBoxSizer( wxVERTICAL );
 


@@ -268,7 +278,7 @@ void wxGenericColourDialog::CreateWidgets()
 
 #if wxUSE_STATLINE
     // 2) static line
 
 #if wxUSE_STATLINE
     // 2) static line

-    topsizer->Add( new wxStaticLine( this, -1 ), 0, wxEXPAND | wxLEFT|wxRIGHT|wxTOP, 10 );
+    topsizer->Add( new wxStaticLine( this, wxID_ANY ), 0, wxEXPAND | wxLEFT|wxRIGHT|wxTOP, 10 );

 #endif
 
     // 3) buttons
 #endif
 
     // 3) buttons


@@ -276,7 +286,7 @@ void wxGenericColourDialog::CreateWidgets()
     buttonsizer->Add( new wxButton(this, wxID_ADD_CUSTOM, _("Add to custom colours") ), 0, wxLEFT|wxRIGHT, 10 );
     topsizer->Add( buttonsizer, 0, wxCENTRE | wxALL, 10 );
 
     buttonsizer->Add( new wxButton(this, wxID_ADD_CUSTOM, _("Add to custom colours") ), 0, wxLEFT|wxRIGHT, 10 );
     topsizer->Add( buttonsizer, 0, wxCENTRE | wxALL, 10 );
 

-    SetAutoLayout( TRUE );
+    SetAutoLayout( true );

     SetSizer( topsizer );
 
     topsizer->SetSizeHints( this );
     SetSizer( topsizer );
 
     topsizer->SetSizeHints( this );


@@ -293,22 +303,26 @@ void wxGenericColourDialog::InitializeColours(void)
 
     for (i = 0; i < WXSIZEOF(wxColourDialogNames); i++)
     {
 
     for (i = 0; i < WXSIZEOF(wxColourDialogNames); i++)
     {

-        wxColour *col = wxTheColourDatabase->FindColour(wxColourDialogNames[i]);
-        if (col)
-            standardColours[i].Set(col->Red(), col->Green(), col->Blue());
+        wxColour col = wxTheColourDatabase->Find(wxColourDialogNames[i]);
+        if (col.Ok())
+            standardColours[i].Set(col.Red(), col.Green(), col.Blue());

         else
             standardColours[i].Set(0, 0, 0);
     }
 
         else
             standardColours[i].Set(0, 0, 0);
     }
 

-    for (i = 0; i < 16; i++)
+    for (i = 0; i < WXSIZEOF(customColours); i++)

     {
     {

-        customColours[i] = colourData.GetCustomColour(i);
+        wxColour c = colourData.GetCustomColour(i);
+        if (c.Ok())
+            customColours[i] = colourData.GetCustomColour(i);
+        else
+            customColours[i] = wxColour(255, 255, 255);

     }
 
     wxColour curr = colourData.GetColour();
     if ( curr.Ok() )
     {
     }
 
     wxColour curr = colourData.GetColour();
     if ( curr.Ok() )
     {

-        bool initColourFound = FALSE;
+        bool initColourFound = false;

 
         for (i = 0; i < WXSIZEOF(wxColourDialogNames); i++)
         {
 
         for (i = 0; i < WXSIZEOF(wxColourDialogNames); i++)
         {


@@ -316,19 +330,18 @@ void wxGenericColourDialog::InitializeColours(void)
             {
                 whichKind = 1;
                 colourSelection = i;
             {
                 whichKind = 1;
                 colourSelection = i;

-                initColourFound = TRUE;
+                initColourFound = true;

                 break;
             }
         }
         if ( !initColourFound )
         {
                 break;
             }
         }
         if ( !initColourFound )
         {

-            for ( i = 0; i < 16; i++ )
+            for ( i = 0; i < WXSIZEOF(customColours); i++ )

             {
                 if ( customColours[i] == curr )
                 {
                     whichKind = 2;
                     colourSelection = i;
             {
                 if ( customColours[i] == curr )
                 {
                     whichKind = 2;
                     colourSelection = i;

-                    initColourFound = TRUE;

                     break;
                 }
             }
                     break;
                 }
             }


@@ -464,46 +477,46 @@ void wxGenericColourDialog::PaintCustomColour(wxDC& dc)
 
 void wxGenericColourDialog::OnBasicColourClick(int which)
 {
 
 void wxGenericColourDialog::OnBasicColourClick(int which)
 {

-  wxClientDC dc(this);
+    wxClientDC dc(this);

 
 

-  PaintHighlight(dc, FALSE);
-  whichKind = 1;
-  colourSelection = which;
-  colourData.SetColour(standardColours[colourSelection]);
-  redSlider->SetValue( standardColours[colourSelection].Red() );
+    PaintHighlight(dc, false);
+    whichKind = 1;
+    colourSelection = which;
+    colourData.SetColour(standardColours[colourSelection]);
+    redSlider->SetValue( standardColours[colourSelection].Red() );

     greenSlider->SetValue( standardColours[colourSelection].Green() );
     blueSlider->SetValue( standardColours[colourSelection].Blue() );
     greenSlider->SetValue( standardColours[colourSelection].Green() );
     blueSlider->SetValue( standardColours[colourSelection].Blue() );

-  singleCustomColour.Set(standardColours[colourSelection].Red(), standardColours[colourSelection].Green(), standardColours[colourSelection].Blue());
+    singleCustomColour.Set(standardColours[colourSelection].Red(), standardColours[colourSelection].Green(), standardColours[colourSelection].Blue());

 
 

-  PaintCustomColour(dc);
-    PaintHighlight(dc, TRUE);
+    PaintCustomColour(dc);
+    PaintHighlight(dc, true);

 }
 
 void wxGenericColourDialog::OnCustomColourClick(int which)
 {
 }
 
 void wxGenericColourDialog::OnCustomColourClick(int which)
 {

-  wxClientDC dc(this);
-  PaintHighlight(dc, FALSE);
-  whichKind = 2;
-  colourSelection = which;
-  colourData.SetColour(customColours[colourSelection]);
-  redSlider->SetValue( customColours[colourSelection].Red() );
+    wxClientDC dc(this);
+    PaintHighlight(dc, false);
+    whichKind = 2;
+    colourSelection = which;
+    colourData.SetColour(customColours[colourSelection]);
+    redSlider->SetValue( customColours[colourSelection].Red() );

     greenSlider->SetValue( customColours[colourSelection].Green() );
     blueSlider->SetValue( customColours[colourSelection].Blue() );
     greenSlider->SetValue( customColours[colourSelection].Green() );
     blueSlider->SetValue( customColours[colourSelection].Blue() );

-  singleCustomColour.Set(customColours[colourSelection].Red(), customColours[colourSelection].Green(), customColours[colourSelection].Blue());
-  PaintCustomColour(dc);
-  PaintHighlight(dc, TRUE);
+    singleCustomColour.Set(customColours[colourSelection].Red(), customColours[colourSelection].Green(), customColours[colourSelection].Blue());
+    PaintCustomColour(dc);
+    PaintHighlight(dc, true);

 }
 
 /*
 void wxGenericColourDialog::OnOk(void)
 {
 }
 
 /*
 void wxGenericColourDialog::OnOk(void)
 {

-  Show(FALSE);
+  Show(false);

 }
 
 void wxGenericColourDialog::OnCancel(void)
 {
 }
 
 void wxGenericColourDialog::OnCancel(void)
 {

-  colourDialogCancelled = TRUE;
-  Show(FALSE);
+  colourDialogCancelled = true;
+  Show(false);

 }
 */
 
 }
 */
 


@@ -512,10 +525,10 @@ void wxGenericColourDialog::OnAddCustom(wxCommandEvent& WXUNUSED(event))
   wxClientDC dc(this);
   if (whichKind != 2)
   {
   wxClientDC dc(this);
   if (whichKind != 2)
   {

-    PaintHighlight(dc, FALSE);
+    PaintHighlight(dc, false);

     whichKind = 2;
     colourSelection = 0;
     whichKind = 2;
     colourSelection = 0;

-    PaintHighlight(dc, TRUE);
+    PaintHighlight(dc, true);

   }
 
   customColours[colourSelection].Set(singleCustomColour.Red(), singleCustomColour.Green(), singleCustomColour.Blue());
   }
 
   customColours[colourSelection].Set(singleCustomColour.Red(), singleCustomColour.Green(), singleCustomColour.Blue());


@@ -555,5 +568,5 @@ void wxGenericColourDialog::OnBlueSlider(wxCommandEvent& WXUNUSED(event))
   PaintCustomColour(dc);
 }
 
   PaintCustomColour(dc);
 }
 

-#endif // wxUSE_COLOURDLG
+#endif // wxUSE_COLOURDLG && !defined(__WXGTK20__)