Added missing test in wxObject::Ref() for already

[wxWidgets.git] / src / gtk1 / pen.cpp

diff --git a/src/gtk1/pen.cpp b/src/gtk1/pen.cpp
index c398c71b583e41a6472eaee99ed2f5cbc4d923d7..7ba9b5940d8aab67a040861fca2e93d4557b75f8 100644 (file)
--- a/src/gtk1/pen.cpp
+++ b/src/gtk1/pen.cpp
@@ -23,43 +23,48 @@
 class wxPenRefData: public wxObjectRefData
 {
 public:
-
-  wxPenRefData();
-  wxPenRefData( const wxPenRefData& data );
-
-  int        m_width;
-  int        m_style;
-  int        m_joinStyle;
-  int        m_capStyle;
-  wxColour   m_colour;
-  int        m_countDashes;
-  wxGTKDash *m_dash;
-};
-
-wxPenRefData::wxPenRefData()
-{
-    m_width = 1;
-    m_style = wxSOLID;
-    m_joinStyle = wxJOIN_ROUND;
-    m_capStyle = wxCAP_ROUND;
-    m_dash = (wxGTKDash*) NULL;
-    m_countDashes = 0;
-}
-
-wxPenRefData::wxPenRefData( const wxPenRefData& data )
-{
-    m_style = data.m_style;
-    m_width = data.m_width;
-    m_joinStyle = data.m_joinStyle;
-    m_capStyle = data.m_capStyle;
-    m_colour = data.m_colour;
-    m_countDashes = data.m_countDashes;
+    wxPenRefData()
+    {
+        m_width = 1;
+        m_style = wxSOLID;
+        m_joinStyle = wxJOIN_ROUND;
+        m_capStyle = wxCAP_ROUND;
+        m_dash = (wxGTKDash*) NULL;
+        m_countDashes = 0;
+    }
+    
+    wxPenRefData( const wxPenRefData& data )
+    {
+        m_style = data.m_style;
+        m_width = data.m_width;
+        m_joinStyle = data.m_joinStyle;
+        m_capStyle = data.m_capStyle;
+        m_colour = data.m_colour;
+        m_countDashes = data.m_countDashes;
 /*
-    if (data.m_dash)  TODO
-      m_dash = new
+        if (data.m_dash)  TODO
+            m_dash = new
 */
-    m_dash = data.m_dash;
-}
+        m_dash = data.m_dash;
+    }
+
+    bool operator == (const wxPenRefData& data) const
+    {
+        return (m_style == data.m_style &&
+                m_width == data.m_width &&
+                m_joinStyle == data.m_joinStyle &&
+                m_capStyle == data.m_capStyle &&
+                m_colour == data.m_colour);
+    }
+            
+    int        m_width;
+    int        m_style;
+    int        m_joinStyle;
+    int        m_capStyle;
+    wxColour   m_colour;
+    int        m_countDashes;
+    wxGTKDash *m_dash;
+};
 
 //-----------------------------------------------------------------------------
 
@@ -67,10 +72,6 @@ wxPenRefData::wxPenRefData( const wxPenRefData& data )
 
 IMPLEMENT_DYNAMIC_CLASS(wxPen,wxGDIObject)
 
-wxPen::wxPen()
-{
-}
-
 wxPen::wxPen( const wxColour &colour, int width, int style )
 {
     m_refData = new wxPenRefData();
@@ -79,73 +80,77 @@ wxPen::wxPen( const wxColour &colour, int width, int style )
     M_PENDATA->m_colour = colour;
 }
 
-wxPen::wxPen( const wxPen& pen )
-{
-    Ref( pen );
-}
-
 wxPen::~wxPen()
 {
+    // m_refData unrefed in ~wxObject
 }
 
-wxPen& wxPen::operator = ( const wxPen& pen )
+wxObjectRefData *wxPen::CreateRefData() const
 {
-    if ( m_refData != pen.m_refData )
-        Ref( pen );
-
-    return *this;
+    return new wxPenRefData;
 }
 
-bool wxPen::operator == ( const wxPen& pen ) const
+wxObjectRefData *wxPen::CloneRefData(const wxObjectRefData *data) const
 {
-    return m_refData == pen.m_refData;
+    return new wxPenRefData(*(wxPenRefData *)data);
 }
 
-bool wxPen::operator != ( const wxPen& pen ) const
+bool wxPen::operator == ( const wxPen& pen ) const
 {
-    return m_refData != pen.m_refData;
+    if (m_refData == pen.m_refData) return TRUE;
+    
+    if (!m_refData || !pen.m_refData) return FALSE;
+    
+    return ( *(wxPenRefData*)m_refData == *(wxPenRefData*)pen.m_refData );
 }
 
 void wxPen::SetColour( const wxColour &colour )
 {
-    Unshare();
+    AllocExclusive();
+    
     M_PENDATA->m_colour = colour;
 }
 
 void wxPen::SetDashes( int number_of_dashes, const wxDash *dash )
 {
-    Unshare();
+    AllocExclusive();
+    
     M_PENDATA->m_countDashes = number_of_dashes;
     M_PENDATA->m_dash = (wxGTKDash *)dash; /* TODO */
 }
 
 void wxPen::SetColour( int red, int green, int blue )
 {
-    Unshare();
+    AllocExclusive();
+    
     M_PENDATA->m_colour.Set( red, green, blue );
 }
 
 void wxPen::SetCap( int capStyle )
 {
-    Unshare();
+    AllocExclusive();
+    
     M_PENDATA->m_capStyle = capStyle;
 }
 
 void wxPen::SetJoin( int joinStyle )
 {
-    Unshare();
+    AllocExclusive();
+    
     M_PENDATA->m_joinStyle = joinStyle;
 }
 
 void wxPen::SetStyle( int style )
 {
-    Unshare();
+    AllocExclusive();
+    
     M_PENDATA->m_style = style;
 }
 
 void wxPen::SetWidth( int width )
 {
-    Unshare();
+    AllocExclusive();
+    
     M_PENDATA->m_width = width;
 }
 
@@ -200,22 +205,3 @@ wxColour &wxPen::GetColour() const
     return M_PENDATA->m_colour;
 }
 
-bool wxPen::Ok() const
-{
-    return (m_refData != NULL);
-}
-
-void wxPen::Unshare()
-{
-    if (!m_refData)
-    {
-        m_refData = new wxPenRefData();
-    }
-    else
-    {
-        wxPenRefData* ref = new wxPenRefData( *(wxPenRefData*)m_refData );
-        UnRef();
-        m_refData = ref;
-    }
-}
-