width and height arguments are no longer ignored in wxRadioBox::SetSize()

[wxWidgets.git] / src / gtk1 / listbox.cpp

diff --git a/src/gtk1/listbox.cpp b/src/gtk1/listbox.cpp
index ade85f736928a2b3c63045961b2995e7fdc89bef..32cf66671e2e3169d8ecb0c60e2ce98a65446050 100644 (file)
--- a/src/gtk1/listbox.cpp
+++ b/src/gtk1/listbox.cpp
@@ -2,9 +2,8 @@
 // Name:        listbox.cpp
 // Purpose:
 // Author:      Robert Roebling
 // Name:        listbox.cpp
 // Purpose:
 // Author:      Robert Roebling

-// Created:     01/02/97
-// Id:
-// Copyright:   (c) 1998 Robert Roebling, Julian Smart and Markus Holzem
+// Id:          $Id$
+// Copyright:   (c) 1998 Robert Roebling

 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 


@@ -16,340 +15,738 @@
 #include "wx/dynarray.h"
 #include "wx/listbox.h"
 #include "wx/utils.h"
 #include "wx/dynarray.h"
 #include "wx/listbox.h"
 #include "wx/utils.h"

+#include "wx/intl.h"
+#include "wx/checklst.h"
+
+#if wxUSE_DRAG_AND_DROP
+#include "wx/dnd.h"
+#endif
+
+#include "gdk/gdk.h"
+#include "gtk/gtk.h"
+
+//-------------------------------------------------------------------------
+// conditional compilation
+//-------------------------------------------------------------------------
+
+#if (GTK_MINOR_VERSION == 1)
+#if (GTK_MICRO_VERSION >= 5)
+#define NEW_GTK_SCROLL_CODE
+#endif
+#endif

 
 //-----------------------------------------------------------------------------
 // data
 //-----------------------------------------------------------------------------
 
 extern bool   g_blockEventsOnDrag;
 
 //-----------------------------------------------------------------------------
 // data
 //-----------------------------------------------------------------------------
 
 extern bool   g_blockEventsOnDrag;

+extern bool   g_blockEventsOnScroll;

 
 //-----------------------------------------------------------------------------
 
 //-----------------------------------------------------------------------------

-// wxListBox
+// "button_press_event"
+//-----------------------------------------------------------------------------
+
+static gint 
+gtk_listbox_button_press_callback( GtkWidget *widget, GdkEventButton *gdk_event, wxListBox *listbox )
+{
+    if (g_blockEventsOnDrag) return FALSE;
+    if (g_blockEventsOnScroll) return FALSE;
+
+    if (!listbox->HasVMT()) return FALSE;
+
+    int sel = listbox->GetIndex( widget );
+    
+    if ((listbox->m_hasCheckBoxes) && (gdk_event->x < 15) && (gdk_event->type != GDK_2BUTTON_PRESS))
+    {
+        wxCheckListBox *clb = (wxCheckListBox *)listbox;
+    
+        clb->Check( sel, !clb->IsChecked(sel) );
+    
+        wxCommandEvent event( wxEVT_COMMAND_CHECKLISTBOX_TOGGLED, listbox->GetId() );
+        event.SetEventObject( listbox );
+        event.SetInt( sel );
+        listbox->GetEventHandler()->ProcessEvent( event );
+    }
+    
+    if (gdk_event->type == GDK_2BUTTON_PRESS)
+    {
+        wxCommandEvent event( wxEVT_COMMAND_LISTBOX_DOUBLECLICKED, listbox->GetId() );
+        event.SetEventObject( listbox );
+       
+        wxArrayInt aSelections;
+        int count = listbox->GetSelections(aSelections);
+        if ( count > 0 )
+        {
+            event.m_commandInt = aSelections[0] ;
+            event.m_clientData = listbox->GetClientData( event.m_commandInt );
+            wxString str(listbox->GetString(event.m_commandInt));
+            if (str != "") event.m_commandString = copystring((char *)(const char *)str);
+        }
+        else
+        {
+            event.m_commandInt = -1 ;
+            event.m_commandString = copystring("") ;
+        }
+
+        listbox->GetEventHandler()->ProcessEvent( event );
+       
+        if (event.m_commandString) delete[] event.m_commandString ;
+    }
+
+    return FALSE;
+}
+
+//-----------------------------------------------------------------------------
+// "key_press_event"
+//-----------------------------------------------------------------------------
+
+static gint 
+gtk_listbox_key_press_callback( GtkWidget *widget, GdkEventKey *gdk_event, wxListBox *listbox )
+{
+    if (g_blockEventsOnDrag) return FALSE;
+
+    if (!listbox->HasVMT()) return FALSE;
+
+    if (gdk_event->keyval != ' ') return FALSE;
+    
+    int sel = listbox->GetIndex( widget );
+    
+    wxCheckListBox *clb = (wxCheckListBox *)listbox;
+    
+    clb->Check( sel, !clb->IsChecked(sel) );
+    
+    wxCommandEvent event( wxEVT_COMMAND_CHECKLISTBOX_TOGGLED, listbox->GetId() );
+    event.SetEventObject( listbox );
+    event.SetInt( sel );
+    listbox->GetEventHandler()->ProcessEvent( event );
+       
+    return FALSE;
+}
+
+//-----------------------------------------------------------------------------
+// "select" and "deselect"

 //-----------------------------------------------------------------------------
 
 static void gtk_listitem_select_callback( GtkWidget *WXUNUSED(widget), wxListBox *listbox )
 {
 //-----------------------------------------------------------------------------
 
 static void gtk_listitem_select_callback( GtkWidget *WXUNUSED(widget), wxListBox *listbox )
 {

-  if (!listbox->HasVMT()) return;
-  if (g_blockEventsOnDrag) return;
-  
-  wxCommandEvent event(wxEVT_COMMAND_LISTBOX_SELECTED, listbox->GetId() );
-  
+    if (!listbox->HasVMT()) return;
+    if (g_blockEventsOnDrag) return;
+
+    wxCommandEvent event(wxEVT_COMMAND_LISTBOX_SELECTED, listbox->GetId() );
+

     wxArrayInt aSelections;
     int count = listbox->GetSelections(aSelections);
     if ( count > 0 )
     {
     wxArrayInt aSelections;
     int count = listbox->GetSelections(aSelections);
     if ( count > 0 )
     {

-      event.m_commandInt = aSelections[0] ;
-      event.m_clientData = listbox->GetClientData(event.m_commandInt);
-      wxString str(listbox->GetString(event.m_commandInt));
-      if (str != "")
-        event.m_commandString = copystring((char *)(const char *)str);
+        event.m_commandInt = aSelections[0] ;
+        event.m_clientData = listbox->GetClientData( event.m_commandInt );
+        wxString str(listbox->GetString(event.m_commandInt));
+        if (str != "") event.m_commandString = copystring((char *)(const char *)str);

     }
     else
     {
     }
     else
     {

-      event.m_commandInt = -1 ;
-      event.m_commandString = copystring("") ;
+        event.m_commandInt = -1 ;
+        event.m_commandString = copystring("") ;

     }
 
     }
 

-  event.SetEventObject( listbox );
+    event.SetEventObject( listbox );

 
 

-  listbox->GetEventHandler()->ProcessEvent( event );
-  if (event.m_commandString) delete[] event.m_commandString ;
-};
+    listbox->GetEventHandler()->ProcessEvent( event );
+    if (event.m_commandString) delete[] event.m_commandString ;
+}

 
 

+//-----------------------------------------------------------------------------
+// wxListBox

 //-----------------------------------------------------------------------------
 
 IMPLEMENT_DYNAMIC_CLASS(wxListBox,wxControl)
 
 //-----------------------------------------------------------------------------
 
 IMPLEMENT_DYNAMIC_CLASS(wxListBox,wxControl)
 

-wxListBox::wxListBox(void)
+wxListBox::wxListBox()

 {
 {

-  m_list = NULL;
-};
-
-wxListBox::wxListBox( wxWindow *parent, wxWindowID id, 
-      const wxPoint &pos, const wxSize &size, 
-      int n, const wxString choices[],
-      long style, const wxString &name )
+    m_list = (GtkList *) NULL;
+    m_hasCheckBoxes = FALSE;
+}
+
+bool wxListBox::Create( wxWindow *parent, wxWindowID id,
+                        const wxPoint &pos, const wxSize &size,
+                        int n, const wxString choices[],
+                        long style, const wxValidator& validator, const wxString &name )

 {
 {

-  Create( parent, id, pos, size, n, choices, style, name );
-};
+    m_needParent = TRUE;
+    m_acceptsFocus = TRUE;

 
 

-bool wxListBox::Create( wxWindow *parent, wxWindowID id, 
-      const wxPoint &pos, const wxSize &size, 
-      int n, const wxString choices[],
-      long style, const wxString &name )
-{
-  m_needParent = TRUE;
-  
-  PreCreation( parent, id, pos, size, style, name );
-  
-  m_widget = gtk_scrolled_window_new( NULL, NULL );
-  gtk_scrolled_window_set_policy( GTK_SCROLLED_WINDOW(m_widget),
-    GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC );
-  
-  m_list = GTK_LIST( gtk_list_new() );
+    PreCreation( parent, id, pos, size, style, name );
+
+    SetValidator( validator );
+
+    m_widget = gtk_scrolled_window_new( (GtkAdjustment*) NULL, (GtkAdjustment*) NULL );
+    gtk_scrolled_window_set_policy( GTK_SCROLLED_WINDOW(m_widget),
+      GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC );
+      
+    m_list = GTK_LIST( gtk_list_new() );
+
+    GtkSelectionMode mode = GTK_SELECTION_BROWSE;
+    if (style & wxLB_MULTIPLE)
+        mode = GTK_SELECTION_MULTIPLE;
+    else if (style & wxLB_EXTENDED)
+        mode = GTK_SELECTION_EXTENDED;
+
+    gtk_list_set_selection_mode( GTK_LIST(m_list), mode );
+
+#ifdef NEW_GTK_SCROLL_CODE
+    gtk_scrolled_window_add_with_viewport( GTK_SCROLLED_WINDOW(m_widget), GTK_WIDGET(m_list) );
+#else
+    gtk_container_add( GTK_CONTAINER(m_widget), GTK_WIDGET(m_list) );
+#endif
+
+#ifdef __WXDEBUG__
+    debug_focus_in( m_widget, "wxListBox::m_widget", name );
+    
+    debug_focus_in( GTK_WIDGET(m_list), "wxListBox::m_list", name );
+
+    GtkScrolledWindow *s_window = GTK_SCROLLED_WINDOW(m_widget);
+
+    debug_focus_in( s_window->hscrollbar, "wxWindow::hsrcollbar", name );
+    debug_focus_in( s_window->vscrollbar, "wxWindow::vsrcollbar", name );
+
+#ifdef NEW_GTK_SCROLL_CODE
+    GtkViewport *viewport = GTK_VIEWPORT(s_window->child);
+#else
+    GtkViewport *viewport = GTK_VIEWPORT(s_window->viewport);
+#endif
+
+    debug_focus_in( GTK_WIDGET(viewport), "wxWindow::viewport", name );
+#endif
+
+    gtk_widget_show( GTK_WIDGET(m_list) );
+
+    wxSize newSize = size;
+    if (newSize.x == -1) newSize.x = 100;
+    if (newSize.y == -1) newSize.y = 110;
+    SetSize( newSize.x, newSize.y );
+
+    for (int i = 0; i < n; i++)
+    {
+        m_clientDataList.Append( (wxObject*) NULL );
+        m_clientObjectList.Append( (wxObject*) NULL );

   
   

-  // @@ what's the difference between BROWSE and SINGLE?
-  GtkSelectionMode mode = GTK_SELECTION_BROWSE;
-  if ( style & wxLB_MULTIPLE )
-    mode = GTK_SELECTION_MULTIPLE;
-  else if ( style & wxLB_EXTENDED )
-    mode = GTK_SELECTION_EXTENDED;
-
-  gtk_list_set_selection_mode( GTK_LIST(m_list), mode );
+        GtkWidget *list_item;
+       
+       if (m_hasCheckBoxes)
+       {
+            wxString str = "[-] ";
+           str += choices[i];
+            list_item = gtk_list_item_new_with_label( str );
+       }
+       else
+       {
+            list_item = gtk_list_item_new_with_label( choices[i] );
+       }
+
+#ifdef __WXDEBUG__
+        debug_focus_in( list_item, "wxListBox::list_item", name );
+#endif    
+    
+        gtk_container_add( GTK_CONTAINER(m_list), list_item );
+
+        gtk_signal_connect( GTK_OBJECT(list_item), "select",
+          GTK_SIGNAL_FUNC(gtk_listitem_select_callback), (gpointer)this );
+
+        if (style & wxLB_MULTIPLE)
+            gtk_signal_connect( GTK_OBJECT(list_item), "deselect",
+              GTK_SIGNAL_FUNC(gtk_listitem_select_callback), (gpointer)this );
+
+        gtk_signal_connect( GTK_OBJECT(list_item), 
+                           "button_press_event",
+                            (GtkSignalFunc)gtk_listbox_button_press_callback, 
+                           (gpointer) this );
+       
+       if (m_hasCheckBoxes)
+       {
+            gtk_signal_connect( GTK_OBJECT(list_item), 
+                           "key_press_event",
+                            (GtkSignalFunc)gtk_listbox_key_press_callback, 
+                           (gpointer)this );
+       }
+       
+        ConnectWidget( list_item );    
+       
+        gtk_widget_show( list_item );
+    }
+
+    m_parent->AddChild( this );
+
+    (m_parent->m_insertCallback)( m_parent, this );

   
   

-  gtk_container_add (GTK_CONTAINER(m_widget), GTK_WIDGET(m_list) );
-  gtk_widget_show( GTK_WIDGET(m_list) );
+    PostCreation();
+
+    gtk_widget_realize( GTK_WIDGET(m_list) );
+
+    SetBackgroundColour( parent->GetBackgroundColour() );
+    SetForegroundColour( parent->GetForegroundColour() );
+
+    Show( TRUE );
+
+    return TRUE;
+}
+
+wxListBox::~wxListBox()
+{
+    Clear();
+}
+
+void wxListBox::AppendCommon( const wxString &item )
+{
+    wxCHECK_RET( m_list != NULL, "invalid listbox" );

   
   

-  for (int i = 0; i < n; i++)
-  {

     GtkWidget *list_item;
     GtkWidget *list_item;

-    list_item = gtk_list_item_new_with_label( choices[i] ); 
-  
-    gtk_container_add( GTK_CONTAINER(m_list), list_item );

     
     

-    gtk_signal_connect( GTK_OBJECT(list_item), "select", 
+    if (m_hasCheckBoxes)
+    {
+        wxString str = "[-] ";
+       str += item;
+        list_item = gtk_list_item_new_with_label( str );
+    }
+    else
+    {
+        list_item = gtk_list_item_new_with_label( item );
+    }
+
+    gtk_signal_connect( GTK_OBJECT(list_item), "select",

       GTK_SIGNAL_FUNC(gtk_listitem_select_callback), (gpointer)this );
       GTK_SIGNAL_FUNC(gtk_listitem_select_callback), (gpointer)this );

+
+    if (GetWindowStyleFlag() & wxLB_MULTIPLE)
+        gtk_signal_connect( GTK_OBJECT(list_item), "deselect",
+          GTK_SIGNAL_FUNC(gtk_listitem_select_callback), (gpointer)this );
+
+    gtk_container_add( GTK_CONTAINER(m_list), list_item );
+
+    if (m_widgetStyle) ApplyWidgetStyle();

   
   

-    if ( style & wxLB_MULTIPLE )
-      gtk_signal_connect( GTK_OBJECT(list_item), "deselect", 
-        GTK_SIGNAL_FUNC(gtk_listitem_select_callback), (gpointer)this );
-  
-    m_clientData.Append( (wxObject*)NULL );
+    gtk_signal_connect( GTK_OBJECT(list_item), 
+                       "button_press_event",
+                        (GtkSignalFunc)gtk_listbox_button_press_callback, 
+                       (gpointer) this );

     
     

+    if (m_hasCheckBoxes)
+    {
+       gtk_signal_connect( GTK_OBJECT(list_item), 
+                       "key_press_event",
+                        (GtkSignalFunc)gtk_listbox_key_press_callback, 
+                       (gpointer)this );
+    }
+       

     gtk_widget_show( list_item );
     gtk_widget_show( list_item );

-  };
- 
-  PostCreation();
-  
-  gtk_widget_realize( GTK_WIDGET(m_list) );
+
+    ConnectWidget( list_item );
+
+#if wxUSE_DRAG_AND_DROP
+#ifndef NEW_GTK_DND_CODE
+    if (m_dropTarget) m_dropTarget->RegisterWidget( list_item );
+#endif
+#endif
+}
+
+void wxListBox::Append( const wxString &item )
+{
+    m_clientDataList.Append( (wxObject*) NULL );
+    m_clientObjectList.Append( (wxObject*) NULL );

   
   

-  Show( TRUE );
+    AppendCommon( item );
+}
+
+void wxListBox::Append( const wxString &item, void *clientData )
+{
+    m_clientDataList.Append( (wxObject*) clientData );
+    m_clientObjectList.Append( (wxObject*) NULL );

   
   

-  return TRUE;
-};
+    AppendCommon( item );
+}

 
 

-void wxListBox::Append( const wxString &item )
+void wxListBox::Append( const wxString &item, wxClientData *clientData )

 {
 {

-  Append( item, (char*)NULL );
-};
+    m_clientObjectList.Append( (wxObject*) clientData );
+    m_clientDataList.Append( (wxObject*) NULL );
+  
+    AppendCommon( item );
+}

 
 

-void wxListBox::Append( const wxString &item, char *clientData )
+void wxListBox::SetClientData( int n, void* clientData )

 {
 {

-  GtkWidget *list_item;
-  list_item = gtk_list_item_new_with_label( item ); 
+    wxCHECK_RET( m_widget != NULL, "invalid combobox" );

   
   

-  gtk_signal_connect( GTK_OBJECT(list_item), "select", 
-    GTK_SIGNAL_FUNC(gtk_listitem_select_callback), (gpointer)this );
+    wxNode *node = m_clientDataList.Nth( n );
+    if (!node) return;

   
   

-  if ( GetWindowStyleFlag() & wxLB_MULTIPLE )
-    gtk_signal_connect( GTK_OBJECT(list_item), "deselect", 
-      GTK_SIGNAL_FUNC(gtk_listitem_select_callback), (gpointer)this );
+    node->SetData( (wxObject*) clientData );
+}
+
+void* wxListBox::GetClientData( int n )
+{
+    wxCHECK_MSG( m_widget != NULL, NULL, "invalid combobox" );

   
   

-  gtk_container_add( GTK_CONTAINER(m_list), list_item );
+    wxNode *node = m_clientDataList.Nth( n );
+    if (!node) return NULL;
+    
+    return node->Data();
+}
+
+void wxListBox::SetClientObject( int n, wxClientData* clientData )
+{
+    wxCHECK_RET( m_widget != NULL, "invalid combobox" );
+    
+    wxNode *node = m_clientObjectList.Nth( n );
+    if (!node) return;

   
   

-  m_clientData.Append( (wxObject*)clientData );
+    wxClientData *cd = (wxClientData*) node->Data();
+    if (cd) delete cd;

   
   

-  gtk_widget_show( list_item );
-};
+    node->SetData( (wxObject*) clientData );
+}

 
 

-void wxListBox::Clear(void)
+wxClientData* wxListBox::GetClientObject( int n )

 {
 {

-  gtk_list_clear_items( m_list, 0, Number() );
+    wxCHECK_MSG( m_widget != NULL, (wxClientData*)NULL, "invalid combobox" );

   
   

-  m_clientData.Clear();
-};
+    wxNode *node = m_clientObjectList.Nth( n );
+    if (!node) return (wxClientData*) NULL;
+    
+    return (wxClientData*) node->Data();
+}
+
+void wxListBox::Clear()
+{
+    wxCHECK_RET( m_list != NULL, "invalid listbox" );
+
+    gtk_list_clear_items( m_list, 0, Number() );
+
+    wxNode *node = m_clientObjectList.First();
+    while (node)
+    {
+        wxClientData *cd = (wxClientData*)node->Data();
+        if (cd) delete cd;
+        node = node->Next();
+    }
+    m_clientObjectList.Clear();
+    
+    m_clientDataList.Clear();
+}

 
 void wxListBox::Delete( int n )
 {
 
 void wxListBox::Delete( int n )
 {

-  gtk_list_clear_items( m_list, n, n );
-  
-  wxNode *node = m_clientData.Nth( n );
-  if (!node)
-  {
-    wxFAIL_MSG("wxListBox::Delete wrong index");
-  }
-  else
-    m_clientData.DeleteNode( node );
-};
+    wxCHECK_RET( m_list != NULL, "invalid listbox" );
+
+    GList *child = g_list_nth( m_list->children, n );
+
+    wxCHECK_RET( child, "wrong listbox index" );
+
+    GList *list = g_list_append( (GList*) NULL, child->data );
+    gtk_list_remove_items( m_list, list );
+    g_list_free( list );
+
+    wxNode *node = m_clientObjectList.Nth( n );
+    if (node)
+    {
+        wxClientData *cd = (wxClientData*)node->Data();
+        if (cd) delete cd;
+        m_clientObjectList.DeleteNode( node );
+    }
+    
+    node = m_clientDataList.Nth( n );
+    if (node)
+    {
+        m_clientDataList.DeleteNode( node );
+    }
+}

 
 void wxListBox::Deselect( int n )
 {
 
 void wxListBox::Deselect( int n )
 {

-  gtk_list_unselect_item( m_list, n );
-};
+    wxCHECK_RET( m_list != NULL, "invalid listbox" );
+
+    gtk_list_unselect_item( m_list, n );
+}

 
 int wxListBox::FindString( const wxString &item ) const
 {
 
 int wxListBox::FindString( const wxString &item ) const
 {

-  GList *child = m_list->children;
-  int count = 0;
-  while (child)
-  {
-    GtkBin *bin = GTK_BIN( child->data );
-    GtkLabel *label = GTK_LABEL( bin->child );
-    if (item == label->label) return count;
-    count++;
-    child = child->next;
-  };
-  return -1;
-};
+    wxCHECK_MSG( m_list != NULL, -1, "invalid listbox" );
+  
+    GList *child = m_list->children;
+    int count = 0;
+    while (child)
+    {
+        GtkBin *bin = GTK_BIN( child->data );
+        GtkLabel *label = GTK_LABEL( bin->child );
+       
+       wxString str = label->label;
+       if (m_hasCheckBoxes) str.Remove( 0, 4 );
+       
+        if (str == item) return count;
+       
+        count++;
+        child = child->next;
+    }

 
 

-char *wxListBox::GetClientData( int n ) const
-{
-  wxNode *node = m_clientData.Nth( n );
-  if (node) return ((char*)node->Data());
-  return NULL;
-};
+  // it's not an error if the string is not found -> no wxCHECK

 
 

-int wxListBox::GetSelection(void) const
+  return -1;
+}
+
+int wxListBox::GetSelection() const

 {
 {

-  GList *selection = m_list->selection;
-  if (selection)
-  {
+    wxCHECK_MSG( m_list != NULL, -1, "invalid listbox" );
+  

     GList *child = m_list->children;
     int count = 0;
     while (child)
     {
     GList *child = m_list->children;
     int count = 0;
     while (child)
     {

-      if (child->data == selection->data) return count;
-      count++;
-      child = child->next;
-    };
-  };
-  return -1;
-};
+        if (GTK_WIDGET(child->data)->state == GTK_STATE_SELECTED) return count;
+        count++;
+        child = child->next;
+    }
+    return -1;
+}

 
 

-int wxListBox::GetSelections(wxArrayInt& aSelections) const
+int wxListBox::GetSelections( wxArrayInt& aSelections ) const

 {
 {

-  // get the number of selected items first
-  GList *child = m_list->children;
-  int count = 0;
-  for ( child = m_list->children; child != NULL; child = child->next ) {
-    if ( GTK_WIDGET(child->data)->state == GTK_STATE_SELECTED ) 
-      count++;
-  }
+    wxCHECK_MSG( m_list != NULL, -1, "invalid listbox" );
+  
+    // get the number of selected items first
+    GList *child = m_list->children;
+    int count = 0;
+    for (child = m_list->children; child != NULL; child = child->next)
+    {
+        if (GTK_WIDGET(child->data)->state == GTK_STATE_SELECTED)
+            count++;
+    }
+
+    aSelections.Empty();
+
+    if (count > 0) 
+    {
+        // now fill the list
+        aSelections.Alloc(count); // optimization attempt
+        int i = 0;
+        for (child = m_list->children; child != NULL; child = child->next, i++)
+        {
+            if (GTK_WIDGET(child->data)->state == GTK_STATE_SELECTED)
+                 aSelections.Add(i);
+        }
+    }

 
 

-  aSelections.Empty();
+    return count;
+}
+
+wxString wxListBox::GetString( int n ) const
+{
+    wxCHECK_MSG( m_list != NULL, "", "invalid listbox" );

   
   

-  if ( count > 0 ) {
-    // now fill the list
-    aSelections.Alloc(count); // optimization attempt
-    int i = 0;
-    for ( child = m_list->children; child != NULL; child = child->next, i++ ) {
-      if ( GTK_WIDGET(child->data)->state == GTK_STATE_SELECTED ) 
-        aSelections.Add(i);
+    GList *child = g_list_nth( m_list->children, n );
+    if (child)
+    {
+        GtkBin *bin = GTK_BIN( child->data );
+        GtkLabel *label = GTK_LABEL( bin->child );
+       
+       wxString str = label->label;
+       if (m_hasCheckBoxes) str.Remove( 0, 4 );
+       
+        return str;

     }
     }

-  }
+    wxFAIL_MSG("wrong listbox index");
+    return "";
+}
+
+wxString wxListBox::GetStringSelection() const
+{
+    wxCHECK_MSG( m_list != NULL, "", "invalid listbox" );

   
   

-  return count;
-};
+    GList *selection = m_list->selection;
+    if (selection)
+    {
+        GtkBin *bin = GTK_BIN( selection->data );
+        GtkLabel *label = GTK_LABEL( bin->child );
+       
+       wxString str = label->label;
+       if (m_hasCheckBoxes) str.Remove( 0, 4 );
+       
+        return str;
+    }
+    
+    wxFAIL_MSG("no listbox selection available");
+    return "";
+}

 
 

-wxString wxListBox::GetString( int n ) const
+int wxListBox::Number()

 {
 {

-  GList *child = g_list_nth( m_list->children, n );
-  if (child)
-  {
-    GtkBin *bin = GTK_BIN( child->data );
-    GtkLabel *label = GTK_LABEL( bin->child );
-    return label->label;
-  };
-  return "";
-};
-
-wxString wxListBox::GetStringSelection(void) const
-{
-  GList *selection = m_list->selection;
-  if (selection)
-  {
-    GtkBin *bin = GTK_BIN( selection->data );
-    wxString tmp = GTK_LABEL( bin->child )->label;
-    return tmp;
-  };
-  return "";
-};
-
-int wxListBox::Number(void)
-{
-  GList *child = m_list->children;
-  int count = 0;
-  while (child) { count++; child = child->next; };
-  return count;
-};
+    wxCHECK_MSG( m_list != NULL, -1, "invalid listbox" );
+  
+    GList *child = m_list->children;
+    int count = 0;
+    while (child) { count++; child = child->next; }
+    return count;
+}

 
 bool wxListBox::Selected( int n )
 {
 
 bool wxListBox::Selected( int n )
 {

-  GList *target = g_list_nth( m_list->children, n );
-  if (target)
-  {
-    GList *child = m_list->selection;
-    while (child)
+    wxCHECK_MSG( m_list != NULL, FALSE, "invalid listbox" );
+  
+    GList *target = g_list_nth( m_list->children, n );
+    if (target)

     {
     {

-      if (child->data == target->data) return TRUE;
-      child = child->next;
-    };
-  };
-  return FALSE;
-};
+        GList *child = m_list->selection;
+        while (child)
+        {
+            if (child->data == target->data) return TRUE;
+            child = child->next;
+        }
+    }
+    wxFAIL_MSG("wrong listbox index");
+    return FALSE;
+}

 
 void wxListBox::Set( int WXUNUSED(n), const wxString *WXUNUSED(choices) )
 {
 
 void wxListBox::Set( int WXUNUSED(n), const wxString *WXUNUSED(choices) )
 {

-};
-
-void wxListBox::SetClientData( int n, char *clientData )
-{
-  wxNode *node = m_clientData.Nth( n );
-  if (node) node->SetData( (wxObject*)clientData );
-};
+    wxFAIL_MSG("wxListBox::Set not implemented");
+}

 
 void wxListBox::SetFirstItem( int WXUNUSED(n) )
 {
 
 void wxListBox::SetFirstItem( int WXUNUSED(n) )
 {

-};
+    wxFAIL_MSG("wxListBox::SetFirstItem not implemented");
+}

 
 void wxListBox::SetFirstItem( const wxString &WXUNUSED(item) )
 {
 
 void wxListBox::SetFirstItem( const wxString &WXUNUSED(item) )
 {

-};
+    wxFAIL_MSG("wxListBox::SetFirstItem not implemented");
+}

 
 void wxListBox::SetSelection( int n, bool select )
 {
 
 void wxListBox::SetSelection( int n, bool select )
 {

-  if (select)
-    gtk_list_select_item( m_list, n );
-  else
-    gtk_list_unselect_item( m_list, n );
-};
+    wxCHECK_RET( m_list != NULL, "invalid listbox" );
+  
+    if (select)
+        gtk_list_select_item( m_list, n );
+    else
+        gtk_list_unselect_item( m_list, n );
+}

 
 void wxListBox::SetString( int n, const wxString &string )
 {
 
 void wxListBox::SetString( int n, const wxString &string )
 {

-  GList *child = g_list_nth( m_list->children, n );
-  if (child)
-  {
-    GtkBin *bin = GTK_BIN( child->data );
-    GtkLabel *label = GTK_LABEL( bin->child );
-    gtk_label_set( label, string );
-  };
-};
+    wxCHECK_RET( m_list != NULL, "invalid listbox" );
+  
+    GList *child = g_list_nth( m_list->children, n );
+    if (child)
+    {
+        GtkBin *bin = GTK_BIN( child->data );
+        GtkLabel *label = GTK_LABEL( bin->child );
+       
+       wxString str;
+       if (m_hasCheckBoxes) str += "[-] ";
+       str += string;
+       
+        gtk_label_set( label, str );
+    }
+    else
+    {
+        wxFAIL_MSG("wrong listbox index");
+    } 
+}

 
 void wxListBox::SetStringSelection( const wxString &string, bool select )
 {
 
 void wxListBox::SetStringSelection( const wxString &string, bool select )
 {

-  SetSelection( FindString(string), select );
-};
+    wxCHECK_RET( m_list != NULL, "invalid listbox" );
+  
+    SetSelection( FindString(string), select );
+}

 
 int wxListBox::GetIndex( GtkWidget *item ) const
 {
 
 int wxListBox::GetIndex( GtkWidget *item ) const
 {

-  if (item)
-  {
-    GList *child = m_list->children;
-    int count = 0;
-    while (child)
+    if (item)

     {
     {

-      if (GTK_WIDGET(child->data) == item) return count;
-      count++;
-      child = child->next;
-    };
-  };
-  return -1;
-};
+        GList *child = m_list->children;
+        int count = 0;
+        while (child)
+        {
+            if (GTK_WIDGET(child->data) == item) return count;
+            count++;
+            child = child->next;
+        }
+    }
+    return -1;
+}

 
 

-GtkWidget *wxListBox::GetDropTargetWidget(void)
+#if wxUSE_DRAG_AND_DROP
+void wxListBox::SetDropTarget( wxDropTarget *dropTarget )

 {
 {

-  return GTK_WIDGET(m_list);
-};
+    wxCHECK_RET( m_list != NULL, "invalid listbox" );
+  
+#ifndef NEW_GTK_DND_CODE
+    if (m_dropTarget)
+    {
+        GList *child = m_list->children;
+        while (child)
+        {
+           m_dropTarget->UnregisterWidget( GTK_WIDGET( child->data ) );
+            child = child->next;
+        }
+    }
+#endif
+    
+    wxWindow::SetDropTarget( dropTarget );
+
+#ifndef NEW_GTK_DND_CODE
+    if (m_dropTarget)
+    {
+        GList *child = m_list->children;
+        while (child)
+        {
+           m_dropTarget->RegisterWidget( GTK_WIDGET( child->data ) );
+            child = child->next;
+        }
+    }
+#endif
+}
+#endif
+
+GtkWidget *wxListBox::GetConnectWidget()
+{
+    return GTK_WIDGET(m_list);
+}
+
+bool wxListBox::IsOwnGtkWindow( GdkWindow *window )
+{
+    if (wxWindow::IsOwnGtkWindow( window )) return TRUE;

 
 

+    GList *child = m_list->children;
+    while (child)
+    {
+        GtkWidget *bin = GTK_WIDGET( child->data );
+        if (bin->window == window) return TRUE;
+        child = child->next;
+    }

 
 

+    return FALSE;
+}

 
 

+void wxListBox::ApplyWidgetStyle()
+{
+    SetWidgetStyle();
+  
+    if (m_backgroundColour.Ok())
+    {
+        GdkWindow *window = GTK_WIDGET(m_list)->window;
+        m_backgroundColour.CalcPixel( gdk_window_get_colormap( window ) );
+        gdk_window_set_background( window, m_backgroundColour.GetColor() );
+        gdk_window_clear( window );
+    }
+      
+    GList *child = m_list->children;
+    while (child)
+    {
+        gtk_widget_set_style( GTK_WIDGET(child->data), m_widgetStyle );
+       
+        GtkBin *bin = GTK_BIN( child->data );
+        GtkWidget *label = GTK_WIDGET( bin->child );
+        gtk_widget_set_style( label, m_widgetStyle );
+       
+        child = child->next;
+    }
+}