allow changing the page from keyboard in property sheet like controls even when the...

[wxWidgets.git] / src / common / combocmn.cpp

diff --git a/src/common/combocmn.cpp b/src/common/combocmn.cpp
index 3ae8b2c22da567b0f5314c9433c6b47f258b722e..b9792d8df82ce6f08038eb2aac335ff184e0af75 100644 (file)
--- a/src/common/combocmn.cpp
+++ b/src/common/combocmn.cpp
@@ -1,6 +1,6 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        combocmn.cpp
-// Purpose:     wxComboControlBase
+// Name:        src/common/combocmn.cpp
+// Purpose:     wxComboCtrlBase

 // Author:      Jaakko Salli
 // Modified by:
 // Created:     Apr-30-2006
 // Author:      Jaakko Salli
 // Modified by:
 // Created:     Apr-30-2006


@@ -23,20 +23,20 @@
     #pragma hdrstop
 #endif
 
     #pragma hdrstop
 #endif
 

-#if wxUSE_COMBOCONTROL
+#if wxUSE_COMBOCTRL
+
+#include "wx/combobox.h"

 
 #ifndef WX_PRECOMP
 
 #ifndef WX_PRECOMP

-    #include "wx/defs.h"

     #include "wx/log.h"
     #include "wx/log.h"

-    #include "wx/combobox.h"

     #include "wx/dcclient.h"
     #include "wx/settings.h"
     #include "wx/dialog.h"
     #include "wx/dcclient.h"
     #include "wx/settings.h"
     #include "wx/dialog.h"

+    #include "wx/timer.h"

 #endif
 
 #include "wx/dcbuffer.h"
 #include "wx/tooltip.h"
 #endif
 
 #include "wx/dcbuffer.h"
 #include "wx/tooltip.h"

-#include "wx/timer.h"

 
 #include "wx/combo.h"
 
 
 #include "wx/combo.h"
 


@@ -139,7 +139,7 @@
 class wxComboFrameEventHandler : public wxEvtHandler
 {
 public:
 class wxComboFrameEventHandler : public wxEvtHandler
 {
 public:

-    wxComboFrameEventHandler( wxComboControlBase* pCb );
+    wxComboFrameEventHandler( wxComboCtrlBase* pCb );

     ~wxComboFrameEventHandler();
 
     void OnPopup();
     ~wxComboFrameEventHandler();
 
     void OnPopup();


@@ -154,7 +154,7 @@ public:
 
 protected:
     wxWindow*                       m_focusStart;
 
 protected:
     wxWindow*                       m_focusStart;

-    wxComboControlBase*     m_combo;
+    wxComboCtrlBase*     m_combo;

 
 private:
     DECLARE_EVENT_TABLE()
 
 private:
     DECLARE_EVENT_TABLE()


@@ -172,7 +172,7 @@ BEGIN_EVENT_TABLE(wxComboFrameEventHandler, wxEvtHandler)
     EVT_CLOSE(wxComboFrameEventHandler::OnClose)
 END_EVENT_TABLE()
 
     EVT_CLOSE(wxComboFrameEventHandler::OnClose)
 END_EVENT_TABLE()
 

-wxComboFrameEventHandler::wxComboFrameEventHandler( wxComboControlBase* combo )
+wxComboFrameEventHandler::wxComboFrameEventHandler( wxComboCtrlBase* combo )

     : wxEvtHandler()
 {
     m_combo = combo;
     : wxEvtHandler()
 {
     m_combo = combo;


@@ -250,14 +250,14 @@ void wxComboFrameEventHandler::OnMove( wxMoveEvent& event )
 
 // ----------------------------------------------------------------------------
 // wxComboPopupWindow is wxPopupWindow customized for
 
 // ----------------------------------------------------------------------------
 // wxComboPopupWindow is wxPopupWindow customized for

-// wxComboControl.
+// wxComboCtrl.

 // ----------------------------------------------------------------------------
 
 class wxComboPopupWindow : public wxComboPopupWindowBase
 {
 public:
 
 // ----------------------------------------------------------------------------
 
 class wxComboPopupWindow : public wxComboPopupWindowBase
 {
 public:
 

-    wxComboPopupWindow( wxComboControlBase *parent, int style = wxBORDER_NONE );
+    wxComboPopupWindow( wxComboCtrlBase *parent, int style = wxBORDER_NONE );

 
 #if USE_TRANSIENT_POPUP
     virtual bool ProcessLeftDown(wxMouseEvent& event);
 
 #if USE_TRANSIENT_POPUP
     virtual bool ProcessLeftDown(wxMouseEvent& event);


@@ -291,7 +291,7 @@ BEGIN_EVENT_TABLE(wxComboPopupWindow, wxComboPopupWindowBase)
 END_EVENT_TABLE()
 
 
 END_EVENT_TABLE()
 
 

-wxComboPopupWindow::wxComboPopupWindow( wxComboControlBase *parent,
+wxComboPopupWindow::wxComboPopupWindow( wxComboCtrlBase *parent,

                                         int style )
 #if wxUSE_POPUPWIN
                                        : wxComboPopupWindowBase(parent,style)
                                         int style )
 #if wxUSE_POPUPWIN
                                        : wxComboPopupWindowBase(parent,style)


@@ -327,9 +327,9 @@ void wxComboPopupWindow::OnActivate( wxActivateEvent& event )
     if ( !event.GetActive() )
     {
         // Tell combo control that we are dismissed.
     if ( !event.GetActive() )
     {
         // Tell combo control that we are dismissed.

-        wxComboControl* combo = (wxComboControl*) GetParent();
+        wxComboCtrl* combo = (wxComboCtrl*) GetParent();

         wxASSERT( combo );
         wxASSERT( combo );

-        wxASSERT( combo->IsKindOf(CLASSINFO(wxComboControl)) );
+        wxASSERT( combo->IsKindOf(CLASSINFO(wxComboCtrl)) );

 
         combo->HidePopup();
 
 
         combo->HidePopup();
 


@@ -349,9 +349,9 @@ bool wxComboPopupWindow::ProcessLeftDown(wxMouseEvent& event )
 // First thing that happens when a transient popup closes is that this method gets called.
 void wxComboPopupWindow::OnDismiss()
 {
 // First thing that happens when a transient popup closes is that this method gets called.
 void wxComboPopupWindow::OnDismiss()
 {

-    wxComboControlBase* combo = (wxComboControlBase*) GetParent();
-    wxASSERT_MSG( combo->IsKindOf(CLASSINFO(wxComboControlBase)),
-                  wxT("parent might not be wxComboControl, but check IMPLEMENT_DYNAMIC_CLASS(2) macro for correctness") );
+    wxComboCtrlBase* combo = (wxComboCtrlBase*) GetParent();
+    wxASSERT_MSG( combo->IsKindOf(CLASSINFO(wxComboCtrlBase)),
+                  wxT("parent might not be wxComboCtrl, but check IMPLEMENT_DYNAMIC_CLASS(2) macro for correctness") );

 
     combo->OnPopupDismiss();
 }
 
     combo->OnPopupDismiss();
 }


@@ -381,18 +381,24 @@ wxSize wxComboPopup::GetAdjustedSize( int minWidth,
     return wxSize(minWidth,prefHeight);
 }
 
     return wxSize(minWidth,prefHeight);
 }
 

-void wxComboPopup::PaintComboControl( wxDC& dc, const wxRect& rect )
+void wxComboPopup::DefaultPaintComboControl( wxComboCtrlBase* combo,
+                                             wxDC& dc, const wxRect& rect )

 {
 {

-    if ( m_combo->GetWindowStyle() & wxCB_READONLY ) // ie. no textctrl
+    if ( combo->GetWindowStyle() & wxCB_READONLY ) // ie. no textctrl

     {
     {

-        m_combo->DrawFocusBackground(dc,rect,0);
+        combo->DrawFocusBackground(dc,rect,0);

 
 

-        dc.DrawText( GetStringValue(),
-                     rect.x + m_combo->GetTextIndent(),
-                     (rect.height-dc.GetCharHeight())/2 + m_combo->m_widthCustomBorder );
+        dc.DrawText( combo->GetValue(),
+                     rect.x + combo->GetTextIndent(),
+                     (rect.height-dc.GetCharHeight())/2 + rect.y );

     }
 }
 
     }
 }
 

+void wxComboPopup::PaintComboControl( wxDC& dc, const wxRect& rect )
+{
+    DefaultPaintComboControl(m_combo,dc,rect);
+}
+

 void wxComboPopup::OnComboKeyEvent( wxKeyEvent& event )
 {
     event.Skip();
 void wxComboPopup::OnComboKeyEvent( wxKeyEvent& event )
 {
     event.Skip();


@@ -428,7 +434,7 @@ class wxComboBoxExtraInputHandler : public wxEvtHandler
 {
 public:
 
 {
 public:
 

-    wxComboBoxExtraInputHandler( wxComboControlBase* combo )
+    wxComboBoxExtraInputHandler( wxComboCtrlBase* combo )

         : wxEvtHandler()
     {
         m_combo = combo;
         : wxEvtHandler()
     {
         m_combo = combo;


@@ -438,7 +444,7 @@ public:
     void OnFocus(wxFocusEvent& event);
 
 protected:
     void OnFocus(wxFocusEvent& event);
 
 protected:

-    wxComboControlBase*   m_combo;
+    wxComboCtrlBase*   m_combo;

 
 private:
     DECLARE_EVENT_TABLE()
 
 private:
     DECLARE_EVENT_TABLE()


@@ -455,7 +461,7 @@ void wxComboBoxExtraInputHandler::OnKey(wxKeyEvent& event)
 {
     int keycode = event.GetKeyCode();
 
 {
     int keycode = event.GetKeyCode();
 

-    if ( keycode == WXK_TAB )
+    if ( keycode == WXK_TAB && !m_combo->IsPopupShown() )

     {
         wxNavigationKeyEvent evt;
         evt.SetFlags(wxNavigationKeyEvent::FromTab|
     {
         wxNavigationKeyEvent evt;
         evt.SetFlags(wxNavigationKeyEvent::FromTab|


@@ -469,12 +475,12 @@ void wxComboBoxExtraInputHandler::OnKey(wxKeyEvent& event)
     if ( m_combo->IsPopupShown() )
     {
         // pass it to the popped up control
     if ( m_combo->IsPopupShown() )
     {
         // pass it to the popped up control

-        m_combo->GetPopupControl()->AddPendingEvent(event);
+        m_combo->GetPopupControl()->GetControl()->AddPendingEvent(event);

     }
     else // no popup
     {
         int comboStyle = m_combo->GetWindowStyle();
     }
     else // no popup
     {
         int comboStyle = m_combo->GetWindowStyle();

-        wxComboPopup* popupInterface = m_combo->GetPopup();
+        wxComboPopup* popupInterface = m_combo->GetPopupControl();

 
         if ( !popupInterface )
         {
 
         if ( !popupInterface )
         {


@@ -486,24 +492,13 @@ void wxComboBoxExtraInputHandler::OnKey(wxKeyEvent& event)
              ( keycode != WXK_RIGHT && keycode != WXK_LEFT )
             )
         {
              ( keycode != WXK_RIGHT && keycode != WXK_LEFT )
             )
         {

-            // Alternate keys: UP and DOWN show the popup instead of cycling
-            if ( (comboStyle & wxCC_ALT_KEYS) )
-            {
-                if ( keycode == WXK_UP || keycode == WXK_DOWN )
-                {
-                    m_combo->OnButtonClick();
-                    return;
-                }
-            }
-            else
-                popupInterface->OnComboKeyEvent(event);
+            popupInterface->OnComboKeyEvent(event);

         }
         else
             event.Skip();
     }
 }
 
         }
         else
             event.Skip();
     }
 }
 

-

 void wxComboBoxExtraInputHandler::OnFocus(wxFocusEvent& event)
 {
     // FIXME: This code does run when control is clicked,
 void wxComboBoxExtraInputHandler::OnFocus(wxFocusEvent& event)
 {
     // FIXME: This code does run when control is clicked,


@@ -516,6 +511,18 @@ void wxComboBoxExtraInputHandler::OnFocus(wxFocusEvent& event)
             m_combo->SetSelection(-1,-1);
     }
 
             m_combo->SetSelection(-1,-1);
     }
 

+    if ( event.GetId() != m_combo->GetId() )
+    {
+        // Add textctrl set focus events as combo set focus events
+        // NOTE: Simply changing the event and skipping didn't seem
+        // to do the trick.
+        wxFocusEvent evt2(wxEVT_SET_FOCUS,m_combo->GetId());
+        evt2.SetEventObject(m_combo);
+        m_combo->GetEventHandler()->ProcessEvent(evt2);
+    }
+    else
+        event.Skip();
+

     event.Skip();
 }
 
     event.Skip();
 }
 


@@ -528,7 +535,7 @@ class wxComboPopupExtraEventHandler : public wxEvtHandler
 {
 public:
 
 {
 public:
 

-    wxComboPopupExtraEventHandler( wxComboControlBase* combo )
+    wxComboPopupExtraEventHandler( wxComboCtrlBase* combo )

         : wxEvtHandler()
     {
         m_combo = combo;
         : wxEvtHandler()
     {
         m_combo = combo;


@@ -538,16 +545,16 @@ public:
 
     void OnMouseEvent( wxMouseEvent& event );
 
 
     void OnMouseEvent( wxMouseEvent& event );
 

-    // Called from wxPGComboControlBase::OnPopupDismiss
+    // Called from wxComboCtrlBase::OnPopupDismiss

     void OnPopupDismiss()
     {
         m_beenInside = false;
     }
 
 protected:
     void OnPopupDismiss()
     {
         m_beenInside = false;
     }
 
 protected:

-    wxComboControlBase*     m_combo;
+    wxComboCtrlBase*     m_combo;

 
 

-    bool                            m_beenInside;
+    bool                    m_beenInside;

 
 private:
     DECLARE_EVENT_TABLE()
 
 private:
     DECLARE_EVENT_TABLE()


@@ -562,7 +569,7 @@ END_EVENT_TABLE()
 void wxComboPopupExtraEventHandler::OnMouseEvent( wxMouseEvent& event )
 {
     wxPoint pt = event.GetPosition();
 void wxComboPopupExtraEventHandler::OnMouseEvent( wxMouseEvent& event )
 {
     wxPoint pt = event.GetPosition();

-    wxSize sz = m_combo->GetPopupControl()->GetClientSize();
+    wxSize sz = m_combo->GetPopupControl()->GetControl()->GetClientSize();

     int evtType = event.GetEventType();
     bool isInside = pt.x >= 0 && pt.y >= 0 && pt.x < sz.x && pt.y < sz.y;
 
     int evtType = event.GetEventType();
     bool isInside = pt.x >= 0 && pt.y >= 0 && pt.x < sz.x && pt.y < sz.y;
 


@@ -616,27 +623,27 @@ void wxComboPopupExtraEventHandler::OnMouseEvent( wxMouseEvent& event )
 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------

-// wxComboControlBase
+// wxComboCtrlBase

 // ----------------------------------------------------------------------------
 
 
 // ----------------------------------------------------------------------------
 
 

-BEGIN_EVENT_TABLE(wxComboControlBase, wxControl)
-    EVT_TEXT(wxID_ANY,wxComboControlBase::OnTextCtrlEvent)
-    EVT_SIZE(wxComboControlBase::OnSizeEvent)
-    EVT_SET_FOCUS(wxComboControlBase::OnFocusEvent)
-    EVT_KILL_FOCUS(wxComboControlBase::OnFocusEvent)
-    //EVT_BUTTON(wxID_ANY,wxComboControlBase::OnButtonClickEvent)
-    EVT_TEXT_ENTER(wxID_ANY,wxComboControlBase::OnTextCtrlEvent)
-    EVT_SYS_COLOUR_CHANGED(wxComboControlBase::OnSysColourChanged)
+BEGIN_EVENT_TABLE(wxComboCtrlBase, wxControl)
+    EVT_TEXT(wxID_ANY,wxComboCtrlBase::OnTextCtrlEvent)
+    EVT_SIZE(wxComboCtrlBase::OnSizeEvent)
+    EVT_SET_FOCUS(wxComboCtrlBase::OnFocusEvent)
+    EVT_KILL_FOCUS(wxComboCtrlBase::OnFocusEvent)
+    //EVT_BUTTON(wxID_ANY,wxComboCtrlBase::OnButtonClickEvent)
+    EVT_TEXT_ENTER(wxID_ANY,wxComboCtrlBase::OnTextCtrlEvent)
+    EVT_SYS_COLOUR_CHANGED(wxComboCtrlBase::OnSysColourChanged)

 END_EVENT_TABLE()
 
 
 END_EVENT_TABLE()
 
 

-IMPLEMENT_ABSTRACT_CLASS(wxComboControlBase, wxControl)
+IMPLEMENT_ABSTRACT_CLASS(wxComboCtrlBase, wxControl)

 
 // Have global double buffer - should be enough for multiple combos
 static wxBitmap* gs_doubleBuffer = (wxBitmap*) NULL;
 
 
 // Have global double buffer - should be enough for multiple combos
 static wxBitmap* gs_doubleBuffer = (wxBitmap*) NULL;
 

-void wxComboControlBase::Init()
+void wxComboCtrlBase::Init()

 {
     m_winPopup = (wxWindow *)NULL;
     m_popup = (wxWindow *)NULL;
 {
     m_winPopup = (wxWindow *)NULL;
     m_popup = (wxWindow *)NULL;


@@ -662,7 +669,7 @@ void wxComboControlBase::Init()
     m_btnState = 0;
     m_btnWidDefault = 0;
     m_blankButtonBg = false;
     m_btnState = 0;
     m_btnWidDefault = 0;
     m_blankButtonBg = false;

-    m_btnWid = m_btnHei = 0;
+    m_btnWid = m_btnHei = -1;

     m_btnSide = wxRIGHT;
     m_btnSpacingX = 0;
 
     m_btnSide = wxRIGHT;
     m_btnSpacingX = 0;
 


@@ -674,14 +681,14 @@ void wxComboControlBase::Init()
     m_timeCanAcceptClick = 0;
 }
 
     m_timeCanAcceptClick = 0;
 }
 

-bool wxComboControlBase::Create(wxWindow *parent,
-                                wxWindowID id,
-                                const wxString& value,
-                                const wxPoint& pos,
-                                const wxSize& size,
-                                long style,
-                                const wxValidator& validator,
-                                const wxString& name)
+bool wxComboCtrlBase::Create(wxWindow *parent,
+                             wxWindowID id,
+                             const wxString& value,
+                             const wxPoint& pos,
+                             const wxSize& size,
+                             long style,
+                             const wxValidator& validator,
+                             const wxString& name)

 {
     if ( !wxControl::Create(parent,
                             id,
 {
     if ( !wxControl::Create(parent,
                             id,


@@ -698,10 +705,20 @@ bool wxComboControlBase::Create(wxWindow *parent,
     OnThemeChange();
     m_absIndent = GetNativeTextIndent();
 
     OnThemeChange();
     m_absIndent = GetNativeTextIndent();
 

+    m_iFlags |= wxCC_IFLAG_CREATED;
+
+    // If x and y indicate valid size, wxSizeEvent won't be
+    // emitted automatically, so we need to add artifical one.
+    if ( size.x > 0 && size.y > 0 )
+    {
+        wxSizeEvent evt(size,GetId());
+        GetEventHandler()->AddPendingEvent(evt);
+    }
+

     return true;
 }
 
     return true;
 }
 

-void wxComboControlBase::InstallInputHandlers( bool alsoTextCtrl )
+void wxComboCtrlBase::InstallInputHandlers( bool alsoTextCtrl )

 {
     if ( m_text && alsoTextCtrl )
     {
 {
     if ( m_text && alsoTextCtrl )
     {


@@ -714,35 +731,35 @@ void wxComboControlBase::InstallInputHandlers( bool alsoTextCtrl )
     m_extraEvtHandler = inputHandler;
 }
 
     m_extraEvtHandler = inputHandler;
 }
 

-void wxComboControlBase::CreateTextCtrl( int extraStyle, const wxValidator& validator )
+void
+wxComboCtrlBase::CreateTextCtrl(int style, const wxValidator& validator)

 {
     if ( !(m_windowStyle & wxCB_READONLY) )
     {
 {
     if ( !(m_windowStyle & wxCB_READONLY) )
     {

-        m_text = new wxTextCtrl(this,
-                                12345,
-                                m_valueString,
-                                wxDefaultPosition,
-                                wxDefaultSize,
-                                // wxTE_PROCESS_TAB is needed because on Windows, wxTAB_TRAVERSAL is
-                                // not used by the wxPropertyGrid and therefore the tab is
-                                // processed by looking at ancestors to see if they have
-                                // wxTAB_TRAVERSAL. The navigation event is then sent to
-                                // the wrong window.
-                                wxTE_PROCESS_TAB |
-                                extraStyle,
-                                validator);
+        // wxTE_PROCESS_TAB is needed because on Windows, wxTAB_TRAVERSAL is
+        // not used by the wxPropertyGrid and therefore the tab is processed by
+        // looking at ancestors to see if they have wxTAB_TRAVERSAL. The
+        // navigation event is then sent to the wrong window.
+        style |= wxTE_PROCESS_TAB;
+
+        if ( HasFlag(wxTE_PROCESS_ENTER) )
+            style |= wxTE_PROCESS_ENTER;
+
+        m_text = new wxTextCtrl(this, wxID_ANY, m_valueString,
+                                wxDefaultPosition, wxDefaultSize,
+                                style, validator);

 
         // This is required for some platforms (GTK+ atleast)
         m_text->SetSizeHints(2,4);
     }
 }
 
 
         // This is required for some platforms (GTK+ atleast)
         m_text->SetSizeHints(2,4);
     }
 }
 

-void wxComboControlBase::OnThemeChange()
+void wxComboCtrlBase::OnThemeChange()

 {
     SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOW));
 }
 
 {
     SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOW));
 }
 

-wxComboControlBase::~wxComboControlBase()
+wxComboCtrlBase::~wxComboCtrlBase()

 {
     if ( HasCapture() )
         ReleaseMouse();
 {
     if ( HasCapture() )
         ReleaseMouse();


@@ -755,15 +772,7 @@ wxComboControlBase::~wxComboControlBase()
     m_toplevEvtHandler = (wxEvtHandler*) NULL;
 #endif
 
     m_toplevEvtHandler = (wxEvtHandler*) NULL;
 #endif
 

-    if ( m_popup )
-        m_popup->RemoveEventHandler(m_popupExtraHandler);
-
-    delete m_popupExtraHandler;
-
-    HidePopup();
-
-    delete m_popupInterface;
-    delete m_winPopup;
+    DestroyPopup();

 
     RemoveEventHandler(m_extraEvtHandler);
 
 
     RemoveEventHandler(m_extraEvtHandler);
 


@@ -780,24 +789,25 @@ wxComboControlBase::~wxComboControlBase()
 // ----------------------------------------------------------------------------
 
 // Recalculates button and textctrl areas
 // ----------------------------------------------------------------------------
 
 // Recalculates button and textctrl areas

-void wxComboControlBase::CalculateAreas( int btnWidth )
+void wxComboCtrlBase::CalculateAreas( int btnWidth )

 {
     wxSize sz = GetClientSize();
     int customBorder = m_widthCustomBorder;
 {
     wxSize sz = GetClientSize();
     int customBorder = m_widthCustomBorder;

-    bool buttonOutside;

     int btnBorder; // border for button only
 
     int btnBorder; // border for button only
 

-    if ( ( (m_iFlags & wxCC_BUTTON_OUTSIDE_BORDER) || m_blankButtonBg ) &&
-         m_btnSpacingX == 0 && m_btnWid == 0 && m_btnHei == 0 &&
-         (!m_bmpNormal.Ok() || m_blankButtonBg) )
+    // check if button should really be outside the border: we'll do it it if
+    // its platform default or bitmap+pushbutton background is used, but not if
+    // there is vertical size adjustment or horizontal spacing.
+    if ( ( (m_iFlags & wxCC_BUTTON_OUTSIDE_BORDER) ||
+                (m_bmpNormal.Ok() && m_blankButtonBg) ) &&
+         m_btnSpacingX == 0 &&
+         m_btnHei <= 0 )

     {
     {

-        buttonOutside = true;

         m_iFlags |= wxCC_IFLAG_BUTTON_OUTSIDE;
         btnBorder = 0;
     }
     else
     {
         m_iFlags |= wxCC_IFLAG_BUTTON_OUTSIDE;
         btnBorder = 0;
     }
     else
     {

-        buttonOutside = false;

         m_iFlags &= ~(wxCC_IFLAG_BUTTON_OUTSIDE);
         btnBorder = customBorder;
     }
         m_iFlags &= ~(wxCC_IFLAG_BUTTON_OUTSIDE);
         btnBorder = customBorder;
     }


@@ -816,20 +826,32 @@ void wxComboControlBase::CalculateAreas( int btnWidth )
     if ( butWidth <= 0 )
         return;
 
     if ( butWidth <= 0 )
         return;
 

+    int butHeight = sz.y - btnBorder*2;
+

     // Adjust button width
     // Adjust button width

-    if ( m_btnWid < 0 )
-        butWidth += m_btnWid;
-    else if ( m_btnWid > 0 )
+    if ( m_btnWid > 0 )

         butWidth = m_btnWid;
         butWidth = m_btnWid;

+    else
+    {
+        // Adjust button width to match aspect ratio
+        // (but only if control is smaller than best size).
+        int bestHeight = GetBestSize().y;
+        int height = GetSize().y;

 
 

-    int butHeight = sz.y;
-
-    butHeight -= btnBorder*2;
+        if ( height < bestHeight )
+        {
+            // Make very small buttons square, as it makes
+            // them accommodate arrow image better and still
+            // looks decent.
+            if ( height > 18 )
+                butWidth = (height*butWidth)/bestHeight;
+            else
+                butWidth = butHeight;
+        }
+    }

 
     // Adjust button height
 
     // Adjust button height

-    if ( m_btnHei < 0 )
-        butHeight += m_btnHei;
-    else if ( m_btnHei > 0 )
+    if ( m_btnHei > 0 )

         butHeight = m_btnHei;
 
     // Use size of normal bitmap if...
         butHeight = m_btnHei;
 
     // Use size of normal bitmap if...


@@ -857,7 +879,7 @@ void wxComboControlBase::CalculateAreas( int btnWidth )
         if ( (sz.y-(customBorder*2)) < butHeight && btnWidth == 0 )
         {
             int newY = butHeight+(customBorder*2);
         if ( (sz.y-(customBorder*2)) < butHeight && btnWidth == 0 )
         {
             int newY = butHeight+(customBorder*2);

-            SetClientSize(-1,newY);
+            SetClientSize(wxDefaultCoord,newY);

             sz.y = newY;
         }
     }
             sz.y = newY;
         }
     }


@@ -886,7 +908,7 @@ void wxComboControlBase::CalculateAreas( int btnWidth )
 */
 }
 
 */
 }
 

-void wxComboControlBase::PositionTextCtrl( int textCtrlXAdjust, int textCtrlYAdjust )
+void wxComboCtrlBase::PositionTextCtrl( int textCtrlXAdjust, int textCtrlYAdjust )

 {
     if ( !m_text )
         return;
 {
     if ( !m_text )
         return;


@@ -928,7 +950,7 @@ void wxComboControlBase::PositionTextCtrl( int textCtrlXAdjust, int textCtrlYAdj
     }
 }
 
     }
 }
 

-wxSize wxComboControlBase::DoGetBestSize() const
+wxSize wxComboCtrlBase::DoGetBestSize() const

 {
     wxSize sizeText(150,0);
 
 {
     wxSize sizeText(150,0);
 


@@ -975,20 +997,12 @@ wxSize wxComboControlBase::DoGetBestSize() const
     return ret;
 }
 
     return ret;
 }
 

-void wxComboControlBase::DoMoveWindow(int x, int y, int width, int height)
-{
-    // SetSize is called last in create, so it marks the end of creation
-    m_iFlags |= wxCC_IFLAG_CREATED;
-
-    wxControl::DoMoveWindow(x, y, width, height);
-}
-
-void wxComboControlBase::OnSizeEvent( wxSizeEvent& event )
+void wxComboCtrlBase::OnSizeEvent( wxSizeEvent& event )

 {
     if ( !IsCreated() )
         return;
 
 {
     if ( !IsCreated() )
         return;
 

-    // defined by actual wxComboControls
+    // defined by actual wxComboCtrls

     OnResize();
 
     event.Skip();
     OnResize();
 
     event.Skip();


@@ -998,7 +1012,7 @@ void wxComboControlBase::OnSizeEvent( wxSizeEvent& event )
 // standard operations
 // ----------------------------------------------------------------------------
 
 // standard operations
 // ----------------------------------------------------------------------------
 

-bool wxComboControlBase::Enable(bool enable)
+bool wxComboCtrlBase::Enable(bool enable)

 {
     if ( !wxControl::Enable(enable) )
         return false;
 {
     if ( !wxControl::Enable(enable) )
         return false;


@@ -1011,7 +1025,7 @@ bool wxComboControlBase::Enable(bool enable)
     return true;
 }
 
     return true;
 }
 

-bool wxComboControlBase::Show(bool show)
+bool wxComboCtrlBase::Show(bool show)

 {
     if ( !wxControl::Show(show) )
         return false;
 {
     if ( !wxControl::Show(show) )
         return false;


@@ -1025,7 +1039,7 @@ bool wxComboControlBase::Show(bool show)
     return true;
 }
 
     return true;
 }
 

-bool wxComboControlBase::SetFont ( const wxFont& font )
+bool wxComboCtrlBase::SetFont ( const wxFont& font )

 {
     if ( !wxControl::SetFont(font) )
         return false;
 {
     if ( !wxControl::SetFont(font) )
         return false;


@@ -1037,7 +1051,7 @@ bool wxComboControlBase::SetFont ( const wxFont& font )
 }
 
 #if wxUSE_TOOLTIPS
 }
 
 #if wxUSE_TOOLTIPS

-void wxComboControlBase::DoSetToolTip(wxToolTip *tooltip)
+void wxComboCtrlBase::DoSetToolTip(wxToolTip *tooltip)

 {
     wxControl::DoSetToolTip(tooltip);
 
 {
     wxControl::DoSetToolTip(tooltip);
 


@@ -1061,7 +1075,7 @@ void wxComboControlBase::DoSetToolTip(wxToolTip *tooltip)
 // ----------------------------------------------------------------------------
 
 // draw focus background on area in a way typical on platform
 // ----------------------------------------------------------------------------
 
 // draw focus background on area in a way typical on platform

-void wxComboControlBase::DrawFocusBackground( wxDC& dc, const wxRect& rect, int flags )
+void wxComboCtrlBase::DrawFocusBackground( wxDC& dc, const wxRect& rect, int flags ) const

 {
     wxSize sz = GetClientSize();
     bool isEnabled;
 {
     wxSize sz = GetClientSize();
     bool isEnabled;


@@ -1095,8 +1109,14 @@ void wxComboControlBase::DrawFocusBackground( wxDC& dc, const wxRect& rect, int
     wxRect selRect(rect);
     selRect.y += focusSpacingY;
     selRect.height -= (focusSpacingY*2);
     wxRect selRect(rect);
     selRect.y += focusSpacingY;
     selRect.height -= (focusSpacingY*2);

-    selRect.x += m_widthCustomPaint + focusSpacingX;
-    selRect.width -= m_widthCustomPaint + (focusSpacingX*2);
+
+    int wcp = 0;
+
+    if ( !(flags & wxCONTROL_ISSUBMENU) )
+        wcp += m_widthCustomPaint;
+
+    selRect.x += wcp + focusSpacingX;
+    selRect.width -= wcp + (focusSpacingX*2);

 
     wxColour bgCol;
 
 
     wxColour bgCol;
 


@@ -1126,7 +1146,7 @@ void wxComboControlBase::DrawFocusBackground( wxDC& dc, const wxRect& rect, int
     dc.DrawRectangle( selRect );
 }
 
     dc.DrawRectangle( selRect );
 }
 

-void wxComboControlBase::DrawButton( wxDC& dc, const wxRect& rect, bool paintBg )
+void wxComboCtrlBase::DrawButton( wxDC& dc, const wxRect& rect, bool paintBg )

 {
     int drawState = m_btnState;
 
 {
     int drawState = m_btnState;
 


@@ -1154,9 +1174,19 @@ void wxComboControlBase::DrawButton( wxDC& dc, const wxRect& rect, bool paintBg
     if ( !m_bmpNormal.Ok() )
     {
         // Need to clear button background even if m_btn is present
     if ( !m_bmpNormal.Ok() )
     {
         // Need to clear button background even if m_btn is present

-        // (assume non-button background was cleared just before this call so brushes are good)

         if ( paintBg )
         if ( paintBg )

+        {
+            wxColour bgCol;
+
+            if ( m_iFlags & wxCC_IFLAG_BUTTON_OUTSIDE )
+                bgCol = GetParent()->GetBackgroundColour();
+            else
+                bgCol = GetBackgroundColour();
+
+            dc.SetBrush(bgCol);
+            dc.SetPen(bgCol);

             dc.DrawRectangle(rect);
             dc.DrawRectangle(rect);

+        }

 
         // Draw standard button
         wxRendererNative::Get().DrawComboBoxDropButton(this,
 
         // Draw standard button
         wxRendererNative::Get().DrawComboBoxDropButton(this,


@@ -1215,7 +1245,7 @@ void wxComboControlBase::DrawButton( wxDC& dc, const wxRect& rect, bool paintBg
     }
 }
 
     }
 }
 

-void wxComboControlBase::RecalcAndRefresh()
+void wxComboCtrlBase::RecalcAndRefresh()

 {
     if ( IsCreated() )
     {
 {
     if ( IsCreated() )
     {


@@ -1225,7 +1255,7 @@ void wxComboControlBase::RecalcAndRefresh()
     }
 }
 
     }
 }
 

-wxBitmap& wxComboControlBase::GetBufferBitmap( const wxSize& sz ) const
+wxBitmap& wxComboCtrlBase::GetBufferBitmap( const wxSize& sz ) const

 {
     // If size is larger, recalculate double buffer bitmap
     if ( !gs_doubleBuffer ||
 {
     // If size is larger, recalculate double buffer bitmap
     if ( !gs_doubleBuffer ||


@@ -1238,38 +1268,22 @@ wxBitmap& wxComboControlBase::GetBufferBitmap( const wxSize& sz ) const
     return *gs_doubleBuffer;
 }
 
     return *gs_doubleBuffer;
 }
 

-
-bool wxComboControlBase::OnDrawListItem( wxDC& WXUNUSED(dc),
-                                         const wxRect& WXUNUSED(rect),
-                                         int WXUNUSED(item),
-                                         int WXUNUSED(flags) )
-{
-    return false; // signals caller to make default drawing
-}
-
-wxCoord wxComboControlBase::OnMeasureListItem( int WXUNUSED(item) )
-{
-    return -1; // signals caller to use default
-}
-
-wxCoord wxComboControlBase::OnMeasureListItemWidth( int WXUNUSED(item) )
-{
-    return -1; // signals caller to use default
-}
-

 // ----------------------------------------------------------------------------
 // miscellaneous event handlers
 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------
 // miscellaneous event handlers
 // ----------------------------------------------------------------------------
 

-void wxComboControlBase::OnTextCtrlEvent(wxCommandEvent& event)
+void wxComboCtrlBase::OnTextCtrlEvent(wxCommandEvent& event)

 {
 {

-    // Change event id and relay it forward
+    // Change event id, object and string before relaying it forward

     event.SetId(GetId());
     event.SetId(GetId());

+    wxString s = event.GetString();
+    event.SetEventObject(this);
+    event.SetString(s);

     event.Skip();
 }
 
 // call if cursor is on button area or mouse is captured for the button
     event.Skip();
 }
 
 // call if cursor is on button area or mouse is captured for the button

-bool wxComboControlBase::HandleButtonMouseEvent( wxMouseEvent& event,
+bool wxComboCtrlBase::HandleButtonMouseEvent( wxMouseEvent& event,

                                                  int flags )
 {
     int type = event.GetEventType();
                                                  int flags )
 {
     int type = event.GetEventType();


@@ -1359,8 +1373,8 @@ bool wxComboControlBase::HandleButtonMouseEvent( wxMouseEvent& event,
 
 // Conversion to double-clicks and some basic filtering
 // returns true if event was consumed or filtered
 
 // Conversion to double-clicks and some basic filtering
 // returns true if event was consumed or filtered

-//bool wxComboControlBase::PreprocessMouseEvent( wxMouseEvent& event, bool isOnButtonArea )
-bool wxComboControlBase::PreprocessMouseEvent( wxMouseEvent& event,
+//bool wxComboCtrlBase::PreprocessMouseEvent( wxMouseEvent& event, bool isOnButtonArea )
+bool wxComboCtrlBase::PreprocessMouseEvent( wxMouseEvent& event,

                                                int flags )
 {
     wxLongLong t = ::wxGetLocalTimeMillis();
                                                int flags )
 {
     wxLongLong t = ::wxGetLocalTimeMillis();


@@ -1418,7 +1432,7 @@ bool wxComboControlBase::PreprocessMouseEvent( wxMouseEvent& event,
     return false;
 }
 
     return false;
 }
 

-void wxComboControlBase::HandleNormalMouseEvent( wxMouseEvent& event )
+void wxComboCtrlBase::HandleNormalMouseEvent( wxMouseEvent& event )

 {
     int evtType = event.GetEventType();
 
 {
     int evtType = event.GetEventType();
 


@@ -1462,7 +1476,7 @@ void wxComboControlBase::HandleNormalMouseEvent( wxMouseEvent& event )
         event.Skip();
 }
 
         event.Skip();
 }
 

-void wxComboControlBase::OnFocusEvent( wxFocusEvent& )
+void wxComboCtrlBase::OnFocusEvent( wxFocusEvent& )

 {
     // First click is the first part of double-click
     // Some platforms don't generate down-less mouse up-event
 {
     // First click is the first part of double-click
     // Some platforms don't generate down-less mouse up-event


@@ -1481,7 +1495,7 @@ void wxComboControlBase::OnFocusEvent( wxFocusEvent& )
         Refresh();
 }
 
         Refresh();
 }
 

-void wxComboControlBase::OnSysColourChanged(wxSysColourChangedEvent& WXUNUSED(event))
+void wxComboCtrlBase::OnSysColourChanged(wxSysColourChangedEvent& WXUNUSED(event))

 {
     OnThemeChange();
     // indentation may also have changed
 {
     OnThemeChange();
     // indentation may also have changed


@@ -1495,7 +1509,7 @@ void wxComboControlBase::OnSysColourChanged(wxSysColourChangedEvent& WXUNUSED(ev
 // ----------------------------------------------------------------------------
 
 // Create popup window and the child control
 // ----------------------------------------------------------------------------
 
 // Create popup window and the child control

-void wxComboControlBase::CreatePopup()
+void wxComboCtrlBase::CreatePopup()

 {
     wxComboPopup* popupInterface = m_popupInterface;
     wxWindow* popup;
 {
     wxComboPopup* popupInterface = m_popupInterface;
     wxWindow* popup;


@@ -1517,14 +1531,39 @@ void wxComboControlBase::CreatePopup()
     popupInterface->m_iFlags |= wxCP_IFLAG_CREATED;
 }
 
     popupInterface->m_iFlags |= wxCP_IFLAG_CREATED;
 }
 

-void wxComboControlBase::SetPopupControl( wxComboPopup* iface )
+// Destroy popup window and the child control
+void wxComboCtrlBase::DestroyPopup()

 {
 {

+    if ( m_popup )
+        m_popup->RemoveEventHandler(m_popupExtraHandler);
+
+    delete m_popupExtraHandler;
+
+    HidePopup();
+

     delete m_popupInterface;
     delete m_popupInterface;

-    delete m_winPopup;
+
+    if ( m_winPopup )
+        m_winPopup->Destroy();
+
+    m_popupExtraHandler = (wxEvtHandler*) NULL;
+    m_popupInterface = (wxComboPopup*) NULL;
+    m_winPopup = (wxWindow*) NULL;
+    m_popup = (wxWindow*) NULL;
+}
+
+void wxComboCtrlBase::DoSetPopupControl(wxComboPopup* iface)
+{
+    wxCHECK_RET( iface, wxT("no popup interface set for wxComboCtrl") );
+
+    DestroyPopup();
+
+    iface->InitBase(this);
+    iface->Init();

 
     m_popupInterface = iface;
 
 
     m_popupInterface = iface;
 

-    if ( !iface->LazyCreate() || m_winPopup )
+    if ( !iface->LazyCreate() )

     {
         CreatePopup();
     }
     {
         CreatePopup();
     }


@@ -1533,22 +1572,31 @@ void wxComboControlBase::SetPopupControl( wxComboPopup* iface )
         m_popup = (wxWindow*) NULL;
     }
 
         m_popup = (wxWindow*) NULL;
     }
 

-    // This must be after creation
-    if ( m_valueString )
+    // This must be done after creation
+    if ( m_valueString.length() )
+    {

         iface->SetStringValue(m_valueString);
         iface->SetStringValue(m_valueString);

+        //Refresh();
+    }
+}

 
 

+// Ensures there is atleast the default popup
+void wxComboCtrlBase::EnsurePopupControl()
+{
+    if ( !m_popupInterface )
+        SetPopupControl(NULL);

 }
 
 }
 

-void wxComboControlBase::OnButtonClick()
+void wxComboCtrlBase::OnButtonClick()

 {
     // Derived classes can override this method for totally custom
     // popup action
     ShowPopup();
 }
 
 {
     // Derived classes can override this method for totally custom
     // popup action
     ShowPopup();
 }
 

-void wxComboControlBase::ShowPopup()
+void wxComboCtrlBase::ShowPopup()

 {
 {

-    wxCHECK_RET( m_popupInterface, wxT("no popup interface set for wxComboControl") );
+    EnsurePopupControl();

     wxCHECK_RET( !IsPopupShown(), wxT("popup window already shown") );
 
     SetFocus();
     wxCHECK_RET( !IsPopupShown(), wxT("popup window already shown") );
 
     SetFocus();


@@ -1625,15 +1673,45 @@ void wxComboControlBase::ShowPopup()
     int popupX;
     int popupY = scrPos.y + ctrlSz.y;
 
     int popupX;
     int popupY = scrPos.y + ctrlSz.y;
 

+    // Default anchor is wxLEFT

     int anchorSide = m_anchorSide;
     if ( !anchorSide )
     int anchorSide = m_anchorSide;
     if ( !anchorSide )

-        anchorSide = m_btnSide;
+        anchorSide = wxLEFT;
+
+    int rightX = scrPos.x + ctrlSz.x + m_extRight - szp.x;
+    int leftX = scrPos.x - m_extLeft;
+    int screenWidth = wxSystemSettings::GetMetric( wxSYS_SCREEN_X );

 
 

-    // Anchor popup to the side the dropbutton is on
+    // If there is not enough horizontal space, anchor on the other side.
+    // If there is no space even then, place the popup at x 0.

     if ( anchorSide == wxRIGHT )
     if ( anchorSide == wxRIGHT )

-        popupX = scrPos.x + ctrlSz.x + m_extRight- szp.x;
+    {
+        if ( rightX < 0 )
+        {
+            if ( (leftX+szp.x) < screenWidth )
+                anchorSide = wxLEFT;
+            else
+                anchorSide = 0;
+        }
+    }
+    else
+    {
+        if ( (leftX+szp.x) >= screenWidth )
+        {
+            if ( rightX >= 0 )
+                anchorSide = wxRIGHT;
+            else
+                anchorSide = 0;
+        }
+    }
+
+    // Select x coordinate according to the anchor side
+    if ( anchorSide == wxRIGHT )
+        popupX = rightX;
+    else if ( anchorSide == wxLEFT )
+        popupX = leftX;

     else
     else

-        popupX = scrPos.x - m_extLeft;
+        popupX = 0;

 
     if ( spaceBelow < szp.y )
     {
 
     if ( spaceBelow < szp.y )
     {


@@ -1663,7 +1741,6 @@ void wxComboControlBase::ShowPopup()
     else
     {
         // This is neede since focus/selection indication may change when popup is shown
     else
     {
         // This is neede since focus/selection indication may change when popup is shown

-        // FIXME: But in that case, would m_isPopupShown need to go before this?

         Refresh();
     }
 
         Refresh();
     }
 


@@ -1690,7 +1767,7 @@ void wxComboControlBase::ShowPopup()
 
 }
 
 
 }
 

-void wxComboControlBase::OnPopupDismiss()
+void wxComboCtrlBase::OnPopupDismiss()

 {
     // Just in case, avoid double dismiss
     if ( !m_isPopupShown )
 {
     // Just in case, avoid double dismiss
     if ( !m_isPopupShown )


@@ -1740,7 +1817,7 @@ void wxComboControlBase::OnPopupDismiss()
 
 }
 
 
 }
 

-void wxComboControlBase::HidePopup()
+void wxComboCtrlBase::HidePopup()

 {
     // Should be able to call this without popup interface
     //wxCHECK_RET( m_popupInterface, _T("no popup interface") );
 {
     // Should be able to call this without popup interface
     //wxCHECK_RET( m_popupInterface, _T("no popup interface") );


@@ -1763,8 +1840,8 @@ void wxComboControlBase::HidePopup()
 // customization methods
 // ----------------------------------------------------------------------------
 
 // customization methods
 // ----------------------------------------------------------------------------
 

-void wxComboControlBase::SetButtonPosition( int width, int height,
-                                            int side, int spacingX )
+void wxComboCtrlBase::SetButtonPosition( int width, int height,
+                                         int side, int spacingX )

 {
     m_btnWid = width;
     m_btnHei = height;
 {
     m_btnWid = width;
     m_btnHei = height;


@@ -1774,7 +1851,26 @@ void wxComboControlBase::SetButtonPosition( int width, int height,
     RecalcAndRefresh();
 }
 
     RecalcAndRefresh();
 }
 

-void wxComboControlBase::SetButtonBitmaps( const wxBitmap& bmpNormal,
+wxSize wxComboCtrlBase::GetButtonSize()
+{
+    if ( m_btnSize.x > 0 )
+        return m_btnSize;
+
+    wxSize retSize(m_btnWid,m_btnHei);
+
+    // Need to call CalculateAreas now if button size is
+    // is not explicitly specified.
+    if ( retSize.x <= 0 || retSize.y <= 0)
+    {
+        OnResize();
+
+        retSize = m_btnSize;
+    }
+
+    return retSize;
+}
+
+void wxComboCtrlBase::SetButtonBitmaps( const wxBitmap& bmpNormal,

                                            bool blankButtonBg,
                                            const wxBitmap& bmpPressed,
                                            const wxBitmap& bmpHover,
                                            bool blankButtonBg,
                                            const wxBitmap& bmpPressed,
                                            const wxBitmap& bmpHover,


@@ -1801,7 +1897,7 @@ void wxComboControlBase::SetButtonBitmaps( const wxBitmap& bmpNormal,
     RecalcAndRefresh();
 }
 
     RecalcAndRefresh();
 }
 

-void wxComboControlBase::SetCustomPaintWidth( int width )
+void wxComboCtrlBase::SetCustomPaintWidth( int width )

 {
     if ( m_text )
     {
 {
     if ( m_text )
     {


@@ -1818,7 +1914,7 @@ void wxComboControlBase::SetCustomPaintWidth( int width )
     RecalcAndRefresh();
 }
 
     RecalcAndRefresh();
 }
 

-void wxComboControlBase::SetTextIndent( int indent )
+void wxComboCtrlBase::SetTextIndent( int indent )

 {
     if ( indent < 0 )
     {
 {
     if ( indent < 0 )
     {


@@ -1834,7 +1930,7 @@ void wxComboControlBase::SetTextIndent( int indent )
     RecalcAndRefresh();
 }
 
     RecalcAndRefresh();
 }
 

-wxCoord wxComboControlBase::GetNativeTextIndent() const
+wxCoord wxComboCtrlBase::GetNativeTextIndent() const

 {
     return DEFAULT_TEXT_INDENT;
 }
 {
     return DEFAULT_TEXT_INDENT;
 }


@@ -1843,14 +1939,14 @@ wxCoord wxComboControlBase::GetNativeTextIndent() const
 // methods forwarded to wxTextCtrl
 // ----------------------------------------------------------------------------
 
 // methods forwarded to wxTextCtrl
 // ----------------------------------------------------------------------------
 

-wxString wxComboControlBase::GetValue() const
+wxString wxComboCtrlBase::GetValue() const

 {
     if ( m_text )
         return m_text->GetValue();
     return m_valueString;
 }
 
 {
     if ( m_text )
         return m_text->GetValue();
     return m_valueString;
 }
 

-void wxComboControlBase::SetValue(const wxString& value)
+void wxComboCtrlBase::SetValue(const wxString& value)

 {
     if ( m_text )
     {
 {
     if ( m_text )
     {


@@ -1859,49 +1955,61 @@ void wxComboControlBase::SetValue(const wxString& value)
             m_text->SelectAll();
     }
 
             m_text->SelectAll();
     }
 

+    m_valueString = value;
+
+    Refresh();
+

     // Since wxComboPopup may want to paint the combo as well, we need
     // to set the string value here (as well as sometimes in ShowPopup).
     if ( m_valueString != value && m_popupInterface )
     {
         m_popupInterface->SetStringValue(value);
     }
     // Since wxComboPopup may want to paint the combo as well, we need
     // to set the string value here (as well as sometimes in ShowPopup).
     if ( m_valueString != value && m_popupInterface )
     {
         m_popupInterface->SetStringValue(value);
     }

+}
+
+// In this SetValue variant wxComboPopup::SetStringValue is not called
+void wxComboCtrlBase::SetText(const wxString& value)
+{
+    // Unlike in SetValue(), this must be called here or
+    // the behaviour will no be consistent in readonlys.
+    EnsurePopupControl();

 
     m_valueString = value;
 
     Refresh();
 }
 
 
     m_valueString = value;
 
     Refresh();
 }
 

-void wxComboControlBase::Copy()
+void wxComboCtrlBase::Copy()

 {
     if ( m_text )
         m_text->Copy();
 }
 
 {
     if ( m_text )
         m_text->Copy();
 }
 

-void wxComboControlBase::Cut()
+void wxComboCtrlBase::Cut()

 {
     if ( m_text )
         m_text->Cut();
 }
 
 {
     if ( m_text )
         m_text->Cut();
 }
 

-void wxComboControlBase::Paste()
+void wxComboCtrlBase::Paste()

 {
     if ( m_text )
         m_text->Paste();
 }
 
 {
     if ( m_text )
         m_text->Paste();
 }
 

-void wxComboControlBase::SetInsertionPoint(long pos)
+void wxComboCtrlBase::SetInsertionPoint(long pos)

 {
     if ( m_text )
         m_text->SetInsertionPoint(pos);
 }
 
 {
     if ( m_text )
         m_text->SetInsertionPoint(pos);
 }
 

-void wxComboControlBase::SetInsertionPointEnd()
+void wxComboCtrlBase::SetInsertionPointEnd()

 {
     if ( m_text )
         m_text->SetInsertionPointEnd();
 }
 
 {
     if ( m_text )
         m_text->SetInsertionPointEnd();
 }
 

-long wxComboControlBase::GetInsertionPoint() const
+long wxComboCtrlBase::GetInsertionPoint() const

 {
     if ( m_text )
         return m_text->GetInsertionPoint();
 {
     if ( m_text )
         return m_text->GetInsertionPoint();


@@ -1909,7 +2017,7 @@ long wxComboControlBase::GetInsertionPoint() const
     return 0;
 }
 
     return 0;
 }
 

-long wxComboControlBase::GetLastPosition() const
+long wxComboCtrlBase::GetLastPosition() const

 {
     if ( m_text )
         return m_text->GetLastPosition();
 {
     if ( m_text )
         return m_text->GetLastPosition();


@@ -1917,28 +2025,28 @@ long wxComboControlBase::GetLastPosition() const
     return 0;
 }
 
     return 0;
 }
 

-void wxComboControlBase::Replace(long from, long to, const wxString& value)
+void wxComboCtrlBase::Replace(long from, long to, const wxString& value)

 {
     if ( m_text )
         m_text->Replace(from, to, value);
 }
 
 {
     if ( m_text )
         m_text->Replace(from, to, value);
 }
 

-void wxComboControlBase::Remove(long from, long to)
+void wxComboCtrlBase::Remove(long from, long to)

 {
     if ( m_text )
         m_text->Remove(from, to);
 }
 
 {
     if ( m_text )
         m_text->Remove(from, to);
 }
 

-void wxComboControlBase::SetSelection(long from, long to)
+void wxComboCtrlBase::SetSelection(long from, long to)

 {
     if ( m_text )
         m_text->SetSelection(from, to);
 }
 
 {
     if ( m_text )
         m_text->SetSelection(from, to);
 }
 

-void wxComboControlBase::Undo()
+void wxComboCtrlBase::Undo()

 {
     if ( m_text )
         m_text->Undo();
 }
 
 {
     if ( m_text )
         m_text->Undo();
 }
 

-#endif // wxUSE_COMBOCONTROL
+#endif // wxUSE_COMBOCTRL