Made dnd reentrent safe as per stable tree.

[wxWidgets.git] / src / gtk1 / window.cpp

diff --git a/src/gtk1/window.cpp b/src/gtk1/window.cpp
index cdbcf62cf0b040abc39aa54f315b3a14759f26ec..a85d6ab17b857ad6d222173471a3f122b5be095b 100644 (file)
--- a/src/gtk1/window.cpp
+++ b/src/gtk1/window.cpp
@@ -681,22 +681,6 @@ static int gtk_window_expose_callback( GtkWidget *widget, GdkEventExpose *gdk_ev
                                 
     GtkPizza *pizza = GTK_PIZZA (widget);
 
-/*        
-    if (win->IsTopLevel())
-    {
-        gtk_paint_flat_box (win->m_widget->style, pizza->bin_window, GTK_STATE_NORMAL,
-                   GTK_SHADOW_NONE, &gdk_event->area, win->m_widget, "base", 0, 0, -1, -1);
-    }
-    
-    wxWindow *parent = win->GetParent();
-    if (parent && GTK_IS_NOTEBOOK(parent->m_widget))
-    {
-        while (!parent->IsTopLevel())
-            parent = parent->GetParent();
-        gtk_paint_flat_box (parent->m_widget->style, pizza->bin_window, GTK_STATE_NORMAL,
-                   GTK_SHADOW_NONE, &gdk_event->area, parent->m_widget, "base", 0, 0, -1, -1);
-    }
-*/
     if (win->GetThemeEnabled())
     {
         wxWindow *parent = win->GetParent();
@@ -714,18 +698,18 @@ static int gtk_window_expose_callback( GtkWidget *widget, GdkEventExpose *gdk_ev
                                   gdk_event->area.width,
                                   gdk_event->area.height );
 
-        if (gdk_event->count == 0)
-        {
-            wxEraseEvent eevent( win->GetId() );
-            eevent.SetEventObject( win );
-            win->GetEventHandler()->ProcessEvent(eevent);
-
-            wxPaintEvent event( win->GetId() );
-            event.SetEventObject( win );
-            win->GetEventHandler()->ProcessEvent( event );
+    if (gdk_event->count == 0)
+    {
+        wxEraseEvent eevent( win->GetId() );
+        eevent.SetEventObject( win );
+        win->GetEventHandler()->ProcessEvent(eevent);
 
-            win->GetUpdateRegion().Clear();
-        }
+        wxPaintEvent event( win->GetId() );
+        event.SetEventObject( win );
+        win->GetEventHandler()->ProcessEvent( event );
+        
+        win->GetUpdateRegion().Clear();
+    }
     
         /* The following code will result in all window-less widgets
            being redrawn if the wxWindows class is given a chance to
@@ -789,7 +773,11 @@ static void gtk_window_draw_callback( GtkWidget *widget, GdkRectangle *rect, wxW
 
     if (g_isIdle)
         wxapp_install_idle_handler();
-        
+
+    // this is supposed to take care of extra (and unneeded) frame repaints
+    if (win->GetChildren().GetCount() == 0)
+        return; 
+
 /*
     if (win->GetName() == wxT("panel"))
     {
@@ -805,31 +793,29 @@ static void gtk_window_draw_callback( GtkWidget *widget, GdkRectangle *rect, wxW
    
     GtkPizza *pizza = GTK_PIZZA (widget);
 
-    if (win->IsTopLevel())
-    {
-        gtk_paint_flat_box (win->m_widget->style, pizza->bin_window, GTK_STATE_NORMAL, 
-                     GTK_SHADOW_NONE, rect, win->m_widget, "base", 0, 0, -1, -1);
-    }
-        
-    wxWindow *parent = win->GetParent();
-    if (parent && GTK_IS_NOTEBOOK(parent->m_widget))
+    if (win->GetThemeEnabled())
     {
-        while (!parent->IsTopLevel())
+        wxWindow *parent = win->GetParent();
+        while (parent && !parent->IsTopLevel())
             parent = parent->GetParent();
+        if (!parent)
+            parent = win;
+
         gtk_paint_flat_box (parent->m_widget->style, pizza->bin_window, GTK_STATE_NORMAL,
                    GTK_SHADOW_NONE, rect, parent->m_widget, "base", 0, 0, -1, -1);
     }
         
-        if (!(GTK_WIDGET_APP_PAINTABLE (widget)) &&
-             (pizza->clear_on_draw))
-        {
-            gdk_window_clear_area( pizza->bin_window,
+        
+    if (!(GTK_WIDGET_APP_PAINTABLE (widget)) &&
+         (pizza->clear_on_draw))
+    {
+        gdk_window_clear_area( pizza->bin_window,
                                rect->x, rect->y, rect->width, rect->height);
-        }
+    }
     
-        win->GetUpdateRegion().Union( rect->x, rect->y, rect->width, rect->height );
+    win->GetUpdateRegion().Union( rect->x, rect->y, rect->width, rect->height );
 
-        win->m_clipPaintRegion = TRUE;
+    win->m_clipPaintRegion = TRUE;
     
         wxEraseEvent eevent( win->GetId() );
         eevent.SetEventObject( win );