fixed hash collisions in ZIP files (patch 1082026)

[wxWidgets.git] / src / common / filename.cpp

diff --git a/src/common/filename.cpp b/src/common/filename.cpp
index 84af36bbf270290267a77e1ac9ddc4d02159e0b8..9553e92a27433643d46379caee24d7561f384432 100644 (file)
--- a/src/common/filename.cpp
+++ b/src/common/filename.cpp
@@ -87,6 +87,9 @@
 // For GetShort/LongPathName
 #ifdef __WIN32__
 #include "wx/msw/wrapwin.h"
 // For GetShort/LongPathName
 #ifdef __WIN32__
 #include "wx/msw/wrapwin.h"

+#if defined(__MINGW32__)
+#include "wx/msw/gccpriv.h"
+#endif

 #endif
 
 #ifdef __WXWINCE__
 #endif
 
 #ifdef __WXWINCE__


@@ -234,8 +237,8 @@ static void ConvertWxToFileTime(FILETIME *ft, const wxDateTime& dt)
 {
     SYSTEMTIME st;
     st.wDay = dt.GetDay();
 {
     SYSTEMTIME st;
     st.wDay = dt.GetDay();

-    st.wMonth = dt.GetMonth() + 1;
-    st.wYear = dt.GetYear();
+    st.wMonth = (WORD)(dt.GetMonth() + 1);
+    st.wYear = (WORD)dt.GetYear();

     st.wHour = dt.GetHour();
     st.wMinute = dt.GetMinute();
     st.wSecond = dt.GetSecond();
     st.wHour = dt.GetHour();
     st.wMinute = dt.GetMinute();
     st.wSecond = dt.GetSecond();


@@ -450,9 +453,21 @@ void wxFileName::Assign(const wxString& fullpathOrig,
     Assign(volume, path, name, ext, format);
 }
 
     Assign(volume, path, name, ext, format);
 }
 

+void wxFileName::Assign(const wxString& pathOrig,
+                        const wxString& name,
+                        const wxString& ext,
+                        wxPathFormat format)
+{
+    wxString volume,
+             path;
+    SplitVolume(pathOrig, &volume, &path, format);
+
+    Assign(volume, path, name, ext, format);
+}
+

 void wxFileName::AssignDir(const wxString& dir, wxPathFormat format)
 {
 void wxFileName::AssignDir(const wxString& dir, wxPathFormat format)
 {

-    Assign(dir, _T(""), format);
+    Assign(dir, wxEmptyString, format);

 }
 
 void wxFileName::Clear()
 }
 
 void wxFileName::Clear()


@@ -677,7 +692,7 @@ wxFileName::CreateTempFileName(const wxString& prefix, wxFile *fileTemp)
     else // mkstemp() succeeded
     {
         path = wxConvFile.cMB2WX( (const char*) buf );
     else // mkstemp() succeeded
     {
         path = wxConvFile.cMB2WX( (const char*) buf );

-        
+

         // avoid leaking the fd
         if ( fileTemp )
         {
         // avoid leaking the fd
         if ( fileTemp )
         {


@@ -794,12 +809,12 @@ bool wxFileName::Mkdir( const wxString& dir, int perm, int flags )
         size_t count = dirs.GetCount();
         for ( size_t i = 0; i < count; i++ )
         {
         size_t count = dirs.GetCount();
         for ( size_t i = 0; i < count; i++ )
         {

-            if ( i > 0 || 
+            if ( i > 0 ||

 #if defined(__WXMAC__) && !defined(__DARWIN__)
 #if defined(__WXMAC__) && !defined(__DARWIN__)

-                       // relative pathnames are exactely the other way round under mac...
-               !filename.IsAbsolute() 
+            // relative pathnames are exactely the other way round under mac...
+                !filename.IsAbsolute()

 #else
 #else

-               filename.IsAbsolute() 
+                filename.IsAbsolute()

 #endif
             )
                 currPath += wxFILE_SEP_PATH;
 #endif
             )
                 currPath += wxFILE_SEP_PATH;


@@ -951,7 +966,7 @@ bool wxFileName::Normalize(int flags,
 
         m_dirs.Add(dir);
     }
 
         m_dirs.Add(dir);
     }

-    
+

 #if defined(__WIN32__) && !defined(__WXWINCE__) && wxUSE_OLE
     if ( (flags & wxPATH_NORM_SHORTCUT) )
     {
 #if defined(__WIN32__) && !defined(__WXWINCE__) && wxUSE_OLE
     if ( (flags & wxPATH_NORM_SHORTCUT) )
     {


@@ -1021,49 +1036,54 @@ bool wxFileName::GetShortcutTarget(const wxString& shortcutPath, wxString& targe
 {
     wxString path, file, ext;
     wxSplitPath(shortcutPath, & path, & file, & ext);
 {
     wxString path, file, ext;
     wxSplitPath(shortcutPath, & path, & file, & ext);

-    
-       HRESULT hres;   
-       IShellLink* psl;
-    bool success = FALSE;
+
+    HRESULT hres;
+    IShellLink* psl;
+    bool success = false;

 
     // Assume it's not a shortcut if it doesn't end with lnk
     if (ext.Lower() != wxT("lnk"))
 
     // Assume it's not a shortcut if it doesn't end with lnk
     if (ext.Lower() != wxT("lnk"))

-        return FALSE;
-    
-       // create a ShellLink object
-       hres = CoCreateInstance(CLSID_ShellLink, NULL, CLSCTX_INPROC_SERVER,
-                               IID_IShellLink, (LPVOID*) &psl);
-       
-       if (SUCCEEDED(hres))
-       {
-               IPersistFile* ppf;
-               hres = psl->QueryInterface( IID_IPersistFile, (LPVOID *) &ppf);
-               if (SUCCEEDED(hres))
-               {
-                       WCHAR wsz[MAX_PATH];
-
-                       MultiByteToWideChar(CP_ACP, MB_PRECOMPOSED, shortcutPath.mb_str(), -1, wsz,
-                MAX_PATH);
-                       
-                       hres = ppf->Load(wsz, 0);                       
-                       if (SUCCEEDED(hres))
-                       {
+        return false;
+
+    // create a ShellLink object
+    hres = CoCreateInstance(CLSID_ShellLink, NULL, CLSCTX_INPROC_SERVER,
+                            IID_IShellLink, (LPVOID*) &psl);
+
+    if (SUCCEEDED(hres))
+    {
+        IPersistFile* ppf;
+        hres = psl->QueryInterface( IID_IPersistFile, (LPVOID *) &ppf);
+        if (SUCCEEDED(hres))
+        {
+            WCHAR wsz[MAX_PATH];
+
+            MultiByteToWideChar(CP_ACP, MB_PRECOMPOSED, shortcutPath.mb_str(), -1, wsz,
+                                MAX_PATH);
+
+            hres = ppf->Load(wsz, 0);
+            if (SUCCEEDED(hres))
+            {

                 wxChar buf[2048];
                 wxChar buf[2048];

-                               psl->GetPath(buf, 2048, NULL, SLGP_UNCPRIORITY);
-                               targetFilename = wxString(buf);
+                // Wrong prototype in early versions
+#if defined(__MINGW32__) && !wxCHECK_W32API_VERSION(2, 2)
+                psl->GetPath((CHAR*) buf, 2048, NULL, SLGP_UNCPRIORITY);
+#else
+                psl->GetPath(buf, 2048, NULL, SLGP_UNCPRIORITY);
+#endif
+                targetFilename = wxString(buf);

                 success = (shortcutPath != targetFilename);
 
                 success = (shortcutPath != targetFilename);
 

-                               psl->GetArguments(buf, 2048);
+                psl->GetArguments(buf, 2048);

                 wxString args(buf);
                 wxString args(buf);

-                if (!args.IsEmpty() && arguments)
+                if (!args.empty() && arguments)

                 {
                     *arguments = args;
                 {
                     *arguments = args;

-                }                
-                       }
-               }
-       }
-       psl->Release();
-       return success;
+                }
+            }
+        }
+    }
+    psl->Release();
+    return success;

 }
 #endif
 
 }
 #endif
 


@@ -1269,10 +1289,8 @@ wxString wxFileName::GetPathTerminators(wxPathFormat format)
 bool wxFileName::IsPathSeparator(wxChar ch, wxPathFormat format)
 {
     // wxString::Find() doesn't work as expected with NUL - it will always find
 bool wxFileName::IsPathSeparator(wxChar ch, wxPathFormat format)
 {
     // wxString::Find() doesn't work as expected with NUL - it will always find

-    // it, so it is almost surely a bug if this function is called with NUL arg
-    wxASSERT_MSG( ch != _T('\0'), _T("shouldn't be called with NUL") );
-
-    return GetPathSeparators(format).Find(ch) != wxNOT_FOUND;
+    // it, so test for it separately
+    return ch != _T('\0') && GetPathSeparators(format).Find(ch) != wxNOT_FOUND;

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -1302,26 +1320,26 @@ bool wxFileName::IsPathSeparator(wxChar ch, wxPathFormat format)
     return true;
 }
 
     return true;
 }
 

-void wxFileName::AppendDir( const wxString &dir )
+void wxFileName::AppendDir( const wxString& dir )

 {
     if ( IsValidDirComponent(dir) )
         m_dirs.Add( dir );
 }
 
 {
     if ( IsValidDirComponent(dir) )
         m_dirs.Add( dir );
 }
 

-void wxFileName::PrependDir( const wxString &dir )
+void wxFileName::PrependDir( const wxString& dir )

 {
     InsertDir(0, dir);
 }
 
 {
     InsertDir(0, dir);
 }
 

-void wxFileName::InsertDir( int before, const wxString &dir )
+void wxFileName::InsertDir(size_t before, const wxString& dir)

 {
     if ( IsValidDirComponent(dir) )
 {
     if ( IsValidDirComponent(dir) )

-        m_dirs.Insert( dir, before );
+        m_dirs.Insert(dir, before);

 }
 
 }
 

-void wxFileName::RemoveDir( int pos )
+void wxFileName::RemoveDir(size_t pos)

 {
 {

-    m_dirs.RemoveAt( (size_t)pos );
+    m_dirs.RemoveAt(pos);

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -1980,7 +1998,7 @@ public :
   MacDefaultExtensionRecord()
   {
     m_ext[0] = 0 ;
   MacDefaultExtensionRecord()
   {
     m_ext[0] = 0 ;

-    m_type = m_creator = NULL ;
+    m_type = m_creator = 0 ;

   }
   MacDefaultExtensionRecord( const MacDefaultExtensionRecord& from )
   {
   }
   MacDefaultExtensionRecord( const MacDefaultExtensionRecord& from )
   {


@@ -2040,14 +2058,14 @@ bool wxFileName::MacSetTypeAndCreator( wxUint32 type , wxUint32 creator )
 
     if ( wxMacPathToFSRef( GetFullPath() , &fsRef ) == noErr )
     {
 
     if ( wxMacPathToFSRef( GetFullPath() , &fsRef ) == noErr )
     {

-           if ( FSGetCatalogInfo (&fsRef, kFSCatInfoFinderInfo, &catInfo, NULL, NULL, NULL) == noErr )
-           {
-               finfo = (FileInfo*)&catInfo.finderInfo;
-                   finfo->fileType = type ;
-                   finfo->fileCreator = creator ;
-                   FSSetCatalogInfo( &fsRef, kFSCatInfoFinderInfo, &catInfo ) ;
+        if ( FSGetCatalogInfo (&fsRef, kFSCatInfoFinderInfo, &catInfo, NULL, NULL, NULL) == noErr )
+        {
+            finfo = (FileInfo*)&catInfo.finderInfo;
+            finfo->fileType = type ;
+            finfo->fileCreator = creator ;
+            FSSetCatalogInfo( &fsRef, kFSCatInfoFinderInfo, &catInfo ) ;

             return true ;
             return true ;

-           }
+        }

     }
     return false ;
 }
     }
     return false ;
 }


@@ -2060,13 +2078,13 @@ bool wxFileName::MacGetTypeAndCreator( wxUint32 *type , wxUint32 *creator )
 
     if ( wxMacPathToFSRef( GetFullPath() , &fsRef ) == noErr )
     {
 
     if ( wxMacPathToFSRef( GetFullPath() , &fsRef ) == noErr )
     {

-           if ( FSGetCatalogInfo (&fsRef, kFSCatInfoFinderInfo, &catInfo, NULL, NULL, NULL) == noErr )
-           {
-               finfo = (FileInfo*)&catInfo.finderInfo;
-                   *type = finfo->fileType ;
-                   *creator = finfo->fileCreator ;
+        if ( FSGetCatalogInfo (&fsRef, kFSCatInfoFinderInfo, &catInfo, NULL, NULL, NULL) == noErr )
+        {
+            finfo = (FileInfo*)&catInfo.finderInfo;
+            *type = finfo->fileType ;
+            *creator = finfo->fileCreator ;

             return true ;
             return true ;

-           }
+        }

     }
     return false ;
 }
     }
     return false ;
 }