fixed bug with adding new entries to a root group with subgroups but without any...

[wxWidgets.git] / src / common / filename.cpp

diff --git a/src/common/filename.cpp b/src/common/filename.cpp
index 84af36bbf270290267a77e1ac9ddc4d02159e0b8..94799d1a964f9aba107c9dc2ea67042523b700bf 100644 (file)
--- a/src/common/filename.cpp
+++ b/src/common/filename.cpp
@@ -87,6 +87,9 @@
 // For GetShort/LongPathName
 #ifdef __WIN32__
 #include "wx/msw/wrapwin.h"
+#if defined(__MINGW32__)
+#include "wx/msw/gccpriv.h"
+#endif
 #endif
 
 #ifdef __WXWINCE__
@@ -234,8 +237,8 @@ static void ConvertWxToFileTime(FILETIME *ft, const wxDateTime& dt)
 {
     SYSTEMTIME st;
     st.wDay = dt.GetDay();
-    st.wMonth = dt.GetMonth() + 1;
-    st.wYear = dt.GetYear();
+    st.wMonth = (WORD)(dt.GetMonth() + 1);
+    st.wYear = (WORD)dt.GetYear();
     st.wHour = dt.GetHour();
     st.wMinute = dt.GetMinute();
     st.wSecond = dt.GetSecond();
@@ -677,7 +680,7 @@ wxFileName::CreateTempFileName(const wxString& prefix, wxFile *fileTemp)
     else // mkstemp() succeeded
     {
         path = wxConvFile.cMB2WX( (const char*) buf );
-        
+
         // avoid leaking the fd
         if ( fileTemp )
         {
@@ -794,12 +797,12 @@ bool wxFileName::Mkdir( const wxString& dir, int perm, int flags )
         size_t count = dirs.GetCount();
         for ( size_t i = 0; i < count; i++ )
         {
-            if ( i > 0 || 
+            if ( i > 0 ||
 #if defined(__WXMAC__) && !defined(__DARWIN__)
-                       // relative pathnames are exactely the other way round under mac...
-               !filename.IsAbsolute() 
+            // relative pathnames are exactely the other way round under mac...
+                !filename.IsAbsolute()
 #else
-               filename.IsAbsolute() 
+                filename.IsAbsolute()
 #endif
             )
                 currPath += wxFILE_SEP_PATH;
@@ -951,7 +954,7 @@ bool wxFileName::Normalize(int flags,
 
         m_dirs.Add(dir);
     }
-    
+
 #if defined(__WIN32__) && !defined(__WXWINCE__) && wxUSE_OLE
     if ( (flags & wxPATH_NORM_SHORTCUT) )
     {
@@ -1021,49 +1024,54 @@ bool wxFileName::GetShortcutTarget(const wxString& shortcutPath, wxString& targe
 {
     wxString path, file, ext;
     wxSplitPath(shortcutPath, & path, & file, & ext);
-    
-       HRESULT hres;   
-       IShellLink* psl;
-    bool success = FALSE;
+
+    HRESULT hres;
+    IShellLink* psl;
+    bool success = false;
 
     // Assume it's not a shortcut if it doesn't end with lnk
     if (ext.Lower() != wxT("lnk"))
-        return FALSE;
-    
-       // create a ShellLink object
-       hres = CoCreateInstance(CLSID_ShellLink, NULL, CLSCTX_INPROC_SERVER,
-                               IID_IShellLink, (LPVOID*) &psl);
-       
-       if (SUCCEEDED(hres))
-       {
-               IPersistFile* ppf;
-               hres = psl->QueryInterface( IID_IPersistFile, (LPVOID *) &ppf);
-               if (SUCCEEDED(hres))
-               {
-                       WCHAR wsz[MAX_PATH];
-
-                       MultiByteToWideChar(CP_ACP, MB_PRECOMPOSED, shortcutPath.mb_str(), -1, wsz,
-                MAX_PATH);
-                       
-                       hres = ppf->Load(wsz, 0);                       
-                       if (SUCCEEDED(hres))
-                       {
+        return false;
+
+    // create a ShellLink object
+    hres = CoCreateInstance(CLSID_ShellLink, NULL, CLSCTX_INPROC_SERVER,
+                            IID_IShellLink, (LPVOID*) &psl);
+
+    if (SUCCEEDED(hres))
+    {
+        IPersistFile* ppf;
+        hres = psl->QueryInterface( IID_IPersistFile, (LPVOID *) &ppf);
+        if (SUCCEEDED(hres))
+        {
+            WCHAR wsz[MAX_PATH];
+
+            MultiByteToWideChar(CP_ACP, MB_PRECOMPOSED, shortcutPath.mb_str(), -1, wsz,
+                                MAX_PATH);
+
+            hres = ppf->Load(wsz, 0);
+            if (SUCCEEDED(hres))
+            {
                 wxChar buf[2048];
-                               psl->GetPath(buf, 2048, NULL, SLGP_UNCPRIORITY);
-                               targetFilename = wxString(buf);
+                // Wrong prototype in early versions
+#if defined(__MINGW32__) && !wxCHECK_W32API_VERSION(2, 2)
+                psl->GetPath((CHAR*) buf, 2048, NULL, SLGP_UNCPRIORITY);
+#else
+                psl->GetPath(buf, 2048, NULL, SLGP_UNCPRIORITY);
+#endif
+                targetFilename = wxString(buf);
                 success = (shortcutPath != targetFilename);
 
-                               psl->GetArguments(buf, 2048);
+                psl->GetArguments(buf, 2048);
                 wxString args(buf);
                 if (!args.IsEmpty() && arguments)
                 {
                     *arguments = args;
-                }                
-                       }
-               }
-       }
-       psl->Release();
-       return success;
+                }
+            }
+        }
+    }
+    psl->Release();
+    return success;
 }
 #endif
 
@@ -2040,14 +2048,14 @@ bool wxFileName::MacSetTypeAndCreator( wxUint32 type , wxUint32 creator )
 
     if ( wxMacPathToFSRef( GetFullPath() , &fsRef ) == noErr )
     {
-           if ( FSGetCatalogInfo (&fsRef, kFSCatInfoFinderInfo, &catInfo, NULL, NULL, NULL) == noErr )
-           {
-               finfo = (FileInfo*)&catInfo.finderInfo;
-                   finfo->fileType = type ;
-                   finfo->fileCreator = creator ;
-                   FSSetCatalogInfo( &fsRef, kFSCatInfoFinderInfo, &catInfo ) ;
+        if ( FSGetCatalogInfo (&fsRef, kFSCatInfoFinderInfo, &catInfo, NULL, NULL, NULL) == noErr )
+        {
+            finfo = (FileInfo*)&catInfo.finderInfo;
+            finfo->fileType = type ;
+            finfo->fileCreator = creator ;
+            FSSetCatalogInfo( &fsRef, kFSCatInfoFinderInfo, &catInfo ) ;
             return true ;
-           }
+        }
     }
     return false ;
 }
@@ -2060,13 +2068,13 @@ bool wxFileName::MacGetTypeAndCreator( wxUint32 *type , wxUint32 *creator )
 
     if ( wxMacPathToFSRef( GetFullPath() , &fsRef ) == noErr )
     {
-           if ( FSGetCatalogInfo (&fsRef, kFSCatInfoFinderInfo, &catInfo, NULL, NULL, NULL) == noErr )
-           {
-               finfo = (FileInfo*)&catInfo.finderInfo;
-                   *type = finfo->fileType ;
-                   *creator = finfo->fileCreator ;
+        if ( FSGetCatalogInfo (&fsRef, kFSCatInfoFinderInfo, &catInfo, NULL, NULL, NULL) == noErr )
+        {
+            finfo = (FileInfo*)&catInfo.finderInfo;
+            *type = finfo->fileType ;
+            *creator = finfo->fileCreator ;
             return true ;
-           }
+        }
     }
     return false ;
 }