use wxColourDatabase::Find() instead of deprecated FindColour(); some minor code...

[wxWidgets.git] / src / common / wincmn.cpp

diff --git a/src/common/wincmn.cpp b/src/common/wincmn.cpp
index 2961a758e940c9292b5d9f8764578432ede7445b..a45a930faeef994357bf3532f321da5ba7af7593 100644 (file)
--- a/src/common/wincmn.cpp
+++ b/src/common/wincmn.cpp
@@ -202,7 +202,7 @@ bool wxWindowBase::CreateBase(wxWindowBase *parent,
                               const wxPoint& WXUNUSED(pos),
                               const wxSize& WXUNUSED(size),
                               long style,
                               const wxPoint& WXUNUSED(pos),
                               const wxSize& WXUNUSED(size),
                               long style,

-                              const wxValidator& validator,
+                              const wxValidator& wxVALIDATOR_PARAM(validator),

                               const wxString& name)
 {
 #if wxUSE_STATBOX
                               const wxString& name)
 {
 #if wxUSE_STATBOX


@@ -266,6 +266,17 @@ wxWindowBase::~wxWindowBase()
 
     wxASSERT_MSG( GetChildren().GetCount() == 0, wxT("children not destroyed") );
 
 
     wxASSERT_MSG( GetChildren().GetCount() == 0, wxT("children not destroyed") );
 

+    // reset the dangling pointer our parent window may keep to us
+    if ( m_parent )
+    {
+        if ( m_parent->GetDefaultItem() == this )
+        {
+            m_parent->SetDefaultItem(NULL);
+        }
+
+        m_parent->RemoveChild(this);
+    }
+

 #if wxUSE_CARET
     delete m_caret;
 #endif // wxUSE_CARET
 #if wxUSE_CARET
     delete m_caret;
 #endif // wxUSE_CARET


@@ -305,12 +316,6 @@ wxWindowBase::~wxWindowBase()
 #if wxUSE_ACCESSIBILITY
     delete m_accessible;
 #endif
 #if wxUSE_ACCESSIBILITY
     delete m_accessible;
 #endif

-
-    // reset the dangling pointer our parent window may keep to us
-    if ( m_parent && m_parent->GetDefaultItem() == this )
-    {
-        m_parent->SetDefaultItem(NULL);
-    }

 }
 
 bool wxWindowBase::Destroy()
 }
 
 bool wxWindowBase::Destroy()


@@ -343,11 +348,11 @@ bool wxWindowBase::DestroyChildren()
 
         wxWindow *child = node->GetData();
 
 
         wxWindow *child = node->GetData();
 

-        wxASSERT_MSG( child, wxT("children list contains empty nodes") );
-
-        child->Show(FALSE);
-
-        child->Destroy();
+        // note that we really want to call delete and not ->Destroy() here
+        // because we want to delete the child immediately, before we are
+        // deleted, and delayed deletion would result in problems as our (top
+        // level) child could outlive its parent
+        delete child;

 
         wxASSERT_MSG( !GetChildren().Find(child),
                       wxT("child didn't remove itself using RemoveChild()") );
 
         wxASSERT_MSG( !GetChildren().Find(child),
                       wxT("child didn't remove itself using RemoveChild()") );


@@ -807,7 +812,9 @@ bool wxWindowBase::RemoveEventHandler(wxEvtHandler *handler)
             {
                 handlerNext->SetPreviousHandler ( handlerPrev );
             }
             {
                 handlerNext->SetPreviousHandler ( handlerPrev );
             }

+

             handler->SetNextHandler(NULL);
             handler->SetNextHandler(NULL);

+            handler->SetPreviousHandler(NULL);

 
             return TRUE;
         }
 
             return TRUE;
         }


@@ -2143,7 +2150,7 @@ void wxWindowBase::SendDestroyEvent()
 // event processing
 // ----------------------------------------------------------------------------
 
 // event processing
 // ----------------------------------------------------------------------------
 

-bool wxWindowBase::TryValidator(wxEvent& event)
+bool wxWindowBase::TryValidator(wxEvent& wxVALIDATOR_PARAM(event))

 {
 #if wxUSE_VALIDATORS
     // Can only use the validator of the window which
 {
 #if wxUSE_VALIDATORS
     // Can only use the validator of the window which


@@ -2205,7 +2212,7 @@ wxWindow* wxGetTopLevelParent(wxWindow *win)
 
 // Can return either a child object, or an integer
 // representing the child element, starting from 1.
 
 // Can return either a child object, or an integer
 // representing the child element, starting from 1.

-wxAccStatus wxWindowAccessible::HitTest(const wxPoint& pt, int* childId, wxAccessible** childObject)
+wxAccStatus wxWindowAccessible::HitTest(const wxPoint& WXUNUSED(pt), int* WXUNUSED(childId), wxAccessible** WXUNUSED(childObject))

 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())
 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())


@@ -2248,7 +2255,7 @@ wxAccStatus wxWindowAccessible::GetLocation(wxRect& rect, int elementId)
 
 // Navigates from fromId to toId/toObject.
 wxAccStatus wxWindowAccessible::Navigate(wxNavDir navDir, int fromId,
 
 // Navigates from fromId to toId/toObject.
 wxAccStatus wxWindowAccessible::Navigate(wxNavDir navDir, int fromId,

-                             int* toId, wxAccessible** toObject)
+                             int* WXUNUSED(toId), wxAccessible** toObject)

 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())
 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())


@@ -2435,7 +2442,7 @@ wxAccStatus wxWindowAccessible::GetParent(wxAccessible** parent)
 // or > 0 (the action for a child).
 // Return wxACC_NOT_SUPPORTED if there is no default action for this
 // window (e.g. an edit control).
 // or > 0 (the action for a child).
 // Return wxACC_NOT_SUPPORTED if there is no default action for this
 // window (e.g. an edit control).

-wxAccStatus wxWindowAccessible::DoDefaultAction(int childId)
+wxAccStatus wxWindowAccessible::DoDefaultAction(int WXUNUSED(childId))

 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())
 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())


@@ -2450,7 +2457,7 @@ wxAccStatus wxWindowAccessible::DoDefaultAction(int childId)
 // The retrieved string describes the action that is performed on an object,
 // not what the object does as a result. For example, a toolbar button that prints
 // a document has a default action of "Press" rather than "Prints the current document."
 // The retrieved string describes the action that is performed on an object,
 // not what the object does as a result. For example, a toolbar button that prints
 // a document has a default action of "Press" rather than "Prints the current document."

-wxAccStatus wxWindowAccessible::GetDefaultAction(int childId, wxString* actionName)
+wxAccStatus wxWindowAccessible::GetDefaultAction(int WXUNUSED(childId), wxString* WXUNUSED(actionName))

 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())
 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())


@@ -2460,7 +2467,7 @@ wxAccStatus wxWindowAccessible::GetDefaultAction(int childId, wxString* actionNa
 }
 
 // Returns the description for this object or a child.
 }
 
 // Returns the description for this object or a child.

-wxAccStatus wxWindowAccessible::GetDescription(int childId, wxString* description)
+wxAccStatus wxWindowAccessible::GetDescription(int WXUNUSED(childId), wxString* description)

 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())
 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())


@@ -2476,7 +2483,7 @@ wxAccStatus wxWindowAccessible::GetDescription(int childId, wxString* descriptio
 }
 
 // Returns help text for this object or a child, similar to tooltip text.
 }
 
 // Returns help text for this object or a child, similar to tooltip text.

-wxAccStatus wxWindowAccessible::GetHelpText(int childId, wxString* helpText)
+wxAccStatus wxWindowAccessible::GetHelpText(int WXUNUSED(childId), wxString* helpText)

 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())
 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())


@@ -2493,7 +2500,7 @@ wxAccStatus wxWindowAccessible::GetHelpText(int childId, wxString* helpText)
 
 // Returns the keyboard shortcut for this object or child.
 // Return e.g. ALT+K
 
 // Returns the keyboard shortcut for this object or child.
 // Return e.g. ALT+K

-wxAccStatus wxWindowAccessible::GetKeyboardShortcut(int childId, wxString* shortcut)
+wxAccStatus wxWindowAccessible::GetKeyboardShortcut(int WXUNUSED(childId), wxString* WXUNUSED(shortcut))

 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())
 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())


@@ -2529,7 +2536,9 @@ wxAccStatus wxWindowAccessible::GetRole(int childId, wxAccRole* role)
     *role = wxROLE_SYSTEM_CLIENT;
     return wxACC_OK;
 
     *role = wxROLE_SYSTEM_CLIENT;
     return wxACC_OK;
 

+    #if 0

     return wxACC_NOT_IMPLEMENTED;
     return wxACC_NOT_IMPLEMENTED;

+    #endif

 }
 
 // Returns a state constant.
 }
 
 // Returns a state constant.


@@ -2559,12 +2568,14 @@ wxAccStatus wxWindowAccessible::GetState(int childId, long* state)
     *state = 0;
     return wxACC_OK;
 
     *state = 0;
     return wxACC_OK;
 

+    #if 0

     return wxACC_NOT_IMPLEMENTED;
     return wxACC_NOT_IMPLEMENTED;

+    #endif

 }
 
 // Returns a localized string representing the value for the object
 // or child.
 }
 
 // Returns a localized string representing the value for the object
 // or child.

-wxAccStatus wxWindowAccessible::GetValue(int childId, wxString* strValue)
+wxAccStatus wxWindowAccessible::GetValue(int WXUNUSED(childId), wxString* WXUNUSED(strValue))

 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())
 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())


@@ -2574,7 +2585,7 @@ wxAccStatus wxWindowAccessible::GetValue(int childId, wxString* strValue)
 }
 
 // Selects the object or child.
 }
 
 // Selects the object or child.

-wxAccStatus wxWindowAccessible::Select(int childId, wxAccSelectionFlags selectFlags)
+wxAccStatus wxWindowAccessible::Select(int WXUNUSED(childId), wxAccSelectionFlags WXUNUSED(selectFlags))

 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())
 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())


@@ -2587,7 +2598,7 @@ wxAccStatus wxWindowAccessible::Select(int childId, wxAccSelectionFlags selectFl
 // If childId is 0 and child is NULL, no object in
 // this subhierarchy has the focus.
 // If this object has the focus, child should be 'this'.
 // If childId is 0 and child is NULL, no object in
 // this subhierarchy has the focus.
 // If this object has the focus, child should be 'this'.

-wxAccStatus wxWindowAccessible::GetFocus(int* childId, wxAccessible** child)
+wxAccStatus wxWindowAccessible::GetFocus(int* WXUNUSED(childId), wxAccessible** WXUNUSED(child))

 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())
 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())


@@ -2604,7 +2615,7 @@ wxAccStatus wxWindowAccessible::GetFocus(int* childId, wxAccessible** child)
 // - an integer representing the selected child element,
 //   or 0 if this object is selected (GetType() == wxT("long")
 // - a "void*" pointer to a wxAccessible child object
 // - an integer representing the selected child element,
 //   or 0 if this object is selected (GetType() == wxT("long")
 // - a "void*" pointer to a wxAccessible child object

-wxAccStatus wxWindowAccessible::GetSelections(wxVariant* selections)
+wxAccStatus wxWindowAccessible::GetSelections(wxVariant* WXUNUSED(selections))

 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())
 {
     wxASSERT( GetWindow() != NULL );
     if (!GetWindow())