label.wx_str(), // the window name
style, // the window style
x, y, w, h, // the window position and size
- GetHwndOf(GetParent()), // parent
- (HMENU)GetId(), // child id
+ GetHwndOf(GetParent()), // parent
+ (HMENU)wxUIntToPtr(GetId()), // child id
wxGetInstance(), // app instance
NULL // creation parameters
);
if ( !m_hWnd )
{
#ifdef __WXDEBUG__
- wxFAIL_MSG(wxString::Format
- (
- _T("CreateWindowEx(\"%s\", flags=%08x, ex=%08x) failed"),
- classname, (unsigned int)style, (unsigned int)exstyle
- ));
+ wxLogLastError(wxString::Format
+ (
+ _T("CreateWindowEx(\"%s\", flags=%08lx, ex=%08lx)"),
+ classname, style, exstyle
+ ));
#endif // __WXDEBUG__
return false;
}
+#if !wxUSE_UNICODE
+ // Text labels starting with the character 0xff (which is a valid character
+ // in many code pages) don't appear correctly as CreateWindowEx() has some
+ // special treatment for this case, apparently the strings starting with -1
+ // are not really strings but something called "ordinals". There is no
+ // documentation about it but the fact is that the label gets mangled or
+ // not displayed at all if we don't do this, see #9572.
+ //
+ // Notice that 0xffff is not a valid Unicode character so the problem
+ // doesn't arise in Unicode build.
+ if ( !label.empty() && label[0] == -1 )
+ ::SetWindowText(GetHwnd(), label.wx_str());
+#endif // !wxUSE_UNICODE
+
// saving the label in m_labelOrig to return it verbatim
// later in GetLabel()
m_labelOrig = label;
// various accessors
// ----------------------------------------------------------------------------
-wxBorder wxControl::GetDefaultBorder() const
-{
- // we want to automatically give controls a sunken style (confusingly,
- // it may not really mean sunken at all as we map it to WS_EX_CLIENTEDGE
- // which is not sunken at all under Windows XP -- rather, just the default)
-#if defined(__POCKETPC__) || defined(__SMARTPHONE__)
- return wxBORDER_SIMPLE;
-#else
- return wxBORDER_SUNKEN;
-#endif
-}
-
WXDWORD wxControl::MSWGetStyle(long style, WXDWORD *exstyle) const
{
long msStyle = wxWindow::MSWGetStyle(style, exstyle);
return wxSize(DEFAULT_ITEM_WIDTH, DEFAULT_ITEM_HEIGHT);
}
+wxBorder wxControl::GetDefaultBorder() const
+{
+ return wxControlBase::GetDefaultBorder();
+}
+
// This is a helper for all wxControls made with UPDOWN native control.
// In wxMSW it was only wxSpinCtrl derived from wxSpinButton but in
// WinCE of Smartphones this happens also for native wxTextCtrl,
bool wxControl::ProcessCommand(wxCommandEvent& event)
{
- return GetEventHandler()->ProcessEvent(event);
+ return HandleWindowEvent(event);
}
bool wxControl::MSWOnNotify(int idCtrl,
event.SetEventType(eventType);
event.SetEventObject(this);
- return GetEventHandler()->ProcessEvent(event);
+ return HandleWindowEvent(event);
}
WXHBRUSH wxControl::DoMSWControlColor(WXHDC pDC, wxColour colBg, WXHWND hWnd)
::SetBkColor(hdc, wxColourToRGB(colBg));
// draw children with the same colour as the parent
- wxBrush *brush = wxTheBrushList->FindOrCreateBrush(colBg, wxSOLID);
-
+ wxBrush *brush = wxTheBrushList->FindOrCreateBrush(colBg,
+ wxBRUSHSTYLE_SOLID);
hbr = (WXHBRUSH)brush->GetResourceHandle();
-
}
// if we use custom background, we should set foreground ourselves too
totalTextLength += items[i].length();
}
- if ( SendMessage(MSWGetItemsHWND(), wm, numItems,
+ if ( SendMessage((HWND)MSWGetItemsHWND(), wm, numItems,
(LPARAM)totalTextLength*sizeof(wxChar)) == LB_ERRSPACE )
{
wxLogLastError(wxT("SendMessage(XX_INITSTORAGE)"));
const wxString& item,
unsigned wm)
{
- LRESULT n = SendMessage(MSWGetItemsHWND(), wm, pos, (LPARAM)item.wx_str());
+ LRESULT n = SendMessage((HWND)MSWGetItemsHWND(), wm, pos,
+ (LPARAM)item.wx_str());
if ( n == CB_ERR || n == CB_ERRSPACE )
{
wxLogLastError(wxT("SendMessage(XX_ADD/INSERTSTRING)"));