fixed memory leak in RestoreState

[wxWidgets.git] / src / x11 / window.cpp

diff --git a/src/x11/window.cpp b/src/x11/window.cpp
index ce08b9fd81c786eed722eac96b820e0e2218149f..2e2df49db87ac9102ed8a3bc714b0a68b9c8d55c 100644 (file)
--- a/src/x11/window.cpp
+++ b/src/x11/window.cpp
@@ -1,5 +1,5 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        windows.cpp
+// Name:        src/x11/window.cpp

 // Purpose:     wxWindow
 // Author:      Julian Smart
 // Modified by:
 // Purpose:     wxWindow
 // Author:      Julian Smart
 // Modified by:


@@ -9,6 +9,13 @@
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 

+// for compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"
+
+#if defined(__BORLANDC__)
+    #pragma hdrstop
+#endif
+

 // ============================================================================
 // declarations
 // ============================================================================
 // ============================================================================
 // declarations
 // ============================================================================


@@ -17,29 +24,32 @@
 // headers
 // ----------------------------------------------------------------------------
 
 // headers
 // ----------------------------------------------------------------------------
 

-#ifdef __GNUG__
-    #pragma implementation "window.h"
+#include "wx/window.h"
+
+#ifndef WX_PRECOMP
+    #include "wx/hash.h"
+    #include "wx/log.h"
+    #include "wx/app.h"
+    #include "wx/utils.h"
+    #include "wx/panel.h"
+    #include "wx/frame.h"
+    #include "wx/dc.h"
+    #include "wx/dcclient.h"
+    #include "wx/button.h"
+    #include "wx/menu.h"
+    #include "wx/dialog.h"
+    #include "wx/timer.h"
+    #include "wx/settings.h"
+    #include "wx/msgdlg.h"
+    #include "wx/scrolbar.h"
+    #include "wx/listbox.h"
+    #include "wx/scrolwin.h"
+    #include "wx/layout.h"
+    #include "wx/menuitem.h"
+    #include "wx/module.h"

 #endif
 
 #endif
 

-#include "wx/setup.h"
-#include "wx/menu.h"
-#include "wx/dc.h"
-#include "wx/dcclient.h"
-#include "wx/utils.h"
-#include "wx/app.h"
-#include "wx/panel.h"
-#include "wx/layout.h"
-#include "wx/dialog.h"
-#include "wx/listbox.h"
-#include "wx/button.h"
-#include "wx/settings.h"
-#include "wx/msgdlg.h"
-#include "wx/frame.h"
-#include "wx/scrolwin.h"
-#include "wx/scrolbar.h"
-#include "wx/module.h"
-#include "wx/menuitem.h"
-#include "wx/log.h"
+#include "wx/fontutil.h"

 #include "wx/univ/renderer.h"
 
 #if  wxUSE_DRAG_AND_DROP
 #include "wx/univ/renderer.h"
 
 #if  wxUSE_DRAG_AND_DROP


@@ -49,19 +59,12 @@
 #include "wx/x11/private.h"
 #include "X11/Xutil.h"
 
 #include "wx/x11/private.h"
 #include "X11/Xutil.h"
 

-#if wxUSE_NANOX
-// For wxGetLocalTime, used by XButtonEventGetTime
-#include "wx/timer.h"
-#endif
-

 #include <string.h>
 
 // ----------------------------------------------------------------------------
 // global variables for this module
 // ----------------------------------------------------------------------------
 
 #include <string.h>
 
 // ----------------------------------------------------------------------------
 // global variables for this module
 // ----------------------------------------------------------------------------
 

-extern wxHashTable *wxWidgetHashTable;
-extern wxHashTable *wxClientWidgetHashTable;

 static wxWindow* g_captureWindow = NULL;
 static GC g_eraseGC;
 
 static wxWindow* g_captureWindow = NULL;
 static GC g_eraseGC;
 


@@ -97,123 +100,135 @@ END_EVENT_TABLE()
 
 void wxWindowX11::Init()
 {
 
 void wxWindowX11::Init()
 {

-    // generic initializations first
-    InitBase();
-

     // X11-specific
     m_mainWindow = (WXWindow) 0;
     m_clientWindow = (WXWindow) 0;
     // X11-specific
     m_mainWindow = (WXWindow) 0;
     m_clientWindow = (WXWindow) 0;

-    m_insertIntoMain = FALSE;
-    m_updateNcArea = FALSE;
-    
-    m_winCaptured = FALSE;
-    m_needsInputFocus = FALSE;
-    m_isShown = TRUE;
-    m_isBeingDeleted = FALSE;
+    m_insertIntoMain = false;
+    m_updateNcArea = false;
+
+    m_winCaptured = false;
+    m_needsInputFocus = false;
+    m_isShown = true;

     m_lastTS = 0;
     m_lastButton = 0;
 }
 
 // real construction (Init() must have been called before!)
 bool wxWindowX11::Create(wxWindow *parent, wxWindowID id,
     m_lastTS = 0;
     m_lastButton = 0;
 }
 
 // real construction (Init() must have been called before!)
 bool wxWindowX11::Create(wxWindow *parent, wxWindowID id,

-                      const wxPoint& pos,
-                      const wxSize& size,
-                      long style,
-                      const wxString& name)
+                         const wxPoint& pos,
+                         const wxSize& size,
+                         long style,
+                         const wxString& name)

 {
 {

-    wxCHECK_MSG( parent, FALSE, "can't create wxWindow without parent" );
+    wxCHECK_MSG( parent, false, wxT("can't create wxWindow without parent") );

 
     CreateBase(parent, id, pos, size, style, wxDefaultValidator, name);
 
     parent->AddChild(this);
 
 
     CreateBase(parent, id, pos, size, style, wxDefaultValidator, name);
 
     parent->AddChild(this);
 

-    int w = size.GetWidth();
-    int h = size.GetHeight();
-    int x = size.GetX();
-    int y = size.GetY();
-    if (w == -1) w = 20;
-    if (h == -1) h = 20;
-    if (x == -1) x = 0;
-    if (y == -1) y = 0;
-

     Display *xdisplay = (Display*) wxGlobalDisplay();
     int xscreen = DefaultScreen( xdisplay );
     Visual *xvisual = DefaultVisual( xdisplay, xscreen );
     Colormap cm = DefaultColormap( xdisplay, xscreen );
 
     m_backgroundColour = wxSystemSettings::GetColour(wxSYS_COLOUR_3DFACE);
     Display *xdisplay = (Display*) wxGlobalDisplay();
     int xscreen = DefaultScreen( xdisplay );
     Visual *xvisual = DefaultVisual( xdisplay, xscreen );
     Colormap cm = DefaultColormap( xdisplay, xscreen );
 
     m_backgroundColour = wxSystemSettings::GetColour(wxSYS_COLOUR_3DFACE);

-    m_backgroundColour.CalcPixel( (WXColormap) cm ); 
-    
+    m_backgroundColour.CalcPixel( (WXColormap) cm );
+

     m_foregroundColour = *wxBLACK;
     m_foregroundColour = *wxBLACK;

-    m_foregroundColour.CalcPixel( (WXColormap) cm ); 
+    m_foregroundColour.CalcPixel( (WXColormap) cm );
+
+    Window xparent = (Window) parent->GetClientAreaWindow();

 
 

-    Window xparent = (Window) parent->GetClientWindow();
-    

     // Add window's own scrollbars to main window, not to client window
     if (parent->GetInsertIntoMain())
     {
         // wxLogDebug( "Inserted into main: %s", GetName().c_str() );
         xparent = (Window) parent->GetMainWindow();
     }
     // Add window's own scrollbars to main window, not to client window
     if (parent->GetInsertIntoMain())
     {
         // wxLogDebug( "Inserted into main: %s", GetName().c_str() );
         xparent = (Window) parent->GetMainWindow();
     }

-    
+
+    // Size (not including the border) must be nonzero (or a Value error results)!
+    // Note: The Xlib manual doesn't mention this restriction of XCreateWindow.

     wxSize size2(size);
     wxSize size2(size);

-    if (size2.x == -1)
-       size2.x = 20;
-    if (size2.y == -1)
-       size2.y = 20;
+    if (size2.x <= 0)
+        size2.x = 20;
+    if (size2.y <= 0)
+        size2.y = 20;

 
     wxPoint pos2(pos);
 
     wxPoint pos2(pos);

-    if (pos2.x == -1)
-       pos2.x = 0;
-    if (pos2.y == -1)
-       pos2.y = 0;
-    
-#if !wxUSE_NANOX
+    if (pos2.x == wxDefaultCoord)
+        pos2.x = 0;
+    if (pos2.y == wxDefaultCoord)
+        pos2.y = 0;
+
+    AdjustForParentClientOrigin(pos2.x, pos2.y);

 
 #if wxUSE_TWO_WINDOWS
 
 #if wxUSE_TWO_WINDOWS

-    bool need_two_windows = 
+    bool need_two_windows =

         ((( wxSUNKEN_BORDER | wxRAISED_BORDER | wxSIMPLE_BORDER | wxHSCROLL | wxVSCROLL ) & m_windowStyle) != 0);
 #else
         ((( wxSUNKEN_BORDER | wxRAISED_BORDER | wxSIMPLE_BORDER | wxHSCROLL | wxVSCROLL ) & m_windowStyle) != 0);
 #else

-    bool need_two_windows = FALSE;
+    bool need_two_windows = false;

 #endif
 
 #endif
 

+#if wxUSE_NANOX
+    long xattributes = 0;
+#else

     XSetWindowAttributes xattributes;
     long xattributes_mask = 0;
     XSetWindowAttributes xattributes;
     long xattributes_mask = 0;

-    
+

     xattributes_mask |= CWBackPixel;
     xattributes.background_pixel = m_backgroundColour.GetPixel();
     xattributes_mask |= CWBackPixel;
     xattributes.background_pixel = m_backgroundColour.GetPixel();

-    
+

     xattributes_mask |= CWBorderPixel;
     xattributes.border_pixel = BlackPixel( xdisplay, xscreen );
     xattributes_mask |= CWBorderPixel;
     xattributes.border_pixel = BlackPixel( xdisplay, xscreen );

-    
+

     xattributes_mask |= CWEventMask;
     xattributes_mask |= CWEventMask;

-    
+#endif
+

     if (need_two_windows)
     {
     if (need_two_windows)
     {

-        xattributes.event_mask = 
+#if wxUSE_NANOX
+        long backColor, foreColor;
+        backColor = GR_RGB(m_backgroundColour.Red(), m_backgroundColour.Green(), m_backgroundColour.Blue());
+        foreColor = GR_RGB(m_foregroundColour.Red(), m_foregroundColour.Green(), m_foregroundColour.Blue());
+
+        Window xwindow = XCreateWindowWithColor( xdisplay, xparent, pos2.x, pos2.y, size2.x, size2.y,
+                                    0, 0, InputOutput, xvisual, backColor, foreColor);
+        XSelectInput( xdisplay, xwindow,
+          GR_EVENT_MASK_CLOSE_REQ | ExposureMask | KeyPressMask | KeyReleaseMask | ButtonPressMask | ButtonReleaseMask |
+          ButtonMotionMask | EnterWindowMask | LeaveWindowMask | PointerMotionMask |
+          KeymapStateMask | FocusChangeMask | ColormapChangeMask | StructureNotifyMask |
+                      PropertyChangeMask );
+
+#else
+        // Normal X11
+        xattributes.event_mask =

             ExposureMask | StructureNotifyMask | ColormapChangeMask;
 
             ExposureMask | StructureNotifyMask | ColormapChangeMask;
 

-        Window xwindow = XCreateWindow( xdisplay, xparent, pos2.x, pos2.y, size2.x, size2.y, 
+        Window xwindow = XCreateWindow( xdisplay, xparent, pos2.x, pos2.y, size2.x, size2.y,

             0, DefaultDepth(xdisplay,xscreen), InputOutput, xvisual, xattributes_mask, &xattributes );
             0, DefaultDepth(xdisplay,xscreen), InputOutput, xvisual, xattributes_mask, &xattributes );

-    
+
+#endif
+

         XSetWindowBackgroundPixmap( xdisplay, xwindow, None );
         XSetWindowBackgroundPixmap( xdisplay, xwindow, None );

-    
+

         m_mainWindow = (WXWindow) xwindow;
         wxAddWindowToTable( xwindow, (wxWindow*) this );
         m_mainWindow = (WXWindow) xwindow;
         wxAddWindowToTable( xwindow, (wxWindow*) this );

-    
+

         XMapWindow( xdisplay, xwindow );
         XMapWindow( xdisplay, xwindow );

-    
-        xattributes.event_mask = 
+
+#if !wxUSE_NANOX
+        xattributes.event_mask =

             ExposureMask | KeyPressMask | KeyReleaseMask | ButtonPressMask | ButtonReleaseMask |
             ButtonMotionMask | EnterWindowMask | LeaveWindowMask | PointerMotionMask |
             KeymapStateMask | FocusChangeMask | ColormapChangeMask | StructureNotifyMask |
             PropertyChangeMask | VisibilityChangeMask ;
 
             ExposureMask | KeyPressMask | KeyReleaseMask | ButtonPressMask | ButtonReleaseMask |
             ButtonMotionMask | EnterWindowMask | LeaveWindowMask | PointerMotionMask |
             KeymapStateMask | FocusChangeMask | ColormapChangeMask | StructureNotifyMask |
             PropertyChangeMask | VisibilityChangeMask ;
 

-        if (HasFlag( wxNO_FULL_REPAINT_ON_RESIZE ))
+        if (!HasFlag( wxFULL_REPAINT_ON_RESIZE ))

         {
             xattributes_mask |= CWBitGravity;
             xattributes.bit_gravity = StaticGravity;
         }
         {
             xattributes_mask |= CWBitGravity;
             xattributes.bit_gravity = StaticGravity;
         }

+#endif

 
         if (HasFlag( wxSUNKEN_BORDER) || HasFlag( wxRAISED_BORDER))
         {
 
         if (HasFlag( wxSUNKEN_BORDER) || HasFlag( wxRAISED_BORDER))
         {


@@ -221,82 +236,94 @@ bool wxWindowX11::Create(wxWindow *parent, wxWindowID id,
             pos2.y = 2;
             size2.x -= 4;
             size2.y -= 4;
             pos2.y = 2;
             size2.x -= 4;
             size2.y -= 4;

-        } else
-        if (HasFlag( wxSIMPLE_BORDER ))
+        }
+        else if (HasFlag( wxSIMPLE_BORDER ))

         {
             pos2.x = 1;
             pos2.y = 1;
             size2.x -= 2;
             size2.y -= 2;
         {
             pos2.x = 1;
             pos2.y = 1;
             size2.x -= 2;
             size2.y -= 2;

-        } else
+        }
+        else

         {
             pos2.x = 0;
             pos2.y = 0;
         }
         {
             pos2.x = 0;
             pos2.y = 0;
         }

-        
-        xwindow = XCreateWindow( xdisplay, xwindow, pos2.x, pos2.y, size2.x, size2.y, 
+
+        // Make again sure the size is nonzero.
+        if (size2.x <= 0)
+            size2.x = 1;
+        if (size2.y <= 0)
+            size2.y = 1;
+
+#if wxUSE_NANOX
+        backColor = GR_RGB(m_backgroundColour.Red(), m_backgroundColour.Green(), m_backgroundColour.Blue());
+        foreColor = GR_RGB(m_foregroundColour.Red(), m_foregroundColour.Green(), m_foregroundColour.Blue());
+
+        xwindow = XCreateWindowWithColor( xdisplay, xwindow, pos2.x, pos2.y, size2.x, size2.y,
+                                    0, 0, InputOutput, xvisual, backColor, foreColor);
+        XSelectInput( xdisplay, xwindow,
+          GR_EVENT_MASK_CLOSE_REQ | ExposureMask | KeyPressMask | KeyReleaseMask | ButtonPressMask | ButtonReleaseMask |
+          ButtonMotionMask | EnterWindowMask | LeaveWindowMask | PointerMotionMask |
+          KeymapStateMask | FocusChangeMask | ColormapChangeMask | StructureNotifyMask |
+                      PropertyChangeMask );
+
+#else
+        xwindow = XCreateWindow( xdisplay, xwindow, pos2.x, pos2.y, size2.x, size2.y,

             0, DefaultDepth(xdisplay,xscreen), InputOutput, xvisual, xattributes_mask, &xattributes );
             0, DefaultDepth(xdisplay,xscreen), InputOutput, xvisual, xattributes_mask, &xattributes );

-    
+#endif
+

         XSetWindowBackgroundPixmap( xdisplay, xwindow, None );
         XSetWindowBackgroundPixmap( xdisplay, xwindow, None );

-    
+

         m_clientWindow = (WXWindow) xwindow;
         wxAddClientWindowToTable( xwindow, (wxWindow*) this );
         m_clientWindow = (WXWindow) xwindow;
         wxAddClientWindowToTable( xwindow, (wxWindow*) this );

-        
+

         XMapWindow( xdisplay, xwindow );
     }
     else
     {
         // wxLogDebug( "No two windows needed %s", GetName().c_str() );
         XMapWindow( xdisplay, xwindow );
     }
     else
     {
         // wxLogDebug( "No two windows needed %s", GetName().c_str() );

-    
-        xattributes.event_mask = 
+#if wxUSE_NANOX
+        long backColor, foreColor;
+        backColor = GR_RGB(m_backgroundColour.Red(), m_backgroundColour.Green(), m_backgroundColour.Blue());
+        foreColor = GR_RGB(m_foregroundColour.Red(), m_foregroundColour.Green(), m_foregroundColour.Blue());
+
+        Window xwindow = XCreateWindowWithColor( xdisplay, xparent, pos2.x, pos2.y, size2.x, size2.y,
+                                    0, 0, InputOutput, xvisual, backColor, foreColor);
+        XSelectInput( xdisplay, xwindow,
+          GR_EVENT_MASK_CLOSE_REQ | ExposureMask | KeyPressMask | KeyReleaseMask | ButtonPressMask | ButtonReleaseMask |
+          ButtonMotionMask | EnterWindowMask | LeaveWindowMask | PointerMotionMask |
+          KeymapStateMask | FocusChangeMask | ColormapChangeMask | StructureNotifyMask |
+                      PropertyChangeMask );
+
+#else
+        xattributes.event_mask =

             ExposureMask | KeyPressMask | KeyReleaseMask | ButtonPressMask | ButtonReleaseMask |
             ButtonMotionMask | EnterWindowMask | LeaveWindowMask | PointerMotionMask |
             KeymapStateMask | FocusChangeMask | ColormapChangeMask | StructureNotifyMask |
             PropertyChangeMask | VisibilityChangeMask ;
 
             ExposureMask | KeyPressMask | KeyReleaseMask | ButtonPressMask | ButtonReleaseMask |
             ButtonMotionMask | EnterWindowMask | LeaveWindowMask | PointerMotionMask |
             KeymapStateMask | FocusChangeMask | ColormapChangeMask | StructureNotifyMask |
             PropertyChangeMask | VisibilityChangeMask ;
 

-        if (HasFlag( wxNO_FULL_REPAINT_ON_RESIZE ))
+        if (!HasFlag( wxFULL_REPAINT_ON_RESIZE ))

         {
             xattributes_mask |= CWBitGravity;
             xattributes.bit_gravity = NorthWestGravity;
         }
 
         {
             xattributes_mask |= CWBitGravity;
             xattributes.bit_gravity = NorthWestGravity;
         }
 

-        Window xwindow = XCreateWindow( xdisplay, xparent, pos2.x, pos2.y, size2.x, size2.y, 
+        Window xwindow = XCreateWindow( xdisplay, xparent, pos2.x, pos2.y, size2.x, size2.y,

             0, DefaultDepth(xdisplay,xscreen), InputOutput, xvisual, xattributes_mask, &xattributes );
             0, DefaultDepth(xdisplay,xscreen), InputOutput, xvisual, xattributes_mask, &xattributes );

-            
+#endif
+

         XSetWindowBackgroundPixmap( xdisplay, xwindow, None );
         XSetWindowBackgroundPixmap( xdisplay, xwindow, None );

-    
+

         m_mainWindow = (WXWindow) xwindow;
         m_clientWindow = m_mainWindow;
         wxAddWindowToTable( xwindow, (wxWindow*) this );
         m_mainWindow = (WXWindow) xwindow;
         m_clientWindow = m_mainWindow;
         wxAddWindowToTable( xwindow, (wxWindow*) this );

-        
+

         XMapWindow( xdisplay, xwindow );
     }
         XMapWindow( xdisplay, xwindow );
     }

-#else
-
-    int extraFlags = GR_EVENT_MASK_CLOSE_REQ;
-
-    long backColor, foreColor;
-    backColor = GR_RGB(m_backgroundColour.Red(), m_backgroundColour.Green(), m_backgroundColour.Blue());
-    foreColor = GR_RGB(m_foregroundColour.Red(), m_foregroundColour.Green(), m_foregroundColour.Blue());
-    
-    Window xwindow = XCreateWindowWithColor( xdisplay, xparent, pos2.x, pos2.y, size2.x, size2.y, 
-                                    0, 0, InputOutput, xvisual, backColor, foreColor);
-    XSelectInput( xdisplay, xwindow,
-        extraFlags | ExposureMask | KeyPressMask | KeyReleaseMask | ButtonPressMask | ButtonReleaseMask |
-        ButtonMotionMask | EnterWindowMask | LeaveWindowMask | PointerMotionMask |
-        KeymapStateMask | FocusChangeMask | ColormapChangeMask | StructureNotifyMask |
-        PropertyChangeMask );
-    
-    XSetWindowBackgroundPixmap( xdisplay, xwindow, None );
-    
-    m_mainWindow = (WXWindow) xwindow;
-    wxAddWindowToTable( xwindow, (wxWindow*) this );
-    
-    XMapWindow( xdisplay, xwindow );
-#endif

 
     // Is a subwindow, so map immediately
 
     // Is a subwindow, so map immediately

-    m_isShown = TRUE;
+    m_isShown = true;

 
     // Without this, the cursor may not be restored properly (e.g. in splitter
     // sample).
 
     // Without this, the cursor may not be restored properly (e.g. in splitter
     // sample).


@@ -307,19 +334,18 @@ bool wxWindowX11::Create(wxWindow *parent, wxWindowID id,
     // for example
     //    SetSize(pos.x, pos.y, size.x, size.y);
 
     // for example
     //    SetSize(pos.x, pos.y, size.x, size.y);
 

-    return TRUE;
+    return true;

 }
 
 // Destructor
 wxWindowX11::~wxWindowX11()
 {
 }
 
 // Destructor
 wxWindowX11::~wxWindowX11()
 {

+    SendDestroyEvent();
+

     if (g_captureWindow == this)
     if (g_captureWindow == this)

-       g_captureWindow = NULL;
-    
-    m_isBeingDeleted = TRUE;
-    
-    if (m_parent)
-        m_parent->RemoveChild( this );
+        g_captureWindow = NULL;
+
+    m_isBeingDeleted = true;

 
     DestroyChildren();
 
 
     DestroyChildren();
 


@@ -331,12 +357,15 @@ wxWindowX11::~wxWindowX11()
         XDestroyWindow( wxGlobalDisplay(), xwindow );
         m_clientWindow = NULL;
     }
         XDestroyWindow( wxGlobalDisplay(), xwindow );
         m_clientWindow = NULL;
     }

-        
+

     // Destroy the window
     // Destroy the window

-    Window xwindow = (Window) m_mainWindow;
-    wxDeleteWindowFromTable( xwindow );
-    XDestroyWindow( wxGlobalDisplay(), xwindow );
-    m_mainWindow = NULL;
+    if ( m_mainWindow )
+    {
+        Window xwindow = (Window) m_mainWindow;
+        wxDeleteWindowFromTable( xwindow );
+        XDestroyWindow( wxGlobalDisplay(), xwindow );
+        m_mainWindow = NULL;
+    }

 }
 
 // ---------------------------------------------------------------------------
 }
 
 // ---------------------------------------------------------------------------


@@ -346,11 +375,15 @@ wxWindowX11::~wxWindowX11()
 void wxWindowX11::SetFocus()
 {
     Window xwindow = (Window) m_clientWindow;
 void wxWindowX11::SetFocus()
 {
     Window xwindow = (Window) m_clientWindow;

-    
+

     wxCHECK_RET( xwindow, wxT("invalid window") );
     wxCHECK_RET( xwindow, wxT("invalid window") );

-    
-    wxCHECK_RET( AcceptsFocus(), wxT("set focus on window that doesn't accept the focus") );
-    
+
+    // Don't assert; we might be trying to set the focus for a panel
+    // with only static controls, so the panel returns false from AcceptsFocus.
+    // The app should be not be expected to deal with this.
+    if (!AcceptsFocus())
+        return;
+

 #if 0
     if (GetName() == "scrollBar")
     {
 #if 0
     if (GetName() == "scrollBar")
     {


@@ -358,20 +391,22 @@ void wxWindowX11::SetFocus()
         *crash = 0;
     }
 #endif
         *crash = 0;
     }
 #endif

-    
+

     if (wxWindowIsVisible(xwindow))
     {
     if (wxWindowIsVisible(xwindow))
     {

-        XSetInputFocus( wxGlobalDisplay(), xwindow, RevertToParent, CurrentTime );
-        m_needsInputFocus = FALSE;
+        wxLogTrace( _T("focus"), _T("wxWindowX11::SetFocus: %s"), GetClassInfo()->GetClassName());
+        //        XSetInputFocus( wxGlobalDisplay(), xwindow, RevertToParent, CurrentTime );
+        XSetInputFocus( wxGlobalDisplay(), xwindow, RevertToNone, CurrentTime );
+        m_needsInputFocus = false;

     }
     else
     {
     }
     else
     {

-        m_needsInputFocus = TRUE;
+        m_needsInputFocus = true;

     }
 }
 
 // Get the window with the focus
     }
 }
 
 // Get the window with the focus

-wxWindow *wxWindowBase::FindFocus()
+wxWindow *wxWindowBase::DoFindFocus()

 {
     Window xfocus = (Window) 0;
     int revert = 0;
 {
     Window xfocus = (Window) 0;
     int revert = 0;


@@ -396,9 +431,9 @@ wxWindow *wxWindowBase::FindFocus()
 bool wxWindowX11::Enable(bool enable)
 {
     if ( !wxWindowBase::Enable(enable) )
 bool wxWindowX11::Enable(bool enable)
 {
     if ( !wxWindowBase::Enable(enable) )

-        return FALSE;
-   
-    return TRUE;
+        return false;
+
+    return true;

 }
 
 bool wxWindowX11::Show(bool show)
 }
 
 bool wxWindowX11::Show(bool show)


@@ -418,7 +453,7 @@ bool wxWindowX11::Show(bool show)
         XUnmapWindow(xdisp, xwindow);
     }
 
         XUnmapWindow(xdisp, xwindow);
     }
 

-    return TRUE;
+    return true;

 }
 
 // Raise the window to the top of the Z order
 }
 
 // Raise the window to the top of the Z order


@@ -435,25 +470,36 @@ void wxWindowX11::Lower()
         XLowerWindow( wxGlobalDisplay(), (Window) m_mainWindow );
 }
 
         XLowerWindow( wxGlobalDisplay(), (Window) m_mainWindow );
 }
 

+void wxWindowX11::SetLabel(const wxString& WXUNUSED(label))
+{
+    // TODO
+}
+
+wxString wxWindowX11::GetLabel() const
+{
+    // TODO
+    return wxEmptyString;
+}
+

 void wxWindowX11::DoCaptureMouse()
 {
     if ((g_captureWindow != NULL) && (g_captureWindow != this))
     {
 void wxWindowX11::DoCaptureMouse()
 {
     if ((g_captureWindow != NULL) && (g_captureWindow != this))
     {

-        wxASSERT_MSG(FALSE, "Trying to capture before mouse released.");
+        wxFAIL_MSG(wxT("Trying to capture before mouse released."));

 
         // Core dump now
         int *tmp = NULL;
         (*tmp) = 1;
         return;
     }
 
         // Core dump now
         int *tmp = NULL;
         (*tmp) = 1;
         return;
     }

-    
+

     if (m_winCaptured)
         return;
 
     Window xwindow = (Window) m_clientWindow;
 
     wxCHECK_RET( xwindow, wxT("invalid window") );
     if (m_winCaptured)
         return;
 
     Window xwindow = (Window) m_clientWindow;
 
     wxCHECK_RET( xwindow, wxT("invalid window") );

-    
+

     g_captureWindow = (wxWindow*) this;
 
     if (xwindow)
     g_captureWindow = (wxWindow*) this;
 
     if (xwindow)


@@ -462,7 +508,7 @@ void wxWindowX11::DoCaptureMouse()
             FALSE,
             ButtonPressMask | ButtonReleaseMask | ButtonMotionMask | EnterWindowMask | LeaveWindowMask | PointerMotionMask,
             GrabModeAsync,
             FALSE,
             ButtonPressMask | ButtonReleaseMask | ButtonMotionMask | EnterWindowMask | LeaveWindowMask | PointerMotionMask,
             GrabModeAsync,

-               GrabModeAsync,
+            GrabModeAsync,

             None,
             None, /* cursor */ // TODO: This may need to be set to the cursor of this window
             CurrentTime );
             None,
             None, /* cursor */ // TODO: This may need to be set to the cursor of this window
             CurrentTime );


@@ -470,24 +516,23 @@ void wxWindowX11::DoCaptureMouse()
         if (res != GrabSuccess)
         {
             wxString msg;
         if (res != GrabSuccess)
         {
             wxString msg;

-            msg.Printf("Failed to grab pointer for window %s", this->GetClassInfo()->GetClassName());
+            msg.Printf(wxT("Failed to grab pointer for window %s"), this->GetClassInfo()->GetClassName());

             wxLogDebug(msg);
             if (res == GrabNotViewable)
             wxLogDebug(msg);
             if (res == GrabNotViewable)

-            {
-                wxLogDebug("This is not a viewable window - perhaps not shown yet?");
-            }
+                wxLogDebug( wxT("This is not a viewable window - perhaps not shown yet?") );
+

             g_captureWindow = NULL;
             return;
         }
 
             g_captureWindow = NULL;
             return;
         }
 

-        m_winCaptured = TRUE;
+        m_winCaptured = true;

     }
 }
 
 void wxWindowX11::DoReleaseMouse()
 {
     g_captureWindow = NULL;
     }
 }
 
 void wxWindowX11::DoReleaseMouse()
 {
     g_captureWindow = NULL;

-    
+

     if ( !m_winCaptured )
         return;
 
     if ( !m_winCaptured )
         return;
 


@@ -497,10 +542,10 @@ void wxWindowX11::DoReleaseMouse()
     {
         XUngrabPointer( wxGlobalDisplay(), CurrentTime );
     }
     {
         XUngrabPointer( wxGlobalDisplay(), CurrentTime );
     }

-    
+

     // wxLogDebug( "Ungrabbed pointer in %s", GetName().c_str() );
 
     // wxLogDebug( "Ungrabbed pointer in %s", GetName().c_str() );
 

-    m_winCaptured = FALSE;
+    m_winCaptured = false;

 }
 
 bool wxWindowX11::SetFont(const wxFont& font)
 }
 
 bool wxWindowX11::SetFont(const wxFont& font)


@@ -508,10 +553,10 @@ bool wxWindowX11::SetFont(const wxFont& font)
     if ( !wxWindowBase::SetFont(font) )
     {
         // nothing to do
     if ( !wxWindowBase::SetFont(font) )
     {
         // nothing to do

-        return FALSE;
+        return false;

     }
 
     }
 

-    return TRUE;
+    return true;

 }
 
 bool wxWindowX11::SetCursor(const wxCursor& cursor)
 }
 
 bool wxWindowX11::SetCursor(const wxCursor& cursor)


@@ -519,13 +564,13 @@ bool wxWindowX11::SetCursor(const wxCursor& cursor)
     if ( !wxWindowBase::SetCursor(cursor) )
     {
         // no change
     if ( !wxWindowBase::SetCursor(cursor) )
     {
         // no change

-        return FALSE;
+        return false;

     }
 
     Window xwindow = (Window) m_clientWindow;
 
     }
 
     Window xwindow = (Window) m_clientWindow;
 

-    wxCHECK_MSG( xwindow, FALSE, wxT("invalid window") );
-    
+    wxCHECK_MSG( xwindow, false, wxT("invalid window") );
+

     wxCursor cursorToUse;
     if (m_cursor.Ok())
         cursorToUse = m_cursor;
     wxCursor cursorToUse;
     if (m_cursor.Ok())
         cursorToUse = m_cursor;


@@ -536,7 +581,7 @@ bool wxWindowX11::SetCursor(const wxCursor& cursor)
 
     XDefineCursor( wxGlobalDisplay(), xwindow, xcursor );
 
 
     XDefineCursor( wxGlobalDisplay(), xwindow, xcursor );
 

-    return TRUE;
+    return true;

 }
 
 // Coordinates relative to the window
 }
 
 // Coordinates relative to the window


@@ -545,7 +590,7 @@ void wxWindowX11::WarpPointer (int x, int y)
     Window xwindow = (Window) m_clientWindow;
 
     wxCHECK_RET( xwindow, wxT("invalid window") );
     Window xwindow = (Window) m_clientWindow;
 
     wxCHECK_RET( xwindow, wxT("invalid window") );

-    
+

     XWarpPointer( wxGlobalDisplay(), None, xwindow, 0, 0, 0, 0, x, y);
 }
 
     XWarpPointer( wxGlobalDisplay(), None, xwindow, 0, 0, 0, 0, x, y);
 }
 


@@ -554,28 +599,28 @@ void wxWindowX11::ScrollWindow(int dx, int dy, const wxRect *rect)
 {
     // No scrolling requested.
     if ((dx == 0) && (dy == 0)) return;
 {
     // No scrolling requested.
     if ((dx == 0) && (dy == 0)) return;

-    
+

     if (!m_updateRegion.IsEmpty())
     {
         m_updateRegion.Offset( dx, dy );
     if (!m_updateRegion.IsEmpty())
     {
         m_updateRegion.Offset( dx, dy );

-        
+

         int cw = 0;
         int ch = 0;
         GetSize( &cw, &ch );  // GetClientSize() ??
         m_updateRegion.Intersect( 0, 0, cw, ch );
     }
         int cw = 0;
         int ch = 0;
         GetSize( &cw, &ch );  // GetClientSize() ??
         m_updateRegion.Intersect( 0, 0, cw, ch );
     }

-    
+

     if (!m_clearRegion.IsEmpty())
     {
         m_clearRegion.Offset( dx, dy );
     if (!m_clearRegion.IsEmpty())
     {
         m_clearRegion.Offset( dx, dy );

-        
+

         int cw = 0;
         int ch = 0;
         GetSize( &cw, &ch );  // GetClientSize() ??
         m_clearRegion.Intersect( 0, 0, cw, ch );
     }
         int cw = 0;
         int ch = 0;
         GetSize( &cw, &ch );  // GetClientSize() ??
         m_clearRegion.Intersect( 0, 0, cw, ch );
     }

-    
-    Window xwindow = (Window) GetClientWindow();
+
+    Window xwindow = (Window) GetClientAreaWindow();

 
     wxCHECK_RET( xwindow, wxT("invalid window") );
 
 
     wxCHECK_RET( xwindow, wxT("invalid window") );
 


@@ -592,7 +637,7 @@ void wxWindowX11::ScrollWindow(int dx, int dy, const wxRect *rect)
     {
         s_x = rect->x;
         s_y = rect->y;
     {
         s_x = rect->x;
         s_y = rect->y;

-        
+

         cw = rect->width;
         ch = rect->height;
     }
         cw = rect->width;
         ch = rect->height;
     }


@@ -602,7 +647,7 @@ void wxWindowX11::ScrollWindow(int dx, int dy, const wxRect *rect)
         s_y = 0;
         GetClientSize( &cw, &ch );
     }
         s_y = 0;
         GetClientSize( &cw, &ch );
     }

-    
+

 #if wxUSE_TWO_WINDOWS
     wxPoint offset( 0,0 );
 #else
 #if wxUSE_TWO_WINDOWS
     wxPoint offset( 0,0 );
 #else


@@ -610,10 +655,10 @@ void wxWindowX11::ScrollWindow(int dx, int dy, const wxRect *rect)
     s_x += offset.x;
     s_y += offset.y;
 #endif
     s_x += offset.x;
     s_y += offset.y;
 #endif

-        
+

     int w = cw - abs(dx);
     int h = ch - abs(dy);
     int w = cw - abs(dx);
     int h = ch - abs(dy);

-        
+

     if ((h < 0) || (w < 0))
     {
         Refresh();
     if ((h < 0) || (w < 0))
     {
         Refresh();


@@ -625,17 +670,17 @@ void wxWindowX11::ScrollWindow(int dx, int dy, const wxRect *rect)
         if (dy < 0) rect.y = ch+dy + offset.y; else rect.y = s_y;
         if (dy != 0) rect.width = cw; else rect.width = abs(dx);
         if (dx != 0) rect.height = ch; else rect.height = abs(dy);
         if (dy < 0) rect.y = ch+dy + offset.y; else rect.y = s_y;
         if (dy != 0) rect.width = cw; else rect.width = abs(dx);
         if (dx != 0) rect.height = ch; else rect.height = abs(dy);

-    
+

         int d_x = s_x;
         int d_y = s_y;
         int d_x = s_x;
         int d_y = s_y;

-        
+

         if (dx < 0) s_x += -dx;
         if (dy < 0) s_y += -dy;
         if (dx > 0) d_x = dx + offset.x;
         if (dy > 0) d_y = dy + offset.y;
 
         XCopyArea( xdisplay, xwindow, xwindow, xgc, s_x, s_y, w, h, d_x, d_y );
         if (dx < 0) s_x += -dx;
         if (dy < 0) s_y += -dy;
         if (dx > 0) d_x = dx + offset.x;
         if (dy > 0) d_y = dy + offset.y;
 
         XCopyArea( xdisplay, xwindow, xwindow, xgc, s_x, s_y, w, h, d_x, d_y );

-        
+

         // wxLogDebug( "Copy: s_x %d s_y %d w %d h %d d_x %d d_y %d", s_x, s_y, w, h, d_x, d_y );
 
         // wxLogDebug( "Update: %d %d %d %d", rect.x, rect.y, rect.width, rect.height );
         // wxLogDebug( "Copy: s_x %d s_y %d w %d h %d d_x %d d_y %d", s_x, s_y, w, h, d_x, d_y );
 
         // wxLogDebug( "Update: %d %d %d %d", rect.x, rect.y, rect.width, rect.height );


@@ -643,8 +688,28 @@ void wxWindowX11::ScrollWindow(int dx, int dy, const wxRect *rect)
         m_updateRegion.Union( rect );
         m_clearRegion.Union( rect );
     }
         m_updateRegion.Union( rect );
         m_clearRegion.Union( rect );
     }

-    
+

     XFreeGC( xdisplay, xgc );
     XFreeGC( xdisplay, xgc );

+
+    // Move Clients, but not the scrollbars
+    // FIXME: There may be a better method to move a lot of Windows within X11
+    wxScrollBar *sbH = ((wxWindow *) this)->GetScrollbar( wxHORIZONTAL );
+    wxScrollBar *sbV = ((wxWindow *) this)->GetScrollbar( wxVERTICAL );
+    wxWindowList::compatibility_iterator node = GetChildren().GetFirst();
+    while ( node )
+    {
+        // Only propagate to non-top-level windows
+        wxWindow *win = node->GetData();
+        if ( win->GetParent() && win != sbH && win != sbV )
+        {
+            wxPoint pos = win->GetPosition();
+            // Add the delta to the old Position
+            pos.x += dx;
+            pos.y += dy;
+            win->SetPosition(pos);
+        }
+        node = node->GetNext();
+    }

 }
 
 // ---------------------------------------------------------------------------
 }
 
 // ---------------------------------------------------------------------------


@@ -685,7 +750,7 @@ void wxWindowX11::DoSetToolTip(wxToolTip * WXUNUSED(tooltip))
 
 bool wxWindowX11::PreResize()
 {
 
 bool wxWindowX11::PreResize()
 {

-    return TRUE;
+    return true;

 }
 
 // Get total size
 }
 
 // Get total size


@@ -694,13 +759,13 @@ void wxWindowX11::DoGetSize(int *x, int *y) const
     Window xwindow = (Window) m_mainWindow;
 
     wxCHECK_RET( xwindow, wxT("invalid window") );
     Window xwindow = (Window) m_mainWindow;
 
     wxCHECK_RET( xwindow, wxT("invalid window") );

-    
+

     //XSync(wxGlobalDisplay(), False);
 
     XWindowAttributes attr;
     Status status = XGetWindowAttributes( wxGlobalDisplay(), xwindow, &attr );
     wxASSERT(status);
     //XSync(wxGlobalDisplay(), False);
 
     XWindowAttributes attr;
     Status status = XGetWindowAttributes( wxGlobalDisplay(), xwindow, &attr );
     wxASSERT(status);

-        
+

     if (status)
     {
         *x = attr.width /* + 2*m_borderSize */ ;
     if (status)
     {
         *x = attr.width /* + 2*m_borderSize */ ;


@@ -717,12 +782,12 @@ void wxWindowX11::DoGetPosition(int *x, int *y) const
         XWindowAttributes attr;
         Status status = XGetWindowAttributes(wxGlobalDisplay(), window, & attr);
         wxASSERT(status);
         XWindowAttributes attr;
         Status status = XGetWindowAttributes(wxGlobalDisplay(), window, & attr);
         wxASSERT(status);

-        
+

         if (status)
         {
             *x = attr.x;
             *y = attr.y;
         if (status)
         {
             *x = attr.x;
             *y = attr.y;

-            
+

             // We may be faking the client origin. So a window that's really at (0, 30)
             // may appear (to wxWin apps) to be at (0, 0).
             if (GetParent())
             // We may be faking the client origin. So a window that's really at (0, 30)
             // may appear (to wxWin apps) to be at (0, 0).
             if (GetParent())


@@ -742,9 +807,11 @@ void wxWindowX11::DoScreenToClient(int *x, int *y) const
     Window thisWindow = (Window) m_clientWindow;
 
     Window childWindow;
     Window thisWindow = (Window) m_clientWindow;
 
     Window childWindow;

-    int xx = *x;
-    int yy = *y;
-    XTranslateCoordinates(display, rootWindow, thisWindow, xx, yy, x, y, &childWindow);
+    int xx = x ? *x : 0;
+    int yy = y ? *y : 0;
+    XTranslateCoordinates(display, rootWindow, thisWindow,
+                          xx, yy, x ? x : &xx, y ? y : &yy,
+                          &childWindow);

 }
 
 void wxWindowX11::DoClientToScreen(int *x, int *y) const
 }
 
 void wxWindowX11::DoClientToScreen(int *x, int *y) const


@@ -754,9 +821,11 @@ void wxWindowX11::DoClientToScreen(int *x, int *y) const
     Window thisWindow = (Window) m_clientWindow;
 
     Window childWindow;
     Window thisWindow = (Window) m_clientWindow;
 
     Window childWindow;

-    int xx = *x;
-    int yy = *y;
-    XTranslateCoordinates(display, thisWindow, rootWindow, xx, yy, x, y, &childWindow);
+    int xx = x ? *x : 0;
+    int yy = y ? *y : 0;
+    XTranslateCoordinates(display, thisWindow, rootWindow,
+                          xx, yy, x ? x : &xx, y ? y : &yy,
+                          &childWindow);

 }
 
 
 }
 
 


@@ -770,7 +839,7 @@ void wxWindowX11::DoGetClientSize(int *x, int *y) const
         XWindowAttributes attr;
         Status status = XGetWindowAttributes( wxGlobalDisplay(), window, &attr );
         wxASSERT(status);
         XWindowAttributes attr;
         Status status = XGetWindowAttributes( wxGlobalDisplay(), window, &attr );
         wxASSERT(status);

-        
+

         if (status)
         {
             *x = attr.width ;
         if (status)
         {
             *x = attr.width ;


@@ -782,7 +851,7 @@ void wxWindowX11::DoGetClientSize(int *x, int *y) const
 void wxWindowX11::DoSetSize(int x, int y, int width, int height, int sizeFlags)
 {
     //    wxLogDebug("DoSetSize: %s (%ld) %d, %d %dx%d", GetClassInfo()->GetClassName(), GetId(), x, y, width, height);
 void wxWindowX11::DoSetSize(int x, int y, int width, int height, int sizeFlags)
 {
     //    wxLogDebug("DoSetSize: %s (%ld) %d, %d %dx%d", GetClassInfo()->GetClassName(), GetId(), x, y, width, height);

-    
+

     Window xwindow = (Window) m_mainWindow;
 
     wxCHECK_RET( xwindow, wxT("invalid window") );
     Window xwindow = (Window) m_mainWindow;
 
     wxCHECK_RET( xwindow, wxT("invalid window") );


@@ -790,54 +859,54 @@ void wxWindowX11::DoSetSize(int x, int y, int width, int height, int sizeFlags)
     XWindowAttributes attr;
     Status status = XGetWindowAttributes( wxGlobalDisplay(), xwindow, &attr );
     wxCHECK_RET( status, wxT("invalid window attributes") );
     XWindowAttributes attr;
     Status status = XGetWindowAttributes( wxGlobalDisplay(), xwindow, &attr );
     wxCHECK_RET( status, wxT("invalid window attributes") );

-        
+

     int new_x = attr.x;
     int new_y = attr.y;
     int new_w = attr.width;
     int new_h = attr.height;
     int new_x = attr.x;
     int new_y = attr.y;
     int new_w = attr.width;
     int new_h = attr.height;

-    
-    if (x != -1 || (sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
+
+    if (x != wxDefaultCoord || (sizeFlags & wxSIZE_ALLOW_MINUS_ONE))

     {
         int yy = 0;
         AdjustForParentClientOrigin( x, yy, sizeFlags);
         new_x = x;
     }
     {
         int yy = 0;
         AdjustForParentClientOrigin( x, yy, sizeFlags);
         new_x = x;
     }

-    if (y != -1 || (sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
+    if (y != wxDefaultCoord || (sizeFlags & wxSIZE_ALLOW_MINUS_ONE))

     {
         int xx = 0;
         AdjustForParentClientOrigin( xx, y, sizeFlags);
         new_y = y;
     }
     {
         int xx = 0;
         AdjustForParentClientOrigin( xx, y, sizeFlags);
         new_y = y;
     }

-    if (width != -1)
+    if (width != wxDefaultCoord)

     {
         new_w = width;
         if (new_w <= 0)
             new_w = 20;
     }
     {
         new_w = width;
         if (new_w <= 0)
             new_w = 20;
     }

-    if (height != -1)
+    if (height != wxDefaultCoord)

     {
         new_h = height;
         if (new_h <= 0)
             new_h = 20;
     }
     {
         new_h = height;
         if (new_h <= 0)
             new_h = 20;
     }

-    
+

     DoMoveWindow( new_x, new_y, new_w, new_h );
 }
 
 void wxWindowX11::DoSetClientSize(int width, int height)
 {
     //    wxLogDebug("DoSetClientSize: %s (%ld) %dx%d", GetClassInfo()->GetClassName(), GetId(), width, height);
     DoMoveWindow( new_x, new_y, new_w, new_h );
 }
 
 void wxWindowX11::DoSetClientSize(int width, int height)
 {
     //    wxLogDebug("DoSetClientSize: %s (%ld) %dx%d", GetClassInfo()->GetClassName(), GetId(), width, height);

-    
+

     Window xwindow = (Window) m_mainWindow;
 
     wxCHECK_RET( xwindow, wxT("invalid window") );
 
     XResizeWindow( wxGlobalDisplay(), xwindow, width, height );
     Window xwindow = (Window) m_mainWindow;
 
     wxCHECK_RET( xwindow, wxT("invalid window") );
 
     XResizeWindow( wxGlobalDisplay(), xwindow, width, height );

-    
+

     if (m_mainWindow != m_clientWindow)
     {
         xwindow = (Window) m_clientWindow;
     if (m_mainWindow != m_clientWindow)
     {
         xwindow = (Window) m_clientWindow;

-        
+

         wxWindow *window = (wxWindow*) this;
         wxRenderer *renderer = window->GetRenderer();
         if (renderer)
         wxWindow *window = (wxWindow*) this;
         wxRenderer *renderer = window->GetRenderer();
         if (renderer)


@@ -846,18 +915,11 @@ void wxWindowX11::DoSetClientSize(int width, int height)
             width -= border.x + border.width;
             height -= border.y + border.height;
         }
             width -= border.x + border.width;
             height -= border.y + border.height;
         }

-        
+

         XResizeWindow( wxGlobalDisplay(), xwindow, width, height );
     }
 }
 
         XResizeWindow( wxGlobalDisplay(), xwindow, width, height );
     }
 }
 

-// For implementation purposes - sometimes decorations make the client area
-// smaller
-wxPoint wxWindowX11::GetClientAreaOrigin() const
-{
-    return wxPoint(0, 0);
-}
-

 void wxWindowX11::DoMoveWindow(int x, int y, int width, int height)
 {
     Window xwindow = (Window) m_mainWindow;
 void wxWindowX11::DoMoveWindow(int x, int y, int width, int height)
 {
     Window xwindow = (Window) m_mainWindow;


@@ -870,7 +932,7 @@ void wxWindowX11::DoMoveWindow(int x, int y, int width, int height)
     if (m_mainWindow != m_clientWindow)
     {
         xwindow = (Window) m_clientWindow;
     if (m_mainWindow != m_clientWindow)
     {
         xwindow = (Window) m_clientWindow;

-        
+

         wxWindow *window = (wxWindow*) this;
         wxRenderer *renderer = window->GetRenderer();
         if (renderer)
         wxWindow *window = (wxWindow*) this;
         wxRenderer *renderer = window->GetRenderer();
         if (renderer)


@@ -886,7 +948,7 @@ void wxWindowX11::DoMoveWindow(int x, int y, int width, int height)
             x = 0;
             y = 0;
         }
             x = 0;
             y = 0;
         }

-        
+

         wxScrollBar *sb = window->GetScrollbar( wxHORIZONTAL );
         if (sb && sb->IsShown())
         {
         wxScrollBar *sb = window->GetScrollbar( wxHORIZONTAL );
         if (sb && sb->IsShown())
         {


@@ -899,11 +961,11 @@ void wxWindowX11::DoMoveWindow(int x, int y, int width, int height)
             wxSize size = sb->GetSize();
             width -= size.x;
         }
             wxSize size = sb->GetSize();
             width -= size.x;
         }

-        
+

         XMoveResizeWindow( wxGlobalDisplay(), xwindow, x, y, wxMax(1, width), wxMax(1, height) );
     }
         XMoveResizeWindow( wxGlobalDisplay(), xwindow, x, y, wxMax(1, width), wxMax(1, height) );
     }

-    
-#else    
+
+#else

 
     XWindowChanges windowChanges;
     windowChanges.x = x;
 
     XWindowChanges windowChanges;
     windowChanges.x = x;


@@ -914,11 +976,11 @@ void wxWindowX11::DoMoveWindow(int x, int y, int width, int height)
     int valueMask = CWX | CWY | CWWidth | CWHeight;
 
     XConfigureWindow( wxGlobalDisplay(), xwindow, valueMask, &windowChanges );
     int valueMask = CWX | CWY | CWWidth | CWHeight;
 
     XConfigureWindow( wxGlobalDisplay(), xwindow, valueMask, &windowChanges );

-    
+

 #endif
 }
 
 #endif
 }
 

-void wxWindowX11::SetSizeHints(int minW, int minH, int maxW, int maxH, int incW, int incH)
+void wxWindowX11::DoSetSizeHints(int minW, int minH, int maxW, int maxH, int incW, int incH)

 {
     m_minWidth = minW;
     m_minHeight = minH;
 {
     m_minWidth = minW;
     m_minHeight = minH;


@@ -928,7 +990,7 @@ void wxWindowX11::SetSizeHints(int minW, int minH, int maxW, int maxH, int incW,
 #if !wxUSE_NANOX
     XSizeHints sizeHints;
     sizeHints.flags = 0;
 #if !wxUSE_NANOX
     XSizeHints sizeHints;
     sizeHints.flags = 0;

-    
+

     if (minW > -1 && minH > -1)
     {
         sizeHints.flags |= PMinSize;
     if (minW > -1 && minH > -1)
     {
         sizeHints.flags |= PMinSize;


@@ -958,9 +1020,21 @@ void wxWindowX11::SetSizeHints(int minW, int minH, int maxW, int maxH, int incW,
 
 int wxWindowX11::GetCharHeight() const
 {
 
 int wxWindowX11::GetCharHeight() const
 {

-    wxCHECK_MSG( m_font.Ok(), 0, "valid window font needed" );
-
-    WXFontStructPtr pFontStruct = m_font.GetFontStruct(1.0, wxGlobalDisplay());
+    wxFont font(GetFont());
+    wxCHECK_MSG( font.Ok(), 0, wxT("valid window font needed") );
+
+#if wxUSE_UNICODE
+    // There should be an easier way.
+    PangoLayout *layout = pango_layout_new( wxTheApp->GetPangoContext() );
+    pango_layout_set_font_description( layout, font.GetNativeFontInfo()->description );
+    pango_layout_set_text(layout, "H", 1 );
+    int w,h;
+    pango_layout_get_pixel_size(layout, &w, &h);
+    g_object_unref( G_OBJECT( layout ) );
+
+    return h;
+#else
+    WXFontStructPtr pFontStruct = font.GetFontStruct(1.0, wxGlobalDisplay());

 
     int direction, ascent, descent;
     XCharStruct overall;
 
     int direction, ascent, descent;
     XCharStruct overall;


@@ -969,13 +1043,26 @@ int wxWindowX11::GetCharHeight() const
 
     //  return (overall.ascent + overall.descent);
     return (ascent + descent);
 
     //  return (overall.ascent + overall.descent);
     return (ascent + descent);

+#endif

 }
 
 int wxWindowX11::GetCharWidth() const
 {
 }
 
 int wxWindowX11::GetCharWidth() const
 {

-    wxCHECK_MSG( m_font.Ok(), 0, "valid window font needed" );
-
-    WXFontStructPtr pFontStruct = m_font.GetFontStruct(1.0, wxGlobalDisplay());
+    wxFont font(GetFont());
+    wxCHECK_MSG( font.Ok(), 0, wxT("valid window font needed") );
+
+#if wxUSE_UNICODE
+    // There should be an easier way.
+    PangoLayout *layout = pango_layout_new( wxTheApp->GetPangoContext() );
+    pango_layout_set_font_description( layout, font.GetNativeFontInfo()->description );
+    pango_layout_set_text(layout, "H", 1 );
+    int w,h;
+    pango_layout_get_pixel_size(layout, &w, &h);
+    g_object_unref( G_OBJECT( layout ) );
+
+    return w;
+#else
+    WXFontStructPtr pFontStruct = font.GetFontStruct(1.0, wxGlobalDisplay());

 
     int direction, ascent, descent;
     XCharStruct overall;
 
     int direction, ascent, descent;
     XCharStruct overall;


@@ -983,31 +1070,59 @@ int wxWindowX11::GetCharWidth() const
         &descent, &overall);
 
     return overall.width;
         &descent, &overall);
 
     return overall.width;

+#endif

 }
 
 void wxWindowX11::GetTextExtent(const wxString& string,
 }
 
 void wxWindowX11::GetTextExtent(const wxString& string,

-                             int *x, int *y,
-                             int *descent, int *externalLeading,
-                             const wxFont *theFont) const
+                                int *x, int *y,
+                                int *descent, int *externalLeading,
+                                const wxFont *theFont) const

 {
 {

-    wxFont fontToUse = m_font;
+    wxFont fontToUse = GetFont();

     if (theFont) fontToUse = *theFont;
 
     wxCHECK_RET( fontToUse.Ok(), wxT("invalid font") );
 
     if (theFont) fontToUse = *theFont;
 
     wxCHECK_RET( fontToUse.Ok(), wxT("invalid font") );
 

+    if (string.empty())
+    {
+        if (x) (*x) = 0;
+        if (y) (*y) = 0;
+        return;
+    }
+
+#if wxUSE_UNICODE
+    PangoLayout *layout = pango_layout_new( wxTheApp->GetPangoContext() );
+
+    PangoFontDescription *desc = fontToUse.GetNativeFontInfo()->description;
+    pango_layout_set_font_description(layout, desc);
+
+    const wxCharBuffer data = wxConvUTF8.cWC2MB( string );
+    pango_layout_set_text(layout, (const char*) data, strlen( (const char*) data ));
+
+    PangoLayoutLine *line = (PangoLayoutLine *)pango_layout_get_lines(layout)->data;
+
+
+    PangoRectangle rect;
+    pango_layout_line_get_extents(line, NULL, &rect);
+
+    if (x) (*x) = (wxCoord) (rect.width / PANGO_SCALE);
+    if (y) (*y) = (wxCoord) (rect.height / PANGO_SCALE);
+    if (descent)
+    {
+        // Do something about metrics here
+        (*descent) = 0;
+    }
+    if (externalLeading) (*externalLeading) = 0;  // ??
+
+    g_object_unref( G_OBJECT( layout ) );
+#else

     WXFontStructPtr pFontStruct = fontToUse.GetFontStruct(1.0, wxGlobalDisplay());
 
     int direction, ascent, descent2;
     XCharStruct overall;
     WXFontStructPtr pFontStruct = fontToUse.GetFontStruct(1.0, wxGlobalDisplay());
 
     int direction, ascent, descent2;
     XCharStruct overall;

-    int slen = string.Len();
+    int slen = string.length();

 
 

-#if 0
-    if (use16)
-        XTextExtents16((XFontStruct*) pFontStruct, (XChar2b *) (char*) (const char*) string, slen, &direction,
-        &ascent, &descent2, &overall);
-#endif
-
-    XTextExtents((XFontStruct*) pFontStruct, (char*) string.c_str(), slen,
+    XTextExtents((XFontStruct*) pFontStruct, (const char*) string.c_str(), slen,

                  &direction, &ascent, &descent2, &overall);
 
     if ( x )
                  &direction, &ascent, &descent2, &overall);
 
     if ( x )


@@ -1018,7 +1133,7 @@ void wxWindowX11::GetTextExtent(const wxString& string,
         *descent = descent2;
     if (externalLeading)
         *externalLeading = 0;
         *descent = descent2;
     if (externalLeading)
         *externalLeading = 0;

-
+#endif

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -1038,7 +1153,7 @@ void wxWindowX11::Refresh(bool eraseBack, const wxRect *rect)
         {
             int height,width;
             GetSize( &width, &height );
         {
             int height,width;
             GetSize( &width, &height );

-            
+

             // Schedule for later Updating in ::Update() or ::OnInternalIdle().
             m_clearRegion.Clear();
             m_clearRegion.Union( 0, 0, width, height );
             // Schedule for later Updating in ::Update() or ::OnInternalIdle().
             m_clearRegion.Clear();
             m_clearRegion.Union( 0, 0, width, height );


@@ -1054,7 +1169,7 @@ void wxWindowX11::Refresh(bool eraseBack, const wxRect *rect)
     {
         int height,width;
         GetSize( &width, &height );
     {
         int height,width;
         GetSize( &width, &height );

-            
+

         // Schedule for later Updating in ::Update() or ::OnInternalIdle().
         m_updateRegion.Clear();
         m_updateRegion.Union( 0, 0, width, height );
         // Schedule for later Updating in ::Update() or ::OnInternalIdle().
         m_updateRegion.Clear();
         m_updateRegion.Union( 0, 0, width, height );


@@ -1069,42 +1184,34 @@ void wxWindowX11::Update()
         // Send nc paint events.
         SendNcPaintEvents();
     }
         // Send nc paint events.
         SendNcPaintEvents();
     }

-        
+

     if (!m_updateRegion.IsEmpty())
     {
         // wxLogDebug("wxWindowX11::Update: %s", GetClassInfo()->GetClassName());
         // Actually send erase events.
         SendEraseEvents();
     if (!m_updateRegion.IsEmpty())
     {
         // wxLogDebug("wxWindowX11::Update: %s", GetClassInfo()->GetClassName());
         // Actually send erase events.
         SendEraseEvents();

-        
+

         // Actually send paint events.
         SendPaintEvents();
     }
 }
 
         // Actually send paint events.
         SendPaintEvents();
     }
 }
 

-void wxWindowX11::Clear()
-{
-//    wxClientDC dc((wxWindow*) this);
-//    wxBrush brush(GetBackgroundColour(), wxSOLID);
-//    dc.SetBackground(brush);
-//    dc.Clear();
-}
-

 void wxWindowX11::SendEraseEvents()
 {
     if (m_clearRegion.IsEmpty()) return;
 void wxWindowX11::SendEraseEvents()
 {
     if (m_clearRegion.IsEmpty()) return;

-    
+

     wxClientDC dc( (wxWindow*)this );
     dc.SetClippingRegion( m_clearRegion );
     wxClientDC dc( (wxWindow*)this );
     dc.SetClippingRegion( m_clearRegion );

-    
+

     wxEraseEvent erase_event( GetId(), &dc );
     erase_event.SetEventObject( this );
 
     if (!GetEventHandler()->ProcessEvent(erase_event) )
     {
         Display *xdisplay = wxGlobalDisplay();
     wxEraseEvent erase_event( GetId(), &dc );
     erase_event.SetEventObject( this );
 
     if (!GetEventHandler()->ProcessEvent(erase_event) )
     {
         Display *xdisplay = wxGlobalDisplay();

-        Window xwindow = (Window) GetClientWindow();
+        Window xwindow = (Window) GetClientAreaWindow();

         XSetForeground( xdisplay, g_eraseGC, m_backgroundColour.GetPixel() );
         XSetForeground( xdisplay, g_eraseGC, m_backgroundColour.GetPixel() );

-        
+

         wxRegionIterator upd( m_clearRegion );
         while (upd)
         {
         wxRegionIterator upd( m_clearRegion );
         while (upd)
         {


@@ -1113,7 +1220,7 @@ void wxWindowX11::SendEraseEvents()
             upd ++;
         }
     }
             upd ++;
         }
     }

-    
+

     m_clearRegion.Clear();
 }
 
     m_clearRegion.Clear();
 }
 


@@ -1121,15 +1228,15 @@ void wxWindowX11::SendPaintEvents()
 {
     //    wxLogDebug("SendPaintEvents: %s (%ld)", GetClassInfo()->GetClassName(), GetId());
 
 {
     //    wxLogDebug("SendPaintEvents: %s (%ld)", GetClassInfo()->GetClassName(), GetId());
 

-    m_clipPaintRegion = TRUE;
-    
+    m_clipPaintRegion = true;
+

     wxPaintEvent paint_event( GetId() );
     paint_event.SetEventObject( this );
     GetEventHandler()->ProcessEvent( paint_event );
     wxPaintEvent paint_event( GetId() );
     paint_event.SetEventObject( this );
     GetEventHandler()->ProcessEvent( paint_event );

-    
+

     m_updateRegion.Clear();
     m_updateRegion.Clear();

-    
-    m_clipPaintRegion = FALSE;
+
+    m_clipPaintRegion = false;

 }
 
 void wxWindowX11::SendNcPaintEvents()
 }
 
 void wxWindowX11::SendNcPaintEvents()


@@ -1146,7 +1253,7 @@ void wxWindowX11::SendNcPaintEvents()
     {
         height = sb->GetSize().y;
         y = sb->GetPosition().y;
     {
         height = sb->GetSize().y;
         y = sb->GetPosition().y;

-        
+

         sb = window->GetScrollbar( wxVERTICAL );
         if (sb && sb->IsShown())
         {
         sb = window->GetScrollbar( wxVERTICAL );
         if (sb && sb->IsShown())
         {


@@ -1158,18 +1265,18 @@ void wxWindowX11::SendNcPaintEvents()
             Colormap cm = (Colormap) wxTheApp->GetMainColormap( wxGetDisplay() );
             wxColour colour = wxSystemSettings::GetColour(wxSYS_COLOUR_APPWORKSPACE);
             colour.CalcPixel( (WXColormap) cm );
             Colormap cm = (Colormap) wxTheApp->GetMainColormap( wxGetDisplay() );
             wxColour colour = wxSystemSettings::GetColour(wxSYS_COLOUR_APPWORKSPACE);
             colour.CalcPixel( (WXColormap) cm );

-            
+

             XSetForeground( xdisplay, g_eraseGC, colour.GetPixel() );
             XSetForeground( xdisplay, g_eraseGC, colour.GetPixel() );

-        
+

             XFillRectangle( xdisplay, xwindow, g_eraseGC, x, y, width, height );
         }
     }
             XFillRectangle( xdisplay, xwindow, g_eraseGC, x, y, width, height );
         }
     }

-        
+

     wxNcPaintEvent nc_paint_event( GetId() );
     nc_paint_event.SetEventObject( this );
     GetEventHandler()->ProcessEvent( nc_paint_event );
     wxNcPaintEvent nc_paint_event( GetId() );
     nc_paint_event.SetEventObject( this );
     GetEventHandler()->ProcessEvent( nc_paint_event );

-    
-    m_updateNcArea = FALSE;
+
+    m_updateNcArea = false;

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -1179,7 +1286,7 @@ void wxWindowX11::SendNcPaintEvents()
 // Responds to colour changes: passes event on to children.
 void wxWindowX11::OnSysColourChanged(wxSysColourChangedEvent& event)
 {
 // Responds to colour changes: passes event on to children.
 void wxWindowX11::OnSysColourChanged(wxSysColourChangedEvent& event)
 {

-    wxWindowList::Node *node = GetChildren().GetFirst();
+    wxWindowList::compatibility_iterator node = GetChildren().GetFirst();

     while ( node )
     {
         // Only propagate to non-top-level windows
     while ( node )
     {
         // Only propagate to non-top-level windows


@@ -1187,7 +1294,7 @@ void wxWindowX11::OnSysColourChanged(wxSysColourChangedEvent& event)
         if ( win->GetParent() )
         {
             wxSysColourChangedEvent event2;
         if ( win->GetParent() )
         {
             wxSysColourChangedEvent event2;

-            event.m_eventObject = win;
+            event.SetEventObject(win);

             win->GetEventHandler()->ProcessEvent(event2);
         }
 
             win->GetEventHandler()->ProcessEvent(event2);
         }
 


@@ -1195,90 +1302,102 @@ void wxWindowX11::OnSysColourChanged(wxSysColourChangedEvent& event)
     }
 }
 
     }
 }
 

+// See handler for InFocus case in app.cpp for details.
+wxWindow* g_GettingFocus = NULL;
+

 void wxWindowX11::OnInternalIdle()
 {
     // Update invalidated regions.
     Update();
 void wxWindowX11::OnInternalIdle()
 {
     // Update invalidated regions.
     Update();

-    
+

     // This calls the UI-update mechanism (querying windows for
     // menu/toolbar/control state information)
     // This calls the UI-update mechanism (querying windows for
     // menu/toolbar/control state information)

-    UpdateWindowUI();
+    if (wxUpdateUIEvent::CanUpdate((wxWindow*) this))
+        UpdateWindowUI(wxUPDATE_UI_FROMIDLE);

 
     // Set the input focus if couldn't do it before
     if (m_needsInputFocus)
     {
 
     // Set the input focus if couldn't do it before
     if (m_needsInputFocus)
     {

-       SetFocus();
+#if 0
+        wxString msg;
+        msg.Printf("Setting focus for %s from OnInternalIdle\n", GetClassInfo()->GetClassName());
+        printf(msg.c_str());
+#endif
+        SetFocus();
+
+        // If it couldn't set the focus now, there's
+        // no point in trying again.
+        m_needsInputFocus = false;

     }
     }

+    g_GettingFocus = NULL;

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------

-// function which maintain the global hash table mapping Widgets to wxWindows
+// function which maintain the global hash table mapping Widgets to wxWidgets

 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------
 

-bool wxAddWindowToTable(Window w, wxWindow *win)
+static bool DoAddWindowToTable(wxWindowHash *hash, Window w, wxWindow *win)

 {
 {

-    wxWindow *oldItem = NULL;
-    if ((oldItem = (wxWindow *)wxWidgetHashTable->Get ((long) w)))
+    if ( !hash->insert(wxWindowHash::value_type(w, win)).second )

     {
     {

-        wxLogDebug("Widget table clash: new widget is %ld, %s",
-                   (long)w, win->GetClassInfo()->GetClassName());
-        return FALSE;
+        wxLogDebug( wxT("Widget table clash: new widget is 0x%08x, %s"),
+                    (unsigned int)w, win->GetClassInfo()->GetClassName());
+        return false;

     }
 
     }
 

-    wxWidgetHashTable->Put((long) w, win);
+    wxLogTrace( wxT("widget"), wxT("XWindow 0x%08x <-> window %p (%s)"),
+                (unsigned int) w, win, win->GetClassInfo()->GetClassName());

 
 

-    wxLogTrace("widget", "XWindow 0x%08x <-> window %p (%s)",
-               w, win, win->GetClassInfo()->GetClassName());
-
-    return TRUE;
+    return true;

 }
 
 }
 

-wxWindow *wxGetWindowFromTable(Window w)
+static inline wxWindow *DoGetWindowFromTable(wxWindowHash *hash, Window w)

 {
 {

-    return (wxWindow *)wxWidgetHashTable->Get((long) w);
+    wxWindowHash::iterator i = hash->find(w);
+    return i == hash->end() ? NULL : i->second;

 }
 
 }
 

-void wxDeleteWindowFromTable(Window w)
+static inline void DoDeleteWindowFromTable(wxWindowHash *hash, Window w)

 {
 {

-    wxWidgetHashTable->Delete((long)w);
+    wxLogTrace( wxT("widget"), wxT("XWindow 0x%08x deleted"), (unsigned int) w);
+
+    hash->erase(w);

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------

-// function which maintain the global hash table mapping client widgets
+// public wrappers

 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------
 

-bool wxAddClientWindowToTable(Window w, wxWindow *win)
+bool wxAddWindowToTable(Window w, wxWindow *win)

 {
 {

-    wxWindow *oldItem = NULL;
-    if ((oldItem = (wxWindow *)wxClientWidgetHashTable->Get ((long) w)))
-    {
-        wxLogDebug("Client window table clash: new window is %ld, %s",
-                   (long)w, win->GetClassInfo()->GetClassName());
-        return FALSE;
-    }
+    return DoAddWindowToTable(wxWidgetHashTable, w, win);
+}

 
 

-    wxClientWidgetHashTable->Put((long) w, win);
+wxWindow *wxGetWindowFromTable(Window w)
+{
+    return DoGetWindowFromTable(wxWidgetHashTable, w);
+}

 
 

-    wxLogTrace("widget", "XWindow 0x%08x <-> window %p (%s)",
-               w, win, win->GetClassInfo()->GetClassName());
+void wxDeleteWindowFromTable(Window w)
+{
+    DoDeleteWindowFromTable(wxWidgetHashTable, w);
+}

 
 

-    return TRUE;
+bool wxAddClientWindowToTable(Window w, wxWindow *win)
+{
+    return DoAddWindowToTable(wxClientWidgetHashTable, w, win);

 }
 
 wxWindow *wxGetClientWindowFromTable(Window w)
 {
 }
 
 wxWindow *wxGetClientWindowFromTable(Window w)
 {

-    return (wxWindow *)wxClientWidgetHashTable->Get((long) w);
+    return DoGetWindowFromTable(wxClientWidgetHashTable, w);

 }
 
 void wxDeleteClientWindowFromTable(Window w)
 {
 }
 
 void wxDeleteClientWindowFromTable(Window w)
 {

-    wxClientWidgetHashTable->Delete((long)w);
+    DoDeleteWindowFromTable(wxClientWidgetHashTable, w);

 }
 
 }
 

-// ----------------------------------------------------------------------------
-// add/remove window from the table
-// ----------------------------------------------------------------------------
-

 // ----------------------------------------------------------------------------
 // X11-specific accessors
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
 // X11-specific accessors
 // ----------------------------------------------------------------------------


@@ -1288,7 +1407,7 @@ WXWindow wxWindowX11::GetMainWindow() const
     return m_mainWindow;
 }
 
     return m_mainWindow;
 }
 

-WXWindow wxWindowX11::GetClientWindow() const
+WXWindow wxWindowX11::GetClientAreaWindow() const

 {
     return m_clientWindow;
 }
 {
     return m_clientWindow;
 }


@@ -1346,6 +1465,22 @@ bool wxTranslateMouseEvent(wxMouseEvent& wxevent, wxWindow *win, Window window,
                     eventType = wxEVT_RIGHT_DOWN;
                     button = 3;
                 }
                     eventType = wxEVT_RIGHT_DOWN;
                     button = 3;
                 }

+                else if ( xevent->xbutton.button == Button4 ||
+                            xevent->xbutton.button == Button5 )
+                {
+                    // this is the same value as used under wxMSW
+                    static const int WHEEL_DELTA = 120;
+
+                    eventType = wxEVT_MOUSEWHEEL;
+                    button = xevent->xbutton.button;
+
+                    wxevent.m_linesPerAction = 3;
+                    wxevent.m_wheelDelta = WHEEL_DELTA;
+
+                    // Button 4 means mousewheel up, 5 means down
+                    wxevent.m_wheelRotation = button == Button4 ? WHEEL_DELTA
+                                                                : -WHEEL_DELTA;
+                }

 
                 // check for a double click
                 // TODO: where can we get this value from?
 
                 // check for a double click
                 // TODO: where can we get this value from?


@@ -1386,11 +1521,11 @@ bool wxTranslateMouseEvent(wxMouseEvent& wxevent, wxWindow *win, Window window,
                 {
                     eventType = wxEVT_RIGHT_UP;
                 }
                 {
                     eventType = wxEVT_RIGHT_UP;
                 }

-                else return FALSE;
+                else return false;

             }
             else
             {
             }
             else
             {

-                return FALSE;
+                return false;

             }
 
             wxevent.SetEventType(eventType);
             }
 
             wxevent.SetEventType(eventType);


@@ -1416,13 +1551,13 @@ bool wxTranslateMouseEvent(wxMouseEvent& wxevent, wxWindow *win, Window window,
             wxevent.SetId(win->GetId());
             wxevent.SetEventObject(win);
 
             wxevent.SetId(win->GetId());
             wxevent.SetEventObject(win);
 

-            return TRUE;
+            return true;

         }
     }
         }
     }

-    return FALSE;
+    return false;

 }
 
 }
 

-bool wxTranslateKeyEvent(wxKeyEvent& wxevent, wxWindow *win, Window WXUNUSED(win), XEvent *xevent)
+bool wxTranslateKeyEvent(wxKeyEvent& wxevent, wxWindow *win, Window WXUNUSED(win), XEvent *xevent, bool isAscii)

 {
     switch (XEventGetType(xevent))
     {
 {
     switch (XEventGetType(xevent))
     {


@@ -1434,6 +1569,14 @@ bool wxTranslateKeyEvent(wxKeyEvent& wxevent, wxWindow *win, Window WXUNUSED(win
             KeySym keySym;
             (void) XLookupString ((XKeyEvent *) xevent, buf, 20, &keySym, NULL);
             int id = wxCharCodeXToWX (keySym);
             KeySym keySym;
             (void) XLookupString ((XKeyEvent *) xevent, buf, 20, &keySym, NULL);
             int id = wxCharCodeXToWX (keySym);

+            // id may be WXK_xxx code - these are outside ASCII range, so we
+            // can't just use toupper() on id.
+            // Only change this if we want the raw key that was pressed,
+            // and don't change it if we want an ASCII value.
+            if (!isAscii && (id >= 'a' && id <= 'z'))
+            {
+                id = id + 'A' - 'a';
+            }

 
             wxevent.m_shiftDown = XKeyEventShiftIsDown(xevent);
             wxevent.m_controlDown = XKeyEventCtrlIsDown(xevent);
 
             wxevent.m_shiftDown = XKeyEventShiftIsDown(xevent);
             wxevent.m_controlDown = XKeyEventCtrlIsDown(xevent);


@@ -1446,16 +1589,12 @@ bool wxTranslateKeyEvent(wxKeyEvent& wxevent, wxWindow *win, Window WXUNUSED(win
             wxevent.m_x = XKeyEventGetX(xevent);
             wxevent.m_y = XKeyEventGetY(xevent);
 
             wxevent.m_x = XKeyEventGetX(xevent);
             wxevent.m_y = XKeyEventGetY(xevent);
 

-            if (id > -1)
-                return TRUE;
-            else
-                return FALSE;
-            break;
+            return id > -1;

         }
     default:
         break;
     }
         }
     default:
         break;
     }

-    return FALSE;
+    return false;

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -1471,20 +1610,20 @@ bool wxWindowX11::SetBackgroundColour(const wxColour& col)
     Colormap cm = DefaultColormap( xdisplay, xscreen );
 
     m_backgroundColour.CalcPixel( (WXColormap) cm );
     Colormap cm = DefaultColormap( xdisplay, xscreen );
 
     m_backgroundColour.CalcPixel( (WXColormap) cm );

-    
+

     // We don't set the background colour as we paint
     // the background ourselves.
     // XSetWindowBackground( xdisplay, (Window) m_clientWindow, m_backgroundColour.GetPixel() );
     // We don't set the background colour as we paint
     // the background ourselves.
     // XSetWindowBackground( xdisplay, (Window) m_clientWindow, m_backgroundColour.GetPixel() );

-    
-    return TRUE;
+
+    return true;

 }
 
 bool wxWindowX11::SetForegroundColour(const wxColour& col)
 {
     if ( !wxWindowBase::SetForegroundColour(col) )
 }
 
 bool wxWindowX11::SetForegroundColour(const wxColour& col)
 {
     if ( !wxWindowBase::SetForegroundColour(col) )

-        return FALSE;
+        return false;

 
 

-    return TRUE;
+    return true;

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -1494,7 +1633,7 @@ bool wxWindowX11::SetForegroundColour(const wxColour& col)
 wxWindow *wxGetActiveWindow()
 {
     // TODO
 wxWindow *wxGetActiveWindow()
 {
     // TODO

-    wxFAIL_MSG("Not implemented");
+    wxFAIL_MSG(wxT("Not implemented"));

     return NULL;
 }
 
     return NULL;
 }
 


@@ -1512,28 +1651,59 @@ wxWindow* wxFindWindowAtPointer(wxPoint& pt)
     return wxFindWindowAtPoint(wxGetMousePosition());
 }
 
     return wxFindWindowAtPoint(wxGetMousePosition());
 }
 

-// Get the current mouse position.
-wxPoint wxGetMousePosition()
+void wxGetMouseState(int& rootX, int& rootY, unsigned& maskReturn)

 {
 #if wxUSE_NANOX
     /* TODO */
 {
 #if wxUSE_NANOX
     /* TODO */

-    return wxPoint(0, 0);
+    rootX = rootY = 0;
+    maskReturn = 0;

 #else
     Display *display = wxGlobalDisplay();
     Window rootWindow = RootWindowOfScreen (DefaultScreenOfDisplay(display));
     Window rootReturn, childReturn;
 #else
     Display *display = wxGlobalDisplay();
     Window rootWindow = RootWindowOfScreen (DefaultScreenOfDisplay(display));
     Window rootReturn, childReturn;

-    int rootX, rootY, winX, winY;
-    unsigned int maskReturn;
+    int winX, winY;

 
     XQueryPointer (display,
 
     XQueryPointer (display,

-                  rootWindow,
-                  &rootReturn,
+                   rootWindow,
+                   &rootReturn,

                    &childReturn,
                    &rootX, &rootY, &winX, &winY, &maskReturn);
                    &childReturn,
                    &rootX, &rootY, &winX, &winY, &maskReturn);

-    return wxPoint(rootX, rootY);

 #endif
 }
 
 #endif
 }
 

+// Get the current mouse position.
+wxPoint wxGetMousePosition()
+{
+    int x, y;
+    unsigned mask;
+
+    wxGetMouseState(x, y, mask);
+    return wxPoint(x, y);
+}
+
+wxMouseState wxGetMouseState()
+{
+    wxMouseState ms;
+    int x, y;
+    unsigned mask;
+
+    wxGetMouseState(x, y, mask);
+
+    ms.SetX(x);
+    ms.SetY(y);
+
+    ms.SetLeftDown(mask & Button1Mask);
+    ms.SetMiddleDown(mask & Button2Mask);
+    ms.SetRightDown(mask & Button3Mask);
+
+    ms.SetControlDown(mask & ControlMask);
+    ms.SetShiftDown(mask & ShiftMask);
+    ms.SetAltDown(mask & Mod3Mask);
+    ms.SetMetaDown(mask & Mod1Mask);
+
+    return ms;
+}
+

 
 // ----------------------------------------------------------------------------
 // wxNoOptimize: switch off size optimization
 
 // ----------------------------------------------------------------------------
 // wxNoOptimize: switch off size optimization


@@ -1549,8 +1719,14 @@ int wxNoOptimize::ms_count = 0;
 class wxWinModule : public wxModule
 {
 public:
 class wxWinModule : public wxModule
 {
 public:

-    bool OnInit();
-    void OnExit();
+    wxWinModule()
+    {
+        // we must be cleaned up before the display is closed
+        AddDependency(wxClassInfo::FindClass(_T("wxX11DisplayModule")));
+    }
+
+    virtual bool OnInit();
+    virtual void OnExit();

 
 private:
     DECLARE_DYNAMIC_CLASS(wxWinModule)
 
 private:
     DECLARE_DYNAMIC_CLASS(wxWinModule)


@@ -1565,8 +1741,8 @@ bool wxWinModule::OnInit()
     Window xroot = RootWindow( xdisplay, xscreen );
     g_eraseGC = XCreateGC( xdisplay, xroot, 0, NULL );
     XSetFillStyle( xdisplay, g_eraseGC, FillSolid );
     Window xroot = RootWindow( xdisplay, xscreen );
     g_eraseGC = XCreateGC( xdisplay, xroot, 0, NULL );
     XSetFillStyle( xdisplay, g_eraseGC, FillSolid );

-    
-    return TRUE;
+
+    return true;

 }
 
 void wxWinModule::OnExit()
 }
 
 void wxWinModule::OnExit()


@@ -1574,5 +1750,3 @@ void wxWinModule::OnExit()
     Display *xdisplay = wxGlobalDisplay();
     XFreeGC( xdisplay, g_eraseGC );
 }
     Display *xdisplay = wxGlobalDisplay();
     XFreeGC( xdisplay, g_eraseGC );
 }

-
-