Fix memory leak when a spacer is added, and crash when a window is added before wxSiz...

[wxWidgets.git] / src / gtk1 / stattext.cpp

diff --git a/src/gtk1/stattext.cpp b/src/gtk1/stattext.cpp
index c245fd315c96c06415602ad9195a9dd8d63754fc..9b5aa5cb2f2faa946d2bfd0c65b38ed36a07e6d6 100644 (file)
--- a/src/gtk1/stattext.cpp
+++ b/src/gtk1/stattext.cpp
@@ -132,20 +132,20 @@ void wxStaticText::SetLabel( const wxString &label )
 #ifdef __WXGTK20__
     // Build the colorized version of the label (markup only allowed
     // under GTK2):
 #ifdef __WXGTK20__
     // Build the colorized version of the label (markup only allowed
     // under GTK2):

-    wxString colorlabel = label;
-    // If the color has been set, create a markup string to pass to
-    // the label setter

     if (m_foregroundColour.Ok())
     {
     if (m_foregroundColour.Ok())
     {

+        // If the color has been set, create a markup string to pass to
+        // the label setter
+        wxString colorlabel;

         colorlabel.Printf(_T("<span foreground=\"#%02x%02x%02x\">%s</span>"),
                           m_foregroundColour.Red(), m_foregroundColour.Green(),
         colorlabel.Printf(_T("<span foreground=\"#%02x%02x%02x\">%s</span>"),
                           m_foregroundColour.Red(), m_foregroundColour.Green(),

-                          m_foregroundColour.Blue(), label.c_str());
+                          m_foregroundColour.Blue(),
+                          wxEscapeStringForPangoMarkup(label).c_str());
+        gtk_label_set_markup( GTK_LABEL(m_widget), wxGTK_CONV( colorlabel ) );

     }
     }

-        
-    gtk_label_set_markup( GTK_LABEL(m_widget), wxGTK_CONV( colorlabel ) );
-#else
-    gtk_label_set( GTK_LABEL(m_widget), wxGTK_CONV( m_label ) );
+    else

 #endif
 #endif

+        gtk_label_set( GTK_LABEL(m_widget), wxGTK_CONV( m_label ) );

 
     // adjust the label size to the new label unless disabled
     if (!HasFlag(wxST_NO_AUTORESIZE))
 
     // adjust the label size to the new label unless disabled
     if (!HasFlag(wxST_NO_AUTORESIZE))