Fix memory leak when a spacer is added, and crash when a window is added before wxSiz...

[wxWidgets.git] / src / gtk1 / tglbtn.cpp

diff --git a/src/gtk1/tglbtn.cpp b/src/gtk1/tglbtn.cpp
index c5a05ec57891b5003c23652492a554c901f0f749..1bf01efef71d7fc91f9d83236dab0405316f7971 100644 (file)
--- a/src/gtk1/tglbtn.cpp
+++ b/src/gtk1/tglbtn.cpp
@@ -7,9 +7,12 @@
 // Created:     08.02.01
 // RCS-ID:      $Id$
 // Copyright:   (c) 2000 Johnny C. Norris II
 // Created:     08.02.01
 // RCS-ID:      $Id$
 // Copyright:   (c) 2000 Johnny C. Norris II

-// License:     Rocketeer license
+// License:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////////
 

+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"
+

 #include "wx/tglbtn.h"
 #include "wx/button.h"
 
 #include "wx/tglbtn.h"
 #include "wx/button.h"
 


@@ -21,9 +24,9 @@ extern void wxapp_install_idle_handler();
 extern bool g_isIdle;
 extern bool      g_blockEventsOnDrag;
 extern wxCursor   g_globalCursor;
 extern bool g_isIdle;
 extern bool      g_blockEventsOnDrag;
 extern wxCursor   g_globalCursor;

+extern wxWindowGTK *g_delayedFocus;

 
 

-// void gtk_togglebutton_clicked_callback(GtkWidget *widget, wxToggleButton *cb)
-// Callback function given to gtk.
+extern "C" {

 static void gtk_togglebutton_clicked_callback(GtkWidget *WXUNUSED(widget), wxToggleButton *cb)
 {
    if (g_isIdle)
 static void gtk_togglebutton_clicked_callback(GtkWidget *WXUNUSED(widget), wxToggleButton *cb)
 {
    if (g_isIdle)


@@ -40,10 +43,189 @@ static void gtk_togglebutton_clicked_callback(GtkWidget *WXUNUSED(widget), wxTog
    event.SetEventObject(cb);
    cb->GetEventHandler()->ProcessEvent(event);
 }
    event.SetEventObject(cb);
    cb->GetEventHandler()->ProcessEvent(event);
 }

+}

 
 

-IMPLEMENT_DYNAMIC_CLASS(wxToggleButton, wxControl)

 DEFINE_EVENT_TYPE(wxEVT_COMMAND_TOGGLEBUTTON_CLICKED)
 
 DEFINE_EVENT_TYPE(wxEVT_COMMAND_TOGGLEBUTTON_CLICKED)
 

+// ------------------------------------------------------------------------
+// wxToggleBitmapButton
+// ------------------------------------------------------------------------
+
+IMPLEMENT_DYNAMIC_CLASS(wxToggleBitmapButton, wxControl)
+
+bool wxToggleBitmapButton::Create(wxWindow *parent, wxWindowID id,
+                            const wxBitmap &label, const wxPoint &pos,
+                            const wxSize &size, long style,
+                            const wxValidator& validator,
+                            const wxString &name)
+{
+    m_needParent = TRUE;
+    m_acceptsFocus = TRUE;
+   
+    m_blockEvent = FALSE;
+
+    if (!PreCreation(parent, pos, size) ||
+       !CreateBase(parent, id, pos, size, style, validator, name ))
+    {
+        wxFAIL_MSG(wxT("wxToggleBitmapButton creation failed"));
+        return FALSE;
+    }
+    
+    m_bitmap = label;
+
+    // Create the gtk widget.
+    m_widget = gtk_toggle_button_new();
+
+    if (style & wxNO_BORDER)
+       gtk_button_set_relief( GTK_BUTTON(m_widget), GTK_RELIEF_NONE );
+
+    if (m_bitmap.Ok())
+    {
+        OnSetBitmap();
+    }
+
+    gtk_signal_connect(GTK_OBJECT(m_widget), "clicked",
+                      GTK_SIGNAL_FUNC(gtk_togglebutton_clicked_callback),
+                      (gpointer *)this);
+
+    m_parent->DoAddChild(this);
+
+    PostCreation(size);
+
+    return TRUE;
+}
+
+// void SetValue(bool state)
+// Set the value of the toggle button.
+void wxToggleBitmapButton::SetValue(bool state)
+{
+   wxCHECK_RET(m_widget != NULL, wxT("invalid toggle button"));
+
+   if (state == GetValue())
+      return;
+
+   m_blockEvent = TRUE;
+
+   gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(m_widget), state);
+
+   m_blockEvent = FALSE;
+}
+
+// bool GetValue() const
+// Get the value of the toggle button.
+bool wxToggleBitmapButton::GetValue() const
+{
+   wxCHECK_MSG(m_widget != NULL, FALSE, wxT("invalid toggle button"));
+
+   return GTK_TOGGLE_BUTTON(m_widget)->active;
+}
+
+void wxToggleBitmapButton::SetLabel(const wxBitmap& label)
+{
+    wxCHECK_RET(m_widget != NULL, wxT("invalid toggle button"));
+
+    m_bitmap = label;
+    InvalidateBestSize();
+    
+    OnSetBitmap();
+}
+
+void wxToggleBitmapButton::OnSetBitmap()
+{
+    if (!m_bitmap.Ok()) return;
+
+    GdkBitmap *mask = (GdkBitmap *) NULL;
+    if (m_bitmap.GetMask()) mask = m_bitmap.GetMask()->GetBitmap();
+
+    GtkWidget *child = BUTTON_CHILD(m_widget);
+    if (child == NULL)
+    {
+        // initial bitmap
+        GtkWidget *pixmap = gtk_pixmap_new(m_bitmap.GetPixmap(), mask);
+        gtk_widget_show(pixmap);
+        gtk_container_add(GTK_CONTAINER(m_widget), pixmap);
+    }
+    else
+    {   // subsequent bitmaps
+        GtkPixmap *g_pixmap = GTK_PIXMAP(child);
+        gtk_pixmap_set(g_pixmap, m_bitmap.GetPixmap(), mask);
+    }
+}
+
+bool wxToggleBitmapButton::Enable(bool enable /*=TRUE*/)
+{
+    if (!wxControl::Enable(enable))
+        return FALSE;
+
+    gtk_widget_set_sensitive(BUTTON_CHILD(m_widget), enable);
+
+    return TRUE;
+}
+
+void wxToggleBitmapButton::DoApplyWidgetStyle(GtkRcStyle *style)
+{
+    gtk_widget_modify_style(m_widget, style);
+    gtk_widget_modify_style(BUTTON_CHILD(m_widget), style);
+}
+
+bool wxToggleBitmapButton::IsOwnGtkWindow(GdkWindow *window)
+{
+    return window == TOGGLE_BUTTON_EVENT_WIN(m_widget);
+}
+
+void wxToggleBitmapButton::OnInternalIdle()
+{
+    wxCursor cursor = m_cursor;
+    
+    if (g_globalCursor.Ok())
+        cursor = g_globalCursor;
+
+    GdkWindow *win = TOGGLE_BUTTON_EVENT_WIN(m_widget);
+    if ( win && cursor.Ok() )
+    {
+      /* I now set the cursor the anew in every OnInternalIdle call
+         as setting the cursor in a parent window also effects the
+         windows above so that checking for the current cursor is
+         not possible. */
+
+        gdk_window_set_cursor(win, cursor.GetCursor());
+    }
+
+    if (wxUpdateUIEvent::CanUpdate(this))
+        UpdateWindowUI(wxUPDATE_UI_FROMIDLE);
+}
+
+
+// Get the "best" size for this control.
+wxSize wxToggleBitmapButton::DoGetBestSize() const
+{
+    wxSize best;
+    
+    if (m_bitmap.Ok())
+    {
+        int border = HasFlag(wxNO_BORDER) ? 4 : 10;
+        best.x = m_bitmap.GetWidth()+border;
+        best.y = m_bitmap.GetHeight()+border;
+    }
+    CacheBestSize(best);
+    return best;
+}
+
+
+// static
+wxVisualAttributes
+wxToggleBitmapButton::GetClassDefaultAttributes(wxWindowVariant WXUNUSED(variant))
+{
+    return GetDefaultAttributesFromGTKWidget(gtk_toggle_button_new);
+}
+
+
+// ------------------------------------------------------------------------
+// wxToggleButton
+// ------------------------------------------------------------------------
+
+IMPLEMENT_DYNAMIC_CLASS(wxToggleButton, wxControl)
+

 bool wxToggleButton::Create(wxWindow *parent, wxWindowID id,
                             const wxString &label, const wxPoint &pos,
                             const wxSize &size, long style,
 bool wxToggleButton::Create(wxWindow *parent, wxWindowID id,
                             const wxString &label, const wxPoint &pos,
                             const wxSize &size, long style,


@@ -64,7 +246,7 @@ bool wxToggleButton::Create(wxWindow *parent, wxWindowID id,
    wxControl::SetLabel(label);
 
    // Create the gtk widget.
    wxControl::SetLabel(label);
 
    // Create the gtk widget.

-   m_widget = gtk_toggle_button_new_with_label(m_label.mbc_str());
+   m_widget = gtk_toggle_button_new_with_label( wxGTK_CONV( m_label ) );

 
    gtk_signal_connect(GTK_OBJECT(m_widget), "clicked",
                       GTK_SIGNAL_FUNC(gtk_togglebutton_clicked_callback),
 
    gtk_signal_connect(GTK_OBJECT(m_widget), "clicked",
                       GTK_SIGNAL_FUNC(gtk_togglebutton_clicked_callback),


@@ -72,23 +254,7 @@ bool wxToggleButton::Create(wxWindow *parent, wxWindowID id,
 
    m_parent->DoAddChild(this);
 
 
    m_parent->DoAddChild(this);
 

-   PostCreation();
-
-   SetFont(parent->GetFont());
-
-   wxSize size_best(DoGetBestSize());
-   wxSize new_size(size);
-   if (new_size.x == -1)
-      new_size.x = size_best.x;
-   if (new_size.y == -1)
-      new_size.y = size_best.y;
-   if ((new_size.x != size.x) || (new_size.y != size.y))
-      SetSize(new_size.x, new_size.y);
-
-   SetBackgroundColour(parent->GetBackgroundColour());
-   SetForegroundColour(parent->GetForegroundColour());
-
-   Show(TRUE);
+   PostCreation(size);

 
    return TRUE;
 }
 
    return TRUE;
 }


@@ -124,7 +290,7 @@ void wxToggleButton::SetLabel(const wxString& label)
 
     wxControl::SetLabel(label);
 
 
     wxControl::SetLabel(label);
 

-    gtk_label_set(GTK_LABEL(BUTTON_CHILD(m_widget)), GetLabel().mbc_str());
+    gtk_label_set(GTK_LABEL(BUTTON_CHILD(m_widget)), wxGTK_CONV( GetLabel() ) );

 }
 
 bool wxToggleButton::Enable(bool enable /*=TRUE*/)
 }
 
 bool wxToggleButton::Enable(bool enable /*=TRUE*/)


@@ -137,11 +303,10 @@ bool wxToggleButton::Enable(bool enable /*=TRUE*/)
     return TRUE;
 }
 
     return TRUE;
 }
 

-void wxToggleButton::ApplyWidgetStyle()
+void wxToggleButton::DoApplyWidgetStyle(GtkRcStyle *style)

 {
 {

-    SetWidgetStyle();
-    gtk_widget_set_style(m_widget, m_widgetStyle);
-    gtk_widget_set_style(BUTTON_CHILD(m_widget), m_widgetStyle);
+    gtk_widget_modify_style(m_widget, style);
+    gtk_widget_modify_style(BUTTON_CHILD(m_widget), style);

 }
 
 bool wxToggleButton::IsOwnGtkWindow(GdkWindow *window)
 }
 
 bool wxToggleButton::IsOwnGtkWindow(GdkWindow *window)


@@ -167,10 +332,11 @@ void wxToggleButton::OnInternalIdle()
         gdk_window_set_cursor(win, cursor.GetCursor());
     }
 
         gdk_window_set_cursor(win, cursor.GetCursor());
     }
 

-    UpdateWindowUI();
+    if (wxUpdateUIEvent::CanUpdate(this))
+        UpdateWindowUI(wxUPDATE_UI_FROMIDLE);

 }
 
 }
 

-// wxSize DoGetBestSize() const
+

 // Get the "best" size for this control.
 wxSize wxToggleButton::DoGetBestSize() const
 {
 // Get the "best" size for this control.
 wxSize wxToggleButton::DoGetBestSize() const
 {


@@ -181,8 +347,15 @@ wxSize wxToggleButton::DoGetBestSize() const
         if (ret.x < 80) ret.x = 80;
     }
     
         if (ret.x < 80) ret.x = 80;
     }
     

+    CacheBestSize(ret);
+    return ret;
+}

 
 

-   return ret;
+// static
+wxVisualAttributes
+wxToggleButton::GetClassDefaultAttributes(wxWindowVariant WXUNUSED(variant))
+{
+    return GetDefaultAttributesFromGTKWidget(gtk_toggle_button_new);

 }
 
 #endif // wxUSE_TOGGLEBTN
 }
 
 #endif // wxUSE_TOGGLEBTN