// ----------------------------------------------------------------------------
// the default values for GetValue()
-wxString wxGridCellBoolEditor::ms_stringValues[2] = { _T("1"), _T("") };
+wxString wxGridCellBoolEditor::ms_stringValues[2] = { _T(""), _T("1") };
void wxGridCellBoolEditor::Create(wxWindow* parent,
wxWindowID id,
else
{
wxString cellval( grid->GetTable()->GetValue(row, col) );
- m_startValue = !( !cellval || (cellval == wxT("0")) );
+
+ if ( cellval == ms_stringValues[false] )
+ m_startValue = false;
+ else if ( cellval == ms_stringValues[true] )
+ m_startValue = true;
+ else
+ {
+ // do not try to be smart here and convert it to true or false
+ // because we'll still overwrite it with something different and
+ // this risks to be very surprising for the user code, let them
+ // know about it
+ wxFAIL_MSG( _T("invalid value for a cell with bool editor!") );
+ }
}
CBox()->SetValue(m_startValue);
m_rowMinHeights(GRID_HASH_SIZE)
{
Create();
- SetBestFittingSize(size);
+ SetInitialSize(size);
}
bool wxGrid::Create(wxWindow *parent, wxWindowID id,
m_rowMinHeights = wxLongToLongHashMap(GRID_HASH_SIZE);
Create();
- SetBestFittingSize(size);
+ SetInitialSize(size);
return true;
}
total ? (gs_nAttrCacheHits*100) / total : 0);
#endif
- if (m_ownTable)
+ // if we own the table, just delete it, otherwise at least don't leave it
+ // with dangling view pointer
+ if ( m_ownTable )
delete m_table;
+ else if ( m_table && m_table->GetView() == this )
+ m_table->SetView(NULL);
delete m_typeRegistry;
delete m_selection;
// default widths/heights are used for all rows/columns, we may not use these
// arrays at all
//
-// with some extra code, it should be possible to only store the
-// widths/heights different from default ones but this will be done later...
+// with some extra code, it should be possible to only store the widths/heights
+// different from default ones (resulting in space savings for huge grids) but
+// this is not done currently
// ----------------------------------------------------------------------------
void wxGrid::InitRowHeights()
m_rowHeights.Alloc( m_numRows );
m_rowBottoms.Alloc( m_numRows );
- int rowBottom = 0;
-
m_rowHeights.Add( m_defaultRowHeight, m_numRows );
+ int rowBottom = 0;
for ( int i = 0; i < m_numRows; i++ )
{
rowBottom += m_defaultRowHeight;
m_colWidths.Alloc( m_numCols );
m_colRights.Alloc( m_numCols );
- int colRight = 0;
m_colWidths.Add( m_defaultColWidth, m_numCols );
+ int colRight = 0;
for ( int i = 0; i < m_numCols; i++ )
{
colRight = ( GetColPos( i ) + 1 ) * m_defaultColWidth;
void wxGrid::CalcDimensions()
{
- int cw, ch;
- GetClientSize( &cw, &ch );
-
- if ( m_rowLabelWin->IsShown() )
- cw -= m_rowLabelWidth;
- if ( m_colLabelWin->IsShown() )
- ch -= m_colLabelHeight;
+ // compute the size of the scrollable area
+ int w = m_numCols > 0 ? GetColRight(GetColAt(m_numCols - 1)) : 0;
+ int h = m_numRows > 0 ? GetRowBottom(m_numRows - 1) : 0;
- // grid total size
- int w = m_numCols > 0 ? GetColRight(GetColAt( m_numCols - 1 )) + m_extraWidth + 1 : 0;
- int h = m_numRows > 0 ? GetRowBottom(m_numRows - 1) + m_extraHeight + 1 : 0;
+ w += m_extraWidth;
+ h += m_extraHeight;
// take into account editor if shown
if ( IsCellEditControlShown() )
// do set scrollbar parameters
SetScrollbars( m_scrollLineX, m_scrollLineY,
- GetScrollX(w), GetScrollY(h), x, y,
+ GetScrollX(w), GetScrollY(h),
+ x, y,
GetBatchCount() != 0);
// if our OnSize() hadn't been called (it would if we have scrollbars), we
return;
}
+#if !(defined(__WXMAC__) && wxMAC_USE_CORE_GRAPHICS)
wxClientDC dc( m_gridWin );
PrepareDC( dc );
+#endif
if ( m_currentCellCoords != wxGridNoCellCoords )
{
// Otherwise refresh redraws the highlight!
m_currentCellCoords = coords;
+#if defined(__WXMAC__) && wxMAC_USE_CORE_GRAPHICS
+ m_gridWin->Refresh(true /*, & r */);
+#else
DrawGridCellArea( dc, cells );
DrawAllGridLines( dc, r );
+#endif
}
}
m_currentCellCoords = coords;
wxGridCellAttr *attr = GetCellAttr( coords );
+#if !(defined(__WXMAC__) && wxMAC_USE_CORE_GRAPHICS)
DrawCellHighlight( dc, attr );
+#endif
attr->DecRef();
}
// edit control is erased by this code after being rendered.
// On wxMac (QD build only), the cell editor is a wxTextCntl and is rendered
// implicitly, causing this out-of order render.
-#if !defined(__WXMAC__) || wxMAC_USE_CORE_GRAPHICS
+#if !defined(__WXMAC__)
wxGridCellEditor *editor = attr->GetEditor(this, row, col);
editor->PaintBackground(rect, attr);
editor->DecRef();
int rightCol = GetColPos( internalXToCol(right) );
int bottomRow = internalYToRow(bottom);
-#ifndef __WXMAC__
- // CS: I don't know why suddenly unscrolled coordinates are used for clipping
+#if !defined(__WXMAC__) || wxMAC_USE_CORE_GRAPHICS
wxRegion clippedcells(0, 0, cw, ch);
int i, j, cell_rows, cell_cols;
wxRect rect;
- for (j=topRow; j<bottomRow; j++)
+ for (j=topRow; j<=bottomRow; j++)
{
int colPos;
- for (colPos=leftCol; colPos<rightCol; colPos++)
+ for (colPos=leftCol; colPos<=rightCol; colPos++)
{
i = GetColAt( colPos );
int i, j, cell_rows, cell_cols;
wxRect rect;
- for (j=topRow; j<bottomRow; j++)
+ for (j=topRow; j<=bottomRow; j++)
{
- for (i=leftCol; i<rightCol; i++)
+ for (i=leftCol; i<=rightCol; i++)
{
GetCellSize( j, i, &cell_rows, &cell_cols );
if ((cell_rows > 1) || (cell_cols > 1))
int diff = h - m_rowHeights[row];
m_rowHeights[row] = h;
- int i;
- for ( i = row; i < m_numRows; i++ )
+ for ( int i = row; i < m_numRows; i++ )
{
m_rowBottoms[i] += diff;
}
int diff = w - m_colWidths[col];
m_colWidths[col] = w;
- int i;
- int colPos;
- for ( colPos = GetColPos( col ); colPos < m_numCols; colPos++ )
+ for ( int colPos = GetColPos(col); colPos < m_numCols; colPos++ )
{
- i = GetColAt( colPos );
- m_colRights[i] += diff;
+ m_colRights[GetColAt(colPos)] += diff;
}
if ( !GetBatchCount() )
{
BeginBatch();
- wxSize size(SetOrCalcColumnSizes(false), SetOrCalcRowSizes(false));
-
- // round up the size to a multiple of scroll step - this ensures that we
- // won't get the scrollbars if we're sized exactly to this width
- // CalcDimension adds m_extraWidth + 1 etc. to calculate the necessary
- // scrollbar steps
- wxSize sizeFit(
- GetScrollX(size.x + m_extraWidth + 1) * m_scrollLineX,
- GetScrollY(size.y + m_extraHeight + 1) * m_scrollLineY );
+ // we need to round up the size of the scrollable area to a multiple of
+ // scroll step to ensure that we don't get the scrollbars when we're sized
+ // exactly to fit our contents
+ wxSize size(SetOrCalcColumnSizes(false) - m_rowLabelWidth + m_extraWidth,
+ SetOrCalcRowSizes(false) - m_colLabelHeight + m_extraHeight);
+ wxSize sizeFit(GetScrollX(size.x) * GetScrollLineX(),
+ GetScrollY(size.y) * GetScrollLineY());
// distribute the extra space between the columns/rows to avoid having
// extra white space
-
- // Remove the extra m_extraWidth + 1 added above
- wxCoord diff = sizeFit.x - size.x + (m_extraWidth + 1);
+ wxCoord diff = sizeFit.x - size.x;
if ( diff && m_numCols )
{
// try to resize the columns uniformly
}
// same for rows
- diff = sizeFit.y - size.y - (m_extraHeight + 1);
+ diff = sizeFit.y - size.y;
if ( diff && m_numRows )
{
// try to resize the columns uniformly
}
}
- EndBatch();
+ // we know that we're not going to have scrollbars so disable them now to
+ // avoid trouble in SetClientSize() which can otherwise set the correct
+ // client size but also leave space for (not needed any more) scrollbars
+ SetScrollbars(0, 0, 0, 0, 0, 0, true);
+ SetClientSize(sizeFit.x + m_rowLabelWidth, sizeFit.y + m_colLabelHeight);
- SetClientSize(sizeFit);
+ EndBatch();
}
void wxGrid::AutoSizeRowLabelSize( int row )
projects / wxWidgets.git / blobdiff