/////////////////////////////////////////////////////////////////////////////
-// Name: msw/statbox.cpp
+// Name: src/msw/statbox.cpp
// Purpose: wxStaticBox
// Author: Julian Smart
// Modified by:
// headers
// ----------------------------------------------------------------------------
-#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)
- #pragma implementation "statbox.h"
-#endif
-
// For compilers that support precompilation, includes "wx.h".
#include "wx/wxprec.h"
#if wxUSE_STATBOX
+#include "wx/statbox.h"
+
#ifndef WX_PRECOMP
#include "wx/app.h"
#include "wx/dcclient.h"
+ #include "wx/dcmemory.h"
+ #include "wx/image.h"
#endif
-#include "wx/statbox.h"
#include "wx/notebook.h"
#include "wx/sysopt.h"
-#include "wx/image.h"
-#include "wx/dcmemory.h"
+#include "wx/msw/uxtheme.h"
#include "wx/msw/private.h"
+#include "wx/msw/missing.h"
+#include "wx/msw/dc.h"
+
+// the values coincide with those in tmschema.h
+#define BP_GROUPBOX 4
+
+#define GBS_NORMAL 1
+
+#define TMT_FONT 210
// ----------------------------------------------------------------------------
// wxWin macros
if ( !MSWCreateControl(wxT("BUTTON"), label, pos, size) )
return false;
+ // Always use LTR layout. Otherwise, the label would be mirrored.
+ SetLayoutDirection(wxLayout_LeftToRight);
+
#ifndef __WXWINCE__
- Connect(wxEVT_PAINT, wxPaintEventHandler(wxStaticBox::OnPaint));
-#endif
+ if (!wxSystemOptions::IsFalse(wxT("msw.staticbox.optimized-paint")))
+ Connect(wxEVT_PAINT, wxPaintEventHandler(wxStaticBox::OnPaint));
+#endif // !__WXWINCE__
return true;
}
-wxBorder wxStaticBox::GetDefaultBorder() const
-{
- return wxBORDER_NONE;
-}
-
WXDWORD wxStaticBox::MSWGetStyle(long style, WXDWORD *exstyle) const
{
long styleWin = wxStaticBoxBase::MSWGetStyle(style, exstyle);
styleWin &= ~WS_CLIPCHILDREN;
if ( exstyle )
- *exstyle = 0;
+ {
+#ifndef __WXWINCE__
+ if (wxSystemOptions::IsFalse(wxT("msw.staticbox.optimized-paint")))
+ *exstyle = WS_EX_TRANSPARENT;
+ else
+#endif
+ *exstyle = 0;
+ }
+
+ styleWin |= BS_GROUPBOX;
- return styleWin | BS_GROUPBOX;
+ if ( wxTheApp->GetLayoutDirection() == wxLayout_RightToLeft )
+ {
+ // Make sure label is on the right
+ styleWin |= BS_RIGHT;
+ }
+
+ return styleWin;
}
wxSize wxStaticBox::DoGetBestSize() const
wxGetCharSize(GetHWND(), &cx, &cy, GetFont());
int wBox;
- GetTextExtent(wxGetWindowText(m_hWnd), &wBox, &cy);
+ GetTextExtent(GetLabelText(wxGetWindowText(m_hWnd)), &wBox, &cy);
wBox += 3*cx;
int hBox = EDIT_HEIGHT_FROM_CHAR_HEIGHT(cy);
- return wxSize(wBox, hBox);
+ wxSize best(wBox, hBox);
+ CacheBestSize(best);
+ return best;
}
-WXLRESULT wxStaticBox::MSWWindowProc(WXUINT nMsg, WXWPARAM wParam, WXLPARAM lParam)
+void wxStaticBox::GetBordersForSizer(int *borderTop, int *borderOther) const
{
+ wxStaticBoxBase::GetBordersForSizer(borderTop, borderOther);
+
+ // need extra space, don't know how much but this seems to be enough
+ *borderTop += GetCharHeight()/3;
+}
+
+// all the hacks below are not necessary for WinCE
#ifndef __WXWINCE__
+
+WXLRESULT wxStaticBox::MSWWindowProc(WXUINT nMsg, WXWPARAM wParam, WXLPARAM lParam)
+{
if ( nMsg == WM_NCHITTEST )
{
// This code breaks some other processing such as enter/leave tracking
s_useHTClient = wxSystemOptions::GetOptionInt(wxT("msw.staticbox.htclient"));
if (s_useHTClient == 1)
{
- int xPos = LOWORD(lParam); // horizontal position of cursor
- int yPos = HIWORD(lParam); // vertical position of cursor
+ int xPos = GET_X_LPARAM(lParam);
+ int yPos = GET_Y_LPARAM(lParam);
ScreenToClient(&xPos, &yPos);
return (long)HTCLIENT;
}
}
-#endif // !__WXWINCE__
+
+ if ( nMsg == WM_PRINTCLIENT )
+ {
+ // we have to process WM_PRINTCLIENT ourselves as otherwise child
+ // windows' background (eg buttons in radio box) would never be drawn
+ // unless we have a parent with non default background
+
+ // so check first if we have one
+ if ( !HandlePrintClient((WXHDC)wParam) )
+ {
+ // no, we don't, erase the background ourselves
+ // (don't use our own) - see PaintBackground for explanation
+ wxBrush brush(GetParent()->GetBackgroundColour());
+ wxFillRect(GetHwnd(), (HDC)wParam, GetHbrushOf(brush));
+ }
+
+ return 0;
+ }
return wxControl::MSWWindowProc(nMsg, wParam, lParam);
}
-void wxStaticBox::GetBordersForSizer(int *borderTop, int *borderOther) const
-{
- wxStaticBoxBase::GetBordersForSizer(borderTop, borderOther);
+// ----------------------------------------------------------------------------
+// static box drawing
+// ----------------------------------------------------------------------------
- // need extra space, don't know how much but this seems to be enough
- *borderTop += GetCharHeight()/3;
-}
+/*
+ We draw the static box ourselves because it's the only way to prevent it
+ from flickering horribly on resize (because everything inside the box is
+ erased twice: once when the box itself is repainted and second time when
+ the control inside it is repainted) without using WS_EX_TRANSPARENT style as
+ we used to do and which resulted in other problems.
+ */
// MSWGetRegionWithoutSelf helper: removes the given rectangle from region
static inline void
AutoHRGN hrgnRect(::CreateRectRgn(left, top, right, bottom));
if ( !hrgnRect )
{
- wxLogLastError(_T("CreateRectRgn()"));
+ wxLogLastError(wxT("CreateRectRgn()"));
return;
}
RECT rc;
::GetWindowRect(GetHwnd(), &rc);
HRGN hrgn = ::CreateRectRgn(rc.left, rc.top, rc.right + 1, rc.bottom + 1);
+ bool foundThis = false;
// iterate over all child windows (not just wxWindows but all windows)
for ( HWND child = ::GetWindow(GetHwndOf(GetParent()), GW_CHILD);
child;
child = ::GetWindow(child, GW_HWNDNEXT) )
{
- wxWindow *childWindow = wxGetWindowFromHWND((WXHWND) child);
+ if ( ! ::IsWindowVisible(child) )
+ {
+ // if the window isn't visible then it doesn't need clipped
+ continue;
+ }
- // can't just test for (this != child) here since if a wxStaticBox
- // overlaps another wxStaticBox then neither are drawn. The overlapping
- // region will flicker but we shouldn't have overlapping windows anyway.
- if ( !childWindow || !wxDynamicCast(childWindow, wxStaticBox) )
+ LONG style = ::GetWindowLong(child, GWL_STYLE);
+ wxString str(wxGetWindowClass(child));
+ str.UpperCase();
+ if ( str == wxT("BUTTON") && (style & BS_GROUPBOX) == BS_GROUPBOX )
{
- ::GetWindowRect(child, &rc);
- if ( ::RectInRegion(hrgn, &rc) )
- {
- // need to remove WS_CLIPSIBLINGS from all sibling windows
- // that are within this staticbox if set
- LONG style = ::GetWindowLong(child, GWL_STYLE);
- if ( style & WS_CLIPSIBLINGS )
- {
- style &= ~WS_CLIPSIBLINGS;
- ::SetWindowLong(child, GWL_STYLE, style);
-
- // MSDN: "If you have changed certain window data using
- // SetWindowLong, you must call SetWindowPos to have the
- // changes take effect."
- ::SetWindowPos(child, NULL, 0, 0, 0, 0,
- SWP_NOMOVE | SWP_NOSIZE | SWP_NOZORDER |
- SWP_FRAMECHANGED);
- }
+ if ( child == GetHwnd() )
+ foundThis = true;
+
+ // Any static boxes below this one in the Z-order can't be clipped
+ // since if we have the case where a static box with a low Z-order
+ // is nested inside another static box with a high Z-order then the
+ // nested static box would be painted over. Doing it this way
+ // unfortunately results in flicker if the Z-order of nested static
+ // boxes is not inside (lowest) to outside (highest) but at least
+ // they are still shown.
+ if ( foundThis )
+ continue;
+ }
- AutoHRGN hrgnChild(::CreateRectRgnIndirect(&rc));
- ::CombineRgn(hrgn, hrgn, hrgnChild, RGN_DIFF);
+ ::GetWindowRect(child, &rc);
+ if ( ::RectInRegion(hrgn, &rc) )
+ {
+ // need to remove WS_CLIPSIBLINGS from all sibling windows
+ // that are within this staticbox if set
+ if ( style & WS_CLIPSIBLINGS )
+ {
+ style &= ~WS_CLIPSIBLINGS;
+ ::SetWindowLong(child, GWL_STYLE, style);
+
+ // MSDN: "If you have changed certain window data using
+ // SetWindowLong, you must call SetWindowPos to have the
+ // changes take effect."
+ ::SetWindowPos(child, NULL, 0, 0, 0, 0,
+ SWP_NOMOVE | SWP_NOSIZE | SWP_NOZORDER |
+ SWP_FRAMECHANGED);
}
+
+ AutoHRGN hrgnChild(::CreateRectRgnIndirect(&rc));
+ ::CombineRgn(hrgn, hrgn, hrgnChild, RGN_DIFF);
}
}
return (WXHRGN)hrgn;
}
-// helper for OnPaint()
+// helper for OnPaint(): really erase the background, i.e. do it even if we
+// don't have any non default brush for doing it (DoEraseBackground() doesn't
+// do anything in such case)
void wxStaticBox::PaintBackground(wxDC& dc, const RECT& rc)
{
- // note that static box should be transparent, so it should show its
- // parents colour, not its own
- wxWindow * const parent = GetParent();
-
- HBRUSH hbr = (HBRUSH)parent->MSWGetBgBrush(dc.GetHDC());
+ // note that we do not use the box background colour here, it shouldn't
+ // apply to its interior for several reasons:
+ // 1. wxGTK doesn't do it
+ // 2. controls inside the box don't get correct bg colour because they
+ // are not our children so we'd have some really ugly colour mix if
+ // we did it
+ // 3. this is backwards compatible behaviour and some people rely on it,
+ // see http://groups.google.com/groups?selm=4252E932.3080801%40able.es
+ wxWindow *parent = GetParent();
+ wxMSWDCImpl *impl = (wxMSWDCImpl*) dc.GetImpl();
+ HBRUSH hbr = (HBRUSH)parent->MSWGetBgBrush(impl->GetHDC(), this);
+
+ // if there is no special brush for painting this control, just use the
+ // solid background colour
+ wxBrush brush;
if ( !hbr )
{
- wxBrush *brush =
- wxTheBrushList->FindOrCreateBrush(parent->GetBackgroundColour());
- if ( brush )
- hbr = GetHbrushOf(*brush);
+ brush = wxBrush(parent->GetBackgroundColour());
+ hbr = GetHbrushOf(brush);
}
- if ( hbr )
- ::FillRect(GetHdcOf(dc), &rc, hbr);
+ ::FillRect(GetHdcOf(*impl), &rc, hbr);
+}
+
+void wxStaticBox::PaintForeground(wxDC& dc, const RECT& rc)
+{
+ wxMSWDCImpl *impl = (wxMSWDCImpl*) dc.GetImpl();
+ MSWDefWindowProc(WM_PAINT, (WPARAM)GetHdcOf(*impl), 0);
+
+ // when using XP themes, neither setting the text colour nor transparent
+ // background mode doesn't change anything: the static box def window proc
+ // still draws the label in its own colours, so we need to redraw the text
+ // ourselves if we have a non default fg colour
+ if ( m_hasFgCol && wxUxThemeEngine::GetIfActive() )
+ {
+ // draw over the text in default colour in our colour
+ HDC hdc = GetHdcOf(*impl);
+ ::SetTextColor(hdc, GetForegroundColour().GetPixel());
+
+ const bool rtl = wxTheApp->GetLayoutDirection() == wxLayout_RightToLeft;
+ if ( rtl )
+ ::SetTextAlign(hdc, TA_RTLREADING | TA_RIGHT);
+
+ // Get dimensions of the label
+ const wxString label = GetLabel();
+
+ // choose the correct font
+ AutoHFONT font;
+ SelectInHDC selFont;
+ if ( m_hasFont )
+ {
+ selFont.Init(hdc, GetHfontOf(GetFont()));
+ }
+ else // no font set, use the one set by the theme
+ {
+ wxUxThemeHandle hTheme(this, L"BUTTON");
+ if ( hTheme )
+ {
+ // GetThemeFont() expects its parameter to be LOGFONTW and not
+ // LOGFONTA even in ANSI programs and will happily corrupt
+ // memory after the struct end if we pass a LOGFONTA (which is
+ // smaller) to it!
+ LOGFONTW lfw;
+ if ( wxUxThemeEngine::Get()->GetThemeFont
+ (
+ hTheme,
+ hdc,
+ BP_GROUPBOX,
+ GBS_NORMAL,
+ TMT_FONT,
+ (LOGFONT *)&lfw
+ ) == S_OK )
+ {
+#if wxUSE_UNICODE
+ // ok, no conversion necessary
+ const LOGFONT& lf = lfw;
+#else // !wxUSE_UNICODE
+ // most of the fields are the same in LOGFONTA and LOGFONTW
+ LOGFONT lf;
+ memcpy(&lf, &lfw, sizeof(lf));
+
+ // but the face name must be converted
+ WideCharToMultiByte(CP_ACP, 0, lfw.lfFaceName, -1,
+ lf.lfFaceName, sizeof(lf.lfFaceName),
+ NULL, NULL);
+#endif // wxUSE_UNICODE/!wxUSE_UNICODE
+
+ font.Init(lf);
+ if ( font )
+ selFont.Init(hdc, font);
+ }
+ }
+ }
+
+ // Get the font extent
+ int width, height;
+ dc.GetTextExtent(wxStripMenuCodes(label, wxStrip_Mnemonics),
+ &width, &height);
+
+ int x;
+ int y = height;
+
+ // first we need to correctly paint the background of the label
+ // as Windows ignores the brush offset when doing it
+ //
+ // FIXME: value of x is hardcoded as this is what it is on my system,
+ // no idea if it's true everywhere
+ RECT dimensions = {0, 0, 0, y};
+ if ( !rtl )
+ {
+ x = 9;
+ dimensions.left = x;
+ dimensions.right = x + width;
+ }
+ else
+ {
+ x = rc.right - 7;
+ dimensions.left = x - width;
+ dimensions.right = x;
+ }
+
+ // need to adjust the rectangle to cover all the label background
+ dimensions.left -= 2;
+ dimensions.right += 2;
+ dimensions.bottom += 2;
+
+ if ( UseBgCol() )
+ {
+ // our own background colour should be used for the background of
+ // the label: this is consistent with the behaviour under pre-XP
+ // systems (i.e. without visual themes) and generally makes sense
+ wxBrush brush = wxBrush(GetBackgroundColour());
+ wxMSWDCImpl *impl = (wxMSWDCImpl*) dc.GetImpl();
+ ::FillRect(GetHdcOf(*impl), &dimensions, GetHbrushOf(brush));
+ }
+ else // paint parent background
+ {
+ PaintBackground(dc, dimensions);
+ }
+
+ // now draw the text
+ if ( !rtl )
+ {
+ RECT rc2 = { x, 0, x + width, y };
+ ::DrawText(hdc, label.wx_str(), label.length(), &rc2,
+ DT_SINGLELINE | DT_VCENTER);
+ }
+ else // RTL
+ {
+ RECT rc2 = { x, 0, x - width, y };
+ ::DrawText(hdc, label.wx_str(), label.length(), &rc2,
+ DT_SINGLELINE | DT_VCENTER | DT_RTLREADING);
+ }
+ }
}
void wxStaticBox::OnPaint(wxPaintEvent& WXUNUSED(event))
{
- wxPaintDC dc(this);
RECT rc;
::GetClientRect(GetHwnd(), &rc);
- // draw the entire box in a memory DC, but only blit the bits not redrawn
- // either by our children windows nor by FillRect() painting the background
- // below
+ // draw the entire box in a memory DC
wxMemoryDC memdc;
wxBitmap bitmap(rc.right, rc.bottom);
memdc.SelectObject(bitmap);
PaintBackground(memdc, rc);
- MSWDefWindowProc(WM_PAINT, (WPARAM)GetHdcOf(memdc), 0);
-
+ PaintForeground(memdc, rc);
+
+ // now only blit the static box border itself, not the interior, to avoid
+ // flicker when background is drawn below
+ //
+ // note that it seems to be faster to do 4 small blits here and then paint
+ // directly into wxPaintDC than painting background in wxMemoryDC and then
+ // blitting everything at once to wxPaintDC, this is why we do it like this
+ wxPaintDC dc(this);
int borderTop, border;
GetBordersForSizer(&borderTop, &border);
dc.Blit(border, 0, rc.right - border, borderTop,
&memdc, border, 0);
// bottom
- dc.Blit(border, rc.bottom - border, rc.right - border, rc.bottom,
+ dc.Blit(border, rc.bottom - border, rc.right - border, border,
&memdc, border, rc.bottom - border);
// left
dc.Blit(0, 0, border, rc.bottom,
&memdc, 0, 0);
- // right
- dc.Blit(rc.right - border, 0, rc.right, rc.bottom,
- &memdc, rc.right - border, 0);
+ // right (note that upper and bottom right corners were already part of the
+ // first two blits so we shouldn't overwrite them here to avoi flicker)
+ dc.Blit(rc.right - border, borderTop,
+ border, rc.bottom - borderTop - border,
+ &memdc, rc.right - border, borderTop);
+
+ // create the region excluding box children
AutoHRGN hrgn((HRGN)MSWGetRegionWithoutChildren());
RECT rcWin;
::GetWindowRect(GetHwnd(), &rcWin);
::OffsetRgn(hrgn, -rcWin.left, -rcWin.top);
-
- // now remove the box itself
+ // and also the box itself
MSWGetRegionWithoutSelf((WXHRGN) hrgn, rc.right, rc.bottom);
+ wxMSWDCImpl *impl = (wxMSWDCImpl*) dc.GetImpl();
+ HDCClipper clipToBg(GetHdcOf(*impl), hrgn);
- // and paint the inside of the box (excluding child controls)
- ::SelectClipRgn(GetHdcOf(dc), hrgn);
+ // paint the inside of the box (excluding box itself and child controls)
PaintBackground(dc, rc);
- ::SelectClipRgn(GetHdcOf(dc), NULL);
}
-#endif // wxUSE_STATBOX
+#endif // !__WXWINCE__
+#endif // wxUSE_STATBOX
projects / wxWidgets.git / blobdiff