compilation warning (and possible bug) fix

[wxWidgets.git] / include / wx / gtk / choice.h

diff --git a/include/wx/gtk/choice.h b/include/wx/gtk/choice.h
index 6631f12bcc12d8a20cdc2d0c2b9b16e6bc9dacea..279e80d7fb79a0beede6ef4e3367ca63611e06b7 100644 (file)
--- a/include/wx/gtk/choice.h
+++ b/include/wx/gtk/choice.h
@@ -30,6 +30,8 @@ public:
             const wxValidator& validator = wxDefaultValidator,
             const wxString& name = wxChoiceNameStr )
     {
             const wxValidator& validator = wxDefaultValidator,
             const wxString& name = wxChoiceNameStr )
     {

+        m_strings = (wxSortedArrayString *)NULL;
+

         Create(parent, id, pos, size, n, choices, style, validator, name);
     }
     ~wxChoice();
         Create(parent, id, pos, size, n, choices, style, validator, name);
     }
     ~wxChoice();


@@ -49,27 +51,31 @@ public:
     void SetSelection( int n );
 
     virtual int GetCount() const;
     void SetSelection( int n );
 
     virtual int GetCount() const;

-    int FindString( const wxString &string ) const;
+    int FindString( const wxString& string ) const;

     wxString GetString( int n ) const;
     wxString GetString( int n ) const;

+    void SetString( int n, const wxString& string );

 
 

-    // implementation
-    wxList   m_clientDataList;
-    wxList   m_clientObjectList;
+protected:
+    wxList m_clientList;    // contains the client data for the items

 
 

-    void DisableEvents();
-    void EnableEvents();
-    void AppendCommon( const wxString &item );

     void ApplyWidgetStyle();
     void ApplyWidgetStyle();

-    
-protected:

     virtual int DoAppend(const wxString& item);
 
     virtual int DoAppend(const wxString& item);
 

-    virtual void DoSetClientData( int n, void* clientData );
-    virtual void* DoGetClientData( int n ) const;
-    virtual void DoSetClientObject( int n, wxClientData* clientData );
-    virtual wxClientData* DoGetClientObject( int n ) const;
+    virtual void DoSetItemClientData( int n, void* clientData );
+    virtual void* DoGetItemClientData( int n ) const;
+    virtual void DoSetItemClientObject( int n, wxClientData* clientData );
+    virtual wxClientData* DoGetItemClientObject( int n ) const;
+
+    virtual wxSize DoGetBestSize() const;

 
 private:
 
 private:

+    // common part of Create() and DoAppend()
+    size_t GtkAppendHelper(GtkWidget *menu, const wxString& item);
+
+    // this array is only used for controls with wxCB_SORT style, so only
+    // allocate it if it's needed (hence using pointer)
+    wxSortedArrayString *m_strings;
+

     DECLARE_DYNAMIC_CLASS(wxChoice)
 };
 
     DECLARE_DYNAMIC_CLASS(wxChoice)
 };