No real changes, just refactor wxControlContainer code a little.

[wxWidgets.git] / src / msw / radiobox.cpp

diff --git a/src/msw/radiobox.cpp b/src/msw/radiobox.cpp
index 4c8017f88147962c1e9545947d98462e99b4b42e..70665bdf845c7c589b698c79312223a75deab9f5 100644 (file)
--- a/src/msw/radiobox.cpp
+++ b/src/msw/radiobox.cpp
@@ -1,12 +1,12 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        radiobox.cpp
-// Purpose:     wxRadioBox
+// Name:        src/msw/radiobox.cpp
+// Purpose:     wxRadioBox implementation

 // Author:      Julian Smart
 // Modified by:
 // Created:     04/01/98
 // RCS-ID:      $Id$
 // Author:      Julian Smart
 // Modified by:
 // Created:     04/01/98
 // RCS-ID:      $Id$

-// Copyright:   (c) Julian Smart and Markus Holzem
-// Licence:     wxWindows license
+// Copyright:   (c) Julian Smart
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 // ===========================================================================
 /////////////////////////////////////////////////////////////////////////////
 
 // ===========================================================================


@@ -17,10 +17,6 @@
 // headers
 // ---------------------------------------------------------------------------
 
 // headers
 // ---------------------------------------------------------------------------
 

-#ifdef __GNUG__
-    #pragma implementation "radiobox.h"
-#endif
-

 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 


@@ -28,761 +24,900 @@
     #pragma hdrstop
 #endif
 
     #pragma hdrstop
 #endif
 

+#if wxUSE_RADIOBOX
+
+#include "wx/radiobox.h"
+

 #ifndef WX_PRECOMP
 #ifndef WX_PRECOMP

-    #include <stdio.h>
-    #include "wx/setup.h"
+    #include "wx/hashmap.h"

     #include "wx/bitmap.h"
     #include "wx/brush.h"
     #include "wx/bitmap.h"
     #include "wx/brush.h"

-    #include "wx/radiobox.h"
+    #include "wx/settings.h"
+    #include "wx/log.h"

 #endif
 
 #endif
 

-#include "wx/msw/private.h"
+#include "wx/msw/subwin.h"
+
+#if wxUSE_TOOLTIPS
+    #include "wx/tooltip.h"
+#endif // wxUSE_TOOLTIPS
+
+// TODO: wxCONSTRUCTOR
+#if 0 // wxUSE_EXTENDED_RTTI
+WX_DEFINE_FLAGS( wxRadioBoxStyle )
+
+wxBEGIN_FLAGS( wxRadioBoxStyle )
+    // new style border flags, we put them first to
+    // use them for streaming out
+    wxFLAGS_MEMBER(wxBORDER_SIMPLE)
+    wxFLAGS_MEMBER(wxBORDER_SUNKEN)
+    wxFLAGS_MEMBER(wxBORDER_DOUBLE)
+    wxFLAGS_MEMBER(wxBORDER_RAISED)
+    wxFLAGS_MEMBER(wxBORDER_STATIC)
+    wxFLAGS_MEMBER(wxBORDER_NONE)
+
+    // old style border flags
+    wxFLAGS_MEMBER(wxSIMPLE_BORDER)
+    wxFLAGS_MEMBER(wxSUNKEN_BORDER)
+    wxFLAGS_MEMBER(wxDOUBLE_BORDER)
+    wxFLAGS_MEMBER(wxRAISED_BORDER)
+    wxFLAGS_MEMBER(wxSTATIC_BORDER)
+    wxFLAGS_MEMBER(wxBORDER)
+
+    // standard window styles
+    wxFLAGS_MEMBER(wxTAB_TRAVERSAL)
+    wxFLAGS_MEMBER(wxCLIP_CHILDREN)
+    wxFLAGS_MEMBER(wxTRANSPARENT_WINDOW)
+    wxFLAGS_MEMBER(wxWANTS_CHARS)
+    wxFLAGS_MEMBER(wxFULL_REPAINT_ON_RESIZE)
+    wxFLAGS_MEMBER(wxALWAYS_SHOW_SB )
+    wxFLAGS_MEMBER(wxVSCROLL)
+    wxFLAGS_MEMBER(wxHSCROLL)
+
+    wxFLAGS_MEMBER(wxRA_SPECIFY_COLS)
+    wxFLAGS_MEMBER(wxRA_SPECIFY_ROWS)
+wxEND_FLAGS( wxRadioBoxStyle )
+
+IMPLEMENT_DYNAMIC_CLASS_XTI(wxRadioBox, wxControl,"wx/radiobox.h")
+
+wxBEGIN_PROPERTIES_TABLE(wxRadioBox)
+    wxEVENT_PROPERTY( Select , wxEVT_RADIOBOX , wxCommandEvent )
+    wxPROPERTY_FLAGS( WindowStyle , wxRadioBoxStyle , long , SetWindowStyleFlag , GetWindowStyleFlag , , 0 /*flags*/ , wxT("Helpstring") , wxT("group")) // style
+wxEND_PROPERTIES_TABLE()

 
 

-#if !USE_SHARED_LIBRARY
-    IMPLEMENT_DYNAMIC_CLASS(wxRadioBox, wxControl)
+#else
+IMPLEMENT_DYNAMIC_CLASS(wxRadioBox, wxControl)

 #endif
 
 #endif
 

+/*
+    selection
+    content
+        label
+        dimension
+        item
+*/
+

 // ---------------------------------------------------------------------------
 // private functions
 // ---------------------------------------------------------------------------
 
 // ---------------------------------------------------------------------------
 // private functions
 // ---------------------------------------------------------------------------
 

-// get the id of the window
-#ifdef __WIN32__
-    #define GET_WIN_ID(hwnd) ::GetWindowLong((HWND)hwnd, GWL_ID)
-#else // Win16
-    #define GET_WIN_ID(hwnd) ::GetWindowWord((HWND)hwnd, GWW_ID)
-#endif // Win32/16
-

 // wnd proc for radio buttons
 // wnd proc for radio buttons

-#ifdef __WIN32__

 LRESULT APIENTRY _EXPORT wxRadioBtnWndProc(HWND hWnd,
                                            UINT message,
                                            WPARAM wParam,
                                            LPARAM lParam);
 LRESULT APIENTRY _EXPORT wxRadioBtnWndProc(HWND hWnd,
                                            UINT message,
                                            WPARAM wParam,
                                            LPARAM lParam);

-#endif

 
 // ---------------------------------------------------------------------------
 // global vars
 // ---------------------------------------------------------------------------
 
 
 // ---------------------------------------------------------------------------
 // global vars
 // ---------------------------------------------------------------------------
 

+namespace
+{
+

 // the pointer to standard radio button wnd proc
 // the pointer to standard radio button wnd proc

-static WNDPROC s_wndprocRadioBtn = (WNDPROC)NULL;
+WXFARPROC s_wndprocRadioBtn = (WXFARPROC)NULL;
+
+// Hash allowing to find wxRadioBox containing the given radio button by its
+// HWND. This is used by (subclassed) radio button window proc to find the
+// radio box it belongs to.
+WX_DECLARE_HASH_MAP(HWND, wxRadioBox *,
+                    wxPointerHash, wxPointerEqual,
+                    RadioBoxFromButton);
+
+RadioBoxFromButton gs_boxFromButton;
+
+} // anonymous namespace

 
 // ===========================================================================
 // implementation
 // ===========================================================================
 
 
 // ===========================================================================
 // implementation
 // ===========================================================================
 

+/* static */
+wxRadioBox* wxRadioBox::GetFromRadioButtonHWND(WXHWND hwnd)
+{
+    const RadioBoxFromButton::const_iterator it = gs_boxFromButton.find(hwnd);
+    return it == gs_boxFromButton.end() ? NULL : it->second;
+}
+

 // ---------------------------------------------------------------------------
 // ---------------------------------------------------------------------------

-// wxRadioBox
+// wxRadioBox creation

 // ---------------------------------------------------------------------------
 
 // ---------------------------------------------------------------------------
 

-int wxRadioBox::GetNumVer() const
+// Radio box item
+void wxRadioBox::Init()

 {
 {

-    if ( m_windowStyle & wxRA_SPECIFY_ROWS )
-    {
-        return m_majorDim;
-    }
-    else
-    {
-        return (m_noItems + m_majorDim - 1)/m_majorDim;
-    }
+    m_selectedButton = wxNOT_FOUND;
+    m_radioButtons = NULL;
+    m_dummyHwnd = NULL;
+    m_radioWidth = NULL;
+    m_radioHeight = NULL;

 }
 
 }
 

-int wxRadioBox::GetNumHor() const
-{
-    if ( m_windowStyle & wxRA_SPECIFY_ROWS )
-    {
-        return (m_noItems + m_majorDim - 1)/m_majorDim;
-    }
-    else
-    {
-        return m_majorDim;
-    }
-}
+bool wxRadioBox::Create(wxWindow *parent,
+                        wxWindowID id,
+                        const wxString& title,
+                        const wxPoint& pos,
+                        const wxSize& size,
+                        int n,
+                        const wxString choices[],
+                        int majorDim,
+                        long style,
+                        const wxValidator& val,
+                        const wxString& name)
+{
+    // common initialization
+    if ( !wxStaticBox::Create(parent, id, title, pos, size, style, name) )
+        return false;
+
+    // the code elsewhere in this file supposes that either wxRA_SPECIFY_COLS
+    // or wxRA_SPECIFY_ROWS is set, ensure that this is indeed the case
+    if ( !(style & (wxRA_SPECIFY_ROWS | wxRA_SPECIFY_COLS)) )
+        style |= wxRA_SPECIFY_COLS;
+
+#if wxUSE_VALIDATORS
+    SetValidator(val);
+#else
+    wxUnusedVar(val);
+#endif // wxUSE_VALIDATORS/!wxUSE_VALIDATORS
+
+    // We need an extra one to keep track of the 'dummy' item we
+    // create to end the radio group, so it will be destroyed and
+    // it's id will be released.  But we want it separate from the
+    // other buttons since the wxSubwindows will operate on it as
+    // well and we just want to ignore it until destroying it.
+    // For instance, we don't want the bounding box of the radio
+    // buttons to include the dummy button
+    m_radioButtons = new wxSubwindows(n);

 
 

-bool wxRadioBox::MSWCommand(WXUINT param, WXWORD id)
-{
-    if ( param == BN_CLICKED )
+    m_radioWidth = new int[n];
+    m_radioHeight = new int[n];
+
+    for ( int i = 0; i < n; i++ )

     {
     {

-        m_selectedButton = -1;
+        m_radioWidth[i] =
+        m_radioHeight[i] = wxDefaultCoord;
+        long styleBtn = BS_AUTORADIOBUTTON | WS_TABSTOP | WS_CHILD | WS_VISIBLE;
+        if ( i == 0 )
+            styleBtn |= WS_GROUP;
+
+        wxWindowIDRef subid = NewControlId();
+
+        HWND hwndBtn = ::CreateWindow(wxT("BUTTON"),
+                                      choices[i].t_str(),
+                                      styleBtn,
+                                      0, 0, 0, 0,   // will be set in SetSize()
+                                      GetHwndOf(parent),
+                                      (HMENU)wxUIntToPtr(subid.GetValue()),
+                                      wxGetInstance(),
+                                      NULL);

 
 

-        for ( int i = 0; i < m_noItems; i++ )
+        if ( !hwndBtn )

         {
         {

-            if ( id == GET_WIN_ID(m_radioButtons[i]) )
-            {
-                m_selectedButton = i;
+            wxLogLastError(wxT("CreateWindow(radio btn)"));

 
 

-                break;
-            }
+            return false;

         }
 
         }
 

-        wxASSERT_MSG( m_selectedButton != -1, "click from alien button?" );
+        // Keep track of the subwindow
+        m_radioButtons->Set(i, hwndBtn, subid);

 
 

-        wxCommandEvent event(wxEVT_COMMAND_RADIOBOX_SELECTED, m_windowId);
-        event.SetInt( m_selectedButton );
-        event.SetEventObject( this );
-        ProcessCommand(event);
+        SubclassRadioButton((WXHWND)hwndBtn);

 
 

-        return TRUE;
+        // Also, make it a subcontrol of this control
+        m_subControls.Add(subid);

     }
     }

-    else
-        return FALSE;
-}

 
 

-#if WXWIN_COMPATIBILITY
-wxRadioBox::wxRadioBox(wxWindow *parent, wxFunction func, const char *title,
-        int x, int y, int width, int height,
-        int n, char **choices,
-        int majorDim, long style, const char *name)
-{
-    wxString *choices2 = new wxString[n];
-    for ( int i = 0; i < n; i ++) choices2[i] = choices[i];
-    Create(parent, -1, title, wxPoint(x, y), wxSize(width, height), n, choices2, majorDim, style,
-            wxDefaultValidator, name);
-    Callback(func);
-    delete choices2;
-}
+    // Create a dummy radio control to end the group.
+    m_dummyId = NewControlId();
+
+    m_dummyHwnd = (WXHWND)::CreateWindow(wxT("BUTTON"),
+                         wxEmptyString,
+                         WS_GROUP | BS_AUTORADIOBUTTON | WS_CHILD,
+                         0, 0, 0, 0, GetHwndOf(parent),
+                         (HMENU)wxUIntToPtr(m_dummyId.GetValue()),
+                         wxGetInstance(), NULL);
+
+
+    m_radioButtons->SetFont(GetFont());

 
 

+#ifdef __WXWINCE__
+    // Set the z-order correctly
+    SetWindowPos(GetHwnd(), HWND_BOTTOM, 0, 0, 0, 0, SWP_NOMOVE|SWP_NOSIZE);

 #endif
 
 #endif
 

-// Radio box item
-wxRadioBox::wxRadioBox()
+    SetMajorDim(majorDim == 0 ? n : majorDim, style);
+    SetSelection(0);
+    SetSize(pos.x, pos.y, size.x, size.y);
+
+    // Now that we have items determine what is the best size and set it.
+    SetInitialSize(size);
+
+    // And update all the buttons positions to match it.
+    const wxSize actualSize = GetSize();
+    PositionAllButtons(pos.x, pos.y, actualSize.x, actualSize.y);
+
+    return true;
+}
+
+bool wxRadioBox::Create(wxWindow *parent,
+                        wxWindowID id,
+                        const wxString& title,
+                        const wxPoint& pos,
+                        const wxSize& size,
+                        const wxArrayString& choices,
+                        int majorDim,
+                        long style,
+                        const wxValidator& val,
+                        const wxString& name)

 {
 {

-    m_selectedButton = -1;
-    m_noItems = 0;
-    m_noRowsOrCols = 0;
-    m_radioButtons = NULL;
-    m_majorDim = 0;
-    m_radioWidth = NULL;
-    m_radioHeight = NULL;
+    wxCArrayString chs(choices);
+    return Create(parent, id, title, pos, size, chs.GetCount(),
+                  chs.GetStrings(), majorDim, style, val, name);

 }
 
 }
 

-bool wxRadioBox::Create(wxWindow *parent, wxWindowID id, const wxString& title,
-        const wxPoint& pos, const wxSize& size,
-        int n, const wxString choices[],
-        int majorDim, long style,
-        const wxValidator& val, const wxString& name)
+wxRadioBox::~wxRadioBox()

 {
 {

-    m_selectedButton = -1;
-    m_noItems = n;
+    SendDestroyEvent();

 
 

-    SetName(name);
-    SetValidator(val);
+    // Unsubclass all the radio buttons and remove their soon-to-be-invalid
+    // HWNDs from the global map. Notice that we need to unsubclass because
+    // otherwise we'd need the entries in gs_boxFromButton for the buttons
+    // being deleted to handle the messages generated during their destruction.
+    for ( size_t item = 0; item < m_radioButtons->GetCount(); item++ )
+    {
+        HWND hwnd = m_radioButtons->Get(item);

 
 

-    parent->AddChild(this);
-    m_backgroundColour = parent->GetBackgroundColour();
-    m_foregroundColour = parent->GetForegroundColour();
+        wxSetWindowProc(hwnd, reinterpret_cast<WNDPROC>(s_wndprocRadioBtn));
+        gs_boxFromButton.erase(hwnd);
+    }

 
 

-    m_windowStyle = (long&)style;
+    delete m_radioButtons;

 
 

-    int x = pos.x;
-    int y = pos.y;
-    int width = size.x;
-    int height = size.y;
+    if ( m_dummyHwnd )
+        DestroyWindow((HWND)m_dummyHwnd);

 
 

-    if (id == -1)
-        m_windowId = NewControlId();
-    else
-        m_windowId = id;
+    delete[] m_radioWidth;
+    delete[] m_radioHeight;
+}

 
 

-    if ( majorDim == 0 )
-        m_majorDim = n;
-    else
-        m_majorDim = majorDim;
-    m_noRowsOrCols = majorDim;
-
-    long msStyle = GROUP_FLAGS;
-
-    bool want3D;
-    WXDWORD exStyle = Determine3DEffects(0, &want3D);
-    // Even with extended styles, need to combine with WS_BORDER
-    // for them to look right.
-    /*
-       if ( want3D || wxStyleHasBorder(m_windowStyle) )
-       msStyle |= WS_BORDER;
-     */
-
-    HWND hwndParent = (HWND)parent->GetHWND();
-
-    m_hWnd = (WXHWND)::CreateWindowEx
-                        (
-                         (DWORD)exStyle,
-                         GROUP_CLASS,
-                         title,
-                         msStyle,
-                         0, 0, 0, 0,
-                         hwndParent,
-                         (HMENU)m_windowId,
-                         wxGetInstance(),
-                         NULL
-                        );
-
-#if wxUSE_CTL3D
-    if (want3D)
-    {
-        Ctl3dSubclassCtl((HWND)m_hWnd);
-        m_useCtl3D = TRUE;
-    }
-#endif // wxUSE_CTL3D
+// NB: if this code is changed, wxGetWindowForHWND() which relies on having the
+//     radiobox pointer in GWL_USERDATA for radio buttons must be updated too!
+void wxRadioBox::SubclassRadioButton(WXHWND hWndBtn)
+{
+    HWND hwndBtn = (HWND)hWndBtn;

 
 

-    SetFont(parent->GetFont());
+    if ( !s_wndprocRadioBtn )
+        s_wndprocRadioBtn = (WXFARPROC)wxGetWindowProc(hwndBtn);

 
 

-    SubclassWin(m_hWnd);
+    wxSetWindowProc(hwndBtn, wxRadioBtnWndProc);

 
 

-    // Some radio boxes test consecutive id.
-    (void)NewControlId();
-    m_radioButtons = new WXHWND[n];
-    m_radioWidth = new int[n];
-    m_radioHeight = new int[n];
-    int i;
-    for (i = 0; i < n; i++)
-    {
-        m_radioWidth[i] = m_radioHeight[i] = -1;
-        long groupStyle = 0;
-        if ( i == 0 && style == 0 )
-            groupStyle = WS_GROUP;
-        long newId = NewControlId();
-        long msStyle = groupStyle | RADIO_FLAGS;
-
-        HWND hwndBtn = CreateWindowEx(exStyle, RADIO_CLASS,
-                                      choices[i], msStyle,
-                                      0,0,0,0,
-                                      hwndParent,
-                                      (HMENU)newId, wxGetInstance(),
-                                      NULL);
+    gs_boxFromButton[hwndBtn] = this;
+}

 
 

-        m_radioButtons[i] = (WXHWND)hwndBtn;
-        SubclassRadioButton((WXHWND)hwndBtn);
+// ----------------------------------------------------------------------------
+// events generation
+// ----------------------------------------------------------------------------

 
 

-        wxFont& font = GetFont();
-        if ( font.Ok() )
-        {
-            SendMessage(hwndBtn, WM_SETFONT,
-                        (WPARAM)font.GetResourceHandle(), 0L);
-        }
+bool wxRadioBox::MSWCommand(WXUINT cmd, WXWORD id_)
+{
+    const int id = (signed short)id_;

 
 

-        m_subControls.Append((wxObject *)newId);
-    }
+    if ( cmd == BN_CLICKED )
+    {
+        if (id == GetId())
+            return true;

 
 

-    // Create a dummy radio control to end the group.
-    (void)CreateWindowEx(0, RADIO_CLASS, "", WS_GROUP | RADIO_FLAGS,
-                         0, 0, 0, 0, hwndParent,
-                         (HMENU)NewControlId(), wxGetInstance(), NULL);
+        int selectedButton = wxNOT_FOUND;

 
 

-    SetSelection(0);
+        const unsigned int count = GetCount();
+        for ( unsigned int i = 0; i < count; i++ )
+        {
+            const HWND hwndBtn = (*m_radioButtons)[i];
+            if ( id == wxGetWindowId(hwndBtn) )
+            {
+                // we can get BN_CLICKED for a button which just became focused
+                // but it may not be checked, in which case we shouldn't
+                // generate a radiobox selection changed event for it
+                if ( ::SendMessage(hwndBtn, BM_GETCHECK, 0, 0) == BST_CHECKED )
+                    selectedButton = i;

 
 

-    SetSize(x, y, width, height);
+                break;
+            }
+        }

 
 

-    return TRUE;
-}
+        if ( selectedButton == wxNOT_FOUND )
+        {
+            // just ignore it - due to a hack with WM_NCHITTEST handling in our
+            // wnd proc, we can receive dummy click messages when we click near
+            // the radiobox edge (this is ugly but Julian wouldn't let me get
+            // rid of this...)
+            return false;
+        }

 
 

-wxRadioBox::~wxRadioBox()
-{
-    m_isBeingDeleted = TRUE;
+        if ( selectedButton != m_selectedButton )
+        {
+            m_selectedButton = selectedButton;

 
 

-    if (m_radioButtons)
-    {
-        int i;
-        for (i = 0; i < m_noItems; i++)
-            DestroyWindow((HWND) m_radioButtons[i]);
-        delete[] m_radioButtons;
-    }
-    if (m_radioWidth)
-        delete[] m_radioWidth;
-    if (m_radioHeight)
-        delete[] m_radioHeight;
-    if (m_hWnd)
-        ::DestroyWindow((HWND) m_hWnd);
-    m_hWnd = 0;
+            SendNotificationEvent();
+        }
+        //else: don't generate events when the selection doesn't change

 
 

+        return true;
+    }
+    else
+        return false;

 }
 
 }
 

-wxString wxRadioBox::GetLabel(int item) const
+void wxRadioBox::Command(wxCommandEvent & event)

 {
 {

-    GetWindowText((HWND)m_radioButtons[item], wxBuffer, 300);
-    return wxString(wxBuffer);
+    SetSelection (event.GetInt());
+    SetFocus();
+    ProcessCommand(event);

 }
 
 }
 

-void wxRadioBox::SetLabel(int item, const wxString& label)
+void wxRadioBox::SendNotificationEvent()

 {
 {

-    m_radioWidth[item] = m_radioHeight[item] = -1;
-    SetWindowText((HWND)m_radioButtons[item], (const char *)label);
+    wxCommandEvent event(wxEVT_RADIOBOX, m_windowId);
+    event.SetInt( m_selectedButton );
+    event.SetString(GetString(m_selectedButton));
+    event.SetEventObject( this );
+    ProcessCommand(event);

 }
 
 }
 

-void wxRadioBox::SetLabel(int item, wxBitmap *bitmap)
+// ----------------------------------------------------------------------------
+// simple accessors
+// ----------------------------------------------------------------------------
+
+unsigned int wxRadioBox::GetCount() const

 {
 {

-    /*
-       m_radioWidth[item] = bitmap->GetWidth() + FB_MARGIN;
-       m_radioHeight[item] = bitmap->GetHeight() + FB_MARGIN;
-     */
+    return m_radioButtons ? m_radioButtons->GetCount() : 0u;

 }
 
 }
 

-int wxRadioBox::FindString(const wxString& s) const
+void wxRadioBox::SetString(unsigned int item, const wxString& label)

 {
 {

-    int i;
-    for (i = 0; i < m_noItems; i++)
-    {
-        GetWindowText((HWND) m_radioButtons[i], wxBuffer, 1000);
-        if (s == wxBuffer)
-            return i;
-    }
-    return -1;
+    wxCHECK_RET( IsValid(item), wxT("invalid radiobox index") );
+
+    m_radioWidth[item] =
+    m_radioHeight[item] = wxDefaultCoord;
+
+    ::SetWindowText((*m_radioButtons)[item], label.c_str());
+
+    InvalidateBestSize();

 }
 
 void wxRadioBox::SetSelection(int N)
 {
 }
 
 void wxRadioBox::SetSelection(int N)
 {

-    wxCHECK_RET( (N >= 0) && (N < m_noItems), "invalid radiobox index" );
+    wxCHECK_RET( IsValid(N), wxT("invalid radiobox index") );

 
 

-    // Following necessary for Win32s, because Win32s translate BM_SETCHECK
-    if (m_selectedButton >= 0 && m_selectedButton < m_noItems)
-        ::SendMessage((HWND) m_radioButtons[m_selectedButton], BM_SETCHECK, 0, 0L);
+    // unselect the old button
+    if ( m_selectedButton != wxNOT_FOUND )
+        ::SendMessage((*m_radioButtons)[m_selectedButton], BM_SETCHECK, 0, 0L);

 
 

-    ::SendMessage((HWND)m_radioButtons[N], BM_SETCHECK, 1, 0L);
-    ::SetFocus((HWND)m_radioButtons[N]);
+    // and select the new one
+    ::SendMessage((*m_radioButtons)[N], BM_SETCHECK, 1, 0L);

 
     m_selectedButton = N;
 }
 
 
     m_selectedButton = N;
 }
 

-// Get single selection, for single choice list items
-int wxRadioBox::GetSelection() const
-{
-    return m_selectedButton;
-}
-

 // Find string for position
 // Find string for position

-wxString wxRadioBox::GetString(int N) const
+wxString wxRadioBox::GetString(unsigned int item) const

 {
 {

-    return wxGetWindowText(m_radioButtons[N]);
+    wxCHECK_MSG( IsValid(item), wxEmptyString,
+                 wxT("invalid radiobox index") );
+
+    return wxGetWindowText((*m_radioButtons)[item]);

 }
 
 }
 

-// Restored old code.
-void wxRadioBox::DoSetSize(int x, int y, int width, int height, int sizeFlags)
+void wxRadioBox::SetFocus()

 {
 {

-  int currentX, currentY;
-  GetPosition(&currentX, &currentY);
-  int xx = x;
-  int yy = y;
-
-  if (x == -1 || (sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
-    xx = currentX;
-  if (y == -1 || (sizeFlags & wxSIZE_ALLOW_MINUS_ONE))
-    yy = currentY;
-
-  char buf[400];
-
-  int y_offset = yy;
-  int x_offset = xx;
-  int current_width, cyf;
-
-  int cx1,cy1;
-  wxGetCharSize(m_hWnd, &cx1, &cy1, & GetFont());
-  // Attempt to have a look coherent with other platforms:
-  // We compute the biggest toggle dim, then we align all
-  // items according this value.
-  int maxWidth =  -1;
-  int maxHeight = -1;
-
-  int i;
-  for (i = 0 ; i < m_noItems; i++)
-  {
-    int eachWidth;
-    int eachHeight;
-    if (m_radioWidth[i]<0)
-    {
-      // It's a labelled toggle
-      GetWindowText((HWND) m_radioButtons[i], buf, 300);
-      GetTextExtent(buf, &current_width, &cyf,NULL,NULL, & GetFont());
-      eachWidth = (int)(current_width + RADIO_SIZE);
-      eachHeight = (int)((3*cyf)/2);
-    }
-    else
-    {
-      eachWidth = m_radioWidth[i];
-      eachHeight = m_radioHeight[i];
-    }
-    if (maxWidth<eachWidth) maxWidth = eachWidth;
-    if (maxHeight<eachHeight) maxHeight = eachHeight;
-  }
-
-  if (m_hWnd)
-  {
-    int totWidth;
-    int totHeight;
-
-    int nbHor = GetNumHor(),
-        nbVer = GetNumVer();
-
-    // this formula works, but I don't know why.
-    // Please, be sure what you do if you modify it!!
-    if (m_radioWidth[0]<0)
-      totHeight = (nbVer * maxHeight) + cy1/2;
-    else
-      totHeight = nbVer * (maxHeight+cy1/2);
-    totWidth  = nbHor * (maxWidth+cx1);
-
-#if (!CTL3D)
-    // Requires a bigger group box in plain Windows
-    MoveWindow((HWND) m_hWnd,x_offset,y_offset,totWidth+cx1,totHeight+(3*cy1)/2,TRUE);
-#else
-    MoveWindow((HWND) m_hWnd,x_offset,y_offset,totWidth+cx1,totHeight+cy1,TRUE);
-#endif
-    x_offset += cx1;
-    y_offset += cy1;
-  }
-
-#if (!CTL3D)
-  y_offset += (int)(cy1/2); // Fudge factor since buttons overlapped label
-                            // JACS 2/12/93. CTL3D draws group label quite high.
-#endif
-  int startX = x_offset;
-  int startY = y_offset;
-
-  for ( i = 0 ; i < m_noItems; i++)
-  {
-    // Bidimensional radio adjustment
-    if (i&&((i%m_majorDim)==0)) // Why is this omitted for i = 0?
-    {
-      if (m_windowStyle & wxRA_VERTICAL)
-      {
-        y_offset = startY;
-        x_offset += maxWidth + cx1;
-      }
-      else
-      {
-        x_offset = startX;
-        y_offset += maxHeight;
-        if (m_radioWidth[0]>0)
-          y_offset += cy1/2;
-      }
-    }
-    int eachWidth;
-    int eachHeight;
-    if (m_radioWidth[i]<0)
-    {
-      // It's a labeled item
-      GetWindowText((HWND) m_radioButtons[i], buf, 300);
-      GetTextExtent(buf, &current_width, &cyf,NULL,NULL, & GetFont());
-
-      // How do we find out radio button bitmap size!!
-      // By adjusting them carefully, manually :-)
-      eachWidth = (int)(current_width + RADIO_SIZE);
-      eachHeight = (int)((3*cyf)/2);
-    }
-    else
+    if ( GetCount() > 0 )

     {
     {

-      eachWidth = m_radioWidth[i];
-      eachHeight = m_radioHeight[i];
+        ::SetFocus((*m_radioButtons)[m_selectedButton == wxNOT_FOUND
+                                        ? 0
+                                        : m_selectedButton]);

     }
     }

-
-    MoveWindow((HWND) m_radioButtons[i],x_offset,y_offset,eachWidth,eachHeight,TRUE);
-    if (m_windowStyle & wxRA_SPECIFY_ROWS)
-    {
-      y_offset += maxHeight;
-      if (m_radioWidth[0]>0)
-        y_offset += cy1/2;
-    }
-    else
-      x_offset += maxWidth + cx1;
-  }

 }
 
 }
 

-
-void wxRadioBox::GetSize(int *width, int *height) const
+// Enable a specific button
+bool wxRadioBox::Enable(unsigned int item, bool enable)

 {
 {

-    RECT rect;
-    rect.left = -1; rect.right = -1; rect.top = -1; rect.bottom = -1;
+    wxCHECK_MSG( IsValid(item), false,
+                 wxT("invalid item in wxRadioBox::Enable()") );

 
 

-    if (m_hWnd)
-        wxFindMaxSize(m_hWnd, &rect);
+    BOOL ret = MSWEnableHWND((*m_radioButtons)[item], enable);

 
 

-    int i;
-    for (i = 0; i < m_noItems; i++)
-        wxFindMaxSize(m_radioButtons[i], &rect);
-
-    *width = rect.right - rect.left;
-    *height = rect.bottom - rect.top;
+    return (ret == 0) != enable;

 }
 
 }
 

-void wxRadioBox::GetPosition(int *x, int *y) const
+bool wxRadioBox::IsItemEnabled(unsigned int item) const

 {
 {

-    wxWindow *parent = GetParent();
-    RECT rect;
-    rect.left = -1; rect.right = -1; rect.top = -1; rect.bottom = -1;
-
-    int i;
-    for (i = 0; i < m_noItems; i++)
-        wxFindMaxSize(m_radioButtons[i], &rect);
-
-    if (m_hWnd)
-        wxFindMaxSize(m_hWnd, &rect);
-
-    // Since we now have the absolute screen coords,
-    // if there's a parent we must subtract its top left corner
-    POINT point;
-    point.x = rect.left;
-    point.y = rect.top;
-    if (parent)
-    {
-        ::ScreenToClient((HWND) parent->GetHWND(), &point);
-    }
-    // We may be faking the client origin.
-    // So a window that's really at (0, 30) may appear
-    // (to wxWin apps) to be at (0, 0).
-    if (GetParent())
-    {
-        wxPoint pt(GetParent()->GetClientAreaOrigin());
-        point.x -= pt.x;
-        point.y -= pt.y;
-    }
+    wxCHECK_MSG( IsValid(item), false,
+                 wxT("invalid item in wxRadioBox::IsItemEnabled()") );

 
 

-    *x = point.x;
-    *y = point.y;
+    return ::IsWindowEnabled((*m_radioButtons)[item]) != 0;

 }
 
 }
 

-wxString wxRadioBox::GetLabel() const
+// Show a specific button
+bool wxRadioBox::Show(unsigned int item, bool show)

 {
 {

-    if (m_hWnd)
+    wxCHECK_MSG( IsValid(item), false,
+                 wxT("invalid item in wxRadioBox::Show()") );
+
+    BOOL ret = ::ShowWindow((*m_radioButtons)[item], show ? SW_SHOW : SW_HIDE);
+
+    bool changed = (ret != 0) != show;
+    if ( changed )

     {
     {

-        GetWindowText((HWND) m_hWnd, wxBuffer, 300);
-        return wxString(wxBuffer);
+        InvalidateBestSize();

     }
     }

-    else return wxString("");
-}

 
 

-void wxRadioBox::SetLabel(const wxString& label)
-{
-    if (m_hWnd)
-        SetWindowText((HWND) m_hWnd, label);
+    return changed;

 }
 
 }
 

-void wxRadioBox::SetFocus()
+bool wxRadioBox::IsItemShown(unsigned int item) const

 {
 {

-    if (m_noItems > 0)
-    {
-        if (m_selectedButton == -1)
-            ::SetFocus((HWND) m_radioButtons[0]);
-        else
-            ::SetFocus((HWND) m_radioButtons[m_selectedButton]);
-    }
+    wxCHECK_MSG( IsValid(item), false,
+                 wxT("invalid item in wxRadioBox::IsItemShown()") );

 
 

+    // don't use IsWindowVisible() here because it would return false if the
+    // radiobox itself is hidden while we want to only return false if this
+    // button specifically is hidden
+    return (::GetWindowLong((*m_radioButtons)[item],
+                            GWL_STYLE) & WS_VISIBLE) != 0;

 }
 
 }
 

-bool wxRadioBox::Show(bool show)
+#if wxUSE_TOOLTIPS
+
+bool wxRadioBox::HasToolTips() const

 {
 {

-    m_isShown = show;
-    int cshow;
-    if (show)
-        cshow = SW_SHOW;
-    else
-        cshow = SW_HIDE;
-    if (m_hWnd)
-        ShowWindow((HWND) m_hWnd, cshow);
-    int i;
-    for (i = 0; i < m_noItems; i++)
-        ShowWindow((HWND) m_radioButtons[i], cshow);
-    return TRUE;
+    return wxStaticBox::HasToolTips() || wxRadioBoxBase::HasItemToolTips();

 }
 
 }
 

-// Enable a specific button
-void wxRadioBox::Enable(int item, bool enable)
+void wxRadioBox::DoSetItemToolTip(unsigned int item, wxToolTip *tooltip)

 {
 {

-    if (item<0)
-        wxWindow::Enable(enable);
-    else if (item < m_noItems)
-        ::EnableWindow((HWND) m_radioButtons[item], enable);
+    // we have already checked for the item to be valid in wxRadioBoxBase
+    const HWND hwndRbtn = (*m_radioButtons)[item];
+    if ( tooltip != NULL )
+        tooltip->AddOtherWindow(hwndRbtn);
+    else // unset the tooltip
+        wxToolTip::Remove(hwndRbtn, 0, wxRect(0,0,0,0));
+        // the second parameter can be zero since it's ignored by Remove()
+        // as we pass a rect for which wxRect::IsEmpty()==true...

 }
 
 }
 

-// Enable all controls
-void wxRadioBox::Enable(bool enable)
+#endif // wxUSE_TOOLTIPS
+
+bool wxRadioBox::Reparent(wxWindowBase *newParent)

 {
 {

-    wxControl::Enable(enable);
+    if ( !wxStaticBox::Reparent(newParent) )
+    {
+        return false;
+    }

 
 

-    int i;
-    for (i = 0; i < m_noItems; i++)
-        ::EnableWindow((HWND) m_radioButtons[i], enable);
+    HWND hwndParent = GetHwndOf(GetParent());
+    for ( size_t item = 0; item < m_radioButtons->GetCount(); item++ )
+    {
+        ::SetParent((*m_radioButtons)[item], hwndParent);
+    }
+#ifdef __WXWINCE__
+    // put static box under the buttons in the Z-order
+    SetWindowPos(GetHwnd(), HWND_BOTTOM, 0, 0, 0, 0, SWP_NOMOVE|SWP_NOSIZE);
+#endif
+    return true;

 }
 
 }
 

-// Show a specific button
-void wxRadioBox::Show(int item, bool show)
+WX_FORWARD_STD_METHODS_TO_SUBWINDOWS(wxRadioBox, wxStaticBox, m_radioButtons)
+
+// ----------------------------------------------------------------------------
+// size calculations
+// ----------------------------------------------------------------------------
+
+wxSize wxRadioBox::GetMaxButtonSize() const

 {
 {

-    if (item<0)
-        wxRadioBox::Show(show);
-    else if (item < m_noItems)
+    // calculate the max button size
+    int widthMax = 0,
+        heightMax = 0;
+    const unsigned int count = GetCount();
+    for ( unsigned int i = 0 ; i < count; i++ )

     {
     {

-        int cshow;
-        if (show)
-            cshow = SW_SHOW;
+        int width, height;
+        if ( m_radioWidth[i] < 0 )
+        {
+            GetTextExtent(wxGetWindowText((*m_radioButtons)[i]), &width, &height);
+
+            // adjust the size to take into account the radio box itself
+            // FIXME this is totally bogus!
+            width += RADIO_SIZE;
+            height *= 3;
+            height /= 2;
+        }

         else
         else

-            cshow = SW_HIDE;
-        ShowWindow((HWND) m_radioButtons[item], cshow);
+        {
+            width = m_radioWidth[i];
+            height = m_radioHeight[i];
+        }
+
+        if ( widthMax < width )
+            widthMax = width;
+        if ( heightMax < height )
+            heightMax = height;

     }
     }

+
+    return wxSize(widthMax, heightMax);

 }
 
 }
 

-WXHBRUSH wxRadioBox::OnCtlColor(WXHDC pDC, WXHWND pWnd, WXUINT nCtlColor,
-        WXUINT message, WXWPARAM wParam, WXLPARAM lParam)
+wxSize wxRadioBox::GetTotalButtonSize(const wxSize& sizeBtn) const

 {
 {

-#if wxUSE_CTL3D
-    if ( m_useCtl3D )
-    {
-        HBRUSH hbrush = Ctl3dCtlColorEx(message, wParam, lParam);
-        return (WXHBRUSH) hbrush;
-    }
-#endif
+    // the radiobox should be big enough for its buttons
+    int cx1, cy1;
+    wxGetCharSize(m_hWnd, &cx1, &cy1, GetFont());

 
 

-    if (GetParent()->GetTransparentBackground())
-        SetBkMode((HDC) pDC, TRANSPARENT);
-    else
-        SetBkMode((HDC) pDC, OPAQUE);
+    int extraHeight = cy1;
+
+    int height = GetRowCount() * sizeBtn.y + cy1/2 + extraHeight;
+    int width  = GetColumnCount() * (sizeBtn.x + cx1) + cx1;

 
 

-    ::SetBkColor((HDC) pDC, RGB(GetBackgroundColour().Red(), GetBackgroundColour().Green(), GetBackgroundColour().Blue()));
-    ::SetTextColor((HDC) pDC, RGB(GetForegroundColour().Red(), GetForegroundColour().Green(), GetForegroundColour().Blue()));
+    // Add extra space under the label, if it exists.
+    if (!wxControl::GetLabel().empty())
+        height += cy1/2;

 
 

-    wxBrush *backgroundBrush = wxTheBrushList->FindOrCreateBrush(GetBackgroundColour(), wxSOLID);
+    // and also wide enough for its label
+    int widthLabel;
+    GetTextExtent(GetLabelText(), &widthLabel, NULL);
+    widthLabel += RADIO_SIZE; // FIXME this is bogus too
+    if ( widthLabel > width )
+        width = widthLabel;

 
 

-    // Note that this will be cleaned up in wxApp::OnIdle, if backgroundBrush
-    // has a zero usage count.
-    //  backgroundBrush->RealizeResource();
-    return (WXHBRUSH) backgroundBrush->GetResourceHandle();
+    return wxSize(width, height);

 }
 
 }
 

-// For single selection items only
-wxString wxRadioBox::GetStringSelection() const
+wxSize wxRadioBox::DoGetBestSize() const

 {
 {

-    wxString result;
-    int sel = GetSelection();
-    if (sel > -1)
-        result = GetString(sel);
+    if ( !m_radioButtons )
+    {
+        // if we're not fully initialized yet, we can't meaningfully compute
+        // our best size, we'll do it later
+        return wxSize(1, 1);
+    }

 
 

-    return result;
+    wxSize best = GetTotalButtonSize(GetMaxButtonSize());
+    CacheBestSize(best);
+    return best;

 }
 
 }
 

-bool wxRadioBox::SetStringSelection(const wxString& s)
+void wxRadioBox::DoSetSize(int x, int y, int width, int height, int sizeFlags)

 {
 {

-    int sel = FindString (s);
-    if (sel > -1)
+    if ( (width == wxDefaultCoord && (sizeFlags & wxSIZE_AUTO_WIDTH)) ||
+            (height == wxDefaultCoord && (sizeFlags & wxSIZE_AUTO_HEIGHT)) )

     {
     {

-        SetSelection (sel);
-        return TRUE;
+        // Attempt to have a look coherent with other platforms: We compute the
+        // biggest toggle dim, then we align all items according this value.
+        const wxSize totSize = GetTotalButtonSize(GetMaxButtonSize());
+
+        // only change our width/height if asked for
+        if ( width == wxDefaultCoord && (sizeFlags & wxSIZE_AUTO_WIDTH) )
+            width = totSize.x;
+
+        if ( height == wxDefaultCoord && (sizeFlags & wxSIZE_AUTO_HEIGHT) )
+            height = totSize.y;

     }
     }

-    else
-        return FALSE;
+
+    wxStaticBox::DoSetSize(x, y, width, height);

 }
 
 }
 

-bool wxRadioBox::ContainsHWND(WXHWND hWnd) const
+void wxRadioBox::DoMoveWindow(int x, int y, int width, int height)

 {
 {

-    int i;
-    for (i = 0; i < Number(); i++)
-        if (GetRadioButtons()[i] == hWnd)
-            return TRUE;
-    return FALSE;
+    wxStaticBox::DoMoveWindow(x, y, width, height);
+
+    PositionAllButtons(x, y, width, height);

 }
 
 }
 

-void wxRadioBox::Command (wxCommandEvent & event)
+void
+wxRadioBox::PositionAllButtons(int x, int y, int width, int WXUNUSED(height))

 {
 {

-    SetSelection (event.m_commandInt);
-    ProcessCommand (event);
+    wxSize maxSize = GetMaxButtonSize();
+    int maxWidth = maxSize.x,
+        maxHeight = maxSize.y;
+
+    // Now position all the buttons: the current button will be put at
+    // wxPoint(x_offset, y_offset) and the new row/column will start at
+    // startX/startY. The size of all buttons will be the same wxSize(maxWidth,
+    // maxHeight) except for the buttons in the last column which should extend
+    // to the right border of radiobox and thus can be wider than this.
+
+    // Also, remember that wxRA_SPECIFY_COLS means that we arrange buttons in
+    // left to right order and GetMajorDim() is the number of columns while
+    // wxRA_SPECIFY_ROWS means that the buttons are arranged top to bottom and
+    // GetMajorDim() is the number of rows.
+
+    int cx1, cy1;
+    wxGetCharSize(m_hWnd, &cx1, &cy1, GetFont());
+
+    int x_offset = x + cx1;
+    int y_offset = y + cy1;
+
+    // Add extra space under the label, if it exists.
+    if (!wxControl::GetLabel().empty())
+        y_offset += cy1/2;
+
+    int startX = x_offset;
+    int startY = y_offset;
+
+    const unsigned int count = GetCount();
+    for (unsigned int i = 0; i < count; i++)
+    {
+        // the last button in the row may be wider than the other ones as the
+        // radiobox may be wider than the sum of the button widths (as it
+        // happens, for example, when the radiobox label is very long)
+        bool isLastInTheRow;
+        if ( m_windowStyle & wxRA_SPECIFY_COLS )
+        {
+            // item is the last in its row if it is a multiple of the number of
+            // columns or if it is just the last item
+            unsigned int n = i + 1;
+            isLastInTheRow = ((n % GetMajorDim()) == 0) || (n == count);
+        }
+        else // wxRA_SPECIFY_ROWS
+        {
+            // item is the last in the row if it is in the last columns
+            isLastInTheRow = i >= (count/GetMajorDim())*GetMajorDim();
+        }
+
+        // is this the start of new row/column?
+        if ( i && (i % GetMajorDim() == 0) )
+        {
+            if ( m_windowStyle & wxRA_SPECIFY_ROWS )
+            {
+                // start of new column
+                y_offset = startY;
+                x_offset += maxWidth + cx1;
+            }
+            else // start of new row
+            {
+                x_offset = startX;
+                y_offset += maxHeight;
+                if (m_radioWidth[0]>0)
+                    y_offset += cy1/2;
+            }
+        }
+
+        int widthBtn;
+        if ( isLastInTheRow )
+        {
+            // make the button go to the end of radio box
+            widthBtn = startX + width - x_offset - 2*cx1;
+            if ( widthBtn < maxWidth )
+                widthBtn = maxWidth;
+        }
+        else
+        {
+            // normal button, always of the same size
+            widthBtn = maxWidth;
+        }
+
+        // make all buttons of the same, maximal size - like this they cover
+        // the radiobox entirely and the radiobox tooltips are always shown
+        // (otherwise they are not when the mouse pointer is in the radiobox
+        // part not belonging to any radiobutton)
+        DoMoveSibling((*m_radioButtons)[i], x_offset, y_offset, widthBtn, maxHeight);
+
+        // where do we put the next button?
+        if ( m_windowStyle & wxRA_SPECIFY_ROWS )
+        {
+            // below this one
+            y_offset += maxHeight;
+            if (m_radioWidth[0]>0)
+                y_offset += cy1/2;
+        }
+        else
+        {
+            // to the right of this one
+            x_offset += widthBtn + cx1;
+        }
+    }

 }
 
 }
 

-long wxRadioBox::MSWWindowProc(WXUINT nMsg, WXWPARAM wParam, WXLPARAM lParam)
+int wxRadioBox::GetItemFromPoint(const wxPoint& pt) const

 {
 {

-    if (nMsg == WM_NCHITTEST)
+    const unsigned int count = GetCount();
+    for ( unsigned int i = 0; i < count; i++ )

     {
     {

-        int xPos = LOWORD(lParam);  // horizontal position of cursor
-        int yPos = HIWORD(lParam);  // vertical position of cursor
-
-        ScreenToClient(&xPos, &yPos);
+        RECT rect = wxGetWindowRect((*m_radioButtons)[i]);

 
 

-        // Make sure you can drag by the top of the groupbox, but let
-        // other (enclosed) controls get mouse events also
-        if (yPos < 10)
-            return (long)HTCLIENT;
+        if ( rect.left <= pt.x && pt.x < rect.right &&
+                rect.top  <= pt.y && pt.y < rect.bottom )
+        {
+            return i;
+        }

     }
 
     }
 

-    return wxControl::MSWWindowProc(nMsg, wParam, lParam);
+    return wxNOT_FOUND;

 }
 
 }
 

-void wxRadioBox::SubclassRadioButton(WXHWND hWndBtn)
+// ----------------------------------------------------------------------------
+// radio box drawing
+// ----------------------------------------------------------------------------
+
+#ifndef __WXWINCE__
+
+WXHRGN wxRadioBox::MSWGetRegionWithoutChildren()

 {
 {

-    HWND hwndBtn = (HWND)hWndBtn;
+    RECT rc;
+    ::GetWindowRect(GetHwnd(), &rc);
+    HRGN hrgn = ::CreateRectRgn(rc.left, rc.top, rc.right + 1, rc.bottom + 1);

 
 

-    if ( !s_wndprocRadioBtn )
-        s_wndprocRadioBtn = (WNDPROC)::GetWindowLong(hwndBtn, GWL_WNDPROC);
+    const unsigned int count = GetCount();
+    for ( unsigned int i = 0; i < count; ++i )
+    {
+        // don't clip out hidden children
+        if ( !IsItemShown(i) )
+            continue;

 
 

-    // No GWL_USERDATA in Win16, so omit this subclassing.
-#ifdef __WIN32__
-    ::SetWindowLong(hwndBtn, GWL_WNDPROC, (long)wxRadioBtnWndProc);
-    ::SetWindowLong(hwndBtn, GWL_USERDATA, (long)this);
-#endif
+        ::GetWindowRect((*m_radioButtons)[i], &rc);
+        AutoHRGN hrgnchild(::CreateRectRgnIndirect(&rc));
+        ::CombineRgn(hrgn, hrgn, hrgnchild, RGN_DIFF);
+    }
+
+    return (WXHRGN)hrgn;

 }
 
 }
 

+#endif // __WXWINCE__
+

 // ---------------------------------------------------------------------------
 // window proc for radio buttons
 // ---------------------------------------------------------------------------
 
 // ---------------------------------------------------------------------------
 // window proc for radio buttons
 // ---------------------------------------------------------------------------
 

-#ifdef __WIN32__
-

 LRESULT APIENTRY _EXPORT wxRadioBtnWndProc(HWND hwnd,
 LRESULT APIENTRY _EXPORT wxRadioBtnWndProc(HWND hwnd,

-                                           UINT msg,
+                                           UINT message,

                                            WPARAM wParam,
                                            LPARAM lParam)
 {
                                            WPARAM wParam,
                                            LPARAM lParam)
 {

-    bool processed = TRUE;
-    if ( msg != WM_KEYDOWN )
-        processed = FALSE;        

 
 

-    if ( processed )
+    wxRadioBox * const radiobox = wxRadioBox::GetFromRadioButtonHWND(hwnd);
+    wxCHECK_MSG( radiobox, 0, wxT("Should have the associated radio box") );
+
+    switch ( message )

     {
     {

-        wxRadioBox *radiobox = (wxRadioBox *)::GetWindowLong(hwnd, GWL_USERDATA);
+        case WM_GETDLGCODE:
+            // we must tell IsDialogMessage()/our kbd processing code that we
+            // want to process arrows ourselves because neither of them is
+            // smart enough to handle arrows properly for us
+            {
+                long lDlgCode = ::CallWindowProc(CASTWNDPROC s_wndprocRadioBtn, hwnd,
+                                                 message, wParam, lParam);

 
 

-        wxCHECK_MSG( radiobox, 0, "radio button without radio box?" );
+                return lDlgCode | DLGC_WANTARROWS;
+            }

 
 

-        int sel = radiobox->GetSelection();
+        case WM_KEYDOWN:
+            {
+                bool processed = true;

 
 

-        switch ( wParam )
-        {
-            case VK_UP:
-                sel--;
-                break;
+                wxDirection dir;
+                switch ( wParam )
+                {
+                    case VK_UP:
+                        dir = wxUP;
+                        break;

 
 

-            case VK_LEFT:
-                sel -= radiobox->GetNumVer();
-                break;
+                    case VK_LEFT:
+                        dir = wxLEFT;
+                        break;

 
 

-            case VK_DOWN:
-                sel++;
-                break;
+                    case VK_DOWN:
+                        dir = wxDOWN;
+                        break;

 
 

-            case VK_RIGHT:
-                sel += radiobox->GetNumVer();
-                break;
+                    case VK_RIGHT:
+                        dir = wxRIGHT;
+                        break;

 
 

-            case VK_TAB:
+                    default:
+                        processed = false;
+
+                        // just to suppress the compiler warning
+                        dir = wxALL;
+                }
+
+                if ( processed )

                 {
                 {

-                    wxNavigationKeyEvent event;
-                    event.SetDirection(!(::GetKeyState(VK_SHIFT) & 0x100));
-                    event.SetWindowChange(FALSE);
-                    event.SetEventObject(radiobox);
+                    int selOld = radiobox->GetSelection();
+                    int selNew = radiobox->GetNextItem
+                                 (
+                                  selOld,
+                                  dir,
+                                  radiobox->GetWindowStyle()
+                                 );
+
+                    if ( selNew != selOld )
+                    {
+                        radiobox->SetSelection(selNew);
+                        radiobox->SetFocus();
+
+                        // emulate the button click
+                        radiobox->SendNotificationEvent();

 
 

-                    if ( radiobox->GetEventHandler()->ProcessEvent(event) )

                         return 0;
                         return 0;

+                    }

                 }
                 }

-                // fall through
+            }
+            break;

 
 

-            default:
-                processed = FALSE;        
-        }
+        case WM_SETFOCUS:
+        case WM_KILLFOCUS:
+            {
+                // if we don't do this, no focus events are generated for the
+                // radiobox and, besides, we need to notify the parent about
+                // the focus change, otherwise the focus handling logic in
+                // wxControlContainer doesn't work
+                if ( message == WM_SETFOCUS )
+                    radiobox->HandleSetFocus((WXHWND)wParam);
+                else
+                    radiobox->HandleKillFocus((WXHWND)wParam);
+            }
+            break;

 
 

-        if ( processed )
-        {
-            if ( sel >= 0 && sel < radiobox->Number() )
-                radiobox->SetSelection(sel);
-        }
+#ifndef __WXWINCE__
+        case WM_HELP:
+            {
+                bool processed = false;
+
+                wxEvtHandler * const handler = radiobox->GetEventHandler();
+
+                HELPINFO* info = (HELPINFO*) lParam;
+                if ( info->iContextType == HELPINFO_WINDOW )
+                {
+                    for ( wxWindow* subjectOfHelp = radiobox;
+                          subjectOfHelp;
+                          subjectOfHelp = subjectOfHelp->GetParent() )
+                    {
+                        wxHelpEvent helpEvent(wxEVT_HELP,
+                                              subjectOfHelp->GetId(),
+                                              wxPoint(info->MousePos.x,
+                                                      info->MousePos.y));
+                        helpEvent.SetEventObject(radiobox);
+                        if ( handler->ProcessEvent(helpEvent) )
+                        {
+                            processed = true;
+                            break;
+                        }
+                    }
+                }
+                else if (info->iContextType == HELPINFO_MENUITEM)
+                {
+                    wxHelpEvent helpEvent(wxEVT_HELP, info->iCtrlId);
+                    helpEvent.SetEventObject(radiobox);
+                    processed = handler->ProcessEvent(helpEvent);
+                }
+
+                if ( processed )
+                    return 0;
+            }
+            break;
+#endif // !__WXWINCE__

     }
 
     }
 

-    if ( !processed )
-        return ::CallWindowProc((WNDPROC) s_wndprocRadioBtn, hwnd, msg, wParam, lParam);
-    else
-        return 0;
+    return ::CallWindowProc(CASTWNDPROC s_wndprocRadioBtn, hwnd, message, wParam, lParam);

 }
 }

-#endif

 
 

+#endif // wxUSE_RADIOBOX