Bail out if GetCurrentMenu returns NULL

[wxWidgets.git] / src / cocoa / menuitem.mm

diff --git a/src/cocoa/menuitem.mm b/src/cocoa/menuitem.mm
index 5d85321a8721c9445f16724ba1e54494f7143669..595ce117302f215f7aa8f0ff5a601178f773be85 100644 (file)
--- a/src/cocoa/menuitem.mm
+++ b/src/cocoa/menuitem.mm
@@ -4,8 +4,8 @@
 // Author:      David Elliott
 // Modified by:
 // Created:     2002/12/15
 // Author:      David Elliott
 // Modified by:
 // Created:     2002/12/15

-// RCS-ID:      $Id: 
-// Copyright:   2002 David Elliott
+// RCS-ID:      $Id$
+// Copyright:   2002-2004 David Elliott

 // Licence:     wxWindows licence
 ///////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 ///////////////////////////////////////////////////////////////////////////////
 


@@ -33,6 +33,7 @@
 #import <AppKit/NSMenuItem.h>
 #import <AppKit/NSMenu.h>
 #import <Foundation/NSString.h>
 #import <AppKit/NSMenuItem.h>
 #import <AppKit/NSMenu.h>
 #import <Foundation/NSString.h>

+#import <AppKit/NSCell.h> // NSOnState, NSOffState

 
 #if wxUSE_MENUS
 
 
 #if wxUSE_MENUS
 


@@ -72,7 +73,7 @@
 
 - (BOOL)validateMenuItem: (id)menuItem
 {
 
 - (BOOL)validateMenuItem: (id)menuItem
 {

-    // TODO: Do wxWindows validation here and avoid sending during idle time
+    // TODO: Do wxWidgets validation here and avoid sending during idle time

     wxLogTrace(wxTRACE_COCOA,wxT("wxMenuItemAction"));
     wxMenuItem *item = wxMenuItem::GetFromCocoa(menuItem);
     wxCHECK_MSG(item,NO,wxT("validateMenuItem received but no wxMenuItem exists!"));
     wxLogTrace(wxTRACE_COCOA,wxT("wxMenuItemAction"));
     wxMenuItem *item = wxMenuItem::GetFromCocoa(menuItem);
     wxCHECK_MSG(item,NO,wxT("validateMenuItem received but no wxMenuItem exists!"));


@@ -81,20 +82,6 @@
 
 @end //implementation wxNSMenuItemTarget
 
 
 @end //implementation wxNSMenuItemTarget
 

-// ============================================================================
-// @class wxPoserNSMenuItem
-// ============================================================================
-@interface wxPoserNSMenuItem : NSMenuItem
-{
-}
-
-@end // wxPoserNSMenuItem
-
-WX_IMPLEMENT_POSER(wxPoserNSMenuItem);
-@implementation wxPoserNSMenuItem : NSMenuItem
-
-@end // wxPoseRNSMenuItem
-

 // ============================================================================
 // wxMenuItemCocoa implementation
 // ============================================================================
 // ============================================================================
 // wxMenuItemCocoa implementation
 // ============================================================================


@@ -191,10 +178,43 @@ void wxMenuItem::Enable(bool bDoEnable)
     // NOTE: Nothing to do, we respond to validateMenuItem instead
 }
 
     // NOTE: Nothing to do, we respond to validateMenuItem instead
 }
 

-void wxMenuItem::Check(bool bDoCheck)
+void wxMenuItem::Check(bool check)

 {
     wxCHECK_RET( IsCheckable(), wxT("only checkable items may be checked") );
 {
     wxCHECK_RET( IsCheckable(), wxT("only checkable items may be checked") );

-    wxMenuItemBase::Check(bDoCheck);
+    if(m_isChecked == check)
+        return;
+    wxAutoNSAutoreleasePool pool;
+    if(GetKind() == wxITEM_RADIO)
+    {
+        // it doesn't make sense to uncheck a radio item - what would this do?
+        if(!check)
+            return;
+        const wxMenuItemList& items = m_parentMenu->GetMenuItems();
+        // First search backwards for other radio items
+        wxMenuItemList::compatibility_iterator radioStart = items.Find(this);
+        for(wxMenuItemList::compatibility_iterator prevNode = radioStart;
+            prevNode && (prevNode->GetData()->GetKind() == wxITEM_RADIO);
+            prevNode = prevNode->GetPrevious())
+        {
+            radioStart = prevNode;
+        }
+        // Now starting there set the state of every item until we're
+        // out of radio items to set.
+        for(wxMenuItemList::compatibility_iterator node = radioStart;
+            node && (node->GetData()->GetKind() == wxITEM_RADIO);
+            node = node->GetNext())
+        {
+            wxMenuItem *item = node->GetData();
+            bool checkItem = (item == this);
+            item->wxMenuItemBase::Check(checkItem);
+            [item->m_cocoaNSMenuItem setState: checkItem?NSOnState:NSOffState];
+        }
+    }
+    else // normal check (non-radio) item
+    {
+        wxMenuItemBase::Check(check);
+        [m_cocoaNSMenuItem setState: check?NSOnState:NSOffState];
+    }

 }
 
 void wxMenuItem::SetText(const wxString& label)
 }
 
 void wxMenuItem::SetText(const wxString& label)


@@ -206,7 +226,9 @@ void wxMenuItem::SetText(const wxString& label)
 
 void wxMenuItem::SetCheckable(bool checkable)
 {
 
 void wxMenuItem::SetCheckable(bool checkable)
 {

+    wxCHECK_RET(m_kind != wxITEM_SEPARATOR, wxT("Separator items cannot be turned into normal menu items."));

     wxMenuItemBase::SetCheckable(checkable);
     wxMenuItemBase::SetCheckable(checkable);

+    // NOTE: Cocoa does not discern between unchecked and normal items

 }
 
 #endif // wxUSE_MENUS
 }
 
 #endif // wxUSE_MENUS