don't use wxString::FromASCII() with possibly non-ASCII strings (fixes asserts when...

[wxWidgets.git] / src / gtk / combobox.cpp

diff --git a/src/gtk/combobox.cpp b/src/gtk/combobox.cpp
index 11799f3b608934e0037f21a472eb6c8f5014d769..b94d1f983b341429a83def8e8e4f1bc54ca5e408 100644 (file)
--- a/src/gtk/combobox.cpp
+++ b/src/gtk/combobox.cpp
@@ -1,413 +1,308 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        combobox.cpp
+// Name:        src/gtk/combobox.cpp

 // Purpose:
 // Author:      Robert Roebling
 // Purpose:
 // Author:      Robert Roebling

-// Created:     01/02/97
-// Id:
-// Copyright:   (c) 1998 Robert Roebling, Julian Smart and Markus Holzem
-// Licence:    wxWindows licence
+// Id:          $Id$
+// Copyright:   (c) 1998 Robert Roebling
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
-#pragma implementation "combobox.h"
-#endif
+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"
+
+#if wxUSE_COMBOBOX

 
 #include "wx/combobox.h"
 
 #include "wx/combobox.h"

-#include <wx/intl.h>

 
 

-//-----------------------------------------------------------------------------
-// data
-//-----------------------------------------------------------------------------
+#ifndef WX_PRECOMP
+    #include "wx/intl.h"
+    #include "wx/settings.h"
+    #include "wx/textctrl.h"    // for wxEVT_COMMAND_TEXT_UPDATED
+    #include "wx/arrstr.h"
+#endif

 
 

-extern bool   g_blockEventsOnDrag;
+#include "wx/gtk/private.h"

 
 

-//-----------------------------------------------------------------------------
-// "select"
-//-----------------------------------------------------------------------------
+// ----------------------------------------------------------------------------
+// GTK callbacks
+// ----------------------------------------------------------------------------

 
 

-static void gtk_combo_clicked_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )
+extern "C" {
+static void
+gtkcombobox_text_changed_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )

 {
 {

-  if (!combo->HasVMT()) return;
-  if (g_blockEventsOnDrag) return;
-  
-  if (combo->m_alreadySent)
-  {
-    combo->m_alreadySent = FALSE;
-    return;
-  }
-
-  combo->m_alreadySent = TRUE;
-  
-  wxCommandEvent event(wxEVT_COMMAND_CHOICE_SELECTED, combo->GetId());
-  event.SetInt( combo->GetSelection() );
-  wxString tmp( combo->GetStringSelection() );
-  event.SetString( WXSTRINGCAST(tmp) );
-  event.SetEventObject(combo);
-  combo->GetEventHandler()->ProcessEvent(event);
+    if (!combo->m_hasVMT) return;
+
+    wxCommandEvent event( wxEVT_COMMAND_TEXT_UPDATED, combo->GetId() );
+    event.SetString( combo->GetValue() );
+    event.SetEventObject( combo );
+    combo->HandleWindowEvent( event );

 }
 
 }
 

-//-----------------------------------------------------------------------------
-// size 
-
-/*
-static gint gtk_combo_size_callback( GtkCombo *widget, GtkAllocation* alloc, wxComboBox *win )
-{ 
-  if (!win->HasVMT()) return FALSE;
-  if (g_blockEventsOnDrag) return FALSE;
-  if (!widget->button) return FALSE;
-  
-  widget->button->allocation.x = 
-    alloc->width - widget->button->allocation.width;
-  
-  return FALSE;
+static void
+gtkcombobox_changed_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )
+{
+    combo->SendSelectionChangedEvent(wxEVT_COMMAND_COMBOBOX_SELECTED);
+}

 }
 }

-*/

 
 //-----------------------------------------------------------------------------
 // wxComboBox
 //-----------------------------------------------------------------------------
 
 
 //-----------------------------------------------------------------------------
 // wxComboBox
 //-----------------------------------------------------------------------------
 

-IMPLEMENT_DYNAMIC_CLASS(wxComboBox,wxControl)
-
-bool wxComboBox::Create(wxWindow *parent, wxWindowID id, const wxString& value,
-  const wxPoint& pos, const wxSize& size,
-  int n, const wxString choices[],
-  long style, const wxValidator& validator, const wxString& name )
+IMPLEMENT_DYNAMIC_CLASS(wxComboBox, wxChoice)
+
+BEGIN_EVENT_TABLE(wxComboBox, wxChoice)
+    EVT_CHAR(wxComboBox::OnChar)
+
+    EVT_MENU(wxID_CUT, wxComboBox::OnCut)
+    EVT_MENU(wxID_COPY, wxComboBox::OnCopy)
+    EVT_MENU(wxID_PASTE, wxComboBox::OnPaste)
+    EVT_MENU(wxID_UNDO, wxComboBox::OnUndo)
+    EVT_MENU(wxID_REDO, wxComboBox::OnRedo)
+    EVT_MENU(wxID_CLEAR, wxComboBox::OnDelete)
+    EVT_MENU(wxID_SELECTALL, wxComboBox::OnSelectAll)
+
+    EVT_UPDATE_UI(wxID_CUT, wxComboBox::OnUpdateCut)
+    EVT_UPDATE_UI(wxID_COPY, wxComboBox::OnUpdateCopy)
+    EVT_UPDATE_UI(wxID_PASTE, wxComboBox::OnUpdatePaste)
+    EVT_UPDATE_UI(wxID_UNDO, wxComboBox::OnUpdateUndo)
+    EVT_UPDATE_UI(wxID_REDO, wxComboBox::OnUpdateRedo)
+    EVT_UPDATE_UI(wxID_CLEAR, wxComboBox::OnUpdateDelete)
+    EVT_UPDATE_UI(wxID_SELECTALL, wxComboBox::OnUpdateSelectAll)
+END_EVENT_TABLE()
+
+void wxComboBox::Init()

 {
 {

-  m_alreadySent = FALSE;
-  m_needParent = TRUE;
-  
-  PreCreation( parent, id, pos, size, style, name );
-  
-  SetValidator( validator );
-
-  m_widget = gtk_combo_new();
-  
-  wxSize newSize = size;
-  if (newSize.x == -1) newSize.x = 100;
-  if (newSize.y == -1) newSize.y = 26;
-  SetSize( newSize.x, newSize.y );
-  
-  GtkWidget *list = GTK_COMBO(m_widget)->list;
-  
-  for (int i = 0; i < n; i++)
-  {
-    GtkWidget *list_item;
-    list_item = gtk_list_item_new_with_label( choices[i] ); 
-  
-    gtk_container_add( GTK_CONTAINER(list), list_item );
-    
-    m_clientData.Append( (wxObject*)NULL );
-    
-    gtk_widget_show( list_item );
-    
-    gtk_signal_connect( GTK_OBJECT(list_item), "select", 
-      GTK_SIGNAL_FUNC(gtk_combo_clicked_callback), (gpointer)this );
-  }
-  
-  PostCreation();
-
-/*
-  gtk_signal_connect( GTK_OBJECT(m_widget), "size_allocate", 
-    GTK_SIGNAL_FUNC(gtk_combo_size_callback), (gpointer)this );
-*/
-
-  if (!value.IsNull()) SetValue( value );
-    
-  Show( TRUE );
-    
-  return TRUE;
+    m_entry = NULL;

 }
 
 }
 

-void wxComboBox::Clear(void)
+bool wxComboBox::Create( wxWindow *parent, wxWindowID id,
+                         const wxString& value,
+                         const wxPoint& pos, const wxSize& size,
+                         const wxArrayString& choices,
+                         long style, const wxValidator& validator,
+                         const wxString& name )

 {
 {

-  GtkWidget *list = GTK_COMBO(m_widget)->list;
-  gtk_list_clear_items( GTK_LIST(list), 0, Number() );
-  
-  m_clientData.Clear();
-}
+    wxCArrayString chs(choices);

 
 

-void wxComboBox::Append( const wxString &item )
-{
-  Append( item, (char*)NULL );
+    return Create( parent, id, value, pos, size, chs.GetCount(),
+                   chs.GetStrings(), style, validator, name );

 }
 
 }
 

-void wxComboBox::Append( const wxString &item, char *clientData )
+bool wxComboBox::Create( wxWindow *parent, wxWindowID id, const wxString& value,
+                         const wxPoint& pos, const wxSize& size,
+                         int n, const wxString choices[],
+                         long style, const wxValidator& validator,
+                         const wxString& name )

 {
 {

-  GtkWidget *list = GTK_COMBO(m_widget)->list;
-  
-  GtkWidget *list_item = gtk_list_item_new_with_label( item ); 
-  
-  if (m_hasOwnStyle)
-  {
-    GtkBin *bin = GTK_BIN( list_item );
-    gtk_widget_set_style( bin->child, 
-      gtk_style_ref(
-        gtk_widget_get_style( m_widget ) ) ); 
-  }
-  
-  gtk_signal_connect( GTK_OBJECT(list_item), "select", 
-    GTK_SIGNAL_FUNC(gtk_combo_clicked_callback), (gpointer)this );
-  
-  m_clientData.Append( (wxObject*)clientData );
-  
-  gtk_container_add( GTK_CONTAINER(list), list_item );
-    
-  gtk_widget_show( list_item );
-}
+    if (!PreCreation( parent, pos, size ) ||
+        !CreateBase( parent, id, pos, size, style, validator, name ))
+    {
+        wxFAIL_MSG( wxT("wxComboBox creation failed") );
+        return false;
+    }

 
 

-void wxComboBox::Delete( int n )
-{
-  GtkList *listbox = GTK_LIST( GTK_COMBO(m_widget)->list );
-  
-  GList *child = g_list_nth( listbox->children, n );
-  
-  if (!child)
-  {
-    wxFAIL_MSG("wrong index");
-    return;
-  }
-  
-  GList *list = g_list_append( NULL, child->data );
-  gtk_list_remove_items( listbox, list );
-  g_list_free( list );
-  
-  wxNode *node = m_clientData.Nth( n );
-  if (!node)
-  {
-    wxFAIL_MSG( "wrong index" );
-  }
-  else
-    m_clientData.DeleteNode( node );
-}
+    if (HasFlag(wxCB_SORT))
+        m_strings = new wxSortedArrayString();

 
 

-int wxComboBox::FindString( const wxString &item )
-{
-  GtkWidget *list = GTK_COMBO(m_widget)->list;
-  
-  GList *child = GTK_LIST(list)->children;
-  int count = 0;
-  while (child)
-  {
-    GtkBin *bin = GTK_BIN( child->data );
-    GtkLabel *label = GTK_LABEL( bin->child );
-    if (item == label->label) return count;
-    count++;
-    child = child->next;
-  }
-  
-  wxFAIL_MSG( "wxComboBox: string not found" );
-  
-  return -1;
+    GTKCreateComboBoxWidget();
+
+    if (HasFlag(wxBORDER_NONE))
+    {
+        // Doesn't seem to work
+        // g_object_set (m_widget, "has-frame", FALSE, NULL);
+    }
+
+    GtkEntry * const entry = GetEntry();
+
+    if ( entry )
+    {
+        // Set it up to trigger default item on enter key press
+        gtk_entry_set_activates_default( entry,
+                                         !HasFlag(wxTE_PROCESS_ENTER) );
+
+        gtk_entry_set_editable( entry, TRUE );
+    }
+
+    Append(n, choices);
+
+    m_parent->DoAddChild( this );
+
+    if ( entry )
+        m_focusWidget = GTK_WIDGET( entry );
+
+    PostCreation(size);
+
+    if ( entry )
+    {
+        gtk_entry_set_text( entry, wxGTK_CONV(value) );
+
+        if (style & wxCB_READONLY)
+            gtk_entry_set_editable( entry, FALSE );
+
+        g_signal_connect_after (entry, "changed",
+                                G_CALLBACK (gtkcombobox_text_changed_callback), this);
+    }
+
+    g_signal_connect_after (m_widget, "changed",
+                        G_CALLBACK (gtkcombobox_changed_callback), this);
+
+    SetInitialSize(size); // need this too because this is a wxControlWithItems
+
+    return true;

 }
 
 }
 

-char* wxComboBox::GetClientData( int n )
+void wxComboBox::GTKCreateComboBoxWidget()

 {
 {

-  wxNode *node = m_clientData.Nth( n );
-  if (node) return (char*)node->Data();
-  
-  wxFAIL_MSG( "wxComboBox: wrong index" );
-  
-  return (char *) NULL;
+    m_widget = gtk_combo_box_entry_new_text();
+    g_object_ref(m_widget);
+
+    m_entry = GTK_ENTRY(GTK_BIN(m_widget)->child);

 }
 
 }
 

-void wxComboBox::SetClientData( int n, char * clientData )
+GtkEditable *wxComboBox::GetEditable() const

 {
 {

-  wxNode *node = m_clientData.Nth( n );
-  if (node) node->SetData( (wxObject*) clientData );
-  
-  wxFAIL_MSG( "wxComboBox: wrong index" );
+    return GTK_EDITABLE( GTK_BIN(m_widget)->child );

 }
 
 }
 

-int wxComboBox::GetSelection(void) const
+void wxComboBox::OnChar( wxKeyEvent &event )

 {
 {

-  GtkWidget *list = GTK_COMBO(m_widget)->list;
-  
-  GList *selection = GTK_LIST(list)->selection;
-  if (selection)
-  {
-    GList *child = GTK_LIST(list)->children;
-    int count = 0;
-    while (child)
+    switch ( event.GetKeyCode() )

     {
     {

-      if (child->data == selection->data) return count;
-      count++;
-      child = child->next;
+        case WXK_RETURN:
+            if ( HasFlag(wxTE_PROCESS_ENTER) && GetEntry() )
+            {
+                // GTK automatically selects an item if its in the list
+                wxCommandEvent eventEnter(wxEVT_COMMAND_TEXT_ENTER, GetId());
+                eventEnter.SetString( GetValue() );
+                eventEnter.SetInt( GetSelection() );
+                eventEnter.SetEventObject( this );
+
+                if ( HandleWindowEvent(eventEnter) )
+                {
+                    // Catch GTK event so that GTK doesn't open the drop
+                    // down list upon RETURN.
+                    return;
+                }
+            }
+            break;

     }
     }

-  }
-  
-  wxFAIL_MSG( "wxComboBox: no selection" );
-  
-  return -1;
-}

 
 

-wxString wxComboBox::GetString( int n ) const
-{
-  GtkWidget *list = GTK_COMBO(m_widget)->list;
-  
-  GList *child = g_list_nth( GTK_LIST(list)->children, n );
-  if (child)
-  {
-    GtkBin *bin = GTK_BIN( child->data );
-    GtkLabel *label = GTK_LABEL( bin->child );
-    return label->label;
-  }
-  
-  wxFAIL_MSG( "wxComboBox: wrong index" );
-  
-  return "";
+    event.Skip();

 }
 
 }
 

-wxString wxComboBox::GetStringSelection(void) const
+void wxComboBox::DisableEvents()

 {
 {

-  GtkWidget *list = GTK_COMBO(m_widget)->list;
-  
-  GList *selection = GTK_LIST(list)->selection;
-  if (selection)
-  {
-    GtkBin *bin = GTK_BIN( selection->data );
-    wxString tmp = GTK_LABEL( bin->child )->label;
-    return tmp;
-  }
-  
-  wxFAIL_MSG( "wxComboBox: no selection" );
-  
-  return "";
+    if ( GetEntry() )
+        g_signal_handlers_block_by_func(GTK_BIN(m_widget)->child,
+            (gpointer)gtkcombobox_text_changed_callback, this);
+
+    g_signal_handlers_block_by_func(m_widget,
+        (gpointer)gtkcombobox_changed_callback, this);

 }
 
 }
 

-int wxComboBox::Number(void) const
+void wxComboBox::EnableEvents()

 {
 {

-  GtkWidget *list = GTK_COMBO(m_widget)->list;
-  
-  GList *child = GTK_LIST(list)->children;
-  int count = 0;
-  while (child) { count++; child = child->next; }
-  return count;
+    if ( GetEntry() )
+        g_signal_handlers_unblock_by_func(GTK_BIN(m_widget)->child,
+            (gpointer)gtkcombobox_text_changed_callback, this);
+
+    g_signal_handlers_unblock_by_func(m_widget,
+        (gpointer)gtkcombobox_changed_callback, this);

 }
 
 }
 

-void wxComboBox::SetSelection( int n )
+GtkWidget* wxComboBox::GetConnectWidget()

 {
 {

-  GtkWidget *list = GTK_COMBO(m_widget)->list;
-  gtk_list_select_item( GTK_LIST(list), n );
+    return GTK_WIDGET( GetEntry() );

 }
 
 }
 

-void wxComboBox::SetStringSelection( const wxString &string )
+GdkWindow *wxComboBox::GTKGetWindow(wxArrayGdkWindows& windows) const

 {
 {

-  int res = FindString( string );
-  if (res == -1) return;
-  SetSelection( res );
+    wxUnusedVar(windows);
+
+    return GetEntry()->text_area;

 }
 
 }
 

-wxString wxComboBox::GetValue(void) const
+// static
+wxVisualAttributes
+wxComboBox::GetClassDefaultAttributes(wxWindowVariant WXUNUSED(variant))

 {
 {

-  GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-  wxString tmp = gtk_entry_get_text( GTK_ENTRY(entry) );
-  return tmp;
+    return GetDefaultAttributesFromGTKWidget(gtk_combo_box_entry_new, true);

 }
 
 }
 

-void wxComboBox::SetValue( const wxString& value )
+// ----------------------------------------------------------------------------
+// standard event handling
+// ----------------------------------------------------------------------------
+
+void wxComboBox::OnCut(wxCommandEvent& WXUNUSED(event))

 {
 {

-  GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-  wxString tmp = "";
-  if (!value.IsNull()) tmp = value;
-  gtk_entry_set_text( GTK_ENTRY(entry), tmp );
+    Cut();

 }
 
 }
 

-void wxComboBox::Copy(void)
+void wxComboBox::OnCopy(wxCommandEvent& WXUNUSED(event))

 {
 {

-  GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-  gtk_editable_copy_clipboard( GTK_EDITABLE(entry), 0 );
+    Copy();

 }
 
 }
 

-void wxComboBox::Cut(void)
+void wxComboBox::OnPaste(wxCommandEvent& WXUNUSED(event))

 {
 {

-  GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-  gtk_editable_cut_clipboard( GTK_EDITABLE(entry), 0 );
+    Paste();

 }
 
 }
 

-void wxComboBox::Paste(void)
+void wxComboBox::OnUndo(wxCommandEvent& WXUNUSED(event))

 {
 {

-  GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-  gtk_editable_paste_clipboard( GTK_EDITABLE(entry), 0 );
+    Undo();

 }
 
 }
 

-void wxComboBox::SetInsertionPoint( long pos )
+void wxComboBox::OnRedo(wxCommandEvent& WXUNUSED(event))

 {
 {

-  GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-  int tmp = (int) pos;
-  gtk_entry_set_position( GTK_ENTRY(entry), tmp );
+    Redo();

 }
 
 }
 

-void wxComboBox::SetInsertionPointEnd(void)
+void wxComboBox::OnDelete(wxCommandEvent& WXUNUSED(event))

 {
 {

-  GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-  int pos = GTK_ENTRY(entry)->text_length;
-  SetInsertionPoint( pos-1 );
+    RemoveSelection();

 }
 
 }
 

-long wxComboBox::GetInsertionPoint(void) const
+void wxComboBox::OnSelectAll(wxCommandEvent& WXUNUSED(event))

 {
 {

-  GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-  return (long) GTK_EDITABLE(entry)->current_pos;
+    SelectAll();

 }
 
 }
 

-long wxComboBox::GetLastPosition(void) const
+void wxComboBox::OnUpdateCut(wxUpdateUIEvent& event)

 {
 {

-  GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-  int pos = GTK_ENTRY(entry)->text_length;
-  return (long) pos-1;
+    event.Enable( CanCut() );

 }
 
 }
 

-void wxComboBox::Replace( long from, long to, const wxString& value )
+void wxComboBox::OnUpdateCopy(wxUpdateUIEvent& event)

 {
 {

-  GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-  gtk_editable_delete_text( GTK_EDITABLE(entry), (gint)from, (gint)to );
-  if (value.IsNull()) return;
-  gint pos = (gint)to;
-  gtk_editable_insert_text( GTK_EDITABLE(entry), value, value.Length(), &pos );
+    event.Enable( CanCopy() );

 }
 
 }
 

-void wxComboBox::Remove(long from, long to)
+void wxComboBox::OnUpdatePaste(wxUpdateUIEvent& event)

 {
 {

-  GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-  gtk_editable_delete_text( GTK_EDITABLE(entry), (gint)from, (gint)to );
+    event.Enable( CanPaste() );

 }
 
 }
 

-void wxComboBox::SetSelection( long WXUNUSED(from), long WXUNUSED(to) )
+void wxComboBox::OnUpdateUndo(wxUpdateUIEvent& event)

 {
 {

+    event.Enable( CanUndo() );

 }
 
 }
 

-void wxComboBox::SetEditable( bool WXUNUSED(editable) )
+void wxComboBox::OnUpdateRedo(wxUpdateUIEvent& event)

 {
 {

+    event.Enable( CanRedo() );

 }
 
 }
 

-void wxComboBox::SetFont( const wxFont &font )
+void wxComboBox::OnUpdateDelete(wxUpdateUIEvent& event)

 {
 {

-  wxWindow::SetFont( font );
-   
-  GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-  
-  gtk_widget_set_style( entry,
-    gtk_style_ref(
-      gtk_widget_get_style( m_widget ) ) ); 
-  
-  GtkWidget *list = GTK_COMBO(m_widget)->list;
-  
-  GList *child = GTK_LIST(list)->children;
-  while (child)
-  {
-    GtkBin *bin = (GtkBin*) child->data;
-    gtk_widget_set_style( bin->child, 
-      gtk_style_ref(
-        gtk_widget_get_style( m_widget ) ) ); 
-        
-    child = child->next;
-  }
+    event.Enable(HasSelection() && IsEditable()) ;

 }
 }

-      
-GtkWidget* wxComboBox::GetConnectWidget(void)
+
+void wxComboBox::OnUpdateSelectAll(wxUpdateUIEvent& event)

 {
 {

-  return GTK_COMBO(m_widget)->entry;
+    event.Enable(!wxTextEntry::IsEmpty());

 }
 
 }
 

-
+#endif // wxUSE_COMBOBOX