Corrected meaning of parameter col as the position not ID in wxLisrCtrl::InsertColumn...

[wxWidgets.git] / src / motif / combobox.cpp

diff --git a/src/motif/combobox.cpp b/src/motif/combobox.cpp
index 099cc58604a8f0db4071ba8041705c2eef785835..83dac29f7f70897d259716e8c147c7781dbd0711 100644 (file)
--- a/src/motif/combobox.cpp
+++ b/src/motif/combobox.cpp
@@ -53,8 +53,6 @@ bool wxComboBox::Create(wxWindow *parent, wxWindowID id,
         return false;
     PreCreation();
 
-    m_noStrings = n;
-
     Widget parentWidget = (Widget) parent->GetClientWidget();
 
     Widget buttonWidget = XtVaCreateManagedWidget(name.c_str(),
@@ -72,7 +70,7 @@ bool wxComboBox::Create(wxWindow *parent, wxWindowID id,
     {
         wxXmString str( choices[i] );
         XmComboBoxAddItem(buttonWidget, str(), 0);
-        m_stringList.Add(choices[i]);
+        m_stringArray.Add(choices[i]);
     }
 
     m_mainWidget = (Widget) buttonWidget;
@@ -121,6 +119,8 @@ void wxComboBox::DoSetSize(int x, int y,
     wxWindow::DoSetSize(x, y, width, DoGetBestSize().y, sizeFlags);
 }
 
+#if 0
+// Already defined in include/motif/combobox.h
 wxString wxComboBox::GetValue() const
 {
     char *s = XmComboBoxGetString ((Widget) m_mainWidget);
@@ -133,6 +133,7 @@ wxString wxComboBox::GetValue() const
     else
         return wxEmptyString;
 }
+#endif
 
 void wxComboBox::SetValue(const wxString& value)
 {
@@ -162,9 +163,7 @@ int wxComboBox::DoInsertItems(const wxArrayStringsAdapter& items,
     {
         wxXmString str( items[i].c_str() );
         XmComboBoxAddItem((Widget) m_mainWidget, str(), GetMotifPosition(pos));
-        wxChar* copy = wxStrcpy(new wxChar[items[i].length() + 1], items[i].c_str());
-        m_stringList.Insert(pos, copy);
-        m_noStrings ++;
+        m_stringArray.Insert(items[i], pos);
         InsertNewItemClientData(pos, clientData, i, type);
     }
 
@@ -174,23 +173,16 @@ int wxComboBox::DoInsertItems(const wxArrayStringsAdapter& items,
 void wxComboBox::DoDeleteOneItem(unsigned int n)
 {
     XmComboBoxDeletePos((Widget) m_mainWidget, n+1);
-    wxStringList::Node *node = m_stringList.Item(n);
-    if (node)
-    {
-        delete[] node->GetData();
-        delete node;
-    }
+    m_stringArray.RemoveAt(n);
     wxControlWithItems::DoDeleteOneItem(n);
-    m_noStrings--;
 }
 
-void wxComboBox::DoClear()
+void wxComboBox::Clear()
 {
     XmComboBoxDeleteAllItems((Widget) m_mainWidget);
-    m_stringList.Clear();
+    m_stringArray.Clear();
 
     wxControlWithItems::DoClear();
-    m_noStrings = 0;
 }
 
 void wxComboBox::SetSelection (int n)
@@ -209,11 +201,7 @@ int wxComboBox::GetSelection (void) const
 
 wxString wxComboBox::GetString(unsigned int n) const
 {
-    wxStringList::Node *node = m_stringList.Item(n);
-    if (node)
-        return wxString(node->GetData ());
-    else
-        return wxEmptyString;
+    return m_stringArray[n];
 }
 
 int wxComboBox::FindString(const wxString& s, bool WXUNUSED(bCase)) const