fix for a crash in ~wxFontList

[wxWidgets.git] / src / generic / statusbr.cpp

diff --git a/src/generic/statusbr.cpp b/src/generic/statusbr.cpp
index de2d7df9409606f07be7060d89a7043564d2abed..386ba1d251c77f956372c99e278ed234597ca00e 100644 (file)
--- a/src/generic/statusbr.cpp
+++ b/src/generic/statusbr.cpp
@@ -29,12 +29,10 @@
 #include "wx/dcclient.h"
 #endif
 
-#include "wx/generic/statusbr.h"
+#include "wx/statusbr.h"
 
-#ifdef __WXMSW__
-#include <windows.h>
-#include "wx/msw/winundef.h"
-#endif
+// with wxUSE_NATIVE_STATUSBAR it is not included from wx/statusbr.h
+#include "wx/generic/statusbr.h"
 
 IMPLEMENT_DYNAMIC_CLASS(wxStatusBarGeneric, wxWindow)
 
@@ -98,34 +96,33 @@ bool wxStatusBarGeneric::Create(wxWindow *parent,
   return success;
 }
 
-void wxStatusBarGeneric::SetFieldsCount(int number, const int widths[])
+void wxStatusBarGeneric::SetFieldsCount(int number, const int *widths)
 {
-  m_nFields = number;
-
-  if ( m_statusWidths )
-    delete[] m_statusWidths;
+    if ( number != m_nFields )
+    {
+        m_nFields = number;
 
-  if ( m_statusStrings )
         delete[] m_statusStrings;
+        m_statusStrings = new wxString[number];
 
-  m_statusStrings = new wxString[number];
-
-  int i;
-  for (i = 0; i < number; i++)
-    m_statusStrings[i] = "";
+#if 0 // VZ: what is this for?
+        int i;
+        for (i = 0; i < number; i++)
+            m_statusStrings[i] = "";
+#endif
+    }
 
-  if ( widths )
-      SetStatusWidths(number, widths);
+    SetStatusWidths(number, widths);
 }
 
 void wxStatusBarGeneric::SetStatusText(const wxString& text, int number)
 {
-  if ((number < 0) || (number >= m_nFields))
-    return;
+    wxCHECK_RET( (number >= 0) && (number < m_nFields),
+                 _T("invalid status bar field index") );
 
-  m_statusStrings[number] = text;
+    m_statusStrings[number] = text;
 
-  Refresh();
+    Refresh();
 }
 
 wxString wxStatusBarGeneric::GetStatusText(int n) const
@@ -138,46 +135,65 @@ wxString wxStatusBarGeneric::GetStatusText(int n) const
 
 void wxStatusBarGeneric::SetStatusWidths(int n, const int widths_field[])
 {
-  // only set status widths, when n == number of statuswindows
-  if (n == m_nFields)
-  {
-    // only set status widths,
+    // only set status widths, when n == number of statuswindows
+    wxCHECK_RET( n == m_nFields, _T("status bar field count mismatch") );
+
+    // delete the old widths in any case - this function may be used to reset
+    // the widths to the default (all equal)
+    delete [] m_statusWidths;
+
+    if ( !widths_field )
+    {
+        // not an error, see the comment above
+        m_statusWidths = (int *)NULL;
+
+        return;
+    }
+
+    int i;
+
+    // VZ: this doesn't do anything as is_variable is unused later
+#if 0
     // when one window (minimum) is variable (width <= 0)
     bool is_variable = FALSE;
-    int i;
     for (i = 0; i < m_nFields; i++)
     {
-      if (widths_field[i] <= 0) is_variable = TRUE;
+        if (widths_field[i] <= 0)
+            is_variable = TRUE;
     }
-
-    // if there are old widths, delete them
-    if (m_statusWidths)
-      delete [] m_statusWidths;
+#endif // 0
 
     // set widths
     m_statusWidths = new int[n];
     for (i = 0; i < m_nFields; i++)
     {
-      m_statusWidths[i] = widths_field[i];
+        m_statusWidths[i] = widths_field[i];
     }
-  }
 }
 
 void wxStatusBarGeneric::OnPaint(wxPaintEvent& WXUNUSED(event) )
 {
   wxPaintDC dc(this);
 
+
   int i;
   if ( GetFont().Ok() )
     dc.SetFont(GetFont());
   dc.SetBackgroundMode(wxTRANSPARENT);
 
+#ifdef __WXPM__
+  wxColour                          vColor;
+
+  vColor.InitFromName("GREY");
+  ::WinFillRect(dc.m_hPS, &dc.m_vRclPaint, vColor.GetPixel());
+#endif
+
   for ( i = 0; i < m_nFields; i ++ )
     DrawField(dc, i);
 
-#   ifdef __WXMSW__
-        dc.SetFont(wxNullFont);
-#   endif // MSW
+#ifdef __WXMSW__
+  dc.SetFont(wxNullFont);
+#endif // MSW
 }
 
 void wxStatusBarGeneric::DrawFieldText(wxDC& dc, int i)
@@ -191,11 +207,21 @@ void wxStatusBarGeneric::DrawFieldText(wxDC& dc, int i)
 
   long x, y;
 
+#if defined(__WXPM__)
+  long decsent;
+
+  dc.GetTextExtent(text, &x, &y,&decsent);
+  int xpos = rect.x + leftMargin;
+  int ypos = (int) (((rect.height - y + 1) / 2 ) + rect.y + decsent ) ;
+
+#else
   dc.GetTextExtent(text, &x, &y);
 
   int xpos = rect.x + leftMargin;
   int ypos = (int) (((rect.height - y) / 2 ) + rect.y + 0.5) ;
 
+#endif // __WXPM__
+
 #if defined( __WXGTK__ ) || defined(__WXMAC__)
   xpos++;
   ypos++;
@@ -221,6 +247,8 @@ void wxStatusBarGeneric::DrawField(wxDC& dc, int i)
 
     dc.SetPen(m_hilightPen);
 
+#ifndef __WXPM__
+
     // Right and bottom white lines
     dc.DrawLine(rect.x + rect.width, rect.y,
                 rect.x + rect.width, rect.y + rect.height);
@@ -234,6 +262,25 @@ void wxStatusBarGeneric::DrawField(wxDC& dc, int i)
            rect.x, rect.y);
     dc.DrawLine(rect.x, rect.y,
         rect.x + rect.width, rect.y);
+#else
+    // Right
+    dc.DrawLine(rect.x + rect.width, rect.y,
+                rect.x + rect.width, rect.y + rect.height + 2);
+    dc.SetPen(m_mediumShadowPen);
+    dc.DrawLine(rect.x + rect.width + 1, rect.y,
+                rect.x + rect.width + 1, rect.y + rect.height + 2);
+    dc.DrawLine(rect.x + rect.width + 2, rect.y,
+                rect.x + rect.width + 2, rect.y + rect.height + 2);
+    // Top
+    dc.DrawLine(rect.x + rect.width + 2, rect.y,
+                rect.x - 2, rect.y);
+    dc.DrawLine(rect.x + rect.width + 1, rect.y - 1,
+                rect.x - 2, rect.y - 1);
+    dc.SetPen(m_hilightPen);
+    dc.DrawLine(rect.x + rect.width, rect.y - 2,
+                rect.x - 2, rect.y - 2);
+
+#endif
 
     DrawFieldText(dc, i);
 }
@@ -245,7 +292,11 @@ bool wxStatusBarGeneric::GetFieldRect(int n, wxRect& rect) const
                _T("invalid status bar field index") );
 
   int width, height;
+#ifdef __WXPM__
+  GetSize(&width, &height);
+#else
   GetClientSize(&width, &height);
+#endif
 
   int i;
   int sum_of_nonvar = 0;
@@ -318,6 +369,9 @@ void wxStatusBarGeneric::InitColours()
 
     wxColour hilightColour(wxSystemSettings::GetSystemColour(wxSYS_COLOUR_3DHILIGHT));
     m_hilightPen = wxPen(hilightColour, 1, wxSOLID);
+#elif defined(__WXPM__)
+    m_mediumShadowPen = wxPen("LIGHT GREY", 1, wxSOLID);
+    m_hilightPen = wxPen("WHITE", 1, wxSOLID);
 #else
     m_mediumShadowPen = wxPen("GREY", 1, wxSOLID);
     m_hilightPen = wxPen("WHITE", 1, wxSOLID);