added wxUSE_PALETTE and fixed compilation with it set to 0

[wxWidgets.git] / src / motif / menu.cpp

diff --git a/src/motif/menu.cpp b/src/motif/menu.cpp
index f42b5d07d4f063ac5c90a91977a4bed761b7e2a1..05c09120079726625978e9d9bcc3395771b616e1 100644 (file)
--- a/src/motif/menu.cpp
+++ b/src/motif/menu.cpp
@@ -6,22 +6,24 @@
 // Created:     17/09/98
 // RCS-ID:      $Id$
 // Copyright:   (c) Julian Smart
 // Created:     17/09/98
 // RCS-ID:      $Id$
 // Copyright:   (c) Julian Smart

-// Licence:    wxWindows licence
+// Licence:     wxWindows licence

 /////////////////////////////////////////////////////////////////////////////
 
 
 // ============================================================================
 /////////////////////////////////////////////////////////////////////////////
 
 
 // ============================================================================

-// headers & declarations
+// declarations

 // ============================================================================
 
 // ============================================================================
 

-// wxWindows headers
-// -----------------
-

 #ifdef __GNUG__
 #ifdef __GNUG__

-#pragma implementation "menu.h"
-#pragma implementation "menuitem.h"
+    #pragma implementation "menu.h"

 #endif
 
 #endif
 

+// ----------------------------------------------------------------------------
+// headers
+// ----------------------------------------------------------------------------
+
+#include "wx/defs.h"
+

 #include "wx/menu.h"
 #include "wx/menuitem.h"
 #include "wx/log.h"
 #include "wx/menu.h"
 #include "wx/menuitem.h"
 #include "wx/log.h"


@@ -30,6 +32,11 @@
 #include "wx/frame.h"
 #include "wx/settings.h"
 
 #include "wx/frame.h"
 #include "wx/settings.h"
 

+#ifdef __VMS__
+#pragma message disable nosimpint
+#define XtDisplay XTDISPLAY
+#define XtWindow XTWINDOW
+#endif

 #include <Xm/Label.h>
 #include <Xm/LabelG.h>
 #include <Xm/CascadeBG.h>
 #include <Xm/Label.h>
 #include <Xm/LabelG.h>
 #include <Xm/CascadeBG.h>


@@ -39,34 +46,30 @@
 #include <Xm/ToggleB.h>
 #include <Xm/ToggleBG.h>
 #include <Xm/RowColumn.h>
 #include <Xm/ToggleB.h>
 #include <Xm/ToggleBG.h>
 #include <Xm/RowColumn.h>

+#ifdef __VMS__
+#pragma message enable nosimpint
+#endif

 
 #include "wx/motif/private.h"
 
 // other standard headers
 
 #include "wx/motif/private.h"
 
 // other standard headers

-// ----------------------

 #include <string.h>
 
 #include <string.h>
 

-#if !USE_SHARED_LIBRARY

 IMPLEMENT_DYNAMIC_CLASS(wxMenu, wxEvtHandler)
 IMPLEMENT_DYNAMIC_CLASS(wxMenuBar, wxEvtHandler)
 IMPLEMENT_DYNAMIC_CLASS(wxMenu, wxEvtHandler)
 IMPLEMENT_DYNAMIC_CLASS(wxMenuBar, wxEvtHandler)

-#endif

 
 // ============================================================================
 // implementation
 // ============================================================================
 
 
 // ============================================================================
 // implementation
 // ============================================================================
 

+// ----------------------------------------------------------------------------

 // Menus
 // Menus

+// ----------------------------------------------------------------------------

 
 // Construct a menu with optional title (then use append)
 
 // Construct a menu with optional title (then use append)

-wxMenu::wxMenu(const wxString& title, const wxFunction func)
+void wxMenu::Init()

 {
 {

-    m_title = title;
-    m_parent = (wxEvtHandler*) NULL;
-    m_eventHandler = this;
-    m_noItems = 0;
-    m_menuBar = NULL;
-
-    //// Motif-specific members
+    // Motif-specific members

     m_numColumns = 1;
     m_menuWidget = (WXWidget) NULL;
     m_popupShell = (WXWidget) NULL;
     m_numColumns = 1;
     m_menuWidget = (WXWidget) NULL;
     m_popupShell = (WXWidget) NULL;


@@ -74,19 +77,16 @@ wxMenu::wxMenu(const wxString& title, const wxFunction func)
     m_menuId = 0;
     m_topLevelMenu  = (wxMenu*) NULL;
     m_ownedByMenuBar = FALSE;
     m_menuId = 0;
     m_topLevelMenu  = (wxMenu*) NULL;
     m_ownedByMenuBar = FALSE;

-    m_menuParent = (wxMenu*) NULL;
-    m_clientData = (void*) NULL;

 
 

-    if (m_title != "")
+    if ( !!m_title )

     {
     {

-        Append(ID_SEPARATOR, m_title) ;
+        Append(wxID_SEPARATOR, m_title) ;

         AppendSeparator() ;
     }
         AppendSeparator() ;
     }

+

     m_backgroundColour = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_MENU);
     m_foregroundColour = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_MENUTEXT);
     m_font = wxSystemSettings::GetSystemFont(wxSYS_DEFAULT_GUI_FONT);
     m_backgroundColour = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_MENU);
     m_foregroundColour = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_MENUTEXT);
     m_font = wxSystemSettings::GetSystemFont(wxSYS_DEFAULT_GUI_FONT);

-
-    Callback(func);

 }
 
 // The wxWindow destructor will take care of deleting the submenus.
 }
 
 // The wxWindow destructor will take care of deleting the submenus.


@@ -94,370 +94,111 @@ wxMenu::~wxMenu()
 {
     if (m_menuWidget)
     {
 {
     if (m_menuWidget)
     {

-      if (m_menuParent)
-        DestroyMenu(TRUE);
-      else
-        DestroyMenu(FALSE);
+        if (m_menuParent)
+            DestroyMenu(TRUE);
+        else
+            DestroyMenu(FALSE);

     }
 
     // Not sure if this is right
     if (m_menuParent && m_menuBar)
     {
     }
 
     // Not sure if this is right
     if (m_menuParent && m_menuBar)
     {

-      m_menuParent = NULL;
-      //      m_menuBar = NULL;
-    }
-
-    wxNode *node = m_menuItems.First();
-    while (node)
-    {
-        wxMenuItem *item = (wxMenuItem *)node->Data();
-
-       /*
-        if (item->GetSubMenu())
-            item->DeleteSubMenu();
-        */
-
-        wxNode *next = node->Next();
-        delete item;
-        delete node;
-        node = next;
+        m_menuParent = NULL;
+        //      m_menuBar = NULL;

     }
 }
 
 void wxMenu::Break()
 {
     }
 }
 
 void wxMenu::Break()
 {

-    m_numColumns ++;
+    m_numColumns++;

 }
 
 // function appends a new item or submenu to the menu
 }
 
 // function appends a new item or submenu to the menu

-void wxMenu::Append(wxMenuItem *pItem)
+bool wxMenu::DoAppend(wxMenuItem *pItem)

 {
 {

-    wxCHECK_RET( pItem != NULL, "can't append NULL item to the menu" );
-
-    m_menuItems.Append(pItem);
-

     if (m_menuWidget)
     if (m_menuWidget)

-      pItem->CreateItem (m_menuWidget, m_menuBar, m_topLevelMenu);     // this is a dynamic Append
-
-    m_noItems++;
-}
-
-void wxMenu::AppendSeparator()
-{
-    Append(new wxMenuItem(this, ID_SEPARATOR));
-}
-
-// Pullright item
-// N.B.: difference between old and new code.
-// Old code stores subMenu in 'children' for later deletion,
-// as well as in m_menuItems, whereas we only store it in
-// m_menuItems here. What implications does this have?
-
-void wxMenu::Append(int id, const wxString& label, wxMenu *subMenu, 
-                    const wxString& helpString)
-{
-    Append(new wxMenuItem(this, id, label, helpString, FALSE, subMenu));
-
-    subMenu->m_topLevelMenu = m_topLevelMenu;
-}
-
-// Ordinary menu item
-void wxMenu::Append(int id, const wxString& label, 
-                    const wxString& helpString, bool checkable)
-{
-  // 'checkable' parameter is useless for Windows.
-    Append(new wxMenuItem(this, id, label, helpString, checkable));
-}
-
-void wxMenu::Delete(int id)
-{
-    wxNode *node;
-    wxMenuItem *item;
-    int pos;
-
-    for (pos = 0, node = m_menuItems.First(); node; node = node->Next(), pos++) 

     {
     {

-        item = (wxMenuItem *)node->Data();
-        if (item->GetId() == id)
-               break;
+        // this is a dynamic Append
+        pItem->CreateItem(m_menuWidget, m_menuBar, m_topLevelMenu);

     }
 
     }
 

-    if (!node)
-       return;
-
-    item->DestroyItem(TRUE);
-
-    // See also old code - don't know if this is needed (seems redundant).
-    /*
-  if (item->GetSubMenu()) {
-    item->subMenu->top_level_menu = item->GetSubMenu();
-    item->subMenu->window_parent = NULL;
-    children->DeleteObject(item->GetSubMenu());
-  }
-  */
-
-    m_menuItems.DeleteNode(node);
-    delete item;
-}
-
-void wxMenu::Enable(int id, bool flag)
-{
-    wxMenuItem *item = FindItemForId(id);
-    wxCHECK_RET( item != NULL, "can't enable non-existing menu item" );
+    if ( pItem->IsSubMenu() )
+    {
+        pItem->GetSubMenu()->m_topLevelMenu = m_topLevelMenu;
+    }

 
 

-    item->Enable(flag);
+    return wxMenuBase::DoAppend(pItem);

 }
 
 }
 

-bool wxMenu::Enabled(int Id) const
+wxMenuItem *wxMenu::DoRemove(wxMenuItem *item)

 {
 {

-    wxMenuItem *item = FindItemForId(Id);
-    wxCHECK( item != NULL, FALSE );
+    item->DestroyItem(TRUE);

 
 

-    return item->IsEnabled();
+    return wxMenuBase::DoRemove(item);

 }
 
 }
 

-void wxMenu::Check(int Id, bool Flag)
+bool wxMenu::DoInsert(size_t pos, wxMenuItem *item)

 {
 {

-    wxMenuItem *item = FindItemForId(Id);
-    wxCHECK_RET( item != NULL, "can't get status of non-existing menu item" );
-
-    item->Check(Flag);
-}
+    if ( !wxMenuBase::DoInsert(pos, item) )
+        return FALSE;

 
 

-bool wxMenu::Checked(int id) const
-{
-    wxMenuItem *item = FindItemForId(id);
-    wxCHECK( item != NULL, FALSE );
+    wxFAIL_MSG(wxT("not implemented"));

 
 

-    return item->IsChecked();
+    return FALSE;

 }
 
 void wxMenu::SetTitle(const wxString& label)
 {
 }
 
 void wxMenu::SetTitle(const wxString& label)
 {

-    m_title = label ;
+    m_title = label;

 
 

-    wxNode *node = m_menuItems.First ();
-    if (!node)
-      return;
+    wxMenuItemList::Node *node = GetMenuItems().GetFirst();
+    if ( !node )
+        return;

 
 

-    wxMenuItem *item = (wxMenuItem *) node->Data ();
+    wxMenuItem *item = node->GetData ();

     Widget widget = (Widget) item->GetButtonWidget();
     Widget widget = (Widget) item->GetButtonWidget();

-    if (!widget)
-      return;
-
-    XmString title_str = XmStringCreateSimple ((char*) (const char*) label);
-    XtVaSetValues (widget,
-                   XmNlabelString, title_str,
-                   NULL);
-    // TODO: should we delete title_str now?
-}
-
-const wxString wxMenu::GetTitle() const
-{
-    return m_title;
-}
-
-void wxMenu::SetLabel(int id, const wxString& label)
-{
-    wxMenuItem *item = FindItemForId(id);
-    if (item == (wxMenuItem*) NULL)
-      return;
-
-    item->SetLabel(label);
-}
-
-wxString wxMenu::GetLabel(int id) const
-{
-  wxMenuItem *it = NULL;
-  WXWidget w = FindMenuItem (id, &it);
-  if (w)
-    {
-      XmString text;
-      char *s;
-      XtVaGetValues ((Widget) w,
-                    XmNlabelString, &text,
-                    NULL);
-
-      if (XmStringGetLtoR (text, XmSTRING_DEFAULT_CHARSET, &s))
-       {
-         wxString str(s);
-         XtFree (s);
-         return str;
-       }
-      else
-       {
-         XmStringFree (text);
-         return wxEmptyString;
-       }
-    }
-  else
-    return wxEmptyString;
-}
-
-// Finds the item id matching the given string, -1 if not found.
-int wxMenu::FindItem (const wxString& itemString) const
-{
-    char buf1[200];
-    char buf2[200];
-    wxStripMenuCodes ((char *)(const char *)itemString, buf1);
-
-    for (wxNode * node = m_menuItems.First (); node; node = node->Next ())
-    {
-      wxMenuItem *item = (wxMenuItem *) node->Data ();
-      if (item->GetSubMenu())
-      {
-        int ans = item->GetSubMenu()->FindItem(itemString);
-        if (ans > -1)
-          return ans;
-      }
-      if ( !item->IsSeparator() )
-      {
-        wxStripMenuCodes((char *)item->GetName().c_str(), buf2);
-        if (strcmp(buf1, buf2) == 0)
-          return item->GetId();
-      }
-    }
-
-    return -1;
-}
-
-wxMenuItem *wxMenu::FindItemForId(int itemId, wxMenu ** itemMenu) const
-{
-    if (itemMenu)
-        *itemMenu = NULL;
-    for (wxNode * node = m_menuItems.First (); node; node = node->Next ())
-    {
-        wxMenuItem *item = (wxMenuItem *) node->Data ();
-
-        if (item->GetId() == itemId)
-        {
-            if (itemMenu)
-                *itemMenu = (wxMenu *) this;
-            return item;
-        }
-
-        if (item->GetSubMenu())
-        {
-            wxMenuItem *ans = item->GetSubMenu()->FindItemForId (itemId, itemMenu);
-            if (ans)
-                return ans;
-        }
-    }
-
-    if (itemMenu)
-        *itemMenu = NULL;
-    return NULL;
-}
-
-void wxMenu::SetHelpString(int itemId, const wxString& helpString)
-{
-    wxMenuItem *item = FindItemForId (itemId);
-    if (item)
-        item->SetHelp(helpString);
-}
+    if ( !widget )
+        return;

 
 

-wxString wxMenu::GetHelpString (int itemId) const
-{
-    wxMenuItem *item = FindItemForId (itemId);
-    wxString str("");
-    return (item == NULL) ? str : item->GetHelp();
+    wxXmString title_str(label);
+    XtVaSetValues(widget,
+                  XmNlabelString, title_str(),
+                  NULL);

 }
 
 }
 

-void wxMenu::ProcessCommand(wxCommandEvent & event)
+bool wxMenu::ProcessCommand(wxCommandEvent & event)

 {
     bool processed = FALSE;
 
 {
     bool processed = FALSE;
 

+#if wxUSE_MENU_CALLBACK

     // Try a callback
     if (m_callback)
     {
     // Try a callback
     if (m_callback)
     {

-            (void) (*(m_callback)) (*this, event);
-            processed = TRUE;
+        (void) (*(m_callback)) (*this, event);
+        processed = TRUE;

     }
     }

+#endif // wxUSE_MENU_CALLBACK

 
     // Try the menu's event handler
     if ( !processed && GetEventHandler())
     {
 
     // Try the menu's event handler
     if ( !processed && GetEventHandler())
     {

-            processed = GetEventHandler()->ProcessEvent(event);
+        processed = GetEventHandler()->ProcessEvent(event);

     }
     }

-/* TODO

     // Try the window the menu was popped up from (and up
     // through the hierarchy)
     if ( !processed && GetInvokingWindow())
         processed = GetInvokingWindow()->ProcessEvent(event);
     // Try the window the menu was popped up from (and up
     // through the hierarchy)
     if ( !processed && GetInvokingWindow())
         processed = GetInvokingWindow()->ProcessEvent(event);

-*/
-}
-
-bool wxWindow::PopupMenu(wxMenu *menu, int x, int y)
-{
-  Widget widget = (Widget) GetMainWidget();
-
-  /* The menuId field seems to be usused, so we'll use it to
-     indicate whether a menu is popped up or not:
-        0: Not currently created as a popup
-       -1: Created as a popup, but not active
-        1: Active popup.
-   */
-
-  if (menu->GetParent() && (menu->GetId() != -1))
-    return FALSE;
-
-  if (menu->GetMainWidget()) {
-    menu->DestroyMenu(TRUE);
-  }

 
 

-  wxWindow *parent = this;
-
-  menu->SetId(1); /* Mark as popped-up */
-  menu->CreateMenu(NULL, widget, menu);
-  //  menu->SetParent(parent);
-  //  parent->children->Append(menu);  // Store menu for later deletion
-
-  Widget menuWidget = (Widget) menu->GetMainWidget();
-
-  int rootX = 0;
-  int rootY = 0;
-
-  int deviceX = x;
-  int deviceY = y;
-  /*
-  if (this->IsKindOf(CLASSINFO(wxCanvas)))
-  {
-    wxCanvas *canvas = (wxCanvas *) this;
-    deviceX = canvas->GetDC ()->LogicalToDeviceX (x);
-    deviceY = canvas->GetDC ()->LogicalToDeviceY (y);
-  }
-  */
-
-  Display *display = XtDisplay (widget);
-  Window rootWindow = RootWindowOfScreen (XtScreen((Widget)widget));
-  Window thisWindow = XtWindow (widget);
-  Window childWindow;
-  XTranslateCoordinates (display, thisWindow, rootWindow, (int) deviceX, (int) deviceY,
-                        &rootX, &rootY, &childWindow);
-
-  XButtonPressedEvent event;
-  event.type = ButtonPress;
-  event.button = 1;
-
-  event.x = deviceX;
-  event.y = deviceY;
-
-  event.x_root = rootX;
-  event.y_root = rootY;
-
-  XmMenuPosition (menuWidget, &event);
-  XtManageChild (menuWidget);
-
-  return TRUE;
+    return processed;

 }
 
 }
 

+// ----------------------------------------------------------------------------

 // Menu Bar
 // Menu Bar

-wxMenuBar::wxMenuBar()
+// ----------------------------------------------------------------------------
+
+void wxMenuBar::Init()

 {
     m_eventHandler = this;
 {
     m_eventHandler = this;

-    m_menuCount = 0;
-    m_menus = NULL;
-    m_titles = NULL;

     m_menuBarFrame = NULL;
     m_mainWidget = (WXWidget) NULL;
     m_backgroundColour = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_MENU);
     m_menuBarFrame = NULL;
     m_mainWidget = (WXWidget) NULL;
     m_backgroundColour = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_MENU);


@@ -467,241 +208,125 @@ wxMenuBar::wxMenuBar()
 
 wxMenuBar::wxMenuBar(int n, wxMenu *menus[], const wxString titles[])
 {
 
 wxMenuBar::wxMenuBar(int n, wxMenu *menus[], const wxString titles[])
 {

-    m_eventHandler = this;
-    m_menuCount = n;
-    m_menus = menus;
-    m_titles = new wxString[n];
-    int i;
-    for ( i = 0; i < n; i++ )
-       m_titles[i] = titles[i];
-    m_menuBarFrame = NULL;
-    m_backgroundColour = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_MENU);
-    m_foregroundColour = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_MENUTEXT);
-    m_font = wxSystemSettings::GetSystemFont(wxSYS_DEFAULT_GUI_FONT);
-}
+    Init();

 
 

-wxMenuBar::~wxMenuBar()
-{
-    int i;
-    for (i = 0; i < m_menuCount; i++)
+    for ( int i = 0; i < n; i++ )

     {
     {

-        delete m_menus[i];
+        m_menus.Append(menus[i]);
+        m_titles.Add(titles[i]);

     }
     }

-    delete[] m_menus;
-    delete[] m_titles;
-}
-
-// Must only be used AFTER menu has been attached to frame,
-// otherwise use individual menus to enable/disable items
-void wxMenuBar::Enable(int id, bool flag)
-{
-    wxMenu *itemMenu = NULL;
-    wxMenuItem *item = FindItemForId(id, &itemMenu) ;
-    if (!item)
-        return;
-    item->Enable(flag);
-}
-
-void wxMenuBar::EnableTop(int pos, bool flag)
-{
-    // TODO
-}
-
-// Must only be used AFTER menu has been attached to frame,
-// otherwise use individual menus
-void wxMenuBar::Check(int id, bool flag)
-{
-    wxMenu *itemMenu = NULL;
-    wxMenuItem *item = FindItemForId(id, &itemMenu) ;
-    if (!item)
-        return;
-
-    if (!item->IsCheckable())
-        return ;
-
-    item->Check(flag);

 }
 
 }
 

-bool wxMenuBar::Checked(int id) const
+wxMenuBar::~wxMenuBar()

 {
 {

-    wxMenu *itemMenu = NULL;
-    wxMenuItem *item = FindItemForId(id, &itemMenu) ;
-    if (!item)
-        return FALSE;
-
-    return item->IsChecked();
+    // nothing to do: wxMenuBarBase will delete the menus

 }
 
 }
 

-bool wxMenuBar::Enabled(int id) const
+void wxMenuBar::EnableTop(size_t WXUNUSED(pos), bool WXUNUSED(flag))

 {
 {

-    wxMenu *itemMenu = NULL;
-    wxMenuItem *item = FindItemForId(id, &itemMenu) ;
-    if (!item)
-        return FALSE;
-
-    return item->IsEnabled();
+  //    wxFAIL_MSG("TODO");
+//  wxLogWarning("wxMenuBar::EnableTop not yet implemented.");

 }
 
 }
 

-void wxMenuBar::SetLabel(int id, const wxString& label)
+void wxMenuBar::SetLabelTop(size_t pos, const wxString& label)

 {
 {

-    wxMenu *itemMenu = NULL;
-    wxMenuItem *item = FindItemForId(id, &itemMenu) ;
-
-    if (!item)
+    wxMenu *menu = GetMenu(pos);
+    if ( !menu )

         return;
 
         return;
 

-    item->SetLabel(label);
-}
-
-wxString wxMenuBar::GetLabel(int id) const
-{
-    wxMenu *itemMenu = NULL;
-    wxMenuItem *item = FindItemForId(id, &itemMenu) ;
-
-    if (!item)
-        return wxString("");
+    Widget w = (Widget)menu->GetButtonWidget();
+    if (w)
+    {
+        wxXmString label_str(label);

 
 

-    return item->GetLabel();
+        XtVaSetValues(w,
+                      XmNlabelString, label_str(),
+                      NULL);
+    }

 }
 
 }
 

-void wxMenuBar::SetLabelTop(int pos, const wxString& label)
+wxString wxMenuBar::GetLabelTop(size_t pos) const

 {
 {

-  wxASSERT( (pos < m_menuCount) );
+    wxString str;

 
 

-  Widget w = (Widget) m_menus[pos]->GetButtonWidget();
-  if (w)
+    wxMenu *menu = GetMenu(pos);
+    if ( menu )

     {
     {

-      XmString label_str = XmStringCreateSimple ((char*) (const char*) label);
-      XtVaSetValues (w,
-                    XmNlabelString, label_str,
-                    NULL);
-      XmStringFree (label_str);
+        Widget w = (Widget)menu->GetButtonWidget();
+        if (w)
+        {
+            XmString text;
+            XtVaGetValues(w,
+                          XmNlabelString, &text,
+                          NULL);
+
+            char *s;
+            if ( XmStringGetLtoR(text, XmSTRING_DEFAULT_CHARSET, &s) )
+            {
+                str = s;
+
+                XtFree(s);
+            }
+        }

     }
     }

+
+    return str;

 }
 
 }
 

-wxString wxMenuBar::GetLabelTop(int pos) const
+bool wxMenuBar::Append(wxMenu * menu, const wxString& title)

 {
 {

-  wxASSERT( (pos < m_menuCount) );
+    wxCHECK_MSG( menu, FALSE, wxT("invalid menu") );
+    wxCHECK_MSG( !menu->GetParent() && !menu->GetButtonWidget(), FALSE,
+                 wxT("menu already appended") );

 
 

-  Widget w = (Widget) m_menus[pos]->GetButtonWidget();
-  if (w)
+    if ( m_menuBarFrame )

     {
     {

-      XmString text;
-      char *s;
-      XtVaGetValues (w,
-                    XmNlabelString, &text,
-                    NULL);
-
-      if (XmStringGetLtoR (text, XmSTRING_DEFAULT_CHARSET, &s))
-       {
-         wxString str(s);
-         XtFree (s);
-         return str;
-       }
-      else
-       {
-         return wxEmptyString;
-       }
+        WXWidget w = menu->CreateMenu(this, GetMainWidget(), menu, title, TRUE);
+        wxCHECK_MSG( w, FALSE, wxT("failed to create menu") );
+        menu->SetButtonWidget(w);

     }
     }

-  else
-    return wxEmptyString;

 
 

-}
+    //menu->SetMenuBar(this);

 
 

-bool wxMenuBar::OnDelete(wxMenu *menu, int pos)
-{
-    // Only applies to dynamic deletion (when set in frame)
-    if (!m_menuBarFrame)
-        return TRUE;
+    m_titles.Add(title);

 
 

-    menu->DestroyMenu(TRUE);
-    return TRUE;
+    return wxMenuBarBase::Append(menu, title);

 }
 
 }
 

-bool wxMenuBar::OnAppend(wxMenu *menu, const char *title)
+bool wxMenuBar::Insert(size_t pos, wxMenu *menu, const wxString& title)

 {
 {

-    // Only applies to dynamic append (when set in frame)
-    if (!m_menuBarFrame)
-        return TRUE;
-
-    // Probably should be an assert here
-    if (menu->GetParent())
-        return FALSE;
-
-    // Has already been appended
-    if (menu->GetButtonWidget())
+    if ( !wxMenuBarBase::Insert(pos, menu, title) )

         return FALSE;
 
         return FALSE;
 

-    WXWidget w = menu->CreateMenu(this, GetMainWidget(), menu, title, TRUE);
-    menu->SetButtonWidget(w);
+    wxFAIL_MSG(wxT("TODO"));

 
 

-    return TRUE;
+    return FALSE;

 }
 
 }
 

-void wxMenuBar::Append (wxMenu * menu, const wxString& title)
+wxMenu *wxMenuBar::Replace(size_t pos, wxMenu *menu, const wxString& title)

 {
 {

-    if (!OnAppend(menu, title))
-        return;
-
-    m_menuCount ++;
-    wxMenu **new_menus = new wxMenu *[m_menuCount];
-    wxString *new_titles = new wxString[m_menuCount];
-    int i;
-
-    for (i = 0; i < m_menuCount - 1; i++)
-       {
-        new_menus[i] = m_menus[i];
-        m_menus[i] = NULL;
-        new_titles[i] = m_titles[i];
-        m_titles[i] = "";
-    }
-    if (m_menus)
-    {
-        delete[]m_menus;
-        delete[]m_titles;
-    }
-    m_menus = new_menus;
-    m_titles = new_titles;
+    if ( !wxMenuBarBase::Replace(pos, menu, title) )
+        return FALSE;

 
 

-    m_menus[m_menuCount - 1] = (wxMenu *)menu;
-    m_titles[m_menuCount - 1] = title;
+    wxFAIL_MSG(wxT("TODO"));

 
 

-    menu->SetMenuBar(this);
-    menu->SetParent(this);
+    return NULL;

 }
 
 }
 

-void wxMenuBar::Delete(wxMenu * menu, int i)
+wxMenu *wxMenuBar::Remove(size_t pos)

 {
 {

-    int j;
-    int ii = (int) i;
+    wxMenu *menu = wxMenuBarBase::Remove(pos);
+    if ( !menu )
+        return NULL;

 
 

-    if (menu != 0)
-    {
-           for (ii = 0; ii < m_menuCount; ii++)
-        {
-            if (m_menus[ii] == menu)
-            break;
-           }
-        if (ii >= m_menuCount)
-            return;
-    } else
-    {
-        if (ii < 0 || ii >= m_menuCount)
-            return;
-        menu = m_menus[ii];
-    }
+    if ( m_menuBarFrame )
+        menu->DestroyMenu(TRUE);

 
 

-    if (!OnDelete(menu, ii))
-        return;
+    menu->SetMenuBar(NULL);

 
 

-    menu->SetParent((wxEvtHandler*) NULL);
+    m_titles.Remove(pos);

 
 

-    -- m_menuCount;
-    for (j = ii; j < m_menuCount; j++)
-    {
-        m_menus[j] = m_menus[j + 1];
-        m_titles[j] = m_titles[j + 1];
-    }
+    return menu;

 }
 
 // Find the menu menuString, item itemString, and return the item id.
 }
 
 // Find the menu menuString, item itemString, and return the item id.


@@ -711,8 +336,9 @@ int wxMenuBar::FindMenuItem (const wxString& menuString, const wxString& itemStr
     char buf1[200];
     char buf2[200];
     wxStripMenuCodes ((char *)(const char *)menuString, buf1);
     char buf1[200];
     char buf2[200];
     wxStripMenuCodes ((char *)(const char *)menuString, buf1);

-    int i;
-    for (i = 0; i < m_menuCount; i++)
+
+    size_t menuCount = GetMenuCount();
+    for (size_t i = 0; i < menuCount; i++)

     {
         wxStripMenuCodes ((char *)(const char *)m_titles[i], buf2);
         if (strcmp (buf1, buf2) == 0)
     {
         wxStripMenuCodes ((char *)(const char *)m_titles[i], buf2);
         if (strcmp (buf1, buf2) == 0)


@@ -721,310 +347,313 @@ int wxMenuBar::FindMenuItem (const wxString& menuString, const wxString& itemStr
     return -1;
 }
 
     return -1;
 }
 

-wxMenuItem *wxMenuBar::FindItemForId (int id, wxMenu ** itemMenu) const
+wxMenuItem *wxMenuBar::FindItem(int id, wxMenu ** itemMenu) const

 {
     if (itemMenu)
         *itemMenu = NULL;
 
     wxMenuItem *item = NULL;
 {
     if (itemMenu)
         *itemMenu = NULL;
 
     wxMenuItem *item = NULL;

-    int i;
-    for (i = 0; i < m_menuCount; i++)
-        if ((item = m_menus[i]->FindItemForId (id, itemMenu)))
+    size_t menuCount = GetMenuCount();
+    for (size_t i = 0; i < menuCount; i++)
+        if ((item = m_menus[i]->FindItem(id, itemMenu)))

             return item;
             return item;

-    return NULL;
-}
-
-void wxMenuBar::SetHelpString (int id, const wxString& helpString)
-{
-    int i;
-    for (i = 0; i < m_menuCount; i++)
-    {
-        if (m_menus[i]->FindItemForId (id))
-        {
-            m_menus[i]->SetHelpString (id, helpString);
-            return;
-        }
-    }
-}
-
-wxString wxMenuBar::GetHelpString (int id) const
-{
-    int i;
-    for (i = 0; i < m_menuCount; i++)
-    {
-        if (m_menus[i]->FindItemForId (id))
-            return wxString(m_menus[i]->GetHelpString (id));
-    }
-    return wxString("");
+        return NULL;

 }
 
 // Create menubar
 bool wxMenuBar::CreateMenuBar(wxFrame* parent)
 {
 }
 
 // Create menubar
 bool wxMenuBar::CreateMenuBar(wxFrame* parent)
 {

-  if (m_mainWidget)
-  {
-    XtVaSetValues((Widget) parent->GetMainWindowWidget(), XmNmenuBar, (Widget) m_mainWidget, NULL);
-    /*
-    if (!XtIsManaged((Widget) m_mainWidget))
-      XtManageChild((Widget) m_mainWidget);
-      */
-    XtMapWidget((Widget) m_mainWidget);
-    return TRUE;
-  }
+    if (m_mainWidget)
+    {
+        XtVaSetValues((Widget) parent->GetMainWidget(), XmNmenuBar, (Widget) m_mainWidget, NULL);
+        /*
+        if (!XtIsManaged((Widget) m_mainWidget))
+        XtManageChild((Widget) m_mainWidget);
+        */
+        XtMapWidget((Widget) m_mainWidget);
+        return TRUE;
+    }

 
 

-  Widget menuBarW = XmCreateMenuBar ((Widget) parent->GetMainWindowWidget(), "MenuBar", NULL, 0);
-  m_mainWidget = (WXWidget) menuBarW;
+    Widget menuBarW = XmCreateMenuBar ((Widget) parent->GetMainWidget(), "MenuBar", NULL, 0);
+    m_mainWidget = (WXWidget) menuBarW;

 
 

-  int i;
-  for (i = 0; i < GetMenuCount(); i++)
+    size_t menuCount = GetMenuCount();
+    for (size_t i = 0; i < menuCount; i++)

     {
     {

-      wxMenu *menu = GetMenu(i);
-      wxString title(m_titles[i]);
-      menu->SetButtonWidget(menu->CreateMenu (this, menuBarW, menu, title, TRUE));
+        wxMenu *menu = GetMenu(i);
+        wxString title(m_titles[i]);
+        menu->SetButtonWidget(menu->CreateMenu (this, menuBarW, menu, title, TRUE));

 
 

-      /*
-       * COMMENT THIS OUT IF YOU DON'T LIKE A RIGHT-JUSTIFIED HELP MENU
-       */
-      wxStripMenuCodes ((char*) (const char*) title, wxBuffer);
+        if (strcmp (wxStripMenuCodes(title), "Help") == 0)
+            XtVaSetValues ((Widget) menuBarW, XmNmenuHelpWidget, (Widget) menu->GetButtonWidget(), NULL);

 
 

-      if (strcmp (wxBuffer, "Help") == 0)
-        XtVaSetValues ((Widget) menuBarW, XmNmenuHelpWidget, (Widget) menu->GetButtonWidget(), NULL);
+        // tear off menu support
+#if (XmVersion >= 1002)
+        if ( menu->IsTearOff() )
+        {
+            XtVaSetValues(GetWidget(menu),
+                          XmNtearOffModel, XmTEAR_OFF_ENABLED,
+                          NULL);
+            Widget tearOff = XmGetTearOffControl(GetWidget(menu));
+            wxDoChangeForegroundColour((Widget) tearOff, m_foregroundColour);
+            wxDoChangeBackgroundColour((Widget) tearOff, m_backgroundColour, TRUE);
+#endif
+        }

     }
 
     }
 

-  SetBackgroundColour(m_backgroundColour);
-  SetForegroundColour(m_foregroundColour);
-  SetFont(m_font);
+    SetBackgroundColour(m_backgroundColour);
+    SetForegroundColour(m_foregroundColour);
+    SetFont(m_font);

 
 

-  XtVaSetValues((Widget) parent->GetMainWindowWidget(), XmNmenuBar, (Widget) m_mainWidget, NULL);
-  XtRealizeWidget ((Widget) menuBarW);
-  XtManageChild ((Widget) menuBarW);
-  SetMenuBarFrame(parent);
+    XtVaSetValues((Widget) parent->GetMainWidget(), XmNmenuBar, (Widget) m_mainWidget, NULL);
+    XtRealizeWidget ((Widget) menuBarW);
+    XtManageChild ((Widget) menuBarW);
+    SetMenuBarFrame(parent);

 
 

-  return TRUE;
+    return TRUE;

 }
 
 // Destroy menubar, but keep data structures intact so we can recreate it.
 bool wxMenuBar::DestroyMenuBar()
 {
 }
 
 // Destroy menubar, but keep data structures intact so we can recreate it.
 bool wxMenuBar::DestroyMenuBar()
 {

-  if (!m_mainWidget)
-  {
-      SetMenuBarFrame((wxFrame*) NULL);
-      return FALSE;
-  }
+    if (!m_mainWidget)
+    {
+        SetMenuBarFrame((wxFrame*) NULL);
+        return FALSE;
+    }

 
 

-  XtUnmanageChild ((Widget) m_mainWidget);
-  XtUnrealizeWidget ((Widget) m_mainWidget);
+    XtUnmanageChild ((Widget) m_mainWidget);
+    XtUnrealizeWidget ((Widget) m_mainWidget);

 
 

-  int i;
-  for (i = 0; i < GetMenuCount(); i++)
+    size_t menuCount = GetMenuCount();
+    for (size_t i = 0; i < menuCount; i++)

     {
     {

-      wxMenu *menu = GetMenu(i);
-      menu->DestroyMenu(TRUE);
+        wxMenu *menu = GetMenu(i);
+        menu->DestroyMenu(TRUE);

 
     }
 
     }

-  XtDestroyWidget((Widget) m_mainWidget);
-  m_mainWidget = (WXWidget) 0;
+    XtDestroyWidget((Widget) m_mainWidget);
+    m_mainWidget = (WXWidget) 0;

 
 

-  SetMenuBarFrame((wxFrame*) NULL);
+    SetMenuBarFrame((wxFrame*) NULL);

 
 

-  return TRUE;
+    return TRUE;

 }
 
 //// Motif-specific
 }
 
 //// Motif-specific

-
-extern wxApp *wxTheApp;

 static XtWorkProcId WorkProcMenuId;
 
 /* Since PopupMenu under Motif stills grab right mouse button events
 static XtWorkProcId WorkProcMenuId;
 
 /* Since PopupMenu under Motif stills grab right mouse button events

- * after it was closed, we need to delete the associated widgets to
- * allow next PopUpMenu to appear...
- */
+* after it was closed, we need to delete the associated widgets to
+* allow next PopUpMenu to appear...
+*/

 
 int PostDeletionOfMenu( XtPointer* clientData )
 {
 
 int PostDeletionOfMenu( XtPointer* clientData )
 {

-  XtRemoveWorkProc(WorkProcMenuId);
-  wxMenu *menu = (wxMenu *)clientData;
+    XtRemoveWorkProc(WorkProcMenuId);
+    wxMenu *menu = (wxMenu *)clientData;

 
 

-  if (menu->GetMainWidget()) {
-    if (menu->GetParent())
+    if (menu->GetMainWidget())

     {
     {

-      wxList& list = menu->GetParent()->GetItems();
-      list.DeleteObject(menu);
+        wxMenu *menuParent = menu->GetParent();
+        if ( menuParent )
+        {
+            wxMenuItemList::Node *node = menuParent->GetMenuItems().GetFirst();
+            while ( node )
+            {
+                if ( node->GetData()->GetSubMenu() == menu )
+                {
+                    menuParent->GetMenuItems().DeleteNode(node);
+
+                    break;
+                }
+
+                node = node->GetNext();
+            }
+        }
+
+        menu->DestroyMenu(TRUE);

     }
     }

-    menu->DestroyMenu(TRUE);
-  }
-  /* Mark as no longer popped up */
-  menu->m_menuId = -1;
-  return TRUE;
+
+    // Mark as no longer popped up
+    menu->m_menuId = -1;
+
+    return TRUE;

 }
 
 }
 

-void 
-wxMenuPopdownCallback(Widget w, XtPointer clientData,
-                     XtPointer ptr)
+void
+wxMenuPopdownCallback(Widget WXUNUSED(w), XtPointer clientData,
+                      XtPointer WXUNUSED(ptr))

 {
 {

-  wxMenu *menu = (wxMenu *)clientData;
-
-  // Added by JOREL Jean-Charles <jjorel@silr.ireste.fr>
-  /* Since Callbacks of MenuItems are not yet processed, we put a
-   * background job which will be done when system will be idle.
-   * What awful hack!! :(
-   */
-
-  WorkProcMenuId = XtAppAddWorkProc( 
-               (XtAppContext) wxTheApp->GetAppContext(), 
-               (XtWorkProc) PostDeletionOfMenu,
-               (XtPointer) menu );
-  // Apparently not found in Motif headers
-  //  XtVaSetValues( w, XmNpopupEnabled, XmPOPUP_DISABLED, NULL );
+    wxMenu *menu = (wxMenu *)clientData;
+
+    // Added by JOREL Jean-Charles <jjorel@silr.ireste.fr>
+    /* Since Callbacks of MenuItems are not yet processed, we put a
+    * background job which will be done when system will be idle.
+    * What awful hack!! :(
+    */
+
+    WorkProcMenuId = XtAppAddWorkProc(
+        (XtAppContext) wxTheApp->GetAppContext(),
+        (XtWorkProc) PostDeletionOfMenu,
+        (XtPointer) menu );
+    // Apparently not found in Motif headers
+    //  XtVaSetValues( w, XmNpopupEnabled, XmPOPUP_DISABLED, NULL );

 }
 
 /*
 }
 
 /*

- * Create a popup or pulldown menu.
- * Submenus of a popup will be pulldown.
- *
- */
+* Create a popup or pulldown menu.
+* Submenus of a popup will be pulldown.
+*
+*/

 
 WXWidget wxMenu::CreateMenu (wxMenuBar * menuBar, WXWidget parent, wxMenu * topMenu, const wxString& title, bool pullDown)
 {
 
 WXWidget wxMenu::CreateMenu (wxMenuBar * menuBar, WXWidget parent, wxMenu * topMenu, const wxString& title, bool pullDown)
 {

-  Widget menu = (Widget) 0;
-  Widget buttonWidget = (Widget) 0;
-  Arg args[5];
-  XtSetArg (args[0], XmNnumColumns, m_numColumns);
-  XtSetArg (args[1], XmNpacking, XmPACK_COLUMN);
+    Widget menu = (Widget) 0;
+    Widget buttonWidget = (Widget) 0;
+    Arg args[5];
+    XtSetArg (args[0], XmNnumColumns, m_numColumns);
+    XtSetArg (args[1], XmNpacking, XmPACK_COLUMN);

 
 

-  if (!pullDown)
+    if (!pullDown)

     {
     {

-      menu = XmCreatePopupMenu ((Widget) parent, "popup", args, 2);
-      XtAddCallback(menu,
-                   XmNunmapCallback, 
-                   (XtCallbackProc)wxMenuPopdownCallback,
-                   (XtPointer)this);
+        menu = XmCreatePopupMenu ((Widget) parent, "popup", args, 2);
+        XtAddCallback(menu,
+            XmNunmapCallback,
+            (XtCallbackProc)wxMenuPopdownCallback,
+            (XtPointer)this);

     }
     }

-  else
+    else

     {
     {

-      char mnem = wxFindMnemonic (title);
-      wxStripMenuCodes ((char*) (const char*) title, wxBuffer);
+        char mnem = wxFindMnemonic (title);
+        wxStripMenuCodes ((char*) (const char*) title, wxBuffer);

 
 

-      menu = XmCreatePulldownMenu ((Widget) parent, "pulldown", args, 2);
+        menu = XmCreatePulldownMenu ((Widget) parent, "pulldown", args, 2);

 
 

-      XmString label_str = XmStringCreateSimple (wxBuffer);
-      buttonWidget = XtVaCreateManagedWidget (wxBuffer,
+        wxString title2(wxStripMenuCodes(title));
+        wxXmString label_str(title2);
+        buttonWidget = XtVaCreateManagedWidget(title2,

 #if wxUSE_GADGETS
 #if wxUSE_GADGETS

-                                        xmCascadeButtonGadgetClass, (Widget) parent,
+            xmCascadeButtonGadgetClass, (Widget) parent,

 #else
 #else

-                                        xmCascadeButtonWidgetClass, (Widget) parent,
+            xmCascadeButtonWidgetClass, (Widget) parent,

 #endif
 #endif

-                                             XmNlabelString, label_str,
-                                             XmNsubMenuId, menu,
-                                             NULL);
+            XmNlabelString, label_str(),
+            XmNsubMenuId, menu,
+            NULL);

 
 

-      if (mnem != 0)
-       XtVaSetValues (buttonWidget, XmNmnemonic, mnem, NULL);
-
-      XmStringFree (label_str);
+        if (mnem != 0)
+            XtVaSetValues (buttonWidget, XmNmnemonic, mnem, NULL);

     }
 
     }
 

-  m_menuWidget = (WXWidget) menu;
+    m_menuWidget = (WXWidget) menu;

 
 

-  m_menuBar = menuBar;
-  m_topLevelMenu = topMenu;
+    m_menuBar = menuBar;
+    m_topLevelMenu = topMenu;

 
 

-  for (wxNode * node = m_menuItems.First (); node; node = node->Next ())
+    for ( wxMenuItemList::Node *node = GetMenuItems().GetFirst();
+          node;
+          node = node->GetNext() )

     {
     {

-      wxMenuItem *item = (wxMenuItem *) node->Data ();
-      item->CreateItem (menu, menuBar, topMenu);
+        wxMenuItem *item = node->GetData();
+
+        item->CreateItem(menu, menuBar, topMenu);

     }
 
     }
 

-  SetBackgroundColour(m_backgroundColour);
-  SetForegroundColour(m_foregroundColour);
-  SetFont(m_font);
+    SetBackgroundColour(m_backgroundColour);
+    SetForegroundColour(m_foregroundColour);
+    SetFont(m_font);

 
 

-  return buttonWidget;
+    return buttonWidget;

 }
 
 // Destroys the Motif implementation of the menu,
 // but maintains the wxWindows data structures so we can
 }
 
 // Destroys the Motif implementation of the menu,
 // but maintains the wxWindows data structures so we can

-// do a CreateMenu again. 
+// do a CreateMenu again.

 void wxMenu::DestroyMenu (bool full)
 {
 void wxMenu::DestroyMenu (bool full)
 {

-  for (wxNode * node = m_menuItems.First (); node; node = node->Next ())
+    for ( wxMenuItemList::Node *node = GetMenuItems().GetFirst();
+          node;
+          node = node->GetNext() )

     {
     {

-      wxMenuItem *item = (wxMenuItem *) node->Data ();
-      item->SetMenuBar((wxMenuBar*) NULL);
+        wxMenuItem *item = node->GetData();
+        item->SetMenuBar((wxMenuBar*) NULL);

 
 

-      item->DestroyItem(full);
-    }                          // for()
+        item->DestroyItem(full);
+    }

 
 

-  if (m_buttonWidget)
+    if (m_buttonWidget)

     {
     {

-      if (full)
-      {
-        XtVaSetValues((Widget) m_buttonWidget, XmNsubMenuId, NULL, NULL);
-        XtDestroyWidget ((Widget) m_buttonWidget);
-        m_buttonWidget = (WXWidget) 0;
-      }
+        if (full)
+        {
+            XtVaSetValues((Widget) m_buttonWidget, XmNsubMenuId, NULL, NULL);
+            XtDestroyWidget ((Widget) m_buttonWidget);
+            m_buttonWidget = (WXWidget) 0;
+        }

     }
     }

-  if (m_menuWidget && full)
+    if (m_menuWidget && full)

     {
     {

-      XtDestroyWidget((Widget) m_menuWidget);
-      m_menuWidget = (WXWidget) NULL;
+        XtDestroyWidget((Widget) m_menuWidget);
+        m_menuWidget = (WXWidget) NULL;

     }
 }
 
 WXWidget wxMenu::FindMenuItem (int id, wxMenuItem ** it) const
 {
     }
 }
 
 WXWidget wxMenu::FindMenuItem (int id, wxMenuItem ** it) const
 {

-  if (id == m_menuId)
+    if (id == m_menuId)

     {
     {

-      if (it)
-       *it = (wxMenuItem*) NULL;
-      return m_buttonWidget;
+        if (it)
+            *it = (wxMenuItem*) NULL;
+        return m_buttonWidget;

     }
 
     }
 

-  for (wxNode * node = m_menuItems.First (); node; node = node->Next ())
+    for ( wxMenuItemList::Node *node = GetMenuItems().GetFirst();
+          node;
+          node = node->GetNext() )

     {
     {

-      wxMenuItem *item = (wxMenuItem *) node->Data ();
-      if (item->GetId() == id)
-       {
-         if (it)
-           *it = item;
-         return item->GetButtonWidget();
-       }
-
-      if (item->GetSubMenu())
-       {
-         WXWidget w = item->GetSubMenu()->FindMenuItem (id, it);
-         if (w)
-           {
-             return w;
-           }
-       }
-    }                          // for()
-
-  if (it)
-    *it = (wxMenuItem*) NULL;
-  return (WXWidget) NULL;
+        wxMenuItem *item = node->GetData ();
+        if (item->GetId() == id)
+        {
+            if (it)
+                *it = item;
+            return item->GetButtonWidget();
+        }
+
+        if (item->GetSubMenu())
+        {
+            WXWidget w = item->GetSubMenu()->FindMenuItem (id, it);
+            if (w)
+            {
+                return w;
+            }
+        }
+    }
+
+    if (it)
+        *it = (wxMenuItem*) NULL;
+    return (WXWidget) NULL;

 }
 
 void wxMenu::SetBackgroundColour(const wxColour& col)
 {
     m_backgroundColour = col;
     if (m_menuWidget)
 }
 
 void wxMenu::SetBackgroundColour(const wxColour& col)
 {
     m_backgroundColour = col;
     if (m_menuWidget)

-       wxDoChangeBackgroundColour(m_menuWidget, (wxColour&) col);
+        wxDoChangeBackgroundColour(m_menuWidget, (wxColour&) col);

     if (m_buttonWidget)
     if (m_buttonWidget)

-       wxDoChangeBackgroundColour(m_buttonWidget, (wxColour&) col, TRUE);
+        wxDoChangeBackgroundColour(m_buttonWidget, (wxColour&) col, TRUE);

 
 

-    wxNode* node = m_menuItems.First();
-    while (node)
+    for ( wxMenuItemList::Node *node = GetMenuItems().GetFirst();
+          node;
+          node = node->GetNext() )

     {
     {

-        wxMenuItem* item = (wxMenuItem*) node->Data();
+        wxMenuItem* item = node->GetData();

         if (item->GetButtonWidget())
         {
         if (item->GetButtonWidget())
         {

-          // This crashes because it uses gadgets
-         //            wxDoChangeBackgroundColour(item->GetButtonWidget(), (wxColour&) col, TRUE);
+            // This crashes because it uses gadgets
+            //            wxDoChangeBackgroundColour(item->GetButtonWidget(), (wxColour&) col, TRUE);

         }
         if (item->GetSubMenu())
         }
         if (item->GetSubMenu())

-          item->GetSubMenu()->SetBackgroundColour((wxColour&) col);
-        node = node->Next();
+            item->GetSubMenu()->SetBackgroundColour((wxColour&) col);

     }
 }
 
     }
 }
 


@@ -1032,56 +661,57 @@ void wxMenu::SetForegroundColour(const wxColour& col)
 {
     m_foregroundColour = col;
     if (m_menuWidget)
 {
     m_foregroundColour = col;
     if (m_menuWidget)

-       wxDoChangeForegroundColour(m_menuWidget, (wxColour&) col);
+        wxDoChangeForegroundColour(m_menuWidget, (wxColour&) col);

     if (m_buttonWidget)
     if (m_buttonWidget)

-       wxDoChangeForegroundColour(m_buttonWidget, (wxColour&) col);
+        wxDoChangeForegroundColour(m_buttonWidget, (wxColour&) col);

 
 

-    wxNode* node = m_menuItems.First();
-    while (node)
+    for ( wxMenuItemList::Node *node = GetMenuItems().GetFirst();
+          node;
+          node = node->GetNext() )

     {
     {

-        wxMenuItem* item = (wxMenuItem*) node->Data();
+        wxMenuItem* item = node->GetData();

         if (item->GetButtonWidget())
         {
         if (item->GetButtonWidget())
         {

-          // This crashes because it uses gadgets
-         //            wxDoChangeForegroundColour(item->GetButtonWidget(), (wxColour&) col);
+            // This crashes because it uses gadgets
+            //            wxDoChangeForegroundColour(item->GetButtonWidget(), (wxColour&) col);

         }
         if (item->GetSubMenu())
         }
         if (item->GetSubMenu())

-          item->GetSubMenu()->SetForegroundColour((wxColour&) col);
-        node = node->Next();
+            item->GetSubMenu()->SetForegroundColour((wxColour&) col);

     }
 }
 
 void wxMenu::ChangeFont(bool keepOriginalSize)
 {
     }
 }
 
 void wxMenu::ChangeFont(bool keepOriginalSize)
 {

-// lesstif 0.87 hangs when setting XmNfontList
-#ifndef LESSTIF_VERSION        
+    // lesstif 0.87 hangs when setting XmNfontList
+#ifndef LESSTIF_VERSION

     if (!m_font.Ok() || !m_menuWidget)
         return;
 
     XmFontList fontList = (XmFontList) m_font.GetFontList(1.0, XtDisplay((Widget) m_menuWidget));
 
     XtVaSetValues ((Widget) m_menuWidget,
     if (!m_font.Ok() || !m_menuWidget)
         return;
 
     XmFontList fontList = (XmFontList) m_font.GetFontList(1.0, XtDisplay((Widget) m_menuWidget));
 
     XtVaSetValues ((Widget) m_menuWidget,

-                  XmNfontList, fontList,
-                  NULL);
+        XmNfontList, fontList,
+        NULL);

     if (m_buttonWidget)
     {
     if (m_buttonWidget)
     {

-      XtVaSetValues ((Widget) m_buttonWidget,
-                  XmNfontList, fontList,
-                  NULL);
+        XtVaSetValues ((Widget) m_buttonWidget,
+            XmNfontList, fontList,
+            NULL);

     }
     }

-    wxNode* node = m_menuItems.First();
-    while (node)
+
+    for ( wxMenuItemList::Node *node = GetMenuItems().GetFirst();
+          node;
+          node = node->GetNext() )

     {
     {

-        wxMenuItem* item = (wxMenuItem*) node->Data();
+        wxMenuItem* item = node->GetData();

         if (m_menuWidget && item->GetButtonWidget() && m_font.Ok())
         {
         if (m_menuWidget && item->GetButtonWidget() && m_font.Ok())
         {

-          XtVaSetValues ((Widget) item->GetButtonWidget(),
-                  XmNfontList, fontList,
-                  NULL);
+            XtVaSetValues ((Widget) item->GetButtonWidget(),
+                XmNfontList, fontList,
+                NULL);

         }
         if (item->GetSubMenu())
         }
         if (item->GetSubMenu())

-          item->GetSubMenu()->ChangeFont(keepOriginalSize);
-        node = node->Next();
+            item->GetSubMenu()->ChangeFont(keepOriginalSize);

     }
 #endif
 }
     }
 #endif
 }


@@ -1092,40 +722,46 @@ void wxMenu::SetFont(const wxFont& font)
     ChangeFont();
 }
 
     ChangeFont();
 }
 

-void wxMenuBar::SetBackgroundColour(const wxColour& col)
+bool wxMenuBar::SetBackgroundColour(const wxColour& col)

 {
 {

-

     m_backgroundColour = col;
     if (m_mainWidget)
     m_backgroundColour = col;
     if (m_mainWidget)

-       wxDoChangeBackgroundColour(m_mainWidget, (wxColour&) col);
-    int i;
-    for (i = 0; i < m_menuCount; i++)
-      m_menus[i]->SetBackgroundColour((wxColour&) col);
+        wxDoChangeBackgroundColour(m_mainWidget, (wxColour&) col);
+
+    size_t menuCount = GetMenuCount();
+    for (size_t i = 0; i < menuCount; i++)
+        m_menus[i]->SetBackgroundColour((wxColour&) col);
+
+    return TRUE;

 }
 
 }
 

-void wxMenuBar::SetForegroundColour(const wxColour& col)
+bool wxMenuBar::SetForegroundColour(const wxColour& col)

 {
     m_foregroundColour = col;
     if (m_mainWidget)
 {
     m_foregroundColour = col;
     if (m_mainWidget)

-       wxDoChangeForegroundColour(m_mainWidget, (wxColour&) col);
+        wxDoChangeForegroundColour(m_mainWidget, (wxColour&) col);
+
+    size_t menuCount = GetMenuCount();
+    for (size_t i = 0; i < menuCount; i++)
+        m_menus[i]->SetForegroundColour((wxColour&) col);

 
 

-    int i;
-    for (i = 0; i < m_menuCount; i++)
-      m_menus[i]->SetForegroundColour((wxColour&) col);
+    return TRUE;

 }
 
 }
 

-void wxMenuBar::ChangeFont(bool keepOriginalSize)
+void wxMenuBar::ChangeFont(bool WXUNUSED(keepOriginalSize))

 {
 {

-  // Nothing to do for menubar, fonts are kept in wxMenus
+    // Nothing to do for menubar, fonts are kept in wxMenus

 }
 
 }
 

-void wxMenuBar::SetFont(const wxFont& font)
+bool wxMenuBar::SetFont(const wxFont& font)

 {
     m_font = font;
     ChangeFont();
 
 {
     m_font = font;
     ChangeFont();
 

-    int i;
-    for (i = 0; i < m_menuCount; i++)
-      m_menus[i]->SetFont(font);
+    size_t menuCount = GetMenuCount();
+    for (size_t i = 0; i < menuCount; i++)
+        m_menus[i]->SetFont(font);
+
+    return TRUE;

 }
 
 }