add emission hook from RemoveIdleSource (was RemoveIdleTag); minor cleanup

[wxWidgets.git] / src / common / bookctrl.cpp

diff --git a/src/common/bookctrl.cpp b/src/common/bookctrl.cpp
index e8539c12f482089aee95e4951f411161f915422b..ffae3d708da7c67332915c8397b6fb52c422a9ff 100644 (file)
--- a/src/common/bookctrl.cpp
+++ b/src/common/bookctrl.cpp
@@ -162,32 +162,61 @@ wxSize wxBookCtrlBase::DoGetBestSize() const
 }
 
 #if wxUSE_HELP
+
 void wxBookCtrlBase::OnHelp(wxHelpEvent& event)
 {
-    // find the corresponding page
-    wxWindow *page = NULL;
+    // determine where does this even originate from to avoid redirecting it
+    // back to the page which generated it (resulting in an infinite loop)
+
+    // notice that we have to check in the hard(er) way instead of just testing
+    // if the event object == this because the book control can have other
+    // subcontrols inside it (e.g. wxSpinButton in case of a notebook in wxUniv)
+    wxWindow *source = wxStaticCast(event.GetEventObject(), wxWindow);
+    while ( source && source != this && source->GetParent() != this )
+    {
+        source = source->GetParent();
+    }
 
-    if ( event.GetOrigin() == wxHelpEvent::Origin_HelpButton )
+    if ( source && m_pages.Index(source) == wxNOT_FOUND )
     {
-        // show help for the page under the mouse
-        const int pagePos = HitTest(ScreenToClient(event.GetPosition()));
+        // this event is for the book control itself, redirect it to the
+        // corresponding page
+        wxWindow *page = NULL;
 
-        if ( pagePos != wxNOT_FOUND)
+        if ( event.GetOrigin() == wxHelpEvent::Origin_HelpButton )
         {
-            page = GetPage((size_t)pagePos);
+            // show help for the page under the mouse
+            const int pagePos = HitTest(ScreenToClient(event.GetPosition()));
+
+            if ( pagePos != wxNOT_FOUND)
+            {
+                page = GetPage((size_t)pagePos);
+            }
+        }
+        else // event from keyboard or unknown source
+        {
+            // otherwise show the current page help
+            page = GetCurrentPage();
         }
-    }
 
-    if ( !page )
-    {
-        page = GetCurrentPage();
+        if ( page )
+        {
+            // change event object to the page to avoid infinite recursion if
+            // we get this event ourselves if the page doesn't handle it
+            event.SetEventObject(page);
+
+            if ( page->GetEventHandler()->ProcessEvent(event) )
+            {
+                // don't call event.Skip()
+                return;
+            }
+        }
     }
+    //else: event coming from one of our pages already
 
-    if ( !page || !page->GetEventHandler()->ProcessEvent(event) )
-    {
-        event.Skip();
-    }
+    event.Skip();
 }
+
 #endif // wxUSE_HELP
 
 // ----------------------------------------------------------------------------
@@ -268,11 +297,8 @@ wxRect wxBookCtrlBase::GetPageRect() const
 
     wxPoint pt;
     wxRect rectPage(pt, GetClientSize());
-    long style = GetWindowStyle();
-    if ( !HasFlag(wxBK_ALIGN_MASK) )
-        style = GetDefaultAlignment();
 
-    switch ( style )
+    switch ( GetWindowStyle() & wxBK_ALIGN_MASK )
     {
         default:
             wxFAIL_MSG( _T("unexpected alignment") );
@@ -284,6 +310,8 @@ wxRect wxBookCtrlBase::GetPageRect() const
 
         case wxBK_BOTTOM:
             rectPage.height -= size.y + GetInternalBorder();
+            if (rectPage.height < 0)
+                rectPage.height = 0;
             break;
 
         case wxBK_LEFT:
@@ -292,6 +320,8 @@ wxRect wxBookCtrlBase::GetPageRect() const
 
         case wxBK_RIGHT:
             rectPage.width -= size.x + GetInternalBorder();
+            if (rectPage.width < 0)
+                rectPage.width = 0;
             break;
     }