Wrong order of calls

[wxWidgets.git] / src / gtk / timer.cpp

diff --git a/src/gtk/timer.cpp b/src/gtk/timer.cpp
index 175c92aa12168af15f1b170d51d12b7eeef18c67..628ede1a184036807f7cbd8b4351ab92b56e0cdd 100644 (file)
--- a/src/gtk/timer.cpp
+++ b/src/gtk/timer.cpp
@@ -1,74 +1,69 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        timer.cpp
-// Purpose:
+// Name:        gtk/timer.cpp
+// Purpose:     wxTimer implementation

 // Author:      Robert Roebling
 // Id:          $Id$
 // Copyright:   (c) 1998 Robert Roebling
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // Author:      Robert Roebling
 // Id:          $Id$
 // Copyright:   (c) 1998 Robert Roebling
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 

+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"

 
 

-#ifdef __GNUG__
-#pragma implementation "timer.h"
-#endif
+#if wxUSE_TIMER

 
 

-#include "wx/timer.h"
+#include "wx/gtk/private/timer.h"

 
 

-#include "gtk/gtk.h"
+#include <gtk/gtk.h>

 
 

-//-----------------------------------------------------------------------------
-// wxTimer
-//-----------------------------------------------------------------------------
+// ----------------------------------------------------------------------------
+// wxTimerImpl
+// ----------------------------------------------------------------------------

 
 

-IMPLEMENT_ABSTRACT_CLASS(wxTimer,wxObject)
+extern "C" {

 
 

-static gint timeout_callback( gpointer data )
+static gboolean timeout_callback(gpointer data)

 {
 {

-    wxTimer *timer = (wxTimer*)data;
+    wxGTKTimerImpl *timer = (wxGTKTimerImpl*)data;

 
 

-    /* when getting called from GDK's timer handler we
-       are no longer within GDK's grab on the GUI
-       thread so we must lock it here ourselves */
+    const bool keepGoing = !timer->IsOneShot();
+    if ( !keepGoing )
+        timer->Stop();
+
+    // When getting called from GDK's timer handler we
+    // are no longer within GDK's grab on the GUI
+    // thread so we must lock it here ourselves.

     gdk_threads_enter();
 
     timer->Notify();
 
     gdk_threads_enter();
 
     timer->Notify();
 

-    /* release lock again */
+    // Release lock again.

     gdk_threads_leave();
 
     gdk_threads_leave();
 

-    if ( timer->IsOneShot() )
-        return FALSE;
-
-    return TRUE;
+    return keepGoing;

 }
 
 }
 

-wxTimer::wxTimer()
-{
-    m_tag = -1;
-    m_milli = 1000;
-    m_oneShot = FALSE;
-}
+} // extern "C"

 
 

-wxTimer::~wxTimer()
+bool wxGTKTimerImpl::Start(int millisecs, bool oneShot)

 {
 {

-    wxTimer::Stop();
-}
+    if ( !wxTimerImpl::Start(millisecs, oneShot) )
+        return false;

 
 

-bool wxTimer::Start( int millisecs, bool oneShot )
-{
-    (void)wxTimerBase::Start(millisecs, oneShot);
+    wxASSERT_MSG( !m_sourceId, _T("shouldn't be still running") );

 
 

-    m_tag = gtk_timeout_add( m_milli, timeout_callback, this );
+    m_sourceId = g_timeout_add(m_milli, timeout_callback, this);

 
 

-    return TRUE;
+    return true;

 }
 
 }
 

-void wxTimer::Stop()
+void wxGTKTimerImpl::Stop()

 {
 {

-    if (m_tag != -1)
-    {
-        gtk_timeout_remove( m_tag );
-        m_tag = -1;
-    }
+    wxASSERT_MSG( m_sourceId, _T("should be running") );
+
+    g_source_remove(m_sourceId);
+    m_sourceId = 0;

 }
 
 }
 

+#endif // wxUSE_TIMER
+