corrected off by 1 error in cMB2WC() call (thanks valgrind)

[wxWidgets.git] / src / gtk / clipbrd.cpp

diff --git a/src/gtk/clipbrd.cpp b/src/gtk/clipbrd.cpp
index 628a663fbd4a8de9357e351628c793a1ea28ee78..483b6beca4889861019d77c3cc6e1c27cb973eb4 100644 (file)
--- a/src/gtk/clipbrd.cpp
+++ b/src/gtk/clipbrd.cpp
@@ -88,6 +88,17 @@ public:
         ms_clipboard = NULL;
     }
 
         ms_clipboard = NULL;
     }
 

+    // this method should be called if it's possible that no async clipboard
+    // operation is currently in progress (like it can be the case when the
+    // clipboard is cleared but not because we asked about it), it should only
+    // be called if such situation is expected -- otherwise call OnDone() which
+    // would assert in this case
+    static void OnDoneIfInProgress(wxClipboard *clipboard)
+    {
+        if ( ms_clipboard )
+            OnDone(clipboard);
+    }
+

 private:
     static wxClipboard *ms_clipboard;
 
 private:
     static wxClipboard *ms_clipboard;
 


@@ -199,7 +210,12 @@ selection_clear_clip( GtkWidget *WXUNUSED(widget), GdkEventSelection *event )
     if ( !clipboard )
         return TRUE;
 
     if ( !clipboard )
         return TRUE;
 

-    wxON_BLOCK_EXIT1(wxClipboardSync::OnDone, clipboard);
+    // notice the use of OnDoneIfInProgress() here instead of just OnDone():
+    // it's perfectly possible that we're receiving this notification from GTK+
+    // even though we hadn't cleared the clipboard ourselves but because
+    // another application (or even another window in the same program)
+    // acquired it
+    wxON_BLOCK_EXIT1(wxClipboardSync::OnDoneIfInProgress, clipboard);

 
     wxClipboard::Kind kind;
     if (event->selection == GDK_SELECTION_PRIMARY)
 
     wxClipboard::Kind kind;
     if (event->selection == GDK_SELECTION_PRIMARY)


@@ -377,10 +393,8 @@ wxClipboard::~wxClipboard()
 {
     Clear();
 
 {
     Clear();
 

-    if ( m_clipboardWidget )
-        gtk_widget_destroy( m_clipboardWidget );
-    if ( m_targetsWidget )
-        gtk_widget_destroy( m_targetsWidget );
+    gtk_widget_destroy( m_clipboardWidget );
+    gtk_widget_destroy( m_targetsWidget );

 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------


@@ -425,7 +439,7 @@ void wxClipboard::AddSupportedTarget(GdkAtom atom)
 {
     gtk_selection_add_target
     (
 {
     gtk_selection_add_target
     (

-        GTK_WIDGET(m_clipboardWidget),
+        m_clipboardWidget,

         GTKGetClipboardAtom(),
         atom,
         0 // info (same as client data) unused
         GTKGetClipboardAtom(),
         atom,
         0 // info (same as client data) unused