* Name: gsocket.c
* Authors: Guilhem Lavaux,
* Guillermo Rodriguez Garcia <guille@iies.es> (maintainer)
- * Purpose: GSocket main Unix file
+ * Purpose: GSocket main Unix and OS/2 file
+ * Licence: The wxWindows licence
* CVSID: $Id$
* -------------------------------------------------------------------------
*/
#include "wx/setup.h"
#endif
+#if defined(__VISAGECPP__)
+/* Seems to be needed by Visual Age C++, though I don't see how it manages
+ to not break on including a C++ header into a plain C source file */
+#include "wx/defs.h"
+#define BSD_SELECT /* use Berkley Sockets select */
+#endif
+
#if wxUSE_SOCKETS || defined(__GSOCKET_STANDALONE__)
#include <assert.h>
#include <sys/types.h>
+#ifdef __VISAGECPP__
+#include <string.h>
+#include <sys/time.h>
+#include <types.h>
+#include <netinet/in.h>
+#endif
#include <netdb.h>
#include <sys/ioctl.h>
#ifdef __VMS__
#include <socket.h>
-struct sockaddr_un {
+struct sockaddr_un
+{
u_char sun_len; /* sockaddr len including null */
u_char sun_family; /* AF_UNIX */
char sun_path[108]; /* path name (gag) */
#include <sys/un.h>
#endif
+#ifndef __VISAGECPP__
#include <sys/time.h>
#include <netinet/in.h>
#include <arpa/inet.h>
#include <errno.h>
#include <string.h>
#include <unistd.h>
+#else
+#include <nerrno.h>
+# if __IBMCPP__ < 400
+#include <machine/endian.h>
+#include <socket.h>
+#include <ioctl.h>
+#include <select.h>
+#include <unistd.h>
+
+#define EBADF SOCEBADF
+
+# ifdef min
+# undef min
+# endif
+# else
+#include <sys/socket.h>
+#include <sys/ioctl.h>
+#include <sys/select.h>
+
+#define close(a) soclose(a)
+#define select(a,b,c,d,e) bsdselect(a,b,c,d,e)
+int _System bsdselect(int,
+ struct fd_set *,
+ struct fd_set *,
+ struct fd_set *,
+ struct timeval *);
+int _System soclose(int);
+# endif
+#endif
#include <stdio.h>
#include <stdlib.h>
#include <stddef.h>
#define INVALID_SOCKET -1
#endif
+/* UnixWare reportedly needs this for FIONBIO definition */
+#ifdef __UNIXWARE__
+#include <sys/filio.h>
+#endif
+
/*
* INADDR_BROADCAST is identical to INADDR_NONE which is not defined
* on all systems. INADDR_BROADCAST should be fine to indicate an error.
# include "gsocket.h"
#endif /* __GSOCKET_STANDALONE__ */
-/* redefine some GUI-only functions to do nothing in console mode */
-#if defined(wxUSE_GUI) && !wxUSE_GUI
-# define _GSocket_GUI_Init(socket) (1)
-# define _GSocket_GUI_Destroy(socket)
-# define _GSocket_Enable_Events(socket)
-# define _GSocket_Disable_Events(socket)
-# define _GSocket_Install_Callback(socket, event)
-# define _GSocket_Uninstall_Callback(socket, event)
-#endif /* wxUSE_GUI */
-
/* debugging helpers */
#ifdef __GSOCKET_DEBUG__
- #define GSocket_Debug(args) printf args
+# define GSocket_Debug(args) printf args
#else
- #define GSocket_Debug(args)
-#endif // __GSOCKET_DEBUG__
+# define GSocket_Debug(args)
+#endif /* __GSOCKET_DEBUG__ */
+
+/* Table of GUI-related functions. We must call them indirectly because
+ * of wxBase and GUI separation: */
+
+static struct GSocketGUIFunctionsTable *gs_gui_functions;
+
+#define USE_GUI() (gs_gui_functions != NULL)
+
+/* Define macros to simplify indirection: */
+#define _GSocket_GUI_Init() \
+ if (gs_gui_functions) gs_gui_functions->GUI_Init()
+#define _GSocket_GUI_Cleanup() \
+ if (gs_gui_functions) gs_gui_functions->GUI_Cleanup()
+#define _GSocket_GUI_Init_Socket(socket) \
+ (gs_gui_functions ? gs_gui_functions->GUI_Init_Socket(socket) : 1)
+#define _GSocket_GUI_Destroy_Socket(socket) \
+ if (gs_gui_functions) gs_gui_functions->GUI_Destroy_Socket(socket)
+#define _GSocket_Enable_Events(socket) \
+ if (gs_gui_functions) gs_gui_functions->Enable_Events(socket)
+#define _GSocket_Disable_Events(socket) \
+ if (gs_gui_functions) gs_gui_functions->Disable_Events(socket)
+#define _GSocket_Install_Callback(socket, event) \
+ if (gs_gui_functions) gs_gui_functions->Install_Callback(socket, event)
+#define _GSocket_Uninstall_Callback(socket, event) \
+ if (gs_gui_functions) gs_gui_functions->Uninstall_Callback(socket, event)
+
+static struct GSocketBaseFunctionsTable gs_base_functions =
+{
+ _GSocket_Detected_Read,
+ _GSocket_Detected_Write
+};
/* Global initialisers */
-bool GSocket_Init(void)
+void GSocket_SetGUIFunctions(struct GSocketGUIFunctionsTable *guifunc)
{
- return TRUE;
+ gs_gui_functions = guifunc;
+}
+
+int GSocket_Init(void)
+{
+ if (gs_gui_functions)
+ {
+ if ( !gs_gui_functions->GUI_Init() )
+ return 0;
+ }
+ return 1;
}
void GSocket_Cleanup(void)
{
+ if (gs_gui_functions)
+ {
+ gs_gui_functions->GUI_Cleanup();
+ }
}
/* Constructors / Destructors for GSocket */
/* 10 minutes * 60 sec * 1000 millisec */
socket->m_establishing = FALSE;
+ socket->m_functions = &gs_base_functions;
+
/* Per-socket GUI-specific initialization */
- success = _GSocket_GUI_Init(socket);
+ success = _GSocket_GUI_Init_Socket(socket);
if (!success)
{
free(socket);
return socket;
}
+void GSocket_close(GSocket *socket)
+{
+ _GSocket_Disable_Events(socket);
+// gsockosx.c calls CFSocketInvalidate which closes the socket for us
+#if !(defined(__DARWIN__) && (defined(__WXMAC__) || defined(__WXCOCOA__)))
+ close(socket->m_fd);
+#endif
+ socket->m_fd = INVALID_SOCKET;
+}
+
void GSocket_destroy(GSocket *socket)
{
assert(socket != NULL);
GSocket_Shutdown(socket);
/* Per-socket GUI-specific cleanup */
- _GSocket_GUI_Destroy(socket);
+ _GSocket_GUI_Destroy_Socket(socket);
/* Destroy private addresses */
if (socket->m_local)
if (socket->m_fd != INVALID_SOCKET)
{
shutdown(socket->m_fd, 2);
- close(socket->m_fd);
- socket->m_fd = INVALID_SOCKET;
+ GSocket_close(socket);
}
/* Disable GUI callbacks */
socket->m_cbacks[evt] = NULL;
socket->m_detected = GSOCK_LOST_FLAG;
- _GSocket_Disable_Events(socket);
}
/* Address handling */
*/
GSocketError GSocket_SetServer(GSocket *sck)
{
- int type;
int arg = 1;
assert(sck != NULL);
sck->m_error = GSOCK_IOERR;
return GSOCK_IOERR;
}
-
+#if defined(__EMX__) || defined(__VISAGECPP__)
+ ioctl(sck->m_fd, FIONBIO, (char*)&arg, sizeof(arg));
+#else
ioctl(sck->m_fd, FIONBIO, &arg);
+#endif
_GSocket_Enable_Events(sck);
+ /* allow a socket to re-bind if the socket is in the TIME_WAIT
+ state after being previously closed.
+ */
+ setsockopt(sck->m_fd, SOL_SOCKET, SO_REUSEADDR, (const char*)&arg, sizeof(u_long));
+
/* Bind to the local address,
* retrieve the actual address bound,
* and listen up to 5 connections.
(SOCKLEN_T *) &sck->m_local->m_len) != 0) ||
(listen(sck->m_fd, 5) != 0))
{
- close(sck->m_fd);
- sck->m_fd = INVALID_SOCKET;
+ GSocket_close(sck);
sck->m_error = GSOCK_IOERR;
return GSOCK_IOERR;
}
socket->m_error = err;
return NULL;
}
-
+#if defined(__EMX__) || defined(__VISAGECPP__)
+ ioctl(connection->m_fd, FIONBIO, (char*)&arg, sizeof(arg));
+#else
ioctl(connection->m_fd, FIONBIO, &arg);
+#endif
_GSocket_Enable_Events(connection);
return connection;
sck->m_error = GSOCK_IOERR;
return GSOCK_IOERR;
}
-
+#if defined(__EMX__) || defined(__VISAGECPP__)
+ ioctl(sck->m_fd, FIONBIO, (char*)&arg, sizeof(arg));
+#else
ioctl(sck->m_fd, FIONBIO, &arg);
+#endif
_GSocket_Enable_Events(sck);
/* Connect it to the peer address, with a timeout (see below) */
{
if (_GSocket_Output_Timeout(sck) == GSOCK_TIMEDOUT)
{
- close(sck->m_fd);
- sck->m_fd = INVALID_SOCKET;
+ GSocket_close(sck);
/* sck->m_error is set in _GSocket_Output_Timeout */
return GSOCK_TIMEDOUT;
}
/* If connect failed with an error other than EINPROGRESS,
* then the call to GSocket_Connect has failed.
*/
- close(sck->m_fd);
- sck->m_fd = INVALID_SOCKET;
+ GSocket_close(sck);
sck->m_error = GSOCK_IOERR;
return GSOCK_IOERR;
}
sck->m_error = GSOCK_IOERR;
return GSOCK_IOERR;
}
-
+#if defined(__EMX__) || defined(__VISAGECPP__)
+ ioctl(sck->m_fd, FIONBIO, (char*)&arg, sizeof(arg));
+#else
ioctl(sck->m_fd, FIONBIO, &arg);
+#endif
_GSocket_Enable_Events(sck);
/* Bind to the local address,
sck->m_local->m_addr,
(SOCKLEN_T *) &sck->m_local->m_len) != 0))
{
- close(sck->m_fd);
- sck->m_fd = INVALID_SOCKET;
+ GSocket_close(sck);
sck->m_error = GSOCK_IOERR;
return GSOCK_IOERR;
}
assert(socket != NULL);
+ /* When using CFSocket we MUST NOT reenable events until we finish reading */
+#ifndef __DARWIN__
/* Reenable INPUT events */
_GSocket_Enable(socket, GSOCK_INPUT);
+#endif
if (socket->m_fd == INVALID_SOCKET || socket->m_server)
{
socket->m_error = GSOCK_IOERR;
}
+#ifdef __DARWIN__
+ /* Reenable INPUT events */
+ _GSocket_Enable(socket, GSOCK_INPUT);
+#endif
+
return ret;
}
*/
GSocketEventFlags GSocket_Select(GSocket *socket, GSocketEventFlags flags)
{
-#if defined(wxUSE_GUI) && !wxUSE_GUI
+ if (!USE_GUI())
+ {
- GSocketEventFlags result = 0;
- fd_set readfds;
- fd_set writefds;
- fd_set exceptfds;
- struct timeval tv;
+ GSocketEventFlags result = 0;
+ fd_set readfds;
+ fd_set writefds;
+ fd_set exceptfds;
+ struct timeval tv;
- /* Do not use a static struct, Linux can garble it */
- tv.tv_sec = 0;
- tv.tv_usec = 0;
+ /* Do not use a static struct, Linux can garble it */
+ tv.tv_sec = socket->m_timeout / 1000;
+ tv.tv_usec = (socket->m_timeout % 1000) / 1000;
- assert(socket != NULL);
+ assert(socket != NULL);
- FD_ZERO(&readfds);
- FD_ZERO(&writefds);
- FD_ZERO(&exceptfds);
- FD_SET(socket->m_fd, &readfds);
- FD_SET(socket->m_fd, &writefds);
- FD_SET(socket->m_fd, &exceptfds);
+ FD_ZERO(&readfds);
+ FD_ZERO(&writefds);
+ FD_ZERO(&exceptfds);
+ FD_SET(socket->m_fd, &readfds);
+ if (flags & GSOCK_OUTPUT_FLAG)
+ FD_SET(socket->m_fd, &writefds);
+ FD_SET(socket->m_fd, &exceptfds);
- /* Check known state first */
- result |= (GSOCK_CONNECTION_FLAG & socket->m_detected & flags);
- result |= (GSOCK_LOST_FLAG & socket->m_detected & flags);
+ /* Check 'sticky' CONNECTION flag first */
+ result |= (GSOCK_CONNECTION_FLAG & socket->m_detected);
- /* Try select now */
- if (select(socket->m_fd + 1, &readfds, &writefds, &exceptfds, &tv) <= 0)
- return result;
+ /* If we have already detected a LOST event, then don't try
+ * to do any further processing.
+ */
+ if ((socket->m_detected & GSOCK_LOST_FLAG) != 0)
+ {
+ socket->m_establishing = FALSE;
- /* Check for readability */
- if (FD_ISSET(socket->m_fd, &readfds))
- {
- char c;
+ return (GSOCK_LOST_FLAG & flags);
+ }
- if (recv(socket->m_fd, &c, 1, MSG_PEEK) > 0)
+ /* Try select now */
+ if (select(socket->m_fd + 1, &readfds, &writefds, &exceptfds, &tv) <= 0)
{
- result |= (GSOCK_INPUT_FLAG & flags);
+ /* What to do here? */
+ return (result & flags);
}
- else
+
+ /* Check for readability */
+ if (FD_ISSET(socket->m_fd, &readfds))
{
- if (socket->m_server && socket->m_stream)
+ char c;
+
+ if (recv(socket->m_fd, &c, 1, MSG_PEEK) > 0)
{
- result |= (GSOCK_CONNECTION_FLAG & flags);
- socket->m_detected |= GSOCK_CONNECTION_FLAG;
+ result |= GSOCK_INPUT_FLAG;
}
else
{
- result |= (GSOCK_LOST_FLAG & flags);
- socket->m_detected = GSOCK_LOST_FLAG;
+ if (socket->m_server && socket->m_stream)
+ {
+ result |= GSOCK_CONNECTION_FLAG;
+ socket->m_detected |= GSOCK_CONNECTION_FLAG;
+ }
+ else
+ {
+ socket->m_detected = GSOCK_LOST_FLAG;
+ socket->m_establishing = FALSE;
+
+ /* LOST event: Abort any further processing */
+ return (GSOCK_LOST_FLAG & flags);
+ }
}
}
- }
- /* Check for writability */
- if (FD_ISSET(socket->m_fd, &writefds))
- {
- if (socket->m_establishing && !socket->m_server)
+ /* Check for writability */
+ if (FD_ISSET(socket->m_fd, &writefds))
{
- int error;
- SOCKLEN_T len = sizeof(error);
+ if (socket->m_establishing && !socket->m_server)
+ {
+ int error;
+ SOCKLEN_T len = sizeof(error);
- socket->m_establishing = FALSE;
+ socket->m_establishing = FALSE;
- getsockopt(socket->m_fd, SOL_SOCKET, SO_ERROR, (void*)&error, &len);
+ getsockopt(socket->m_fd, SOL_SOCKET, SO_ERROR, (void*)&error, &len);
- if (error)
- {
- result |= (GSOCK_LOST_FLAG & flags);
- socket->m_detected = GSOCK_LOST_FLAG;
+ if (error)
+ {
+ socket->m_detected = GSOCK_LOST_FLAG;
+
+ /* LOST event: Abort any further processing */
+ return (GSOCK_LOST_FLAG & flags);
+ }
+ else
+ {
+ result |= GSOCK_CONNECTION_FLAG;
+ socket->m_detected |= GSOCK_CONNECTION_FLAG;
+ }
}
else
{
- result |= (GSOCK_CONNECTION_FLAG & flags);
- socket->m_detected |= GSOCK_CONNECTION_FLAG;
+ result |= GSOCK_OUTPUT_FLAG;
}
}
- else
+
+ /* Check for exceptions and errors (is this useful in Unices?) */
+ if (FD_ISSET(socket->m_fd, &exceptfds))
{
- result |= (GSOCK_OUTPUT_FLAG & flags);
- }
- }
+ socket->m_establishing = FALSE;
+ socket->m_detected = GSOCK_LOST_FLAG;
- /* Check for exceptions and errors (is this useful in Unices?) */
- if (FD_ISSET(socket->m_fd, &exceptfds))
- {
- result |= (GSOCK_LOST_FLAG & flags);
- socket->m_establishing = FALSE;
- socket->m_detected = GSOCK_LOST_FLAG;
- }
+ /* LOST event: Abort any further processing */
+ return (GSOCK_LOST_FLAG & flags);
+ }
- return result;
+ return (result & flags);
-#else
+ }
+ else
+ {
- assert(socket != NULL);
- return flags & socket->m_detected;
+ assert(socket != NULL);
+ return flags & socket->m_detected;
-#endif /* !wxUSE_GUI */
+ }
}
/* Flags */
* Sets the socket to non-blocking mode. All IO calls will return
* immediately.
*/
-void GSocket_SetNonBlocking(GSocket *socket, bool non_block)
+void GSocket_SetNonBlocking(GSocket *socket, int non_block)
{
assert(socket != NULL);
+ GSocket_Debug( ("GSocket_SetNonBlocking: %d\n", (int)non_block) );
+
socket->m_non_blocking = non_block;
}
if (ret == -1)
{
GSocket_Debug(( "GSocket_Input_Timeout, select returned -1\n" ));
- if (errno == EBADF) GSocket_Debug(( "Invalid file descriptor\n" ));
- if (errno == EINTR) GSocket_Debug(( "A non blocked signal was caught\n" ));
- if (errno == EINVAL) GSocket_Debug(( "The highest number descriptor is negative\n" ));
- if (errno == ENOMEM) GSocket_Debug(( "Not enough memory\n" ));
+ if (errno == EBADF) { GSocket_Debug(( "Invalid file descriptor\n" )); }
+ if (errno == EINTR) { GSocket_Debug(( "A non blocked signal was caught\n" )); }
+ if (errno == EINVAL) { GSocket_Debug(( "The highest number descriptor is negative\n" )); }
+ if (errno == ENOMEM) { GSocket_Debug(( "Not enough memory\n" )); }
socket->m_error = GSOCK_TIMEDOUT;
return GSOCK_TIMEDOUT;
}
tv.tv_sec = (socket->m_timeout / 1000);
tv.tv_usec = (socket->m_timeout % 1000) * 1000;
+ GSocket_Debug( ("m_non_blocking has: %d\n", (int)socket->m_non_blocking) );
+
if (!socket->m_non_blocking)
{
FD_ZERO(&writefds);
if (ret == -1)
{
GSocket_Debug(( "GSocket_Output_Timeout, select returned -1\n" ));
- if (errno == EBADF) GSocket_Debug(( "Invalid file descriptor\n" ));
- if (errno == EINTR) GSocket_Debug(( "A non blocked signal was caught\n" ));
- if (errno == EINVAL) GSocket_Debug(( "The highest number descriptor is negative\n" ));
- if (errno == ENOMEM) GSocket_Debug(( "Not enough memory\n" ));
+ if (errno == EBADF) { GSocket_Debug(( "Invalid file descriptor\n" )); }
+ if (errno == EINTR) { GSocket_Debug(( "A non blocked signal was caught\n" )); }
+ if (errno == EINVAL) { GSocket_Debug(( "The highest number descriptor is negative\n" )); }
+ if (errno == ENOMEM) { GSocket_Debug(( "Not enough memory\n" )); }
socket->m_error = GSOCK_TIMEDOUT;
return GSOCK_TIMEDOUT;
}
- if ( ! FD_ISSET(socket->m_fd, &writefds) )
- GSocket_Debug(( "GSocket_Output_Timeout is buggy!\n" ));
- else
- GSocket_Debug(( "GSocket_Output_Timeout seems correct\n" ));
+ if ( ! FD_ISSET(socket->m_fd, &writefds) ) {
+ GSocket_Debug(( "GSocket_Output_Timeout is buggy!\n" ));
+ }
+ else {
+ GSocket_Debug(( "GSocket_Output_Timeout seems correct\n" ));
+ }
}
else
{
{
int ret;
+#ifndef __VISAGECPP__
MASK_SIGNAL();
ret = send(socket->m_fd, buffer, size, 0);
UNMASK_SIGNAL();
+#else
+ ret = send(socket->m_fd, (char *)buffer, size, 0);
+#endif
return ret;
}
return -1;
}
+#ifndef __VISAGECPP__
MASK_SIGNAL();
ret = sendto(socket->m_fd, buffer, size, 0, addr, len);
UNMASK_SIGNAL();
+#else
+ ret = sendto(socket->m_fd, (char *)buffer, size, 0, addr, len);
+#endif
/* Frees memory allocated from _GAddress_translate_to */
free(addr);
{
char c;
+ /* If we have already detected a LOST event, then don't try
+ * to do any further processing.
+ */
+ if ((socket->m_detected & GSOCK_LOST_FLAG) != 0)
+ {
+ socket->m_establishing = FALSE;
+
+ CALL_CALLBACK(socket, GSOCK_LOST);
+ GSocket_Shutdown(socket);
+ return;
+ }
+
if (recv(socket->m_fd, &c, 1, MSG_PEEK) > 0)
{
CALL_CALLBACK(socket, GSOCK_INPUT);
else
{
CALL_CALLBACK(socket, GSOCK_LOST);
+ GSocket_Shutdown(socket);
}
}
}
void _GSocket_Detected_Write(GSocket *socket)
{
+ /* If we have already detected a LOST event, then don't try
+ * to do any further processing.
+ */
+ if ((socket->m_detected & GSOCK_LOST_FLAG) != 0)
+ {
+ socket->m_establishing = FALSE;
+
+ CALL_CALLBACK(socket, GSOCK_LOST);
+ GSocket_Shutdown(socket);
+ return;
+ }
+
if (socket->m_establishing && !socket->m_server)
{
int error;
if (error)
{
CALL_CALLBACK(socket, GSOCK_LOST);
+ GSocket_Shutdown(socket);
}
else
{
* -------------------------------------------------------------------------
*/
-/* CHECK_ADDRESS verifies that the current family is either GSOCK_NOFAMILY
- * or GSOCK_*family*, and if it is GSOCK_NOFAMILY, it initalizes address
- * to be a GSOCK_*family*. In other cases, it returns GSOCK_INVADDR.
+/* CHECK_ADDRESS verifies that the current address family is either
+ * GSOCK_NOFAMILY or GSOCK_*family*, and if it is GSOCK_NOFAMILY, it
+ * initalizes it to be a GSOCK_*family*. In other cases, it returns
+ * an appropiate error code.
+ *
+ * CHECK_ADDRESS_RETVAL does the same but returning 'retval' on error.
*/
-#define CHECK_ADDRESS(address, family, retval) \
+#define CHECK_ADDRESS(address, family) \
{ \
if (address->m_family == GSOCK_NOFAMILY) \
if (_GAddress_Init_##family(address) != GSOCK_NOERROR) \
return address->m_error; \
if (address->m_family != GSOCK_##family) \
+ { \
+ address->m_error = GSOCK_INVADDR; \
+ return GSOCK_INVADDR; \
+ } \
+}
+
+#define CHECK_ADDRESS_RETVAL(address, family, retval) \
+{ \
+ if (address->m_family == GSOCK_NOFAMILY) \
+ if (_GAddress_Init_##family(address) != GSOCK_NOERROR) \
+ return retval; \
+ if (address->m_family != GSOCK_##family) \
{ \
address->m_error = GSOCK_INVADDR; \
return retval; \
} \
}
+
GAddress *GAddress_new(void)
{
GAddress *address;
memcpy(addr2, address, sizeof(GAddress));
- if (address->m_addr)
+ if (address->m_addr && address->m_len > 0)
{
addr2->m_addr = (struct sockaddr *)malloc(addr2->m_len);
if (addr2->m_addr == NULL)
*len = address->m_len;
*addr = (struct sockaddr *)malloc(address->m_len);
- if (*addr == NULL) {
+ if (*addr == NULL)
+ {
address->m_error = GSOCK_MEMERR;
return GSOCK_MEMERR;
}
assert(address != NULL);
- CHECK_ADDRESS(address, INET, GSOCK_INVADDR);
+ CHECK_ADDRESS(address, INET);
addr = &(((struct sockaddr_in *)address->m_addr)->sin_addr);
{
#else
/* Use gethostbyname by default */
- if (1)
+ int val = 1; //VA doesn't like constants in conditional expressions at all
+ if (val)
{
#endif
struct in_addr *array_addr;
assert(address != NULL);
- CHECK_ADDRESS(address, INET, GSOCK_INVADDR);
+ CHECK_ADDRESS(address, INET);
addr = &(((struct sockaddr_in *)address->m_addr)->sin_addr);
addr->s_addr = hostaddr;
struct sockaddr_in *addr;
assert(address != NULL);
- CHECK_ADDRESS(address, INET, GSOCK_INVADDR);
+ CHECK_ADDRESS(address, INET);
if (!port)
{
se = getservbyname(port, protocol);
if (!se)
{
- if (isdigit(port[0]))
+ /* the cast to int suppresses compiler warnings about subscript having the
+ type char */
+ if (isdigit((int)port[0]))
{
int port_int;
struct sockaddr_in *addr;
assert(address != NULL);
- CHECK_ADDRESS(address, INET, GSOCK_INVADDR);
+ CHECK_ADDRESS(address, INET);
addr = (struct sockaddr_in *)address->m_addr;
addr->sin_port = htons(port);
struct sockaddr_in *addr;
assert(address != NULL);
- CHECK_ADDRESS(address, INET, GSOCK_INVADDR);
+ CHECK_ADDRESS(address, INET);
addr = (struct sockaddr_in *)address->m_addr;
addr_buf = (char *)&(addr->sin_addr);
struct sockaddr_in *addr;
assert(address != NULL);
- CHECK_ADDRESS(address, INET, 0);
+ CHECK_ADDRESS_RETVAL(address, INET, 0);
addr = (struct sockaddr_in *)address->m_addr;
struct sockaddr_in *addr;
assert(address != NULL);
- CHECK_ADDRESS(address, INET, 0);
+ CHECK_ADDRESS_RETVAL(address, INET, 0);
addr = (struct sockaddr_in *)address->m_addr;
return ntohs(addr->sin_port);
* -------------------------------------------------------------------------
*/
+#ifndef __VISAGECPP__
GSocketError _GAddress_Init_UNIX(GAddress *address)
{
address->m_len = sizeof(struct sockaddr_un);
((struct sockaddr_un *)address->m_addr)->sun_family = AF_UNIX;
((struct sockaddr_un *)address->m_addr)->sun_path[0] = 0;
- return TRUE;
+ return GSOCK_NOERROR;
}
+#define UNIX_SOCK_PATHLEN (sizeof(addr->sun_path)/sizeof(addr->sun_path[0]))
+
GSocketError GAddress_UNIX_SetPath(GAddress *address, const char *path)
{
struct sockaddr_un *addr;
assert(address != NULL);
- CHECK_ADDRESS(address, UNIX, GSOCK_INVADDR);
+ CHECK_ADDRESS(address, UNIX);
addr = ((struct sockaddr_un *)address->m_addr);
- memcpy(addr->sun_path, path, strlen(path));
+ strncpy(addr->sun_path, path, UNIX_SOCK_PATHLEN);
+ addr->sun_path[UNIX_SOCK_PATHLEN - 1] = '\0';
return GSOCK_NOERROR;
}
struct sockaddr_un *addr;
assert(address != NULL);
- CHECK_ADDRESS(address, UNIX, GSOCK_INVADDR);
+ CHECK_ADDRESS(address, UNIX);
addr = (struct sockaddr_un *)address->m_addr;
return GSOCK_NOERROR;
}
-
+#endif /* !defined(__VISAGECPP__) */
#endif /* wxUSE_SOCKETS || defined(__GSOCKET_STANDALONE__) */
projects / wxWidgets.git / blobdiff