]> git.saurik.com Git - wxWidgets.git/blobdiff - src/msw/ole/dataobj.cpp
fixed wxComboBox sizing problem again
[wxWidgets.git] / src / msw / ole / dataobj.cpp
index f1eab4707cf21e5b143d7f6fe89afa2dabbdbbab..9af22753cf44c4afacf343082e7b16fe3e9c0bba 100644 (file)
 // ----------------------------------------------------------------------------
 
 #ifdef __GNUG__
 // ----------------------------------------------------------------------------
 
 #ifdef __GNUG__
-  #pragma implementation "dataobj.h"
+    #pragma implementation "dataobj.h"
 #endif
 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 #if defined(__BORLANDC__)
 #endif
 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 #if defined(__BORLANDC__)
-  #pragma hdrstop
+    #pragma hdrstop
 #endif
 #endif
+
+#if defined(__WIN32__) && !defined(__GNUWIN32_OLD__)
+
 #ifndef WX_PRECOMP
 #ifndef WX_PRECOMP
-#include "wx/intl.h"
+    #include "wx/intl.h"
+    #include "wx/log.h"
 #endif
 #endif
-#include "wx/defs.h"
 
 
-#if defined(__WIN32__) && !defined(__GNUWIN32__) || defined(wxUSE_NORLANDER_HEADERS)
-
-#include "wx/log.h"
 #include "wx/dataobj.h"
 
 #include "wx/dataobj.h"
 
-#include <windows.h>
-#ifdef wxUSE_NORLANDER_HEADERS
+#include "wx/msw/private.h"         // includes <windows.h>
+
+#if wxUSE_NORLANDER_HEADERS
   #include <ole2.h>
 #endif
 #include <oleauto.h>
 
   #include <ole2.h>
 #endif
 #include <oleauto.h>
 
-#ifndef __WIN32__  
+#ifndef __WIN32__
   #include <ole2.h>
   #include <olestd.h>
 #endif
 
   #include <ole2.h>
   #include <olestd.h>
 #endif
 
-#include  "wx/msw/ole/oleutils.h"
+#include <shlobj.h>
+
+#include "wx/msw/ole/oleutils.h"
+
+#include "wx/msw/dib.h"
 
 // ----------------------------------------------------------------------------
 // functions
 // ----------------------------------------------------------------------------
 
 #ifdef __WXDEBUG__
 
 // ----------------------------------------------------------------------------
 // functions
 // ----------------------------------------------------------------------------
 
 #ifdef __WXDEBUG__
-    static const char *GetTymedName(DWORD tymed);
-#endif // Debug
+    static const wxChar *GetTymedName(DWORD tymed);
+#else // !Debug
+    #define GetTymedName(tymed) ""
+#endif // Debug/!Debug
 
 // ----------------------------------------------------------------------------
 // wxIEnumFORMATETC interface implementation
 
 // ----------------------------------------------------------------------------
 // wxIEnumFORMATETC interface implementation
@@ -66,7 +73,7 @@ class wxIEnumFORMATETC : public IEnumFORMATETC
 {
 public:
     wxIEnumFORMATETC(const wxDataFormat* formats, ULONG nCount);
 {
 public:
     wxIEnumFORMATETC(const wxDataFormat* formats, ULONG nCount);
-    ~wxIEnumFORMATETC() { delete [] m_formats; }
+    virtual ~wxIEnumFORMATETC() { delete [] m_formats; }
 
     DECLARE_IUNKNOWN_METHODS;
 
 
     DECLARE_IUNKNOWN_METHODS;
 
@@ -90,6 +97,12 @@ class wxIDataObject : public IDataObject
 {
 public:
     wxIDataObject(wxDataObject *pDataObject);
 {
 public:
     wxIDataObject(wxDataObject *pDataObject);
+    virtual ~wxIDataObject();
+
+    // normally, wxDataObject controls our lifetime (i.e. we're deleted when it
+    // is), but in some cases, the situation is inversed, that is we delete it
+    // when this object is deleted - setting this flag enables such logic
+    void SetDeleteFlag() { m_mustDelete = TRUE; }
 
     DECLARE_IUNKNOWN_METHODS;
 
 
     DECLARE_IUNKNOWN_METHODS;
 
@@ -106,6 +119,8 @@ public:
 
 private:
     wxDataObject *m_pDataObject;      // pointer to C++ class we belong to
 
 private:
     wxDataObject *m_pDataObject;      // pointer to C++ class we belong to
+
+    bool m_mustDelete;
 };
 
 // ============================================================================
 };
 
 // ============================================================================
@@ -118,7 +133,7 @@ private:
 
 void wxDataFormat::SetId(const wxChar *format)
 {
 
 void wxDataFormat::SetId(const wxChar *format)
 {
-    m_format = ::RegisterClipboardFormat(format);
+    m_format = (wxDataFormat::NativeFormat)::RegisterClipboardFormat(format);
     if ( !m_format )
     {
         wxLogError(_("Couldn't register clipboard format '%s'."), format);
     if ( !m_format )
     {
         wxLogError(_("Couldn't register clipboard format '%s'."), format);
@@ -169,7 +184,7 @@ wxIEnumFORMATETC::wxIEnumFORMATETC(const wxDataFormat *formats, ULONG nCount)
 
 STDMETHODIMP wxIEnumFORMATETC::Next(ULONG      celt,
                                     FORMATETC *rgelt,
 
 STDMETHODIMP wxIEnumFORMATETC::Next(ULONG      celt,
                                     FORMATETC *rgelt,
-                                    ULONG     *pceltFetched)
+                                    ULONG     *WXUNUSED(pceltFetched))
 {
     wxLogTrace(wxTRACE_OleCalls, wxT("wxIEnumFORMATETC::Next"));
 
 {
     wxLogTrace(wxTRACE_OleCalls, wxT("wxIEnumFORMATETC::Next"));
 
@@ -251,6 +266,15 @@ wxIDataObject::wxIDataObject(wxDataObject *pDataObject)
 {
     m_cRef = 0;
     m_pDataObject = pDataObject;
 {
     m_cRef = 0;
     m_pDataObject = pDataObject;
+    m_mustDelete = FALSE;
+}
+
+wxIDataObject::~wxIDataObject()
+{
+    if ( m_mustDelete )
+    {
+        delete m_pDataObject;
+    }
 }
 
 // get data functions
 }
 
 // get data functions
@@ -273,7 +297,17 @@ STDMETHODIMP wxIDataObject::GetData(FORMATETC *pformatetcIn, STGMEDIUM *pmedium)
             pmedium->tymed = TYMED_GDI;
             break;
 
             pmedium->tymed = TYMED_GDI;
             break;
 
+        case wxDF_ENHMETAFILE:
+            pmedium->tymed = TYMED_ENHMF;
+            break;
+
         case wxDF_METAFILE:
         case wxDF_METAFILE:
+            pmedium->hGlobal = GlobalAlloc(GMEM_MOVEABLE | GMEM_SHARE,
+                                           sizeof(METAFILEPICT));
+            if ( !pmedium->hGlobal ) {
+                wxLogLastError(wxT("GlobalAlloc"));
+                return E_OUTOFMEMORY;
+            }
             pmedium->tymed = TYMED_MFPICT;
             break;
 
             pmedium->tymed = TYMED_MFPICT;
             break;
 
@@ -287,9 +321,15 @@ STDMETHODIMP wxIDataObject::GetData(FORMATETC *pformatetcIn, STGMEDIUM *pmedium)
                 return DV_E_FORMATETC;
             }
 
                 return DV_E_FORMATETC;
             }
 
+            if ( !format.IsStandard() ) {
+                // for custom formats, put the size with the data - alloc the
+                // space for it
+                size += sizeof(size_t);
+            }
+
             HGLOBAL hGlobal = GlobalAlloc(GMEM_MOVEABLE | GMEM_SHARE, size);
             if ( hGlobal == NULL ) {
             HGLOBAL hGlobal = GlobalAlloc(GMEM_MOVEABLE | GMEM_SHARE, size);
             if ( hGlobal == NULL ) {
-                wxLogLastError("GlobalAlloc");
+                wxLogLastError(wxT("GlobalAlloc"));
                 return E_OUTOFMEMORY;
             }
 
                 return E_OUTOFMEMORY;
             }
 
@@ -304,7 +344,7 @@ STDMETHODIMP wxIDataObject::GetData(FORMATETC *pformatetcIn, STGMEDIUM *pmedium)
     hr = GetDataHere(pformatetcIn, pmedium);
     if ( FAILED(hr) ) {
         // free resources we allocated
     hr = GetDataHere(pformatetcIn, pmedium);
     if ( FAILED(hr) ) {
         // free resources we allocated
-        if ( pmedium->tymed == TYMED_HGLOBAL ) {
+        if ( pmedium->tymed & (TYMED_HGLOBAL | TYMED_MFPICT) ) {
             GlobalFree(pmedium->hGlobal);
         }
 
             GlobalFree(pmedium->hGlobal);
         }
 
@@ -323,28 +363,41 @@ STDMETHODIMP wxIDataObject::GetDataHere(FORMATETC *pformatetc,
     switch ( pmedium->tymed )
     {
         case TYMED_GDI:
     switch ( pmedium->tymed )
     {
         case TYMED_GDI:
-            m_pDataObject->GetDataHere(wxDF_BITMAP, &pmedium->hBitmap);
+            if ( !m_pDataObject->GetDataHere(wxDF_BITMAP, &pmedium->hBitmap) )
+                return E_UNEXPECTED;
             break;
 
             break;
 
-        case TYMED_MFPICT:
-            // this should be copied on bitmaps - but I don't have time for
-            // this now
-            wxFAIL_MSG(wxT("TODO - no support for metafiles in wxDataObject"));
+        case TYMED_ENHMF:
+            if ( !m_pDataObject->GetDataHere(wxDF_ENHMETAFILE,
+                                             &pmedium->hEnhMetaFile) )
+                return E_UNEXPECTED;
             break;
 
             break;
 
+        case TYMED_MFPICT:
+            // fall through - we pass METAFILEPICT through HGLOBAL
+
         case TYMED_HGLOBAL:
             {
                 // copy data
         case TYMED_HGLOBAL:
             {
                 // copy data
-                void *pBuf = GlobalLock(pmedium->hGlobal);
+                HGLOBAL hGlobal = pmedium->hGlobal;
+                void *pBuf = GlobalLock(hGlobal);
                 if ( pBuf == NULL ) {
                     wxLogLastError(wxT("GlobalLock"));
                     return E_OUTOFMEMORY;
                 }
 
                 if ( pBuf == NULL ) {
                     wxLogLastError(wxT("GlobalLock"));
                     return E_OUTOFMEMORY;
                 }
 
-                wxDataFormat format = (wxDataFormatId)pformatetc->cfFormat;
-                m_pDataObject->GetDataHere(format, pBuf);
+                if ( !wxDataFormat(pformatetc->cfFormat).IsStandard() ) {
+                    // for custom formats, put the size with the data
+                    size_t *p = (size_t *)pBuf;
+                    *p++ = GlobalSize(hGlobal);
+                    pBuf = p;
+                }
 
 
-                GlobalUnlock(pmedium->hGlobal);
+                wxDataFormat format = pformatetc->cfFormat;
+                if ( !m_pDataObject->GetDataHere(format, pBuf) )
+                    return E_UNEXPECTED;
+
+                GlobalUnlock(hGlobal);
             }
             break;
 
             }
             break;
 
@@ -355,74 +408,198 @@ STDMETHODIMP wxIDataObject::GetDataHere(FORMATETC *pformatetc,
     return S_OK;
 }
 
     return S_OK;
 }
 
-// set data functions (not implemented)
+// set data functions
 STDMETHODIMP wxIDataObject::SetData(FORMATETC *pformatetc,
                                     STGMEDIUM *pmedium,
                                     BOOL       fRelease)
 {
 STDMETHODIMP wxIDataObject::SetData(FORMATETC *pformatetc,
                                     STGMEDIUM *pmedium,
                                     BOOL       fRelease)
 {
-  wxLogTrace(wxTRACE_OleCalls, wxT("wxIDataObject::SetData"));
+    wxLogTrace(wxTRACE_OleCalls, wxT("wxIDataObject::SetData"));
+
+    switch ( pmedium->tymed )
+    {
+        case TYMED_GDI:
+            m_pDataObject->SetData(wxDF_BITMAP, 0, &pmedium->hBitmap);
+            break;
 
 
-  return E_NOTIMPL;
+        case TYMED_ENHMF:
+            m_pDataObject->SetData(wxDF_ENHMETAFILE, 0, &pmedium->hEnhMetaFile);
+            break;
+
+        case TYMED_MFPICT:
+            // fall through - we pass METAFILEPICT through HGLOBAL
+        case TYMED_HGLOBAL:
+            {
+                wxDataFormat format = pformatetc->cfFormat;
+
+                // this is quite weird, but for file drag and drop, explorer
+                // calls our SetData() with the formats we do *not* support!
+                //
+                // as we can't fix this bug in explorer (it's a bug because it
+                // should only use formats returned by EnumFormatEtc), do the
+                // check here
+                if ( !m_pDataObject->IsSupportedFormat(format) ) {
+                    // go away!
+                    return DV_E_FORMATETC;
+                }
+
+                // copy data
+                void *pBuf = GlobalLock(pmedium->hGlobal);
+                if ( pBuf == NULL ) {
+                    wxLogLastError(wxT("GlobalLock"));
+
+                    return E_OUTOFMEMORY;
+                }
+
+                // we've got a problem with SetData() here because the base
+                // class version requires the size parameter which we don't
+                // have anywhere in OLE data transfer - so we need to
+                // synthetise it for known formats and we suppose that all data
+                // in custom formats starts with a DWORD containing the size
+                size_t size;
+                switch ( format )
+                {
+                    case CF_TEXT:
+                    case CF_OEMTEXT:
+                        size = strlen((const char *)pBuf);
+                        break;
+#if !defined(__WATCOMC__) && ! (defined(__BORLANDC__) && (__BORLANDC__ < 0x500))
+                    case CF_UNICODETEXT:
+#if (defined(__BORLANDC__) && (__BORLANDC__ > 0x530))
+                        size = std::wcslen((const wchar_t *)pBuf);
+#else
+                        size = ::wcslen((const wchar_t *)pBuf);
+#endif
+                        break;
+#endif
+                    case CF_BITMAP:
+                    case CF_HDROP:
+                        // these formats don't use size at all, anyhow (but
+                        // pass data by handle, which is always a single DWORD)
+                        size = 0;
+                        break;
+
+                    case CF_DIB:
+                        // the handler will calculate size itself (it's too
+                        // complicated to do it here)
+                        size = 0;
+                        break;
+
+                    case CF_METAFILEPICT:
+                        size = sizeof(METAFILEPICT);
+                        break;
+
+                    default:
+                        {
+                            // we suppose that the size precedes the data
+                            size_t *p = (size_t *)pBuf;
+                            size = *p++;
+                            pBuf = p;
+                            if (! format.IsStandard() ) {
+                                // see GetData for coresponding increment
+                                size -= sizeof(size_t);
+                            }
+                        }
+                }
+
+                bool ok = m_pDataObject->SetData(format, size, pBuf);
+
+                GlobalUnlock(pmedium->hGlobal);
+
+                if ( !ok ) {
+                    return E_UNEXPECTED;
+                }
+            }
+            break;
+
+        default:
+            return DV_E_TYMED;
+    }
+
+    if ( fRelease ) {
+        // we own the medium, so we must release it - but do *not* free any
+        // data we pass by handle because we have copied it elsewhere
+        switch ( pmedium->tymed )
+        {
+            case TYMED_GDI:
+                pmedium->hBitmap = 0;
+                break;
+
+            case TYMED_MFPICT:
+                pmedium->hMetaFilePict = 0;
+                break;
+
+            case TYMED_ENHMF:
+                pmedium->hEnhMetaFile = 0;
+                break;
+        }
+
+        ReleaseStgMedium(pmedium);
+    }
+
+    return S_OK;
 }
 
 // information functions
 STDMETHODIMP wxIDataObject::QueryGetData(FORMATETC *pformatetc)
 {
 }
 
 // information functions
 STDMETHODIMP wxIDataObject::QueryGetData(FORMATETC *pformatetc)
 {
-  // do we accept data in this format?
-  if ( pformatetc == NULL ) {
-    wxLogTrace(wxTRACE_OleCalls, wxT("wxIDataObject::QueryGetData: invalid ptr."));
-
-    return E_INVALIDARG;
-  }
-
-  // the only one allowed by current COM implementation
-  if ( pformatetc->lindex != -1 ) {
-    wxLogTrace(wxTRACE_OleCalls,
-               wxT("wxIDataObject::QueryGetData: bad lindex %d"),
-               pformatetc->lindex);
-    return DV_E_LINDEX;
-  }
-
-  // we don't support anything other (THUMBNAIL, ICON, DOCPRINT...)
-  if ( pformatetc->dwAspect != DVASPECT_CONTENT ) {
-    wxLogTrace(wxTRACE_OleCalls,
-               wxT("wxIDataObject::QueryGetData: bad dwAspect %d"),
-               pformatetc->dwAspect);
-    return DV_E_DVASPECT;
-  }
-
-  // we only transfer data by global memory, except for some particular cases
-  wxDataFormat format = (wxDataFormatId)pformatetc->cfFormat;
-  DWORD tymed = pformatetc->tymed;
-  if ( (format == wxDF_BITMAP && !(tymed & TYMED_GDI)) ||
-       !(tymed & TYMED_HGLOBAL) ) {
-    // it's not what we're waiting for
-#ifdef __WXDEBUG__
-    wxLogTrace(wxTRACE_OleCalls,
-               wxT("wxIDataObject::QueryGetData: %s & %s == 0."),
-               GetTymedName(tymed),
-               GetTymedName(format == wxDF_BITMAP ? TYMED_GDI : TYMED_HGLOBAL));
-#endif // Debug
-    return DV_E_TYMED;
-  }
+    // do we accept data in this format?
+    if ( pformatetc == NULL ) {
+        wxLogTrace(wxTRACE_OleCalls,
+                   wxT("wxIDataObject::QueryGetData: invalid ptr."));
+
+        return E_INVALIDARG;
+    }
+
+    // the only one allowed by current COM implementation
+    if ( pformatetc->lindex != -1 ) {
+        wxLogTrace(wxTRACE_OleCalls,
+                   wxT("wxIDataObject::QueryGetData: bad lindex %d"),
+                   pformatetc->lindex);
+
+        return DV_E_LINDEX;
+    }
+
+    // we don't support anything other (THUMBNAIL, ICON, DOCPRINT...)
+    if ( pformatetc->dwAspect != DVASPECT_CONTENT ) {
+        wxLogTrace(wxTRACE_OleCalls,
+                   wxT("wxIDataObject::QueryGetData: bad dwAspect %d"),
+                   pformatetc->dwAspect);
+
+        return DV_E_DVASPECT;
+    }
+
+    // and now check the type of data requested
+    wxDataFormat format = pformatetc->cfFormat;
+    if ( m_pDataObject->IsSupportedFormat(format) ) {
+        wxLogTrace(wxTRACE_OleCalls, wxT("wxIDataObject::QueryGetData: %s ok"),
+                   wxGetFormatName(format));
+    }
+    else {
+        wxLogTrace(wxTRACE_OleCalls,
+                   wxT("wxIDataObject::QueryGetData: %s unsupported"),
+                   wxGetFormatName(format));
+
+        return DV_E_FORMATETC;
+    }
+
+    // we only transfer data by global memory, except for some particular cases
+    DWORD tymed = pformatetc->tymed;
+    if ( (format == wxDF_BITMAP && !(tymed & TYMED_GDI)) &&
+         !(tymed & TYMED_HGLOBAL) ) {
+        // it's not what we're waiting for
+        wxLogTrace(wxTRACE_OleCalls,
+                   wxT("wxIDataObject::QueryGetData: %s != %s"),
+                   GetTymedName(tymed),
+                   GetTymedName(format == wxDF_BITMAP ? TYMED_GDI
+                                                      : TYMED_HGLOBAL));
+
+        return DV_E_TYMED;
+    }
 
 
-  // and now check the type of data requested
-  if ( m_pDataObject->IsSupportedFormat(format) ) {
-#ifdef __WXDEBUG__
-    wxLogTrace(wxTRACE_OleCalls, wxT("wxIDataObject::QueryGetData: %s ok"),
-               wxDataObject::GetFormatName(format));
-#endif // Debug
     return S_OK;
     return S_OK;
-  }
-  else {
-    wxLogTrace(wxTRACE_OleCalls,
-               wxT("wxIDataObject::QueryGetData: %s unsupported"),
-               wxDataObject::GetFormatName((wxDataFormatId)pformatetc->cfFormat));
-    return DV_E_FORMATETC;
-  }
 }
 
 }
 
-STDMETHODIMP wxIDataObject::GetCanonicalFormatEtc(FORMATETC *pFormatetcIn,
+STDMETHODIMP wxIDataObject::GetCanonicalFormatEtc(FORMATETC *WXUNUSED(pFormatetcIn),
                                                   FORMATETC *pFormatetcOut)
 {
     wxLogTrace(wxTRACE_OleCalls, wxT("wxIDataObject::GetCanonicalFormatEtc"));
                                                   FORMATETC *pFormatetcOut)
 {
     wxLogTrace(wxTRACE_OleCalls, wxT("wxIDataObject::GetCanonicalFormatEtc"));
@@ -434,28 +611,19 @@ STDMETHODIMP wxIDataObject::GetCanonicalFormatEtc(FORMATETC *pFormatetcIn,
     return DATA_S_SAMEFORMATETC;
 }
 
     return DATA_S_SAMEFORMATETC;
 }
 
-STDMETHODIMP wxIDataObject::EnumFormatEtc(DWORD dwDirection,
+STDMETHODIMP wxIDataObject::EnumFormatEtc(DWORD dwDir,
                                           IEnumFORMATETC **ppenumFormatEtc)
 {
     wxLogTrace(wxTRACE_OleCalls, wxT("wxIDataObject::EnumFormatEtc"));
 
                                           IEnumFORMATETC **ppenumFormatEtc)
 {
     wxLogTrace(wxTRACE_OleCalls, wxT("wxIDataObject::EnumFormatEtc"));
 
-    if ( dwDirection == DATADIR_SET ) {
-        // we don't allow setting of data anyhow
-        return E_NOTIMPL;
-    }
+    wxDataObject::Direction dir = dwDir == DATADIR_GET ? wxDataObject::Get
+                                                       : wxDataObject::Set;
 
 
-    size_t nFormatCount = m_pDataObject->GetFormatCount();
-    wxDataFormat format, *formats;
-    if ( nFormatCount == 1 ) {
-        // this is the most common case, this is why we consider it separately
-        formats = &format;
-        format = m_pDataObject->GetPreferredFormat();
-    }
-    else {
-        // bad luck, build the array with all formats
-        formats = new wxDataFormat[nFormatCount];
-        m_pDataObject->GetAllFormats(formats);
-    }
+    size_t nFormatCount = m_pDataObject->GetFormatCount(dir);
+    wxDataFormat format;
+       wxDataFormat *formats;
+    formats = nFormatCount == 1 ? &format : new wxDataFormat[nFormatCount];
+    m_pDataObject->GetAllFormats(formats, dir);
 
     wxIEnumFORMATETC *pEnum = new wxIEnumFORMATETC(formats, nFormatCount);
     pEnum->AddRef();
 
     wxIEnumFORMATETC *pEnum = new wxIEnumFORMATETC(formats, nFormatCount);
     pEnum->AddRef();
@@ -468,21 +636,24 @@ STDMETHODIMP wxIDataObject::EnumFormatEtc(DWORD dwDirection,
     return S_OK;
 }
 
     return S_OK;
 }
 
+// ----------------------------------------------------------------------------
 // advise sink functions (not implemented)
 // advise sink functions (not implemented)
-STDMETHODIMP wxIDataObject::DAdvise(FORMATETC   *pformatetc,
-                                    DWORD        advf,
-                                    IAdviseSink *pAdvSink,
-                                    DWORD       *pdwConnection)
+// ----------------------------------------------------------------------------
+
+STDMETHODIMP wxIDataObject::DAdvise(FORMATETC   *WXUNUSED(pformatetc),
+                                    DWORD        WXUNUSED(advf),
+                                    IAdviseSink *WXUNUSED(pAdvSink),
+                                    DWORD       *WXUNUSED(pdwConnection))
 {
   return OLE_E_ADVISENOTSUPPORTED;
 }
 
 {
   return OLE_E_ADVISENOTSUPPORTED;
 }
 
-STDMETHODIMP wxIDataObject::DUnadvise(DWORD dwConnection)
+STDMETHODIMP wxIDataObject::DUnadvise(DWORD WXUNUSED(dwConnection))
 {
   return OLE_E_ADVISENOTSUPPORTED;
 }
 
 {
   return OLE_E_ADVISENOTSUPPORTED;
 }
 
-STDMETHODIMP wxIDataObject::EnumDAdvise(IEnumSTATDATA **ppenumAdvise)
+STDMETHODIMP wxIDataObject::EnumDAdvise(IEnumSTATDATA **WXUNUSED(ppenumAdvise))
 {
   return OLE_E_ADVISENOTSUPPORTED;
 }
 {
   return OLE_E_ADVISENOTSUPPORTED;
 }
@@ -493,162 +664,527 @@ STDMETHODIMP wxIDataObject::EnumDAdvise(IEnumSTATDATA **ppenumAdvise)
 
 wxDataObject::wxDataObject()
 {
 
 wxDataObject::wxDataObject()
 {
-  m_pIDataObject = new wxIDataObject(this);
-  m_pIDataObject->AddRef();
+    m_pIDataObject = new wxIDataObject(this);
+    m_pIDataObject->AddRef();
 }
 
 wxDataObject::~wxDataObject()
 {
 }
 
 wxDataObject::~wxDataObject()
 {
-  m_pIDataObject->Release();
+    ReleaseInterface(m_pIDataObject);
 }
 
 }
 
-bool wxDataObject::IsSupportedFormat(const wxDataFormat& format) const
+void wxDataObject::SetAutoDelete()
 {
 {
-    size_t nFormatCount = GetFormatCount();
-    if ( nFormatCount == 1 ) {
-        return format == GetPreferredFormat();
-    }
-    else {
-        wxDataFormat *formats = new wxDataFormat[nFormatCount];
-        GetAllFormats(formats);
+    ((wxIDataObject *)m_pIDataObject)->SetDeleteFlag();
+    m_pIDataObject->Release();
 
 
-        size_t n;
-        for ( n = 0; n < nFormatCount; n++ ) {
-            if ( formats[n] == format )
-                break;
-        }
+    // so that the dtor doesnt' crash
+    m_pIDataObject = NULL;
+}
 
 
-        delete [] formats;
+#ifdef __WXDEBUG__
+
+const wxChar *wxDataObject::GetFormatName(wxDataFormat format)
+{
+    // case 'xxx' is not a valid value for switch of enum 'wxDataFormat'
+    #ifdef __VISUALC__
+        #pragma warning(disable:4063)
+    #endif // VC++
+
+    static wxChar s_szBuf[256];
+    switch ( format ) {
+        case CF_TEXT:         return wxT("CF_TEXT");
+        case CF_BITMAP:       return wxT("CF_BITMAP");
+        case CF_METAFILEPICT: return wxT("CF_METAFILEPICT");
+        case CF_SYLK:         return wxT("CF_SYLK");
+        case CF_DIF:          return wxT("CF_DIF");
+        case CF_TIFF:         return wxT("CF_TIFF");
+        case CF_OEMTEXT:      return wxT("CF_OEMTEXT");
+        case CF_DIB:          return wxT("CF_DIB");
+        case CF_PALETTE:      return wxT("CF_PALETTE");
+        case CF_PENDATA:      return wxT("CF_PENDATA");
+        case CF_RIFF:         return wxT("CF_RIFF");
+        case CF_WAVE:         return wxT("CF_WAVE");
+        case CF_UNICODETEXT:  return wxT("CF_UNICODETEXT");
+        case CF_ENHMETAFILE:  return wxT("CF_ENHMETAFILE");
+        case CF_HDROP:        return wxT("CF_HDROP");
+        case CF_LOCALE:       return wxT("CF_LOCALE");
 
 
-        // found?
-        return n < nFormatCount;
+        default:
+            if ( !::GetClipboardFormatName(format, s_szBuf, WXSIZEOF(s_szBuf)) )
+            {
+                // it must be a new predefined format we don't know the name of
+                wxSprintf(s_szBuf, wxT("unknown CF (0x%04x)"), format.GetFormatId());
+            }
+
+            return s_szBuf;
     }
     }
-}
 
 
-#ifdef __WXDEBUG__
-const char *wxDataObject::GetFormatName(wxDataFormat format)
-{
-  // case 'xxx' is not a valid value for switch of enum 'wxDataFormat'
-  #ifdef __VISUALC__
-    #pragma warning(disable:4063)
-  #endif // VC++
-
-  static char s_szBuf[128];
-  switch ( format ) {
-    case CF_TEXT:         return "CF_TEXT";
-    case CF_BITMAP:       return "CF_BITMAP";
-    case CF_METAFILEPICT: return "CF_METAFILEPICT";
-    case CF_SYLK:         return "CF_SYLK";
-    case CF_DIF:          return "CF_DIF";
-    case CF_TIFF:         return "CF_TIFF";
-    case CF_OEMTEXT:      return "CF_OEMTEXT";
-    case CF_DIB:          return "CF_DIB";
-    case CF_PALETTE:      return "CF_PALETTE";
-    case CF_PENDATA:      return "CF_PENDATA";
-    case CF_RIFF:         return "CF_RIFF";
-    case CF_WAVE:         return "CF_WAVE";
-    case CF_UNICODETEXT:  return "CF_UNICODETEXT";
-    case CF_ENHMETAFILE:  return "CF_ENHMETAFILE";
-    case CF_HDROP:        return "CF_HDROP";
-    case CF_LOCALE:       return "CF_LOCALE";
-    default:
-      sprintf(s_szBuf, "clipboard format %d (unknown)", format);
-      return s_szBuf;
-  }
-
-  #ifdef __VISUALC__
-    #pragma warning(default:4063)
-  #endif // VC++
+    #ifdef __VISUALC__
+        #pragma warning(default:4063)
+    #endif // VC++
 }
 }
+
 #endif // Debug
 
 // ----------------------------------------------------------------------------
 #endif // Debug
 
 // ----------------------------------------------------------------------------
-// wxPrivateDataObject
+// wxBitmapDataObject supports CF_DIB format
 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------
 
-wxPrivateDataObject::wxPrivateDataObject()
+size_t wxBitmapDataObject::GetDataSize() const
 {
 {
-    m_size = 0;
-    m_data = NULL;
+    return wxConvertBitmapToDIB(NULL, GetBitmap());
 }
 
 }
 
-void wxPrivateDataObject::Free()
+bool wxBitmapDataObject::GetDataHere(void *buf) const
 {
 {
-    if ( m_data )
-        free(m_data);
+    return wxConvertBitmapToDIB((LPBITMAPINFO)buf, GetBitmap()) != 0;
 }
 
 }
 
-void wxPrivateDataObject::SetData( const void *data, size_t size )
+bool wxBitmapDataObject::SetData(size_t WXUNUSED(len), const void *buf)
 {
 {
-    Free();
+    wxBitmap bitmap(wxConvertDIBToBitmap((const LPBITMAPINFO)buf));
 
 
-    m_size = size;
-    m_data = malloc(size);
+    if ( !bitmap.Ok() ) {
+        wxFAIL_MSG(wxT("pasting/dropping invalid bitmap"));
 
 
-    memcpy( m_data, data, size );
+        return FALSE;
+    }
+
+    SetBitmap(bitmap);
+
+    return TRUE;
 }
 
 }
 
-void wxPrivateDataObject::WriteData( void *dest ) const
+// ----------------------------------------------------------------------------
+// wxBitmapDataObject2 supports CF_BITMAP format
+// ----------------------------------------------------------------------------
+
+// the bitmaps aren't passed by value as other types of data (i.e. by copying
+// the data into a global memory chunk and passing it to the clipboard or
+// another application or whatever), but by handle, so these generic functions
+// don't make much sense to them.
+
+size_t wxBitmapDataObject2::GetDataSize() const
 {
 {
-    WriteData( m_data, dest );
+    return 0;
 }
 
 }
 
-size_t wxPrivateDataObject::GetSize() const
+bool wxBitmapDataObject2::GetDataHere(void *pBuf) const
 {
 {
-    return m_size;
+    // we put a bitmap handle into pBuf
+    *(WXHBITMAP *)pBuf = GetBitmap().GetHBITMAP();
+
+    return TRUE;
+}
+
+bool wxBitmapDataObject2::SetData(size_t WXUNUSED(len), const void *pBuf)
+{
+    HBITMAP hbmp = *(HBITMAP *)pBuf;
+
+    BITMAP bmp;
+    if ( !GetObject(hbmp, sizeof(BITMAP), &bmp) )
+    {
+        wxLogLastError(wxT("GetObject(HBITMAP)"));
+    }
+
+    wxBitmap bitmap(bmp.bmWidth, bmp.bmHeight, bmp.bmPlanes);
+    bitmap.SetHBITMAP((WXHBITMAP)hbmp);
+
+    if ( !bitmap.Ok() ) {
+        wxFAIL_MSG(wxT("pasting/dropping invalid bitmap"));
+
+        return FALSE;
+    }
+
+    SetBitmap(bitmap);
+
+    return TRUE;
+}
+
+#if 0
+
+size_t wxBitmapDataObject::GetDataSize(const wxDataFormat& format) const
+{
+    if ( format.GetFormatId() == CF_DIB )
+    {
+        // create the DIB
+        ScreenHDC hdc;
+
+        // shouldn't be selected into a DC or GetDIBits() would fail
+        wxASSERT_MSG( !m_bitmap.GetSelectedInto(),
+                      wxT("can't copy bitmap selected into wxMemoryDC") );
+
+        // first get the info
+        BITMAPINFO bi;
+        if ( !GetDIBits(hdc, (HBITMAP)m_bitmap.GetHBITMAP(), 0, 0,
+                        NULL, &bi, DIB_RGB_COLORS) )
+        {
+            wxLogLastError(wxT("GetDIBits(NULL)"));
+
+            return 0;
+        }
+
+        return sizeof(BITMAPINFO) + bi.bmiHeader.biSizeImage;
+    }
+    else // CF_BITMAP
+    {
+        // no data to copy - we don't pass HBITMAP via global memory
+        return 0;
+    }
+}
+
+bool wxBitmapDataObject::GetDataHere(const wxDataFormat& format,
+                                     void *pBuf) const
+{
+    wxASSERT_MSG( m_bitmap.Ok(), wxT("copying invalid bitmap") );
+
+    HBITMAP hbmp = (HBITMAP)m_bitmap.GetHBITMAP();
+    if ( format.GetFormatId() == CF_DIB )
+    {
+        // create the DIB
+        ScreenHDC hdc;
+
+        // shouldn't be selected into a DC or GetDIBits() would fail
+        wxASSERT_MSG( !m_bitmap.GetSelectedInto(),
+                      wxT("can't copy bitmap selected into wxMemoryDC") );
+
+        // first get the info
+        BITMAPINFO *pbi = (BITMAPINFO *)pBuf;
+        if ( !GetDIBits(hdc, hbmp, 0, 0, NULL, pbi, DIB_RGB_COLORS) )
+        {
+            wxLogLastError(wxT("GetDIBits(NULL)"));
+
+            return 0;
+        }
+
+        // and now copy the bits
+        if ( !GetDIBits(hdc, hbmp, 0, pbi->bmiHeader.biHeight, pbi + 1,
+                        pbi, DIB_RGB_COLORS) )
+        {
+            wxLogLastError(wxT("GetDIBits"));
+
+            return FALSE;
+        }
+    }
+    else // CF_BITMAP
+    {
+        // we put a bitmap handle into pBuf
+        *(HBITMAP *)pBuf = hbmp;
+    }
+
+    return TRUE;
 }
 
 }
 
-void wxPrivateDataObject::WriteData( const void *data, void *dest ) const
+bool wxBitmapDataObject::SetData(const wxDataFormat& format,
+                                 size_t size, const void *pBuf)
 {
 {
-    memcpy( dest, data, GetSize() );
+    HBITMAP hbmp;
+    if ( format.GetFormatId() == CF_DIB )
+    {
+        // here we get BITMAPINFO struct followed by the actual bitmap bits and
+        // BITMAPINFO starts with BITMAPINFOHEADER followed by colour info
+        ScreenHDC hdc;
+
+        BITMAPINFO *pbmi = (BITMAPINFO *)pBuf;
+        BITMAPINFOHEADER *pbmih = &pbmi->bmiHeader;
+        hbmp = CreateDIBitmap(hdc, pbmih, CBM_INIT,
+                              pbmi + 1, pbmi, DIB_RGB_COLORS);
+        if ( !hbmp )
+        {
+            wxLogLastError(wxT("CreateDIBitmap"));
+        }
+
+        m_bitmap.SetWidth(pbmih->biWidth);
+        m_bitmap.SetHeight(pbmih->biHeight);
+    }
+    else // CF_BITMAP
+    {
+        // it's easy with bitmaps: we pass them by handle
+        hbmp = *(HBITMAP *)pBuf;
+
+        BITMAP bmp;
+        if ( !GetObject(hbmp, sizeof(BITMAP), &bmp) )
+        {
+            wxLogLastError(wxT("GetObject(HBITMAP)"));
+        }
+
+        m_bitmap.SetWidth(bmp.bmWidth);
+        m_bitmap.SetHeight(bmp.bmHeight);
+        m_bitmap.SetDepth(bmp.bmPlanes);
+    }
+
+    m_bitmap.SetHBITMAP((WXHBITMAP)hbmp);
+
+    wxASSERT_MSG( m_bitmap.Ok(), wxT("pasting invalid bitmap") );
+
+    return TRUE;
 }
 
 }
 
+#endif // 0
+
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
-// wxBitmapDataObject
+// wxFileDataObject
 // ----------------------------------------------------------------------------
 
 // ----------------------------------------------------------------------------
 
-// the bitmaps aren't passed by value as other types of data (i.e. by copyign
-// the data into a global memory chunk and passing it to the clipboard or
-// another application or whatever), but by handle, so these generic functions
-// don't make much sense to them.
+bool wxFileDataObject::SetData(size_t WXUNUSED(size), const void *pData)
+{
+    m_filenames.Empty();
+
+    // the documentation states that the first member of DROPFILES structure is
+    // a "DWORD offset of double NUL terminated file list". What they mean by
+    // this (I wonder if you see it immediately) is that the list starts at
+    // ((char *)&(pDropFiles.pFiles)) + pDropFiles.pFiles. We're also advised
+    // to use DragQueryFile to work with this structure, but not told where and
+    // how to get HDROP.
+    HDROP hdrop = (HDROP)pData;   // NB: it works, but I'm not sure about it
+
+    // get number of files (magic value -1)
+    UINT nFiles = ::DragQueryFile(hdrop, (unsigned)-1, NULL, 0u);
+
+    wxCHECK_MSG ( nFiles != (UINT)-1, FALSE, wxT("wrong HDROP handle") );
+
+    // for each file get the length, allocate memory and then get the name
+    wxString str;
+    UINT len, n;
+    for ( n = 0; n < nFiles; n++ ) {
+        // +1 for terminating NUL
+        len = ::DragQueryFile(hdrop, n, NULL, 0) + 1;
+
+        UINT len2 = ::DragQueryFile(hdrop, n, str.GetWriteBuf(len), len);
+        str.UngetWriteBuf();
+        m_filenames.Add(str);
+
+        if ( len2 != len - 1 ) {
+            wxLogDebug(wxT("In wxFileDropTarget::OnDrop DragQueryFile returned\
+ %d characters, %d expected."), len2, len - 1);
+        }
+    }
 
 
-size_t wxBitmapDataObject::GetDataSize(const wxDataFormat& format) const
+    return TRUE;
+}
+
+void wxFileDataObject::AddFile(const wxString& file)
 {
 {
-    // no data to copy anyhow
-    return 0;
+    // just add file to filenames array
+    // all useful data (such as DROPFILES struct) will be
+    // created later as necessary
+    m_filenames.Add(file);
 }
 
 }
 
-void wxBitmapDataObject::GetDataHere(const wxDataFormat& format,
-                                     void *pBuf) const
+size_t wxFileDataObject::GetDataSize() const
 {
 {
-    // we put a bitmap handle into pBuf
-    *(WXHBITMAP *)pBuf = m_bitmap.GetHBITMAP();
+    // size returned will be the size of the DROPFILES structure,
+    // plus the list of filesnames (null byte separated), plus
+    // a double null at the end
+
+    // if no filenames in list, size is 0
+    if ( m_filenames.GetCount() == 0 )
+        return 0;
+
+    // inital size of DROPFILES struct + null byte
+    size_t sz = sizeof(DROPFILES) + 1;
+
+    size_t count = m_filenames.GetCount();
+    for ( size_t i = 0; i < count; i++ )
+    {
+        // add filename length plus null byte
+        sz += m_filenames[i].Len() + 1;
+    }
+
+    return sz;
+}
+
+bool wxFileDataObject::GetDataHere(void *pData) const
+{
+    // pData points to an externally allocated memory block
+    // created using the size returned by GetDataSize()
+
+    // if pData is NULL, or there are no files, return
+    if ( !pData || m_filenames.GetCount() == 0 )
+        return FALSE;
+
+    // convert data pointer to a DROPFILES struct pointer
+    LPDROPFILES pDrop = (LPDROPFILES) pData;
+
+    // initialize DROPFILES struct
+    pDrop->pFiles = sizeof(DROPFILES);
+    pDrop->fNC = FALSE;                 // not non-client coords
+#if wxUSE_UNICODE
+    pDrop->fWide = TRUE;
+#else // ANSI
+    pDrop->fWide = FALSE;
+#endif // Unicode/Ansi
+
+    // set start of filenames list (null separated)
+    wxChar *pbuf = (wxChar*) ((BYTE *)pDrop + sizeof(DROPFILES));
+
+    size_t count = m_filenames.GetCount();
+    for (size_t i = 0; i < count; i++ )
+    {
+        // copy filename to pbuf and add null terminator
+        size_t len = m_filenames[i].Len();
+        memcpy(pbuf, m_filenames[i], len);
+        pbuf += len;
+        *pbuf++ = wxT('\0');
+    }
+
+    *pbuf = wxT('\0'); // add final null terminator
+
+    return TRUE;
 }
 
 // ----------------------------------------------------------------------------
 // private functions
 // ----------------------------------------------------------------------------
 
 }
 
 // ----------------------------------------------------------------------------
 // private functions
 // ----------------------------------------------------------------------------
 
+static size_t wxGetNumOfBitmapColors(size_t bitsPerPixel)
+{
+    switch ( bitsPerPixel )
+    {
+        case 1:
+            // monochrome bitmap, 2 entries
+            return 2;
+
+        case 4:
+            return 16;
+
+        case 8:
+            return 256;
+
+        case 24:
+            // may be used with 24bit bitmaps, but we don't use it here - fall
+            // through
+
+        case 16:
+        case 32:
+            // bmiColors not used at all with these bitmaps
+            return 0;
+
+        default:
+            wxFAIL_MSG( wxT("unknown bitmap format") );
+            return 0;
+    }
+}
+
+size_t wxConvertBitmapToDIB(LPBITMAPINFO pbi, const wxBitmap& bitmap)
+{
+    wxASSERT_MSG( bitmap.Ok(), wxT("invalid bmp can't be converted to DIB") );
+
+    // shouldn't be selected into a DC or GetDIBits() would fail
+    wxASSERT_MSG( !bitmap.GetSelectedInto(),
+                  wxT("can't copy bitmap selected into wxMemoryDC") );
+
+    // prepare all the info we need
+    BITMAP bm;
+    HBITMAP hbmp = (HBITMAP)bitmap.GetHBITMAP();
+    if ( !GetObject(hbmp, sizeof(bm), &bm) )
+    {
+        wxLogLastError(wxT("GetObject(bitmap)"));
+
+        return 0;
+    }
+
+    // calculate the number of bits per pixel and the number of items in
+    // bmiColors array (whose meaning depends on the bitmap format)
+    WORD biBits = bm.bmPlanes * bm.bmBitsPixel;
+    WORD biColors = (WORD)wxGetNumOfBitmapColors(biBits);
+
+    BITMAPINFO bi2;
+
+    bool wantSizeOnly = pbi == NULL;
+    if ( wantSizeOnly )
+        pbi = &bi2;
+
+    // just for convenience
+    BITMAPINFOHEADER& bi = pbi->bmiHeader;
+
+    bi.biSize = sizeof(BITMAPINFOHEADER);
+    bi.biWidth = bm.bmWidth;
+    bi.biHeight = bm.bmHeight;
+    bi.biPlanes = 1;
+    bi.biBitCount = biBits;
+    bi.biCompression = BI_RGB;
+    bi.biSizeImage = 0;
+    bi.biXPelsPerMeter = 0;
+    bi.biYPelsPerMeter = 0;
+    bi.biClrUsed = 0;
+    bi.biClrImportant = 0;
+
+    // memory we need for BITMAPINFO only
+    DWORD dwLen = bi.biSize + biColors * sizeof(RGBQUAD);
+
+    // first get the image size
+    ScreenHDC hdc;
+    if ( !GetDIBits(hdc, hbmp, 0, bi.biHeight, NULL, pbi, DIB_RGB_COLORS) )
+    {
+        wxLogLastError(wxT("GetDIBits(NULL)"));
+
+        return 0;
+    }
+
+    if ( wantSizeOnly )
+    {
+        // size of the header + size of the image
+        return dwLen + bi.biSizeImage;
+    }
+
+    // and now copy the bits
+    void *image = (char *)pbi + dwLen;
+    if ( !GetDIBits(hdc, hbmp, 0, bi.biHeight, image, pbi, DIB_RGB_COLORS) )
+    {
+        wxLogLastError(wxT("GetDIBits"));
+
+        return 0;
+    }
+
+    return dwLen + bi.biSizeImage;
+}
+
+wxBitmap wxConvertDIBToBitmap(const LPBITMAPINFO pbmi)
+{
+    // here we get BITMAPINFO struct followed by the actual bitmap bits and
+    // BITMAPINFO starts with BITMAPINFOHEADER followed by colour info
+    const BITMAPINFOHEADER *pbmih = &pbmi->bmiHeader;
+
+    // offset of image from the beginning of the header
+    DWORD ofs = wxGetNumOfBitmapColors(pbmih->biBitCount) * sizeof(RGBQUAD);
+    void *image = (char *)pbmih + sizeof(BITMAPINFOHEADER) + ofs;
+
+    ScreenHDC hdc;
+    HBITMAP hbmp = CreateDIBitmap(hdc, pbmih, CBM_INIT,
+                                  image, pbmi, DIB_RGB_COLORS);
+    if ( !hbmp )
+    {
+        wxLogLastError(wxT("CreateDIBitmap"));
+    }
+
+    wxBitmap bitmap(pbmih->biWidth, pbmih->biHeight, pbmih->biBitCount);
+    bitmap.SetHBITMAP((WXHBITMAP)hbmp);
+
+    return bitmap;
+}
+
 #ifdef __WXDEBUG__
 
 #ifdef __WXDEBUG__
 
-static const char *GetTymedName(DWORD tymed)
+static const wxChar *GetTymedName(DWORD tymed)
 {
 {
-  static char s_szBuf[128];
-  switch ( tymed ) {
-    case TYMED_HGLOBAL:   return "TYMED_HGLOBAL";
-    case TYMED_FILE:      return "TYMED_FILE";
-    case TYMED_ISTREAM:   return "TYMED_ISTREAM";
-    case TYMED_ISTORAGE:  return "TYMED_ISTORAGE";
-    case TYMED_GDI:       return "TYMED_GDI";
-    case TYMED_MFPICT:    return "TYMED_MFPICT";
-    case TYMED_ENHMF:     return "TYMED_ENHMF";
-    default:
-      sprintf(s_szBuf, "type of media format %d (unknown)", tymed);
-      return s_szBuf;
-  }
+    static wxChar s_szBuf[128];
+    switch ( tymed ) {
+        case TYMED_HGLOBAL:   return wxT("TYMED_HGLOBAL");
+        case TYMED_FILE:      return wxT("TYMED_FILE");
+        case TYMED_ISTREAM:   return wxT("TYMED_ISTREAM");
+        case TYMED_ISTORAGE:  return wxT("TYMED_ISTORAGE");
+        case TYMED_GDI:       return wxT("TYMED_GDI");
+        case TYMED_MFPICT:    return wxT("TYMED_MFPICT");
+        case TYMED_ENHMF:     return wxT("TYMED_ENHMF");
+        default:
+            wxSprintf(s_szBuf, wxT("type of media format %ld (unknown)"), tymed);
+            return s_szBuf;
+    }
 }
 
 #endif // Debug
 
 }
 
 #endif // Debug
 
-#endif
+#endif // not using OLE at all