fixed a canonical example of Stupid Bug(tm)

[wxWidgets.git] / include / wx / gtk / dnd.h

diff --git a/include/wx/gtk/dnd.h b/include/wx/gtk/dnd.h
index c43eeca35b9488b6397e351b4640c191faf1fb76..52199517b47c017dae7450e935b909d1174f9862 100644 (file)
--- a/include/wx/gtk/dnd.h
+++ b/include/wx/gtk/dnd.h
@@ -15,8 +15,6 @@
 #pragma interface
 #endif
 
-#include "wx/defs.h"
-
 #if wxUSE_DRAG_AND_DROP
 
 #include "wx/object.h"
@@ -35,51 +33,40 @@ class wxWindow;
 class wxDropTarget;
 class wxTextDropTarget;
 class wxFileDropTarget;
-class wxPrivateDropTarget;
 
 class wxDropSource;
 
+// ----------------------------------------------------------------------------
+// macros
+// ----------------------------------------------------------------------------
+
+// this macro may be used instead for wxDropSource ctor arguments: it will use
+// the icon 'name' from an XPM file under GTK, but will expand to something
+// else under MSW. If you don't use it, you will have to use #ifdef in the
+// application code.
+#define wxDROP_ICON(name)   wxICON(name)
+
 //-------------------------------------------------------------------------
 // wxDropTarget
 //-------------------------------------------------------------------------
 
-class wxDropTarget: public wxObject
+class wxDropTarget: public wxDropTargetBase
 {
 public:
-    wxDropTarget( wxDataObject *data );
-    ~wxDropTarget();
-
-    /* may be overridden to react to events */
-    virtual bool OnEnter( int x, int y );
-  
-    virtual void OnLeave();
-
-    /* may be overridden to reject certain formats or drops
-       on certain areas. always returns TRUE by default
-       indicating that you'd accept the data from the drag. */
-    virtual bool OnMove( int x, int y );
-
-    /* has to be overridden to accept a drop event. call
-       IsSupported() to ask which formats are available
-       and then call RequestData() to indicate the format
-       you request. */
-    virtual bool OnDrop( int x, int y );
+    wxDropTarget(wxDataObject *dataObject = (wxDataObject*) NULL );
 
-    /* this gets called once the data has actually arrived.
-       it will call GetData() to fill up its wxDataObject */
-    virtual bool OnData( int x, int y );
+    virtual wxDragResult OnDragOver(wxCoord x, wxCoord y, wxDragResult def);
+    virtual bool OnDrop(wxCoord x, wxCoord y);
+    virtual wxDragResult OnData(wxCoord x, wxCoord y, wxDragResult def);
+    virtual bool GetData();
 
-    /* fill data with data from the dragging source */
-    bool GetData();
-
-// implementation
+  // implementation
 
     GdkAtom GetMatchingPair();
 
     void RegisterWidget( GtkWidget *widget );
     void UnregisterWidget( GtkWidget *widget );
 
-    wxDataObject       *m_data;
     GdkDragContext     *m_dragContext;
     GtkWidget          *m_dragWidget;
     GtkSelectionData   *m_dragData;
@@ -96,50 +83,50 @@ public:
 // wxDropSource
 //-------------------------------------------------------------------------
 
-enum wxDragResult
-{
-  wxDragError,    // error prevented the d&d operation from completing
-  wxDragNone,     // drag target didn't accept the data
-  wxDragCopy,     // the data was successfully copied
-  wxDragMove,     // the data was successfully moved (MSW only)
-  wxDragCancel    // the operation was cancelled by user (not an error)
-};
-
-class wxDropSource: public wxObject
+class wxDropSource: public wxDropSourceBase
 {
 public:
-
-  /* constructor. set data later with SetData() */
-  wxDropSource( wxWindow *win, const wxIcon &go = wxNullIcon, const wxIcon &stop = wxNullIcon );
-
-  wxDropSource( wxDataObject& data, wxWindow *win, const wxIcon &go = wxNullIcon, const wxIcon &stop = wxNullIcon );
-  ~wxDropSource();
-
-  void SetData( wxDataObject& data );
-
-  /* start drag action */
-  wxDragResult DoDragDrop( bool bAllowMove = FALSE );
-
-  /* override to give feedback */
-  virtual bool GiveFeedback( wxDragResult WXUNUSED(effect), bool WXUNUSED(bScrolling) ) { return TRUE; }
-
-  /* GTK implementation */
-
-  void RegisterWindow();
-  void UnregisterWindow();
-
-    GtkWidget     *m_widget;
-    wxWindow      *m_window;
-    wxDragResult   m_retValue;
-    wxDataObject  *m_data;
-
-    wxCursor      m_defaultCursor;
-    wxCursor      m_goaheadCursor;
-
-    wxIcon        m_goIcon;
-    wxIcon        m_stopIcon;
-
-    bool          m_waiting;
+    /* constructor. set data later with SetData() */
+    wxDropSource( wxWindow *win = (wxWindow *)NULL,
+                  const wxIcon &copy = wxNullIcon,
+                  const wxIcon &move = wxNullIcon,
+                  const wxIcon &none = wxNullIcon);
+
+    /* constructor for setting one data object */
+    wxDropSource( wxDataObject& data,
+                  wxWindow *win,
+                  const wxIcon &copy = wxNullIcon,
+                  const wxIcon &move = wxNullIcon,
+                  const wxIcon &none = wxNullIcon);
+
+    ~wxDropSource();
+
+    /* start drag action */
+    virtual wxDragResult DoDragDrop( bool bAllowMove = FALSE );
+
+    /* GTK implementation */
+    void RegisterWindow();
+    void UnregisterWindow();
+
+    void PrepareIcon( int action, GdkDragContext *context );
+
+    GtkWidget       *m_widget;
+    GtkWidget       *m_iconWindow;
+    GdkDragContext  *m_dragContext;
+    wxWindow        *m_window;
+
+    wxDragResult     m_retValue;
+    wxIcon           m_iconCopy,
+                     m_iconMove,
+                     m_iconNone;
+
+    bool             m_waiting;
+
+private:
+    // common part of both ctors
+    void SetIcons(const wxIcon& copy,
+                  const wxIcon& move,
+                  const wxIcon& none);
 };
 
 #endif