fixed serious bug in wxFont::operator== (ignored weight)

[wxWidgets.git] / src / msw / settings.cpp

diff --git a/src/msw/settings.cpp b/src/msw/settings.cpp
index b636a80883f7c256df11390f2965265092f39df4..360e8a2fc3c618f9404453a47f05e578dcde3d05 100644 (file)
--- a/src/msw/settings.cpp
+++ b/src/msw/settings.cpp
@@ -39,6 +39,8 @@
 #include "wx/settings.h"
 #include "wx/window.h"
 #include "wx/msw/private.h"
+#include "wx/module.h"
+#include "wx/fontutil.h"
 
 // ----------------------------------------------------------------------------
 // private classes
@@ -48,6 +50,7 @@
 // singleton class so it can't be done in the dtor)
 class wxSystemSettingsModule : public wxModule
 {
+    friend class wxSystemSettings;
 public:
     virtual bool OnInit();
     virtual void OnExit();
@@ -80,6 +83,7 @@ bool wxSystemSettingsModule::OnInit()
 void wxSystemSettingsModule::OnExit()
 {
     delete gs_fontDefault;
+    gs_fontDefault = NULL;
 }
 
 // ----------------------------------------------------------------------------
@@ -107,16 +111,8 @@ wxColour wxSystemSettings::GetSystemColour(int index)
     }
 }
 
-wxFont wxSystemSettings::GetSystemFont(int index)
+wxFont wxCreateFontFromStockObject(int index)
 {
-    // wxWindow ctor calls GetSystemFont(wxSYS_DEFAULT_GUI_FONT) so we're
-    // called fairly often - this is why we cache this particular font
-    bool isDefaultRequested = index == wxSYS_DEFAULT_GUI_FONT;
-    if ( isDefaultRequested && gs_fontDefault )
-    {
-        return *gs_fontDefault;
-    }
-
     wxFont font;
 
     HFONT hFont = (HFONT) ::GetStockObject(index);
@@ -125,7 +121,16 @@ wxFont wxSystemSettings::GetSystemFont(int index)
         LOGFONT lf;
         if ( ::GetObject(hFont, sizeof(LOGFONT), &lf) != 0 )
         {
-            font = wxCreateFontFromLogFont(&lf);
+            wxNativeFontInfo info;
+            info.lf = lf;
+            // Under MicroWindows we pass the HFONT as well
+            // because it's hard to convert HFONT -> LOGFONT -> HFONT
+            // It's OK to delete stock objects, the delete will be ignored.
+#ifdef __WXMICROWIN__
+            font.Create(info, (WXHFONT) hFont);
+#else
+            font.Create(info);
+#endif
         }
         else
         {
@@ -136,6 +141,20 @@ wxFont wxSystemSettings::GetSystemFont(int index)
     {
         wxFAIL_MSG( _T("stock font not found") );
     }
+    return font;
+}
+
+wxFont wxSystemSettings::GetSystemFont(int index)
+{
+    // wxWindow ctor calls GetSystemFont(wxSYS_DEFAULT_GUI_FONT) so we're
+    // called fairly often - this is why we cache this particular font
+    bool isDefaultRequested = index == wxSYS_DEFAULT_GUI_FONT;
+    if ( isDefaultRequested && gs_fontDefault )
+    {
+        return *gs_fontDefault;
+    }
+
+    wxFont font = wxCreateFontFromStockObject(index);
 
     if ( isDefaultRequested )
     {
@@ -149,6 +168,10 @@ wxFont wxSystemSettings::GetSystemFont(int index)
 // Get a system metric, e.g. scrollbar size
 int wxSystemSettings::GetSystemMetric(int index)
 {
+#ifdef __WXMICROWIN__
+    // TODO: probably use wxUniv themes functionality
+    return 0;
+#else
     switch ( index)
     {
 #ifdef __WIN32__
@@ -240,5 +263,7 @@ int wxSystemSettings::GetSystemMetric(int index)
         default:
             return 0;
     }
+#endif
+    // __WXMICROWIN__
 }