Applied patch [ 1374215 ] Bug fix to wxSpinCtrl for Windows

[wxWidgets.git] / src / msw / evtloop.cpp

diff --git a/src/msw/evtloop.cpp b/src/msw/evtloop.cpp
index 7721d45905085d4f4ea45f177791ce805d25692b..805fb95ef4aebd703fdfa5f8717ea7b71dc8b3c1 100644 (file)
--- a/src/msw/evtloop.cpp
+++ b/src/msw/evtloop.cpp
@@ -48,39 +48,10 @@
     WX_DEFINE_LIST(wxMsgList)
 #endif // wxUSE_THREADS
 
     WX_DEFINE_LIST(wxMsgList)
 #endif // wxUSE_THREADS
 

-// ----------------------------------------------------------------------------
-// helper class
-// ----------------------------------------------------------------------------
-
-// this object sets the wxEventLoop given to the ctor as the currently active
-// one and unsets it in its dtor
-class wxEventLoopActivator
-{
-public:
-    wxEventLoopActivator(wxEventLoop **pActive,
-                         wxEventLoop *evtLoop)
-    {
-        m_pActive = pActive;
-        m_evtLoopOld = *pActive;
-        *pActive = evtLoop;
-    }
-
-    ~wxEventLoopActivator()
-    {
-        // restore the previously active event loop
-        *m_pActive = m_evtLoopOld;
-    }
-
-private:
-    wxEventLoop *m_evtLoopOld;
-    wxEventLoop **m_pActive;
-};
-

 // ============================================================================
 // wxEventLoop implementation
 // ============================================================================
 
 // ============================================================================
 // wxEventLoop implementation
 // ============================================================================
 

-wxEventLoop *wxEventLoopBase::ms_activeLoop = NULL;

 wxWindowMSW *wxEventLoop::ms_winCritical = NULL;
 
 // ----------------------------------------------------------------------------
 wxWindowMSW *wxEventLoop::ms_winCritical = NULL;
 
 // ----------------------------------------------------------------------------


@@ -127,32 +98,31 @@ bool wxEventLoop::PreProcessMessage(WXMSG *msg)
     wxWindow *wndThis = wxGetWindowFromHWND((WXHWND)hwnd);
     wxWindow *wnd;
 
     wxWindow *wndThis = wxGetWindowFromHWND((WXHWND)hwnd);
     wxWindow *wnd;
 

-       wxWindow* parent = NULL;
-
-       // this might happen if we're in a modeless dialog, or if a wx control has
-       // children which themselves were not created by wx (i.e. wxActiveX control children)
+    // this might happen if we're in a modeless dialog, or if a wx control has
+    // children which themselves were not created by wx (i.e. wxActiveX control children)

     if ( !wndThis )
     {
     if ( !wndThis )
     {

-        while ( hwnd && ::GetWindowLong(hwnd, GWL_STYLE) & WS_CHILD )
+        while ( hwnd && (::GetWindowLong(hwnd, GWL_STYLE) & WS_CHILD ))

         {
             hwnd = ::GetParent(hwnd);
 
         {
             hwnd = ::GetParent(hwnd);
 

-                       // If the control has a wx parent, break and give the parent a chance
-                       // to process the window message
-                       wndThis = wxGetWindowFromHWND((WXHWND)hwnd);
-                       if (wndThis != NULL)
-                               break;
+            // If the control has a wx parent, break and give the parent a chance
+            // to process the window message
+            wndThis = wxGetWindowFromHWND((WXHWND)hwnd);
+            if (wndThis != NULL)
+                break;

         }
 
         }
 

-               if ( !wndThis ){
-                       // this may happen if the event occurred in a standard modeless dialog (the
-                       // only example of which I know of is the find/replace dialog) - then call
-                       // IsDialogMessage() to make TAB navigation in it work
-                       
-                       // NOTE: IsDialogMessage() just eats all the messages (i.e. returns true for
-                       // them) if we call it for the control itself
-                       return hwnd && ::IsDialogMessage(hwnd, msg) != 0;
-               }
+        if ( !wndThis )
+        {
+            // this may happen if the event occurred in a standard modeless dialog (the
+            // only example of which I know of is the find/replace dialog) - then call
+            // IsDialogMessage() to make TAB navigation in it work
+
+            // NOTE: IsDialogMessage() just eats all the messages (i.e. returns true for
+            // them) if we call it for the control itself
+            return hwnd && ::IsDialogMessage(hwnd, msg) != 0;
+        }

     }
 
     if ( !AllowProcessing(wndThis) )
     }
 
     if ( !AllowProcessing(wndThis) )


@@ -208,7 +178,7 @@ bool wxEventLoop::PreProcessMessage(WXMSG *msg)
             if ( wnd->MSWProcessMessage((WXMSG *)msg) )
                 return true;
         }
             if ( wnd->MSWProcessMessage((WXMSG *)msg) )
                 return true;
         }

-        
+

         // Stop at first top level window (as per comment above).
         // If we don't do this, pressing ESC on a modal dialog shown as child of a modal
         // dialog with wxID_CANCEL will cause the parent dialog to be closed, for example
         // Stop at first top level window (as per comment above).
         // If we don't do this, pressing ESC on a modal dialog shown as child of a modal
         // dialog with wxID_CANCEL will cause the parent dialog to be closed, for example


@@ -224,111 +194,19 @@ bool wxEventLoop::PreProcessMessage(WXMSG *msg)
 // wxEventLoop running and exiting
 // ----------------------------------------------------------------------------
 
 // wxEventLoop running and exiting
 // ----------------------------------------------------------------------------
 

-bool wxEventLoop::IsRunning() const
-{
-    return ms_activeLoop == this;
-}
+// ----------------------------------------------------------------------------
+// wxEventLoopManual customization
+// ----------------------------------------------------------------------------

 
 

-int wxEventLoop::Run()
+void wxEventLoop::OnNextIteration()

 {
 {

-    // event loops are not recursive, you need to create another loop!
-    wxCHECK_MSG( !IsRunning(), -1, _T("can't reenter a message loop") );
-
-    // ProcessIdle() and Dispatch() below may throw so the code here should
-    // be exception-safe, hence we must use local objects for all actions we
-    // should undo
-    wxEventLoopActivator activate(&ms_activeLoop, this);
-
-    // we must ensure that OnExit() is called even if an exception is thrown
-    // from inside Dispatch() but we must call it from Exit() in normal
-    // situations because it is supposed to be called synchronously,
-    // wxModalEventLoop depends on this (so we can't just use ON_BLOCK_EXIT or
-    // something similar here)
-#if wxUSE_EXCEPTIONS
-    for ( ;; )
-    {
-        try
-        {
-#endif // wxUSE_EXCEPTIONS
-
-            // this is the event loop itself
-            for ( ;; )
-            {
-                #if wxUSE_THREADS
-                    wxMutexGuiLeaveOrEnter();
-                #endif // wxUSE_THREADS
-
-                // generate and process idle events for as long as we don't
-                // have anything else to do
-                while ( !Pending() && (wxTheApp && wxTheApp->ProcessIdle()) )
-                    ;
-
-                // if the "should exit" flag is set, the loop should terminate
-                // but not before processing any remaining messages so while
-                // Pending() returns true, do process them
-                if ( m_shouldExit )
-                {
-                    while ( Pending() )
-                        Dispatch();
-
-                    break;
-                }
-
-                // a message came or no more idle processing to do, sit in
-                // Dispatch() waiting for the next message
-                if ( !Dispatch() )
-                {
-                    // we got WM_QUIT
-                    break;
-                }
-            }
-
-#if wxUSE_EXCEPTIONS
-            // exit the outer loop as well
-            break;
-        }
-        catch ( ... )
-        {
-            try
-            {
-                if ( !wxTheApp || !wxTheApp->OnExceptionInMainLoop() )
-                {
-                    OnExit();
-                    break;
-                }
-                //else: continue running the event loop
-            }
-            catch ( ... )
-            {
-                // OnException() throwed, possibly rethrowing the same
-                // exception again: very good, but we still need OnExit() to
-                // be called
-                OnExit();
-                throw;
-            }
-        }
-    }
-#endif // wxUSE_EXCEPTIONS
-
-    return m_exitcode;
+#if wxUSE_THREADS
+    wxMutexGuiLeaveOrEnter();
+#endif // wxUSE_THREADS

 }
 
 }
 

-void wxEventLoop::Exit(int rc)
+void wxEventLoop::WakeUp()

 {
 {

-    wxCHECK_RET( IsRunning(), _T("can't call Exit() if not running") );
-
-    m_exitcode = rc;
-    m_shouldExit = true;
-
-    OnExit();
-
-    // all we have to do to exit from the loop is to (maybe) wake it up so that
-    // it can notice that Exit() had been called
-    //
-    // in particular, we do *not* use PostQuitMessage() here because we're not
-    // sure that WM_QUIT is going to be processed by the correct event loop: it
-    // is possible that another one is started before this one has a chance to
-    // process WM_QUIT

     ::PostMessage(NULL, WM_NULL, 0, 0);
 }
 
     ::PostMessage(NULL, WM_NULL, 0, 0);
 }