Don't change file access time implicitly when setting it explicitly.

[wxWidgets.git] / tests / intl / intltest.cpp

diff --git a/tests/intl/intltest.cpp b/tests/intl/intltest.cpp
index d84cda86f735026fe9a8bc09cb67061b26b391f8..094d6bedf54eb968a9caa3f1883a45d4076efaf7 100644 (file)
--- a/tests/intl/intltest.cpp
+++ b/tests/intl/intltest.cpp
@@ -41,12 +41,14 @@ private:
     CPPUNIT_TEST_SUITE( IntlTestCase );
         CPPUNIT_TEST( Domain );
         CPPUNIT_TEST( Headers );
-        CPPUNIT_TEST( DateTimeFmt );
+        CPPUNIT_TEST( DateTimeFmtFrench );
+        CPPUNIT_TEST( DateTimeFmtC );
     CPPUNIT_TEST_SUITE_END();
 
     void Domain();
     void Headers();
-    void DateTimeFmt();
+    void DateTimeFmtFrench();
+    void DateTimeFmtC();
 
     wxLocale *m_locale;
 
@@ -123,43 +125,83 @@ void IntlTestCase::Headers()
     CPPUNIT_ASSERT_EQUAL( "", m_locale->GetHeaderValue("X-Not-Here") );
 }
 
-static void CompareFormats(const wxString& expected, wxString actual)
+static wxString
+NormalizeFormat(const wxString& fmtOrig)
 {
-    if ( actual.empty() )
-    {
-        // this means that GetInfo() failed which can happen, just ignore
-        return;
-    }
+    wxString fmt(fmtOrig);
 
 #ifdef __GLIBC__
     // glibc uses some extensions in its formats which we need to convert to
     // standard form
-    actual.Replace("%T", "%H:%M:%S");
-    actual.Replace("%e", "%d");
+    fmt.Replace("%T", "%H:%M:%S");
+    fmt.Replace("%e", "%d");
 #endif // __GLIBC__
 
-    CPPUNIT_ASSERT_EQUAL( expected, actual );
+    return fmt;
 }
 
-void IntlTestCase::DateTimeFmt()
+#define WX_ASSERT_EQUAL_FORMAT(msg, expected, actual) \
+    if ( !actual.empty() ) \
+        CPPUNIT_ASSERT_EQUAL_MESSAGE(msg, expected, NormalizeFormat(actual))
+
+void IntlTestCase::DateTimeFmtFrench()
 {
     if ( !m_locale )
         return;
 
-    CompareFormats( "%d.%m.%Y", m_locale->GetInfo(wxLOCALE_SHORT_DATE_FMT) );
-    CompareFormats( "%a %d %b %Y", m_locale->GetInfo(wxLOCALE_LONG_DATE_FMT) );
-    CompareFormats( "%a %d %b %Y %H:%M:%S %Z",
+#ifdef __GLIBC__
+    // glibc also uses dots for French locale separator for some reason (the
+    // standard format uses slashes)
+    static const char *FRENCH_DATE_FMT = "%d.%m.%Y";
+    static const char *FRENCH_LONG_DATE_FMT = "%a %d %b %Y";
+    static const char *FRENCH_DATE_TIME_FMT = "%a %d %b %Y %H:%M:%S %Z";
+#else
+    static const char *FRENCH_DATE_FMT = "%d/%m/%Y";
+    static const char *FRENCH_LONG_DATE_FMT = "%A %d %B %Y";
+#ifdef __WXOSX__
+    static const char *FRENCH_DATE_TIME_FMT = "%A %d %B %Y %H:%M:%S";
+#else
+    static const char *FRENCH_DATE_TIME_FMT = "%d/%m/%Y %H:%M:%S";
+#endif
+#endif
+
+    WX_ASSERT_EQUAL_FORMAT( "French short date", FRENCH_DATE_FMT,
+                   m_locale->GetInfo(wxLOCALE_SHORT_DATE_FMT) );
+    WX_ASSERT_EQUAL_FORMAT( "French long date", FRENCH_LONG_DATE_FMT,
+                    m_locale->GetInfo(wxLOCALE_LONG_DATE_FMT) );
+    WX_ASSERT_EQUAL_FORMAT( "French date and time", FRENCH_DATE_TIME_FMT,
                     m_locale->GetInfo(wxLOCALE_DATE_TIME_FMT) );
-    CompareFormats( "%H:%M:%S", m_locale->GetInfo(wxLOCALE_TIME_FMT) );
+    WX_ASSERT_EQUAL_FORMAT( "French time", "%H:%M:%S",
+                    m_locale->GetInfo(wxLOCALE_TIME_FMT) );
+}
+
+void IntlTestCase::DateTimeFmtC()
+{
+    // again, glibc uses different defaults
+#ifdef __GLIBC__
+    static const char *C_DATE_FMT = "%m/%d/%y";
+    static const char *C_LONG_DATE_FMT = "%a %b %d %Y";
+    static const char *C_DATE_TIME_FMT = "%a %b %d %H:%M:%S %Y";
+#else
+    static const char *C_DATE_FMT = "%d/%m/%Y";
+    static const char *C_LONG_DATE_FMT = "%A %d %B %Y";
+#ifdef __WXOSX__
+    static const char *C_DATE_TIME_FMT = "%A %d %B %Y %H:%M:%S";
+#else
+    static const char *C_DATE_TIME_FMT = "%d/%m/%Y %H:%M:%S";
+#endif
+#endif
 
-    // also test for "C" locale
     setlocale(LC_ALL, "C");
 
-    CompareFormats( "%m/%d/%y", m_locale->GetInfo(wxLOCALE_SHORT_DATE_FMT) );
-    CompareFormats( "%a %b %d %Y", m_locale->GetInfo(wxLOCALE_LONG_DATE_FMT) );
-    CompareFormats( "%a %b %d %H:%M:%S %Y",
+    WX_ASSERT_EQUAL_FORMAT( "C short date", C_DATE_FMT,
+                    m_locale->GetInfo(wxLOCALE_SHORT_DATE_FMT) );
+    WX_ASSERT_EQUAL_FORMAT( "C long date", C_LONG_DATE_FMT,
+                    m_locale->GetInfo(wxLOCALE_LONG_DATE_FMT) );
+    WX_ASSERT_EQUAL_FORMAT( "C date and time", C_DATE_TIME_FMT,
                     m_locale->GetInfo(wxLOCALE_DATE_TIME_FMT) );
-    CompareFormats( "%H:%M:%S", m_locale->GetInfo(wxLOCALE_TIME_FMT) );
+    WX_ASSERT_EQUAL_FORMAT( "C time", "%H:%M:%S",
+                    m_locale->GetInfo(wxLOCALE_TIME_FMT) );
 }
 
 #endif // wxUSE_INTL