fix warnings about parameters shadowing member variables

[wxWidgets.git] / src / mgl / pen.cpp

diff --git a/src/mgl/pen.cpp b/src/mgl/pen.cpp
index f4a878aefbd0ce09c5c0d7804891b964cb6a1909..83ad3603dabefe5d3b30f243e1b5c0199a1d2bb1 100644 (file)
--- a/src/mgl/pen.cpp
+++ b/src/mgl/pen.cpp
@@ -1,5 +1,5 @@
 /////////////////////////////////////////////////////////////////////////////
-// Name:        pen.cpp
+// Name:        src/mgl/pen.cpp
 // Purpose:
 // Author:      Vaclav Slavik
 // Id:          $Id$
@@ -15,8 +15,12 @@
 #endif
 
 #include "wx/pen.h"
-#include "wx/bitmap.h"
-#include "wx/colour.h"
+
+#ifndef WX_PRECOMP
+    #include "wx/bitmap.h"
+    #include "wx/colour.h"
+#endif
+
 #include "wx/mgl/private.h"
 
 //-----------------------------------------------------------------------------
@@ -25,21 +29,37 @@
 
 class wxPenRefData: public wxObjectRefData
 {
-    public:
-        wxPenRefData();
-        wxPenRefData(const wxPenRefData& data);
-
-        int            m_width;
-        int            m_style;
-        wxColour       m_colour;
-        wxBitmap       m_stipple;
-        pixpattern24_t m_pixPattern;
-
-        // not used by wxMGL, but we want to preserve values
-        int            m_joinStyle;
-        int            m_capStyle;
-        int            m_countDashes;
-        wxDash        *m_dash;
+public:
+    wxPenRefData();
+    wxPenRefData(const wxPenRefData& data);
+
+    bool operator==(const wxPenRefData& data) const
+    {
+        // we intentionally don't compare m_hPen fields here
+        return m_style == data.m_style &&
+               m_width == data.m_width &&
+               memcmp(&m_pixPattern,
+                      &data.m_pixPattern, sizeof(m_pixPattern)) == 0 &&
+               m_capStyle == data.m_capStyle &&
+               m_joinStyle == data.m_joinStyle &&
+               m_colour == data.m_colour &&
+               (m_style != wxSTIPPLE || m_stipple.IsSameAs(data.m_stipple)) &&
+               (m_style != wxUSER_DASH ||
+                (m_dash == data.m_dash &&
+                    memcmp(m_dash, data.m_dash, m_countDashes*sizeof(wxDash)) == 0));
+    }
+
+    int            m_width;
+    int            m_style;
+    wxColour       m_colour;
+    wxBitmap       m_stipple;
+    pixpattern24_t m_pixPattern;
+
+    // not used by wxMGL, but we want to preserve values
+    int            m_joinStyle;
+    int            m_capStyle;
+    int            m_countDashes;
+    wxDash        *m_dash;
 };
 
 wxPenRefData::wxPenRefData()
@@ -93,7 +113,7 @@ wxPen::wxPen(const wxColour &colour, int width, int style)
 wxPen::wxPen(const wxBitmap& stipple, int width)
 {
     wxCHECK_RET( stipple.Ok(), _T("invalid bitmap") );
-    wxCHECK_RET( stipple.GetWidth() == 8 && stipple.GetHeight() == 8, 
+    wxCHECK_RET( stipple.GetWidth() == 8 && stipple.GetHeight() == 8,
                   _T("stipple bitmap must be 8x8") );
 
     m_refData = new wxPenRefData();
@@ -103,21 +123,13 @@ wxPen::wxPen(const wxBitmap& stipple, int width)
     wxBitmapToPixPattern(stipple, &(M_PENDATA->m_pixPattern), NULL);
 }
 
-wxPen::wxPen(const wxPen& pen)
+bool wxPen::operator == (const wxPen& pen) const
 {
-    Ref(pen);
-}
+    if (m_refData == pen.m_refData) return true;
 
-wxPen& wxPen::operator = (const wxPen& pen)
-{
-    if (*this == pen) return (*this);
-    Ref(pen);
-    return *this;
-}
+    if (!m_refData || !pen.m_refData) return false;
 
-bool wxPen::operator == (const wxPen& pen) const
-{
-    return m_refData == pen.m_refData;
+    return ( *(wxPenRefData*)m_refData == *(wxPenRefData*)pen.m_refData );
 }
 
 bool wxPen::operator != (const wxPen& pen) const
@@ -138,7 +150,7 @@ void wxPen::SetDashes(int number_of_dashes, const wxDash *dash)
     M_PENDATA->m_dash = (wxDash *)dash; /* TODO */
 }
 
-void wxPen::SetColour(int red, int green, int blue)
+void wxPen::SetColour(unsigned char red, unsigned char green, unsigned char blue)
 {
     AllocExclusive();
     M_PENDATA->m_colour.Set(red, green, blue);
@@ -165,7 +177,7 @@ void wxPen::SetStyle(int style)
 void wxPen::SetStipple(const wxBitmap& stipple)
 {
     wxCHECK_RET( stipple.Ok(), _T("invalid bitmap") );
-    wxCHECK_RET( stipple.GetWidth() == 8 && stipple.GetHeight() == 8, 
+    wxCHECK_RET( stipple.GetWidth() == 8 && stipple.GetHeight() == 8,
                   _T("stipple bitmap must be 8x8") );
 
     AllocExclusive();
@@ -179,20 +191,20 @@ void wxPen::SetWidth(int width)
     M_PENDATA->m_width = width;
 }
 
-int wxPen::GetDashes(wxDash **ptr) const 
+int wxPen::GetDashes(wxDash **ptr) const
 {
-     *ptr = (M_PENDATA ? (wxDash*)M_PENDATA->m_dash : (wxDash*) NULL); 
+     *ptr = (M_PENDATA ? (wxDash*)M_PENDATA->m_dash : (wxDash*) NULL);
      return (M_PENDATA ? M_PENDATA->m_countDashes : 0);
 }
 
-int wxPen::GetDashCount() const 
-{ 
-    return (M_PENDATA->m_countDashes); 
+int wxPen::GetDashCount() const
+{
+    return (M_PENDATA->m_countDashes);
 }
 
-wxDash* wxPen::GetDash() const 
-{ 
-    return (wxDash*)M_PENDATA->m_dash; 
+wxDash* wxPen::GetDash() const
+{
+    return (wxDash*)M_PENDATA->m_dash;
 }
 
 int wxPen::GetCap() const
@@ -245,7 +257,7 @@ void* wxPen::GetPixPattern() const
 }
 
 
-bool wxPen::Ok() const
+bool wxPen::IsOk() const
 {
     return (m_refData != NULL);
 }
@@ -259,4 +271,3 @@ wxObjectRefData *wxPen::CloneRefData(const wxObjectRefData *data) const
 {
     return new wxPenRefData(*(wxPenRefData *)data);
 }
-