fixing modal dialog quit after nested message box problem

[wxWidgets.git] / src / common / list.cpp

diff --git a/src/common/list.cpp b/src/common/list.cpp
index 3d8a0ef389f96c8012ba9cab7ae39f1ee5a9eeac..4bdefdba206de4c34ba73b947f251673b6eb7b47 100644 (file)
--- a/src/common/list.cpp
+++ b/src/common/list.cpp
@@ -30,6 +30,7 @@
 
 #ifndef WX_PRECOMP
     #include "wx/list.h"
+    #include "wx/crt.h"
 #endif
 
 #if !wxUSE_STL
@@ -53,7 +54,7 @@ bool wxListKey::operator==(wxListKeyValue value) const
             // by not putting return here...
 
         case wxKEY_STRING:
-            return wxStrcmp(m_key.string, value.string) == 0;
+            return *m_key.string == *value.string;
 
         case wxKEY_INTEGER:
             return m_key.integer == value.integer;
@@ -84,7 +85,7 @@ wxNodeBase::wxNodeBase(wxListBase *list,
 
         case wxKEY_STRING:
             // to be free()d later
-            m_key.string = wxStrdup(key.GetString());
+            m_key.string = new wxString(key.GetString());
             break;
 
         default:
@@ -107,7 +108,7 @@ wxNodeBase::~wxNodeBase()
     {
         if ( m_list->m_keyType == wxKEY_STRING )
         {
-            free(m_key.string);
+            delete m_key.string;
         }
 
         m_list->DetachNode(this);
@@ -140,7 +141,7 @@ int wxNodeBase::IndexOf() const
 void wxListBase::Init(wxKeyType keyType)
 {
   m_nodeFirst =
-  m_nodeLast = (wxNodeBase *) NULL;
+  m_nodeLast = NULL;
   m_count = 0;
   m_destroy = false;
   m_keyType = keyType;
@@ -164,7 +165,7 @@ void wxListBase::DoCopy(const wxListBase& list)
     m_destroy = list.m_destroy;
     m_keyType = list.m_keyType;
     m_nodeFirst =
-    m_nodeLast = (wxNodeBase *) NULL;
+    m_nodeLast = NULL;
 
     switch (m_keyType)
     {
@@ -235,12 +236,12 @@ wxNodeBase *wxListBase::AppendCommon(wxNodeBase *node)
 wxNodeBase *wxListBase::Append(void *object)
 {
     // all objects in a keyed list should have a key
-    wxCHECK_MSG( m_keyType == wxKEY_NONE, (wxNodeBase *)NULL,
+    wxCHECK_MSG( m_keyType == wxKEY_NONE, NULL,
                  wxT("need a key for the object to append") );
 
     // we use wxDefaultListKey even though it is the default parameter value
     // because gcc under Mac OS X seems to miscompile this call otherwise
-    wxNodeBase *node = CreateNode(m_nodeLast, (wxNodeBase *)NULL, object,
+    wxNodeBase *node = CreateNode(m_nodeLast, NULL, object,
                                   wxDefaultListKey);
 
     return AppendCommon(node);
@@ -250,31 +251,31 @@ wxNodeBase *wxListBase::Append(long key, void *object)
 {
     wxCHECK_MSG( (m_keyType == wxKEY_INTEGER) ||
                  (m_keyType == wxKEY_NONE && m_count == 0),
-                 (wxNodeBase *)NULL,
+                 NULL,
                  wxT("can't append object with numeric key to this list") );
 
-    wxNodeBase *node = CreateNode(m_nodeLast, (wxNodeBase *)NULL, object, key);
+    wxNodeBase *node = CreateNode(m_nodeLast, NULL, object, key);
     return AppendCommon(node);
 }
 
-wxNodeBase *wxListBase::Append (const wxChar *key, void *object)
+wxNodeBase *wxListBase::Append (const wxString& key, void *object)
 {
     wxCHECK_MSG( (m_keyType == wxKEY_STRING) ||
                  (m_keyType == wxKEY_NONE && m_count == 0),
-                 (wxNodeBase *)NULL,
+                 NULL,
                  wxT("can't append object with string key to this list") );
 
-    wxNodeBase *node = CreateNode(m_nodeLast, (wxNodeBase *)NULL, object, key);
+    wxNodeBase *node = CreateNode(m_nodeLast, NULL, object, key);
     return AppendCommon(node);
 }
 
 wxNodeBase *wxListBase::Insert(wxNodeBase *position, void *object)
 {
     // all objects in a keyed list should have a key
-    wxCHECK_MSG( m_keyType == wxKEY_NONE, (wxNodeBase *)NULL,
+    wxCHECK_MSG( m_keyType == wxKEY_NONE, NULL,
                  wxT("need a key for the object to insert") );
 
-    wxCHECK_MSG( !position || position->m_list == this, (wxNodeBase *)NULL,
+    wxCHECK_MSG( !position || position->m_list == this, NULL,
                  wxT("can't insert before a node from another list") );
 
     // previous and next node for the node being inserted
@@ -287,7 +288,7 @@ wxNodeBase *wxListBase::Insert(wxNodeBase *position, void *object)
     else
     {
         // inserting in the beginning of the list
-        prev = (wxNodeBase *)NULL;
+        prev = NULL;
         next = m_nodeFirst;
     }
 
@@ -320,7 +321,7 @@ wxNodeBase *wxListBase::Item(size_t n) const
 
     wxFAIL_MSG( wxT("invalid index in wxListBase::Item") );
 
-    return (wxNodeBase *)NULL;
+    return NULL;
 }
 
 wxNodeBase *wxListBase::Find(const wxListKey& key) const
@@ -337,7 +338,7 @@ wxNodeBase *wxListBase::Find(const wxListKey& key) const
     }
 
     // not found
-    return (wxNodeBase *)NULL;
+    return NULL;
 }
 
 wxNodeBase *wxListBase::Find(const void *object) const
@@ -349,7 +350,7 @@ wxNodeBase *wxListBase::Find(const void *object) const
     }
 
     // not found
-    return (wxNodeBase *)NULL;
+    return NULL;
 }
 
 int wxListBase::IndexOf(void *object) const
@@ -436,7 +437,7 @@ void wxListBase::Clear()
     }
 
     m_nodeFirst =
-    m_nodeLast = (wxNodeBase *)NULL;
+    m_nodeLast = NULL;
 
     m_count = 0;
 }
@@ -457,7 +458,7 @@ void *wxListBase::FirstThat(wxListIterateFunction F)
             return current->GetData();
     }
 
-    return (wxNodeBase *)NULL;
+    return NULL;
 }
 
 void *wxListBase::LastThat(wxListIterateFunction F)
@@ -468,7 +469,7 @@ void *wxListBase::LastThat(wxListIterateFunction F)
             return current->GetData();
     }
 
-    return (wxNodeBase *)NULL;
+    return NULL;
 }
 
 // (stefan.hammes@urz.uni-heidelberg.de)
@@ -573,8 +574,6 @@ void wxListBase::DeleteNodes(wxNodeBase* first, wxNodeBase* last)
 // wxList (a.k.a. wxObjectList)
 // -----------------------------------------------------------------------------
 
-IMPLEMENT_DYNAMIC_CLASS(wxList, wxObject)
-
 wxList::wxList( int key_type )
     : wxObjectList( (wxKeyType)key_type )
 {
@@ -595,8 +594,6 @@ static inline wxChar* MYcopystring(const wxChar* s)
     return wxStrcpy(copy, s);
 }
 
-IMPLEMENT_DYNAMIC_CLASS(wxStringList, wxObject)
-
 // instead of WX_DEFINE_LIST(wxStringListBase) we define this function
 // ourselves
 void wxStringListNode::DeleteData()
@@ -704,9 +701,13 @@ bool wxStringList::Member(const wxChar *s) const
 }
 
 #ifdef __WXWINCE__
-extern "C" int __cdecl
+extern "C"
+{
+static int __cdecl
 #else
-extern "C" int LINKAGEMODE
+extern "C"
+{
+static int LINKAGEMODE
 #endif
 
 wx_comparestrings(const void *arg1, const void *arg2)
@@ -717,6 +718,8 @@ wx_comparestrings(const void *arg1, const void *arg2)
   return wxStrcmp (*s1, *s2);
 }
 
+}   // end of extern "C" (required because of GCC Bug c++/33078
+
 // Sort a list of strings - deallocates old nodes, allocates new
 void wxStringList::Sort()
 {
@@ -763,4 +766,6 @@ void _WX_LIST_HELPER_wxStringListBase::DeleteFunction( wxString WXUNUSED(X) )
 {
 }
 
+wxStringListBase::BaseListType wxStringListBase::EmptyList;
+
 #endif // !wxUSE_STL