Commit [ 1592301 ] [wxgtk] Fix wxCollapsiblePane to be flicker-free

[wxWidgets.git] / src / gtk / combobox.cpp

diff --git a/src/gtk/combobox.cpp b/src/gtk/combobox.cpp
index 40e9370a104bf907598e10f4247c08695b9d903c..936f383894f0b5d74be07367d6bf19a8f75b2031 100644 (file)
--- a/src/gtk/combobox.cpp
+++ b/src/gtk/combobox.cpp
@@ -1,5 +1,5 @@
 /////////////////////////////////////////////////////////////////////////////
 /////////////////////////////////////////////////////////////////////////////

-// Name:        combobox.cpp
+// Name:        src/gtk/combobox.cpp

 // Purpose:
 // Author:      Robert Roebling
 // Id:          $Id$
 // Purpose:
 // Author:      Robert Roebling
 // Id:          $Id$


@@ -7,68 +7,169 @@
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 

-#ifdef __GNUG__
-#pragma implementation "combobox.h"
-#endif
-
-#include "wx/combobox.h"
+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"

 
 #if wxUSE_COMBOBOX
 
 
 #if wxUSE_COMBOBOX
 

-#include "wx/settings.h"
-#include "wx/intl.h"
-
-#include <gdk/gdk.h>
-#include <gtk/gtk.h>
+#include "wx/combobox.h"

 
 

-//-----------------------------------------------------------------------------
-// idle system
-//-----------------------------------------------------------------------------
+#ifndef WX_PRECOMP
+    #include "wx/intl.h"
+    #include "wx/settings.h"
+    #include "wx/textctrl.h"    // for wxEVT_COMMAND_TEXT_UPDATED
+    #include "wx/arrstr.h"
+#endif

 
 

-extern void wxapp_install_idle_handler();
-extern bool g_isIdle;
+// We use GtkCombo which has been deprecated since GTK+ 2.3.0
+// in favour of GtkComboBox for <GTK2.4 runtime
+// We also use GtkList
+#ifdef GTK_DISABLE_DEPRECATED
+#undef GTK_DISABLE_DEPRECATED
+#endif
+#include "wx/gtk/private.h"

 
 //-----------------------------------------------------------------------------
 // data
 //-----------------------------------------------------------------------------
 
 extern bool   g_blockEventsOnDrag;
 
 //-----------------------------------------------------------------------------
 // data
 //-----------------------------------------------------------------------------
 
 extern bool   g_blockEventsOnDrag;

+static int    g_SelectionBeforePopup = wxID_NONE; // this means the popup is hidden

 
 //-----------------------------------------------------------------------------
 
 //-----------------------------------------------------------------------------

-// "select"
+//  "changed" - typing and list item matches get changed, select-child
+//              if it doesn't match an item then just get a single changed

 //-----------------------------------------------------------------------------
 
 //-----------------------------------------------------------------------------
 

+extern "C" {

 static void
 static void

-gtk_combo_clicked_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )
+gtkcombo_text_changed_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )

 {
     if (g_isIdle) wxapp_install_idle_handler();
 
 {
     if (g_isIdle) wxapp_install_idle_handler();
 

-    if (!combo->m_hasVMT) return;
-
-    if (g_blockEventsOnDrag) return;
-
-    if (combo->m_alreadySent)
+    if (combo->m_ignoreNextUpdate)

     {
     {

-        combo->m_alreadySent = FALSE;
+        combo->m_ignoreNextUpdate = false;

         return;
     }
 
         return;
     }
 

-    combo->m_alreadySent = TRUE;
+    if (!combo->m_hasVMT) return;

 
 

-    wxCommandEvent event( wxEVT_COMMAND_COMBOBOX_SELECTED, combo->GetId() );
-    event.SetInt( combo->GetSelection() );
-    event.SetString( combo->GetStringSelection() );
+    wxCommandEvent event( wxEVT_COMMAND_TEXT_UPDATED, combo->GetId() );
+    event.SetString( combo->GetValue() );

     event.SetEventObject( combo );
     event.SetEventObject( combo );

-

     combo->GetEventHandler()->ProcessEvent( event );
 }
     combo->GetEventHandler()->ProcessEvent( event );
 }

+}
+
+extern "C" {
+static void
+gtkcombo_dummy_callback(GtkEntry *WXUNUSED(entry), GtkCombo *WXUNUSED(combo))
+{
+}
+}
+
+extern "C" {
+static void
+gtkcombo_popup_hide_callback(GtkCombo *WXUNUSED(gtk_combo), wxComboBox *combo)
+{
+    // when the popup is hidden, throw a SELECTED event only if the combobox
+    // selection changed.
+    const int curSelection = combo->GetCurrentSelection();
+
+    const bool hasChanged = curSelection != g_SelectionBeforePopup;
+
+    // reset the selection flag to value meaning that it is hidden and do it
+    // now, before generating the events, so that GetSelection() returns the
+    // new value from the event handler
+    g_SelectionBeforePopup = wxID_NONE;
+
+    if ( hasChanged )
+    {
+        wxCommandEvent event( wxEVT_COMMAND_COMBOBOX_SELECTED, combo->GetId() );
+        event.SetInt( curSelection );
+        event.SetString( combo->GetStringSelection() );
+        event.SetEventObject( combo );
+        combo->GetEventHandler()->ProcessEvent( event );
+
+        // for consistency with the other ports, send TEXT event
+        wxCommandEvent event2( wxEVT_COMMAND_TEXT_UPDATED, combo->GetId() );
+        event2.SetString( combo->GetStringSelection() );
+        event2.SetEventObject( combo );
+        combo->GetEventHandler()->ProcessEvent( event2 );
+    }
+}
+}
+
+extern "C" {
+static void
+gtkcombo_popup_show_callback(GtkCombo *WXUNUSED(gtk_combo), wxComboBox *combo)
+{
+    // store the combobox selection value before the popup is shown
+    g_SelectionBeforePopup = combo->GetCurrentSelection();
+}
+}

 
 //-----------------------------------------------------------------------------
 
 //-----------------------------------------------------------------------------

-//  "changed"
+// "select-child" - click/cursor get select-child, changed, select-child

 //-----------------------------------------------------------------------------
 
 //-----------------------------------------------------------------------------
 

+extern "C" {
+static void
+gtkcombo_combo_select_child_callback( GtkList *WXUNUSED(list), GtkWidget *WXUNUSED(widget), wxComboBox *combo )
+{
+    if (g_isIdle) wxapp_install_idle_handler();
+
+    if (!combo->m_hasVMT) return;
+
+    if (g_blockEventsOnDrag) return;
+
+    int curSelection = combo->GetCurrentSelection();
+
+    if (combo->m_prevSelection == curSelection) return;
+
+    GtkWidget *list = GTK_COMBO(combo->m_widget)->list;
+    gtk_list_unselect_item( GTK_LIST(list), combo->m_prevSelection );
+
+    combo->m_prevSelection = curSelection;
+
+    // Quickly set the value of the combo box
+    // as GTK+ does that only AFTER the event
+    // is sent.
+    g_signal_handlers_disconnect_by_func (GTK_COMBO (combo->GetHandle())->entry,
+                                          (gpointer) gtkcombo_text_changed_callback,
+                                          combo);
+    combo->SetValue( combo->GetStringSelection() );
+    g_signal_connect_after (GTK_COMBO (combo->GetHandle())->entry, "changed",
+                            G_CALLBACK (gtkcombo_text_changed_callback), combo);
+
+    // throw a SELECTED event only if the combobox popup is hidden (wxID_NONE)
+    // because when combobox popup is shown, gtkcombo_combo_select_child_callback is
+    // called each times the mouse is over an item with a pressed button so a lot
+    // of SELECTED event could be generated if the user keep the mouse button down
+    // and select other items ...
+    if (g_SelectionBeforePopup == wxID_NONE)
+    {
+        wxCommandEvent event( wxEVT_COMMAND_COMBOBOX_SELECTED, combo->GetId() );
+        event.SetInt( curSelection );
+        event.SetString( combo->GetStringSelection() );
+        event.SetEventObject( combo );
+        combo->GetEventHandler()->ProcessEvent( event );
+
+        // for consistency with the other ports, don't generate text update
+        // events while the user is browsing the combobox neither
+        wxCommandEvent event2( wxEVT_COMMAND_TEXT_UPDATED, combo->GetId() );
+        event2.SetString( combo->GetValue() );
+        event2.SetEventObject( combo );
+        combo->GetEventHandler()->ProcessEvent( event2 );
+    }
+}
+}
+
+#ifdef __WXGTK24__
+extern "C" {

 static void
 static void

-gtk_text_changed_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )
+gtkcombobox_text_changed_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )

 {
     if (g_isIdle) wxapp_install_idle_handler();
 
 {
     if (g_isIdle) wxapp_install_idle_handler();
 


@@ -79,6 +180,27 @@ gtk_text_changed_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )
     event.SetEventObject( combo );
     combo->GetEventHandler()->ProcessEvent( event );
 }
     event.SetEventObject( combo );
     combo->GetEventHandler()->ProcessEvent( event );
 }

+}
+
+extern "C" {
+static void
+gtkcombobox_changed_callback( GtkWidget *WXUNUSED(widget), wxComboBox *combo )
+{
+    if (g_isIdle) wxapp_install_idle_handler();
+
+    if (!combo->m_hasVMT) return;
+
+    if (combo->GetSelection() == -1)
+        return;
+
+    wxCommandEvent event( wxEVT_COMMAND_COMBOBOX_SELECTED, combo->GetId() );
+    event.SetInt( combo->GetSelection() );
+    event.SetString( combo->GetStringSelection() );
+    event.SetEventObject( combo );
+    combo->GetEventHandler()->ProcessEvent( event );
+}
+}
+#endif

 
 //-----------------------------------------------------------------------------
 // wxComboBox
 
 //-----------------------------------------------------------------------------
 // wxComboBox


@@ -89,301 +211,619 @@ IMPLEMENT_DYNAMIC_CLASS(wxComboBox,wxControl)
 BEGIN_EVENT_TABLE(wxComboBox, wxControl)
     EVT_SIZE(wxComboBox::OnSize)
     EVT_CHAR(wxComboBox::OnChar)
 BEGIN_EVENT_TABLE(wxComboBox, wxControl)
     EVT_SIZE(wxComboBox::OnSize)
     EVT_CHAR(wxComboBox::OnChar)

+
+    EVT_MENU(wxID_CUT, wxComboBox::OnCut)
+    EVT_MENU(wxID_COPY, wxComboBox::OnCopy)
+    EVT_MENU(wxID_PASTE, wxComboBox::OnPaste)
+    EVT_MENU(wxID_UNDO, wxComboBox::OnUndo)
+    EVT_MENU(wxID_REDO, wxComboBox::OnRedo)
+    EVT_MENU(wxID_CLEAR, wxComboBox::OnDelete)
+    EVT_MENU(wxID_SELECTALL, wxComboBox::OnSelectAll)
+
+    EVT_UPDATE_UI(wxID_CUT, wxComboBox::OnUpdateCut)
+    EVT_UPDATE_UI(wxID_COPY, wxComboBox::OnUpdateCopy)
+    EVT_UPDATE_UI(wxID_PASTE, wxComboBox::OnUpdatePaste)
+    EVT_UPDATE_UI(wxID_UNDO, wxComboBox::OnUpdateUndo)
+    EVT_UPDATE_UI(wxID_REDO, wxComboBox::OnUpdateRedo)
+    EVT_UPDATE_UI(wxID_CLEAR, wxComboBox::OnUpdateDelete)
+    EVT_UPDATE_UI(wxID_SELECTALL, wxComboBox::OnUpdateSelectAll)

 END_EVENT_TABLE()
 
 END_EVENT_TABLE()
 

+bool wxComboBox::Create( wxWindow *parent, wxWindowID id,
+                         const wxString& value,
+                         const wxPoint& pos, const wxSize& size,
+                         const wxArrayString& choices,
+                         long style, const wxValidator& validator,
+                         const wxString& name )
+{
+    wxCArrayString chs(choices);
+
+    return Create( parent, id, value, pos, size, chs.GetCount(),
+                   chs.GetStrings(), style, validator, name );
+}
+

 bool wxComboBox::Create( wxWindow *parent, wxWindowID id, const wxString& value,
                          const wxPoint& pos, const wxSize& size,
                          int n, const wxString choices[],
                          long style, const wxValidator& validator,
                          const wxString& name )
 {
 bool wxComboBox::Create( wxWindow *parent, wxWindowID id, const wxString& value,
                          const wxPoint& pos, const wxSize& size,
                          int n, const wxString choices[],
                          long style, const wxValidator& validator,
                          const wxString& name )
 {

-    m_alreadySent = FALSE;
-    m_needParent = TRUE;
-    m_acceptsFocus = TRUE;
+    m_ignoreNextUpdate = false;
+    m_needParent = true;
+    m_acceptsFocus = true;
+    m_prevSelection = 0;

 
     if (!PreCreation( parent, pos, size ) ||
         !CreateBase( parent, id, pos, size, style, validator, name ))
     {
         wxFAIL_MSG( wxT("wxComboBox creation failed") );
 
     if (!PreCreation( parent, pos, size ) ||
         !CreateBase( parent, id, pos, size, style, validator, name ))
     {
         wxFAIL_MSG( wxT("wxComboBox creation failed") );

-        return FALSE;
+        return false;

     }
 
     }
 

-    m_widget = gtk_combo_new();
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+    {
+        m_widget = gtk_combo_box_entry_new_text();
+        GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );

 
 

-    // make it more useable
-    gtk_combo_set_use_arrows_always(GTK_COMBO(m_widget), TRUE);
+        gtk_entry_set_editable( GTK_ENTRY( GTK_BIN(m_widget)->child ), TRUE );

 
 

-    GtkWidget *list = GTK_COMBO(m_widget)->list;
+        for (int i = 0; i < n; i++)
+        {
+            gtk_combo_box_append_text( combobox,  wxGTK_CONV( choices[i] ) );

 
 

-    for (int i = 0; i < n; i++)
+            m_clientDataList.Append( (wxObject*)NULL );
+            m_clientObjectList.Append( (wxObject*)NULL );
+        }
+    }
+    else
+#endif

     {
     {

-        /* don't send first event, which GTK sends aways when
-           inserting the first item */
-        m_alreadySent = TRUE;
+        m_widget = gtk_combo_new();
+        GtkCombo* combo = GTK_COMBO(m_widget);

 
 

-        GtkWidget *list_item = gtk_list_item_new_with_label( choices[i].mbc_str() );
+        // Disable GTK's broken events ...
+        g_signal_handler_disconnect (combo->entry, combo->entry_change_id);
+        // ... and add surrogate handler.
+        combo->entry_change_id = g_signal_connect (combo->entry, "changed",
+                                               G_CALLBACK (gtkcombo_dummy_callback),
+                                               combo);

 
 

-        m_clientDataList.Append( (wxObject*)NULL );
-        m_clientObjectList.Append( (wxObject*)NULL );
+        // make it more useable
+        gtk_combo_set_use_arrows_always( GTK_COMBO(m_widget), TRUE );

 
 

-        gtk_container_add( GTK_CONTAINER(list), list_item );
+        // and case-sensitive
+        gtk_combo_set_case_sensitive( GTK_COMBO(m_widget), TRUE );

 
 

-        gtk_signal_connect( GTK_OBJECT(list_item), "select",
-           GTK_SIGNAL_FUNC(gtk_combo_clicked_callback), (gpointer)this );
+        if (style & wxNO_BORDER)
+            g_object_set (combo->entry, "has-frame", FALSE, NULL );

 
 

-        gtk_widget_show( list_item );
+        GtkWidget *list = combo->list;
+
+        for (int i = 0; i < n; i++)
+        {
+            GtkWidget *list_item = gtk_list_item_new_with_label( wxGTK_CONV( choices[i] ) );
+
+            m_clientDataList.Append( (wxObject*)NULL );
+            m_clientObjectList.Append( (wxObject*)NULL );
+
+            gtk_container_add( GTK_CONTAINER(list), list_item );
+
+            gtk_widget_show( list_item );
+        }

     }
 
     }
 

+

     m_parent->DoAddChild( this );
 
     m_parent->DoAddChild( this );
 

-    PostCreation();
+    GtkEntry *entry = NULL;
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+        entry = GTK_ENTRY( GTK_BIN(m_widget)->child );
+    else
+#endif
+        entry = GTK_ENTRY( GTK_COMBO(m_widget)->entry );

 
 

-    ConnectWidget( GTK_COMBO(m_widget)->button );
+    m_focusWidget = GTK_WIDGET( entry );

 
 

-    if (!value.IsNull()) SetValue( value );
+    PostCreation(size);

 
 

-    if (style & wxCB_READONLY)
-        gtk_entry_set_editable( GTK_ENTRY( GTK_COMBO(m_widget)->entry ), FALSE );
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+        ConnectWidget( m_widget );
+    else
+#endif
+        ConnectWidget( GTK_COMBO(m_widget)->button );
+
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+    {
+        gtk_entry_set_text( entry, wxGTK_CONV(value) );

 
 

-    gtk_signal_connect( GTK_OBJECT(GTK_COMBO(m_widget)->entry), "changed",
-      GTK_SIGNAL_FUNC(gtk_text_changed_callback), (gpointer)this);
+        if (style & wxCB_READONLY)
+            gtk_entry_set_editable( entry, FALSE );

 
 

-    wxSize size_best( DoGetBestSize() );
-    wxSize new_size( size );
-    if (new_size.x == -1)
-        new_size.x = size_best.x;
-    if (new_size.y == -1)
-        new_size.y = size_best.y;
-    if (new_size.y > size_best.y)
-        new_size.y = size_best.y;
-    if ((new_size.x != size.x) || (new_size.y != size.y))
-        SetSize( new_size.x, new_size.y );
+        g_signal_connect_after (entry, "changed",
+                            G_CALLBACK (gtkcombobox_text_changed_callback), this);
+
+        g_signal_connect_after (m_widget, "changed",
+                            G_CALLBACK (gtkcombobox_changed_callback), this);
+    }
+    else
+#endif
+    {
+        GtkCombo *combo = GTK_COMBO(m_widget);
+        // MSW's combo box shows the value and the selection is -1
+        gtk_entry_set_text( entry, wxGTK_CONV(value) );
+        gtk_list_unselect_all( GTK_LIST(combo->list) );
+
+        if (style & wxCB_READONLY)
+            gtk_entry_set_editable( entry, FALSE );
+
+        // "show" and "hide" events are generated when user click on the combobox button which popups a list
+        // this list is the "popwin" gtk widget
+        g_signal_connect (GTK_COMBO(combo)->popwin, "hide",
+                      G_CALLBACK (gtkcombo_popup_hide_callback), this);
+        g_signal_connect (GTK_COMBO(combo)->popwin, "show",
+                      G_CALLBACK (gtkcombo_popup_show_callback), this);
+        g_signal_connect_after (combo->list, "select-child",
+                            G_CALLBACK (gtkcombo_combo_select_child_callback),
+                            this);
+        g_signal_connect_after (entry, "changed",
+                            G_CALLBACK (gtkcombo_text_changed_callback), this);
+
+        // This is required for tool bar support
+        // Doesn't currently work
+//        wxSize setsize = GetSize();
+//        gtk_widget_set_size_request( m_widget, setsize.x, setsize.y );
+    }

 
 

-    SetBackgroundColour( wxSystemSettings::GetSystemColour( wxSYS_COLOUR_WINDOW ) );
-    SetForegroundColour( parent->GetForegroundColour() );
+    SetInitialSize(size); // need this too because this is a wxControlWithItems

 
 

-    Show( TRUE );

 
 

-    return TRUE;
+    return true;

 }
 
 wxComboBox::~wxComboBox()
 {
 }
 
 wxComboBox::~wxComboBox()
 {

-    wxNode *node = m_clientObjectList.First();
+    wxList::compatibility_iterator node = m_clientObjectList.GetFirst();

     while (node)
     {
     while (node)
     {

-        wxClientData *cd = (wxClientData*)node->Data();
+        wxClientData *cd = (wxClientData*)node->GetData();

         if (cd) delete cd;
         if (cd) delete cd;

-        node = node->Next();
+        node = node->GetNext();

     }
     m_clientObjectList.Clear();
 
     m_clientDataList.Clear();
 }
 
     }
     m_clientObjectList.Clear();
 
     m_clientDataList.Clear();
 }
 

-void wxComboBox::AppendCommon( const wxString &item )
+void wxComboBox::SetFocus()

 {
 {

-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+    if ( m_hasFocus )
+    {
+        // don't do anything if we already have focus
+        return;
+    }

 
 

-    GtkWidget *list = GTK_COMBO(m_widget)->list;
+    gtk_widget_grab_focus( m_focusWidget );
+}

 
 

-    GtkWidget *list_item = gtk_list_item_new_with_label( item.mbc_str() );
+int wxComboBox::DoAppend( const wxString &item )
+{
+    wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid combobox") );

 
 

-    gtk_container_add( GTK_CONTAINER(list), list_item );
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+    {
+        GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+        gtk_combo_box_append_text( combobox,  wxGTK_CONV( item ) );
+    }
+    else
+#endif
+    {
+        DisableEvents();

 
 

-    gtk_signal_connect( GTK_OBJECT(list_item), "select",
-      GTK_SIGNAL_FUNC(gtk_combo_clicked_callback), (gpointer)this );
+        GtkWidget *list = GTK_COMBO(m_widget)->list;
+        GtkWidget *list_item = gtk_list_item_new_with_label( wxGTK_CONV( item ) );

 
 

-    if (GTK_WIDGET_REALIZED(m_widget))
-    {
-        gtk_widget_realize( list_item );
-        gtk_widget_realize( GTK_BIN(list_item)->child );
+        gtk_container_add( GTK_CONTAINER(list), list_item );

 
 

-        if (m_widgetStyle) ApplyWidgetStyle();
+        if (GTK_WIDGET_REALIZED(m_widget))
+        {
+            gtk_widget_realize( list_item );
+            gtk_widget_realize( GTK_BIN(list_item)->child );
+        }
+
+        // Apply current widget style to the new list_item
+        GtkRcStyle *style = CreateWidgetStyle();
+        if (style)
+        {
+            gtk_widget_modify_style( GTK_WIDGET( list_item ), style );
+            GtkBin *bin = GTK_BIN( list_item );
+            GtkWidget *label = GTK_WIDGET( bin->child );
+            gtk_widget_modify_style( label, style );
+            gtk_rc_style_unref( style );
+        }
+
+        gtk_widget_show( list_item );
+
+        EnableEvents();

     }
 
     }
 

-    gtk_widget_show( list_item );
-}
+    const unsigned int count = GetCount();

 
 

-void wxComboBox::Append( const wxString &item )
-{
-    m_clientDataList.Append( (wxObject*) NULL );
-    m_clientObjectList.Append( (wxObject*) NULL );
+    if ( m_clientDataList.GetCount() < count )
+        m_clientDataList.Append( (wxObject*) NULL );
+    if ( m_clientObjectList.GetCount() < count )
+        m_clientObjectList.Append( (wxObject*) NULL );
+
+    InvalidateBestSize();

 
 

-    AppendCommon( item );
+    return count - 1;

 }
 
 }
 

-void wxComboBox::Append( const wxString &item, void *clientData )
+int wxComboBox::DoInsert(const wxString &item, unsigned int pos)

 {
 {

-    m_clientDataList.Append( (wxObject*) clientData );
-    m_clientObjectList.Append( (wxObject*)NULL );
+    wxCHECK_MSG( !(GetWindowStyle() & wxCB_SORT), -1,
+                    wxT("can't insert into sorted list"));

 
 

-    AppendCommon( item );
-}
+    wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid combobox") );
+    wxCHECK_MSG( IsValidInsert(pos), -1, wxT("invalid index") );

 
 

-void wxComboBox::Append( const wxString &item, wxClientData *clientData )
-{
-    m_clientDataList.Append( (wxObject*) NULL );
-    m_clientObjectList.Append( (wxObject*) clientData );
+    unsigned int count = GetCount();
+
+    if (pos == count)
+        return Append(item);
+
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+    {
+        GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+        gtk_combo_box_insert_text( combobox, pos, wxGTK_CONV( item ) );
+    }
+    else
+#endif
+    {
+        DisableEvents();
+
+        GtkWidget *list = GTK_COMBO(m_widget)->list;
+        GtkWidget *list_item = gtk_list_item_new_with_label( wxGTK_CONV( item ) );
+
+        GList *gitem_list = g_list_alloc ();
+        gitem_list->data = list_item;
+        gtk_list_insert_items( GTK_LIST (list), gitem_list, pos );
+
+        if (GTK_WIDGET_REALIZED(m_widget))
+        {
+            gtk_widget_realize( list_item );
+            gtk_widget_realize( GTK_BIN(list_item)->child );
+
+            ApplyWidgetStyle();
+        }
+
+        gtk_widget_show( list_item );
+
+        EnableEvents();
+    }
+
+    count = GetCount();
+
+    if ( m_clientDataList.GetCount() < count )
+        m_clientDataList.Insert( pos, (wxObject*) NULL );
+    if ( m_clientObjectList.GetCount() < count )
+        m_clientObjectList.Insert( pos, (wxObject*) NULL );
+
+    InvalidateBestSize();

 
 

-    AppendCommon( item );
+    return pos;

 }
 
 }
 

-void wxComboBox::SetClientData( int n, void* clientData )
+void wxComboBox::DoSetItemClientData(unsigned int n, void* clientData)

 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 

-    wxNode *node = m_clientDataList.Nth( n );
+    wxList::compatibility_iterator node = m_clientDataList.Item( n );

     if (!node) return;
 
     node->SetData( (wxObject*) clientData );
 }
 
     if (!node) return;
 
     node->SetData( (wxObject*) clientData );
 }
 

-void* wxComboBox::GetClientData( int n )
+void* wxComboBox::DoGetItemClientData(unsigned int n) const

 {
     wxCHECK_MSG( m_widget != NULL, NULL, wxT("invalid combobox") );
 
 {
     wxCHECK_MSG( m_widget != NULL, NULL, wxT("invalid combobox") );
 

-    wxNode *node = m_clientDataList.Nth( n );
-    if (!node) return NULL;
+    wxList::compatibility_iterator node = m_clientDataList.Item( n );

 
 

-    return node->Data();
+    return node ? node->GetData() : NULL;

 }
 
 }
 

-void wxComboBox::SetClientObject( int n, wxClientData* clientData )
+void wxComboBox::DoSetItemClientObject(unsigned int n, wxClientData* clientData)

 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 

-    wxNode *node = m_clientObjectList.Nth( n );
+    wxList::compatibility_iterator node = m_clientObjectList.Item( n );

     if (!node) return;
 
     if (!node) return;
 

-    wxClientData *cd = (wxClientData*) node->Data();
-    if (cd) delete cd;
+    // wxItemContainer already deletes data for us

 
     node->SetData( (wxObject*) clientData );
 }
 
 
     node->SetData( (wxObject*) clientData );
 }
 

-wxClientData* wxComboBox::GetClientObject( int n )
+wxClientData* wxComboBox::DoGetItemClientObject(unsigned int n) const

 {
     wxCHECK_MSG( m_widget != NULL, (wxClientData*)NULL, wxT("invalid combobox") );
 
 {
     wxCHECK_MSG( m_widget != NULL, (wxClientData*)NULL, wxT("invalid combobox") );
 

-    wxNode *node = m_clientDataList.Nth( n );
-    if (!node) return (wxClientData*) NULL;
+    wxList::compatibility_iterator node = m_clientObjectList.Item( n );

 
 

-    return (wxClientData*) node->Data();
+    return node ? (wxClientData*) node->GetData() : NULL;

 }
 
 void wxComboBox::Clear()
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 
 }
 
 void wxComboBox::Clear()
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 

-    GtkWidget *list = GTK_COMBO(m_widget)->list;
-    gtk_list_clear_items( GTK_LIST(list), 0, Number() );
+    DisableEvents();

 
 

-    wxNode *node = m_clientObjectList.First();
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+    {
+        GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+        const unsigned int count = GetCount();
+        for (unsigned int i = 0; i < count; i++)
+            gtk_combo_box_remove_text( combobox, 0 );
+    }
+    else // GTK+ < 2.4.0
+#endif // __WXGTK24__
+    {
+        GtkWidget *list = GTK_COMBO(m_widget)->list;
+        gtk_list_clear_items( GTK_LIST(list), 0, GetCount() );
+    }
+
+    wxList::compatibility_iterator node = m_clientObjectList.GetFirst();

     while (node)
     {
     while (node)
     {

-        wxClientData *cd = (wxClientData*)node->Data();
-        if (cd) delete cd;
-        node = node->Next();
+        wxClientData *cd = (wxClientData*)node->GetData();
+        delete cd;
+        node = node->GetNext();

     }
     m_clientObjectList.Clear();
 
     m_clientDataList.Clear();
     }
     m_clientObjectList.Clear();
 
     m_clientDataList.Clear();

+
+    EnableEvents();
+
+    InvalidateBestSize();

 }
 
 }
 

-void wxComboBox::Delete( int n )
+void wxComboBox::Delete(unsigned int n)

 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 

-    GtkList *listbox = GTK_LIST( GTK_COMBO(m_widget)->list );
-
-    GList *child = g_list_nth( listbox->children, n );
-
-    if (!child)
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))

     {
     {

-        wxFAIL_MSG(wxT("wrong index"));
-        return;
+        wxCHECK_RET( IsValid(n), wxT("invalid index") );
+
+        GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+        gtk_combo_box_remove_text( combobox, n );

     }
     }

+    else
+#endif
+    {
+        GtkList *listbox = GTK_LIST( GTK_COMBO(m_widget)->list );
+
+        GList *child = g_list_nth( listbox->children, n );
+
+        if (!child)
+        {
+            wxFAIL_MSG(wxT("wrong index"));
+            return;
+        }
+
+        DisableEvents();

 
 

-    GList *list = g_list_append( (GList*) NULL, child->data );
-    gtk_list_remove_items( listbox, list );
-    g_list_free( list );
+        GList *list = g_list_append( (GList*) NULL, child->data );
+        gtk_list_remove_items( listbox, list );
+        g_list_free( list );

 
 

-    wxNode *node = m_clientObjectList.Nth( n );
+        EnableEvents();
+    }
+
+    wxList::compatibility_iterator node = m_clientObjectList.Item( n );

     if (node)
     {
     if (node)
     {

-        wxClientData *cd = (wxClientData*)node->Data();
+        wxClientData *cd = (wxClientData*)node->GetData();

         if (cd) delete cd;
         if (cd) delete cd;

-        m_clientObjectList.DeleteNode( node );
+        m_clientObjectList.Erase( node );

     }
 
     }
 

-    node = m_clientDataList.Nth( n );
+    node = m_clientDataList.Item( n );

     if (node)
     if (node)

-    {
-        m_clientDataList.DeleteNode( node );
-    }
+        m_clientDataList.Erase( node );
+
+    InvalidateBestSize();

 }
 
 }
 

-int wxComboBox::FindString( const wxString &item )
+void wxComboBox::SetString(unsigned int n, const wxString &text)

 {
 {

-    wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid combobox") );
+    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );

 
 

-    GtkWidget *list = GTK_COMBO(m_widget)->list;
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+    {
+        GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+        wxCHECK_RET( IsValid(n), wxT("invalid index") );

 
 

-    GList *child = GTK_LIST(list)->children;
-    int count = 0;
-    while (child)
+        GtkTreeModel *model = gtk_combo_box_get_model( combobox );
+        GtkTreeIter iter;
+        if (gtk_tree_model_iter_nth_child (model, &iter, NULL, n))
+        {
+            GValue value = { 0, };
+            g_value_init( &value, G_TYPE_STRING );
+            g_value_set_string( &value, wxGTK_CONV( text ) );
+            gtk_list_store_set_value( GTK_LIST_STORE(model), &iter, 0, &value );
+            g_value_unset( &value );
+        }
+    }
+    else
+#endif

     {
     {

-        GtkBin *bin = GTK_BIN( child->data );
-        GtkLabel *label = GTK_LABEL( bin->child );
-        if (item == wxString(label->label,*wxConvCurrent))
-            return count;
-        count++;
-        child = child->next;
+        GtkWidget *list = GTK_COMBO(m_widget)->list;
+
+        GList *child = g_list_nth( GTK_LIST(list)->children, n );
+        if (child)
+        {
+            GtkBin *bin = GTK_BIN( child->data );
+            GtkLabel *label = GTK_LABEL( bin->child );
+            gtk_label_set_text(label, wxGTK_CONV(text));
+        }
+        else
+        {
+            wxFAIL_MSG( wxT("wxComboBox: wrong index") );
+        }

     }
 
     }
 

-    return wxNOT_FOUND;
+    InvalidateBestSize();

 }
 
 }
 

-int wxComboBox::GetSelection() const
+int wxComboBox::FindString( const wxString &item, bool bCase ) const

 {
 {

-    wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid combobox") );
+    wxCHECK_MSG( m_widget != NULL, wxNOT_FOUND, wxT("invalid combobox") );
+
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+    {
+        GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+        GtkTreeModel* model = gtk_combo_box_get_model( combobox );
+        GtkTreeIter iter;
+        gtk_tree_model_get_iter_first( model, &iter );
+        if (!gtk_list_store_iter_is_valid(GTK_LIST_STORE(model), &iter ))
+            return -1;
+        int count = 0;
+        do
+        {
+            GValue value = { 0, };
+            gtk_tree_model_get_value( model, &iter, 0, &value );
+            wxString str = wxGTK_CONV_BACK( g_value_get_string( &value ) );
+            g_value_unset( &value );
+
+            if (item.IsSameAs( str, bCase ) )
+                return count;

 
 

-    GtkWidget *list = GTK_COMBO(m_widget)->list;
+            count++;

 
 

-    GList *selection = GTK_LIST(list)->selection;
-    if (selection)
+        } while (gtk_tree_model_iter_next( model, &iter ));
+    }
+    else
+#endif

     {
     {

+        GtkWidget *list = GTK_COMBO(m_widget)->list;
+

         GList *child = GTK_LIST(list)->children;
         int count = 0;
         while (child)
         {
         GList *child = GTK_LIST(list)->children;
         int count = 0;
         while (child)
         {

-            if (child->data == selection->data) return count;
+            GtkBin *bin = GTK_BIN( child->data );
+            GtkLabel *label = GTK_LABEL( bin->child );
+            wxString str( wxGTK_CONV_BACK( gtk_label_get_text(label) ) );
+
+            if (item.IsSameAs( str , bCase ) )
+                return count;
+

             count++;
             child = child->next;
         }
     }
 
             count++;
             child = child->next;
         }
     }
 

-    return -1;
+    return wxNOT_FOUND;

 }
 
 }
 

-wxString wxComboBox::GetString( int n ) const
+int wxComboBox::GetSelection() const
+{
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+    {
+        GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+        return gtk_combo_box_get_active( combobox );
+    }
+    else
+#endif
+        // if the popup is currently opened, use the selection as it had been
+        // before it dropped down
+        return g_SelectionBeforePopup == wxID_NONE ? GetCurrentSelection()
+                                               : g_SelectionBeforePopup;
+}
+
+int wxComboBox::GetCurrentSelection() const

 {
 {

-    wxCHECK_MSG( m_widget != NULL, wxT(""), wxT("invalid combobox") );
+    wxCHECK_MSG( m_widget != NULL, -1, wxT("invalid combobox") );
+
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+    {
+        GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+        return gtk_combo_box_get_active( combobox );
+    }
+    else
+#endif
+    {
+        GtkWidget *list = GTK_COMBO(m_widget)->list;

 
 

-    GtkWidget *list = GTK_COMBO(m_widget)->list;
+        GList *selection = GTK_LIST(list)->selection;
+        if (selection)
+        {
+            GList *child = GTK_LIST(list)->children;
+            int count = 0;
+            while (child)
+            {
+                if (child->data == selection->data) return count;
+                count++;
+                child = child->next;
+            }
+        }
+    }
+
+    return -1;
+}
+
+wxString wxComboBox::GetString(unsigned int n) const
+{
+    wxCHECK_MSG( m_widget != NULL, wxEmptyString, wxT("invalid combobox") );

 
     wxString str;
 
     wxString str;

-    GList *child = g_list_nth( GTK_LIST(list)->children, n );
-    if (child)
+
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))

     {
     {

-        GtkBin *bin = GTK_BIN( child->data );
-        GtkLabel *label = GTK_LABEL( bin->child );
-        str = wxString(label->label,*wxConvCurrent);
+        GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+        GtkTreeModel *model = gtk_combo_box_get_model( combobox );
+        GtkTreeIter iter;
+        if (gtk_tree_model_iter_nth_child (model, &iter, NULL, n))
+        {
+            GValue value = { 0, };
+            gtk_tree_model_get_value( model, &iter, 0, &value );
+            wxString tmp = wxGTK_CONV_BACK( g_value_get_string( &value ) );
+            g_value_unset( &value );
+            return tmp;
+        }

     }
     else
     }
     else

+#endif

     {
     {

-        wxFAIL_MSG( wxT("wxComboBox: wrong index") );
+        GtkWidget *list = GTK_COMBO(m_widget)->list;
+
+        GList *child = g_list_nth( GTK_LIST(list)->children, n );
+        if (child)
+        {
+            GtkBin *bin = GTK_BIN( child->data );
+            GtkLabel *label = GTK_LABEL( bin->child );
+            str = wxGTK_CONV_BACK( gtk_label_get_text(label) );
+        }
+        else
+        {
+            wxFAIL_MSG( wxT("wxComboBox: wrong index") );
+        }

     }
 
     return str;
     }
 
     return str;


@@ -391,33 +831,71 @@ wxString wxComboBox::GetString( int n ) const
 
 wxString wxComboBox::GetStringSelection() const
 {
 
 wxString wxComboBox::GetStringSelection() const
 {

-    wxCHECK_MSG( m_widget != NULL, wxT(""), wxT("invalid combobox") );
-
-    GtkWidget *list = GTK_COMBO(m_widget)->list;
+    wxCHECK_MSG( m_widget != NULL, wxEmptyString, wxT("invalid combobox") );

 
 

-    GList *selection = GTK_LIST(list)->selection;
-    if (selection)
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))

     {
     {

-        GtkBin *bin = GTK_BIN( selection->data );
-        wxString tmp = wxString(GTK_LABEL( bin->child )->label,*wxConvCurrent);
-        return tmp;
+        GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+        int sel = gtk_combo_box_get_active( combobox );
+        if (sel == -1)
+            return wxEmptyString;
+        return GetString(sel);

     }
     }

+    else
+#endif
+    {
+        GtkWidget *list = GTK_COMBO(m_widget)->list;

 
 

-    wxFAIL_MSG( wxT("wxComboBox: no selection") );
+        GList *selection = GTK_LIST(list)->selection;
+        if (selection)
+        {
+            GtkBin *bin = GTK_BIN( selection->data );
+            GtkLabel *label = GTK_LABEL( bin->child );
+            wxString tmp( wxGTK_CONV_BACK( gtk_label_get_text(label) ) );
+            return tmp;
+        }
+
+        wxFAIL_MSG( wxT("wxComboBox: no selection") );
+    }

 
 

-    return wxT("");
+    return wxEmptyString;

 }
 
 }
 

-int wxComboBox::Number() const
+unsigned int wxComboBox::GetCount() const

 {
     wxCHECK_MSG( m_widget != NULL, 0, wxT("invalid combobox") );
 
 {
     wxCHECK_MSG( m_widget != NULL, 0, wxT("invalid combobox") );
 

-    GtkWidget *list = GTK_COMBO(m_widget)->list;
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+    {
+        GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+        GtkTreeModel* model = gtk_combo_box_get_model( combobox );
+        GtkTreeIter iter;
+        gtk_tree_model_get_iter_first( model, &iter );
+        if (!gtk_list_store_iter_is_valid(GTK_LIST_STORE(model), &iter ))
+            return 0;
+        unsigned int ret = 1;
+        while (gtk_tree_model_iter_next( model, &iter ))
+            ret++;
+        return ret;
+    }
+    else
+#endif
+    {
+        GtkWidget *list = GTK_COMBO(m_widget)->list;

 
 

-    GList *child = GTK_LIST(list)->children;
-    int count = 0;
-    while (child) { count++; child = child->next; }
-    return count;
+        GList *child = GTK_LIST(list)->children;
+        unsigned int count = 0;
+        while (child)
+        {
+            count++;
+            child = child->next;
+        }
+        return count;
+    }
+
+    return 0;

 }
 
 void wxComboBox::SetSelection( int n )
 }
 
 void wxComboBox::SetSelection( int n )


@@ -426,25 +904,45 @@ void wxComboBox::SetSelection( int n )
 
     DisableEvents();
 
 
     DisableEvents();
 

-    GtkWidget *list = GTK_COMBO(m_widget)->list;
-    gtk_list_select_item( GTK_LIST(list), n );
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+    {
+        GtkComboBox* combobox = GTK_COMBO_BOX( m_widget );
+        gtk_combo_box_set_active( combobox, n );
+    }
+    else
+#endif
+    {
+        GtkWidget *list = GTK_COMBO(m_widget)->list;
+        gtk_list_unselect_item( GTK_LIST(list), m_prevSelection );
+        gtk_list_select_item( GTK_LIST(list), n );
+        m_prevSelection = n;
+    }

 
     EnableEvents();
 }
 
 
     EnableEvents();
 }
 

-void wxComboBox::SetStringSelection( const wxString &string )
+wxString wxComboBox::GetValue() const

 {
 {

-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+    GtkEntry *entry = NULL;
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+        entry = GTK_ENTRY( GTK_BIN(m_widget)->child );
+    else
+#endif
+        entry = GTK_ENTRY( GTK_COMBO(m_widget)->entry );

 
 

-    int res = FindString( string );
-    if (res == -1) return;
-    SetSelection( res );
-}
+    wxString tmp( wxGTK_CONV_BACK( gtk_entry_get_text( entry ) ) );
+
+#if 0
+    for (int i = 0; i < wxStrlen(tmp.c_str()) +1; i++)
+    {
+        wxChar c = tmp[i];
+        printf( "%d ", (int) (c) );
+    }
+    printf( "\n" );
+#endif

 
 

-wxString wxComboBox::GetValue() const
-{
-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    wxString tmp = wxString(gtk_entry_get_text( GTK_ENTRY(entry) ),*wxConvCurrent);

     return tmp;
 }
 
     return tmp;
 }
 


@@ -452,141 +950,269 @@ void wxComboBox::SetValue( const wxString& value )
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 

-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    wxString tmp = wxT("");
+    GtkEntry *entry = NULL;
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+        entry = GTK_ENTRY( GTK_BIN(m_widget)->child );
+    else
+#endif
+        entry = GTK_ENTRY( GTK_COMBO(m_widget)->entry );
+
+    wxString tmp;

     if (!value.IsNull()) tmp = value;
     if (!value.IsNull()) tmp = value;

-    gtk_entry_set_text( GTK_ENTRY(entry), tmp.mbc_str() );
+    gtk_entry_set_text( entry, wxGTK_CONV( tmp ) );
+
+    InvalidateBestSize();

 }
 
 void wxComboBox::Copy()
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 
 }
 
 void wxComboBox::Copy()
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 

-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-#if defined(__WXGTK13__) || (GTK_MINOR_VERSION > 0)
-    gtk_editable_copy_clipboard( GTK_EDITABLE(entry) );
-#else
-    gtk_editable_copy_clipboard( GTK_EDITABLE(entry), 0 );
+    GtkEntry *entry = NULL;
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+        entry = GTK_ENTRY( GTK_BIN(m_widget)->child );
+    else

 #endif
 #endif

+        entry = GTK_ENTRY( GTK_COMBO(m_widget)->entry );
+
+    gtk_editable_copy_clipboard(GTK_EDITABLE(entry));

 }
 
 void wxComboBox::Cut()
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 
 }
 
 void wxComboBox::Cut()
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 

-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-#if defined(__WXGTK13__) || (GTK_MINOR_VERSION > 0)
-    gtk_editable_cut_clipboard( GTK_EDITABLE(entry) );
-#else
-    gtk_editable_cut_clipboard( GTK_EDITABLE(entry), 0 );
+    GtkEntry *entry = NULL;
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+        entry = GTK_ENTRY( GTK_BIN(m_widget)->child );
+    else

 #endif
 #endif

+        entry = GTK_ENTRY( GTK_COMBO(m_widget)->entry );
+
+    gtk_editable_cut_clipboard(GTK_EDITABLE(entry));

 }
 
 void wxComboBox::Paste()
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 
 }
 
 void wxComboBox::Paste()
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 

-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-#if defined(__WXGTK13__) || (GTK_MINOR_VERSION > 0)
-    gtk_editable_paste_clipboard( GTK_EDITABLE(entry) );
-#else
-    gtk_editable_paste_clipboard( GTK_EDITABLE(entry), 0 );
+    GtkEntry *entry = NULL;
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+        entry = GTK_ENTRY( GTK_BIN(m_widget)->child );
+    else

 #endif
 #endif

+        entry = GTK_ENTRY( GTK_COMBO(m_widget)->entry );
+
+    gtk_editable_paste_clipboard(GTK_EDITABLE(entry));

 }
 
 }
 

-void wxComboBox::SetInsertionPoint( long pos )
+void wxComboBox::Undo()

 {
 {

-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+    // TODO
+}
+
+void wxComboBox::Redo()
+{
+    // TODO
+}
+
+void wxComboBox::SelectAll()
+{
+    SetSelection(0, GetLastPosition());
+}
+
+bool wxComboBox::CanUndo() const
+{
+    // TODO
+    return false;
+}
+
+bool wxComboBox::CanRedo() const
+{
+    // TODO
+    return false;
+}
+
+bool wxComboBox::HasSelection() const
+{
+    long from, to;
+    GetSelection(&from, &to);
+    return from != to;
+}

 
 

-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    gtk_entry_set_position( GTK_ENTRY(entry), (int)pos );
+bool wxComboBox::CanCopy() const
+{
+    // Can copy if there's a selection
+    return HasSelection();
+}
+
+bool wxComboBox::CanCut() const
+{
+    return CanCopy() && IsEditable();

 }
 
 }
 

-void wxComboBox::SetInsertionPointEnd()
+bool wxComboBox::CanPaste() const
+{
+    // TODO: check for text on the clipboard
+    return IsEditable() ;
+}
+
+bool wxComboBox::IsEditable() const
+{
+    return !HasFlag(wxCB_READONLY);
+}
+
+
+void wxComboBox::SetInsertionPoint( long pos )

 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
 

-    SetInsertionPoint( -1 );
+    if ( pos == GetLastPosition() )
+        pos = -1;
+
+    GtkEntry *entry = NULL;
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+        entry = GTK_ENTRY( GTK_BIN(m_widget)->child );
+    else
+#endif
+        entry = GTK_ENTRY( GTK_COMBO(m_widget)->entry );
+
+    gtk_entry_set_position( entry, (int)pos );

 }
 
 long wxComboBox::GetInsertionPoint() const
 {
 }
 
 long wxComboBox::GetInsertionPoint() const
 {

-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    return (long) GTK_EDITABLE(entry)->current_pos;
+    GtkEntry *entry = NULL;
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+        entry = GTK_ENTRY( GTK_BIN(m_widget)->child );
+    else
+#endif
+        entry = GTK_ENTRY( GTK_COMBO(m_widget)->entry );
+
+    return (long) gtk_editable_get_position(GTK_EDITABLE(entry));

 }
 
 }
 

-long wxComboBox::GetLastPosition() const
+wxTextPos wxComboBox::GetLastPosition() const

 {
 {

-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    int pos = GTK_ENTRY(entry)->text_length;
+    GtkEntry *entry = NULL;
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+        entry = GTK_ENTRY( GTK_BIN(m_widget)->child );
+    else
+#endif
+        entry = GTK_ENTRY( GTK_COMBO(m_widget)->entry );
+
+    int pos = entry->text_length;

     return (long) pos-1;
 }
 
 void wxComboBox::Replace( long from, long to, const wxString& value )
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
     return (long) pos-1;
 }
 
 void wxComboBox::Replace( long from, long to, const wxString& value )
 {
     wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );

-    // FIXME: not quite sure how to do this method right in multibyte mode

 
 

-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
+    GtkEntry *entry = NULL;
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+        entry = GTK_ENTRY( GTK_BIN(m_widget)->child );
+    else
+#endif
+        entry = GTK_ENTRY( GTK_COMBO(m_widget)->entry );
+

     gtk_editable_delete_text( GTK_EDITABLE(entry), (gint)from, (gint)to );
     if (value.IsNull()) return;
     gint pos = (gint)to;
     gtk_editable_delete_text( GTK_EDITABLE(entry), (gint)from, (gint)to );
     if (value.IsNull()) return;
     gint pos = (gint)to;

-    gtk_editable_insert_text( GTK_EDITABLE(entry), value.mbc_str(), value.Length(), &pos );
+
+#if wxUSE_UNICODE
+    wxCharBuffer buffer = wxConvUTF8.cWX2MB( value );
+    gtk_editable_insert_text( GTK_EDITABLE(entry), (const char*) buffer, strlen( (const char*) buffer ), &pos );
+#else
+    gtk_editable_insert_text( GTK_EDITABLE(entry), value.c_str(), value.length(), &pos );
+#endif

 }
 
 }
 

-void wxComboBox::Remove(long from, long to)
+void wxComboBox::SetSelection( long from, long to )

 {
 {

-    wxCHECK_RET( m_widget != NULL, wxT("invalid combobox") );
+    GtkEntry *entry = NULL;
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+        entry = GTK_ENTRY( GTK_BIN(m_widget)->child );
+    else
+#endif
+        entry = GTK_ENTRY( GTK_COMBO(m_widget)->entry );

 
 

-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    gtk_editable_delete_text( GTK_EDITABLE(entry), (gint)from, (gint)to );
+    gtk_editable_select_region( GTK_EDITABLE(entry), (gint)from, (gint)to );

 }
 
 }
 

-void wxComboBox::SetSelection( long from, long to )
+void wxComboBox::GetSelection( long* from, long* to ) const

 {
 {

-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
-    gtk_editable_select_region( GTK_EDITABLE(entry), (gint)from, (gint)to );
+    GtkEntry *entry = NULL;
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+        entry = GTK_ENTRY( GTK_BIN(m_widget)->child );
+    else
+#endif
+        entry = GTK_ENTRY( GTK_COMBO(m_widget)->entry );
+
+    if (IsEditable())
+    {
+        GtkEditable *editable = GTK_EDITABLE(entry);
+        gint start, end;
+        gtk_editable_get_selection_bounds(editable, & start, & end);
+        *from = start;
+        *to = end;
+    }

 }
 
 void wxComboBox::SetEditable( bool editable )
 {
 }
 
 void wxComboBox::SetEditable( bool editable )
 {

-    GtkWidget *entry = GTK_COMBO(m_widget)->entry;
+    GtkEntry *entry = NULL;
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+        entry = GTK_ENTRY( GTK_BIN(m_widget)->child );
+    else
+#endif
+        entry = GTK_ENTRY( GTK_COMBO(m_widget)->entry );
+

     gtk_entry_set_editable( GTK_ENTRY(entry), editable );
 }
 
 void wxComboBox::OnChar( wxKeyEvent &event )
 {
     gtk_entry_set_editable( GTK_ENTRY(entry), editable );
 }
 
 void wxComboBox::OnChar( wxKeyEvent &event )
 {

-    if ( event.KeyCode() == WXK_RETURN )
+    if ( event.GetKeyCode() == WXK_RETURN )

     {
     {

-        wxString value = GetValue();
+        // GTK automatically selects an item if its in the list
+        wxCommandEvent eventEnter(wxEVT_COMMAND_TEXT_ENTER, GetId());
+        eventEnter.SetString( GetValue() );
+        eventEnter.SetInt( GetSelection() );
+        eventEnter.SetEventObject( this );

 
 

-        if ( Number() == 0 )
-        {
-            // make Enter generate "selected" event if there is only one item
-            // in the combobox - without it, it's impossible to select it at
-            // all!
-            wxCommandEvent event( wxEVT_COMMAND_COMBOBOX_SELECTED, GetId() );
-            event.SetInt( 0 );
-            event.SetString( value );
-            event.SetEventObject( this );
-            GetEventHandler()->ProcessEvent( event );
-        }
-        else
+        if (!GetEventHandler()->ProcessEvent( eventEnter ))

         {
         {

-            // add the item to the list if it's not there yet
-            if ( FindString(value) == wxNOT_FOUND )
+            // This will invoke the dialog default action, such
+            // as the clicking the default button.
+
+            wxWindow *top_frame = m_parent;
+            while (top_frame->GetParent() && !(top_frame->IsTopLevel()))
+                top_frame = top_frame->GetParent();
+
+            if (top_frame && GTK_IS_WINDOW(top_frame->m_widget))

             {
             {

-                Append(value);
-
-                // and generate the selected event for it
-                wxCommandEvent event( wxEVT_COMMAND_COMBOBOX_SELECTED, GetId() );
-                event.SetInt( Number() - 1 );
-                event.SetString( value );
-                event.SetEventObject( this );
-                GetEventHandler()->ProcessEvent( event );
+                GtkWindow *window = GTK_WINDOW(top_frame->m_widget);
+
+                if (window->default_widget)
+                        gtk_widget_activate (window->default_widget);

             }
             }

-            //else: do nothing, this will open the listbox

         }
         }

+
+        // Catch GTK event so that GTK doesn't open the drop
+        // down list upon RETURN.
+        return;

     }
 
     event.Skip();
     }
 
     event.Skip();


@@ -594,73 +1220,132 @@ void wxComboBox::OnChar( wxKeyEvent &event )
 
 void wxComboBox::DisableEvents()
 {
 
 void wxComboBox::DisableEvents()
 {

-    GtkList *list = GTK_LIST( GTK_COMBO(m_widget)->list );
-    GList *child = list->children;
-    while (child)
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+    {
+        g_signal_handlers_disconnect_by_func (GTK_BIN(m_widget)->child,
+                (gpointer)gtkcombobox_text_changed_callback, this);
+
+        g_signal_handlers_disconnect_by_func (m_widget,
+                (gpointer)gtkcombobox_changed_callback, this);
+    }
+    else
+#endif

     {
     {

-        gtk_signal_disconnect_by_func( GTK_OBJECT(child->data),
-          GTK_SIGNAL_FUNC(gtk_combo_clicked_callback), (gpointer)this );
+        g_signal_handlers_disconnect_by_func (GTK_COMBO(m_widget)->list,
+                (gpointer) gtkcombo_combo_select_child_callback, this);

 
 

-        child = child->next;
+        g_signal_handlers_disconnect_by_func (GTK_COMBO(m_widget)->entry,
+                (gpointer) gtkcombo_text_changed_callback, this);

     }
 }
 
 void wxComboBox::EnableEvents()
 {
     }
 }
 
 void wxComboBox::EnableEvents()
 {

-    GtkList *list = GTK_LIST( GTK_COMBO(m_widget)->list );
-    GList *child = list->children;
-    while (child)
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))

     {
     {

-        gtk_signal_connect( GTK_OBJECT(child->data), "select",
-          GTK_SIGNAL_FUNC(gtk_combo_clicked_callback), (gpointer)this );
+        g_signal_connect_after (GTK_BIN(m_widget)->child, "changed",
+                            G_CALLBACK (gtkcombobox_text_changed_callback), this);

 
 

-        child = child->next;
+        g_signal_connect_after (m_widget, "changed",
+                            G_CALLBACK (gtkcombobox_changed_callback), this);
+    }
+    else
+#endif
+    {
+        g_signal_connect_after (GTK_COMBO(m_widget)->list, "select-child",
+                            G_CALLBACK (gtkcombo_combo_select_child_callback),
+                            this);
+        g_signal_connect_after (GTK_COMBO(m_widget)->entry, "changed",
+                            G_CALLBACK (gtkcombo_text_changed_callback),
+                            this );

     }
 }
 
 void wxComboBox::OnSize( wxSizeEvent &event )
 {
     }
 }
 
 void wxComboBox::OnSize( wxSizeEvent &event )
 {

-    event.Skip();
-
-#if 0
-    int w = 21;
-    gtk_widget_set_usize( GTK_COMBO(m_widget)->entry, m_width-w-1, m_height );
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+    {
+        // Do nothing
+    }
+    else
+#endif
+    {
+        // NB: In some situations (e.g. on non-first page of a wizard, if the
+        //     size used is default size), GtkCombo widget is resized correctly,
+        //     but it's look is not updated, it's rendered as if it was much wider.
+        //     No other widgets are affected, so it looks like a bug in GTK+.
+        //     Manually requesting resize calculation (as gtk_pizza_set_size does)
+        //     fixes it.
+        if (GTK_WIDGET_VISIBLE(m_widget))
+            gtk_widget_queue_resize(m_widget);
+    }

 
 

-    gtk_widget_set_uposition( GTK_COMBO(m_widget)->button, m_x+m_width-w, m_y );
-    gtk_widget_set_usize( GTK_COMBO(m_widget)->button, w, m_height );
-#endif // 0
+    event.Skip();

 }
 
 }
 

-void wxComboBox::ApplyWidgetStyle()
+void wxComboBox::DoApplyWidgetStyle(GtkRcStyle *style)

 {
 {

-    SetWidgetStyle();
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+    {
+        // Do nothing
+    }
+    else
+#endif
+    {
+//    gtk_widget_modify_style( GTK_COMBO(m_widget)->button, syle );

 
 

-//    gtk_widget_set_style( GTK_COMBO(m_widget)->button, m_widgetStyle );
-    gtk_widget_set_style( GTK_COMBO(m_widget)->entry, m_widgetStyle );
-    gtk_widget_set_style( GTK_COMBO(m_widget)->list, m_widgetStyle );
+        gtk_widget_modify_style( GTK_COMBO(m_widget)->entry, style );
+        gtk_widget_modify_style( GTK_COMBO(m_widget)->list, style );

 
 

-    GtkList *list = GTK_LIST( GTK_COMBO(m_widget)->list );
-    GList *child = list->children;
-    while (child)
-    {
-        gtk_widget_set_style( GTK_WIDGET(child->data), m_widgetStyle );
+        GtkList *list = GTK_LIST( GTK_COMBO(m_widget)->list );
+        GList *child = list->children;
+        while (child)
+        {
+            gtk_widget_modify_style( GTK_WIDGET(child->data), style );

 
 

-        GtkBin *bin = GTK_BIN(child->data);
-        gtk_widget_set_style( bin->child, m_widgetStyle );
+            GtkBin *bin = GTK_BIN(child->data);
+            gtk_widget_modify_style( bin->child, style );

 
 

-        child = child->next;
+            child = child->next;
+        }

     }
 }
 
 GtkWidget* wxComboBox::GetConnectWidget()
 {
     }
 }
 
 GtkWidget* wxComboBox::GetConnectWidget()
 {

-    return GTK_COMBO(m_widget)->entry;
+    GtkEntry *entry = NULL;
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+        entry = GTK_ENTRY( GTK_BIN(m_widget)->child );
+    else
+#endif
+        entry = GTK_ENTRY( GTK_COMBO(m_widget)->entry );
+
+    return GTK_WIDGET( entry );

 }
 
 }
 

-bool wxComboBox::IsOwnGtkWindow( GdkWindow *window )
+GdkWindow *wxComboBox::GTKGetWindow(wxArrayGdkWindows& windows) const

 {
 {

-    return ( (window == GTK_ENTRY( GTK_COMBO(m_widget)->entry )->text_area) ||
-             (window == GTK_COMBO(m_widget)->button->window ) );
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+    {
+        wxUnusedVar(windows);
+
+        return GTK_ENTRY(GTK_BIN(m_widget)->child)->text_area;
+    }
+    else
+#endif // GTK+ 2.4
+    {
+        windows.push_back(GTK_ENTRY(GTK_COMBO(m_widget)->entry)->text_area);
+        windows.push_back(GTK_COMBO(m_widget)->button->window);
+
+        // indicate that we return multiple windows in the windows array
+        return NULL;
+    }

 }
 
 wxSize wxComboBox::DoGetBestSize() const
 }
 
 wxSize wxComboBox::DoGetBestSize() const


@@ -669,16 +1354,13 @@ wxSize wxComboBox::DoGetBestSize() const
 
     // we know better our horizontal extent: it depends on the longest string
     // in the combobox
 
     // we know better our horizontal extent: it depends on the longest string
     // in the combobox

-    ret.x = 0;

     if ( m_widget )
     {
     if ( m_widget )
     {

-        GdkFont *font = m_font.GetInternalFont();
-
-        wxCoord width;
-        size_t count = Number();
-        for ( size_t n = 0; n < count; n++ )
+        int width;
+        unsigned int count = GetCount();
+        for ( unsigned int n = 0; n < count; n++ )

         {
         {

-            width = (wxCoord)gdk_string_width(font, GetString(n).mbc_str());
+            GetTextExtent(GetString(n), &width, NULL, NULL, NULL );

             if ( width > ret.x )
                 ret.x = width;
         }
             if ( width > ret.x )
                 ret.x = width;
         }


@@ -687,7 +1369,98 @@ wxSize wxComboBox::DoGetBestSize() const
     // empty combobox should have some reasonable default size too
     if ( ret.x < 100 )
         ret.x = 100;
     // empty combobox should have some reasonable default size too
     if ( ret.x < 100 )
         ret.x = 100;

+
+    CacheBestSize(ret);

     return ret;
 }
 
     return ret;
 }
 

+// static
+wxVisualAttributes
+wxComboBox::GetClassDefaultAttributes(wxWindowVariant WXUNUSED(variant))
+{
+#ifdef __WXGTK24__
+    if (!gtk_check_version(2,4,0))
+        return GetDefaultAttributesFromGTKWidget(gtk_combo_box_entry_new, true);
+    else
+#endif
+        return GetDefaultAttributesFromGTKWidget(gtk_combo_new, true);
+}
+
+// ----------------------------------------------------------------------------
+// standard event handling
+// ----------------------------------------------------------------------------
+
+void wxComboBox::OnCut(wxCommandEvent& WXUNUSED(event))
+{
+    Cut();
+}
+
+void wxComboBox::OnCopy(wxCommandEvent& WXUNUSED(event))
+{
+    Copy();
+}
+
+void wxComboBox::OnPaste(wxCommandEvent& WXUNUSED(event))
+{
+    Paste();
+}
+
+void wxComboBox::OnUndo(wxCommandEvent& WXUNUSED(event))
+{
+    Undo();
+}
+
+void wxComboBox::OnRedo(wxCommandEvent& WXUNUSED(event))
+{
+    Redo();
+}
+
+void wxComboBox::OnDelete(wxCommandEvent& WXUNUSED(event))
+{
+    long from, to;
+    GetSelection(& from, & to);
+    if (from != -1 && to != -1)
+        Remove(from, to);
+}
+
+void wxComboBox::OnSelectAll(wxCommandEvent& WXUNUSED(event))
+{
+    SetSelection(-1, -1);
+}
+
+void wxComboBox::OnUpdateCut(wxUpdateUIEvent& event)
+{
+    event.Enable( CanCut() );
+}
+
+void wxComboBox::OnUpdateCopy(wxUpdateUIEvent& event)
+{
+    event.Enable( CanCopy() );
+}
+
+void wxComboBox::OnUpdatePaste(wxUpdateUIEvent& event)
+{
+    event.Enable( CanPaste() );
+}
+
+void wxComboBox::OnUpdateUndo(wxUpdateUIEvent& event)
+{
+    event.Enable( CanUndo() );
+}
+
+void wxComboBox::OnUpdateRedo(wxUpdateUIEvent& event)
+{
+    event.Enable( CanRedo() );
+}
+
+void wxComboBox::OnUpdateDelete(wxUpdateUIEvent& event)
+{
+    event.Enable(HasSelection() && IsEditable()) ;
+}
+
+void wxComboBox::OnUpdateSelectAll(wxUpdateUIEvent& event)
+{
+    event.Enable(GetLastPosition() > 0);
+}
+

 #endif
 #endif