2 warnings from Solaris build log fixed

[wxWidgets.git] / src / common / wincmn.cpp

diff --git a/src/common/wincmn.cpp b/src/common/wincmn.cpp
index 7af94827f8e059b9553afb5925111f753c752076..a45c841cbdf1db1cfae86d02d79e1660dfab1d63 100644 (file)
--- a/src/common/wincmn.cpp
+++ b/src/common/wincmn.cpp
@@ -37,6 +37,7 @@
     #include "wx/window.h"
     #include "wx/checkbox.h"
     #include "wx/radiobut.h"
     #include "wx/window.h"
     #include "wx/checkbox.h"
     #include "wx/radiobut.h"

+    #include "wx/textctrl.h"

     #include "wx/settings.h"
     #include "wx/dialog.h"
 #endif //WX_PRECOMP
     #include "wx/settings.h"
     #include "wx/dialog.h"
 #endif //WX_PRECOMP


@@ -117,9 +118,14 @@ void wxWindowBase::InitBase()
     wxSystemSettings settings;
 
     m_backgroundColour = settings.GetSystemColour(wxSYS_COLOUR_BTNFACE);
     wxSystemSettings settings;
 
     m_backgroundColour = settings.GetSystemColour(wxSYS_COLOUR_BTNFACE);

-    m_foregroundColour = *wxBLACK;  // TODO take this from sys settings too?
-    m_font = *wxSWISS_FONT;         //      and this?
+    // m_foregroundColour = *wxBLACK;  // TODO take this from sys settings too?
+    m_foregroundColour = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_WINDOWTEXT);

 
 

+#if !defined(__WXMAC__) && !defined(__WXGTK__)
+    m_font = *wxSWISS_FONT;         //      and this?
+#else
+       m_font = settings.GetSystemFont(wxSYS_DEFAULT_GUI_FONT);
+#endif

     // no style bits
     m_windowStyle = 0;
 
     // no style bits
     m_windowStyle = 0;
 


@@ -168,7 +174,10 @@ bool wxWindowBase::CreateBase(wxWindowBase *parent,
     SetName(name);
     SetWindowStyleFlag(style);
     SetParent(parent);
     SetName(name);
     SetWindowStyleFlag(style);
     SetParent(parent);

+
+#if wxUSE_VALIDATORS

     SetValidator(validator);
     SetValidator(validator);

+#endif // wxUSE_VALIDATORS

 
     return TRUE;
 }
 
     return TRUE;
 }


@@ -292,7 +301,7 @@ bool wxWindowBase::DestroyChildren()
 }
 
 // ----------------------------------------------------------------------------
 }
 
 // ----------------------------------------------------------------------------

-// centre/fit the window
+// size/position related methods

 // ----------------------------------------------------------------------------
 
 // centre the window with respect to its parent in either (or both) directions
 // ----------------------------------------------------------------------------
 
 // centre the window with respect to its parent in either (or both) directions


@@ -344,42 +353,62 @@ void wxWindowBase::Centre(int direction)
         yNew += posParent.y;
     }
 
         yNew += posParent.y;
     }
 

+    // move the centre of this window to this position

     Move(xNew, yNew);
 }
 
 // fits the window around the children
 void wxWindowBase::Fit()
 {
     Move(xNew, yNew);
 }
 
 // fits the window around the children
 void wxWindowBase::Fit()
 {

-    int maxX = 0,
-        maxY = 0;
+    if ( GetChildren().GetCount() > 0 )
+    {
+        SetClientSize(DoGetBestSize());
+    }
+    //else: do nothing if we have no children
+}

 
 

-    for ( wxWindowList::Node *node = GetChildren().GetFirst();
-          node;
-          node = node->GetNext() )
+// return the size best suited for the current window
+wxSize wxWindowBase::DoGetBestSize() const
+{
+    if ( GetChildren().GetCount() > 0 )

     {
     {

-        wxWindow *win = node->GetData();
-        if ( win->IsTopLevel() )
+        // our minimal acceptable size is such that all our windows fit inside
+        int maxX = 0,
+            maxY = 0;
+
+        for ( wxWindowList::Node *node = GetChildren().GetFirst();
+              node;
+              node = node->GetNext() )

         {
         {

-            // dialogs and frames lie in different top level windows - don't
-            // deal with them here
-            continue;
+            wxWindow *win = node->GetData();
+            if ( win->IsTopLevel() )
+            {
+                // dialogs and frames lie in different top level windows -
+                // don't deal with them here
+                continue;
+            }
+
+            int wx, wy, ww, wh;
+            win->GetPosition(&wx, &wy);
+            win->GetSize(&ww, &wh);
+            if ( wx + ww > maxX )
+                maxX = wx + ww;
+            if ( wy + wh > maxY )
+                maxY = wy + wh;

         }
 
         }
 

-        int wx, wy, ww, wh;
-        win->GetPosition(&wx, &wy);
-        win->GetSize(&ww, &wh);
-        if ( wx + ww > maxX )
-            maxX = wx + ww;
-        if ( wy + wh > maxY )
-            maxY = wy + wh;
+        // leave a margin
+        return wxSize(maxX + 7, maxY + 14);
+    }
+    else
+    {
+        // for a generic window there is no natural best size - just use the
+        // current one
+        return GetSize();

     }
     }

-
-    // leave a margin
-    SetClientSize(maxX + 7, maxY + 14);

 }
 
 // set the min/max size of the window
 }
 
 // set the min/max size of the window

-

 void wxWindowBase::SetSizeHints(int minW, int minH,
                                 int maxW, int maxH,
                                 int WXUNUSED(incW), int WXUNUSED(incH))
 void wxWindowBase::SetSizeHints(int minW, int minH,
                                 int maxW, int maxH,
                                 int WXUNUSED(incW), int WXUNUSED(incH))


@@ -893,28 +922,38 @@ void wxWindowBase::SetSizer(wxSizer *sizer)
 
 bool wxWindowBase::Layout()
 {
 
 bool wxWindowBase::Layout()
 {

-    int w, h;
-    GetClientSize(&w, &h);
-    

     // If there is a sizer, use it instead of the constraints
     if ( GetSizer() )
     {
     // If there is a sizer, use it instead of the constraints
     if ( GetSizer() )
     {

+        int w, h;
+        GetClientSize(&w, &h);
+

         GetSizer()->SetDimension( 0, 0, w, h );
         GetSizer()->SetDimension( 0, 0, w, h );

-        return TRUE;

     }
     }

-    
-    if ( GetConstraints() )
+    else

     {
     {

-        GetConstraints()->width.SetValue(w);
-        GetConstraints()->height.SetValue(h);
+        wxLayoutConstraints *constr = GetConstraints();
+        bool wasOk = constr && constr->AreSatisfied();
+
+        ResetConstraints();   // Mark all constraints as unevaluated
+
+        // if we're a top level panel (i.e. our parent is frame/dialog), our
+        // own constraints will never be satisfied any more unless we do it
+        // here
+        if ( wasOk )
+        {
+            int noChanges = 1;
+            while ( noChanges > 0 )
+            {
+                constr->SatisfyConstraints(this, &noChanges);
+            }
+        }
+
+        DoPhase(1);           // Layout children
+        DoPhase(2);           // Layout grand children
+        SetConstraintSizes(); // Recursively set the real window sizes

     }
     }

-       
-    // Evaluate child constraints
-    ResetConstraints();   // Mark all constraints as unevaluated
-    DoPhase(1);           // Just one phase need if no sizers involved
-    DoPhase(2);
-    SetConstraintSizes(); // Recursively set the real window sizes
-    
+

     return TRUE;
 }
 
     return TRUE;
 }
 


@@ -999,6 +1038,7 @@ void wxWindowBase::ResetConstraints()
         constr->centreX.SetDone(FALSE);
         constr->centreY.SetDone(FALSE);
     }
         constr->centreX.SetDone(FALSE);
         constr->centreY.SetDone(FALSE);
     }

+

     wxWindowList::Node *node = GetChildren().GetFirst();
     while (node)
     {
     wxWindowList::Node *node = GetChildren().GetFirst();
     while (node)
     {


@@ -1014,8 +1054,7 @@ void wxWindowBase::ResetConstraints()
 void wxWindowBase::SetConstraintSizes(bool recurse)
 {
     wxLayoutConstraints *constr = GetConstraints();
 void wxWindowBase::SetConstraintSizes(bool recurse)
 {
     wxLayoutConstraints *constr = GetConstraints();

-    if ( constr && constr->left.GetDone() && constr->right.GetDone( ) &&
-            constr->width.GetDone() && constr->height.GetDone())
+    if ( constr && constr->AreSatisfied() )

     {
         int x = constr->left.GetValue();
         int y = constr->top.GetValue();
     {
         int x = constr->left.GetValue();
         int y = constr->top.GetValue();


@@ -1035,21 +1074,9 @@ void wxWindowBase::SetConstraintSizes(bool recurse)
     }
     else if ( constr )
     {
     }
     else if ( constr )
     {

-        wxChar *windowClass = GetClassInfo()->GetClassName();
-
-        wxString winName;
-        if ( GetName() == wxT("") )
-            winName = wxT("unnamed");
-        else
-            winName = GetName();
-        wxLogDebug( wxT("Constraint(s) not satisfied for window of type %s, name %s:\n"),
-                (const wxChar *)windowClass,
-                (const wxChar *)winName);
-        if ( !constr->left.GetDone()) wxLogDebug( wxT("  unsatisfied 'left' constraint.\n")  );
-        if ( !constr->right.GetDone()) wxLogDebug( wxT("  unsatisfied 'right' constraint.\n")  );
-        if ( !constr->width.GetDone()) wxLogDebug( wxT("  unsatisfied 'width' constraint.\n")  );
-        if ( !constr->height.GetDone())  wxLogDebug( wxT("  unsatisfied 'height' constraint.\n")  );
-        wxLogDebug( wxT("Please check constraints: try adding AsIs() constraints.\n") );
+        wxLogDebug(wxT("Constraints not satisfied for %s named '%s'."),
+                   GetClassInfo()->GetClassName(),
+                   GetName().c_str());

     }
 
     if ( recurse )
     }
 
     if ( recurse )


@@ -1160,42 +1187,44 @@ void wxWindowBase::GetPositionConstraint(int *x, int *y) const
 // of control classes.
 void wxWindowBase::UpdateWindowUI()
 {
 // of control classes.
 void wxWindowBase::UpdateWindowUI()
 {

-    wxWindowID id = GetId();
-    if ( id > 0 )
+    wxUpdateUIEvent event(GetId());
+    event.m_eventObject = this;
+
+    if ( GetEventHandler()->ProcessEvent(event) )

     {
     {

-        wxUpdateUIEvent event(id);
-        event.m_eventObject = this;
+        if ( event.GetSetEnabled() )
+            Enable(event.GetEnabled());

 
 

-        if ( GetEventHandler()->ProcessEvent(event) )
+        if ( event.GetSetText() )

         {
         {

-            if ( event.GetSetEnabled() )
-                Enable(event.GetEnabled());
-
-            if ( event.GetSetText() )
+            wxControl *control = wxDynamicCast(this, wxControl);
+            if ( control )

             {
             {

-                wxControl *control = wxDynamicCast(this, wxControl);
-                if ( control )
+                wxTextCtrl *text = wxDynamicCast(control, wxTextCtrl);
+                if ( text )
+                    text->SetValue(event.GetText());
+                else

                     control->SetLabel(event.GetText());
             }
                     control->SetLabel(event.GetText());
             }

+        }

 
 #if wxUSE_CHECKBOX
 
 #if wxUSE_CHECKBOX

-            wxCheckBox *checkbox = wxDynamicCast(this, wxCheckBox);
-            if ( checkbox )
-            {
-                if ( event.GetSetChecked() )
-                    checkbox->SetValue(event.GetChecked());
-            }
+        wxCheckBox *checkbox = wxDynamicCast(this, wxCheckBox);
+        if ( checkbox )
+        {
+            if ( event.GetSetChecked() )
+                checkbox->SetValue(event.GetChecked());
+        }

 #endif // wxUSE_CHECKBOX
 
 #endif // wxUSE_CHECKBOX
 

-#if wxUSE_RADIOBUTTON
-            wxRadioButton *radiobtn = wxDynamicCast(this, wxRadioButton);
-            if ( radiobtn )
-            {
-                if ( event.GetSetChecked() )
-                    radiobtn->SetValue(event.GetChecked());
-            }
-#endif // wxUSE_RADIOBUTTON
+#if wxUSE_RADIOBTN
+        wxRadioButton *radiobtn = wxDynamicCast(this, wxRadioButton);
+        if ( radiobtn )
+        {
+            if ( event.GetSetChecked() )
+                radiobtn->SetValue(event.GetChecked());

         }
         }

+#endif // wxUSE_RADIOBTN

     }
 }
 
     }
 }
 


@@ -1247,7 +1276,9 @@ void wxWindowBase::DoSetClientObject( wxClientData *data )
 
 wxClientData *wxWindowBase::DoGetClientObject() const
 {
 
 wxClientData *wxWindowBase::DoGetClientObject() const
 {

-    wxASSERT_MSG( m_clientDataType == ClientData_Object,
+    // it's not an error to call GetClientObject() on a window which doesn't
+    // have client data at all - NULL will be returned
+    wxASSERT_MSG( m_clientDataType != ClientData_Void,

                   wxT("this window doesn't have object client data") );
 
     return m_clientObject;
                   wxT("this window doesn't have object client data") );
 
     return m_clientObject;


@@ -1264,7 +1295,9 @@ void wxWindowBase::DoSetClientData( void *data )
 
 void *wxWindowBase::DoGetClientData() const
 {
 
 void *wxWindowBase::DoGetClientData() const
 {

-    wxASSERT_MSG( m_clientDataType == ClientData_Void,
+    // it's not an error to call GetClientData() on a window which doesn't have
+    // client data at all - NULL will be returned
+    wxASSERT_MSG( m_clientDataType != ClientData_Object,

                   wxT("this window doesn't have void client data") );
 
     return m_clientData;
                   wxT("this window doesn't have void client data") );
 
     return m_clientData;